From: Robert Varga <rovarga@cisco.com>
Date: Tue, 20 Sep 2016 12:59:19 +0000 (+0200)
Subject: Eliminate ShardedDOMDataTreeWriteTransaction.doSubmit()'s return
X-Git-Tag: release/carbon~187
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=ada2c265698298bdab0201bb9a2c30af64376a9d;p=mdsal.git

Eliminate ShardedDOMDataTreeWriteTransaction.doSubmit()'s return

Returned future is not used anywhere, hence we can easily remove it.

Change-Id: I4ead4da32d1c2658d5c88f01534b5452230068e7
Signed-off-by: Robert Varga <rovarga@cisco.com>
---

diff --git a/dom/mdsal-dom-broker/src/main/java/org/opendaylight/mdsal/dom/broker/ShardedDOMDataTreeWriteTransaction.java b/dom/mdsal-dom-broker/src/main/java/org/opendaylight/mdsal/dom/broker/ShardedDOMDataTreeWriteTransaction.java
index 0e1180ab12..08f359d216 100644
--- a/dom/mdsal-dom-broker/src/main/java/org/opendaylight/mdsal/dom/broker/ShardedDOMDataTreeWriteTransaction.java
+++ b/dom/mdsal-dom-broker/src/main/java/org/opendaylight/mdsal/dom/broker/ShardedDOMDataTreeWriteTransaction.java
@@ -122,8 +122,7 @@ final class ShardedDOMDataTreeWriteTransaction implements DOMDataTreeCursorAware
         return submitFuture;
     }
 
-    CheckedFuture<Void, TransactionCommitFailedException> doSubmit(
-            final Consumer<ShardedDOMDataTreeWriteTransaction> success,
+    void doSubmit(final Consumer<ShardedDOMDataTreeWriteTransaction> success,
             final BiConsumer<ShardedDOMDataTreeWriteTransaction, Throwable> failure) {
 
         final ListenableFuture<List<Void>> listListenableFuture = Futures.allAsList(
@@ -133,22 +132,17 @@ final class ShardedDOMDataTreeWriteTransaction implements DOMDataTreeCursorAware
                 return tx.submit();
             }).collect(Collectors.toList()));
 
-        final SettableFuture<Void> ret = SettableFuture.create();
         Futures.addCallback(listListenableFuture, new FutureCallback<List<Void>>() {
             @Override
             public void onSuccess(final List<Void> result) {
                 success.accept(ShardedDOMDataTreeWriteTransaction.this);
-                ret.set(null);
             }
 
             @Override
             public void onFailure(final Throwable exp) {
                 failure.accept(ShardedDOMDataTreeWriteTransaction.this, exp);
-                ret.setException(exp);
             }
         });
-
-        return Futures.makeChecked(ret, SUBMIT_FAILED_MAPPER);
     }
 
     void onTransactionSuccess(final Void result) {