From: Robert Varga <robert.varga@pantheon.tech>
Date: Thu, 15 Oct 2020 05:57:01 +0000 (+0200)
Subject: Add a FIXME for getModuleInfo
X-Git-Tag: v7.0.1~7
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=b111382f80a9a058f32556b72bcc48b3a88fdcdc;p=mdsal.git

Add a FIXME for getModuleInfo

We do not want to throw Exception here, mark for improvement.

Change-Id: I67e4ba4e9ca7b6076eb78acb08bbcdb5c13c7d44
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---

diff --git a/binding/mdsal-binding-spec-util/src/main/java/org/opendaylight/mdsal/binding/spec/reflect/BindingReflections.java b/binding/mdsal-binding-spec-util/src/main/java/org/opendaylight/mdsal/binding/spec/reflect/BindingReflections.java
index 7e465bc6eb..2c1a2d1871 100644
--- a/binding/mdsal-binding-spec-util/src/main/java/org/opendaylight/mdsal/binding/spec/reflect/BindingReflections.java
+++ b/binding/mdsal-binding-spec-util/src/main/java/org/opendaylight/mdsal/binding/spec/reflect/BindingReflections.java
@@ -254,7 +254,7 @@ public final class BindingReflections {
             return findQName(clz).getModule();
         }
         try {
-            return BindingReflections.getModuleInfo(clz).getName().getModule();
+            return getModuleInfo(clz).getName().getModule();
         } catch (Exception e) {
             throw new IllegalStateException("Unable to get QName of defining model.", e);
         }
@@ -267,6 +267,7 @@ public final class BindingReflections {
      * @return Instance of {@link YangModuleInfo} associated with model, from
      *         which this class was derived.
      */
+    // FIXME: 8.0.0: do not throw Exception here
     public static @NonNull YangModuleInfo getModuleInfo(final Class<?> cls) throws Exception {
         checkArgument(cls != null);
         String packageName = getModelRootPackageName(cls.getPackage());