From: Robert Varga <robert.varga@pantheon.tech>
Date: Sun, 9 May 2021 08:08:40 +0000 (+0200)
Subject: Deprecate JSONRestconfService
X-Git-Tag: v1.13.2~19
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=b3987544ed63f88035dd4600dc3be7322e98f6b3;p=netconf.git

Deprecate JSONRestconfService

This service is type-unsafe and does not have users in OpenDaylight
proper. The contract is actively hurtful as it seeks to steer users
towards opaque blobs, not expressing their service and data
dependencies. Furthermore the implementation structure forces an ugly
interface on the actual RESTCONF services, preventing reasonable
refactors.

Deprecate the service for removal, so that we can get rid of this burden
in the next major release.

Change-Id: I96d3fd86ba773fa8986454d1ac4825723b15152d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---

diff --git a/restconf/restconf-nb-rfc8040/src/main/java/org/opendaylight/restconf/nb/rfc8040/rests/services/api/JSONRestconfService.java b/restconf/restconf-nb-rfc8040/src/main/java/org/opendaylight/restconf/nb/rfc8040/rests/services/api/JSONRestconfService.java
index 35b5f4012a..c4db274d72 100644
--- a/restconf/restconf-nb-rfc8040/src/main/java/org/opendaylight/restconf/nb/rfc8040/rests/services/api/JSONRestconfService.java
+++ b/restconf/restconf-nb-rfc8040/src/main/java/org/opendaylight/restconf/nb/rfc8040/rests/services/api/JSONRestconfService.java
@@ -15,8 +15,11 @@ import org.opendaylight.yangtools.yang.common.OperationFailedException;
 /**
  * Provides restconf CRUD operations via code with input/output data in JSON format.
  *
+ * @deprecated This interface is type-unsafe and does not document encoding sufficiently. Use proper MD-SAL interfaces
+ *             instead.
  * @author Thomas Pantelis.
  */
+@Deprecated(since = "1.13.2", forRemoval = true)
 public interface JSONRestconfService {
     /**
      * The data tree root path.