From: Vladimir Lavor Date: Mon, 15 Aug 2016 12:09:53 +0000 (+0200) Subject: Bug 6396: Integrate faas renderer with clustering singleton service X-Git-Tag: release/carbon~112^2 X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=b81ab8d9b0efd9dbd777167071ef29349059bb2a;p=groupbasedpolicy.git Bug 6396: Integrate faas renderer with clustering singleton service Change-Id: Id7fabc3ff5d47bb0a2a793927d8dbfa12071a299 Signed-off-by: Vladimir Lavor --- diff --git a/renderers/faas/src/main/java/org/opendaylight/controller/config/yang/config/faas_provider/impl/FaasProviderInstance.java b/renderers/faas/src/main/java/org/opendaylight/controller/config/yang/config/faas_provider/impl/FaasProviderInstance.java index f20b1aab0..544ece9b4 100644 --- a/renderers/faas/src/main/java/org/opendaylight/controller/config/yang/config/faas_provider/impl/FaasProviderInstance.java +++ b/renderers/faas/src/main/java/org/opendaylight/controller/config/yang/config/faas_provider/impl/FaasProviderInstance.java @@ -8,21 +8,77 @@ package org.opendaylight.controller.config.yang.config.faas_provider.impl; +import com.google.common.base.Preconditions; +import com.google.common.util.concurrent.Futures; +import com.google.common.util.concurrent.ListenableFuture; +import org.opendaylight.controller.config.yang.config.groupbasedpolicy.GroupbasedpolicyInstance; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.groupbasedpolicy.api.EpRendererAugmentationRegistry; import org.opendaylight.groupbasedpolicy.renderer.faas.FaasRenderer; +import org.opendaylight.mdsal.singleton.common.api.ClusterSingletonService; +import org.opendaylight.mdsal.singleton.common.api.ClusterSingletonServiceProvider; +import org.opendaylight.mdsal.singleton.common.api.ClusterSingletonServiceRegistration; +import org.opendaylight.mdsal.singleton.common.api.ServiceGroupIdentifier; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; -public class FaasProviderInstance implements AutoCloseable{ +public class FaasProviderInstance implements ClusterSingletonService, AutoCloseable { + private static final Logger LOG = LoggerFactory.getLogger(FaasProviderInstance.class); + + private static final ServiceGroupIdentifier IDENTIFIER = + ServiceGroupIdentifier.create(GroupbasedpolicyInstance.GBP_SERVICE_GROUP_IDENTIFIER); + private final DataBroker dataBroker; + private final EpRendererAugmentationRegistry epRegistry; + private final ClusterSingletonServiceProvider clusterSingletonService; + private ClusterSingletonServiceRegistration singletonServiceRegistration; private FaasRenderer renderer; - public FaasProviderInstance (DataBroker dataBroker, EpRendererAugmentationRegistry epRegistry) { + public FaasProviderInstance(final DataBroker dataBroker, + final EpRendererAugmentationRegistry epRegistry, + final ClusterSingletonServiceProvider clusteringServiceProvider) { + this.dataBroker = Preconditions.checkNotNull(dataBroker); + this.epRegistry = Preconditions.checkNotNull(epRegistry); + this.clusterSingletonService = Preconditions.checkNotNull(clusteringServiceProvider); + } + + public void initialize() { + LOG.info("Clustering session initiated for {}", this.getClass().getSimpleName()); + singletonServiceRegistration = clusterSingletonService.registerClusterSingletonService(this); + } + + @Override + public void instantiateServiceInstance() { + LOG.info("Instantiating {}", this.getClass().getSimpleName()); renderer = new FaasRenderer(dataBroker, epRegistry); } + @Override + public ListenableFuture closeServiceInstance() { + LOG.info("Instance {} closed", this.getClass().getSimpleName()); + try { + renderer.close(); + } catch (Exception e) { + LOG.warn("Exception while closing ... ", e); + } + return Futures.immediateFuture(null); + } + @Override public void close() throws Exception { - renderer.close(); + LOG.info("Clustering provider closed for {}", this.getClass().getSimpleName()); + if (singletonServiceRegistration != null) { + try { + singletonServiceRegistration.close(); + } catch (Exception e) { + LOG.warn("{} closed unexpectedly", this.getClass().getSimpleName(), e.getMessage()); + } + singletonServiceRegistration = null; + } } + @Override + public ServiceGroupIdentifier getIdentifier() { + return IDENTIFIER; + } } diff --git a/renderers/faas/src/main/resources/org/opendaylight/blueprint/faas-renderer.xml b/renderers/faas/src/main/resources/org/opendaylight/blueprint/faas-renderer.xml index a72c7a8e0..0ee23f2f6 100644 --- a/renderers/faas/src/main/resources/org/opendaylight/blueprint/faas-renderer.xml +++ b/renderers/faas/src/main/resources/org/opendaylight/blueprint/faas-renderer.xml @@ -5,10 +5,12 @@ + + init-method="initialize" destroy-method="close"> + \ No newline at end of file