From: Robert Varga <robert.varga@pantheon.tech>
Date: Thu, 22 Jun 2023 10:32:01 +0000 (+0200)
Subject: Hide BindingReflections.isRpcType()
X-Git-Tag: v12.0.0~31
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=bd1b02c16f228f2df268f8ed7da2c70def05c44f;p=mdsal.git

Hide BindingReflections.isRpcType()

This method is only used internally, do not expose it to the outside
world.

JIRA: MDSAL-781
Change-Id: If3dd90eaa24179559e830ebbded5a206ff76082a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---

diff --git a/binding/mdsal-binding-spec-util/src/main/java/org/opendaylight/mdsal/binding/spec/reflect/BindingReflections.java b/binding/mdsal-binding-spec-util/src/main/java/org/opendaylight/mdsal/binding/spec/reflect/BindingReflections.java
index 33d4265841..36a08b97a9 100644
--- a/binding/mdsal-binding-spec-util/src/main/java/org/opendaylight/mdsal/binding/spec/reflect/BindingReflections.java
+++ b/binding/mdsal-binding-spec-util/src/main/java/org/opendaylight/mdsal/binding/spec/reflect/BindingReflections.java
@@ -10,6 +10,7 @@ package org.opendaylight.mdsal.binding.spec.reflect;
 import static com.google.common.base.Preconditions.checkArgument;
 import static com.google.common.base.Preconditions.checkState;
 
+import com.google.common.annotations.VisibleForTesting;
 import com.google.common.cache.CacheBuilder;
 import com.google.common.cache.CacheLoader;
 import com.google.common.cache.LoadingCache;
@@ -128,14 +129,15 @@ public final class BindingReflections {
      *            Class to be checked
      * @return true if class represents RPC Input or RPC Output class.
      */
-    public static boolean isRpcType(final Class<? extends DataObject> targetType) {
+    @VisibleForTesting
+    static boolean isRpcType(final Class<? extends DataObject> targetType) {
         return DataContainer.class.isAssignableFrom(targetType)
                 && !ChildOf.class.isAssignableFrom(targetType)
                 && !Notification.class.isAssignableFrom(targetType)
                 && (targetType.getName().endsWith("Input") || targetType.getName().endsWith("Output"));
     }
 
-    private static class ClassToQNameLoader extends CacheLoader<Class<?>, Optional<QName>> {
+    private static final class ClassToQNameLoader extends CacheLoader<Class<?>, Optional<QName>> {
 
         @Override
         public Optional<QName> load(@SuppressWarnings("NullableProblems") final Class<?> key) throws Exception {