From: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Date: Thu, 8 Jun 2023 13:15:51 +0000 (+0200)
Subject: Remove ObjectMapper from BaseYangOpenApiGenerator
X-Git-Tag: v6.0.0~48
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=d60657e7269c7740a024dcf7d28c1c34a2a11529;p=netconf.git

Remove ObjectMapper from BaseYangOpenApiGenerator

Its unfortunate to use heavy ObjectMapper for logging purposes.

Change-Id: I6357d4bd768065144dc8dee2d4f0b722278b5994
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
---

diff --git a/restconf/restconf-openapi/src/main/java/org/opendaylight/restconf/openapi/impl/BaseYangOpenApiGenerator.java b/restconf/restconf-openapi/src/main/java/org/opendaylight/restconf/openapi/impl/BaseYangOpenApiGenerator.java
index 8edbd6f87e..0f6688f531 100644
--- a/restconf/restconf-openapi/src/main/java/org/opendaylight/restconf/openapi/impl/BaseYangOpenApiGenerator.java
+++ b/restconf/restconf-openapi/src/main/java/org/opendaylight/restconf/openapi/impl/BaseYangOpenApiGenerator.java
@@ -18,8 +18,6 @@ import static org.opendaylight.restconf.openapi.model.builder.OperationBuilder.g
 import static org.opendaylight.restconf.openapi.util.RestDocgenUtil.resolvePathArgumentsName;
 
 import com.fasterxml.jackson.databind.JsonNode;
-import com.fasterxml.jackson.databind.ObjectMapper;
-import com.fasterxml.jackson.databind.SerializationFeature;
 import com.fasterxml.jackson.databind.node.ArrayNode;
 import com.fasterxml.jackson.databind.node.JsonNodeFactory;
 import com.fasterxml.jackson.databind.node.ObjectNode;
@@ -71,7 +69,6 @@ public abstract class BaseYangOpenApiGenerator {
 
     private static final String API_VERSION = "1.0.0";
     private static final String OPEN_API_VERSION = "3.0.3";
-    private static final ObjectMapper MAPPER = new ObjectMapper();
 
     private final DefinitionGenerator jsonConverter = new DefinitionGenerator();
     private final DOMSchemaService schemaService;
@@ -84,10 +81,6 @@ public abstract class BaseYangOpenApiGenerator {
     private static final ArrayNode SECURITY = JsonNodeFactory.instance.arrayNode()
             .add(JsonNodeFactory.instance.objectNode().set("basicAuth", JsonNodeFactory.instance.arrayNode()));
 
-    static {
-        MAPPER.configure(SerializationFeature.INDENT_OUTPUT, true);
-    }
-
     protected BaseYangOpenApiGenerator(final Optional<DOMSchemaService> schemaService) {
         this.schemaService = schemaService.orElse(null);
     }
@@ -222,9 +215,6 @@ public abstract class BaseYangOpenApiGenerator {
             final Map<String, Schema> schemas = jsonConverter.convertToSchemas(module, schemaContext,
                 definitionNames, isForSingleModule);
             docBuilder.getComponents().schemas().putAll(schemas);
-            if (LOG.isDebugEnabled()) {
-                LOG.debug("Document: {}", MAPPER.writeValueAsString(docBuilder.build()));
-            }
         } catch (final IOException e) {
             LOG.error("Exception occurred in DefinitionGenerator", e);
         }