From: Tom Pantelis Date: Sat, 20 Jun 2015 09:20:07 +0000 (-0400) Subject: Fix bug in ImmutableMapEntryNodeBuilder X-Git-Tag: release/beryllium~396 X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=d9a6f8d69adf0f8e9d7947cec1e8758be2341249;p=yangtools.git Fix bug in ImmutableMapEntryNodeBuilder In ImmutableMapEntryNodeBuilder#build, for the call to getChild(childrenQNamesToPaths.get(key.getValue())); it should use key.getKey(). As a result, key childs nodes are never found and thus user-provided nodes are always replaced. NOTE: https://git.opendaylight.org/gerrit/#/c/23044/ should be merged first to avoid unit test failure in the controller project. Change-Id: I736756ce8fc3e15a05641565f2f505a2db32e9fc Signed-off-by: Tom Pantelis (cherry picked from commit f965264bb05b1dc5dc921eb1f8e80461e6a1cbb9) --- diff --git a/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/builder/impl/ImmutableMapEntryNodeBuilder.java b/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/builder/impl/ImmutableMapEntryNodeBuilder.java index 58d86a2967..cebe26b0f5 100644 --- a/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/builder/impl/ImmutableMapEntryNodeBuilder.java +++ b/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/builder/impl/ImmutableMapEntryNodeBuilder.java @@ -98,7 +98,7 @@ public class ImmutableMapEntryNodeBuilder extends AbstractImmutableDataContainer @Override public MapEntryNode build() { for (final Entry key : getNodeIdentifier().getKeyValues().entrySet()) { - final DataContainerChild childNode = getChild(childrenQNamesToPaths.get(key.getValue())); + final DataContainerChild childNode = getChild(childrenQNamesToPaths.get(key.getKey())); // We have enough information to fill-in missing leaf nodes, so let's do that if (childNode == null) {