From: Robert Varga <robert.varga@pantheon.tech>
Date: Fri, 1 Nov 2019 14:07:48 +0000 (+0100)
Subject: Improve NeutronVpnUtils.getIsExternal()
X-Git-Tag: release/magnesium~78
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=efab9e6077216618870d42ca89d2719ded741530;p=netvirt.git

Improve NeutronVpnUtils.getIsExternal()

This eliminates one sift through augmentations, improving performance
a bit.

Change-Id: I39ff594ffc7561d04201282e4fbf812377f9c614
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---

diff --git a/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnUtils.java b/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnUtils.java
index 626d0614ec..f1228b1617 100644
--- a/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnUtils.java
+++ b/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnUtils.java
@@ -1014,8 +1014,8 @@ public class NeutronvpnUtils {
     }
 
     static Boolean getIsExternal(Network network) {
-        return network.augmentation(NetworkL3Extension.class) != null
-                && network.augmentation(NetworkL3Extension.class).isExternal();
+        NetworkL3Extension ext = network.augmentation(NetworkL3Extension.class);
+        return ext != null && ext.isExternal();
     }
 
     static InstanceIdentifier<NetworkMap> buildNetworkMapIdentifier(Uuid networkId) {