From: Robert Varga <rovarga@cisco.com>
Date: Sun, 14 Feb 2016 22:29:41 +0000 (+0100)
Subject: Remove an unneeded null check
X-Git-Tag: release/boron~211
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=f1f9a839ff6d8d932a0ec9a790cb1e015cb3ed30;p=yangtools.git

Remove an unneeded null check

instanceof performs a null check, hence we do not have to do it
ourselves. Saves a branch.

Change-Id: Icb4e29c5adb94a1c971fa8019064324ef1cadbf2
Signed-off-by: Robert Varga <rovarga@cisco.com>
---

diff --git a/common/util/src/main/java/org/opendaylight/yangtools/util/ConstantArrayCollection.java b/common/util/src/main/java/org/opendaylight/yangtools/util/ConstantArrayCollection.java
index 8c29d9e0b9..b88a6ef992 100644
--- a/common/util/src/main/java/org/opendaylight/yangtools/util/ConstantArrayCollection.java
+++ b/common/util/src/main/java/org/opendaylight/yangtools/util/ConstantArrayCollection.java
@@ -145,9 +145,6 @@ final class ConstantArrayCollection<E> implements Collection<E>, Serializable {
         if (obj == this) {
             return true;
         }
-        if (obj == null) {
-            return false;
-        }
         if (!(obj instanceof ConstantArrayCollection)) {
             return false;
         }
@@ -161,7 +158,7 @@ final class ConstantArrayCollection<E> implements Collection<E>, Serializable {
             return "[]";
         }
 
-        StringBuilder sb = new StringBuilder("[");
+        final StringBuilder sb = new StringBuilder("[");
         int i = 0;
         while (i < array.length - 1) {
             sb.append(String.valueOf(array[i++])).append(", ");