From: Susmitha <sa396f@att.com>
Date: Fri, 20 Mar 2020 17:10:43 +0000 (-0400)
Subject: Calculate spanloss crashes when OTS is not present
X-Git-Tag: 1.1.0~26
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=f86d7eccccd5e50eb9e67a1a7e0455849a502565;p=transportpce.git

Calculate spanloss crashes when OTS is not present

-OTS interface check is added to avoid the crash
JIRA: TRNSPRTPCE-172

Change-Id: Ic8fa52eaf98069d7fe581d2c9b2a9f75cbf0fadd
---

diff --git a/olm/src/main/java/org/opendaylight/transportpce/olm/service/OlmPowerServiceImpl.java b/olm/src/main/java/org/opendaylight/transportpce/olm/service/OlmPowerServiceImpl.java
index 15a37d94e..0dcf6f148 100644
--- a/olm/src/main/java/org/opendaylight/transportpce/olm/service/OlmPowerServiceImpl.java
+++ b/olm/src/main/java/org/opendaylight/transportpce/olm/service/OlmPowerServiceImpl.java
@@ -523,6 +523,10 @@ public class OlmPowerServiceImpl implements OlmPowerService {
             String destTpId = link.getDestTpid();
             OtsPmHolder srcOtsPmHoler = getPmMeasurements(sourceNodeId, sourceTpId, "OpticalPowerOutput");
             OtsPmHolder destOtsPmHoler = getPmMeasurements(destNodeId, destTpId, "OpticalPowerInput");
+            if (srcOtsPmHoler.getOtsInterfaceName() == null || destOtsPmHoler.getOtsInterfaceName() == null) {
+                LOG.warn("OTS is not present for the link {}", link);
+                continue;
+            }
             spanLoss = new BigDecimal(srcOtsPmHoler.getOtsParameterVal() - destOtsPmHoler.getOtsParameterVal())
                 .setScale(0, RoundingMode.HALF_UP);
             LOG.info("Spanloss Calculated as :{}={}-{}",