From: Jonas Mårtensson <jonas.martensson@smartoptics.com>
Date: Fri, 9 Feb 2024 07:43:00 +0000 (+0000)
Subject: Fix warning message when service creation fails
X-Git-Tag: 9.0.0~50^2
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F01%2F110201%2F3;p=transportpce.git

Fix warning message when service creation fails

When service implementation failed, the warning message "Service was
not removed from datastore!" was shown in the log, even if the service
was successfully removed.

JIRA: TRNSPRTPCE-784
Signed-off-by: Jonas Mårtensson <jonas.martensson@smartoptics.com>
Change-Id: I64bb939459e32155626bce1a57da6bd09db22ac8
---

diff --git a/servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/listeners/RendererNotificationHandler.java b/servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/listeners/RendererNotificationHandler.java
index be3eef2a4..ae723eb6c 100644
--- a/servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/listeners/RendererNotificationHandler.java
+++ b/servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/listeners/RendererNotificationHandler.java
@@ -364,7 +364,7 @@ public class RendererNotificationHandler implements RendererListener {
         } else {
             deleteServiceOperationResult = this.serviceDataStoreOperations.deleteService(serviceName);
         }
-        if (deleteServiceOperationResult.isSuccess()) {
+        if (!deleteServiceOperationResult.isSuccess()) {
             LOG.warn("{}Service was not removed from datastore!", serviceType);
         }
     }