From: Robert Varga Date: Mon, 30 Sep 2019 14:45:32 +0000 (+0200) Subject: Push out FIXMEs to 5.0.0 X-Git-Tag: v4.0.0~11 X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F11%2F84811%2F3;p=yangtools.git Push out FIXMEs to 5.0.0 We are not going to address these in 4.0.0 timeframe, push them out to 5.0.0. Change-Id: I73b9ba42c552c88758866d325b76fe9aebc3b569 Signed-off-by: Robert Varga --- diff --git a/common/concepts/src/main/java/org/opendaylight/yangtools/concepts/Identifiable.java b/common/concepts/src/main/java/org/opendaylight/yangtools/concepts/Identifiable.java index f8af6a753a..5473f2e545 100644 --- a/common/concepts/src/main/java/org/opendaylight/yangtools/concepts/Identifiable.java +++ b/common/concepts/src/main/java/org/opendaylight/yangtools/concepts/Identifiable.java @@ -17,7 +17,7 @@ import org.eclipse.jdt.annotation.NonNull; * @param Identifier class, must conform to API contract outlined by {@link Identifier}, even if it does not * implement it. */ -// FIXME: 4.0.0: consider requiring "T extends Serializable" +// FIXME: 5.0.0: consider requiring "T extends Serializable" public interface Identifiable { /** * Return this objects Identifier. diff --git a/yang/yang-model-api/src/main/java/org/opendaylight/yangtools/yang/model/api/EffectiveModelContext.java b/yang/yang-model-api/src/main/java/org/opendaylight/yangtools/yang/model/api/EffectiveModelContext.java index 92fe78c726..855184b434 100644 --- a/yang/yang-model-api/src/main/java/org/opendaylight/yangtools/yang/model/api/EffectiveModelContext.java +++ b/yang/yang-model-api/src/main/java/org/opendaylight/yangtools/yang/model/api/EffectiveModelContext.java @@ -20,7 +20,7 @@ import org.opendaylight.yangtools.yang.model.api.stmt.ModuleEffectiveStatement; * @author Robert Varga */ @Beta -// FIXME: 4.0.0: evaluate if we still need to extend SchemaContext here +// FIXME: 5.0.0: evaluate if we still need to extend SchemaContext here public interface EffectiveModelContext extends SchemaContext { Map getModuleStatements(); diff --git a/yang/yang-model-api/src/main/java/org/opendaylight/yangtools/yang/model/api/ModuleImport.java b/yang/yang-model-api/src/main/java/org/opendaylight/yangtools/yang/model/api/ModuleImport.java index 2f58eaa64a..43976a8a16 100644 --- a/yang/yang-model-api/src/main/java/org/opendaylight/yangtools/yang/model/api/ModuleImport.java +++ b/yang/yang-model-api/src/main/java/org/opendaylight/yangtools/yang/model/api/ModuleImport.java @@ -17,7 +17,7 @@ import org.opendaylight.yangtools.yang.common.Revision; *

* The import statement makes definitions from one module available inside another module or submodule. */ -// FIXME: 3.0.0 this class is a leak of the declared world into the effective one. In effective world, all nodes form +// FIXME: 5.0.0 this class is a leak of the declared world into the effective one. In effective world, all nodes form // a tree, which consists of multiple (mostly) QName-navigated namespaces. As such module imports contribute // only a prefix/QNameModule mapping to the effective world and hence should be mapped that way: // - Module exposes String->QNameModule mapping diff --git a/yang/yang-model-api/src/main/java/org/opendaylight/yangtools/yang/model/api/SchemaContext.java b/yang/yang-model-api/src/main/java/org/opendaylight/yangtools/yang/model/api/SchemaContext.java index 19333ae024..9ef5971f8f 100644 --- a/yang/yang-model-api/src/main/java/org/opendaylight/yangtools/yang/model/api/SchemaContext.java +++ b/yang/yang-model-api/src/main/java/org/opendaylight/yangtools/yang/model/api/SchemaContext.java @@ -31,9 +31,9 @@ import org.opendaylight.yangtools.yang.common.Revision; * Instances MUST be immutable and thus usage in multi threaded * environment is safe. */ -// FIXME: 3.0.0: ContainerSchemaNode is far too broad. A combination of DataNodeContainer, NotificationNodeContainer +// FIXME: 5.0.0: ContainerSchemaNode is far too broad. A combination of DataNodeContainer, NotificationNodeContainer // and possibly DataSchemaNode would reflect SchemaContext traits better. -// FIXME: 4.0.0: consider deprecating this class in favor of EffectiveModelContext +// FIXME: 5.0.0: consider deprecating this class in favor of EffectiveModelContext public interface SchemaContext extends ContainerSchemaNode, Immutable { /** * QName of NETCONF top-level data node.