From: Robert Varga <robert.varga@pantheon.tech>
Date: Wed, 11 Aug 2021 12:01:40 +0000 (+0200)
Subject: Use a global comparator
X-Git-Tag: v6.0.11~4
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F36%2F97136%2F1;p=mdsal.git

Use a global comparator

Rather than instantiating a new comparator every time, just reuse a
single instance.

Change-Id: Ida1e9c1f41c5ab67a2847173bdcad6a1cd780c0e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---

diff --git a/dom/mdsal-dom-broker/src/main/java/org/opendaylight/mdsal/dom/broker/DOMActionRoutingTableEntry.java b/dom/mdsal-dom-broker/src/main/java/org/opendaylight/mdsal/dom/broker/DOMActionRoutingTableEntry.java
index f44d884b66..21c872af47 100644
--- a/dom/mdsal-dom-broker/src/main/java/org/opendaylight/mdsal/dom/broker/DOMActionRoutingTableEntry.java
+++ b/dom/mdsal-dom-broker/src/main/java/org/opendaylight/mdsal/dom/broker/DOMActionRoutingTableEntry.java
@@ -24,6 +24,9 @@ import org.opendaylight.yangtools.yang.model.api.SchemaPath;
 @Beta
 final class DOMActionRoutingTableEntry extends AbstractDOMRoutingTableEntry<DOMDataTreeIdentifier,
         DOMActionImplementation, AvailabilityListener> {
+    private static final Comparator<DOMActionImplementation> COMPARATOR =
+        Comparator.comparingLong(DOMActionImplementation::invocationCost);
+
     DOMActionRoutingTableEntry(final SchemaPath type,
             final Map<DOMDataTreeIdentifier, List<DOMActionImplementation>> implementations) {
         super(type, implementations);
@@ -37,7 +40,7 @@ final class DOMActionRoutingTableEntry extends AbstractDOMRoutingTableEntry<DOMD
 
     @Override
     protected Comparator<DOMActionImplementation> implComparator() {
-        return Comparator.comparingLong(DOMActionImplementation::invocationCost);
+        return COMPARATOR;
     }
 
     @Override