From: Robert Varga <robert.varga@pantheon.tech>
Date: Wed, 19 Sep 2018 10:48:17 +0000 (+0200)
Subject: Do not clutter logs with a thrown exception
X-Git-Tag: v2.0.6.4~8
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F58%2F76258%2F2;p=yangtools.git

Do not clutter logs with a thrown exception

SourceException is an unchecked exception which we handle at a higher
layer. The logging statement does not add anything useful, so let's
remove it.

Change-Id: I8a4654b44469a2193996d1d90e982d01a1a62bf3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---

diff --git a/yang/yang-parser-rfc7950/src/main/java/org/opendaylight/yangtools/yang/parser/rfc7950/stmt/uses/UsesStatementSupport.java b/yang/yang-parser-rfc7950/src/main/java/org/opendaylight/yangtools/yang/parser/rfc7950/stmt/uses/UsesStatementSupport.java
index 22002341bc..7f28b90dce 100644
--- a/yang/yang-parser-rfc7950/src/main/java/org/opendaylight/yangtools/yang/parser/rfc7950/stmt/uses/UsesStatementSupport.java
+++ b/yang/yang-parser-rfc7950/src/main/java/org/opendaylight/yangtools/yang/parser/rfc7950/stmt/uses/UsesStatementSupport.java
@@ -24,14 +24,10 @@ import org.opendaylight.yangtools.yang.parser.spi.meta.StmtContext;
 import org.opendaylight.yangtools.yang.parser.spi.meta.StmtContext.Mutable;
 import org.opendaylight.yangtools.yang.parser.spi.meta.StmtContextUtils;
 import org.opendaylight.yangtools.yang.parser.spi.meta.SubstatementValidator;
-import org.opendaylight.yangtools.yang.parser.spi.source.SourceException;
 import org.opendaylight.yangtools.yang.parser.stmt.reactor.StatementContextBase;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 public final class UsesStatementSupport extends
         AbstractQNameStatementSupport<UsesStatement, EffectiveStatement<QName, UsesStatement>> {
-    private static final Logger LOG = LoggerFactory.getLogger(UsesStatementSupport.class);
     private static final SubstatementValidator SUBSTATEMENT_VALIDATOR = SubstatementValidator.builder(YangStmtMapping
         .USES)
         .addAny(YangStmtMapping.AUGMENT)
@@ -82,14 +78,9 @@ public final class UsesStatementSupport extends
                 final StatementContextBase<?, ?, ?> sourceGrpStmtCtx =
                         (StatementContextBase<?, ?, ?>) sourceGroupingPre.resolve(ctx);
 
-                try {
-                    UsesStatementImpl.copyFromSourceToTarget(sourceGrpStmtCtx, targetNodeStmtCtx, usesNode);
-                    UsesStatementImpl.resolveUsesNode(usesNode, targetNodeStmtCtx);
-                    StmtContextUtils.validateIfFeatureAndWhenOnListKeys(usesNode);
-                } catch (final SourceException e) {
-                    LOG.warn(e.getMessage(), e);
-                    throw e;
-                }
+                UsesStatementImpl.copyFromSourceToTarget(sourceGrpStmtCtx, targetNodeStmtCtx, usesNode);
+                UsesStatementImpl.resolveUsesNode(usesNode, targetNodeStmtCtx);
+                StmtContextUtils.validateIfFeatureAndWhenOnListKeys(usesNode);
             }
 
             @Override