From: Robert Varga <rovarga@cisco.com>
Date: Fri, 30 Dec 2016 12:22:41 +0000 (+0100)
Subject: BUG-7464: Hide CNodeBase.csize
X-Git-Tag: release/carbon~168
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F70%2F49870%2F6;p=yangtools.git

BUG-7464: Hide CNodeBase.csize

This field should be accessed only through its accessor, hide it,
along with its updater.

Change-Id: I873ac0abc7d94d616e917d9c87317a55b0280747
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---

diff --git a/third-party/triemap/src/main/java/org/opendaylight/yangtools/triemap/CNodeBase.java b/third-party/triemap/src/main/java/org/opendaylight/yangtools/triemap/CNodeBase.java
index b856547edd..71279440f2 100644
--- a/third-party/triemap/src/main/java/org/opendaylight/yangtools/triemap/CNodeBase.java
+++ b/third-party/triemap/src/main/java/org/opendaylight/yangtools/triemap/CNodeBase.java
@@ -18,21 +18,17 @@ package org.opendaylight.yangtools.triemap;
 import java.util.concurrent.atomic.AtomicIntegerFieldUpdater;
 
 abstract class CNodeBase<K, V> extends MainNode<K, V> {
+    @SuppressWarnings("rawtypes")
+    private static final AtomicIntegerFieldUpdater<CNodeBase> CSIZE_UPDATER =
+            AtomicIntegerFieldUpdater.newUpdater(CNodeBase.class, "csize");
 
-    public static final AtomicIntegerFieldUpdater<CNodeBase> updater = AtomicIntegerFieldUpdater.newUpdater(CNodeBase.class, "csize");
+    private volatile int csize = -1;
 
-    public volatile int csize = -1;
-
-    public boolean CAS_SIZE(final int oldval, final int nval) {
-        return updater.compareAndSet(this, oldval, nval);
-    }
-
-    public void WRITE_SIZE(final int nval) {
-        updater.set(this, nval);
+    final boolean CAS_SIZE(final int oldval, final int nval) {
+        return CSIZE_UPDATER.compareAndSet(this, oldval, nval);
     }
 
-    public int READ_SIZE() {
-        return updater.get(this);
+    final int READ_SIZE() {
+        return csize;
     }
-
-}
\ No newline at end of file
+}