From: janab <brinda.jana@nexusis.com>
Date: Tue, 30 Aug 2016 19:17:33 +0000 (-0700)
Subject: Implementing checkStyleViolationSeverity=error for mdsal-eos-binding-api module
X-Git-Tag: release/carbon~219
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F84%2F44884%2F3;p=mdsal.git

Implementing checkStyleViolationSeverity=error for mdsal-eos-binding-api module

Change-Id: Ic5526189f5a646a369d43676b287034c0f781ce5
Signed-off-by: Brinda Jana <brinda.jana@nexusis.com>
---

diff --git a/entityownership/mdsal-eos-binding-api/pom.xml b/entityownership/mdsal-eos-binding-api/pom.xml
index 94b217516d..ed7436db9f 100644
--- a/entityownership/mdsal-eos-binding-api/pom.xml
+++ b/entityownership/mdsal-eos-binding-api/pom.xml
@@ -62,6 +62,17 @@
       <scope>test</scope>
     </dependency>
   </dependencies>
+  <build>
+    <plugins>
+        <plugin>
+          <groupId>org.apache.maven.plugins</groupId>
+          <artifactId>maven-checkstyle-plugin</artifactId>
+          <configuration>
+              <propertyExpansion>checkstyle.violationSeverity=error</propertyExpansion>
+          </configuration>
+      </plugin>
+    </plugins>
+  </build>
   <scm>
     <connection>scm:git:http://git.opendaylight.org/gerrit/controller.git</connection>
     <developerConnection>scm:git:ssh://git.opendaylight.org:29418/controller.git</developerConnection>
diff --git a/entityownership/mdsal-eos-binding-api/src/main/java/org/opendaylight/mdsal/eos/binding/api/Entity.java b/entityownership/mdsal-eos-binding-api/src/main/java/org/opendaylight/mdsal/eos/binding/api/Entity.java
index 2a128dfbaa..7f5e024bea 100644
--- a/entityownership/mdsal-eos-binding-api/src/main/java/org/opendaylight/mdsal/eos/binding/api/Entity.java
+++ b/entityownership/mdsal-eos-binding-api/src/main/java/org/opendaylight/mdsal/eos/binding/api/Entity.java
@@ -40,8 +40,8 @@ public class Entity extends GenericEntity<InstanceIdentifier<?>> {
      * @param entityName the name of the entity used to construct a general-entity InstanceIdentifier
      */
     public Entity(@Nonnull String type, @Nonnull String entityName) {
-        super(type, InstanceIdentifier.builder(org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.
-                mdsal.core.general.entity.rev150930.Entity.class,
+        super(type, InstanceIdentifier.builder(org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang
+                .mdsal.core.general.entity.rev150930.Entity.class,
                     new EntityKey(Preconditions.checkNotNull(entityName, "entityName should not be null"))).build());
     }
 }
diff --git a/entityownership/mdsal-eos-binding-api/src/main/java/org/opendaylight/mdsal/eos/binding/api/EntityOwnershipChange.java b/entityownership/mdsal-eos-binding-api/src/main/java/org/opendaylight/mdsal/eos/binding/api/EntityOwnershipChange.java
index df9b32839d..ce56940422 100644
--- a/entityownership/mdsal-eos-binding-api/src/main/java/org/opendaylight/mdsal/eos/binding/api/EntityOwnershipChange.java
+++ b/entityownership/mdsal-eos-binding-api/src/main/java/org/opendaylight/mdsal/eos/binding/api/EntityOwnershipChange.java
@@ -21,16 +21,10 @@ import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
 @Beta
 public class EntityOwnershipChange extends GenericEntityOwnershipChange<InstanceIdentifier<?>, Entity> {
 
-    /**
-     * {@inheritDoc}
-     */
     public EntityOwnershipChange(@Nonnull final Entity entity, @Nonnull final EntityOwnershipChangeState state) {
         super(entity, state, false);
     }
 
-    /**
-     * {@inheritDoc}
-     */
     public EntityOwnershipChange(@Nonnull final Entity entity, @Nonnull final EntityOwnershipChangeState state,
             final boolean inJeopardy) {
         super(entity, state, inJeopardy);
diff --git a/entityownership/mdsal-eos-binding-api/src/main/java/org/opendaylight/mdsal/eos/binding/api/EntityOwnershipListener.java b/entityownership/mdsal-eos-binding-api/src/main/java/org/opendaylight/mdsal/eos/binding/api/EntityOwnershipListener.java
index 0789f83d46..6cbafa9e4d 100644
--- a/entityownership/mdsal-eos-binding-api/src/main/java/org/opendaylight/mdsal/eos/binding/api/EntityOwnershipListener.java
+++ b/entityownership/mdsal-eos-binding-api/src/main/java/org/opendaylight/mdsal/eos/binding/api/EntityOwnershipListener.java
@@ -20,9 +20,6 @@ import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
 public interface EntityOwnershipListener extends
         GenericEntityOwnershipListener<InstanceIdentifier<?>, EntityOwnershipChange> {
 
-    /**
-     * {@inheritDoc}
-     */
     @Override
     void ownershipChanged(EntityOwnershipChange ownershipChange);
 }
diff --git a/entityownership/mdsal-eos-binding-api/src/main/java/org/opendaylight/mdsal/eos/binding/api/EntityOwnershipService.java b/entityownership/mdsal-eos-binding-api/src/main/java/org/opendaylight/mdsal/eos/binding/api/EntityOwnershipService.java
index f2e6c6765f..f699f9447a 100644
--- a/entityownership/mdsal-eos-binding-api/src/main/java/org/opendaylight/mdsal/eos/binding/api/EntityOwnershipService.java
+++ b/entityownership/mdsal-eos-binding-api/src/main/java/org/opendaylight/mdsal/eos/binding/api/EntityOwnershipService.java
@@ -24,29 +24,17 @@ import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
 public interface EntityOwnershipService extends
         GenericEntityOwnershipService<InstanceIdentifier<?>, Entity, EntityOwnershipListener> {
 
-    /**
-     * {@inheritDoc}
-     */
     @Override
     EntityOwnershipCandidateRegistration registerCandidate(@Nonnull Entity entity)
             throws CandidateAlreadyRegisteredException;
 
-    /**
-     * {@inheritDoc}
-     */
     @Override
     EntityOwnershipListenerRegistration registerListener(@Nonnull String entityType,
             @Nonnull EntityOwnershipListener listener);
 
-    /**
-     * {@inheritDoc}
-     */
     @Override
     Optional<EntityOwnershipState> getOwnershipState(@Nonnull Entity forEntity);
 
-    /**
-     * {@inheritDoc}
-     */
     @Override
     boolean isCandidateRegistered(@Nonnull Entity forEntity);
 }
diff --git a/entityownership/mdsal-eos-binding-api/src/test/java/org/opendaylight/mdsal/eos/binding/api/EntityTest.java b/entityownership/mdsal-eos-binding-api/src/test/java/org/opendaylight/mdsal/eos/binding/api/EntityTest.java
index 6dfdcc3e1e..6be0adda8e 100644
--- a/entityownership/mdsal-eos-binding-api/src/test/java/org/opendaylight/mdsal/eos/binding/api/EntityTest.java
+++ b/entityownership/mdsal-eos-binding-api/src/test/java/org/opendaylight/mdsal/eos/binding/api/EntityTest.java
@@ -8,11 +8,11 @@
 package org.opendaylight.mdsal.eos.binding.api;
 
 import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertNotEquals;
+import static org.junit.Assert.assertNotNull;
+
 import org.apache.commons.lang3.SerializationUtils;
 import org.junit.Test;
-import org.opendaylight.mdsal.eos.binding.api.Entity;
 import org.opendaylight.yangtools.yang.binding.DataContainer;
 import org.opendaylight.yangtools.yang.binding.DataObject;
 import org.opendaylight.yangtools.yang.binding.Identifier;
@@ -24,6 +24,7 @@ import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
  * @author Thomas Pantelis
  */
 public class EntityTest {
+
     static String ENTITY_TYPE1 = "type1";
     static String ENTITY_TYPE2 = "type2";
     static final InstanceIdentifier<TestDataObject1> ID1 = InstanceIdentifier.create(TestDataObject1.class);
@@ -63,9 +64,10 @@ public class EntityTest {
     public void testEntityNameConstructor() {
         Entity entity = new Entity(ENTITY_TYPE1, "foo");
 
-        Identifier<org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.
-        mdsal.core.general.entity.rev150930.Entity> keyID = entity.getIdentifier().firstKeyOf(
-                org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.mdsal.core.general.entity.rev150930.Entity.class);
+        Identifier<org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang
+            .mdsal.core.general.entity.rev150930.Entity> keyID = entity.getIdentifier().firstKeyOf(
+                org.opendaylight.yang.gen.v1.urn
+                    .opendaylight.params.xml.ns.yang.mdsal.core.general.entity.rev150930.Entity.class);
         assertNotNull("List key not found", keyID);
     }