From: Robert Varga <robert.varga@pantheon.tech>
Date: Thu, 22 Aug 2019 10:42:41 +0000 (+0200)
Subject: Disable SpotBugs enforcement on select artifacts
X-Git-Tag: v4.0.0~70
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F86%2F83886%2F3;p=yangtools.git

Disable SpotBugs enforcement on select artifacts

odlparent has started enforcing SpotBugs by default, but some of
our artifacts are not ready for that. Disable enforcement through
the odlparent property and document why we are disabling it.

Change-Id: Ie8d3e43b26efd75e70223dde2b4555865ce25001
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---

diff --git a/benchmarks/pom.xml b/benchmarks/pom.xml
index 54159e3bc9..1d7a0c374b 100644
--- a/benchmarks/pom.xml
+++ b/benchmarks/pom.xml
@@ -20,6 +20,11 @@
     <artifactId>benchmarks</artifactId>
     <version>4.0.0-SNAPSHOT</version>
 
+    <properties>
+        <!-- JMH-generated code does not pass SB (very noisily)-->
+        <odlparent.spotbugs.skip>true</odlparent.spotbugs.skip>
+    </properties>
+
     <dependencies>
         <dependency>
             <groupId>org.opendaylight.yangtools</groupId>
diff --git a/yang-validation-tool/pom.xml b/yang-validation-tool/pom.xml
index dcb90d3814..5d6d0f1912 100644
--- a/yang-validation-tool/pom.xml
+++ b/yang-validation-tool/pom.xml
@@ -20,6 +20,11 @@
     <artifactId>yang-validation-tool</artifactId>
     <version>4.0.0-SNAPSHOT</version>
 
+    <properties>
+        <!-- FIXME: we have some violations here -->
+        <odlparent.spotbugs.enforce>false</odlparent.spotbugs.enforce>
+    </properties>
+
     <dependencyManagement>
         <dependencies>
             <dependency>
diff --git a/yang/yang-data-impl/pom.xml b/yang/yang-data-impl/pom.xml
index 06188af15e..ca1d1a38b4 100644
--- a/yang/yang-data-impl/pom.xml
+++ b/yang/yang-data-impl/pom.xml
@@ -21,6 +21,9 @@
     <properties>
         <!-- FIXME: workaround for MJAVADOC-586 -->
         <maven.compiler.release>8</maven.compiler.release>
+
+        <!-- FIXME: antlr-generated code does not pass SB -->
+        <odlparent.spotbugs.enforce>false</odlparent.spotbugs.enforce>
     </properties>
 
     <build>
diff --git a/yang/yang-data-jaxen/pom.xml b/yang/yang-data-jaxen/pom.xml
index e7bb768f94..ce2dbf3841 100644
--- a/yang/yang-data-jaxen/pom.xml
+++ b/yang/yang-data-jaxen/pom.xml
@@ -21,6 +21,11 @@
     <description>${project.artifactId}</description>
     <packaging>bundle</packaging>
 
+    <properties>
+        <!-- FIXME: we have some violations here -->
+        <odlparent.spotbugs.enforce>false</odlparent.spotbugs.enforce>
+    </properties>
+
     <dependencies>
         <dependency>
             <groupId>com.google.guava</groupId>
diff --git a/yang/yang-model-export/pom.xml b/yang/yang-model-export/pom.xml
index 0d8294398a..4ae34e1650 100644
--- a/yang/yang-model-export/pom.xml
+++ b/yang/yang-model-export/pom.xml
@@ -21,6 +21,11 @@
     <name>${project.artifactId}</name>
     <description>${project.artifactId}</description>
 
+    <properties>
+        <!-- FIXME: we have some violations here -->
+        <odlparent.spotbugs.enforce>false</odlparent.spotbugs.enforce>
+    </properties>
+
     <dependencies>
         <dependency>
             <groupId>org.opendaylight.yangtools</groupId>
diff --git a/yang/yang-parser-rfc7950/pom.xml b/yang/yang-parser-rfc7950/pom.xml
index 1e2913170e..681d90c2cf 100644
--- a/yang/yang-parser-rfc7950/pom.xml
+++ b/yang/yang-parser-rfc7950/pom.xml
@@ -24,6 +24,9 @@
     <properties>
         <!-- FIXME: workaround for MJAVADOC-586 -->
         <maven.compiler.release>8</maven.compiler.release>
+
+        <!-- FIXME: antlr-generated code does not pass SB -->
+        <odlparent.spotbugs.enforce>false</odlparent.spotbugs.enforce>
     </properties>
 
     <dependencies>
diff --git a/yang/yang-xpath-impl/pom.xml b/yang/yang-xpath-impl/pom.xml
index 9d4e6aa8e7..43988872dd 100644
--- a/yang/yang-xpath-impl/pom.xml
+++ b/yang/yang-xpath-impl/pom.xml
@@ -25,6 +25,9 @@
     <properties>
         <!-- FIXME: workaround for MJAVADOC-586 -->
         <maven.compiler.release>8</maven.compiler.release>
+
+        <!-- FIXME: antlr-generated code does not pass SB -->
+        <odlparent.spotbugs.enforce>false</odlparent.spotbugs.enforce>
     </properties>
 
     <dependencies>