send EOR marker after initial route exchange

JIRA: BGPCEP-807

Change-Id: I374826c8faaa94e8ba8394588b7de0a00acf101f
Signed-off-by: Matej Perina <matej.perina@pantheon.tech>

Migrate Matchers.any()

This method has been moved to ArgumentMatchers, make the switch.

Change-Id: I710791942f2f342e636cc77713e8867b3a75cd32
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add RevisedErrorHandlingSupport ParserConstraint

We need to communicate to the parser whether RFC7606 is enabled
and whether the peer is internal or external. This patch adds
the interface to do that.

JIRA: BGPCEP-359
Change-Id: Id123c4d25019bd1be1ec7b228cd010c81186a4a4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

introduce graceful restart speaker capability

JIRA: BGPCEP-808

Change-Id: I6c4ac1b7697311c31405d0c660fb3e53ca1d8e78
Signed-off-by: Matej Perina <matej.perina@pantheon.tech>

Add Ipv4Util.prefixForByteBuf(ByteBuf, int)

This utility method is needed to parse the IPv4 prefix in two separate
validation steps.

Change-Id: I43f05987222c2cd953760d0b57c3f73240d75f1b
JIRA: BGPCEP-359
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump to yangtools-2.1.4 and mdsal-3.0.2

This bumps the dependencies to 2.1.4 and 3.0.2, respectively.

Change-Id: I73c9ae102298ae3c7bae7f3d1a74a43b626509ba
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

introduce graceful restart listener capability

JIRA: BGPCEP-807

Change-Id: I0f31bd03d63ec48749d8cf4a2491016e30180c0f
Signed-off-by: Matej Perina <matej.perina@pantheon.tech>

add option to close peer session without notification

- from RFC4724 comes need to have option to close
  session without sending NOTIFICATION in certain
  situations

JIRA: BGPCEP-807

Change-Id: Ib560c3a15c1f2227829c151697a6fde98e3a7eed
Signed-off-by: Matej Perina <matej.perina@pantheon.tech>

Remove AttributeParser.parseAttribute(ByteBuf, int)

We require peer information for parsing, promote the peer-aware
parsing method as the primary contract.

JIRA: BGPCEP-359
Change-Id: I7fe039034563ce416ac6f6d08fbf6de867c35344
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove MessageParser.parseMessageBody(ByteBuf, int)

This method is no longer the proper entrypoint, remove it and update
all parsers to implement the replacement.

JIRA: BGPCEP-359
Change-Id: I6fff6cf9f0275d9562c9e37ce55d34287251794b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Reduce use of newArrayList()/newHashSet()

These methods are not needed with modern java, do not use them.

Change-Id: If6cb8780f2277c80ef84d72daa89f92833677e84
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Require Peer to return a FluentFuture

Rather than specifying ListenableFuture, make sure we get a FluentFuture.

Change-Id: I35999c0c7ae8c0c5fa64fdbf4391b6604c60f91c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove duplicate message type check

Rather than performing two instanceof checks, use an if/else
construct to dispatch message.

Change-Id: I4ce5aba7e1c826fe343b279c9767193d0ba83154
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

SERO & SRRO

https://tools.ietf.org/html/rfc8306#section-3.2

JIRA: BGPCEP-406
Change-Id: I47e496fc821325b30c31368a4f906a2cb66434b2
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Decouple sero/srro subojects models from sero/srro objects models

JIRA: BGPCEP-406

Change-Id: I197735ed18278dec010f5e595c7619efb8c5d232
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Assert route change identifier being IdentifiableItem

Rather than doing a straight cast, verify the object beforehand,
giving us a proper data instead of a ClassCastException.

Change-Id: Ia9dafc9d62028fbe66fc11036d6873821c5ef8a7
JIRA: BGPCEP-848
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix an eclipse nullness warning

Eclipse (rightfully) flags this access as potentiall null. Since
we are invoking an interface getter, it is not statically known that
the two invocations will return the same value.

Cache the second field access in a local variable, which ensures
we access the property exactly once, which keeps eclipse happy.

In case the implementation LazyDataObjectModification, this has
the benefit of not deserializing twice.

Change-Id: Idfb8c631bc0267a63710c2cb650e6bda1c227df3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

use multi thread executor in unit tests

- instantiatie AbstractConcurentDataBroker the way to use
  CachedThreadPoolExecutor instead of DirectExecutor
- with new executor we are not in sync with .get() on transaction
  future, so timers continuos verification with timeout is used
  in tests where needed

JIRA: BGPCEP-847

Change-Id: I86cbe54a17e65d4ac7bdc7ca447ac58f345c473a
Signed-off-by: Matej Perina <matej.perina@pantheon.tech>

BGP Stats collector

simplify synchronization of stats

JIRA: BGPCEP-846
Change-Id: I55d30f9cddb33006fb8d2519ddbe9f8b330de71b
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

PCEP Thread deadlock

Change-Id: I7b1f6fcf8c678c76750c501ce979813a20fa8313
JIRA: BGPCEP-845
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Do not create empty route list container

to keep consistency with mdsal changes

Change-Id: Ibd58e7538fbefda96f96d7b3166553c3f8f27181
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Encode with Base64 Linkstate route key

Change-Id: Ib9e9803d6c8287dffb97e9c89b5e975db60bc979
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Update ObjectParser API

- return Object Class
- return Object Type

This will allow to simplify parser registration
and remove duplicated code.

Change-Id: I1f712f87ad0be190db45e77cc13f55ab6352c2a7
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix application peer handling of DISAPPEARED / APPEARED case

JIRA: BGPCEP-843

Change-Id: I82368d8cf029ffe83391333c6e11633511688b69
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Solve deadlock

JIRA: BGPCEP-841
Change-Id: I9daaa786e9d1b1cf7aa74141d346f1bd86b36452
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Migrate bgp-benchmark to MD-SAL APIs

Change-Id: Ie6a1bfcd810524b08485537b6b2e54ceb6c2bf49
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Migrate pcep to MD-SAL APIs

Change-Id: Id3e35a7636cd6b4b7e0d319a022ba588840de67c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Migrate programming controller mdsal

Change-Id: If52a3d8ac73e92965d207d3fe8b1e1c154a5947a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Migrate controller mdsal

Change-Id: Ie2e5014495890f0f153df3011d49558939c4d6d8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Move back to using RC7223 models

Bumping to RFC8343 was a mistake, move back to using RFC7223.

Change-Id: I57fc1d0ff1229b91b8d641d5a0caa9a0a766a027
JIRA: TSC-179
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unnecesary feature

from config loaader feature

Change-Id: I48b767c52265f50072bb82afde7df8b1c5dede97
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix handleDeletions

JIRA: BGPCEP-840
Change-Id: Icef3407608e526f95621ae786524b70c0358d3d1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

use thread-safe list in ConfigLoaderImplTest

- to prevent ConcurrentModificationException in
  situation when List.stream() is called at same
  time as List.clear()

JIRA: BGPCEP-829

Change-Id: I9e69971de5ec75ca515e81e2b95fe44e50489fda
Signed-off-by: Matej Perina <matej.perina@pantheon.tech>

Fix LEAK: ByteBuf.release()

JIRA: BGPCEP-839
Change-Id: I07692d26e7b8cbb3b1134a61f2ea0c5947b8bd81
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Integrate MRI projects for Neon

This patch bumps:
- odlparent to 4.0.2
- yangtools to 2.1.2
- mdsal to 3.0.1

It also fixes assumptions around list presence when it is empty.

JIRA: BGPCEP-827
Change-Id: Ifecf9e3a7909f2a95776a90e27316f0902ca12cd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix LinkstateTopologyBuilder NPE

JIRA: BGPCEP-838

Change-Id: Ie5ba13434245195d77e3c29850cf54ef973e3441
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

remove redundant ImmutableMap call

Change-Id: Idfbbfa44a0835a9caaf0c094b89a2c841224bb09
Signed-off-by: Matej Perina <matej.perina@pantheon.tech>

Include Routes Node when generating route path

Given that it is common node, therefore
duplicate code can removed and is easier for user.

Change-Id: I5babaf17c9b70258aa7772e7cd5c443dcad9a442
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove unneeded references to yang-maven-plugin

This artifacts do not contain a yang model, there is no point
in invoking the plugin.

Change-Id: I8f9dc452e61542310bd28afc3dc024551f754c28
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

BGPCEP-829 fix concurrent access to config file

- calling handleConfigFile from two differrent threads was
  causing ConncurentModificationException in ConfigLoaderImpl
  test

Change-Id: I9ada792c98aafc06daa8971b75df22b85b3ff4c1
Signed-off-by: Matej Perina <matej.perina@pantheon.tech>

Handle RT removal at different level

under eff-rib-in.

JIRA:BGPCEP-830

Change-Id: Id0539fe1334a03847c1cfeb66dfb074821e8b6ae
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Migrate bgpcep docs to the bgpcep project

Issue: DOCS-69
Change-Id: I855bbc445316b0b0fef428666cd31eb56f7bac12
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Bootstrap bgpcep documentation

Issue: DOCS-69
Change-Id: Ia94987eddf0ce52e73b1244770a97f43555e4a8b
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Switch PCEP to no-zone ip addresses

This patch adjusts the model to take advantage of the fact we never
see a zone here -- which leads to slightly faster serialization.

Change-Id: I1aced577b32822a9e8541ed15fcdb958cf1b766d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

BGPCEP-826: Add route target extension StatementActivator service

to META-INF.services

Change-Id: Iab969af474936dd226d255d5bf6d618d0b3845ba
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit ae9ede56f51ed2530c867b1d9a8626163be33bc2)

Fix findbugs warnings

These bugs are reported by upgraded findbugs, fix them prior
to the actual upgrade.

Change-Id: I0c21059a289abec1631f3a7b324c771091930804
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Return Set instead of Iterable in test setup

This allows us to define equality in superclass, hence return
proper Set.

Change-Id: Ic37c3283ff234181320201f18e14047d6aa92d37
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove references to mdsal-model-artifacts

This artifact is going away, migrate to mdsal-artifacts.

Change-Id: I1810e2f18c600e219610d6975241edbd6e9faf22
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions by x.(y+1).z for next dev cycle

Change-Id: Iaad861760cea380b06505b3ebe54f7d77ac48a20
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Bump yangtools to 2.0.10

This fixes an issue with actions, hence we need it in Fluorine.

Change-Id: Ie12ee96d9659441d45a144cc99ef46af912dab76
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use newly-introduced type-safe methods

New methods allow us to precisely target specific case items.

Change-Id: I22c3df0c9bb94767b769020e3d87cad9b4cf7f2d
JIRA: MDSAL-342
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Workaround for jenkins Route target test

JIRA: BGPCEP-817
Change-Id: I4bb5bbc0c39388669bb811ad85b12df2394a21f6
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Adjust for API change

Returned collection type changed slightly, fix that up.

Change-Id: Ib0fede6f8646692d8a9c06740572f51063ba8ccf
JIRA: MDSAL-342
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump yangtools to 2.0.9

This patch bumps yangtools to latest release.

Change-Id: Ie31438a7ce35a149f72a8b024ac2e19e4b736bcd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

fix timing issue in server creation for BmpMockTest

- add wait unitl server is created

Change-Id: Id217822e57be8c7df1139341af9ade2517dad516
JIRA: BGPCEP-815
Signed-off-by: Matej Perina <matej.perina@pantheon.tech>

Bump to odlparent 3.1.3

Change-Id: I10266e55e95d2697ab8c92c47ac0f08c05a31d71
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Use moved BindingReflections

BindingReflections is moving away, make sure we are using the new
version.

Change-Id: I972cad0c094457519a12dba058d43836b045a78c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Reduce use of waitFutureSuccess utility

Change-Id: I5c24101645c592052155402cc3835e63dfc690d1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Rework BmpMockDispatcherTest

- Use test timeout instead of waitFutureSuccess utility
- use blocking futures

JIRA: BGPCEP-814
Change-Id: If21621f2e0aaf3c903671f395d051d6dfca0daa0
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix calculation and roll-over of BGP operational neighbor uptime value.

Change-Id: I15211d925664f275f1980df863cf6cefce8c0ba4
JIRA: BGPCEP-813
Signed-off-by: Ajay Lele <ajayslele@gmail.com>

Cleanup feature dependencies

Some of our basic features do a rather massive over-inclusion,
fix that.

Change-Id: I483d6b9d83b60087c64589abb19d7fa13e3ff75c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove powermock dependency

powermock is not used anywhere, remove the dependency declaration.

Change-Id: I475eda21b1448cbab46837796f03bdaef409fbfb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Minimize model dependencies

Change-Id: I829e2411b605963ad642b8a9255297ed1b7cd208
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use union stringValue()

getValue() is going away, use stringValue(), which is its replacement.

Change-Id: I1112f5417bb41bd21b7a53913b615afc4c34c190
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Add mdsal-dom-api dependency"

This reverts commit cb0fe804f72ec0c8fb7a002dcf2c64d6b097d489.

Change-Id: I106d1d102fc3b1c9a611cfe05d691aa319131c03
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Add mdsal-dom-api dependency

We are now getting mdsal-dom-api, make sure we account for that.

Change-Id: Ib736e51b4ca833b7748d2b2741408d1695386018
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Convert rsvp-api to use ip-address-no-zone

First step in conversion, more to follow.

Change-Id: I94c7efcdb5fdb6248797105e73e4cacd5b7f5816
JIRA: BGPCEP-790
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add required mdsal-dom-api test dependency

Change-Id: If7dbb7302d25c09ae5b4b4c839632fbb2b817371
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Handle no present ext community for VpnNonMemberHandler

avoiding possible NPE

JIRA: BGPCEP-811
Change-Id: I1a597d712bb847ca5708345248c2b06766ecd002
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix invalid models

These models do not contain correct import stanzas and were resolved
accidentally via prefixes declared in modules thy are importing.

JIRA: YANGTOOLS-889
Change-Id: Ia94e3f78ed4a9aec8b55743b821373738b4e6c54
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix invalid tests

Generated unions are enforcing length/range of included types,
which means unit tests which use illegal values need to be fixed
up.

Change-Id: Ieb6ff3b2dca42cef5f104ac976e1e54835fba06c
JIRA: MDSAL-360
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Switch pce-id to a simple type

Union of binary with different lengths does not really make sense,
use length alternatives instead.

Change-Id: I76cd4ad77b51d3e6e6a0522aa5457e7ce56fd590
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Route Target Constrain Default Routing Policies Config

JIRA: BGPCEP-527
Change-Id: Ic59614fd81015a66d2ee4d7d9659f273457f21db
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Follow common singleton pattern

for condition handlers.

Change-Id: Id8568ca0231565e509ce741c9a4fb91f7a6355ff
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Route Constrain policies

Actions
 - Prepend client attribute

JIRA: BGPCEP-527
Change-Id: I24719e1c6a41c11165437539cc8a7714240da798
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Implement Set Next Hop Type Self

remove duplicated route policy, using
openconfig one.

Change-Id: I04fc6167956134bb2769cedbc04df48fb3d4c943
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Improve CSS logs

Change-Id: I263d506fb7ba340ecf84c541a08367f458b8ec92
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix checkstyle complains

Change-Id: If6d289edfc8eaab6946fb5c5b3d379909fdbaf98
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bump yangtools to 2.0.7

This patch brings in the latest yangtools release.

Change-Id: Ib25415ef91d228abb3b0c0674452078d4d3377d3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix checkstyle complains

Change-Id: I692780c68bc2d57e497fac10e5595550f020b5cf
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Handle correctly peer group name

when removing peer

JIRA: BGPCEP-804
Change-Id: I11b1e6d222900be5f2986274ad7c0f92c4ba2c35
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Rib Out Route Paths re evaluation.

Allow to perfom a reevaluation of one specific table,
and update rib out for an specific peer.
This will allow to re evaluate paths advertized
for an specific peer when two families are interconnected
like RT and VPN, reducing the volume of message it can
produce to reevaluate the full table for all peers.

JIRA: BGPCEP-527
Change-Id: I3056aa2e4a2e9b94fb9c4a1c99a09fe972500f4f
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Reduce duplicated code

- reduce noisy log TRACE

Change-Id: I46fc307441f0ca3226f63a0e13c3084c2ed930e8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Route Constrain policies

Conditions
- afi-safi-not-in

Actions
- set-local-address-as-next-hop
- set-originator-id-to-advertizer-router-id

JIRA: BGPCEP-527
Change-Id: I9f784175440fa6f5ab7e7d33cd1d9a72e4bf1ad5
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix invalid rsvp model

Augmenting the same choice with equally-named containers from
a single model is data tree namespace violation. Fix that.

Change-Id: I36eea127a33ade8dec108042bd43dac12e97e64e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix invalid flowspec model

Augmenting the same choice with equally-named containers from
a single model is data tree namespace violation. Fix that.

Change-Id: Icb5f1580c23fd53365481c89111888566eb04747
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update supported afi/safi for bgp testtool

Change-Id: I954354918f7d8a0d3433c6a9068cdca870550345
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix Route target nlri default route serialization

Change-Id: Ic9b16ad72415631efd7814992e99e6b98f1d98f0
JIRA: BGPCEP-802
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bump odlparent to 3.1.2

Change-Id: Ib8005701ca2b775ff14431c0667be1dafc709cfb
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Route Target constrains Extension

https://tools.ietf.org/html/rfc4684

JIRA: BGPCEP-527
Change-Id: Idcb79c3072caa19775a48fbf6980cc8b89504eea
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Improve handling for protocols config changes

Given the dependency of Peers of Rib.
When delete
 - remove first peers
 - then remove Rib
when modification
 - update rib
 - then update peers

JIRA: BGPCEP-799

Change-Id: I582398dab191842473f7cbbd1010b76fe9a9d9fd
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Handle trailing bits under L3vpn mcast

deserialization.

Change-Id: Ib46b269ec0d6138a0234e4478e7d62420814a3bd
JIRA: BGPCEP-800
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Move route target ext comm container

outside extendend communities cases.
 Allowing to reuse the models.

Change-Id: I9faab101f4b5ed0613fe26646be9da2fad58b942
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Inherit common extensions families dependencies

from extensions parent

Change-Id: Ic115f76bd184142d15e9b42f69f80dfd12fa375a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Create common parent for extensions families

Change-Id: I9aff6bb41e565df54fcbcfb660ac014b7547c334
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Code clean up

- remove unnecesary returns
- simplify asserts
- remove unnecesary casts

Change-Id: I5f1410b35bcb6552e6ecd94d08a155dfbc295d9a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Simplify assertions

Change-Id: I119df17bdb5a7bbb54245c52b6927ba05f853c0e
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove unused imports

Change-Id: I5ee0880720e5aee4ddb695d7d4d57010fee67ff3
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Enforce fail on maven-dependency-plugin warning

- fix complains

Change-Id: I2917adc88b3251f39afceff371996d26a6501dbc
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Provide Empty table instead of empty route container

by ribSupport.

Change-Id: Ie75c0005484caf749425551779e6e6a413c72f13
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>