Alien flows in operational datastore.

If statistics from device were too fast while batch of flows
it caused that for some of them (somethimes all) wasn't generated
flow ID. Thus flows from statistic didn't have ID only alien ID.

In this fix operational datastore with all flows is deleted everytime
when flow statistics are received. Flows from statistics are looked up
in flow registry. If found then stored ID is used, if not then new
alien ID is generated.

Change-Id: I039daac851208d60c5c7c63d65a7ffba58ae6a6a
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Bug 3208: Add actions SetNsch[1-4] and matches Nsch[1-4]

Change-Id: Ifd8788dc171b9071b6141f4108edf801a54aff9a
Signed-off-by: Ed Warnicke <hagbard@gmail.com>

Merge "fix parital multipart processing"

fix parital multipart processing

Change-Id: I7428a7df9e448d766a491f15535356c9ace7f0d9
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Adaptive throttling

  - throttling is based on md-sal publishing capacity
  - regulation is based on ability to offer new nottification
  - close now throws only SecurityException

Change-Id: Ia29b78ea9bec6bd544a62a61c0dc358cfb01936d
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

adapted to notificationProvider API

Change-Id: I50ceba80dd8125b0037e7ae970e0150615f086be
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Merge "Explicitly set git-review branch to master"

Explicitly set git-review branch to master

Change-Id: I667e4b078afe82d492857ceb6b1f363d2ead98e4
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

fix npe when calculating IpMatchHash

Change-Id: I32a0af1b840cb1716be40f8a7596e1fa235f51b8
Signed-off-by: Martin Bobak <mbobak@cisco.com>

hashed wheel timer lenght prolonged

Change-Id: I934f028f4a9c7f962143e08f4b282ba1d005e2ee
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Merge "un - throttle connection interval set to 10ms"

Merge "HashedWheel timer tick duration set to 10ms"

Merge "DeviceFlowRegistryImpl uses HashSet instead of ArrayList"

Merge "DeviceContextImpl uses HashSet instead of ArrayList"

Merge "StatisticsContextImpl uses HashSet instead of ArrayList"

Merge "RpcContextImpl uses HashSet instead of ArrayList"

Merge "changed log level to debug"

un - throttle connection interval set to 10ms

Change-Id: I887ddf453c06203f107db12fbb082a9b7c3ca793
Signed-off-by: Martin Bobak <mbobak@cisco.com>
(cherry picked from commit 199e8cd252cf5dfde1e4c161d50eeb6876b692f3)

HashedWheel timer tick duration set to 10ms

Change-Id: I29221888dabbf856de0e26304824ad28c3bd760f
Signed-off-by: Martin Bobak <mbobak@cisco.com>
(cherry picked from commit 67d4ef643b1a16f26abc5a0f006e1c4e8a7fa806)

DeviceFlowRegistryImpl uses HashSet instead of ArrayList

Change-Id: I333031330279e5d56b2cedef5be29614cec47c5b
Signed-off-by: Martin Bobak <mbobak@cisco.com>
(cherry picked from commit c7d744538d466aa20c5d6bf117e6a4549efe0386)

DeviceContextImpl uses HashSet instead of ArrayList

Change-Id: If1a0606bc0cfad7c48f6c0172b1a4ab3b26d6ff9
Signed-off-by: Martin Bobak <mbobak@cisco.com>
(cherry picked from commit 7936b51a1ff5671c268da6149d9fea3b0cf36048)

StatisticsContextImpl uses HashSet instead of ArrayList

Change-Id: Ib962a35f5323db0670c016220ff6d0b3ad5ee0b9
Signed-off-by: Martin Bobak <mbobak@cisco.com>
(cherry picked from commit ad090d357d4545947a6a34a6c01f39c4f309e664)

RpcContextImpl uses HashSet instead of ArrayList

Change-Id: I78b5c4f02e1318e0562c8bd6595c63b21c39e3ea
Signed-off-by: Martin Bobak <mbobak@cisco.com>
(cherry picked from commit deba865e660aab31820f51df6cc9d7c53d36d7d7)

changed log level to debug

Change-Id: I1820ebd13c9166d198a87e5f1f8d3b4e64891008
Signed-off-by: Martin Bobak <mbobak@cisco.com>
(cherry picked from commit 53121333e59c9096b9647bb46303d1cf22be2019)

BUG 2429 - not releasing dead connection threads

Implementation of fix for this bug was added also to
Lithium codebase.

Change-Id: Id807d54b0f7f0eec0e83f078579f893f818fe0e1
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
(cherry picked from commit 1510a4b08068939f3fb3342c5d47d5b42a629f6f)

Merge "Adding required capabilities for LLDP Speaker."

Adding required capabilities for LLDP Speaker.

Adding required capabilities tags to xml of LLDP Speaker
for config subsystem.

Change-Id: Ie5a713ab5845651fd16c0897adfecadab6e0d106
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Adding required capabilities for FRM.

Adding required capabilities tags to xml of FRM for config subsystem.

Change-Id: I77a35265c4529ce289c6a76fdc64ac7d2f676c66
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

binding thread pools in drop test to target node

Change-Id: I593fb2d9dee8d991522d7538a8144b6c74c4417a
Signed-off-by: Martin Bobak <mbobak@cisco.com>

flow hash should be written to device flow registry only if alien ID was generated

Change-Id: I649171151ea2079e56ca200a353f2cff0658973c
Signed-off-by: Martin Bobak <mbobak@cisco.com>

performance fix - nodeConnector II reuse

 - instead of full creating of instanceIdentifier of nodeConnector
   we now reuse instanceIdentifier of node and add just nodeConnector part

Change-Id: I7f55fc73d38f716d3d8b08d65ba5bdc68174dad7
Signed-off-by: Martin Bobak <mbobak@cisco.com>

FlowRegistryException is not used anymore

Change-Id: I407c837aeb9e65ae79ed25c8f4e93ff6f8d43d3d
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Merge "internal message statistics available trough JMX bean"

internal message statistics available trough JMX bean

Change-Id: Id49ab7080ee396e16af2f06282f1cc6b5e268010
Signed-off-by: Martin Bobak <mbobak@cisco.com>

more of internal flow mode stats

Change-Id: Iaaafcd27e4fc81b3fa0e60f16f0f1907e5edbf99
Signed-off-by: Martin Bobak <mbobak@cisco.com>

added internal stats for packetIn+addFlow

Change-Id: Ie179559c2ceffdb74412843cce5298b0bc57bf9d
Signed-off-by: Martin Bobak <mbobak@cisco.com>

connection adapter is set to autoread = false when notofications are not handled

Change-Id: Ie97ed2237a862c64dbd7b7616dce37ef98f3673e
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Fix LOG: private static final

Change-Id: Id153479e96cf97d17064e7f90b4661982dcf2da1
Signed-off-by: Martin Bobak <mbobak@cisco.com>

DeviceFlowRegistry doesn't use ConcurrentHashMap

Change-Id: I3d670585272ec986c078fa2a2ca392e452c22bd3
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Added signum where missing

 - for BigInteger ctor based on byte[] it might get negative value
 - 1 is for positive value - replaced by constant

Change-Id: I478880925dabeae7296222e731800c55b92b8175
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Eliminating new BigInteger where possible

Change-Id: I5c2b7d209f4c80e8cc4d0320f4e7f01f28963b54
Signed-off-by: Martin Bobak <mbobak@cisco.com>

fixed pool size

Change-Id: I1097a0860a55bdeaabd399c7bd826fb4730c4875
Signed-off-by: Martin Bobak <mbobak@cisco.com>

DeviceContext changes approach to synchronization

Instead of creating synchronization locks on whole DeviceContext object,
we create locks on relevant fields.

Change-Id: I593d579a2d4c40eb8b5aef29f7c7c76f5e918e70
Signed-off-by: Martin Bobak <mbobak@cisco.com>

CommonService has its fields private

Change-Id: I24a3ecf9ab3b869cc0575f4b36b4a7effb6a468a
Signed-off-by: Martin Bobak <mbobak@cisco.com>

removed worthless logging wrapping

Change-Id: If005d2a5e84a187e6798629015b133f41e436f5d
Signed-off-by: Martin Bobak <mbobak@cisco.com>

changed approach to synchronization of DeviceContext

Change-Id: I557bf7c894708a1612feb9d304bee70b68667109
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Merge "deviceCtx should not be used where is not needed"

Merge "Use ImmutableMap for TranslatorLibrary"

Merge "Lower fast-path locking in RpcContext"

deviceCtx should not be used where is not needed

Change-Id: Iec28b063342a13aafed81ee0cae49852561ab34c
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Use ImmutableMap for TranslatorLibrary

There is no need for this to be concurrent.

 - fixed typo

Change-Id: If189f01e931e066205aa12108775a8c28e9c404c
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Lower fast-path locking in RpcContext

Instead of acquiring the lock three times, perform common operations
under the lock and then follow-up without it.

 - fixed typo

Change-Id: Ie5b3f5cdd388c54f170e2a742855a6e654094994
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Merge "add flowHash to device registry only after flow is successfully written to DS"

add flowHash to device registry only after flow is successfully written to DS

Change-Id: Ib3b746140462bab3fa632f23c67fb6088266184e
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Cleanup BaseCallback

The fields should be private and final, so clean them up, making the
lifecycle much easier to understand.

Change-Id: I54b029ded933f2f56da6559b0991e2fdd7d5a91d
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix null check

Preconditions.checkNotNull() was not used correctly. Fix that up.

Change-Id: I31582fd72365e4ad7c457f4e7cba4286bf133782
Signed-off-by: Robert Varga <rovarga@cisco.com>

Lower the size of deviceContext synchronized block

The synchronized block is needlessly large, slowing things down with
unrelated transitions happening.

Change-Id: I700ba58f567c592a611fd50f94cf27594385f865
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fixed Scariest level bugs from findbugs.

Change-Id: I22b51dd31887c9c61a049b7c06835f082fd7fd4f
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Martin Bobak <mbobak@cisco.com>

optimized usage of registry

Change-Id: I9f7a551e172cb932af0f7b13d4c47f0a30db59d5
Signed-off-by: Martin Bobak <mbobak@cisco.com>

optimized removal request context from registry

Change-Id: I0f73d5abe4dd15e525725a6f4ceec3f57f387b26
Signed-off-by: Martin Bobak <mbobak@cisco.com>

TranslatorLibrary holds translators in synchronized structure

Change-Id: I2fbbba39bbfa67937af7306ea63ce85005aa1f9c
Signed-off-by: Martin Bobak <mbobak@cisco.com>

hash usage optimized

Change-Id: Ie84d00786e0e2f74a45c20dfdec52f7f1c11e3ea
Signed-off-by: Martin Bobak <mbobak@cisco.com>

all device registries holds its data in synchronized lists

Change-Id: I4e47ea5d7ec0f46595d97771d3a0b40ace5ae88c
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Added threadpool to droptest.

Droptest was stealing MD-SAL threads to do its work,
which actually make it dependable on MD-SAL thread count.

Droptest nows own own threadpool - so it should not be affected
by number of threads in MD-SAL.

Change-Id: I6ecf05e6b6f02b5790044888cf03642d7587d413
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Merge "code cleanup"

code cleanup

- removed unused imports and commented lines

Change-Id: I4b47b032536a45bf93289e6f7a008dc43dd2027f
Signed-off-by: Martin Bobak <mbobak@cisco.com>

fixed logging output

Change-Id: I6e54da6e6b5be0b187fba0539e7a2c777c82af37
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Merge "BUG-3129 NPE in flowHash"

BUG-3129 NPE in flowHash

 - tableId and priority are mandatory
 - flowCookie will fallback to default (0) value

Change-Id: I9bf082178847544f1672b294b5461ea192e6b16f
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Merge "bug 3126 - shift to new notification service"

sanitized transaction operations

 - put and delete are wrapped inside of try-catch
   this way data still will be lost but next operation
   can be scheduled
 - added some more logging

Change-Id: I91b161603db994ef9a2b4879ddae78d8f8bee919
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Merge "added transaction commit time expenses"

added transaction commit time expenses

 - hooking callback on checked future reterned by tx.submit()

Change-Id: I09f8bad1284b0fa58464460a8a64d5e445ed3543
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Merge "scheduled transaction submit skipped when tx empty"

Merge "bug 3118 - statistics polling should react on datastore operation time"

scheduled transaction submit skipped when tx empty

 - separated counter and tx-submit-switch
 - improved scheduling of submit
 - skipped useless submits

Change-Id: I49fd60e38e3351d3f2d9cb2a28e84db7c8a13a9d
Signed-off-by: Martin Bobak <mbobak@cisco.com>

bug 3126 - shift to new notification service

Change-Id: Id25983e139b521075a21d579fe12afd9db2b9363
Signed-off-by: Martin Bobak <mbobak@cisco.com>

bug 3118 - statistics polling should react on datastore operation time

- also cleaned up unused dependencies in StatisticsContextImpl

Change-Id: I55c0ab6f5cd74bd0e5e64229b876d03ee63378d5
Signed-off-by: Martin Bobak <mbobak@cisco.com>

fixed flow hash equals

 - getters delivered default zero/null values
 - updated unit tests

Change-Id: I5806678ce0d047fd25356d9278cdd7f8f1d0351c
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Merge "Write to operational DS response of update-table rpc."

Merge "removed unused method"

Write to operational DS response of update-table rpc.

Write table features which were received as RPC response to
operational datastore (replace all corresponding data in datastore)

Change-Id: I615a26775019f4c79f292e0a95f3c1ac0ca9f116
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

BUG 3119 - Empty flow statistics for OFv10.

During building body of multipart request for flow statistics wildcards were missing.

Change-Id: Ib2e3658a342b991f0c5550780bbea72cccc8d7d1
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

removed unused method

Change-Id: Iadfdb55f25e0760add08438a2e30b21569c48458
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Merge "BUG 3114 - Fixed NPE in table features reconciliation."

BUG 3114 - Fixed NPE in table features reconciliation.

Change-Id: I6bf31f4ab08f9ccde0a1266f833626bce77444f4
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

fix removed tables for OF-1.0

 - empty tables must be written after device description message
   is processed (and written into flowCapableNode - above tables)

Change-Id: Ia052caa103f51e578406cfc8f8128c5a26b99f12
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Merge "process flows statistics in one commit tx only when device is synchronized"

Merge "Adding test for updating table-features."

Merge "Speedup local karaf distro."

process flows statistics in one commit tx only when device is synchronized

Change-Id: I1d3490686445836299e3058a3102889e5c67549c
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Adding test for updating table-features.

Added test for testing writting table-features to operational datastore
via FRM.

Reverting test for FlowListenerTest (currently TableForwarder isn't listening
on changes on node Table (also flow changes were caught) but on TableFeatures.
Therefore original test which tested direct equality on transaction DOM-xxx ID
can by again applied.

Change-Id: Iabf27ab01d0f11095af65e45374dba581c1656f7
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Speedup local karaf distro.

 - by removing odl-restconf boot feature

Change-Id: I716469f96208d84a5f6dbf7ed9dff668725d0e91
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

sal-table:update-table rpc (service) implementation

According to yang this rpc should return only xid. In SalTableServiceImpl
is obtained data as OFPT_MULTIPART_REPLY type OFPMP_TABLE_FEATURES
which can be used to return more meaningful output (instead just xid)

Change-Id: I8a448fadab2884f8e2bd8518c69e50dc83102573
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Merge "lower log severity to warn where appropriate"

Merge "avoid flow number oscilation by deleting and writing flow stats in single commit tx"

avoid flow number oscilation by deleting and writing flow stats in single commit tx

Change-Id: I863e6b2e86a43cb5bfcde23dc99a44288a670b19
Signed-off-by: Martin Bobak <mbobak@cisco.com>

lower log severity to warn where appropriate

 - decreade log contamination

Change-Id: I311ebdba69ab44af20bb8dd1261d4a0db94af7d2
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Merge "Improving logging in DeviceContext and MultiMsgCollector."

Improving logging in DeviceContext and MultiMsgCollector.

Change-Id: I82a72d384e651798d29e8997a8dfd90449d819a0
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>