Merge "Bug 4736 - Add null poiner check of getFixedIPs()"

Drop duplicate classes

Use a single copy of MdsalUtils, SouthboundUtils, SouthboundConstants
and SouthboundMapper.

Minor clean-ups.

Check the operational ingress flow at the end of testDefaultsSG().

Change-Id: Ib8713f6ad0e8f5eec1693ef36ebf6095fd43ce09
Signed-off-by: Stephen Kitt <skitt@redhat.com>

test code to debug it getFlow errors 2

Change-Id: I0086ddb3f846893c7c48cb24ebf1eaff21a4e5f9
Signed-off-by: Sam Hague <shague@redhat.com>

Merge "Adding integration tests for Security Groups (fixed and default SG)"

Merge "Use SouthboundUtils in SouthboundIT"

Merge "Extract neutron-utils from mdsal-utils"

Use SouthboundUtils in SouthboundIT

Change-Id: I2fd8466e650df77af031f75cfa36a04275847124
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Extract neutron-utils from mdsal-utils

NeutronModelsDataStoreHelper adds a dependency on neutron, so it
should really be in its own bundle.

Change-Id: I051b304c77aeee9cbe5a1309bb2f512d87d7387a
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Merge "Create McastMacs by Listening DS Changes"

Merge "test code to debug it getFlow errors"

Adding integration tests for Security Groups (fixed and default SG)

Change-Id: I83eda5e2d78cda71cf9563ed3309af743c212ade
Signed-off-by: raveek <raveek@hp.com>

Create McastMacs by Listening DS Changes

PathSet 2:
1. change according review comments

Change-Id: I446a25ad8a4abed4866285d24442b3405375bdd0
Signed-off-by: Peng Zhang <pzhang@ctbri.com.cn>

test code to debug it getFlow errors

Change-Id: Ieb0acaa495a3e7f917d540d93d95086aa8cd486d
Signed-off-by: Sam Hague <shague@redhat.com>

Bug 4736 - Add null poiner check of getFixedIPs()

NeutronPort.getFixedIPs() can return null.  In netvirt code, some
codes have null pointer check, some doesn't inconsistently.  Add null
pointer check consistently to avoid potential null pointer exception.

Change-Id: I69054f21bd2b18d6861e310a2f5e3e34d8b5a6de
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Create UcastMacs by Listening DS Changes

PathSet 1:
1. create UcastMacsLocal/Remote command
2. add UcastMacs restconf api to postman collection
3. delete physical locator update/remove command

PatchSet 2:
1. change according review comments

PathSet 3:
1. change according review comments

Change-Id: If926651a84d4ae4bac496eb9ca76b36f67b0a3f3
Signed-off-by: Peng Zhang <pzhang@ctbri.com.cn>

Merge "standalone demo fixes for SFC model changes"

Merge "BUG 4718 - null pointer exception in NeutronSubnetChangeListener.java"

standalone demo fixes for SFC model changes

Change-Id: I8b9d6fac59f3c3002e7af8843df2fcb1d5ab43d8
Signed-off-by: Sam Hague <shague@redhat.com>

Merge "Use a logger instead of printStackTrace"

Merge "Fix updatedUMacsRemoteRows null check"

Merge "update IT for new SFC model changes for DPLs"

Merge "OVSDB QoS - move QoS and Queue lists to OVSDB Node"

Merge "Create Physical Port By Listening on DS changes"

update IT for new SFC model changes for DPLs

Change-Id: Ia9f13fb72da10d21d521e5ba1d7746f6980356fe
Signed-off-by: Sam Hague <shague@redhat.com>

Use a logger instead of printStackTrace

Drop commented code.

local_ip -> localIp to follow conventions.

Change-Id: I6b6f674d70af3eb894819d15fb80b762678e3742
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Fix updatedUMacsRemoteRows null check

The null check confuses Sonar; since the member variables are never
null (TyperUtils.extractRowsUpdated never returns null), and are only
initialised in the constructor, make them final and drop the null
check. The isEmpty() check is redundant with the for loop.

Remove the logger which isn't used.

Clean up some whitespace issues.

Change-Id: Ia234546957ff11901300149a5bac45c7bc0c9c96
Signed-off-by: Stephen Kitt <skitt@redhat.com>

BUG 4718 - null pointer exception in NeutronSubnetChangeListener.java

When subnet are created/deleted, the following null pointer exception
occurs.
Although the bug highlights only neutron subnet case, this patch
synchronizes null pointer checks in org.opendaylight.ovsdb.openstack.
netvirt.translator.iaware.impl.Neutron*ChangeListener.fromMd() to
the corresponding ones in
org.opendaylight.neutron.transcriber.Neutron*Interface.fromMd()

> 2015-12-03 10:18:45,889 | TRACE | lt-dispatcher-32 | NeutronSubnetChangeListener      | 267 - org.opendaylight.ovsdb.openstack.net-virt - 1.2.1.SNAPSHOT | Data changes : Translated
> DataChangeEvent{created={KeyedInstanceIdentifier{targetType=interface org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.subnets.rev150712.subnets.attributes.subnets.Subnet, pat
> h=[org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.rev150712.Neutron, org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.subnets.rev150712.subnets.attributes.Subnets, org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.subnets.rev150712.subnets.attributes.subnets.Subnet[key=SubnetKey [_uuid=Uuid [_value=0c103011-92f2-4e88-985a-10dd56b67a95]]]]}=Subnet{getAllocationPools=[AllocationPools{getEnd=10.100.0.14, getStart=10.100.0.1, augmentations={}}], getCidr=10.100.0.0/28, getDnsNameservers=[], getIpVersion=class org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.constants.rev150712.IpVersionV4, getName=, getNetworkId=Uuid [_value=17ce32b1-455e-4c2f-8819-b5a1374637ed], getTenantId=Uuid [_value=dee4a5dd-9482-4cf5-9c26-fc492cef01a2], getUuid=Uuid [_value=0c103011-92f2-4e88-985a-10dd56b67a95], isEnableDhcp=true, augmentations={}}}, updated={}, removed=[], dom=DOMImmutableDataChangeEvent [created=[/(urn:opendaylight:neutron?revision=2015-07-12)neutron/subnets/subnet/subnet[{(urn:opendaylight:neutron?revision=2015-07-12)uuid=0c103011-92f2-4e88-985a-10dd56b67a95}]/ip-version, /(urn:opendaylight:neutron?revision=2015-07-12)neutron/subnets/subnet/subnet[{(urn:opendaylight:neutron?revision=2015-07-12)uuid=0c103011-92f2-4e88-985a-10dd56b67a95}]/enable-dhcp, /(urn:opendaylight:neutron?revision=2015-07-12)neutron/subnets/subnet/subnet[{(urn:opendaylight:neutron?revision=2015-07-12)uuid=0c103011-92f2-4e88-985a-10dd56b67a95}]/network-id, /(urn:opendaylight:neutron?revision=2015-07-12)neutron/subnets/subnet/subnet[{(urn:opendaylight:neutron?revision=2015-07-12)uuid=0c103011-92f2-4e88-985a-10dd56b67a95}], /(urn:opendaylight:neutron?revision=2015-07-12)neutron/subnets/subnet/subnet[{(urn:opendaylight:neutron?revision=2015-07-12)uuid=0c103011-92f2-4e88-985a-10dd56b67a95}]/allocation-pools, /(urn:opendaylight:neutron?revision=2015-07-12)neutron/subnets/subnet/subnet[{(urn:opendaylight:neutron?revision=2015-07-12)uuid=0c103011-92f2-4e88-985a-10dd56b67a95}]/tenant-id, /(urn:opendaylight:neutron?revision=2015-07-12)neutron/subnets/subnet/subnet[{(urn:opendaylight:neutron?revision=2015-07-12)uuid=0c103011-92f2-4e88-985a-10dd56b67a95}]/uuid, /(urn:opendaylight:neutron?revision=2015-07-12)neutron/subnets/subnet/subnet[{(urn:opendaylight:neutron?revision=2015-07-12)uuid=0c103011-92f2-4e88-985a-10dd56b67a95}]/name, /(urn:opendaylight:neutron?revision=2015-07-12)neutron/subnets/subnet/subnet[{(urn:opendaylight:neutron?revision=2015-07-12)uuid=0c103011-92f2-4e88-985a-10dd56b67a95}]/dns-nameservers, /(urn:opendaylight:neutron?revision=2015-07-12)neutron/subnets/subnet/subnet[{(urn:opendaylight:neutron?revision=2015-07-12)uuid=0c103011-92f2-4e88-985a-10dd56b67a95}]/cidr], updated=[], removed=[]]}
> 2015-12-03 10:18:45,889 | ERROR | lt-dispatcher-32 | DataChangeListener               | 140 - org.opendaylight.controller.sal-distributed-datastore - 1.3.0.SNAPSHOT | Error notifying listener org.opendaylight.ovsdb.openstack.netvirt.translator.iaware.impl.NeutronSubnetChangeListener
> java.lang.NullPointerException
>         at org.opendaylight.ovsdb.openstack.netvirt.translator.iaware.impl.NeutronSubnetChangeListener.fromMd(NeutronSubnetChangeListener.java:145)[267:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.translator.iaware.impl.NeutronSubnetChangeListener.createSubnet(NeutronSubnetChangeListener.java:97)[267:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.translator.iaware.impl.NeutronSubnetChangeListener.onDataChanged(NeutronSubnetChangeListener.java:87)[267:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.controller.md.sal.binding.impl.AbstractForwardedDataBroker$TranslatingDataChangeInvoker.onDataChanged(AbstractForwardedDataBroker.java:143)[115:org.opendaylight.controller.sal-binding-broker-impl:1.3.0.SNAPSHOT]
>         at org.opendaylight.controller.cluster.datastore.DataChangeListener.dataChanged(DataChangeListener.java:66)[140:org.opendaylight.controller.sal-distributed-datastore:1.3.0.SNAPSHOT]
>         at org.opendaylight.controller.cluster.datastore.DataChangeListener.handleReceive(DataChangeListener.java:39)[140:org.opendaylight.controller.sal-distributed-datastore:1.3.0.SNAPSHOT]
>         at org.opendaylight.controller.cluster.common.actor.AbstractUntypedActor.onReceive(AbstractUntypedActor.java:34)[136:org.opendaylight.controller.sal-clustering-commons:1.3.0.SNAPSHOT]
>         at akka.actor.UntypedActor$$anonfun$receive$1.applyOrElse(UntypedActor.scala:167)[125:com.typesafe.akka.actor:2.3.14]
>         at akka.actor.Actor$class.aroundReceive(Actor.scala:467)[125:com.typesafe.akka.actor:2.3.14]
>         at akka.actor.UntypedActor.aroundReceive(UntypedActor.scala:97)[125:com.typesafe.akka.actor:2.3.14]
>         at akka.actor.ActorCell.receiveMessage(ActorCell.scala:516)[125:com.typesafe.akka.actor:2.3.14]
>         at akka.actor.ActorCell.invoke(ActorCell.scala:487)[125:com.typesafe.akka.actor:2.3.14]
>         at akka.dispatch.Mailbox.processMailbox(Mailbox.scala:238)[125:com.typesafe.akka.actor:2.3.14]
>         at akka.dispatch.Mailbox.run(Mailbox.scala:220)[125:com.typesafe.akka.actor:2.3.14]
>         at akka.dispatch.ForkJoinExecutorConfigurator$AkkaForkJoinTask.exec(AbstractDispatcher.scala:397)[125:com.typesafe.akka.actor:2.3.14]
>         at scala.concurrent.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260)[122:org.scala-lang.scala-library:2.10.4.v20140209-180020-VFINAL-b66a39653b]
>         at scala.concurrent.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339)[122:org.scala-lang.scala-library:2.10.4.v20140209-180020-VFINAL-b66a39653b]
>         at scala.concurrent.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)[122:org.scala-lang.scala-library:2.10.4.v20140209-180020-VFINAL-b66a39653b]
>         at scala.concurrent.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)[122:org.scala-lang.scala-library:2.10.4.v20140209-180020-VFINAL-b66a39653b]

Change-Id: Icc0957fc961aae7ef277b57df9d8ce4f4b923d24
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Fix for wrong tun_dst

Change-Id: Iee2066da9c3f4af393583e013462bf8caa7d96eb
Signed-off-by: Sam Hague <shague@redhat.com>

Create Physical Port By Listening on DS changes

PatchSet 2&3:
share code and change it according comments

PatchSet 4:
rebase on 'Create Physical Switch'

PathchSet 5:
1.rebase on 'Yang changes and cleanup'
2.finish creating physical port
3.rewrite HwvtepOperationalState

PatchSet 6:
change code according comments

PatchSet 7:
rebase on master branch

PathchSet 8:
fix a nullpoint bug

Change-Id: I425336aea3b055ee4d7e75bd26490e194340e3af
Signed-off-by: Peng Zhang <pzhang@ctbri.com.cn>

OVSDB QoS - move QoS and Queue lists to OVSDB Node

The QoS and Queue tables are root tables in OVSDB.  Updates to
these tables can occur independently from the port table - so
this patch proposes to move lists of QoS and Queue entries to
the ovsdb-node-attributes (i.e. OVSDB Node) object in the MD-SAL.

v2 - removed the 'do not merge' notice from subject line

Change-Id: I77654f144ec6876f0a807b6b723d723e691215f1
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>

Bug 4704 - unbreak compile error of missing symbol of getSubnets

Due to the changeset of neutron nerthbound of
8f43dc56a5e2684ffcc2de4435e87d8ea68a06e6, the following compilation errors
occurs. This patch resolves it by removing those unused functions.
NOTE: This is a compatibility breakage by neutron northbound and such
breakage should be fixed somehow.
Given that the result of getSubnets() will be unreliable (so its usage
is discouraged) and that ovsdb/netvirt already doesn't use
it and related methods, it makes sense to remove references to those
methods.

> [INFO] -------------------------------------------------------------
> [ERROR] COMPILATION ERROR :
> [INFO] -------------------------------------------------------------
> [ERROR] /home/yamahata/openstack/odl/odl/ovsdb/openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/translator/iaware/impl/NeutronNetworkChangeListener.java:[131,20] cannot find symbol
>   symbol:   method getSubnets()
>   location: variable network of type org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.networks.rev150712.networks.attributes.networks.Network
> [ERROR] /home/yamahata/openstack/odl/odl/ovsdb/openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/translator/iaware/impl/NeutronNetworkChangeListener.java:[133,39] cannot find symbol
>   symbol:   method getSubnets()
>   location: variable network of type org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.networks.rev150712.networks.attributes.networks.Network
> [ERROR] /home/yamahata/openstack/odl/odl/ovsdb/openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/translator/crud/impl/NeutronNetworkInterface.java:[137,20] cannot find symbol
>   symbol:   method getSubnets()
>   location: variable network of type org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.networks.rev150712.networks.attributes.networks.Network
> [ERROR] /home/yamahata/openstack/odl/odl/ovsdb/openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/translator/crud/impl/NeutronNetworkInterface.java:[139,39] cannot find symbol
>   symbol:   method getSubnets()
>   location: variable network of type org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.networks.rev150712.networks.attributes.networks.Network
> [ERROR] /home/yamahata/openstack/odl/odl/ovsdb/openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/translator/crud/impl/NeutronNetworkInterface.java:[239,27] cannot find symbol
>   symbol:   method setSubnets(java.util.List<org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.yang.types.rev130715.Uuid>)
>   location: variable networkBuilder of type org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.networks.rev150712.networks.attributes.networks.NetworkBuilder

Change-Id: Ifdcc3c71968bfd2e1773b609b36d7902d66a30da
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Merge "Delete without reading"

Delete without reading

MD-SAL ignores deletions of non-present nodes, so it's safe to delete
without reading first.

Change-Id: I825e46f2e07310d3fddedc1d5200dc80b35d8456
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Add Others Command Skeleton Code

PatchSet2:
rebase on master

PatchSet3:
rebase on "Fix IT tests as per as API change in SFC"

Change-Id: I4b437c6c61f733d91a4bf7b63d8167e2f37f7a85
Signed-off-by: Peng Zhang <pzhang@ctbri.com.cn>

Merge "Fix IT tests as per as API change in SFC"

Merge "Yang changes and cleanup"

Fix IT tests as per as API change in SFC

Those changes were made in SFC:
https://git.opendaylight.org/gerrit/#/c/29303/16/sfc-model/src/main/yang/service-function-forwarder.yang

This patch reflects those changes

Change-Id: I4c07b8b0f9b9e5957b24824fd8da8edd2155cbc6
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Merge "Avoid exceptions with IPv6 subnets"

Yang changes and cleanup

This commits changes how locator-sets are defined and used
in yang file. This also includes code changes to accomodate
yang file changes and some refactoring to make code bit more
simpler and added some error checking.

Patchset2:
1. Added uuid fields for some objects
2. Fixes some issues found in testing physicalLocatorUpdate

Change-Id: Ia55a3bbd15030c7a8fb5cf6276e705097e1da57e
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>

Avoid exceptions with IPv6 subnets

In a setup where ODL is used for L2 support and Neutron L3 agent
is used for Routing, we see some Java exceptions when IPv6 subnets
are created. Because of the Java exception, Layer2 connectivity
is lost and we are unable to work with IPv6 subnets. In this patch,
we log an error instead of exception.

Patch set 2: add other places in netvirt code where ipv6 (address and prefix)
             could be used and it would be improperly interpreted.

Patch set 3: minor code review changes.

Change-Id: I4e253f8f86a1a3f027e57861549e9a1f98ff5fbf
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Signed-off-by: SridharG <sgaddam@redhat.com>

Merge "Use odlparent-lite as artifacts parent"

Merge "Create Physical Switch by listening on DS"

Merge changes from topic 'sonar-cleanup'

* changes:
  Remove unused code and imports
  General code cleanup
  Simplify AbstractNeutronInterface::readMd

Merge "Drop redundant ofPort check"

Merge "Inline return values"

Merge "Added Update and Remove commands code"

Merge "Changes to LogicalSwitchUpdateCommand in transact as per new yang"

Use odlparent-lite as artifacts parent

We created odlparent-lite to provide a minimal pom which allows projects
to publish to the correct server. Without this ${project}-artifacts may
fail to deploy to Nexus.

Change-Id: Iec5b15f027a64ad9498fcd9c874be1b4e57e682c
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Create Physical Switch by listening on DS

PatchSet2:
1. fix update issue
2. update postman collection

PatchSet3:
1. change according to review comment

PatchSet4:
1. fix IP To String issue

Change-Id: I16357d027bdcd8b03e2f0a0d2bedf57bd4a4864f
Signed-off-by: Peng Zhang <pzhang@ctbri.com.cn>

Merge "Avoid calling the String constructor explicitly"

Added Update and Remove commands code

McastMacsLocalUpdate/Remove done.
UcastMacsLocalUpdate/Remove done.
LogicalSwitchRemoveCommand updated as per new yang.
Some minor fixes done in PhysicalLocatorUpdateCommand.

Redundant Blanks and comments removed.
Some comments Updated.

Change-Id: I4e19fc42e0c935da99e3330e442067b2c62be694
Signed-off-by: karanrajsingh <karan.raj.s.singh@ericsson.com>

Changes to LogicalSwitchUpdateCommand in transact as per new yang

1. changes to LogicalSwitchUpdateCommand in transact
2. remove redundant code

PatchSet 2:
1. Get "extractCreated" back

PatchSet 3:
1. Change postman collection as per new yang

Patchset 4:
Fixed update issue in LogicalSwitchUpdate command

Change-Id: If2f34ed570bfa0f265c976178272dc07674766ec
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>

Remove unused code and imports

Change-Id: I9f9fe46abc4feba4a0795b8380b5c9bf4e894716
Signed-off-by: Stephen Kitt <skitt@redhat.com>

General code cleanup

Use <> where appropriate.

Remove a couple of unnecessary unboxing statements.

Reduce variable scope.

Simplify a couple of boolean expressions (Optional<T>.get() is
instanceof T if it's not null).

Fix up some documentation.

Change-Id: I6db39ad20e3245c03fff94cb96fbc8b09f4f57dc
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Simplify AbstractNeutronInterface::readMd

Use B for the parameter type to avoid masking the main T parameter
type.

Inline the optional handling.

Change-Id: I3f54589aec36b7fb378d7a0936743961946aa11b
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Drop redundant ofPort check

Because of the break in the loop, ofPort is always 0 when the if
statement is reached, so it can safely be removed.

Change-Id: Ia700962e9d5a7d8a4dd0fa1af61811694ac366fe
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Inline return values

Change-Id: Iea346d6682801f11e69a22c0330aabcef2a0dd4c
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Merge "Add option to use netdev datapath_type"

Add option to use netdev datapath_type

Change-Id: Ica37449612dc2465ddd71bfc19caa9a599354c34
Signed-off-by: Sam Hague <shague@redhat.com>

Avoid calling the String constructor explicitly

Change-Id: I3f57df03746acafe11def7cdced65822b31117a5
Signed-off-by: Stephen Kitt <skitt@redhat.com>

yang changes, PhysicalLocator and UcastMacsRemote

1. Added PhysicalLocator and UCastMacsRemote Update code.
2. Yang: Modified logical-switch-ref to correct type based on recent
changes
3. Yang: Moved all mac attributes to Global node from PhysicalSwitch.

Change-Id: I1a51ea9a4423144892488d9de6d01e7b5271d18b
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>

Merge "Changes to LogicalSwitchUpdate as per new yang"

Merge "Added UT and refactored code 1) Added UT for SecurityServicesImpl and SecurityGroupCacheManagerImpl. 2) Refactored a method in SecurityServicesManager."

Merge "UT for ProtocolRemovedCommand class"

Merge "Clean up L2ForwardingService"

Merge "Move NetvirtIT to use latest IT parent poms"

Move NetvirtIT to use latest IT parent poms

Change-Id: If59f183f08b0a98514ff1db4c6e0fb7cc1c2ed7c
Signed-off-by: Sam Hague <shague@redhat.com>

Changes to LogicalSwitchUpdate as per new yang

Patchset2: review comments

Change-Id: I0bff6c4a2dbcb63fde20da8c2595061af5e8bca2
Signed-off-by: karanrajsingh <karan.raj.s.singh@ericsson.com>

Added UT and refactored code
1) Added UT for SecurityServicesImpl and SecurityGroupCacheManagerImpl.
2) Refactored a method in SecurityServicesManager.

Change-Id: I039d34869d182bc19ad89733092e0a5f35f67295
Signed-off-by: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>

Merge "Change hwvtep.yang and fix related code"

Change hwvtep.yang and fix related code

1. Change hwvtep.yang based on https://git.opendaylight.org/gerrit/#/c/29797/.
2. Fix related code.

Change-Id: I314ddc23daebe59bd3ed241fa80803ce4845ef37
Signed-off-by: Peng Zhang <pzhang@ctbri.com.cn>

Merge "Test code for failing IT test 2"

Test code for failing IT test 2

Change-Id: Idf46604a17d5b96f3b62f29f17be1fbeb12d2b67
Signed-off-by: Sam Hague <shague@redhat.com>

Test code for failing IT test

Change-Id: I250408640b46e60d0ae67bfe75b898fb077ea2ff
Signed-off-by: Sam Hague <shague@redhat.com>

UT for ProtocolRemovedCommand class

Change-Id: Icd2b454b49b214735540c20281d6611071309947
Signed-off-by: Layth Al-Ani <lalani@inocybe.com>
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Clean up L2ForwardingService

Avoid multiple instanciations of MatchBuilders.

Factor common code involved in FlowBuilder setup and instruction
construction, adding appropriate methods in FlowUtils and
InstructionUtils.

Use fluent-style builders.

Drop appendResubmitLocalFlood() which isn't used.

Avoid multiple creations of the same Uri in loops.

Two of the FlowBuilders don't have a setStrict() call; is that
intentional?

Change-Id: I984a735229613bd013443ff16815a1566a74b2d5
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Merge "L3: Add eth to br-ex"

Handle new base type provided by MD-SAL

When deserialized, OvsdbBridgeAugmentation's datapathType is now
initialized as DatapathTypeBase instead of null. This is now handled
as an absent value in SouthboundMapper instead of producing an
IllegalArgumentException.

The exception's message is clarified to trace the unknown datapath
type class, instead of the value retrieved from the map (which is
always null in this case).

Change-Id: Ie10ff09878bf182d4747d63f1580a37dfd71ac88
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Merge "Remove a few obsolete dependencies"

Remove a few obsolete dependencies

A security upgrade for commons-collections was released, but it turns
out ovsdb no longer uses it; this patch removes that from dependency
management along with a couple of other obsolete dependencies.

Change-Id: I7d3ba0c908e5306475f35ce9e07b0099f9c8f4cf
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Use an Autoclosable to guarantee bridge clean-up

TestBridge encapsulates a bridge created in OVSDB; with
try-with-resources this means we know we always clean the bridges up.

Change-Id: Iac00febaa8525d985bd4ba2b71393dd1d086c314
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Share a single OVSDB connection among all tests

This helps SouthboundIT greatly, and the OVSDB is clean after the
tests finish.

Change-Id: I0ee431a269468b973cc01bd07bb766950f0b5a52
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Merge "Maven cleanup and features-parent migration"

Merge "Added code for PhysicalPort, LogicalSwitch"

Merge "Added support to update flows for induvidual security rule add/remove , after the SG is associated with a port."

Merge "Use MD-SAL events to react to OVSDB changes"

Merge "SouthboundIT: merge the CRUD tests methods"

Maven cleanup and features-parent migration

Use features-parent {{VERSION}} to allow dropping a number of Maven
properties.

Upgrade commons-collections (1.0 -> 3.2.1) and httpcomponents (4.2.1
-> 4.4.1).

Drop a number of obsolete components from dependency management
(controller:commons.northbound, controller:containermanager,
controller:forwardingrulesmanager, controller:sal,
controller:switchmanager.

Use odlparent-provided versions of commons-lang3, most netty
components, and the equinoxSDK381 components.

Drop obsolete io.netty:netty:3.8.0 dependency (replaced by
io.netty:netty-all in versions 4+).

Remove some duplicate dependency declarations.

Use "<relativePath/>" instead of "<relativePath></relativePath>" now
that it's safe to do so (the auto-release scripts handle it).

Change-Id: I62a385ba49d79e045934ec706f69313425553ae0
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bug 4641 - openstack.net-virt-sfc-features fail to find artifacts

Change-Id: Ie9110ebcfb7412015c171e0add5faa89ecd5d293
Signed-off-by: Sam Hague <shague@redhat.com>

Added code for PhysicalPort, LogicalSwitch

1. Added PhysicalPortUpdate and PhysicalPortRemove
2. Added LogicalSwitchUpdate and LogicalSwitchRemove
With these changes physical-port and logical-switch changes on device are
reflected in OperationalDS.

Patchset2:
1. Rebase
2. Add VlanBindings to OperationalDataStore
3. Use env vars for IPs in postman collection
4. Fixed a bug in postman collection

Change-Id: Ic1b3d0e15088db6d81316ad88c2db5299a9c9be0
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>

Merge "Listen config DS then push configuration to switch"

Merge "Bug 4641 - openstack.net-virt-sfc-features fail to find artifacts"

Bug 4641 - openstack.net-virt-sfc-features fail to find artifacts

Change-Id: Iccc0c5d817db0014842f5e7023b173c67af728e2
Signed-off-by: Sam Hague <shague@redhat.com>

Listen config DS then push configuration to switch

Patch Set 1:
1. Add skeletal code for command pattern to push configuration to switch, function TBD.
2. Implement LogicalSwitchUpdateCommand.

Patch Set 2:
1. Fix whiteapce issues.
2. Add 'logical-switch-managed-by' for logical-switch-attribute in hwvtep.yang.
3. Use hcm.getConnetionInstance(node) added in https://git.opendaylight.org/gerrit/#/c/29599.

Patch Set 3:
1. Fix LOG severities and delete some TODOes.
2. Use HwvtepSchemaConstats.databaseName for Hwvtep database name.

Change-Id: I0fe5dafdf9ecfa91ee8c757c4b694a50e6cbed35
Signed-off-by: Peng Zhang <pzhang@ctbri.com.cn>

Merge "rework sfc flows 2"

Merge "Patch Set 1: Add postman collection for HwvtepSouthbound"

rework sfc flows 2

Change-Id: I9cb93d19d54cd7bcf7d93ab82e17dbe7579cafb3
Signed-off-by: Sam Hague <shague@redhat.com>

Merge "Security Groups: Added support for ICMP, ALL ICMP and Others protocol Change-Id: Iedc3061ccaf03f21b9a39da8a4b8b27c4baea6f0 Signed-off-by: raveek <raveek@hp.com>"

Merge "Fixed possible null point exception in node manager entries update code"

Patch Set 1:
Add postman collection for HwvtepSouthbound

Patch Set 2:
Add brief introduction in README

Patch Set 3:
Change to multi-line version

Patch Set 4:
Fix whitespace issues

Patch Set 5:
Fix whitespace issues: a trailing space missed

Patch Set 6:
recheck

Change-Id: If7a764ca56ced4316aa04ff8538bf12849d60dd9
Signed-off-by: Peng Zhang <pzhang@ctbri.com.cn>