D Arunprakash [Wed, 14 Mar 2018 09:39:00 +0000 (15:09 +0530)]
Make TCs to assert on actual values and remove toString asserts
Make assert on getValue insteadOf on toString values.
toString() method implementation change might break the ofp
TCs, to avoid these errors assert on actual values
Change-Id: I687ab07badca72f2f0489660ea5a8e0ebcaded07
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
D Arunprakash [Wed, 14 Mar 2018 02:00:40 +0000 (07:30 +0530)]
TCs in ofp failing as yang class toString method defintion changed
[1] https://git.opendaylight.org/gerrit/#/c/68958/
Due to patch in mdsal [1], yang generated toString is giving
different output and it is causing someof the TCs to fail in
openflowplugin.
Modified the comparision equivalent to the generated toString
output
Change-Id: Ibf7b4f629b296ffe59897f2206f8ab54fea5907b
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
Anil Vishnoi [Mon, 12 Mar 2018 18:22:56 +0000 (18:22 +0000)]
Merge "OPNFLWPLUG-981: per-capability configuration for stats polling"
Evan Zeller [Sat, 24 Feb 2018 00:05:34 +0000 (16:05 -0800)]
OPNFLWPLUG-981: per-capability configuration for stats polling
Implemented granular config knobs to enable or disable statistics
polling for each of the OpenFlow capabilities. Only if supported by
device and enabled by this configuration will the plugin poll the
statistics. By default all are enabled.
Change-Id: Ic0bc81f1f2efc51f96dc6ccd94e803b70ad14174
Signed-off-by: Evan Zeller <evanrzeller@gmail.com>
Yrineu Rodrigues [Thu, 22 Feb 2018 18:01:09 +0000 (10:01 -0800)]
OPNFLWPLUG-951: Adding equal role functionality
Change-Id: Ief56ad88f05ce8c89e04243d655d5f89d73a8d00
Signed-off-by: Yrineu Rodrigues <yrineu.rodrigues@luminanetworks.com>
Abhijit Kumbhare [Wed, 7 Mar 2018 01:32:06 +0000 (01:32 +0000)]
Merge "OPNFLWPLUG-983 Group and flow removal stats are not reported in order"
Evan Zeller [Thu, 1 Mar 2018 04:19:19 +0000 (20:19 -0800)]
OPNFLWPLUG-984: always use ingress node for link discovery
Using the LLDP destination (packet-in ingress) guarantees that the
receiving controller is the owner of the device. Relying on the LLDP
source can cause a scenario where the LLDP packet never appears in the
entity-owner of the source device.
Change-Id: I8ad4171cdae395d260b754b95e5d9b75138fb79b
Signed-off-by: Evan Zeller <evanrzeller@gmail.com>
(cherry picked from commit
36722d99c3a17bb23d4299a906591f11a9847f03)
Anil Vishnoi [Wed, 28 Feb 2018 07:15:16 +0000 (23:15 -0800)]
OPNFLWPLUG-983 Group and flow removal stats are not reported in order
Change-Id: I6f66a40b0434d02fc32b3aa38f8e3834bad57005
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Tom Pantelis [Fri, 2 Mar 2018 18:20:40 +0000 (13:20 -0500)]
Enable findbugs in parent pom
Change-Id: Ib9c64da593973b23c0bf2d3bf499adc95e16df54
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Fri, 2 Mar 2018 18:08:03 +0000 (13:08 -0500)]
Fix findbugs violations in test-provider and drop-test-karaf
- Field only ever set to null
- int value cast to float and then passed to Math.round
- Possible null pointer dereference in method on exception path
- Non-virtual method call passes null for non-null parameter
- Comparison of String parameter using == or !=
- Should be a static inner class
- Private method is never called
- int value cast to float and then passed to Math.round
- Unread field
- Unread field: should this field be static?
- Unused field
- Dead store to local variable
- Private method is never called
- Method uses the same code for two switch clauses
- Write to static field from instance method
- Field not initialized in constructor but dereferenced without null check
Change-Id: Ib09380d626ab9162c4308810fae9db90522269cf
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Fri, 2 Mar 2018 03:12:28 +0000 (22:12 -0500)]
Fix findbugs violations in openflowplugin-impl
- Method ignores exceptional return value
- Check for sign of bitwise operation
- Consider using Locale parameterized version of invoked method
- Reliance on default encoding
- Synchronization performed on util.concurrent instance
- Unchecked/unconfirmed cast
- Unchecked/unconfirmed cast of return value from method
- Return value of method without side effect is ignored
- Dead store to local variable
- Method uses the same code for two branches
- Load of known null value
- Parameter must be non-null but is marked as nullable
- Field not initialized in constructor but dereferenced without null check
Change-Id: I92e00a5772038111d1ab8d9f53d52c43e3f4909d
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Mon, 19 Feb 2018 01:56:48 +0000 (20:56 -0500)]
Fix findbugs violations in openflowplugin
- Comparison of String parameter using == or !=
- Comparator doesn't implement Serializable
- Field is a mutable collection
- Incorrect lazy initialization of static field
- Inefficient use of keySet iterator instead of entrySet iterator
- Private method is never called
- Unsigned right shift cast to short/byte
- Class is final but declares protected field
- Consider returning a zero length array rather than null
Change-Id: I714bd4005a33a772b0b76b0c0f89f28b8517cd06
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sun, 18 Feb 2018 18:37:10 +0000 (13:37 -0500)]
Fix findbugs violations in extensions
- Dead store to local variable
- Unchecked/unconfirmed cast
- Field not initialized in constructor but dereferenced without null check
- Method ignores return value
- Private method is never called
Change-Id: I7a3fe1700439b456cb7dce6d84f63a9840fd68a7
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sat, 17 Feb 2018 23:31:07 +0000 (18:31 -0500)]
Fix findbugs violations in samples
- Inconsistent synchronization
- Using notify() rather than notifyAll()
- Method ignores return value
- Read of unwritten field
- Field not initialized in constructor but dereferenced without null check
Change-Id: I12e8ae3ab25cc41ba05b99e9e4c85f2606a2814d
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sat, 3 Feb 2018 01:43:09 +0000 (20:43 -0500)]
Fix findbugs violations in liblldp
- Method call passes null for non-null parameter
- Class defines clone() but doesn't implement Cloneable
- Clone method may return null
- clone method does not call super.clone()
- equals() method does not check for null argument
- Reliance on default encoding
- May expose internal representation by returning reference to mutable object
- Field is a mutable collection which should be package protected - malicious code vulnerability
- Field should be package protected - malicious code vulnerability
- Inefficient use of keySet iterator instead of entrySet iterator
- Boxing/unboxing to parse a primitive - use parseXXX method
- Redundant nullcheck of value known to be non-null
Change-Id: I6d551d31d618a1adfc877ac59f29d02727201df6
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Fri, 2 Feb 2018 23:30:41 +0000 (18:30 -0500)]
Fix findbugs violations in applications
- Method ignores return value
- Consider using Locale parameterized version of invoked method
- Reliance on default encoding
- Write to static field from instance method
- Inefficient use of keySet iterator instead of entrySet iterator
- Dead store to local variable
- Consider returning a zero length array rather than null
- Consider using Locale parameterized version of invoked method
- Boxing/unboxing to parse a primitive - use parseXXX method
- Unread field
- Dead store to local variable
- Non-transient non-serializable instance field in serializable class
- Parameter must be non-null but is marked as nullable
- Field not initialized in constructor but dereferenced without null check
- Nullcheck of value previously dereferenced
- Redundant nullcheck of value known to be non-null
Change-Id: I1887f775f61fb8e3e6989113edf7faf4f9b06b34
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Fri, 2 Feb 2018 15:20:10 +0000 (10:20 -0500)]
Fix findbugs violations in openflowjava
- Invocation of toString on an array
- Check for sign of bitwise operation:
Example: ((event.detail & SWT.SELECTED) > 0)
Using bit arithmetic and then comparing with the greater than operator
can lead to unexpected results (of course depending on the value of
SWT.SELECTED). If SWT.SELECTED is a negative number, this is a candidate
for a bug. Even when SWT.SELECTED is not negative, it seems good practice
to use '!= 0' instead of '> 0'
- Reliance on default encoding - performs a byte to String (or String to byte)
conversion, and will assume that the default platform encoding is suitable.
- Primitive value is boxed then unboxed to perform primitive coercion
- Unread field
- Result of integer multiplication cast to long - possible overflow
- Dead store to local variable - assigns a value to a local variable, but
the value is not read or used in any subsequent instruction.
- Method uses the same code for two switch clauses
- Load of known null value
- Consider returning a zero length array rather than null
- Redundant nullcheck of value known to be non-null
- Field not initialized in constructor but dereferenced without null check
- Non-transient non-serializable instance field in serializable class
- Class implements same interface as superclass
Change-Id: I28b533c9f9805de539e35b729c5163fd22e75354
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Fri, 2 Feb 2018 02:41:25 +0000 (21:41 -0500)]
Enable checkstyle enforcement in openflowplugin-parent
This covers all code sub-projects. Also removed checkstyle
configurations in all sub-projects.
Change-Id: Ib93f4abb41e97bc4c803cd54ad1c2ea56040d3db
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Thu, 1 Feb 2018 23:31:11 +0000 (18:31 -0500)]
Fix checkstyle violations in test bundles
Change-Id: Id8e05a621e56dadea15252498bf04505f920441d
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Thu, 1 Feb 2018 19:21:27 +0000 (14:21 -0500)]
Fix checkstyle violations in openflowplugin - part 5
Change-Id: I968d1e7931764b1e27e3aad40a3fd9094c24f270
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Thu, 1 Feb 2018 17:02:29 +0000 (12:02 -0500)]
Fix checkstyle violations in openflowplugin - part 4
Change-Id: Ib9e941db9d2f48b34f713a5618368aff68089e42
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Thu, 1 Feb 2018 03:03:02 +0000 (22:03 -0500)]
Fix checkstyle violations in openflowplugin - part 3
Change-Id: I0d8d7f5cc6c12299d67fbdacc13aafea7c086226
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Thu, 1 Feb 2018 02:16:31 +0000 (21:16 -0500)]
Fix checkstyle violations in openflowplugin - part 2
Change-Id: I83c41416dd64eba991ff95c4afc9e8a2b11e3a31
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Thu, 1 Feb 2018 01:40:55 +0000 (20:40 -0500)]
Fix checkstyle violations in openflowplugin - part 1
Change-Id: Ic66142803cdbc5fcb1e27d1ba8efc62aedceba04
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Faseela K [Fri, 16 Feb 2018 11:31:02 +0000 (17:01 +0530)]
use feature for inter-project dependency
Use feature to express inter-project dependency correctly instead of
bundle.
For details, refer to
https://lists.opendaylight.org/pipermail/release/2018-January/013604.html
https://lists.opendaylight.org/pipermail/release/2017-September/012356.html
This depends on below patch to export necessary bundle as feature.
https://git.opendaylight.org/gerrit/#/c/68318/
Change-Id: I38b4244d7c7622099285669d0ef190bd23c3dc90
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Anil Vishnoi [Mon, 26 Feb 2018 23:22:24 +0000 (23:22 +0000)]
Merge "BUG-86: Fixed echo response processing"
Anil Vishnoi [Mon, 26 Feb 2018 21:58:59 +0000 (21:58 +0000)]
Merge "OPNFLWPLUG-952: All links disappear from the topology"
Anil Belur [Mon, 26 Feb 2018 07:41:45 +0000 (17:41 +1000)]
Bump versions by x.(y+1).z for next dev cycle
Change-Id: Ib83c016ca4bdfc87da9ab847c874afe29a9a710a
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Evan Zeller [Fri, 10 Nov 2017 01:19:28 +0000 (17:19 -0800)]
OPNFLWPLUG-952: All links disappear from the topology
In cluster split situations LLDP Speaker can get into a bad state, with
incorrect number of node-connectors mapped locally. In some cases
multiple controllers can start sending packet outs. The solution here is
to use clustered DTCL to keep the node-connectors more consistent across
all instances of LLDPSpeaker and use EOS to determine who should
actually transmit the packet.
Change-Id: I36df734dff23688e8ace27b42f85291aa62ac391
Signed-off-by: Evan Zeller <evanrzeller@gmail.com>
Jalpa Modasiya [Fri, 16 Feb 2018 19:49:40 +0000 (11:49 -0800)]
BUG-86: Fixed echo response processing
Change-Id: Ib83eb3463d101e872830d3985044c1154668baa1
Signed-off-by: Jalpa Modasiya <jmodasiy@luminanetworks.com>
Tom Pantelis [Wed, 31 Jan 2018 18:24:10 +0000 (13:24 -0500)]
Fix checkstyle violations in openflowplugin extensions
Change-Id: I6c2404ee9e0e30efab156a621bd7e641a78af972
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Wed, 31 Jan 2018 14:50:09 +0000 (09:50 -0500)]
Fix checkstyle violations in openflowjava extensions
Change-Id: Ie4a01ec30e1feb054bfceb52a2598a2936264ace
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Wed, 31 Jan 2018 04:06:41 +0000 (23:06 -0500)]
Fix checkstyle violations in samples
Change-Id: I5879e9d420c57c252d301ce7a5c296f8b5b914a6
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Tue, 30 Jan 2018 23:18:37 +0000 (18:18 -0500)]
Fix checkstyle violations in applications
Change-Id: I1ac5ba94705ffba78d4765185ff6ade5f299a671
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Anil Vishnoi [Thu, 15 Feb 2018 10:02:44 +0000 (10:02 +0000)]
Merge "Fix checkstyle violations in liblldp"
Faseela K [Wed, 14 Feb 2018 11:05:44 +0000 (16:35 +0530)]
export lldp as feature
Those bundles are used by genius and netvirt.
They should be consumable as feature, not bundle.
For detailed discussion, please refer to the followings
https://lists.opendaylight.org/pipermail/release/2018-January/013604.html
https://lists.opendaylight.org/pipermail/release/2017-September/012356.html
Change-Id: I034494a38c88c69c8d75731b73bab7b0f116db9d
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Tom Pantelis [Tue, 30 Jan 2018 19:30:28 +0000 (14:30 -0500)]
Fix checkstyle violations in liblldp
Change-Id: I1006a34064ca339a4280a255074eded82dbf5ce5
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
gobinath [Sun, 4 Feb 2018 20:38:48 +0000 (02:08 +0530)]
OPNFLWPLUG-974: Message deserialization failed
Description:
"Message deserialization failed...msgType: 36864 oxm_field: 6
experimenterID: null was not found - please verify that all needed
deserializers ale loaded correctly".
Observation:
The deserialization of this message failed due to the msg type of one of
the oxm fields (CtMark) was getting decoded wrongly.
This was due to the CtMarkCodec present in the packet(before the Metadata
oxm field) was decoding the field wrongly. The field doesnt have mask field
in it but still the mask it was read, ie, it was reading the next oxm field bytes too(Metadata)
thereby skipping the bytes from which the oxm Metadata is supposed to be read
and hence wrong data(skipped 4 bytes) is decoded in the next oxm field deserialization.
Fix:
The incorrect read of mask field in Ctmark codec has been removed now.
Change-Id: I79b6899686b05217df533e9ef365e9909dfc048d
Signed-off-by: gobinath <gobinath@ericsson.com>
Anil Vishnoi [Tue, 6 Feb 2018 05:03:57 +0000 (05:03 +0000)]
Merge "OPNFLWPLUG-929 : Remove deprecated guava library"
Anil Vishnoi [Tue, 30 Jan 2018 04:54:34 +0000 (04:54 +0000)]
Merge "OPNFLWPLUG-972: Point to openflowplugin liblldp"
Tom Pantelis [Sat, 27 Jan 2018 17:24:44 +0000 (12:24 -0500)]
Fix remaining checkstyle violations in openflowjava
Change-Id: I720977b96996a462946c5b6114a6b6b7dd1285bc
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sun, 21 Jan 2018 02:50:17 +0000 (21:50 -0500)]
Fix checkstyle violations in openflow-protocol-impl - part 12
Many violations - more to follow
Change-Id: I909943b0b0b3e8974dd73422843238042b4bac1b
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sun, 21 Jan 2018 02:05:03 +0000 (21:05 -0500)]
Fix checkstyle violations in openflow-protocol-impl - part 11
Many violations - more to follow
Change-Id: Iaa832ec597a543b1d963cd58307d7fed05f50720
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sun, 21 Jan 2018 01:39:35 +0000 (20:39 -0500)]
Fix checkstyle violations in openflow-protocol-impl - part 10
Many violations - more to follow
Change-Id: I3b7ab07f56a13982f88df17805c3d82bbf14a062
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sun, 21 Jan 2018 01:12:03 +0000 (20:12 -0500)]
Fix checkstyle violations in openflow-protocol-impl - part 9
Many violations - more to follow
Change-Id: Ide57e636e33d752cd9a6c912de071fd1493a7097
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sun, 21 Jan 2018 00:22:57 +0000 (19:22 -0500)]
Fix checkstyle violations in openflow-protocol-impl - part 8
Many violations - more to follow
Change-Id: Ie7aac9d6bc6b1372ff425b89d83cf44b617f7751
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sat, 20 Jan 2018 23:11:32 +0000 (18:11 -0500)]
Fix checkstyle violations in openflow-protocol-impl - part 7
Many violations - more to follow
Change-Id: I35f1ada078217cc89d03f2953829ac2274a53655
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sat, 20 Jan 2018 22:30:59 +0000 (17:30 -0500)]
Fix checkstyle violations in openflow-protocol-impl - part 6
Many violations - more to follow
Change-Id: I18badf1a7b759dfbe63d240ea786c716d3135c97
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sat, 20 Jan 2018 22:11:16 +0000 (17:11 -0500)]
Fix checkstyle violations in openflow-protocol-impl - part 5
Many violations - more to follow
Change-Id: I19ea3b92b66c0121946e88699af5e7c2742ea54d
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sat, 20 Jan 2018 21:45:52 +0000 (16:45 -0500)]
Fix checkstyle violations in openflow-protocol-impl - part 4
Many violations - more to follow
Change-Id: I9107de913adef9e19cdf7583b996598d4b9a63b0
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sat, 20 Jan 2018 21:33:37 +0000 (16:33 -0500)]
Fix checkstyle violations in openflow-protocol-impl - part 3
Many violations - more to follow
Change-Id: I5cba0f1e5d8f61106db5d1461c205b80be585993
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sat, 20 Jan 2018 21:10:55 +0000 (16:10 -0500)]
Fix checkstyle violations in openflow-protocol-impl - part 2
Many violations - more to follow
Change-Id: I360cd3cd431d1c05df1262df8debeb68f95ffac9
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sat, 20 Jan 2018 19:43:20 +0000 (14:43 -0500)]
Fix checkstyle violations in openflow-protocol-impl - part 1
Many violations - more to follow
Change-Id: I3467223dd8ab3a9fe52906a2b029b0ab130b0b7d
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Anil Vishnoi [Sat, 27 Jan 2018 02:20:22 +0000 (02:20 +0000)]
Merge "Spec: OFPGC_ADD_OR_MOD support in openflowplugin"
Anil Vishnoi [Sat, 27 Jan 2018 02:18:06 +0000 (02:18 +0000)]
Merge "Fix checkstyle violations in openflowjava-util"
Anil Vishnoi [Sat, 27 Jan 2018 01:21:19 +0000 (01:21 +0000)]
Merge "Fix checkstyle violations in openflow-protocol-api"
Anil Vishnoi [Sat, 27 Jan 2018 01:06:08 +0000 (01:06 +0000)]
Merge "Remove unused interface"
Anil Vishnoi [Sat, 27 Jan 2018 01:05:25 +0000 (01:05 +0000)]
Merge "Remove dependency on sal-common-util"
Anil Vishnoi [Sat, 27 Jan 2018 01:03:41 +0000 (01:03 +0000)]
Merge "Remove deprecated EOS services"
Robert Varga [Fri, 26 Jan 2018 10:31:49 +0000 (11:31 +0100)]
Remove dependency on sal-common-util
This dependency is no longer used, remove it along with use
of controller's odl-mdsal-common.
Change-Id: Id15cc085c56dcb45796593f12da9b4fd4f95a99b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
D Arunprakash [Tue, 23 Jan 2018 08:47:10 +0000 (14:17 +0530)]
OPNFLWPLUG-929 : Remove deprecated guava library
use overload Futures.transform api
Change-Id: Iba64da122b31a022493a793f2e986bd91e530112
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
Anil Vishnoi [Tue, 23 Jan 2018 06:25:36 +0000 (06:25 +0000)]
Merge "OPNFLWPLUG-969: ONF Extension is not installed due to which bundle based resync is failing:"
D Arunprakash [Tue, 16 Jan 2018 16:41:40 +0000 (22:11 +0530)]
OPNFLWPLUG-972: Point to openflowplugin liblldp
Change-Id: Ic029736e257e09825d35946287433bb41c6d61d3
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
D Arunprakash [Tue, 16 Jan 2018 15:53:54 +0000 (21:23 +0530)]
OPNFLWPLUG-972: Add liblldp module to openflowplugin pom
1. Change package from org.opendaylight.controller
to org.opendaylight.openflowplugin.libraries
2. Enable liblldp module - Add to openfloplugin pom.xml
Change-Id: I0d6fa73a78e4fea587e250aed5577c10375e6b31
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
Anil Vishnoi [Tue, 23 Jan 2018 02:35:28 +0000 (02:35 +0000)]
Merge "OPNFLWPLUG-963 : Updating ports delete reason from OFP:"
SujaT [Thu, 4 Jan 2018 13:07:06 +0000 (18:37 +0530)]
OPNFLWPLUG-969: ONF Extension is not installed due to which bundle based
resync is failing:
Feature ONF Extension is not installed due to dependency missing hence
bundle based resync event is not taking place.It's resolved by adding
corresponding dependency in odl-openflowplugin-southbound pom.xml file.
Change-Id: Iaae13d0a327bcc6c867ca4f7b7945c81fde32118
Signed-off-by: SujaT <suja.t@ericsson.com>
Anil Vishnoi [Tue, 23 Jan 2018 02:33:23 +0000 (02:33 +0000)]
Merge "OPNFLWPLUG-929 : Remove deprecated guava library"
Anil Vishnoi [Tue, 23 Jan 2018 02:32:38 +0000 (02:32 +0000)]
Merge "OPNFLWPLUG-929 : Remove deprecated guava library"
Anil Vishnoi [Tue, 23 Jan 2018 02:30:52 +0000 (02:30 +0000)]
Merge "OFPGC_ADD_OR_MOD support in openflowplugin"
Tom Pantelis [Sat, 20 Jan 2018 18:38:58 +0000 (13:38 -0500)]
Fix checkstyle violations in openflowjava-util
Change-Id: Iac5a02900711a36c79481f0ee19be06c20bbd879
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sat, 20 Jan 2018 18:03:32 +0000 (13:03 -0500)]
Fix checkstyle violations in openflow-protocol-api
Change-Id: Ie6aa924aeb857035e8389a50a70d6c9149d4e4ee
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sat, 20 Jan 2018 16:14:28 +0000 (11:14 -0500)]
Eliminate explicit yangtools dependencies and pom cleanup
Changed the openflowplugin-parent pom to derive from bindng-parent so
yangtools version and dependencies come from mdsal. Also removed
unnecessary, duplicated configurations, eg yang-maven-plugin, in derived
poms thatcare inherited from the parents.
Change-Id: Ie331b93a5f1d6784109ff82afe63ca481c67ceec
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Luis Gomez [Thu, 18 Jan 2018 23:27:27 +0000 (15:27 -0800)]
Bump yangtools to 2.0.1
Change-Id: I10fbb74bc762768e90d1f4b1f3fe0ad2a607af82
Signed-off-by: Luis Gomez <ecelgp@gmail.com>
Thanh Ha [Tue, 16 Jan 2018 15:17:34 +0000 (10:17 -0500)]
Merge remote-tracking branch 'liblldp/master'
Change-Id: I7be037f65e45d138e07e3fd136c82bdd65d23c3d
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Tue, 16 Jan 2018 15:09:37 +0000 (10:09 -0500)]
Move liblldp into libraries/liblldp
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Tom Pantelis [Fri, 15 Dec 2017 02:19:54 +0000 (21:19 -0500)]
Bump to yangtools-2.0.0 and odlparent-3.0.2
Change-Id: I55e46a801fa02d37117caf80f2f9ddcd7941dfb7
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Anil Vishnoi [Fri, 12 Jan 2018 19:31:26 +0000 (19:31 +0000)]
Merge "Fix odlparent 3 Checkstyle issues"
Tom Pantelis [Thu, 14 Dec 2017 23:29:22 +0000 (18:29 -0500)]
Bump to odlparent 3.0.2
Change-Id: Ifb16521edc9fa7209c0af8e13745c6b5611d77b7
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Jozef Bacigal [Fri, 15 Dec 2017 06:19:51 +0000 (07:19 +0100)]
Remove unused interface
- remove unused OpenflowPluginTimer
See bug: OPNFLWPLUG-966
Change-Id: I18f9d5db28cc9f8780db1fe513619a438ca88793
Signed-off-by: Jozef Bacigal <jozef.bacigal@me.com>
Robert Varga [Wed, 11 Oct 2017 18:54:53 +0000 (20:54 +0200)]
Bump yangtools to 2.0.0
This bumps odlparent to 3.0.1 and yangtools to 2.0.0. Also fixes
references to features, so that the build reactor is consistent.
Compilation fixes are addressed in a follow-up patch.
Change-Id: I24f9997c2ec22861e674b74fb01d43f783e3dbc1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
D Arunprakash [Fri, 5 Jan 2018 12:41:37 +0000 (18:11 +0530)]
OPNFLWPLUG-929 : Remove deprecated guava library
use overloaded transformAsync api
Change-Id: I8c087f1b77f7d3f5364a3b545033e16631c48f60
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
D Arunprakash [Fri, 5 Jan 2018 12:38:19 +0000 (18:08 +0530)]
OPNFLWPLUG-929 : Remove deprecated guava library
use overloaded transformAsync api
Change-Id: I9c6cc9b78aeba0afe3b08bedc978a800fc804ab3
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
Gobinath [Thu, 21 Dec 2017 05:41:03 +0000 (11:11 +0530)]
OFPGC_ADD_OR_MOD support in openflowplugin
Addition of new command OFPGC_ADD_OR_MOD for OFPT_GROUP_MOD message
that adds a new group that does not exist (like ADD) or modifies
an existing groups like (MODIFY).
Added a configurable property group_add_mod_enabled which when set to
"true", the addition/updation of a group would send OFPGC_ADD_OR_MOD
message to the switches. When set to false, the addition/updation of the
group has the same existing behavior,ie, OFPGC_ADD for addition and
OFPGC_UPDATE for the updation of the groups.
This patch fixes the following bugs: OPNFLWPLUG-788, OPNFLWPLUG-877, OPNFLWPLUG-667
Gerrit link for the specs: https://git.opendaylight.org/gerrit/#/c/65465/
Change-Id: Ifb2f7ff55d07ca565d87eaa8b253021cad667fd6
Signed-off-by: Gobinath <gobinath@ericsson.com>
Jozef Bacigal [Thu, 3 Aug 2017 12:22:30 +0000 (14:22 +0200)]
Remove deprecated EOS services
See also: OPNFLWPLUG-927
Change-Id: Ie9a4b7904c492f2f3b2a011f358e70bfee6bd510
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Anil Vishnoi [Thu, 4 Jan 2018 17:12:37 +0000 (17:12 +0000)]
Merge "OPNFLWPLUG-929 : Remove deprecated guava library in openflowplugin-impl"
Anil Vishnoi [Thu, 4 Jan 2018 17:10:32 +0000 (17:10 +0000)]
Merge "OPNFLWPLUG-929 : Remove deprecated guava library in applications"
Anil Vishnoi [Thu, 4 Jan 2018 17:08:48 +0000 (17:08 +0000)]
Merge "OPNFLWPLUG-929 : Remove deprecated guava library"
eeiillu [Tue, 19 Sep 2017 06:30:04 +0000 (12:00 +0530)]
OPNFLWPLUG-963 : Updating ports delete reason from OFP:
This patch is required by interface manager (GENIUS) to differentiate
NodeConnector removal due to PORT DEL Openflow Message or due to node
itself gets removed.
Change-Id: I84ab57abda78b5796ef94dc07e83e0f4e30fd2ce
Signed-off-by: eeiillu <suja.t@ericsson.com>
D Arunprakash [Wed, 20 Dec 2017 12:36:39 +0000 (18:06 +0530)]
OPNFLWPLUG-929 : Remove deprecated guava library in openflowplugin-impl
Change-Id: Ie95eb2e4af6917e9594c5774e91147619f88d590
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
D Arunprakash [Wed, 20 Dec 2017 12:30:58 +0000 (18:00 +0530)]
OPNFLWPLUG-929 : Remove deprecated guava library
Change-Id: Ica86ef2e1ad320a1fdedc1b1266cb980acd2464b
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
D Arunprakash [Wed, 20 Dec 2017 09:24:06 +0000 (14:54 +0530)]
OPNFLWPLUG-929 : Remove deprecated guava library in applications
Change-Id: I7c21fc9fdb2529968c68e1a535f400cd5f5a61b2
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
D Arunprakash [Wed, 25 Oct 2017 16:16:27 +0000 (21:46 +0530)]
OPNFLWPLUG-953: Property change listener for lldp discovery config properties
Runtime update for properties in openflowplugin.cfg is failing
as there is no listener added for newly added toplogy lldp
discovery properties
Change-Id: I87bcba910f8d51a5b940b82c588a06d39092404a
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
Tom Pantelis [Fri, 15 Dec 2017 03:22:27 +0000 (22:22 -0500)]
Fix odlparent 3 Checkstyle issues
Change-Id: I9ed666294ecdfa04290dc56dcf3610c85b117e92
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Anil Vishnoi [Fri, 8 Dec 2017 21:57:35 +0000 (21:57 +0000)]
Merge "Rename addDeleteOperationTotTxChain => addDeleteOperationToTxChain"
gobinath [Tue, 28 Nov 2017 08:27:05 +0000 (13:57 +0530)]
Run time check and update of OFP service status
Change-Id: I8b41cd32990e7c4ea14cabbf862008fe77c7cc91
Signed-off-by: gobinath <gobinath@ericsson.com>
(cherry picked from commit
042a4f1a62e14cd78fab243b450f77bc6e0bc86e)
Signed-off-by: gobinath <gobinath@ericsson.com>
Prasanna Huddar [Fri, 8 Dec 2017 09:25:56 +0000 (09:25 +0000)]
Merge "System ready integration for OFP"
Gobinath [Fri, 24 Nov 2017 06:31:22 +0000 (12:01 +0530)]
System ready integration for OFP
The openflowplugin will start switch connections only on the system
ready event triggered by the infrautils.
Change-Id: Ia60b36cb2446ed92d58d3507d2de9524d6efbc00
Signed-off-by: gobinath <gobinath@ericsson.com>
Michael Vorburger [Fri, 1 Dec 2017 00:19:53 +0000 (01:19 +0100)]
Rename addDeleteOperationTotTxChain => addDeleteOperationToTxChain
to drop the 't' which looks like an obvious typo in this method
Change-Id: I0c7648f13bc1ea2312fa8fd31f8e9238260e731e
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Anil Vishnoi [Fri, 1 Dec 2017 05:47:39 +0000 (05:47 +0000)]
Merge "Minor: Remove 3 un-used private methods found by FindBugs"
Anil Vishnoi [Fri, 1 Dec 2017 05:35:21 +0000 (05:35 +0000)]
Merge "Make HandshakeManagerImpl more thread-safe, as recommended by FindBugs"