netconf.git
7 years agoBug 6995 - Change event notification subscription usability PART1 31/47731/9
Jakub Toth [Fri, 28 Oct 2016 10:55:00 +0000 (12:55 +0200)]
Bug 6995 - Change event notification subscription usability PART1

  * added leaf of notification-output-type to grouping for use
    both augmentations of notifications:
      * data-change notifications
      * yang notifications
  * implemented support of output type for data-change
    notifications (in draft02 and in latest draft)
  * fixed tests to support output of notification

Change-Id: I0b8b9803d1bd2daa7f319e9332ecaf1e96da16ab
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoMerge "Address comments from blueprint patches"
Jakub Morvay [Mon, 7 Nov 2016 15:59:05 +0000 (15:59 +0000)]
Merge "Address comments from blueprint patches"

7 years agoMerge "Bug 6903 - Implement Query parameters - fields"
Jakub Morvay [Mon, 7 Nov 2016 14:26:52 +0000 (14:26 +0000)]
Merge "Bug 6903 - Implement Query parameters - fields"

7 years agoMerge "Bug 6895 - Implement Query parameters - depth"
Jakub Morvay [Mon, 7 Nov 2016 14:26:30 +0000 (14:26 +0000)]
Merge "Bug 6895 - Implement Query parameters - depth"

7 years agoMerge "Remove netconf-config-dispatcher as moved to netconf-client"
Jakub Morvay [Mon, 7 Nov 2016 13:45:34 +0000 (13:45 +0000)]
Merge "Remove netconf-config-dispatcher as moved to netconf-client"

7 years agoAddress comments from blueprint patches 54/47854/5
Alexis de Talhouët [Wed, 2 Nov 2016 19:02:35 +0000 (15:02 -0400)]
Address comments from blueprint patches

This is a follow-up patch addressing the following comments:

- add missing destroy-method: https://git.opendaylight.org/gerrit/#/c/45750/
- refactor class name, remove useless param and got back to simple map/set
as there is no obvious need to have them concurrent: https://git.opendaylight.org/gerrit/#/c/45608/
- add TODO back: https://git.opendaylight.org/gerrit/#/c/45631/

Change-Id: Ie4648aa520717effbfe367de62a2fb7d6b1d3505
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoMerge "Specify type to NetconfClientDispatcher reference"
Tomas Cere [Mon, 7 Nov 2016 13:06:52 +0000 (13:06 +0000)]
Merge "Specify type to NetconfClientDispatcher reference"

7 years agoMerge changes from topic 'bug/6023'
Jakub Morvay [Mon, 7 Nov 2016 11:59:29 +0000 (11:59 +0000)]
Merge changes from topic 'bug/6023'

* changes:
  Add netconf-util tests for package org.opendaylight.netconf.util.osgi
  Bug 6023 - Adress for config subsystem netconf endpoint is not configurable

7 years agoMerge "Bug 6637 - Make Netconf test-tool simulate buggy behavior"
Jakub Morvay [Mon, 7 Nov 2016 11:39:18 +0000 (11:39 +0000)]
Merge "Bug 6637 - Make Netconf test-tool simulate buggy behavior"

7 years agoAdd netconf-util tests for package org.opendaylight.netconf.util.osgi 72/47772/5
Andrej Mak [Mon, 31 Oct 2016 09:56:59 +0000 (10:56 +0100)]
Add netconf-util tests for package org.opendaylight.netconf.util.osgi

Change-Id: I3a4d476a98c68c7a9fdf0043b09102c72b9fbb2d
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
7 years agoBug 6023 - Adress for config subsystem netconf endpoint is not configurable 45/47745/9
Alexis de Talhouët [Fri, 28 Oct 2016 19:31:12 +0000 (15:31 -0400)]
Bug 6023 - Adress for config subsystem netconf endpoint is not configurable

Follow-up patch to clean-up

Change-Id: I7bfb7ee0c5e07b00f8f55b37a327f3c4ced6b892
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoBug 6696: Add transaction chain support to netconf connector 75/45575/16
Andrej Mak [Wed, 14 Sep 2016 06:08:31 +0000 (08:08 +0200)]
Bug 6696: Add transaction chain support to netconf connector

Change-Id: I3d680be67589e7f005ef470f0b3896c3256fca4b
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
7 years agoBug 6637 - Make Netconf test-tool simulate buggy behavior 46/46446/10
Andrej Mak [Fri, 30 Sep 2016 10:49:55 +0000 (12:49 +0200)]
Bug 6637 - Make Netconf test-tool simulate buggy behavior

Define new NetconfOperationServiceFactory which is used by testtool.
This implementation intercepts RPCs and checks if their behavior
is overriden by config. If it is, response defined in config file is
returned. If it is not overriden, handling is delegated to the normal
operation implementation.

Change-Id: I215b8bf52f8229ad54064226abdae0b7fea8f2ff
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
7 years agoBug 6903 - Implement Query parameters - fields 69/46669/44
Ivan Hrasko [Fri, 7 Oct 2016 11:55:38 +0000 (13:55 +0200)]
Bug 6903 - Implement Query parameters - fields

- parse and verify fields parameter from URI
- nodes written to output are limited in
ParameterAwareNormalizedNodeWriter according to
parsed fields parameter value
- ParameterAwareNormalizedNodeWriter is used as writer
even if no parameters are used
- fields parameter is used together with depth
parameter, when node is selected by fields parameter
then value of depth parameter has no effect on selected
node and its *ancestors*
- contains unit tests for fields parameter parser and
ParameterAwareNormalizedNodeWriter class
- fixed depth for map nodes in way that when map node is
target and depth is 1 no map entries children are written
to output
- added support to read data (GET) from restconf/data path

Change-Id: I3896dba6faa3fdbcb00e07fdfd7b3fdc02ba57d9
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
7 years agoBug 6895 - Implement Query parameters - depth 01/46601/26
Ivan Hrasko [Thu, 6 Oct 2016 09:19:59 +0000 (11:19 +0200)]
Bug 6895 - Implement Query parameters - depth

- depth URI query parameter for new Restconf
- parse and verify all GET parameters in one method
- added tests for depth parameter writer
- added unit tests for content parameter

Change-Id: If9fece9c995dd52bb8ad00d29b6addb66fa4e32b
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
7 years agoMerge "Bug 6382 - add apidoc for latest restconf draft"
Jakub Morvay [Fri, 4 Nov 2016 08:47:06 +0000 (08:47 +0000)]
Merge "Bug 6382 - add apidoc for latest restconf draft"

7 years agoMerge "Bug 6731 - add valid example values"
Jakub Morvay [Fri, 4 Nov 2016 08:46:10 +0000 (08:46 +0000)]
Merge "Bug 6731 - add valid example values"

7 years agoSpecify type to NetconfClientDispatcher reference 02/47902/1
Jakub Morvay [Thu, 3 Nov 2016 16:07:02 +0000 (17:07 +0100)]
Specify type to NetconfClientDispatcher reference

Specify netconf-client-dispatcher type to NetconfClientDispatcher
reference in netconf-topology-singleton blueprint.

Change-Id: I357a10ae634787f1dcf1537c26cebdb9b14effce
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
7 years agoRemove netconf-config-dispatcher as moved to netconf-client 56/47856/1
Alexis de Talhouët [Wed, 2 Nov 2016 19:18:10 +0000 (15:18 -0400)]
Remove netconf-config-dispatcher as moved to netconf-client

Before merging this, USC project needs to merge
https://git.opendaylight.org/gerrit/#/c/46621/
as it is the only consumer of this artifact, it
has to be migrated to the new one.

See commit message of this patch for context:
https://git.opendaylight.org/gerrit/#/c/45735/

Change-Id: Iea4ea41137047fda11ee1276bb001790b772f114
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoAdd blueprint wiring for messagebus-netconf 45/45645/8
Alexis de Talhouët [Thu, 15 Sep 2016 20:25:42 +0000 (16:25 -0400)]
Add blueprint wiring for messagebus-netconf

Change-Id: I3d6f7845a0ab898e5e4f7d3c45cbc3f6eba746c0
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoMerge "Add netconf-netty-util tests"
Jakub Morvay [Wed, 2 Nov 2016 18:39:21 +0000 (18:39 +0000)]
Merge "Add netconf-netty-util tests"

7 years agoMerge "Add netconf-impl unit tests"
Jakub Morvay [Wed, 2 Nov 2016 18:36:50 +0000 (18:36 +0000)]
Merge "Add netconf-impl unit tests"

7 years agoMerge "Add netconf-util tests and remove unused classes"
Jakub Morvay [Wed, 2 Nov 2016 18:35:29 +0000 (18:35 +0000)]
Merge "Add netconf-util tests and remove unused classes"

7 years agoMerge "Add blueprint wiring for netconf-client"
Jakub Morvay [Wed, 2 Nov 2016 17:35:56 +0000 (17:35 +0000)]
Merge "Add blueprint wiring for netconf-client"

7 years agoMerge changes from topic 'blueprint'
Jakub Morvay [Wed, 2 Nov 2016 17:32:40 +0000 (17:32 +0000)]
Merge changes from topic 'blueprint'

* changes:
  Remove remaining yang and xml config system files
  Add blueprint wiring for mdsal-netconf-yang-library
  Add blueprint wiring for mdsal-netconf-monitoring
  Add blueprint wiring to mdsal-netconf-notification
  Add blueprint wiring to netconf-notification-impl
  Add blueprint wiring for mdsal-netconf-connector
  Add blueprint wiring for netconf-impl
  Add blueprint wiring for netconf-ssh
  Add blueprint wiring for aaa-authn-odl-plugin

7 years agoMerge "Add blueprint wiring for netconf-console"
Jakub Morvay [Wed, 2 Nov 2016 15:06:25 +0000 (15:06 +0000)]
Merge "Add blueprint wiring for netconf-console"

7 years agoBug 6382 - add apidoc for latest restconf draft 48/46948/5
miroslav.kovac [Wed, 12 Oct 2016 14:22:30 +0000 (16:22 +0200)]
Bug 6382 - add apidoc for latest restconf draft

Create a swagger api explorer for latest ietf-netconf-restconf draft

Change-Id: Id397bbfdb435b8d8f0474657e6a7557e9b1eb838
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
7 years agoBug 6731 - add valid example values 72/46772/4
miroslav.kovac [Tue, 11 Oct 2016 14:18:44 +0000 (16:18 +0200)]
Bug 6731 - add valid example values

Add API Explorer Model Schema Data Type 'Click to set as parameter
value' valid example values taking in consideration -> default values,
patterns, data types, min and max value.

Change-Id: I81e566bf81d830ddd8da278323e17a3e0e27ec3e
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
7 years agoRemove remaining yang and xml config system files 00/47700/3
Alexis de Talhouët [Thu, 27 Oct 2016 21:20:54 +0000 (17:20 -0400)]
Remove remaining yang and xml config system files

Change-Id: Id2610630046a22b81b10a4155f08ed149d056b09
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoAdd blueprint wiring for mdsal-netconf-yang-library 31/45631/16
Alexis de Talhouët [Thu, 15 Sep 2016 13:16:30 +0000 (09:16 -0400)]
Add blueprint wiring for mdsal-netconf-yang-library

Change-Id: I36f331c6486130f55411fb794625a78780da6268
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoAdd blueprint wiring for mdsal-netconf-monitoring 08/45608/20
Alexis de Talhouët [Wed, 14 Sep 2016 23:45:04 +0000 (19:45 -0400)]
Add blueprint wiring for mdsal-netconf-monitoring

Define concurrent maps and sets to avoid having to synchronize
functions when operation are occuring on those objects.

Change-Id: Icc3e5e688a9b1c131eb28c995c9689f6425fc7b2
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoAdd blueprint wiring to mdsal-netconf-notification 28/45628/18
Alexis de Talhouët [Wed, 21 Sep 2016 23:23:28 +0000 (19:23 -0400)]
Add blueprint wiring to mdsal-netconf-notification

Change classes' modifiers to public so they can be instantiated
using blueprint.

Change-Id: I7b9ac6eaca8f8d7ff8b058e257b5092160ba09bb
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoAdd blueprint wiring to netconf-notification-impl 52/45752/21
Alexis de Talhouët [Wed, 26 Oct 2016 15:03:20 +0000 (11:03 -0400)]
Add blueprint wiring to netconf-notification-impl

- add the mdsal-notification-mapper blueprint xml file in mdsal-netconf-notification,
as this bundle is pulled in by the odl-netconf-mdsal feature, loading the config system
file responsible to create the modules.

Change-Id: I67fb0be3e9765177bb34f81461978954b4632a53
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoAdd blueprint wiring for mdsal-netconf-connector 07/45607/16
Alexis de Talhouët [Tue, 20 Sep 2016 16:06:41 +0000 (12:06 -0400)]
Add blueprint wiring for mdsal-netconf-connector

Change-Id: Ic25810cd354c2fc37362248d8267f0b4d7e6d412
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoAdd blueprint wiring for netconf-impl 50/45750/21
Alexis de Talhouët [Tue, 20 Sep 2016 19:57:02 +0000 (15:57 -0400)]
Add blueprint wiring for netconf-impl

- create mdsal-netconf-impl bundle containing the blueprint xml
file to start-up the md-sal netconf server implementation.

Change-Id: I43e57671651d4321f7a955376b6f6850cc430f56
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoAdd blueprint wiring for netconf-ssh 74/45774/13
Alexis de Talhouët [Wed, 12 Oct 2016 02:10:27 +0000 (22:10 -0400)]
Add blueprint wiring for netconf-ssh

- create mdsal-netconf-ssh bundle containing the blueprint xml
file to start-up the md-sal netconf server ssh.

Change-Id: I20d3d22f8c58b8b28a113f3969c9da0e7d84b028
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoAdd blueprint wiring for aaa-authn-odl-plugin 99/45599/17
Alexis de Talhouët [Wed, 5 Oct 2016 20:00:11 +0000 (16:00 -0400)]
Add blueprint wiring for aaa-authn-odl-plugin

Change-Id: Ice0fcaf58aae9b9402e9b6e515e57b2157a1be69
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoClear out tx reference immediately after submit. 83/47783/2
Tomas Cere [Mon, 31 Oct 2016 15:23:00 +0000 (16:23 +0100)]
Clear out tx reference immediately after submit.

When sumbmitting multiple transactions after each other
you could get into a state in which a transaction was submitted
and the reference wasn't cleared out in the callback resulting in
attempts to use an already finished transaction.

Change-Id: Iebf6ed10760c106e45c51665c63f45debe7e7063
Signed-off-by: Tomas Cere <tcere@cisco.com>
7 years agoAdd netconf-util tests and remove unused classes 69/47769/1
Andrej Mak [Mon, 31 Oct 2016 06:43:04 +0000 (07:43 +0100)]
Add netconf-util tests and remove unused classes

Change-Id: I37d10d6e7a790d0fe58b64f9a91a4d29bd0eed24
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
7 years agoAdd netconf-impl unit tests 13/47713/1
Andrej Mak [Fri, 28 Oct 2016 06:36:29 +0000 (08:36 +0200)]
Add netconf-impl unit tests

Change-Id: If36e4cee4de8635b6e361e0e6eb9809060f99dbd
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
7 years agoMerge "Bug 6931 - Fix unsupported specific type of leaf"
Tomas Cere [Thu, 27 Oct 2016 15:58:34 +0000 (15:58 +0000)]
Merge "Bug 6931 - Fix unsupported specific type of leaf"

7 years agoMerge "Use UTF-8 as the standard output"
Tomas Cere [Thu, 27 Oct 2016 15:56:00 +0000 (15:56 +0000)]
Merge "Use UTF-8 as the standard output"

7 years agoUse UTF-8 as the standard output 65/47665/2
Robert Varga [Thu, 27 Oct 2016 11:37:17 +0000 (13:37 +0200)]
Use UTF-8 as the standard output

Do not rely on environment-specific encoding, but always
use UTF-8 as the target encoding.

Change-Id: I540fed7611ec66ae2aaeec3b86e21af7376208b9
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "InstanceIdentifierCodecImpl JUnit test"
Tomas Cere [Thu, 27 Oct 2016 11:54:44 +0000 (11:54 +0000)]
Merge "InstanceIdentifierCodecImpl JUnit test"

7 years agoBug 6931 - Fix unsupported specific type of leaf 45/46845/12
Jakub Toth [Wed, 12 Oct 2016 16:59:33 +0000 (18:59 +0200)]
Bug 6931 - Fix unsupported specific type of leaf

  * add value to YangInstanceIdentifier as type of leaf
  * converting of value of leaf to String in
    YangInstanceIdentifierSerializer
  * fix tests according to parsing value of leaf by type

Change-Id: I4796b0b116b46d57b9c302bb828beab692f40ed3
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoMerge "Bug 7032 netconf-console support schemaless mount point"
Tomas Cere [Thu, 27 Oct 2016 10:21:44 +0000 (10:21 +0000)]
Merge "Bug 7032  netconf-console support schemaless mount point"

7 years agoUse SerializationUtils from sal-clustering-commons 48/47648/1
Tom Pantelis [Thu, 27 Oct 2016 01:39:48 +0000 (21:39 -0400)]
Use SerializationUtils from sal-clustering-commons

THe SerializationUtils class has been moved from sal-distributed-datastore to
sal-clustering-commons by https://git.opendaylight.org/gerrit/#/c/47637/ so
change usages.

Change-Id: Id279d5c805a400b650cbe2fc8f714c0d1a0794a6
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
7 years agoInstanceIdentifierCodecImpl JUnit test 27/47027/4
matus.kubica [Mon, 17 Oct 2016 15:10:08 +0000 (17:10 +0200)]
InstanceIdentifierCodecImpl JUnit test

Test serialize and deserialize methods of InstanceIdentifierCodecImpl class

Change-Id: Id40a25e2ed5828cc78368f4baa9dfdd205f078d3
Signed-off-by: matus.kubica <Matus.Kubica@pantheon.tech>
7 years agoBug 7032 netconf-console support schemaless mount point 70/47570/1
Geng Xingyuan [Wed, 26 Oct 2016 02:45:36 +0000 (10:45 +0800)]
Bug 7032  netconf-console support schemaless mount point

Change-Id: Id7ed42f87f72a5162ecb6bfdc798062307a3dad0
Signed-off-by: Geng Xingyuan <geng.xingyuan@zte.com.cn>
7 years agoAdd netconf-netty-util tests 74/47474/1
Andrej Mak [Fri, 21 Oct 2016 12:41:09 +0000 (14:41 +0200)]
Add netconf-netty-util tests

Change-Id: I34adb433d6e078f3c95fd4a1516d44ce8ee0463a
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
7 years agoAdd blueprint wiring for netconf-client 35/45735/16
Alexis de Talhouët [Mon, 24 Oct 2016 15:25:07 +0000 (11:25 -0400)]
Add blueprint wiring for netconf-client

- move netconf-config-dispatcher to netconf-client because the *Module
is creating a proxy that needs to share the same classpath as the netconf-client
as it is the bundle providing its implementation and some of its classes
aren't public, but either package-private or protected.

- remove netconf-config-dispatcher from everywhere, but keep the models
there for now as the USC project is dependent on them. To avoid having a flag
day, we keep the models here until https://git.opendaylight.org/gerrit/#/c/46621/
is merged. That patch will be eligible to be merged only once this current
patch is merged.

Change-Id: I2b7007115bf7228ceac6db5946d4e0b859d8ecc6
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoAdd mdsal-singleton-common-api to singleton pom 31/47431/1
Tomas Cere [Mon, 24 Oct 2016 13:58:20 +0000 (15:58 +0200)]
Add mdsal-singleton-common-api to singleton pom

Change-Id: I4159b4ef312f5d924426af82e1bf02f07ee8a5bc
Signed-off-by: Tomas Cere <tcere@cisco.com>
7 years agoMerge "Clean-up netconf-client"
Tomas Cere [Mon, 24 Oct 2016 13:01:42 +0000 (13:01 +0000)]
Merge "Clean-up netconf-client"

7 years agoMerge "Add unit tests for sal-netconf-connector"
Tomas Cere [Mon, 24 Oct 2016 10:18:14 +0000 (10:18 +0000)]
Merge "Add unit tests for sal-netconf-connector"

7 years agoMerge "Add sal-netconf-connector unit tests"
Tomas Cere [Mon, 24 Oct 2016 10:17:44 +0000 (10:17 +0000)]
Merge "Add sal-netconf-connector unit tests"

7 years agoMerge "Add unit tests for sal-netconf-connector transactions"
Tomas Cere [Mon, 24 Oct 2016 10:02:58 +0000 (10:02 +0000)]
Merge "Add unit tests for sal-netconf-connector transactions"

7 years agoMerge "Remove old clustered netconf topology implementation"
Tomas Cere [Mon, 24 Oct 2016 07:35:34 +0000 (07:35 +0000)]
Merge "Remove old clustered netconf topology implementation"

7 years agoAdd logging in tx facade along with the RemoteDeviceId 68/47368/1
Alexis de Talhouët [Fri, 21 Oct 2016 21:22:53 +0000 (17:22 -0400)]
Add logging in tx facade along with the RemoteDeviceId

Change-Id: I0e30376d65ff734ff3dc34809554b961a013a15b
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoAdd the RemoteDeviceId at the begining of the log 67/47367/1
Alexis de Talhouët [Fri, 21 Oct 2016 20:37:48 +0000 (16:37 -0400)]
Add the RemoteDeviceId at the begining of the log

So it's easier to grep and find things related to one netconf
connector, and also, to keep things consistent with how it's
already done in sal-netconf-connector

Change-Id: I29ee41c699de8287fd6e00f3a04cacb3d17c5fd1
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoMove SubmitFailedReply in the appropriate package 64/47364/1
Alexis de Talhouët [Fri, 21 Oct 2016 20:28:39 +0000 (16:28 -0400)]
Move SubmitFailedReply in the appropriate package

SubmitFailedReply is a transaction related message, hence
should resides under the .transactions package

Change-Id: I7b95f664c88ce2525a742d5543ab562cae709d2b
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoRemove unused imports 63/47363/1
Alexis de Talhouët [Fri, 21 Oct 2016 20:28:11 +0000 (16:28 -0400)]
Remove unused imports

Change-Id: I8079b664133e88a3b35f21a3c41e84e890a8ff46
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoUse SerializationUtils to (de)serialize NormalizedNode and YangInstanceIdentifier 62/47362/1
Alexis de Talhouët [Fri, 21 Oct 2016 20:26:02 +0000 (16:26 -0400)]
Use SerializationUtils to (de)serialize NormalizedNode and YangInstanceIdentifier

Controller CDS implementation provide utility method for this,
we can re-use them, as it appears it's keeping a ThreadLocal
holding NormalizedNodeDataOutput instance

Change-Id: Ia106f33d04f937ac8dacf89cb6837a157eee8ae1
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoAdd serialVersionUID to all java.io.Serializable messages 61/47361/1
Alexis de Talhouët [Fri, 21 Oct 2016 19:46:13 +0000 (15:46 -0400)]
Add serialVersionUID to all java.io.Serializable messages

Change-Id: I4928273c0d65e782162d099ddbae36a0c9fe1c63
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoUpdate netconf-topology-singleton.xml file formatting 60/47360/1
Alexis de Talhouët [Fri, 21 Oct 2016 19:21:54 +0000 (15:21 -0400)]
Update netconf-topology-singleton.xml file formatting

- Inline the closing statement
- Rename to bean to be more accurate

Change-Id: I2e2052b7b86b12139b2573c0e3828730cc8d606d
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoRemove old clustered netconf topology implementation 29/47329/5
Jakub Morvay [Fri, 21 Oct 2016 11:22:39 +0000 (13:22 +0200)]
Remove old clustered netconf topology implementation

Since new netconf clustering implementation resides in
netconf-topology-singleton module, old implementation is not needed
anymore. This patch gets rid of it.

Change-Id: I99ba7baced099bd5431a4014378d4ab3b22d93ba
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
7 years agoBug 6714 - Use singleton service in clustered netconf topology 60/46660/18
Rudolf Brisuda [Fri, 7 Oct 2016 09:44:23 +0000 (11:44 +0200)]
Bug 6714 - Use singleton service in clustered netconf topology

Implemented clustered netconf topology with using clustered
singleton service.

Change-Id: I0e71a9934a70c6bce8eeab0644a5bd05c5548a8c
Signed-off-by: Rudolf Brisuda <rbrisuda@cisco.com>
7 years agoFix tests after merging Change 47121 to Yangtools 46/47346/1
Ivan Hrasko [Fri, 21 Oct 2016 13:38:38 +0000 (15:38 +0200)]
Fix tests after merging Change 47121 to Yangtools

Change-Id: I4bafce0972da4e83fe4575517b5e95808bb21caf
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
7 years agoAdd xml config dependency to features pom 10/47210/3
Vratko Polak [Thu, 20 Oct 2016 15:25:00 +0000 (17:25 +0200)]
Add xml config dependency to features pom

Configfile added here [0] also needs to be listed as pom dependency,
otherwise distribution-check would fail.
Also added to netconf-artifacts.

[0] https://git.opendaylight.org/gerrit/#/c/44243/10/features/netconf/src/main/features/features.xml

Change-Id: If016aadb03154d83ddd0afa680e8d1d8acd88217
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
7 years agoMerge "Add more unit tests for sal-netconf-connector"
Tomas Cere [Thu, 20 Oct 2016 13:02:06 +0000 (13:02 +0000)]
Merge "Add more unit tests for sal-netconf-connector"

7 years agoMerge "Bug 6023 - Adress for config subsystem netconf endpoint is not configurable"
Tomas Cere [Thu, 20 Oct 2016 13:01:27 +0000 (13:01 +0000)]
Merge "Bug 6023 - Adress for config subsystem netconf endpoint is not configurable"

7 years agoAdd more unit tests for sal-netconf-connector 90/47190/1
Andrej Mak [Thu, 20 Oct 2016 07:19:39 +0000 (09:19 +0200)]
Add more unit tests for sal-netconf-connector

Change-Id: I76df3726b4c99c93c3ab98edcf0e7aca94d99b79
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
7 years agoBug 6023 - Adress for config subsystem netconf endpoint is not configurable 43/44243/10
Rudolf Brisuda [Wed, 17 Aug 2016 12:03:04 +0000 (14:03 +0200)]
Bug 6023 - Adress for config subsystem netconf endpoint is not configurable

- added NetconfConfigurationActivator for loading ManagedService
- updating configuration from karaf netconf.cfg file
- edited NetconfTCPActivator, NetconfSSHActivator for run with
  cfg values

Change-Id: I5069a9f307a9a9b7c2d79723dc6c1cca0b2cc201
Signed-off-by: Rudolf Brisuda <rudolf.brisuda@pantheon.tech>
7 years agoAdd unit tests for sal-netconf-connector transactions 15/47115/1
Andrej Mak [Wed, 19 Oct 2016 08:24:36 +0000 (10:24 +0200)]
Add unit tests for sal-netconf-connector transactions

Change-Id: I49cbfacd1c41cb531f6fb003110721ae9cbccf0f
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
7 years agoAdd blueprint wiring for netconf-console 38/45738/7
Alexis de Talhouët [Fri, 16 Sep 2016 13:50:38 +0000 (09:50 -0400)]
Add blueprint wiring for netconf-console

Also fix potential NPE when netconf:list-device is called
before the topology-netconf is initialized

Change-Id: Ic4e33ea7717511c26aa9cc9cbde4148f3e5549ac
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoClean-up netconf-client 62/45862/6
Alexis de Talhouët [Tue, 20 Sep 2016 02:53:34 +0000 (22:53 -0400)]
Clean-up netconf-client

- Use lambda or method ref

Change-Id: I02c6b7a13d90119de061cca0f552c565f18e4862
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoAdd sal-netconf-connector unit tests 80/46880/2
Andrej Mak [Thu, 13 Oct 2016 11:18:58 +0000 (13:18 +0200)]
Add sal-netconf-connector unit tests

Change-Id: I6fa10f4a84da2d61cdea57d700195c0eca017f3c
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
7 years agoAdd unit tests for sal-netconf-connector 48/47048/2
Andrej Mak [Mon, 17 Oct 2016 06:58:50 +0000 (08:58 +0200)]
Add unit tests for sal-netconf-connector

Change-Id: I1a6131a38048ef8bd426a8e756ba5ec89e8026cb
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
7 years agoMerge "Bug 4868 - Extend netconf-node-topology model to distinguish user overriden...
Tomas Cere [Tue, 18 Oct 2016 10:53:24 +0000 (10:53 +0000)]
Merge "Bug 4868 - Extend netconf-node-topology model to distinguish user overriden capabilities from device reported capabilities"

7 years agoMerge "Bug 6936 - Fix post request"
Tomas Cere [Tue, 18 Oct 2016 08:53:43 +0000 (08:53 +0000)]
Merge "Bug 6936 - Fix post request"

7 years agoBug 4868 - Extend netconf-node-topology model to distinguish user overriden capabilit... 72/43972/8
Rudolf Brisuda [Mon, 15 Aug 2016 12:46:14 +0000 (14:46 +0200)]
Bug 4868 - Extend netconf-node-topology model to distinguish user overriden capabilities from device reported capabilities

 - changed model and corresponding data bindings and imports, updated tests

Change-Id: I0c9dd78c0bf2c4485f27c0049909a04c6155e718
Signed-off-by: Rudolf Brisuda <rudolf.brisuda@pantheon.tech>
7 years agonetconf-notifications-api unit tests added 25/45725/6
Rudolf Brisuda [Fri, 16 Sep 2016 11:05:24 +0000 (13:05 +0200)]
netconf-notifications-api unit tests added

Change-Id: I02d2bbabb6e5fabb8f45a89c9233a0e763636596
Signed-off-by: Rudolf Brisuda <rudolf.brisuda@pantheon.tech>
7 years agoBug 6936 - Fix post request 64/46864/7
miroslav.kovac [Thu, 13 Oct 2016 06:26:51 +0000 (08:26 +0200)]
Bug 6936 - Fix post request

When post request sends data which already exist, it response with
data already exist.

Change-Id: I2ea60dfe4b8aa4236fbec0fd73b64a6f146146ee
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
7 years agonetconf-console unit tests added 36/45836/7
Rudolf Brisuda [Mon, 19 Sep 2016 15:51:23 +0000 (17:51 +0200)]
netconf-console unit tests added

Change-Id: I3975e0740935dbbe6bc65f6e3ea3febf56507f39
Signed-off-by: Rudolf Brisuda <rudolf.brisuda@pantheon.tech>
7 years agoMerge "Bug 6679 - api explorer creates false examples"
Tomas Cere [Thu, 13 Oct 2016 08:38:28 +0000 (08:38 +0000)]
Merge "Bug 6679 - api explorer creates false examples"

7 years agoMerge "Bug 6272 - support RESTCONF PATCH for mounted NETCONF nodes"
Tomas Cere [Thu, 13 Oct 2016 08:36:31 +0000 (08:36 +0000)]
Merge "Bug 6272 - support RESTCONF PATCH for mounted NETCONF nodes"

7 years agoMerge "Bug 6746 - Restconf: Not working GET operation on mount points"
Tomas Cere [Thu, 13 Oct 2016 08:35:55 +0000 (08:35 +0000)]
Merge "Bug 6746 - Restconf: Not working GET operation on mount points"

7 years agoMerge "Implement TesttoolParams.toString() via reflection"
Tomas Cere [Thu, 13 Oct 2016 08:34:24 +0000 (08:34 +0000)]
Merge "Implement TesttoolParams.toString() via reflection"

7 years agoBug 6272 - support RESTCONF PATCH for mounted NETCONF nodes 23/46123/23
Ivan Hrasko [Fri, 23 Sep 2016 11:33:13 +0000 (13:33 +0200)]
Bug 6272 - support RESTCONF PATCH for mounted NETCONF nodes

- solution for Restconf draft17
- make mount point service available when identifier is parsed
- added unit tests

Change-Id: Ie3c5cdc9cbcb10360ac9d0a082eab52efba75674
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
7 years agoBug 6679 - api explorer creates false examples 51/46751/3
miroslav.kovac [Mon, 10 Oct 2016 16:53:01 +0000 (18:53 +0200)]
Bug 6679 - api explorer creates false examples

Api explorer created false examples when yang has two data nodes with
same name in different containers or lists. It compared name of data
nodes rather than whole path to the data node which result to creting
examples of same types even if they should be different.

Fix examples by comparing the path to data node rather than just name
of the node.

Change-Id: I6f73fb37985fc78ad67ecc466ebfdfe569d7cd8d
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
7 years agoBug 6746 - Restconf: Not working GET operation on mount points 17/45817/30
Ivan Hrasko [Mon, 19 Sep 2016 14:22:53 +0000 (16:22 +0200)]
Bug 6746 - Restconf: Not working GET operation on mount points

- support for reading data on mount points
- improved merge for config and state data:
when identifiers for data in config and state are the same
then merge must by done at one level down, otherwise state
overrides config or vice versa
- identiers are parsed to identifiers context with reference
to mount points when data are behind mount point
- adapted and added unit tests

Change-Id: Iacc45946cc284ae8936f600f5af522926d39c216
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
7 years agoBug 6848 - update url pattern of restconf from 16 to 17 50/46550/8
Jakub Toth [Wed, 5 Oct 2016 13:33:07 +0000 (15:33 +0200)]
Bug 6848 - update url pattern of restconf from 16 to 17

Change-Id: I41882d048a3aede5f4c47c3e160537f7a31a1fab
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 6848 - repackage providers for jersey+create xml 49/46549/12
Jakub Toth [Wed, 5 Oct 2016 12:56:08 +0000 (14:56 +0200)]
Bug 6848 - repackage providers for jersey+create xml
and json reader for restconf draft17

  *fix tests
  *rename tests part from draft11 to draft17

Change-Id: I1315bb693eccc34c78f07ea0acbf45f6ff972455
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoImplement TesttoolParams.toString() via reflection 52/46452/5
Andrej Mak [Tue, 4 Oct 2016 09:08:58 +0000 (11:08 +0200)]
Implement TesttoolParams.toString() via reflection

Change-Id: I2222fcf8b5d95a343f107ed3acd557fbfdf40f42
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
7 years agoFix compilation failure caused by DocumentedException refactoring 48/46748/1
Andrej Mak [Tue, 11 Oct 2016 06:20:17 +0000 (08:20 +0200)]
Fix compilation failure caused by DocumentedException refactoring

Change-Id: I4742760b4afba103af577efc5ffe5905a8255127
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
7 years agoAdd unit test for NetconfConnectorModule 78/46478/3
Andrej Mak [Tue, 4 Oct 2016 13:54:18 +0000 (15:54 +0200)]
Add unit test for NetconfConnectorModule

Change-Id: I865ab9edd5e056579c92aa1436cda8da032dc1e7
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
7 years agoMerge "Add missing Netconf node fields"
Tomas Cere [Fri, 7 Oct 2016 13:46:32 +0000 (13:46 +0000)]
Merge "Add missing Netconf node fields"

7 years agoMerge changes from topic 'Upgrade ietf-restconf draft16 to draft17'
Tomas Cere [Fri, 7 Oct 2016 13:39:34 +0000 (13:39 +0000)]
Merge changes from topic 'Upgrade ietf-restconf draft16 to draft17'

* changes:
  Bug 6848 - upgrade XML media type
  Bug 6848 - upgrade namespace of notification container
  Bug 6848 - Renaming to draft17

7 years agoMerge "Use BDD style mocking everywhere if used once."
Tomas Cere [Fri, 7 Oct 2016 11:50:31 +0000 (11:50 +0000)]
Merge "Use BDD style mocking everywhere if used once."

7 years agoDo a proper disconnect when deleting a connector. 64/46664/1
Tomas Cere [Fri, 7 Oct 2016 10:21:43 +0000 (12:21 +0200)]
Do a proper disconnect when deleting a connector.

Change-Id: I1abba51e331eb1f019e5f2fe741f3836f840aae1
Signed-off-by: Tomas Cere <tcere@cisco.com>
7 years agoBug 6848 - upgrade XML media type 45/46445/6
Jakub Toth [Tue, 4 Oct 2016 06:54:46 +0000 (08:54 +0200)]
Bug 6848 - upgrade XML media type

Change-Id: I16b959a4f325468836477c60d094a1e7473de9e1
Signed-off-by: Jakub Toth <jatoth@cisco.com>