Bug 6278: Switch to use odlparent's karaf-parent.

Change-Id: I64b91792cae98a9829cf92287ea579ed5d8ae0c0
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

BUG 6715:Fixed issue in maven-site generation.

* Fixed the broken links for the manager module.

Change-Id: Ic306d6446210808e8f91b166d065e7c805967ea7
Signed-off-by: yogalakshmi.pa <yogalakshmi.pa@hcl.com>

Bug 6632: Fixed VTN coordinator build error on Fedora 24.

Change-Id: Ic8a30151d9ddf7b42d5c24a00f4aafb24fd1cb8b
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Bug 6543: Changed the default value of port-name

This patch changed the default value of the parameter "port-name" for
the odl-vtn-manager-neutron feature to "eth1" in order to make the CSIT
for the feature work well. As of now, the parameter is not configurable,
and the default value is always used. However, in the ODL CSIT
environment, this parameter needs to be "eth1".

This change is a tentative fix. Ideally, the parameter "port-name"
should be configurable. That improvemnt is tracked as Bug 6599.

Change-Id: Id059618d975dc4982d498c7ab931c55026ba61bb
Signed-off-by: gvrangan <venkatrangang@hcl.com>
(cherry picked from commit 5696f6141b679e1606167f7a5ff705df89ebfae0)

Bump versions by 0.1.0 for next dev cycle

Change-Id: Ie7d02b7293f209c6b135d2db831cd27bbe43bcb6
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge "Improving README for VTN"

Merge "Enable Maven Site for VTN"

Updated description of POM files.

This change makes description of POM files more accurate and simple.

Change-Id: Id7e8323cff50fc7cbd0ae60db9c2e5bdf7142794
Signed-off-by: Hideyuki Tai <Hideyuki.Tai@necam.com>

Merge "Adding description for the pom files in VTN"

Fixed UT/IT build failure due to openflowplugin YANG model change.

Change-Id: I65a38b493b2b3e0341b6a16fc1c0d1ffe939669c
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Adding description for the pom files in VTN

Change-Id: If530e8b2c402056e5de5b2033f4fa44449955f97
Signed-off-by: yogalakshmi.pa <yogalakshmi.pa@hcl.com>

Improving README for VTN

Change-Id: I2cdc798ac14f700024243844ec00981ac96b5ded
Signed-off-by: yogalakshmi.pa <yogalakshmi.pa@hcl.com>

Enable Maven Site for VTN

- Added the maven-site profile to root pom file
- Created the deploy-site.xml  and src/site.xml
- Added the workaround for the url in all the pom files
- Added properties to skip site and deploy in vtn/common/pom
- Override the skip site and edploy in vtn/manager/common/pom

Change-Id: I95204ec635714f681c2989496a40ce472b442df9
Signed-off-by: gvrangan <venkatrangang@hcl.com>

Fixed UT failure due to incorrect test data.

"123.456.789.abc" cannot be used as test data for invalid IP address
because "abc" is valid TLD. So "123.456.789.abc" will be treated as FQDN.

Change-Id: I9c87c45c2f07fdc04250769e967fcaf0855e0ea1
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Bug 6278: Depend on odlparent's version of karaf.branding & opendaylight-karaf-resources

Change-Id: I9f5f5741395880083204f2c4b4d8af45c5120773
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

Revert "Bug 6258: Disabled VSEM Provider build."

This reverts commit 80e359643040ff5550e0d16e82b7fe51a33ddc5c.

Change-Id: Ia95f6727b5cd330e49f9cf162cae6c6253c8809e
Signed-off-by: gvrangan <venkatrangang@hcl.com>

Bug 6258: Disabled VSEM Provider build.

We are facing a problem on building VSEM provider now. This patch has
disabled the build. This change needs to be reverted once the problem is
fixed.

Change-Id: Ie85913854ce0592debf63056bee05e05e70359f7
Signed-off-by: Hideyuki Tai <Hideyuki.Tai@necam.com>
(cherry picked from commit 13b10561b838b931ab627afe08a92ed6e59fff66)

Added blueprint wiring for VTN Manager.

vtn-provider YANG module is still provided only for compatibility.

Change-Id: I98635832d37752de608c6b6516853c0753a8deb4
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Use Java 8 features.

Change-Id: I927189f14148a764ef213421519fee45d6100389
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Removed duplicate ietf-yang-types-20130715 dependency.

Change-Id: I95b1b23fa1a67f7d4ac3cdf03e47ff8e5f827f18
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Eliminate code duplications detected by Sonar.

Change-Id: I56b0db7864448a93c3fcf5e7e4665928f7e2dfb5
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Upgrade ietf-{inet,yang}-types to 2013-07-15

Change-Id: If97dd9c600ff2ea8cdad395eec49d21539b5bc00
Signed-off-by: Hideyuki Tai <Hideyuki.Tai@necam.com>

Bug 6166: Handle jeopardy state of clustered DS.

If DS is in jeopardy state, then:

  * stop aging MAC addresses in MAC address table.
  * stop updating flow statistics.
  * ignore entity ownership change during vtn-config initialization.

Change-Id: I601850fc4d331622f3e4d35368b9f5f313601b94
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Merge "Revert "Disable VSEM Provider Build""

Revert "Disable VSEM Provider Build"

This reverts commit 00b67138abc3bd90e6be598345929c69049ccf44.

Change-Id: Ia39d1b1e2a36f9240985d08a656d8f0367519b48
Signed-off-by: gvrangan <venkatrangang@hcl.com>

Upgrade Apache Tomcat for VTN coordinator to 7.0.70.

Change-Id: I336760686689f66a5afa69ecfd1c00bb308e7116
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Enable to specify Apache Ant home directory for VTN Coordinator build.

  1. If "vtn.build.ant.home" property is defined, its value is used as
     Ant home directory.
  2. If ANT_HOME environment variable is defined, its value is used as
     Ant home directory.
  3. Otherwise Ant home directory is auto-detected.

Change-Id: Ia2f7e6df0e4fe6d1b000de7408422f411ab90f5a
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Suppress unwanted error logs caused by removed node.

This patch suppresses error logs for the following operations if the
target node is disconnected.

  * send-barrier
  * Installation of table miss flow

Change-Id: Icc767479bdec305ba5b2896a04288f3401854d0c
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Bug 6143: Fixed bug that failed to put vtn-data-flow into clustered DS.

This patch fixes a bug that sets an invalid vtn-flow-id into vtn-data-flow
if DS transaction for adding data flow is re-executed due to data
confliction.

Change-Id: I6ef168e396c148daab8cf95b4cf2506b71108401
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Remove obsolete dependency from it/common/pom.xml.

Change-Id: Id320c09b1fe7a0a0269bfc4552fd4afb80553eeb
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Removed distributionManagement section from common

The common/pom.xml does not need to have the information in the
distributionManagement section, since it inherits the necessary
information from its parent. Its parent's parent pom.xml,
odlparent-lite, defines the repository and snapshotRepository
information in its distributionManagement section.

Change-Id: I135e9a9ef3ff938916b09b0e39601fc15c459a26
Signed-off-by: Hideyuki Tai <Hideyuki.Tai@necam.com>

Use flow-removed notification for detecting removed flows.

Flow tables in operational DS are maintained by statistics manager,
which updates flow statistics by periodic polling. In other words,
removed flows are never notified to DataTreeChangeListener unless
statistics manager updates flow statistics.

On the other hand, flow-removed MD-SAL notification will be published
immediately when FLOW_REMOVED message is detected. So we determined to use
flow-removed notification in order to detect expired flows ASAP.

Change-Id: I52ccbe5be84f3ed1f809dbb847f81c6dbf979e9e
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Migrated to openflowplugin-li.

  * Send barrier after modifying flows explicitly.
  * Use opendaylight-direct-statistics to get flow statistics.

Change-Id: Ib84972fab26d653914276f027867293ffce8ff05
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Remove openflowplugin NSF apps from required-capabilities.

openflowplugin has migrated to blueprint and no longer provides
config YANG files for NSF apps.

Change-Id: I344a8d6bde715658fc8d533594ba3ca98f22cdd3
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Disable VSEM Provider Build

This fixes the current problem in VTN verify and Merge jobs.
It needs to be revoked once the versions of nuget gets upgraded.

Change-Id: Ie89f91946ccdd7c93cab66791caac096295db5ff
Signed-off-by: gvrangan <venkatrangang@hcl.com>

Use DataTreeChangeListener in manager.neutron bundle.

Other changes:

  * Refined OVSDB topology listener.
  * Fixed javadoc warnings.

Change-Id: Idd8b8663d075bb32d8756cd671c9ec381196a3ed
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Use Objects.equals() to compare path-faults in bridge-status.

Change-Id: Ie44fd410aa7dec9665668ad4c0ae7e2c28a1463a
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Merge "Use DataTreeChangeListener instead of DataChangeListener."

Bug 5993: Ignore flow-removed that contains non-zero table ID.

VTN Manager uses only flow table 0. So VTN Manager should not handle
flow entries removed from non-zero flow table.

Change-Id: I32e078b9c27d2f2b7dc0328d019a79b5c459472d
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Use DataTreeChangeListener instead of DataChangeListener.

Change-Id: I4ff29b09a03fe7d547f8b7a0ed3144241ad61f16
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Fixed sonar warnings in manager.neutron bundle.

  * Remove this unused "VTN_IDENTIFIERS_IN_PORT" private field.
  * Make XXX a static final constant or non-public and provide accessors
    if needed.

Change-Id: Ie483788823d880e1b9e64dcccc72562e536d5b80
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Use Checkstyle 6.16 as defined in odlparent.

Change-Id: I91fdfdc0960c62739b1204e09b79b946d54a1c4b
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Removed unused methods in VTNNeutronUtils.

For the present there is no need to convert VTN ID into UUID.
So we can remove VTNNeutronUtils.convertNeutronIDToVTNKey() and
all the related methods.

Other changes:

  * Refactored.
    * VTNNeutronUtils.convertUUIDToKey()
    * PortDataChangeListener
    * OVSDBEventHandler
  * Added some static methods to generate tenant/bridge/interface name from
    neutron object.
    * VTNNeutronUtils.getTenantId(BaseAttributes)
    * VTNNeutronUtils.getBridgeId(Network)
    * VTNNeutronUtils.getBridgeId(Port)
    * VTNNeutronUtils.getInterfaceId(Port)

Change-Id: Ied35c2b2c2e00d08727ce55f399133d2f660970d
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Fixed bug in mock-up for integration test.

  * Don't wait for table miss flow entry to be installed into
    unsupported switch.

Change-Id: I9bf5600bc65c3888630e305364227f2b7a675c2e
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Merge "Bug 5557: Fixed issue in delete operation for vbrif out flowfilter"

Bug 5557: Fixed issue in delete operation for vbrif out flowfilter

* Issue in audit scenario for delete operation of vbrif OUT
  flowfilter
* Addressed the same for vtermif flowfilter keytype

Change-Id: I471d3dd1de2727ee2a007a62f0535a593c61aea5
Signed-off-by: yogalakshmi.pa <yogalakshmi.pa@hcl.com>

IT: Make logging levels configurable.

Change-Id: Id21d46d76c65f6a345937d146a95fd3c38980f62
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Fixed bug in mock-up for integration test.

  * IT may be blocked unexpectedly when it fails to clear flow table.

Change-Id: Iaf355d37072c56251d998b760c8b4ee8d0d99248
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Fixed sonar warnings in manager.neutron bundle.

  * Remove this unused "tenantCreated" local variable.
  * Define a constant instead of duplicating this literal "XXX" N times.
  * Either log or rethrow this exception.

Change-Id: I68805daac87999dabf8b59e58f00f09fb53052e3
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Migrated integration test to mdsal-it-base.

This patch enables integration test again.

Change-Id: I8a65316c6dc5b42f697acd6de259eed4b7d3337c
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Use https to connect ODL Nexus

Change-Id: I8f677d45c75a7c2208547cf0dd765db98cb75dc9
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Disable integration tests temporarily.

Change-Id: Idb546921f56e4e43102050045cd1e4b570c78d35
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Fixed sonar warnings.

  * Methods should not be too complex
  * Collapsible "if" statements should be merged

Change-Id: Icab39065c1079d3e46e31bb7083e537c7eee3d89
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Merge "Fixed dependencies in features-vtn-manager POM."

Fixed dependencies in features-vtn-manager POM.

  * Removed unnecessary dependencies.
  * Don't define version of required modules in features-vtn-manager
    POM. It should be centralized in manager.common POM.

Change-Id: Ib616ccf0fd5ece9cd4368ac81c3210bdcc4bf4e6
Signed-off-by: Hideyuki Tai <Hideyuki.Tai@necam.com>

Merge "Bug 5724: Improve log messages that indicate configuration changes."

Merge "Add dependency on javax.validation validation-api"

Bug 5724: Improve log messages that indicate configuration changes.

  * Global path map
  * Path policy
  * Flow condition
  * Flow filter

Change-Id: Ib693cfabd901139c42df5792e4219ea2f03758fc
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Add dependency on javax.validation validation-api

In order to upgrade to org.eclipse.persistence to 2.6.0+ in odlparent,
downstream consumers must include the dependency on javax.validation
validation-api version 1.1.0.Final as described here:

http://stackoverflow.com/questions/28568154/
how-to-get-eclipselink-2-6-0-m3-working-with-jersey-1-18-3

The work to upgrade odlparent's moxy version is included in this patch:
https://git.opendaylight.org/gerrit/#/c/37541/

Change-Id: Id99ea8f255e78b119c6b84669fce573adb8d7eb9
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

Bug 5715: Fixed incorrect log record for modified vBridge configuration.

Change-Id: I9eeeaacef555f7a33e525f03ebd16ea4f0f15f6d
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Remove features-ovsdb

VTN does not need the NetVirt features and NetVirt was moved to a new
project and features-ovsdb disabled from the ovsdb project.

Change-Id: Ibee3b5c1c14026e2240fc5b83492fe2e5e6cb33b
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge "Bug 5609: Fixed issue with fetching vtn dataflows."

Merge "Bug 5530: Fixed flowfilter Import/Audit issue in delete operation"

Inherit nexusproxy property from odlparent

Fix upload issue due to http -> https redirect.

Change-Id: I093dbed150bd649bc470958fda667ded57c98208
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Bug 5609: Fixed issue with fetching vtn dataflows.

* Fixed the issue with fetching vtn dataflows for
  vlanmapping

Change-Id: Ie4ac45ace039440d79bf15c850726fb8cd60d58a
Signed-off-by: yogalakshmi.pa <yogalakshmi.pa@hcl.com>

Bug 5530: Fixed flowfilter Import/Audit issue in delete operation

* Issue with delete opeartion in flowfilter that is created with
  multiple sequence number during the Import/Audit Scenarios.
* Addressed this for all the flowfilter keytypes.

Change-Id: Ie59f1a88250b50982d530a3af9fd7db373af7d3a
Signed-off-by: yogalakshmi.pa <yogalakshmi.pa@hcl.com>

(DataObjectIdentity): Handle unkeyed lists in DataObject.

Change-Id: If8e0c45c9a8a61fec6fff450bae7d7002e0706b8
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Use mockito-core instead of mockito-all.

mockito-all seems to contain old version of hamcrest-core.

Change-Id: I433d2baaa4c2e14ef5315afd0ee6616d763becda
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Fixed incorrect javadoc comments.

Change-Id: I616631823c510ef24fa671b48a7b937fba3b58ae
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Bug 5616: Fixed bug in next-flow-id initialization.

This patch fixed a bug that corrupted next-flow-id container when a new
controller joins with the cluster.

Change-Id: I20ca0f72425ee07ec62238d77c94c99aeef3e0c3
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Modify VTN WebAPI to build using JDK 1.8

Change-Id: Id701962eea756e2a8e11bebf7d91361d63286c8d
Signed-off-by: gvrangan <venkatrangang@hcl.com>

Merge "Fix Bug 5330 to handle OVSDB disconnect from VTN Manager"

Fix Bug 5330 to handle OVSDB disconnect from VTN Manager

Whenever a new OVSDB node gets connected, odl-vtn-manager-neutron
feature will create a OVS bridge which can be controlled using Openflow
to provide networking to Openstack instances.
This patch deletes the bridge node entry from config DS when the OVS
disconnects.The patch also removes some data change handling
code that were not required by VTN and modifies access levels on
some existing methods.

Change-Id: Id0e7dfc055eab71f58a8cd3645c392084698913a
Signed-off-by: gvrangan <venkatrangang@hcl.com>

Bug 5372: Don't remove flows when PACKET_IN is notified on internal port.

If OF swtich has IPv6 support, it may transmit IPv6 neighbor advertisement
packet to every port. VTN Manager may remove unexpected flow entries if
that IPv6 packet transmitted to internal port is notified.

This removal was intended for removing obsolete flow entries once
installed by VTN Manager. But it is no longer needed because VTN Manager
removes all the obsolete flow entries when a new OF switch is detected.

Change-Id: I1cd9713c7f53c67e6eff71494013a7d464d04ed2
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
(cherry picked from commit 946cb11956057918045566581e034a6556286fca)

Bug 5469: Install the table-miss flow entry into every OF1.3+ switch.

According to the OpenFlow 1.3 specification, OF1.3+ switch drops packets
unmatched by flow entries by default. So the VTN Manager needs to install
the table-miss flow entry into OF1.3+ switches so that unmatched packets
are punted to the controller.

Change-Id: I17d7786fd0942c67989bf93470dae17ce94394b2
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
(cherry picked from commit fc3f00718074e112d1bad5bb8764232ef5ad24db)

Bug 5459: Cancel ongoing RPCs routed to the removed node.

Ongoing add-flow/remove-flow RPCs may not return result until timeout
if the target node is removed. This may block VTN internal threads.
This patch keeps track of node-routed RPCs, and cancels all the ongoing
RPCs routed to removed nodes.

Change-Id: I0f2485512ccadd88350f33a6887869c16f7222a5
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
(cherry picked from commit bea45d2424bed23f511097fc6229ee7dc2dff63b)

Remove the dummyprovider from features

* This is no longer needed as it is solved in neutron

Change-Id: I90ca639007cf94bd60031809045b2ddc94bea27d
Signed-off-by: gvrangan <venkatrangang@hcl.com>

Use CharMatcher to remove ':' characters

String.replace() incurs pattern compilation cost, CharMatcher does not
have it and has a specialized method to remove all matching characters
from a string.

Change-Id: If385bd5059ea446969eab5783da91984075cef42
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 5436: Suppress unnecessary remove-flow RPC error logs.

Don't record an error message if an remove-flow RPC error seems to be
caused by disconnection of OpenFlow secure channel.

Addional changes:

  * ReadFlowFuture: Fixed invalid error message.

Change-Id: I835af87c9454d04adddb81e141a27a9a67041f3f
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
(cherry picked from commit fcc8aca34be6bba40cf97d19ccdf9dd8ff539088)

Fixed sonar warning in manager.neutron.

  * Removed an unused private field.
  * Removed an unnecessary throws clause.

Change-Id: I47d4e7ddf3a63a1bd0164b969ad87e0e68006e81
Signed-off-by: Hideyuki Tai <Hideyuki.Tai@necam.com>
(cherry picked from commit cb3ba6497d827da3a2cc8fb9a345c66e3def374b)

Bug 5412: Remove unnecessary import statement.

manager.neutron never uses DOM API.

Change-Id: I9feeb9582d2d7b560b80bb5d25ec3eb1c4c8004d
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
(cherry picked from commit 48dfb61955d990bd6901a1b5f934c341eb1e5cd0)

Pull in PowerMock from odlparent.

Odlparent now manages dependencies for PowerMock, in sync with Mockito.
Rely on that instead of defining our own versions.

Change-Id: Ia07d06d7bf72c6ea1cfa2be1f9eb5acb5d537da5
Signed-off-by: Hideyuki Tai <Hideyuki.Tai@necam.com>

Fixed UT/IT breakage.

  * Use powermock 1.6.4.
  * Don't load mockito into IT container.

Change-Id: Ib15d9025ed76699b5ad7cf2497b345f48621a4d4
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Merge "Removed unused code in manager/neutron/src."

Removed unused code in manager/neutron/src.

  * Removed unused variables.
  * Removed unnecessary comments.

Change-Id: I87029846018f41a22f88515aac2020ddde30ef14
Signed-off-by: Hideyuki Tai <Hideyuki.Tai@necam.com>
(cherry picked from commit e40e830aaa8bd9954ab1d36aa5cd661f291578a5)

Removed unnecessary mocking in manager.neutron UT.

Other change:

  * Removed unused variables.

Change-Id: I3865cc4dc9b62bdf3160930f2512b2f8757c132e
Signed-off-by: Hideyuki Tai <Hideyuki.Tai@necam.com>
(cherry picked from commit ea24e0733844ce988dca607f8d81ab4ebd6f9add)

Removed unused code.

Other changes:

  * VNodeIdentifier.java: No need to check VNodeType in equals() and
    hashCode() because VNodeType is value is tied to VNodeIdentifier
    subclass and never shared with other class.

Change-Id: I213cd7375265413f0ee0a0929113907887fe0335
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Fixed sonar warning.

  * Utility classes should not have a public constructor

Other changes:

  * Increate unit test coverage.
  * Remove debugging code in unit test.

Change-Id: Ief8c10b02736f810a6b41eaf9e7d0a505f7614e1
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
(cherry picked from commit 2e10dbcd0e3e551b1b50f81ece9a3db7d86684a1)

Fixed IT breakage.

Change-Id: I2b2e3e962562cd59ec657f4f76dbfa6df99e57dd
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Increase unit test coverage.

Other changes:

  * implementation: FlowActionConverter, BridgeIdentifier:
    Remove unnecessary constructor.

Change-Id: I315555c4df7d7cc70268be9228b64f8e12113e7c
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
(cherry picked from commit 05590ed19fc439602ecfb6864a1fa3d3f25d4923)

Bug 5341 Fix for Failure in Fetching dataflows for vlan mapping

Change-Id: Id48cf634919138b3d203477250f9aff742e77ca0
Signed-off-by: gvrangan <venkatrangang@hcl.com>
(cherry picked from commit c1353ecf9d0178d0cb330b5132ee2b00c0d940d4)

Increase unit test coverage.

  * Added unit tests for manager.internal.vnode.xml package.

Other changes:

  * Fixed incorrect javadoc comments.
  * implementation: XmlVInterface.java: Don't use raw type.
  * it/util: VTNInetAddrAction.java: Added @Override annotation.

Change-Id: Id5c0652c3a163f900a99dc64cdc53421cc25305c
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
(cherry picked from commit 708de22d43ac3b06aaaee49fe9e22863d283cd7e)

Fixed unstable integration test.

  * Wait for completion of asynchronous tasks as needed.

Change-Id: Id323640c029fc536890b9152e74d4529ee696680
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
(cherry picked from commit e9f68a64593c93485b2142234b547f15628176af)

Merge "BUG 4678: Fixed Port map configuration with OpenStack Liberty"

BUG 4678: Fixed Port map configuration with OpenStack Liberty

Change-Id: I36b4f2692aed5997792dc552bd839d31b15d733a
Signed-off-by: ananthip <ananthip@hcl.com>
(cherry picked from commit 6baea77be7a4c72df434d380fd262d355a7689bf)

BUG 5234: Fixed FT scripts in VTN Coordinator

* Modified FT scripts in VTN Coordinator for VTN Manager RESTCONF
* Updated VBR, VBRIF_PORTMAP, VTERM, VTERMIF_PORTMAP, VBRIF/VTERMIF
  Flowfilter keytypes and its audit FT files.
* Modified Multi-Controller FT files.
* Modified the datafiles for the above Keytypes to support RESTCONF.
* Modified the validate functions in test scripts.

Change-Id: Iabdeb197687f5b04c019f790359cb1aaf82134fb
Signed-off-by: Karthik.S <siva-karthik@hcl.com>
(cherry picked from commit 8fbe60bf97169fa8eaa2a73e307b59c9d85f387c)

BUG 5300: Fixed UT for ODCdriver in VTN Coordinator

* Modified the UT for ODCdriver module in VTN Coordinator for
  the RESTCONF changes in VTN Manager.
* Fixed the UT failures in ODCdriver module.

Change-Id: Id0676211b62d30e1853dbc5f9a55f6af647a7a4f
Signed-off-by: yogalakshmi.pa <yogalakshmi.pa@hcl.com>
(cherry picked from commit 28ebb41f2e9de0dce2c4ded2ed918b4c7a1b848d)

Merge "Bug 5286: Fixed description attribute issue in create operation."

Merge "Bug 5294: Fixed update issue in flowfilter and flowlist keytypes"

Bug 5286: Fixed description attribute issue in create operation.

* Addressed for vtn/vbrif/vterminal/vtermif keytpes

Change-Id: I530a655370eecf6404dabc939009ac8646aaec8a
Signed-off-by: yogalakshmi.pa <yogalakshmi.pa@hcl.com>
(cherry picked from commit 1b3aec2a3b58f0525d7c2ee29995611cd8bf309d)