Dana Kutenicsova [Sun, 27 Jul 2014 18:28:18 +0000 (20:28 +0200)]
Fixed various findbugs issues in PCEP.
Change-Id: I1d1e2d21009a2ce22b8f8e646e8ba3c62eecc545
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sun, 27 Jul 2014 18:08:53 +0000 (20:08 +0200)]
Fixed various findbugs issues in util.
Change-Id: I5e31d46ed509596284764cb7a1eba63399789dff
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sun, 27 Jul 2014 20:38:49 +0000 (22:38 +0200)]
Fixed findbug issues in BGP.
Change-Id: I3c2fb7433682d1ef3cafb77273849a3f397fb26a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Maros Marsalek [Fri, 25 Jul 2014 14:02:45 +0000 (16:02 +0200)]
Update config files in bgpcep, remove duplicate config nodes
Change-Id: I02e315f622585b4de51718bf700b52d178fa4990
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Dana Kutenicsova [Tue, 29 Jul 2014 08:40:13 +0000 (08:40 +0000)]
Merge "BUG-1116: Require Peer handle for creation of AdjRIBsIn entries"
Robert Varga [Tue, 22 Jul 2014 13:57:38 +0000 (15:57 +0200)]
BUG-1116: Require Peer handle for creation of AdjRIBsIn entries
This change is required in order to maintain knowledge of where we
learned a particular route. This knowledge will then be used by the
AdjRibsOut wiring to suppress announcement of routes.
Change-Id: I8e8f38f78ef9a971f4884577c7455a7262284f4a
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 24 Jul 2014 20:04:53 +0000 (22:04 +0200)]
BUG-1287: migrate to WriteTransaction.submit()
WriteTransaction.commit() has been superseded by
WriteTransaction.submit(), so migrate the user.
Change-Id: Ibbcbe28001581cb9db5e9588a3618d4f60bf92f8
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 17 Jul 2014 10:41:44 +0000 (12:41 +0200)]
Update LSPDB incrementally
Now that the datastore can properly handle augment removal and fast
merges, we can get rid of the full rebuild we were doing.
This patch restores the previous logic, such that we enqueue only LSP
updates into the datastore.
The flip of 'synced' boolean is handled as a merge of a single leaf, so
should propagate writhout incurring any other overhead.
Change-Id: I488e15ebef3abdeab6df791b7ed3b7fe2c266330
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 17 Jul 2014 10:59:52 +0000 (12:59 +0200)]
Use Collections.singletonList()
Removes the use of ArrayList and ImmutableList for carrying a single
element.
Change-Id: I8ce335d2e82b57e7696b105b46cb387cd3cd8c0c
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 17 Jul 2014 10:01:24 +0000 (12:01 +0200)]
BUG-1394: Do not notify RPC callers until the report hits the datastore
During bursts of activity, unblocking RPC callers early can lead into
datastore overload, as the callers will immediately issue a new request,
which in turn can succeed before the datastore has had a chance to catch
up.
As a side-effect, that also fixes a logical race condition, where the
caller sees the RPC succeed, but when looking into the topology, still
does not see the state recorded there.
Finally we take care to reorganize the tracking of outstanding requests,
because netty may give us the response from the router before it gives
us the notification that the request has in fact left. Now each request
has a state and the transitions are carefully managed.
Change-Id: I06b1a56777ffb2df6394f1cdcb74396160bb4e4b
Signed-off-by: Robert Varga <rovarga@cisco.com>
Milos Fabian [Mon, 21 Jul 2014 12:18:47 +0000 (14:18 +0200)]
BUG-1287: migrate bgp-topology-provider
Data store has a new set of APIs, which are more efficient. This is a
straightforward migration, without taking advantage of the full APIs
available.
Change-Id: I5d82dd8ed0cb95f2075593713f253bd9abc5b686
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Mon, 21 Jul 2014 09:16:38 +0000 (11:16 +0200)]
BUG-1287: migrate bgp-rib
-fixed config tests
Data store has a new set of APIs, which are more efficient. This is a
straightforward migration, without taking advantage of the full APIs
available.
Change-Id: I3c205fecc08d6ef7f8bedfd481a77a1aeafab7d6
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Mon, 21 Jul 2014 06:56:51 +0000 (08:56 +0200)]
BUG-1287: migrate pcep-tunnel-provider
Data store has a new set of APIs, which are more efficient. This is a
straightforward migration, without taking advantage of the full APIs
available.
Change-Id: I19e7d49f69ecc0bf24fbb511e7bb05df682d5c73
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Robert Varga [Mon, 28 Jul 2014 12:29:19 +0000 (14:29 +0200)]
BUG-432: fix API breakage
Change-Id: I3543a33374be57018d49c89e1ac99499b0bc2fa2
Signed-off-by: Robert Varga <rovarga@cisco.com>
Milos Fabian [Fri, 25 Jul 2014 11:07:36 +0000 (13:07 +0200)]
Bug-1409: Fix empty Update message (EOR) handling.
-Processing of EOR in BGPSynchronization#updReceived ends up with NPE
-fixed behaviour - synchronize Ipv4 Unicast
Change-Id: I6b85cbcfd8ff9ec00c99b9f11b4bb2dce75ef334
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Robert Varga [Sat, 26 Jul 2014 15:09:14 +0000 (15:09 +0000)]
Merge "Fixed various small bugs found by Findbugs plugin."
Dana Kutenicsova [Sat, 26 Jul 2014 08:36:49 +0000 (08:36 +0000)]
Merge "Add defensive checks when looking up attributes"
Dana Kutenicsova [Fri, 25 Jul 2014 21:27:46 +0000 (23:27 +0200)]
Fixed various small bugs found by Findbugs plugin.
Change-Id: I343625bdb9efd2c0ffdfc12f6c0c9119f377041c
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 25 Jul 2014 15:05:42 +0000 (15:05 +0000)]
Merge changes I6723f9e0,Iab4269dc
* changes:
BUG-731: registration no longer throw exceptions
Improve message writing performance
Dana Kutenicsova [Fri, 25 Jul 2014 13:07:38 +0000 (15:07 +0200)]
BUG-1287 : fixed pcep/programming configs.
Change-Id: Ia202bf4afdcc152e3862d007781123774abef4fd
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Fri, 25 Jul 2014 12:43:46 +0000 (14:43 +0200)]
BUG-731: registration no longer throw exceptions
Since the registrations do not throw them, we can simplify our code,
ridding us of a warning.
Change-Id: I6723f9e09d7419f768f80affea0708439f34c8df
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 23 Jul 2014 16:00:47 +0000 (18:00 +0200)]
Improve message writing performance
The advice is to use the context for writing, so let's do precisely
that.
Change-Id: Iab4269dc140f4bfe22753e421feccf8cbe7bce78
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 17 Jul 2014 09:16:43 +0000 (11:16 +0200)]
Report IllegalArgument instead of IllegalState
This is wrong input, not internal state.
Change-Id: I8a0d459a308f309229cf55955be3a77604d47a1d
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Thu, 24 Jul 2014 15:30:07 +0000 (15:30 +0000)]
Merge "BUG-1287: migrate pcep-topology-provider"
Robert Varga [Thu, 24 Jul 2014 03:25:17 +0000 (05:25 +0200)]
BUG-1394: do not read in tight loops
We want to make sure we give writes a chance to complete before reading
again. Lower the amount of processing we do per loop to a single
message.
Change-Id: Iecf029afd2c2ae0288c5c483569e9acff7545a64
Signed-off-by: Robert Varga <rovarga@cisco.com>
Milos Fabian [Mon, 21 Jul 2014 06:25:30 +0000 (08:25 +0200)]
BUG-1287: migrate pcep-topology-provider
-fixed config tests
-ParserToSalTest uses AbstractDataBrokerTest
Change-Id: I93f20d32cce9fbd6dead2a0b181d4852f41181db
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Sun, 20 Jul 2014 14:45:27 +0000 (16:45 +0200)]
BUG-1287: migrate programming-impl
-fixed config tests to use new md-sal configuration
-ProgrammingServiceImplTest uses AbstractDataBroker test instead of mocked DataBroker
Change-Id: I6b0b110c9a61253f8ab17b6ca9f7fb44bf218460
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Dana Kutenicsova [Wed, 23 Jul 2014 08:33:08 +0000 (08:33 +0000)]
Merge "BUG-1394: add traces"
Robert Varga [Mon, 21 Jul 2014 08:37:22 +0000 (10:37 +0200)]
Add defensive checks when looking up attributes
Lookup of attributes is made more hardened, so we do not lose prefixes,
but only attributes in things go south.
Also adds an explicit argument check for null objectType to track down a
NPE we have been hitting.
Change-Id: I2eacc5c66cac747e1ebeb9d88367dcd1e4ea9281
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 18 Jul 2014 15:24:18 +0000 (17:24 +0200)]
BUG-1394: add traces
It seems that when we are processing a PCRpt, the request should already
be in the queue, but we are failing to find it. This should not occur,
so let's add some traces to pinpoint it.
Change-Id: I5c8ee574ab1c95fc25d465374a26a944ecc0b2ce
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sun, 20 Jul 2014 22:22:22 +0000 (00:22 +0200)]
Migrate to use tcpmd5 code in its new place
The TCP-MD5 has been bigrate into its own project and thus lives in new
artifacts, new packages and under a different version. This patch
removes the code from BGPCEP repository and points all callsites to the
new place.
Change-Id: Ic061ba419dd350f32eb7e212fdb6a8cbff243673
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 22 Jul 2014 11:52:54 +0000 (13:52 +0200)]
Always set the list of uncleaned instructions
Change-Id: Idbcc7b2d1c69d406ab0d34493d75a48da35aa111
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Mon, 21 Jul 2014 18:24:11 +0000 (18:24 +0000)]
Merge "Rework BGP timers to work with channel"
Robert Varga [Fri, 18 Jul 2014 16:30:44 +0000 (18:30 +0200)]
Rework BGP timers to work with channel
Since netty channel gives us scheduling capabilities, there is simply no
need for an external timer. So let's get rid of it and simplify our
code.
Change-Id: If6b7f84dbb953fc1766a6ddceb8411abcf1dc442
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Mon, 21 Jul 2014 09:22:03 +0000 (11:22 +0200)]
BUG-1389 : fixed removing of LSP by checking remove flag in SRP-id
Change-Id: I3788157c04a10b6052bb379907fc7cb0d250887c
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Mon, 21 Jul 2014 14:58:16 +0000 (14:58 +0000)]
Merge "Rework PCEP timers to work on channel"
Dana Kutenicsova [Mon, 21 Jul 2014 12:56:04 +0000 (14:56 +0200)]
Fixed failing build after yangtools update (List fields are by default not null).
- added checks for empty
Change-Id: I1a6eb2481f85ce895e2c17a229b11cf8f0ba2fc4
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Fri, 18 Jul 2014 15:41:59 +0000 (17:41 +0200)]
Rework PCEP timers to work on channel
This has the nice property that netty will ensure thread safety, e.g. we
do not have to synchronize channel lifecycle events anymore.
Change-Id: I37ddd71b6cca8210573e767966032885a7678669
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Fri, 18 Jul 2014 16:32:56 +0000 (16:32 +0000)]
Merge "Bug-194: Deleted jni-cfg artifact."
Dana Kutenicsova [Fri, 18 Jul 2014 08:02:13 +0000 (08:02 +0000)]
Merge "Bug-1370: Support for four-octet AS number capability only."
Milos Fabian [Wed, 16 Jul 2014 12:24:46 +0000 (14:24 +0200)]
Bug-194: Deleted jni-cfg artifact.
Dependency removed from integration SP dist.:
https://git.opendaylight.org/gerrit/#/c/9125/
Change-Id: Icc9cde348df549795dd79f15b549ab9a6091f8cb
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Thu, 17 Jul 2014 08:43:32 +0000 (10:43 +0200)]
Bug-1370: Support for four-octet AS number capability only.
-Both BGP speaker and peer, must advertise "support for four-octet AS number capability", to establish connection.
Change-Id: I2998e20439c12aca4e1a31660260d52f5d4963b5
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Dana Kutenicsova [Thu, 17 Jul 2014 11:34:48 +0000 (13:34 +0200)]
BUG-731 : removed some sonar warnings
Change-Id: I4b1a5cdd7a12acca6b86eebd384066fc918ff2e4
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Milos Fabian [Thu, 17 Jul 2014 05:46:41 +0000 (07:46 +0200)]
Bug-194: Explicitly include yang file and services in bundle.
Change-Id: Id207403ecbd2ef0e2e77690a6272d21a5f5ef19f
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Dana Kutenicsova [Thu, 17 Jul 2014 07:02:31 +0000 (07:02 +0000)]
Merge "Revert "Bug 1205 - AS path segment value encoded by 2 bytes""
Robert Varga [Wed, 16 Jul 2014 17:16:43 +0000 (17:16 +0000)]
Merge "Bug-194: Moved tcpmd5/jni-cfg to tcpmd5/jni"
Milos Fabian [Wed, 16 Jul 2014 13:50:53 +0000 (15:50 +0200)]
Revert "Bug 1205 - AS path segment value encoded by 2 bytes"
This reverts commit
d4f23f2d138b7bf0f1e1d2b61b5720749daf207f.
Change-Id: Iaa6e1d467630ba4bc32d9b67db6f09150d46d914
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Robert Varga [Wed, 16 Jul 2014 10:57:39 +0000 (12:57 +0200)]
Add missing tcpmd5-controller-config .project file
Change-Id: I55e7ad85cf9c0e35b3b39dfe2121081301d9308e
Signed-off-by: Robert Varga <rovarga@cisco.com>
Milos Fabian [Wed, 16 Jul 2014 11:48:19 +0000 (13:48 +0200)]
Bug-194: Moved tcpmd5/jni-cfg to tcpmd5/jni
-moved cfg yang model and java files
-preserved minimalistic pom.xml in tcpmd5/jni-cfg
Change-Id: Ifee8463c33376a9da076dcc9297452d506e47897
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Robert Varga [Wed, 16 Jul 2014 10:59:50 +0000 (10:59 +0000)]
Merge "Fixed PCEP activator. Fixed ExcludeRouteObject type."
Dana Kutenicsova [Wed, 16 Jul 2014 08:26:33 +0000 (10:26 +0200)]
Fixed PCEP activator.
Fixed ExcludeRouteObject type.
Change-Id: I77229dab5b92457fd425a489178e6d8b60a3282f
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Milos Fabian [Wed, 16 Jul 2014 08:00:23 +0000 (10:00 +0200)]
Bug-194: Fixed BGPCEP initail configurations.
Change-Id: I030c2996fdd2f4d2371247ee166bda0e86b66cba
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Fri, 11 Jul 2014 08:35:36 +0000 (10:35 +0200)]
Bug-194: Deleted BGPCEP config artifacts.
Change-Id: Id3d921dd86951388212c1d732043ef6a445bc1f5
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Robert Varga [Wed, 16 Jul 2014 07:27:12 +0000 (07:27 +0000)]
Merge "Bug-1370: Reads message body bytes as well as exception is thrown during parsing."
Milos Fabian [Mon, 14 Jul 2014 07:22:42 +0000 (09:22 +0200)]
Bug-612: Added check - before subobjects are serialized.
Change-Id: I1ec19c5529bc85c6dadb02f0e7979db447fcf48b
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Maros Marsalek [Tue, 15 Jul 2014 08:50:58 +0000 (10:50 +0200)]
BUG-731 Fix sonar warnings present in code for BUG-338
Change-Id: I9c3b34f0fbdefd6174ce59c97968746ba3886b98
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Robert Varga [Tue, 15 Jul 2014 19:39:26 +0000 (19:39 +0000)]
Merge "BUG-1025 : use correct YANG syntax to avoid yangtools warnings."
Robert Varga [Tue, 15 Jul 2014 19:39:05 +0000 (19:39 +0000)]
Merge "BUG-1025 : removed logs that pollute log file"
Robert Varga [Tue, 15 Jul 2014 19:38:36 +0000 (19:38 +0000)]
Merge "BUG-1199 : fixed incorrect parsing of Error message."
Milos Fabian [Tue, 15 Jul 2014 14:25:13 +0000 (16:25 +0200)]
Bug-1370: Reads message body bytes as well as exception is thrown during parsing.
Change-Id: I661d598ec662c7445aec93d56229eae3e67e1bd2
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Tue, 15 Jul 2014 15:05:18 +0000 (17:05 +0200)]
Bug-194: Fixed bundle exports.
Change-Id: Ib7b8adcca0cb552c97aac313171259eb98a8ca77
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Dana Kutenicsova [Tue, 15 Jul 2014 14:21:20 +0000 (16:21 +0200)]
BUG-1025 : use correct YANG syntax to avoid yangtools warnings.
Change-Id: Ic47bfb0d5fddd09c62ce271e8c48b2e31893c5a8
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 15 Jul 2014 13:48:39 +0000 (15:48 +0200)]
BUG-1025 : removed logs that pollute log file
Change-Id: Ia37f75d5427dc5102011ade1eeb427660a625510
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 15 Jul 2014 12:39:32 +0000 (14:39 +0200)]
BUG-1199 : fixed incorrect parsing of Error message.
Change-Id: I6227b82a34ae0efd6d0626bc1eef5a58e89031a8
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 15 Jul 2014 13:06:27 +0000 (13:06 +0000)]
Merge "BUG-670: enable reporting of PCEP errors"
Robert Varga [Thu, 26 Jun 2014 12:26:07 +0000 (14:26 +0200)]
BUG-670: enable reporting of PCEP errors
Adds a place where errors reported by a PCC can be stored and fills it
when a PCUpd request results in a failure.
Change-Id: Id235effcf6069b66b9f3f3cae19d0cb495ee332f
Signed-off-by: Robert Varga <rovarga@cisco.com>
Milos Fabian [Wed, 9 Jul 2014 12:00:00 +0000 (14:00 +0200)]
Bug-194: Moved bgp configuration artifacts.
-moved yang models and java files
-added required dependencies and plugins
-uniformed yang models file name
-configuration artifacts left with minimal pom.xml
Change-Id: Iae53875bcd940163687e238becff319767c320b4
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Tue, 8 Jul 2014 07:20:04 +0000 (09:20 +0200)]
Bug-194: Moved pcep configuration artifacts
-moved yang modules and java files
-added reqired maven dependencies and plugins
-uniformed config yang modules name
-moved stateful parsers extensions from pcep-impl, to avoid cyclic dependencies
-configuration artifacts left with minimalistic pom.xml file
Change-Id: I40d9628ff1d1b63bf3f2457dec4b0bfb0b11293e
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Robert Varga [Sun, 13 Jul 2014 15:35:59 +0000 (15:35 +0000)]
Merge "Bug-194: Moved tcp-md5 configuration artifacts"
Robert Varga [Sun, 13 Jul 2014 15:14:39 +0000 (15:14 +0000)]
Merge "Bug-194: Moved topology configuration artifacts"
Robert Varga [Sun, 13 Jul 2014 15:11:56 +0000 (15:11 +0000)]
Merge "Bug-194: Moved programming configuration artifacts"
Robert Varga [Sun, 13 Jul 2014 15:06:40 +0000 (15:06 +0000)]
Merge "BUG-730 : added test for pcep-spi registry."
Dana Kutenicsova [Thu, 10 Jul 2014 15:36:17 +0000 (17:36 +0200)]
BUG-1199 : fixed small mistake in Pcerr, added a test
Change-Id: I89e5812a66d711951f78a60473e06f0a1eabaf9e
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Thu, 10 Jul 2014 15:34:15 +0000 (17:34 +0200)]
BUG-1199 : fixed incorrect parsing of RSVP tlv
Change-Id: If8f1a1fe283e3254b27075c75871af5b5cfefb5c
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sat, 12 Jul 2014 21:41:19 +0000 (23:41 +0200)]
BUG-730 : added test for pcep-spi registry.
Change-Id: I54c8097a49e12dfe22d48a967dedcbcba7abd8f5
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Milos Fabian [Tue, 8 Jul 2014 12:00:23 +0000 (14:00 +0200)]
Bug-194: Moved tcp-md5 configuration artifacts
-moved yang modules and java files
-added required dependencies and plugins
Change-Id: Ie7fbd80036cbb30c04d5b491d0995cf27786968b
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Tue, 8 Jul 2014 10:15:36 +0000 (12:15 +0200)]
Bug-194: Moved topology configuration artifacts
-moved yang files
-renamed yang module
-added required dependencies
-left configuration artifact with minimal pom.xml
Change-Id: I4483544800c942b072aad833769bfb52ae2ea64b
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Tue, 8 Jul 2014 08:21:23 +0000 (10:21 +0200)]
Bug-194: Moved programming configuration artifacts
-moved yang modules and java files
-uniformed config yang modules name
-left configuration artifacts with minimal pom.xml
Change-Id: I1cc2734dc3e9ff320f614e31bd1b14c97ba2130d
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Robert Varga [Sun, 13 Jul 2014 13:29:25 +0000 (13:29 +0000)]
Merge "BUG-731 : extracted parts of long methods to separate methods - added test"
Robert Varga [Sun, 13 Jul 2014 13:27:58 +0000 (13:27 +0000)]
Merge "Fixed incorrect parsing of Linklocal/remote link identifier."
Dana Kutenicsova [Fri, 11 Jul 2014 21:55:22 +0000 (23:55 +0200)]
BUG-730 : added tests for pcep-spi.
Change-Id: I52b8b15cf8d2105f870213be1fe7c4b406a73524
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Thu, 10 Jul 2014 12:35:08 +0000 (14:35 +0200)]
BUG-731 : extracted parts of long methods to separate methods
- added test
Change-Id: I3e8eaf642d9dd9f9f14501455cc69d1f87a4801b
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Thu, 10 Jul 2014 12:27:22 +0000 (14:27 +0200)]
Fixed incorrect parsing of Linklocal/remote link identifier.
Change-Id: I28da0b76b991b619da98f4772469dd5db18d9f02
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Maros Marsalek [Fri, 4 Jul 2014 13:05:06 +0000 (15:05 +0200)]
BUG-338 Allow incomming BGP connections.
Added BGPPeerRegistry that holds all configured BGP peers.
Client/Server SessionNegotiators retrieve BGPPeers(SessionListeners) from the BGPPeerRegistry.
Added StrictBGPPeerRegistry (default implementation of BGPPeerRegistry) that allows only 1 session with BGP peer. If second session is being established, the registry drops either already established or new BGP session (depending on higher source BGP ID).
Added 2 config attributes to BGPPeer:
- initiate connection: true to start BGP connection from ODL. False if just configure BGP peer to accept session from remote device.
- peer registry: dependency on BGPPeerRegistry. Peer registers itself into this registry.
* new attributes are optional to preserve backwards compatibility.
Change-Id: I2f7a606db5196fed49094d49efbb570c4d0fbecb
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Dana Kutenicsova [Tue, 8 Jul 2014 13:00:00 +0000 (13:00 +0000)]
Merge "BUG-1287: migrate tests to new APIs"
Dana Kutenicsova [Tue, 8 Jul 2014 12:51:22 +0000 (12:51 +0000)]
Merge "Bug-731: pcep Tlv serializers - fixed sonar issues"
Dana Kutenicsova [Tue, 8 Jul 2014 12:50:57 +0000 (12:50 +0000)]
Merge "Bug-731: fixed segment-routing sonar issues."
Milos Fabian [Tue, 8 Jul 2014 08:52:13 +0000 (10:52 +0200)]
Bug-731: pcep Tlv serializers - fixed sonar issues
-no need to check for null before an insteadof
-fixed precondition checks in Tlv serializers
Change-Id: I8727f83beb713c427c0337b9058c00490631b1e8
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Mon, 7 Jul 2014 10:59:23 +0000 (12:59 +0200)]
Bug-731: fixed segment-routing sonar issues.
Change-Id: Ie6e120f38ebf036fc09cb601d9c46a572cdffe7e
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Dana Kutenicsova [Sun, 6 Jul 2014 15:43:56 +0000 (17:43 +0200)]
BUG-730 : cleaned up bgp-parser-impl
Change-Id: I478cc65158c58a7e92adce3de17dc265de779034
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sun, 6 Jul 2014 13:52:30 +0000 (15:52 +0200)]
BUG-730 : added tests to bgp-parser-api
Change-Id: I4b90b646610262cb4ff51b9cf68177eb8113c12c
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sun, 6 Jul 2014 07:14:08 +0000 (09:14 +0200)]
BUG-730 : refactor bgp-linkstate
Change-Id: I8a3bac4cb3c3aeaf7b310fbfb4a00a4eb332524b
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Mon, 7 Jul 2014 18:53:18 +0000 (18:53 +0000)]
Merge "BUG-730 : added test for bgp/concepts"
Dana Kutenicsova [Mon, 7 Jul 2014 09:48:22 +0000 (09:48 +0000)]
Merge "Fixed segment-routing formating."
Dana Kutenicsova [Mon, 7 Jul 2014 09:47:26 +0000 (09:47 +0000)]
Merge "Bug-612: fix segment-routing serializers"
Dana Kutenicsova [Mon, 7 Jul 2014 09:47:12 +0000 (09:47 +0000)]
Merge "Bug-612: ietf-stateful07 serializers - improved code defense."
Dana Kutenicsova [Mon, 7 Jul 2014 09:46:34 +0000 (09:46 +0000)]
Merge "Bug-612: ietf-stateful02 serializers - improved code defense"
Dana Kutenicsova [Mon, 7 Jul 2014 09:43:43 +0000 (09:43 +0000)]
Merge "Bug-612: Base PCEP serializers - more defensive code"
Dana Kutenicsova [Mon, 7 Jul 2014 09:42:16 +0000 (09:42 +0000)]
Merge "Bug-612: Added ByteBufWriteUtil class"
Milos Fabian [Mon, 7 Jul 2014 09:07:02 +0000 (11:07 +0200)]
Fixed segment-routing formating.
-replaced deprecated method call in configuration test
Change-Id: I6f5359e2850a81909c5e519666322463ec00db60
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Code Review / bgpcep.git / log