BUG-5013 Check MatchUtils.createICMPv4Match input

ALL_ICMP is in fact fed in at EgressAclService.java:388
which causes an exception to be thrown. This occurs during
various tempest tests.

Change-Id: I5e6fdc0e9aa6fdcfe7f361879342feaf4d96e25d
Signed-off-by: Josh <jhershbe@redhat.com>
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Bug 4997 - Fix for ConnectionInfo parsing in showMdsal tool

Change-Id: If3fee23373829c520fcc532ba70b1a45061aa2b3
Signed-off-by: Sam Hague <shague@redhat.com>

Merge "BUG 4132 - backport to lithium" into stable/lithium

BUG 4132 - backport to lithium

Fix in master:
https://git.opendaylight.org/gerrit/#/c/32324/
(this is a mod to the commit msg in an attempt
to trigger a build)

Change-Id: I5e2253d08acc24345a27ac3752795d40994e486a
Signed-off-by: Josh <jhershbe@redhat.com>

Merge "Added support for port range in TCP and UDP security group rules" into stable/lithium

Merge "BUG-4205 : VM delete does not remove all related flows (backmerge)" into stable/lithium

Fixes an issue in induvidual security rule update, when remote SG is
selected.

Change-Id: Id8d5ea6c6235c31f9147556244f619a15a279382
Signed-off-by: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>

BUG-4205 : VM delete does not remove all related flows (backmerge)

This gerrit is the back merge of patch set 3 of gerrit
https://git.opendaylight.org/gerrit/#/c/32498/

Rebase and add ref to bug 4971.

Change-Id: I716c6cfebe43ab4573ce24369f5ec07a40440616
Signed-off-by: bviswa <badrinath_viswanatha@dell.com>
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Added support for port range in TCP and UDP security group rules

Back merging Change-Id: I69ecc8eb52bedb641a7b2c4407b3e070ed2c1677

Change-Id: I7e0675ccc22d0dd81df22a1fcc24197110bbba70
Signed-off-by: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>

Merge "Avoid logging stacktraces for schema version mismatches" into stable/lithium

Bug 4927 - Rules added by MacResolverServices in br-ex are not removed

This bug can be reproduced by using an external router address
that is not owned by any system in the external neutron subnet.

Made the flow remove call idem-potent and in a common function.

Added missing flow remove calls in the following 2 missing places:
  * Entry removal (non periodic and periodic)
  * Time period restart

Change-Id: Idf481d3a13c1728bf400f185de296cbada7d920b
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Bug 4331 - External bridge used for gateway mac resolver needs to be dynamic (cont.)

This is an additional patchset for changes that shuffle list of dpids so that
different br-ex instances are used when mac resolver is not getting an answer.
The other part of this gerrit has been merged via:
https://git.opendaylight.org/gerrit/#/c/32284/

With this change the GatewayMacResolverService will become resilient to the cases
where nodes get deleted or lose br-ex connectivity after the resolver is kicked
off to periodically track a given ip address.

Also made some minor clean up in NeutronL3Adapter, so that it needs not to
duplicate work for tracking ip in the very first iteration. That duplication
is not necessary as the GatewayMacResolverService is already implemented
with thread executors for the periodic monitoring.

Lastly, this gerrit augments the GatewayMacResolver service to provide
an extra boolean param called refreshExternalNetworkBridgeDpidIfNeeded.
That can be used to control whether dpid used gets updated when mac is
not getting resolved.

Change-Id: I142735f875d1a79144c204bec631712de00d9746
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Merge "Bug 4913 - populate openflow rules for security group on port creation" into stable/lithium

Bug 4913 - populate openflow rules for security group on port creation

When port is created, original port is null.
In that case, flow should be populated instead of ignoring the events.

Change-Id: I1f90868bbb4bcb3e7d40474133bcaafe2fc1983a
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
(cherry picked from commit 1c9dc3604a5ba49aa01b86dce705f202b2d8cd1f)

Bug 4912 - NeutronL3Adapter: missing/reordered enabled check

NeutronL3Adapter.processEvent() can be called before its initialization
The security group process should be after enabled check.

Change-Id: I7fc48a70cacca5a9a1d7a017476259543c8a0086
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
(cherry picked from commit 7003972d8cadaa2e73412d02640153ca70319314)

Merge "Bug 4331 - External bridge used for gateway mac resolver needs to be dynamic" into stable/lithium

Bug 4331 - External bridge used for gateway mac resolver needs to be dynamic

With this change the GatewayMacResolverService will become resilient to the cases
where nodes get deleted or lose br-ex connectivity after the resolver is kicked
off to periodically track a given ip address.

Also made some minor clean up in NeutronL3Adapter, so that it needs not to
duplicate work for tracking ip in the very first iteration. That duplication
is not necessary as the GatewayMacResolverService is already implemented
with thread executors for the periodic monitoring.

Lastly, this gerrit augments the GatewayMacResolver service to provide
an extra boolean param called refreshExternalNetworkBridgeDpidIfNeeded.
That can be used to control whether dpid used gets updated when mac is
not getting resolved.

Change-Id: I95b9e5a2d5773a6be82221b71000ace2a662e772
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Add a unit test for TyperUtils::checkVersion()

Change-Id: Ibb133dfc0a225c275a9cd6cbdb1fb060a8e97e17
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Merge "BUG-4205 : VM delete doesnot remove all flows - handle port updates" into stable/lithium

Drop commons-collections (CVE-2015-7501)

commons-collections is only used for a debug method in NodeDatabase,
which nothings calls; so remove that and drop all references to
commons-collection.

(The Karaf Maven bundle plugin pulls in commons-collection 3.2 via
doxia, but that shouldn't have any impact on runtime behaviour.)

Change-Id: I94a2379ae9564a689872468e9804bf8cc52505e8
Signed-off-by: Stephen Kitt <skitt@redhat.com>

BUG-4205 : VM delete doesnot remove all flows - handle port updates

Change-Id: I1cf82eb0d89f5fc5cdc6d6e99fd2bd53df63aa1b
Signed-off-by: bviswa <badrinath_viswanatha@dell.com>

Merge "Avoid an NPE in OvsdbNodeRemoveCommand" into stable/lithium

Avoid an NPE in OvsdbNodeRemoveCommand

In some cases (perhaps only test code)
ovsdbNodeAugmentation.getManagerEntry() returns null; this patch adds
a test to avoid the resulting NPE.

Change-Id: If545d3e4478deb91703029d8226957c5c61d2125
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit 166befe3a62165b358c9eaeeba9e4629923d01ee)

Bug 4874 - distributed arp in old l3 for ovsdb is not installing rules when it should

Fix TenantNetworkManagerImpl::isTenantNetworkPresentInNode(), so it does not
use stale node to determine the termination points.

Patch set 2: fix UT

Change-Id: I22e1e88ca5b37f6da28b2281f01aaec07c3f751e
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Avoid logging stacktraces for schema version mismatches

Change-Id: Ic3db3d3526491bb488d396be64adc9e41e09a3d6
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Fix the javadoc to build with JDK 8

Change-Id: I62e0d81f0543e199c9869c6bf197ea8e40118a3c
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Remove extra return statement.

When Flow id caches that were no longer needed
were removed from code, a lonely return statement
in the router interface remove code path was
left behind.

Gerrit: https://git.opendaylight.org/gerrit/#/c/29204/

Change-Id: Ic978953ab65da91baf543e21ea86333b4a9ee5ca
Reference: Ic2acced7a9a006e6e04afba6fea22aaf0620f134
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Merge "Bug 4733 - impl/SecurityServicesImpl.java: null pointer exception" into stable/lithium

Merge "Bug 4736 - Add null poiner check of getFixedIPs()" into stable/lithium

Merge "Bug 4579 - Periodic ARP resolver is missing callback for MAC updates" into stable/lithium

Bug 4736 - Add null poiner check of getFixedIPs()

NeutronPort.getFixedIPs() can return null.  In netvirt code, some
codes have null pointer check, some doesn't inconsistently.  Add null
pointer check consistently to avoid potential null pointer exception.

Change-Id: I69054f21bd2b18d6861e310a2f5e3e34d8b5a6de
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Bug 4733 - impl/SecurityServicesImpl.java: null pointer exception

This patch masks the following null pointer exception.
The code assumes that there is always nodes(ovs switch) corresponding to
neutron port always exists. But this is not always true because there are
race conditions and some tempests tests only run neutron without nova.
So the code shouldn't assume that nodes always exists and also external
attributes in ovsdb always exists. The latter case will be addressed by
another patch.
NOTE: this patch only addresses null pointer exception. The race condition
should be handled somehow later.

> 2015-12-03 18:48:15,562 | ERROR | ntDispatcherImpl | TenantNetworkManagerImpl         | 267 - org.opendaylight.ovsdb.openstack.net-virt - 1.2.1.SNAPSHOT | Exception during handlingNeutron network delete
> java.lang.NullPointerException
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.SouthboundImpl.extractTerminationPointAugmentations(SouthboundImpl.java:482)[267:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.SouthboundImpl.getTerminationPointsOfBridge(SouthboundImpl.java:437)[267:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.SecurityServicesImpl.getInterface(SecurityServicesImpl.java:435)[267:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.SecurityServicesImpl.syncSecurityRule(SecurityServicesImpl.java:371)[267:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.PortSecurityHandler.syncSecurityGroup(PortSecurityHandler.java:165)[267:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.PortSecurityHandler.processNeutronSecurityRuleAdded(PortSecurityHandler.java:144)[267:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.PortSecurityHandler.processEvent(PortSecurityHandler.java:130)[267:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.EventDispatcherImpl.dispatchEvent(EventDispatcherImpl.java:94)[267:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.EventDispatcherImpl.access$200(EventDispatcherImpl.java:27)[267:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.EventDispatcherImpl$1.run(EventDispatcherImpl.java:56)[267:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[:1.8.0_45-internal]
>         at java.util.concurrent.FutureTask.run(FutureTask.java:266)[:1.8.0_45-internal]
>         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)[:1.8.0_45-internal]
>         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)[:1.8.0_45-internal]
>         at java.lang.Thread.run(Thread.java:745)[:1.8.0_45-internal]

Change-Id: I37e0a72c4bc4361b678f748bf1df6c926c101cb1
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Back porting  the master changes for security groups to lithum branch,
This include
1)Support for all the protocols.
2)Update of Security group associated with a port.
3)Update of remote security rules when new vm is added / removed.
4)Update of induvidual rules in a security group.

Patch 2
https://git.opendaylight.org/gerrit/#/c/30253/4
Avoid exceptions with IPv6 subnets

Change-Id: I8119bee4862e1d21341428037d06b08e54953486
Signed-off-by: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>

Bug 4579 - Periodic ARP resolver is missing callback for MAC updates

Patch set 1: Add GatewayMacResolverListener, so GatewayMacResolver have a simple
way of telling listener about changes to a resolved mac address.

Patch set 2: Initial review from Andre: Make GatewayMacResolverListener part of
ArpResolverMetadata

Patch set 3: Change context of callback, so it percolates to listener using the
thread that is used for handling all events in NeutronL3Adapter

Patch set 4: Fix UT

Patch set 5: Fix gerrit's topic

Change-Id: I21523c0c6e06c21f4dbf5b914f5dec625a40ab83
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
Also-By: Andre Fredette <afredette@redhat.com>

Bug 4752 - Distributed arp only needed on compute nodes that have tenant net

Missing logic to avoid adding unnecessary rules for distributed arp in
compute nodes that did not have any tenant vms for a particular
segmentation id

Change-Id: Ib9183be4bdc6a23e0b748acfff13992e6a36c684
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Merge "BUG-4205 : VM delete doesnot remove all related flows" into stable/lithium

Merge "Bug 4734 - netvirt/GatewayMacResolverService: null pinter exception" into stable/lithium

Bug 4734 - netvirt/GatewayMacResolverService: null pinter exception

Null pointer exception happens as follows. there is no guarantee that
gatewayToArpMetadataMap caches entry for gatewayIp.  This patch only
addresses null pointer exception. The race condition should be handled
somehow.

> 2015-12-03 18:48:38,091 | ERROR | ntLoopGroup-11-2 | ExecutionList                    | 37 - com.google.guava - 18.0.0 | RuntimeException while executing runnable com.google.common.util.concurrent.Futures$6@4c708463 with executor INSTANCE
> java.lang.NullPointerException
>         at org.opendaylight.ovsdb.openstack.netvirt.providers.openflow13.services.arp.GatewayMacResolverService$3.onSuccess(GatewayMacResolverService.java:262)[268:org.opendaylight.ovsdb.openstack.net-virt-providers:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.providers.openflow13.services.arp.GatewayMacResolverService$3.onSuccess(GatewayMacResolverService.java:249)[268:org.opendaylight.ovsdb.openstack.net-virt-providers:1.2.1.SNAPSHOT]
>         at com.google.common.util.concurrent.Futures$6.run(Futures.java:1319)[37:com.google.guava:18.0.0]
>         at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:457)[37:com.google.guava:18.0.0]
>         at com.google.common.util.concurrent.ExecutionList.executeListener(ExecutionList.java:156)[37:com.google.guava:18.0.0]
>         at com.google.common.util.concurrent.ExecutionList.execute(ExecutionList.java:145)[37:com.google.guava:18.0.0]
>         at com.google.common.util.concurrent.AbstractFuture.set(AbstractFuture.java:185)[37:com.google.guava:18.0.0]
>         at com.google.common.util.concurrent.Futures$ChainingListenableFuture$1.run(Futures.java:918)[37:com.google.guava:18.0.0]
>         at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:457)[37:com.google.guava:18.0.0]
>         at com.google.common.util.concurrent.Futures$ImmediateFuture.addListener(Futures.java:106)[37:com.google.guava:18.0.0]
>         at com.google.common.util.concurrent.Futures$ChainingListenableFuture.run(Futures.java:914)[37:com.google.guava:18.0.0]
>         at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:457)[37:com.google.guava:18.0.0]
>         at com.google.common.util.concurrent.ExecutionList.executeListener(ExecutionList.java:156)[37:com.google.guava:18.0.0]
>         at com.google.common.util.concurrent.ExecutionList.execute(ExecutionList.java:145)[37:com.google.guava:18.0.0]
>         at com.google.common.util.concurrent.AbstractFuture.set(AbstractFuture.java:185)[37:com.google.guava:18.0.0]
>         at com.google.common.util.concurrent.Futures$ChainingListenableFuture$1.run(Futures.java:918)[37:com.google.guava:18.0.0]
>         at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:457)[37:com.google.guava:18.0.0]
>         at com.google.common.util.concurrent.ExecutionList.executeListener(ExecutionList.java:156)[37:com.google.guava:18.0.0]
>         at com.google.common.util.concurrent.ExecutionList.execute(ExecutionList.java:145)[37:com.google.guava:18.0.0]
>         at com.google.common.util.concurrent.AbstractFuture.set(AbstractFuture.java:185)[37:com.google.guava:18.0.0]
>         at com.google.common.util.concurrent.Futures$ChainingListenableFuture$1.run(Futures.java:918)[37:com.google.guava:18.0.0]
>         at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:457)[37:com.google.guava:18.0.0]
>         at com.google.common.util.concurrent.Futures$ImmediateFuture.addListener(Futures.java:106)[37:com.google.guava:18.0.0]
>         at com.google.common.util.concurrent.Futures$ChainingListenableFuture.run(Futures.java:914)[37:com.google.guava:18.0.0]
>         at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:457)[37:com.google.guava:18.0.0]
>         at com.google.common.util.concurrent.ExecutionList.executeListener(ExecutionList.java:156)[37:com.google.guava:18.0.0]
>         at com.google.common.util.concurrent.ExecutionList.execute(ExecutionList.java:145)[37:com.google.guava:18.0.0]
>         at com.google.common.util.concurrent.AbstractFuture.set(AbstractFuture.java:185)[37:com.google.guava:18.0.0]
>         at com.google.common.util.concurrent.SettableFuture.set(SettableFuture.java:53)[37:com.google.guava:18.0.0]
>         at org.opendaylight.openflowjava.protocol.impl.core.connection.AbstractRpcListener.successfulRpc(AbstractRpcListener.java:88)[249:org.opendaylight.openflowjava.openflow-protocol-impl:0.7.0.SNAPSHOT]
>         at org.opendaylight.openflowjava.protocol.impl.core.connection.SimpleRpcListener.operationSuccessful(SimpleRpcListener.java:17)[249:org.opendaylight.openflowjava.openflow-protocol-impl:0.7.0.SNAPSHOT]
>         at org.opendaylight.openflowjava.protocol.impl.core.connection.AbstractRpcListener.operationComplete(AbstractRpcListener.java:63)[249:org.opendaylight.openflowjava.openflow-protocol-impl:0.7.0.SNAPSHOT]
>         at io.netty.util.concurrent.DefaultPromise.notifyListener0(DefaultPromise.java:680)[100:io.netty.common:4.0.30.Final]
>         at io.netty.util.concurrent.DefaultPromise.notifyListeners(DefaultPromise.java:567)[100:io.netty.common:4.0.30.Final]
>         at io.netty.util.concurrent.DefaultPromise.trySuccess(DefaultPromise.java:406)[100:io.netty.common:4.0.30.Final]
>         at io.netty.channel.DefaultChannelPromise.trySuccess(DefaultChannelPromise.java:82)[101:io.netty.transport:4.0.30.Final]
>         at io.netty.channel.ChannelOutboundBuffer.safeSuccess(ChannelOutboundBuffer.java:672)[101:io.netty.transport:4.0.30.Final]
>         at io.netty.channel.ChannelOutboundBuffer.remove(ChannelOutboundBuffer.java:262)[101:io.netty.transport:4.0.30.Final]
>         at io.netty.channel.ChannelOutboundBuffer.removeBytes(ChannelOutboundBuffer.java:342)[101:io.netty.transport:4.0.30.Final]
>         at io.netty.channel.socket.nio.NioSocketChannel.doWrite(NioSocketChannel.java:318)[101:io.netty.transport:4.0.30.Final]
>         at io.netty.channel.AbstractChannel$AbstractUnsafe.flush0(AbstractChannel.java:761)[101:io.netty.transport:4.0.30.Final]
>         at io.netty.channel.nio.AbstractNioChannel$AbstractNioUnsafe.flush0(AbstractNioChannel.java:311)[101:io.netty.transport:4.0.30.Final]
>         at io.netty.channel.AbstractChannel$AbstractUnsafe.flush(AbstractChannel.java:729)[101:io.netty.transport:4.0.30.Final]
>         at io.netty.channel.DefaultChannelPipeline$HeadContext.flush(DefaultChannelPipeline.java:1127)[101:io.netty.transport:4.0.30.Final]
>         at io.netty.channel.AbstractChannelHandlerContext.invokeFlush(AbstractChannelHandlerContext.java:663)[101:io.netty.transport:4.0.30.Final]
>         at io.netty.channel.AbstractChannelHandlerContext.flush(AbstractChannelHandlerContext.java:644)[101:io.netty.transport:4.0.30.Final]
>         at io.netty.channel.ChannelOutboundHandlerAdapter.flush(ChannelOutboundHandlerAdapter.java:115)[101:io.netty.transport:4.0.30.Final]
>         at io.netty.channel.AbstractChannelHandlerContext.invokeFlush(AbstractChannelHandlerContext.java:663)[101:io.netty.transport:4.0.30.Final]
>         at io.netty.channel.AbstractChannelHandlerContext.flush(AbstractChannelHandlerContext.java:644)[101:io.netty.transport:4.0.30.Final]
>         at io.netty.channel.DefaultChannelPipeline.flush(DefaultChannelPipeline.java:897)[101:io.netty.transport:4.0.30.Final]
>         at io.netty.channel.AbstractChannel.flush(AbstractChannel.java:192)[101:io.netty.transport:4.0.30.Final]
>         at org.opendaylight.openflowjava.protocol.impl.core.connection.ChannelOutboundQueue.flush(ChannelOutboundQueue.java:212)[249:org.opendaylight.openflowjava.openflow-protocol-impl:0.7.0.SNAPSHOT]
>         at org.opendaylight.openflowjava.protocol.impl.core.connection.ChannelOutboundQueue.access$000(ChannelOutboundQueue.java:37)[249:org.opendaylight.openflowjava.openflow-protocol-impl:0.7.0.SNAPSHOT]
>         at org.opendaylight.openflowjava.protocol.impl.core.connection.ChannelOutboundQueue$1.run(ChannelOutboundQueue.java:81)[249:org.opendaylight.openflowjava.openflow-protocol-impl:0.7.0.SNAPSHOT]
>         at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:327)[100:io.netty.common:4.0.30.Final]
>         at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:350)[101:io.netty.transport:4.0.30.Final]
>         at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:110)[100:io.netty.common:4.0.30.Final]
>         at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:137)[100:io.netty.common:4.0.30.Final]
>         at java.lang.Thread.run(Thread.java:745)[:1.8.0_45-internal]

Change-Id: I0f7d233b14b672c98ff41d6295eded51da3d4e2a
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Bug 4735 - null pointer exception in SouthboundImpl

This patch adds null pointer check in SouthboundImpl.
NOTE: this patch doesn't address to handle race condition. it only
prevents null pointer exception.

> 2015-12-03 18:52:34,554 | ERROR | ntDispatcherImpl | EventDispatcher                  | 267 - org.opendaylight.ovsdb.openstack.net-virt - 1.2.1.SNAPSHOT | Exception in dispatching event SouthboundEvent [type=PORT, action=DELETE, augmentationData=OvsdbTerminationPointAugmentation{getInterfaceType=class org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.rev150105.InterfaceTypeInternal, getInterfaceUuid=Uuid [_value=971b84f3-5bff-4368-82b3-6c24aa9cb257], getName=br-int, getOfport=65534, getPortUuid=Uuid [_value=89b73b42-4f07-42f3-b9dc-1ee2b4f6667a]}, node=Node{getNodeId=Uri [_value=ovsdb://uuid/8f75c49c-52b9-4303-8633-a80f0361429b/bridge/br-int], getTerminationPoint=[TerminationPoint{getTpId=Uri [_value=br-int], augmentations={interface org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.rev150105.OvsdbTerminationPointAugmentation=OvsdbTerminationPointAugmentation{getInterfaceType=class org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.rev150105.InterfaceTypeInternal, getInterfaceUuid=Uuid [_value=971b84f3-5bff-4368-82b3-6c24aa9cb257], getName=br-int, getOfport=65534, getPortUuid=Uuid [_value=89b73b42-4f07-42f3-b9dc-1ee2b4f6667a]}}}, TerminationPoint{getTpId=Uri [_value=tap1ecd746e-40], augmentations={interface org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.rev150105.OvsdbTerminationPointAugmentation=OvsdbTerminationPointAugmentation{getInterfaceExternalIds=[InterfaceExternalIds{getExternalIdKey=iface-id, getExternalIdValue=1ecd746e-4018-4795-9105-ee70d86449be, augmentations={}}, InterfaceExternalIds{getExternalIdKey=attached-mac, getExternalIdValue=fa:16:3e:c6:03:aa, augmentations={}}, InterfaceExternalIds{getExternalIdKey=iface-status, getExternalIdValue=active, augmentations={}}], getInterfaceType=class org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.rev150105.InterfaceTypeInternal, getInterfaceUuid=Uuid [_value=e5c88292-80de-41bb-ba83-4869d6a4d013], getName=tap1ecd746e-40, getOfport=1, getPortUuid=Uuid [_value=7d8776ca-5f99-4332-96b3-6e4d04a7f732]}}}, TerminationPoint{getTpId=Uri [_value=patch-ext], augmentations={interface org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.rev150105.OvsdbTerminationPointAugmentation=OvsdbTerminationPointAugmentation{getInterfaceType=class org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.rev150105.InterfaceTypePatch, getInterfaceUuid=Uuid [_value=cf25e881-75c3-4022-9a31-fc5eb7f0edd0], getName=patch-ext, getOfport=2, getOptions=[Options{getOption=peer, getValue=patch-int, augmentations={}}], getPortExternalIds=[PortExternalIds{getExternalIdKey=opendaylight-iid, getExternalIdValue=/network-topology:network-topology/network-topology:topology[network-topology:topology-id='ovsdb:1']/network-topology:node[network-topology:node-id='ovsdb://uuid/8f75c49c-52b9-4303-8633-a80f0361429b/bridge/br-int']/network-topology:termination-point[network-topology:tp-id='patch-ext'], augmentations={}}], getPortUuid=Uuid [_value=b90b5a4b-c32b-4194-a789-cb676c7096f1]}}}], augmentations={interface org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.rev150105.OvsdbBridgeAugmentation=OvsdbBridgeAugmentation{getBridgeExternalIds=[BridgeExternalIds{getBridgeExternalIdKey=opendaylight-iid, getBridgeExternalIdValue=/network-topology:network-topology/network-topology:topology[network-topology:topology-id='ovsdb:1']/network-topology:node[network-topology:node-id='ovsdb://uuid/8f75c49c-52b9-4303-8633-a80f0361429b/bridge/br-int'], augmentations={}}], getBridgeName=OvsdbBridgeName [_value=br-int], getBridgeOpenflowNodeRef=KeyedInstanceIdentifier{targetType=interface org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.Node, path=[org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.NetworkTopology, org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.Topology[key=TopologyKey [_topologyId=Uri [_value=ovsdb:1]]], org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.Node[key=NodeKey [_nodeId=Uri [_value=ovsdb://uuid/8f75c49c-52b9-4303-8633-a80f0361429b]]]]}, getBridgeOtherConfigs=[BridgeOtherConfigs{getBridgeOtherConfigKey=disable-in-band, getBridgeOtherConfigValue=true, augmentations={}}], getBridgeUuid=Uuid [_value=1909fea5-3201-487a-a1f6-09b53d9c4c9d], getControllerEntry=[ControllerEntry{getControllerUuid=Uuid [_value=523b204f-c75a-41cb-b953-ab16dfb29259], getTarget=Uri [_value=tcp:143.183.96.62:6653], isIsConnected=true, augmentations={}}], getDatapathId=DatapathId [_value=00:00:a6:fe:09:19:7a:48], getDatapathType=class org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.rev150105.DatapathTypeSystem, getFailMode=class org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.rev150105.OvsdbFailModeSecure, getManagedBy=OvsdbNodeRef [_value=KeyedInstanceIdentifier{targetType=interface org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.Node, path=[org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.NetworkTopology, org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.Topology[key=TopologyKey [_topologyId=Uri [_value=ovsdb:1]]], org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.Node[key=NodeKey [_nodeId=Uri [_value=ovsdb://uuid/8f75c49c-52b9-4303-8633-a80f0361429b]]]]}], getProtocolEntry=[ProtocolEntry{getProtocol=class org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.rev150105.OvsdbBridgeProtocolOpenflow13, augmentations={}}]}}}]
> java.lang.NullPointerException
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.SouthboundImpl.extractNodeAugmentation(SouthboundImpl.java:427)[267:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.SouthboundImpl.getOtherConfig(SouthboundImpl.java:658)[267:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.BridgeConfigurationManagerImpl.getAllPhysicalInterfaceNames(BridgeConfigurationManagerImpl.java:264)[267:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.SouthboundHandler.processPortDelete(SouthboundHandler.java:136)[267:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.SouthboundHandler.processPortEvent(SouthboundHandler.java:289)[267:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.SouthboundHandler.processEvent(SouthboundHandler.java:232)[267:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.EventDispatcherImpl.dispatchEvent(EventDispatcherImpl.java:94)[267:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.EventDispatcherImpl.access$200(EventDispatcherImpl.java:27)[267:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.EventDispatcherImpl$1.run(EventDispatcherImpl.java:56)[267:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[:1.8.0_45-internal]
>         at java.util.concurrent.FutureTask.run(FutureTask.java:266)[:1.8.0_45-internal]
>         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)[:1.8.0_45-internal]
>         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)[:1.8.0_45-internal]

Change-Id: I0887d7fd205ba8f743a2730eb6f4b39dddf900e4
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Merge "Bumping versions by 0.0.1 for next dev cycle" into stable/lithium

Merge "UT for ProtocolRemovedCommand class" into stable/lithium

Bumping versions by 0.0.1 for next dev cycle

Change-Id: Icef6d6d4f7c49cbb940aed51984ae085e17d0aa3
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Release Lithium-SR3

Change-Id: I5481e41c0d4373948d0f884e4122b66924ff2e28
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

UT for ProtocolRemovedCommand class

Change-Id: Icd2b454b49b214735540c20281d6611071309947
Signed-off-by: Layth Al-Ani <lalani@inocybe.com>
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>

Merge "Fixed possible null point exception in node manager entries update code" into stable/lithium

Merge "UT for remaining classes in ovsdb.southbound.ovsdb.transact" into stable/lithium

Fixed possible null point exception in node manager entries update code

Change-Id: Iac231117e592f23c6e1362b71e76ae13d6c98a40
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>

Merge "Bug 4611: null pointer exception while processing interface event" into stable/lithium

For controller initiated connection, there is race condition
while disconnecting the device from controller, that does
not allow one of the non-owner southbound instance to disconnect
the device from the plugin. Race condition was occuring because
OvsdbConnectionInstance was not stored in the internal cache
at correct point in control flow.It gets added when EntityOwnershipChange
event happens, so when data change event for disconnection occured,
it requires OvsdbConnectionInstance to be in cache to disconnect
from the device, but OvsdbConnectionInstance was not in the cache
becuse EntityOwnershipService event was not recieved by that non-owner instance.

Change-Id: I3861b5f2907d08709a3bd1aa4f4ecfbfd444351d
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>

Bug 4611: null pointer exception while processing interface event

Acl service needs to handle cases when port security info is not available.

Patch set 2: add unit test
Patch sets 3, 4: fix build

Change-Id: I788d31e4f0001fcf70caa59086d432b01178de1b
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

UT for remaining classes in ovsdb.southbound.ovsdb.transact

Change-Id: I7dfd78209e770c28a7ced22cea9308c5c9fe7ee8
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>

UT for ovsdb.southbound transact package

4. TerminationPointCreateCommand.java
5. TerminationPointUpdateCommand.java

Change-Id: I7647196548b676ada6a4fa902f60f7e71644901c
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>

Inline variables

Change-Id: I7999f158b755eb9b0a71bd38d3e065cc766f45a7
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Drop redundant type information

Change-Id: I030f911f2e699266b6f85af7a0185a4714e34fb1
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Fix up loops

Use foreach loops instead of explicit Iterators.
Use switch statements instead of mutually-exclusive if statements.

Change-Id: I2239a2f119686efc65ae062a95b4edbda99c5ded
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Boxing/unboxing clean-up

Change-Id: I9c0b9386a5befc58e0a93ad654e9fb8a8531e7bd
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Full <> clean-up

Change-Id: I23ce78b0cb4d2f253bc2d0ea8fe4833ff099e8b2
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Remove unused imports

Change-Id: Icdbeac2764322aebe8c903b5cc23fa3295b61d49
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Remove redundant semi-colons

Change-Id: I4a9d36022a333d90c2b3fc716d9aca9334c15a66
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Clean up enums

enums are static, and their constructors private, by default.

Change-Id: I6be729d10fa2e81b87a5a4afcc91ed1a30e3ea97
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Clean up collections

Use interfaces instead of concrete implementations where appropriate.
Use the Java 7 <> operator.
Avoid Lists.newArrayList() if new ArrayList<>() is sufficient.

Change-Id: I70ebe6ebc7c79f8d742fdd71fc6419461a7aaa65
Signed-off-by: Stephen Kitt <skitt@redhat.com>

BUG-4205 : VM delete doesnot remove all related flows

Change-Id: Ia3cbba3087232cb56eee6e5424cdd011a01ce266
Signed-off-by: bviswa <badrinath_viswanatha@dell.com>

Merge "Unit Test for ovsdb southbound OvsdbConnectionManager.java" into stable/lithium

Merge "Added unit tests for ovsdb/southbound lithium branch" into stable/lithium

Merge "Add UT for SouthboundMapper and SouthboundProvider" into stable/lithium

Ovsdb-UI : Change icon and attempt to fix invisible vxlan

- Change the icon for ones more appropriate.
- Attempt to solve the invisible vxlan when using
a "triange" vxlan topology.
- Change the logical dialog to be "half-static".
The position will be set one time and will keep the
last given instead of trying to appear near the related node.

Change-Id: I1bdd92a5b97c9f8638c5415391c02f3deb6d168a
Signed-off-by: Maxime Millette-Coulombe <mmcoulombe@inocybe.com>

Unit Test for ovsdb southbound OvsdbConnectionManager.java

- added UT for vsdbDataChangeListener.java (no need to cherry pick patch 27361

Change-Id: I272d716e3d8b3df9bdaea5fc0009c809c8e25933
Signed-off-by: rpujar <rpujar@inocybe.com>
(cherry picked from commit ef682a0e6a1b8a7fe4aa87a831729933c0d96856)

Added unit tests for ovsdb/southbound lithium branch

Change-Id: Iab67bab14a90ef39678756e7bd9c8852bf111f40
Signed-off-by: mserngawy <melserngawy@inocybe.com>
(cherry picked from commit cf3e86ebee7a42e212194d3e3f1bbbd6359e1f33)

Add UT for SouthboundMapper and SouthboundProvider

Change-Id: I38776516b120cc16d123d37dcafb8d19c6fd7e21
Signed-off-by: mserngawy <melserngawy@inocybe.com>
(cherry picked from commit 3a52bd31ce8fa9d9dd494811fe4441183414018d)

Bug 4546 - Southbound plugin throws java.lang.IllegalStateException
 while shutting down and loops forever

Change-Id: I71812a3cb008e43cfa5b0f9ce331fb2623983332
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>

UT for ovsdb.southbound transact package

1. TransactInvokerImpl.java
2. TransactCommandAggregator.java
3. TransactUtils.java

Change-Id: If360ba8f07a9715ff60225809fbc987afba59516
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>

Merge "Adding code to test the all the supportted interfaces by OVS-DPDK [dpdk, dpdkr, dpdkvhostuser,....others]" into stable/lithium

Adding code to test the all the supportted interfaces by OVS-DPDK [dpdk, dpdkr, dpdkvhostuser,....others]

Change-Id: Ied5750ef7ff095e13dcd731c8cfe25823620926e
Signed-off-by: Praveen Mala <praveen.mala@intel.com>

Adding code to test the OVS-DPDK datapath type: netdev

Change-Id: I599df4f0f910a1e7e18ee230ac562cbea6ac3b03
Signed-off-by: Praveen Mala <praveen.mala@intel.com>

Fix ovsdb-ui to use stable/lithium version of commons parent

ovsdb-ui incorrectly depends on a future version of commons parent
causing autorelease to fail the build.

Change-Id: I33ca52f542447f7eb069b89ec02b810d6badc001
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge "UT for southbound/transactions/md" into stable/lithium

Merge "UT for SouthboundUtil.java" into stable/lithium

Merge "UT for southbound/transactions/md - set 3" into stable/lithium

Merge "UT for southbound/transactions/md - set 2" into stable/lithium

Merge "Added Unit Tests for ovsdb/southbound" into stable/lithium

Merge "UT for southbound/transactions/md - set 5" into stable/lithium

Merge "UT for southbound/transactions/md - set 4" into stable/lithium

UT for southbound/transactions/md - set 5

11. OvsdbPortRemoveCommand.java
12. TransactionInvokerImpl.java
13. OvsdbPortUpdateCommand.java

Change-Id: Icd9ad76e482de5408650916f6bbf5bc73dc297c8
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>
(cherry picked from commit 26ed35648c8fcea96674a1f6e310f9d7930c09c8)

UT for southbound/transactions/md - set 4

8. OvsdbManagersUpdateCommand.java
9. OvsdbNodeRemoveCommand.java
10. OvsdbOperationalCommandAggregator.java

Change-Id: I4597340cb871fb6b8558f2632ad71423a3cb8176
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>
(cherry picked from commit ffa3c96aab514cfaba4e0eb543fe6956d3dfdb13)

UT for southbound/transactions/md - set 3

6. OvsdbControllerUpdateCommand.java
7. OvsdbManagersRemovedCommand.java

Change-Id: Idcb7ff1ad8f414cb243ae766e69d6437d0bee93f
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>
(cherry picked from commit ea32373f46715c41376f1473b121e5cc723c46f0)

UT for southbound/transactions/md - set 2

4. OvsdbBridgeUpdateCommand.java
5. OvsdbControllerRemovedCommand.java

Change-Id: Idc469c08351b1e98129dd9e798c07a660d782709
Signed-off-by: rpujar <rpujar@inocybe.com>
(cherry picked from commit cfcc6d4b4288e44bdbcb9de4cf5ac0de97f741f6)

UT for southbound/transactions/md

1. AbstractTransactionCommand.java
2. OpenVSwitchUpdateCommand.java
3. OvsdbBridgeRemovedCommand.java

Change-Id: I7655dec526bc06b770c533dd082eb403bc89a2c7
Signed-off-by: rpujar <rpujar@inocybe.com>
(cherry picked from commit ba1ac0433a93468260f0e00e693ba1a928c14e14)

UT for SouthboundUtil.java

Change-Id: I87e3577ab2f262ec7f50b6c185a41f49b1e607ed
Signed-off-by: rpujar <rpujar@inocybe.com>
(cherry picked from commit bf634aac7eb1da8021841fa05959762a2c6bf3ab)

Added Unit Tests for ovsdb/southbound

InstanceIdentifierCodecTest.java and OvsdbSchemaContantsTest.java

Change-Id: I91e356dfc6bfc41bac081b9792ff99bfc931c3ae
Signed-off-by: rpujar <rpujar@inocybe.com>
(cherry picked from commit a3372e6f62b7b3e9d00b0d1a73886464e6fc511a)

Unit test for ovsdb.southbound.ovsdb.transact

Change-Id: I200bf945bf2d8875d5e8de23c101420092a9161e
Signed-off-by: Mohamed El-Serngawy <melserngawy@inocybe.com>

If node joins the cluster after application master instance
is selected, it doesn't get any notification about the ownership
change of the application, so it does not initiate the ovsdb manager,
It should check if any other instance is master instance,
if yes, consider itself slave and start the Ovsdb Manager.

Patch 2: Register entity ASAP, to minimize the delta for missing
ownership change notifications

Change-Id: Iea205de0a760f3e03962bb889e82acacfbf2247b
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>

Merge changes I4a00740f,I31fad80f into stable/lithium

* changes:
  All TCP & UDP SG Rules : Implementation and Unit tests added.
  Custom ICMP SG Rule: 1)Modification in ICMP matcher 2)Unit Test Improvement (Check added to validate if some values are set properly).

Merge "Bug 4472 - netvirt: IlligalArgumentException in NAT provider" into stable/lithium

All TCP & UDP SG Rules : Implementation and Unit tests added.

Change-Id: I4a00740fed78ab416fe22214fa7542ae7036f6fc
Signed-off-by: sangeeta.maurya <sangeeta.maurya@hp.com>

Custom ICMP SG Rule:
1)Modification in ICMP matcher
2)Unit Test Improvement (Check added to validate if some values are set
properly).

Change-Id: I31fad80f6dd278372abe2b1a6aac95935aef5f17
Signed-off-by: sangeeta.maurya <sangeeta.maurya@hp.com>
(cherry picked from commit 99f9a373e9bc410933421692148b87f177ab4879)

Added Security Rule for Custom ICMP

Change-Id: I5f813b3695c2fd21e03a0ccf215e49b891059154
Signed-off-by: sangeeta.maurya <sangeeta.maurya@hp.com>
(cherry picked from commit 055d8e4b6b06dabd5b2c9949d9ee1b96b6abb39e)

Bug 4472 - netvirt: IlligalArgumentException in NAT provider

This patch adds work around code for ipv6 cidr notation is given.
Otherwise following exception occurs.

> 2015-10-14 13:38:55,125 | ERROR | ntDispatcherImpl | NeutronL3Adapter                 | 392 - org.opendaylight.ovsdb.openstack.net-virt - 1.2.1.SNAPSHOT | ProgramRouterInterface failed for mac:FA:16:3E:E0:A8:B5 addr:fd14:5ac7:ba3::1/64 node:ovsdb://uuid/8f75c49c-52b9-4303-8633-a80f0361429b/bridge/br-int srcTunId:external destTunId:1083 action:ADD status:Not Implemented: Not Implemented (0)
> 2015-10-14 13:38:55,126 | DEBUG | ntDispatcherImpl | ArpResponderService              | 393 - org.opendaylight.ovsdb.openstack.net-virt-providers - 1.2.1.SNAPSHOT | ipv6 address case is not implemented yet. dpid 209308480409166 segmentationId 1083 macAddressStr, ipAddress FA:16:3E:E0:A8:B5 action /fd14:5ac7:ba3:0:0:0:0:1
> 2015-10-14 13:38:55,126 | ERROR | ntDispatcherImpl | NeutronL3Adapter                 | 392 - org.opendaylight.ovsdb.openstack.net-virt - 1.2.1.SNAPSHOT | ProgramStaticArp failed for mac:FA:16:3E:E0:A8:B5 addr:fd14:5ac7:ba3::1 dpid:209308480409166 segOrOfPort:1083 action:ADD status:Not Implemented: Not Implemented (0)
> 2015-10-14 13:38:55,126 | ERROR | ntDispatcherImpl | EventDispatcher                  | 392 - org.opendaylight.ovsdb.openstack.net-virt - 1.2.1.SNAPSHOT | Exception in dispatching event NorthboundEvent [handler=NEUTRON_PORT, action=ADD, port=NeutronPort [portUUID=4b19acf4-d644-4fe7-8643-852c25cbf604, networkUUID=821f7a2b-b991-48b0-a39c-b0ef264bd321, name=, adminStateUp=true, status=ACTIVE, macAddress=FA:16:3E:E0:A8:B5, fixedIPs=[Neutron_IPs{ipAddress='fd14:5ac7:ba3::1', subnetUUID='54a7f233-1fdb-4d40-bd44-275f180e9a64'}], deviceID=738d6a7c-43bd-469d-bfed-6bcc6ffe5dca, deviceOwner=network:router_interface, tenantID=dc27e3a1cff64a1cb85c7f24899c3eee, securityGroups=[], bindinghostID=, bindingvnicType=normal, bindingvnicType=normal], subnet=null, router=null, routerInterface=null, floatingIP=null, network=null, loadBalancer=null, loadBalancerPool=null, loadBalancerPoolMember=null]
> java.lang.IllegalArgumentException: Supplied value "fd14:5ac7:ba3::/64" does not match required pattern "^(([0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])\.){3}([0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])/(([0-9])|([1-2][0-9])|(3[0-2]))$"
>         at com.google.common.base.Preconditions.checkArgument(Preconditions.java:145)[64:com.google.guava:18.0.0]
>         at org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev100924.Ipv4Prefix.<init>(Ipv4Prefix.java:49)[216:org.opendaylight.mdsal.model.ietf-inet-types:2010.9.24.8-SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.providers.openflow13.services.OutboundNatService.programIpRewriteExclusion(OutboundNatService.java:167)[393:org.opendaylight.ovsdb.openstack.net-virt-providers:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.NeutronL3Adapter.programIpRewriteExclusionStage2(NeutronL3Adapter.java:1143)[392:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.NeutronL3Adapter.programIpRewriteExclusionStage1(NeutronL3Adapter.java:1128)[392:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.NeutronL3Adapter.programFlowsForNeutronRouterInterface(NeutronL3Adapter.java:807)[392:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.NeutronL3Adapter.handleNeutronRouterInterfaceEvent(NeutronL3Adapter.java:298)[392:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.NeutronL3Adapter.handleNeutronPortEvent(NeutronL3Adapter.java:245)[392:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.PortHandler.doNeutronPortCreated(PortHandler.java:66)[392:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.PortHandler.processEvent(PortHandler.java:161)[392:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.EventDispatcherImpl.dispatchEvent(EventDispatcherImpl.java:95)[392:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.EventDispatcherImpl.access$200(EventDispatcherImpl.java:28)[392:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.EventDispatcherImpl$1.run(EventDispatcherImpl.java:57)[392:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[:1.8.0_60]
>         at java.util.concurrent.FutureTask.run(FutureTask.java:266)[:1.8.0_60]
>         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)[:1.8.0_60]
>         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)[:1.8.0_60]
>         at java.lang.Thread.run(Thread.java:745)[:1.8.0_60]

Change-Id: I1559667adde1c14b5627df3b7212e404998ce897
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Merge "First pass for ovsdb-ui" into stable/lithium

First pass for ovsdb-ui

Revamp of the work already done. Adding a draft of a
logical topology viewer. The old code is still in this
commit because the works done before will be reuse.

Change-Id: Ia3a86cb0370cfad2ef3c2a156b412b9e029c3bf9
Signed-off-by: Maxime Millette-Coulombe <mmcoulombe@inocybe.com>

Workaround to fix net-virt-it

Change-Id: I10838b993f60b5e3859780d7d9f7b4c3630e312a
Signed-off-by: Sam Hague <shague@redhat.com>