Bump versions to 4.0.0-SNAPSHOT

Prepare master for next incompatible release stream.

Change-Id: I7fc3219f6439c73f39e946123803f225be98dbb9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 3.1.0-SNAPSHOT

In preparation for 3.1.x branch, bump versions on master.

Change-Id: I568e9b5536809d5b90018862fb6c737cc0ead77d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump jersey-1.x to 1.19.4 and package it

Rather than relying on downstreams doing their own packaging
of jersey, provide proper package of basic dependencies in a feature.

Change-Id: I576008ca9e9d6673f5f5d3ffc4081d9943b634e7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Align jetty version with karaf

karaf is pulling in version 9.3.21, while we are advertizing
9.2.19 -- which leads to odl-karaf-feat-jetty not squashing
dependencies in features.

Change-Id: I914d9a3c2c83426d58e6d4f8f5def9d7d29f6114
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump karaf to 4.1.4

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311140&version=12341702

of which most notable is jetty version alignment.

Change-Id: I23d74258d40635d78b20c4c3fe9e61f3f1c8ddd2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

find-duplicate-classpath-entries in phase verify

instead of already during validate, because that's too early

https://lists.opendaylight.org/pipermail/odlparent-dev/2018-January/001597.html
https://lists.opendaylight.org/pipermail/odlparent-dev/2018-January/001589.html

Change-Id: I0e3ad52a3b8bc7175a2e98e320667a74001f54ae
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Use jackson-bom to declare jackson dependencies

Importing jackson-bom declares all jackson components versions
in a consistent set.

Change-Id: I839db437eb965925b6a4cd3dd572e7e81df7e10f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

add org.osgi.compendium to features-test

fixes SFT bug ODLPARENT-136
java.lang.ClassNotFoundException:
org.osgi.service.resolver.ResolutionException

Change-Id: Ifaa39b35d1975ccd2aec15f6ed56191637f43d73
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Start 3.0.3-SNAPSHOT

Change-Id: Ie676ecbb5c74d7db8654cecb56e25c51d9156f80
Signed-off-by: Stephen Kitt <skitt@redhat.com>

odlparent 3.0.2 release notes

Change-Id: Ic8bc02873149704d7673f2d8d594ffcd32416562
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Use default upstream logging configuration

Now that Karaf uses Log4J2, our custom configuration no longer works;
this patch uses the default upstream setup for the time being.

Change-Id: I1786d9f50d60a030dc3b265fdb70dc5130806c1a
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump javadoc plugin to 3.0.0

Proper release is now available, bump to it:
https://mail-archives.apache.org/mod_mbox/maven-announce/201712.mbox/%3Cop.zaufhhzukdkhrr%40desktop-2khsk44.mshome.net%3E

Change-Id: Icbb6bc02496e937320424a1ec8a4edac0ca09478
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove JavaDoc <links> from odlparent

because all of these, and more, are already in odlparent-lite now

see also https://jira.opendaylight.org/browse/ODLPARENT-121

This change does NOT fix that performance problem; only
change I4ca0c9e81985c2827e16654e9d9413c7d93f6068 does that,
whereas this one is just a clean up I stumbled upon.

Change-Id: Ifd66f318dfc3b900ad6fe06fa26e80932783cce8
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Disable hiddenField check for abstract methods

There is a valid use case, where we are forwarding a private field
to an abstract method. This clearly does not hide the field, as it
is invisible to subclasses -- hence disable HiddenField on abstract
methods.

Change-Id: I00adfce58eea65660cae06649168a09a560713a4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

ODLPARENT-134: ensure correct startup with BC

In Karaf 4.1, Bouncy Castle no longer starts correctly; or rather,
loading kpix results in prov being refreshed, which restarts sshd and
most of Karaf.

This patch cleans up the startup.properties construction, and enforces
the correct order for Bouncy Castle. It also adds metatype and
blueprint.core.compatibility which must be loaded at boot to avoid
unwanted refreshes.

Change-Id: Ic8e8e0e932b9d9eaea292003118ef1936b67b822
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Add a javadoc-links profile

... to build with external links (which adds substantial time to the
build).

Change-Id: Iea9adc7ed49ae39609ecd5d6bd012a35fe36fc81
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump maven-enforcer-plugin 1.4.1 => 3.0.0-M1

https://mail-archives.apache.org/mod_mbox/maven-announce/201707.mbox/%3Cop.y37atexzkdkhrr%40desktop-2khsk44%3E

Change-Id: I290370bb6619a6fe7c809646995877f73dd891a7
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

ODLPARENT-133: process conditional dependencies

Karaf 4.1 uses many more conditional dependencies in its features,
which results in a distribution missing many dependencies which we
actually need. This patch adds conditional bundle processing to
PopulateLocalRepoMojo, resulting in a distribution where all
dependencies are available, regardless of the conditions.

Change-Id: Ic9eb2befbed066a486603f28c38d32a7e951dd9f
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Comment out JavaDoc <links> for build perf

see https://jira.opendaylight.org/browse/ODLPARENT-121

Change-Id: I4ca0c9e81985c2827e16654e9d9413c7d93f6068
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Use getClass() in equals(), and simplify

Using getClass() enforces the equals() symmetry contract without
having to be careful with subclasses (which is fine since the classes
are final), and is also slightly faster.

Change-Id: I02dcb453c08f1139713b5d72629c2ab98c1ce86f
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Avoid unnecessary copies of data structures

In BundleDiagInfosImpl, the constructor is private, and forContext
creates new instances of the collections stored in the resulting
object specifically for that object; there’s no point in making
immutable *copies*.

Change-Id: I453cd97e957248a6f074ce292e685470e2f6973c
Signed-off-by: Stephen Kitt <skitt@redhat.com>

BundleDiagInfos with getBundlesStateMap()

Allows infrautils.ready to offer infrautils.diagstatus per bundle infos

see https://jira.opendaylight.org/browse/INFRAUTILS-27

Change-Id: Ib2c529ac0d7d812148b8673c773d439e155c6224
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

bundles-test-lib with BundleDiagInfos

instead of BundleDiagInfosImpl (drop the *Impl, where possible)

Change-Id: I65046338016d77409e667a644f19bd3397ce8a0a
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

TestBundleDiag with configurable await logging

Allows infrautils.ready to make TestBundleDiag INFO log less verbose

The full list of NOK bundles during boot caused confusion, even if INFO

see https://jira.opendaylight.org/browse/INFRAUTILS-17

Change-Id: Iad1badb29e6a061812640a9182973d7c2b679836
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Fix SFT for Archetype Self Test

This sets the Pax Exam URL Maven localRepository so that the
SingleFeatureTest of the Archetype in controller works, even if
there is a -Dmaven.repo.local=, such as on Gerrit.

see https://jira.opendaylight.org/browse/CONTROLLER-1799

Change-Id: Idd6126944518bab0fa0b886a7012ea94aba3126e
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Start 3.0.2-SNAPSHOT

Change-Id: If127110ae6f0acc181966f748b5768f6461c1405
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Release notes for 3.0.1

Change-Id: I2df6a518158836bc4e0d67e1e0bac721d8471a42
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Workaround broken upstream features

hibernate-validator-osgi-karaf-features-[5.3.4,5.4.2) is broken
due to invalid maven URL reference. Add hard exception to fix it up.

Change-Id: I6cc28817b721fd7fa6f7dd940c82a4b80acb81c2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Pre-compile FeatureUtil replacement patterns

When we are discovering features, we end up converting a lot of URLs,
hence we end up recompiling the same patterns over and over again.

Rather than doing that, keep pre-compiled versions and reuse them.

Change-Id: I6b0b2b9e3c6ba9a13d20b7e16b4284feee222797
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add a test distribution to test karaf4-parent

This adds a simple distribution, containing just odl-guava.

Change-Id: I65a9d85238f358072d595e7523a17f2a6eab8fc6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Start 3.0.1-SNAPSHOT

Change-Id: I9be70dcdef4b95a98095df72f7bb5e4eafb7ef59
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bug 7756 Bind web services to single port

Right now, we mirror web service offerings on ports 8080 and 8181.
There has been much discussion surrounding consolidating on a single
port.  See these email threads:

https://lists.opendaylight.org/pipermail/release/2017-February/009244.html
https://lists.opendaylight.org/pipermail/controller-dev/2016-September/012677.html

Based on community feedback, it would appear that most people utilize
port 8181, and it would take a LOT of work to change that. Thus, this
change removes the port 8080 offering. If downstream consumers still
wish to use web services on port 8080, then can simply re-add the
connector in etc/jetty.xml without recompiling (will require karaf
container restart to reinitialize pax-web).

This is just a change to the default offering, and makes the ODL
platform a bit more consistent OOB.

Change-Id: I62ccf4a8f9719c7923f06204955239ceea8a780f
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

ODL Parent 3.0.0 release notes

... and supporting Sphinx framework.

Change-Id: Ifa6a8ec9f159aa855868509de588d30f671d2680
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Add missing M2E lifecycle mappings metadata

* Ignore for the duplicate-finder-maven-plugin

Not sure why I have to repeat here what I had done back in January in
https://github.com/vorburger/opendaylight-eclipse-setup/commit/abf867c9a1e58686b79214c9381adcb0e224b3b6
but I can only strongly encourage all ODL developers using Eclipse to
use the opendaylight-eclipse-setup model.

also make bundles-test-lib enable the dupe CP finder (and PMD CPD),
because that actually made the problem appear under Eclipse within
odlparent - after manually locally removing the equivalent in
lifecycle-mapping-metadata.xml by opendaylight-eclipse-setup.

see also I3498cc5f3af7481cd83b4f7f69045d19668fd1da

Change-Id: I2bfbfc05600814df1fa5c866e1db3cbe2576959c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Add missing M2E lifecycle mappings metadata

* Ignore for the karaf-maven-plugin

This change does intentionally NOT include a lifecycle mapping for the
(new) spotbugs-maven-plugin, because that's one which we do NOT want to
just IGNORE, but have to configure; re. that one, please watch
https://github.com/m2e-code-quality/m2e-code-quality/issues/110

FTR: Originally I started putting these (only) into
opendaylight-eclipse-setup, because "such Eclipse specifics should not
be in our POM", but today on IRC rovarga opined that "it should 'just
work' even if one doesn't want to use your opendaylight-eclipse-setup"
but why? its great!] so putting there here now - meaning we have a bit
of a mix now, but I guess this isn't the end of the world.

see https://github.com/vorburger/opendaylight-eclipse-setup#how-to-add-additional-m2e-lifecycle-mapping

Change-Id: I3498cc5f3af7481cd83b4f7f69045d19668fd1da
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Dependency check: avoid dependency loops

Exclude all org.opendaylight dependencies to avoid introducing
dependency loops with dependency management on third-party artifacts
re-packaged in ODL projects.

Change-Id: I19a235e395f4b8e89e86a054d4e266cc8e101905
Signed-off-by: Stephen Kitt <skitt@redhat.com>

BUG-9202: update maven-javadoc-plugin

Required to make build work with Java 9, release notes are at
https://mail-archives.apache.org/mod_mbox/maven-announce/201707.mbox/%3Cop.y3p20je4kdkhrr%40desktop-2khsk44%3E

Change-Id: I46d348026a41587a04ebc6508fcc649dd5be9a48
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

SFT needs Karaf branding

For some reason SFT now needs our Karaf branding. We should fix this
so that it’s no longer the case — see
https://jira.opendaylight.org/browse/ODLPARENT-130 — but in the
interest of getting odlparent 3.0.0 out, this adds an explicit test
dependency.

Change-Id: I548e421a63073503be47d239cd9536306ab92bd9
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Add a dependency check to validate management

To avoid issues such as the invalid uncommon-maths version bump, add a
module whose sole purpose is to depend on all artifacts specified in
dependency management in odlparent. This ensures that the artifacts
are actually available.

Remove two artifacts which don’t exist (and aren’t used anywhere):
* ssl-config-akka_2.12
* jetty-servlet-tester

Change-Id: Ia18132fb45eb5f87afdc0d63ac3fff4f2caaf04c
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Don’t exclude pax-url-commons from pax-url-wrap

Excluding pax-url-commons from pax-url-wrap means that anything
depending on -wrap without -aether fails (including karaf-plugin).

Change-Id: I861f63caac4fdf6405174df4e05e6242d747b2b5
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Remove io.dropwizard.metrics dependencyManagement

https://lists.opendaylight.org/pipermail/odlparent-dev/2017-November/001460.html

for https://jira.opendaylight.org/browse/INFRAUTILS-19

Change-Id: I0ce0e4b7ad54e171c061e1bb91d568b25e9d1145
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Fail build if classpath contains duplicates

duplicate-finder-maven-plugin fails build if duplicate classpath entries
see https://github.com/basepom/duplicate-finder-maven-plugin/

This is currently not enforced, but projects opt-in to this quality via:

  <properties><duplicate-finder.skip>false

FTR: There are a few other tools in this space, incl. e.g.
http://www.mojohaus.org/extra-enforcer-rules/banDuplicateClasses.html
and http://tattletale.jboss.org/ and http://jhades.github.io, but
duplicate-finder-maven-plugin fits best here.

See https://git.opendaylight.org/gerrit/#/c/50851/ for a related util.

Bug: 7662
Change-Id: I79142549ba7c739ce39285d35f179172d7b099a6
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump jacoco to 0.7.9

https://github.com/jacoco/jacoco/releases/tag/v0.7.8
https://github.com/jacoco/jacoco/releases/tag/v0.7.9

Change-Id: Iced1a38897da53fcf80d2cde4ee76baa93cd8242
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Checkstyle InnerAssignment"

This reverts commit c115daf2f2548b49b505a12fb3ab26c7e096dd8c.

The Checkstyle InnerAssignment check only handles a subset of cases,
which ends up being confusing.
(E.g. while() { }, but not do { } while().)

Change-Id: I813679f18214e8729bc588ae4e0987579b0e3786
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Revert "Bump Uncommons Maths 1.2.2a → 1.2.3"

This reverts commit cf236575fa87a2928bb83393bb9e5355b8eedd01.

Version 1.2.3 isn’t available on Maven Central...

Change-Id: If524032a85f17dee7a553e5e27cdeb9816904af6
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Revert "Checkstyle TrailingComment, Sonar aligned"

This reverts commit f7680f6a688e26e28515c907328c52d0a35a4515.

This code format convention is actually stupid IMHO after all.
For example, I really do like this a lot more:

  @SuppressFBWarnings("SE_BAD_FIELD") // Runnable is not Serializable
  private final TrackingLinkedBlockingQueue<Runnable> backingQueue;

than being forced by Checkstyle to have to write this:

  // Runnable is not Serializable
  @SuppressFBWarnings("SE_BAD_FIELD")
  private final TrackingLinkedBlockingQueue<Runnable> backingQueue;

We should change Sonar's configuraiton, not enforce this in odlparent.

Change-Id: Ib3a8708a7a4b43bb72859f69aca33aafb8b6080c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump scala to 2.12.4

https://github.com/scala/scala/releases/tag/v2.12.4

Change-Id: Id179520eb109053dd99197f5f9665d6be6d40bab
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add -Xlint:deprecation

We do need to clean up callers of deprecated methods. Make sure
we emit details during build.

Change-Id: I3259edafcf0f54b087b38f5270cf67009a0fd885
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Awaitility 2 → 3

Release notes:
https://github.com/awaitility/awaitility/wiki/ReleaseNotes30

Change-Id: Iee993116d976a6f61104681e055e8d5f60575895
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump Felix dependencies

Dependency Manager 4.3.0 → 4.4.1
Dependency Manager Shell 4.0.4 → 4.0.6
Metatype 1.1.2 → 1.1.6

Release notes are few and far between...

Change-Id: Ib13e01ad62ba31d30b8efe20fab10d1564337bd7
Signed-off-by: Stephen Kitt <skitt@redhat.com>

maven-compiler-plugin showWarnings

This won't break anything, just spew a few more logs, which MAYBE *some*
people will start looking it.  I will be enabled with the upcoming
proposed error-prone integration anyway, so we may as well make a start
with it now, even before getting error-prone in.

Change-Id: Ica17b1a250562c0f083ed252d921dc86278abd3b
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump webcohesion enunciate 2.6.0 → 2.10.1

Release notes: https://github.com/stoicflame/enunciate/releases

Change-Id: Id60106cd18b822eb84589bc4bf7c2e9e35c577e8
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Remove obsolete dependency management entries

Remove a number of dependencies which are no longer used:
* xml-apis
* Xerces
* txw2
* Eclipse Link
* Gemini Web
* Orbit
* Felix File Install and Web Console
* Equinox HTTP service bridge
* Chameleon MBeans
* Spring Framework

Change-Id: Icbc4368941f109e7b835323b2dfbcef0b335e8bb
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Checkstyle InnerAssignment

see http://checkstyle.sourceforge.net/config_coding.html#InnerAssignment

Change-Id: Icaaaa3ff3a08843b2ed1bf013edf7110b49b547c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump Uncommons Maths 1.2.2a → 1.2.3

This version adds OSGi bundle information:
https://maths.uncommons.org/changelog.php

Change-Id: I379e8d857f936f4471a1529adb0f3cc363d20d3e
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump logback 1.2.2 → 1.2.3

Release notes: https://logback.qos.ch/news.html

Change-Id: If03272caf0a419541d1e4203539a83b85622737b
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump gson 2.7 → 2.8.2

Release notes: https://github.com/google/gson/blob/master/CHANGELOG.md

Change-Id: If6c7369442a68ce9d2545010335cb422d2f45238
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump lmax disruptor 3.3.6 → 3.3.7

Release notes: https://github.com/LMAX-Exchange/disruptor/releases/tag/3.3.7

Change-Id: I0fd240efa3d24fb524961cfed01ebf091650adb7
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump commons-fileupload 1.3.2 → 1.3.3

Release notes:
http://www.apache.org/dist/commons/fileupload/RELEASE-NOTES.txt

Change-Id: Ic18fec72aea51fe33debd160b03d984e512ecbed
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump commons-io 2.5 → 2.6

Release notes: http://www.apache.org/dist/commons/io/RELEASE-NOTES.txt

This version is now a Java 9 module.

Change-Id: Ie5ca856b636347927d4bf9e3d1fd824d79b02a8d
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump JSONassert 1.3.0 → 1.5.0

Release notes: https://github.com/skyscreamer/JSONassert/releases

Change-Id: I5d066a5168a22d1b56b61e19d9582deacf9f21a9
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump SLF4J 1.7.21 → 1.7.25

Release notes: https://www.slf4j.org/news.html

Change-Id: I8092ba8f07824c8433774898c24d25d5e3510680
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump Karaf 4.1.2 → 4.1.3

Change-Id: Ia3eb52ca11cc3e3e870badf469ef8ead7294d031
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

BUG-8258: Bump karaf 4.1.2

This is a straightforward upgrade from 4.0.9 to 4.1.2 and will need
to be updated to 4.1.3.

Change-Id: I9275dd42e53dec3e46bc169b6aafb5cb75b40753
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump Coda Hale Metrics 3.1.2 → 3.2.3

Release notes:
http://metrics.dropwizard.io/3.2.3/about/release-notes.html

Change-Id: I723e77d1907fc6dde8724f8236ee9c545a20ebbe
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump checkstyle 8.2 → 8.4

Release notes:
http://checkstyle.sourceforge.net/releasenotes.html#Release_8.4

Change-Id: Ibf0f3079d0c7911c1106d8dbbbf7a4f32037dc8b
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Add support for local feature files

Karaf 4.1 introduces local feature files for some dependencies. This
patch adjusts populate-local-repo so that it copes with them instead
of crashing.

Change-Id: Ia709011d928abd4994346fde5002c3ff35fe874a
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump Xtend 2.12 → 2.13

Release notes: https://www.eclipse.org/xtend/releasenotes.html

Change-Id: I97f878b8904dc83b04c78e9759d38adf48116b64
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump Google Truth 0.28 → 0.36

Release notes: https://github.com/google/truth/releases

This also enables the Java 8 extensions.

Change-Id: If374852847f0669d03cd08f6a541465cfbc6bd95
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump guava to 23.3-jre

https://github.com/google/guava/releases/tag/v23.3

Change-Id: I887206256c1f4ed611dc350eac3bf887fab6f72e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Checkstyle HiddenField

see http://checkstyle.sourceforge.net/config_coding.html#HiddenField

Change-Id: I7c25835837e63a9580a9f870d2c1d7cef9e2f57d
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Checkstyle TrailingComment, aligned with Sonar

http://checkstyle.sourceforge.net/config_misc.html#TrailingComment

Change-Id: I063cc5b40b561292d3d412d595669851b29951bb
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

BUG-9201: bump maven-enforcer-plugin to 3.0.0-M1

This is required for building with Java 9. Release notes are at:
http://maven.40175.n5.nabble.com/ANN-Apache-Maven-Enforcer-Plugin-3-0-0-M1-Released-td5911744.html

Change-Id: I4b32b3703efea41aed8e3e685896c8fcbd13b4f9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

BUG-9200: upgrade maven-shade-plugin

Version 3.1.0 is required for Java 9, release notes at:
https://mail-archives.apache.org/mod_mbox/maven-announce/201708.mbox/raw/%3Cop.y5d393zfkdkhrr%40desktop-2khsk44.dynamic.ziggo.nl%3E/

Change-Id: I5892cba22d1f50708b219aaee35be5ed2af2d2ec
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

BUG-9200: update failsafe/surefire plugin version

Version 2.20.1 is required to support Java 9, changelogs are at
https://mail-archives.apache.org/mod_mbox/maven-announce/201709.mbox/%3CCAKuVzBTt6gPWkjDS7AcLBKj7C1i9C7CgjRa3s0mQ0S-P%3D3CiiQ%40mail.gmail.com%3E

Change-Id: I08c48631b3ddcec3d36476e759d16f49a1c0a70f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump commons-codec 1.10 → 1.11

Release notes: http://www.apache.org/dist/commons/codec/RELEASE-NOTES.txt

Change-Id: I402e984c90e9f59b65c06244a8bade3e2156db6c
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Remove deploy-site.xml

With the javadoc jobs now available to generate javadoc it is time to
remove the maven-sites and related files.

Change-Id: If751fe5cf6c4b122063699f4ac234c25fc8daffb
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Switch bundles4-test from FindBugs to SpotBug

Change-Id: I4d4a92d3800a1b23705f8cac3d24c44dfcc01950
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Add SpotBugs dependencies

SpotBugs is the maintained replacement for FindBugs, which has been
abandoned. See https://spotbugs.github.io/ for details.

This patch is phase 1 of the (long-term) migration from FindBugs to
SpotBugs: it adds the spotbugs-maven-plugin to plugin management with
the appropriate version specifications and default configuration.

Change-Id: I29a47604bdd25a20dc0fe56f41cd0083ad934e13
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump Guava to 23.2-jre

https://github.com/google/guava/releases/tag/v23.1
https://github.com/google/guava/releases/tag/v23.2

Change-Id: I6c9992ad6caf1810359a79203038aaf79a5c8eb5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Exclude jsr305 from guava-testlib

... in the same way as for guava itself. Otherwise our own enforcer
fails builds...

Change-Id: Ibecbbf48c9045c290d439f3666f01fde519b842f
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump pax-url 2.5.2 → 2.5.3

Release notes:
https://ops4j1.jira.com/browse/PAXURL-345?jql=project%20%3D%20PAXURL%20AND%20fixVersion%20%3D%202.5.3
(in particular, this addresses CVE-2015-5262).

Change-Id: I2c7bfdb9139ae15573fc9d92f47d28a14ef0e345
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump netty to 4.1.16

http://netty.io/news/2017/09/25/4-0-52-Final-4-1-16-Final.html

Change-Id: I327ac3968dd3421a20f514a70a25002f7aebfbd5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump reactive-streams to 1.0.1

No changes, just clarifications according to
http://www.reactive-streams.org/announce-1.0.1

Change-Id: I9932ef2ede27cce4bae61ab7332c3f5746e2e27e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bug 9229:  Bump bouncycastle from 1.57 to 1.58

Release notes can be found here:
https://www.bouncycastle.org/releasenotes.html

Change-Id: Ie686001b8f02a08ee9f94a8e34c8079a8222366d
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

Bug 9169: Bump jdt.annotation from 2.0.0 to 2.1.0

Most importantly, this introduces a handy util for legacy interop
org.eclipse.jdt.annotation.Checks; see its JavaDoc on:
https://help.eclipse.org/neon/index.jsp?topic=%2Forg.eclipse.jdt.doc.isv%2Freference%2Fapi%2Forg%2Feclipse%2Fjdt%2Fannotation%2FChecks.html

Full git change log with more details available on
https://gist.github.com/vorburger/0479be76f9cd3d10aa5ef86d4034a090

I'm starting to explore using org.eclipse.jdt.annotation more, and want
to have its latest version at my disposal for this.  This is part of
https://git.opendaylight.org/gerrit/#/c/47370/ but that's bigger and
still WIP and it would be great if you would agree to get this one in
already now.

This should be very low risk and not break anything anywhere.

Change-Id: Ib1f6389cc0929e08d1585efc7bdc5e75097a3544
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump maven-compiler-plugin from 3.6.1 to 3.7.0

This also removes a number of uses of the
maven-compiler-plugin and maven-surefire-plugin
from project with odlparent-lite as parent, which
should not require these two plugins.

Change-Id: Iec5ad374633903cdcda6344eb736ec337f727a1d
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bug 9228: Package bcprov-ext-jdk15on jar

Bouncycastle is hotwired as the default JCE provider in ODL
since it has greater capabilities than those provided with
the default Oracle and OpenJDK JCE implementations.  This
change adds an overlooked and missing jar to the existing
provider infra.

Change-Id: I16cdab1d838285b3d690c61ae9fb3586e8cc69d3
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

Bump maven-dependency-plugin from 3.0.1 to 3.0.2

Change-Id: Ib3d7831d2c62bbd1d8b5da1302454f6793c4b554
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

BUG-9161: Bump karaf to 4.0.10

Upstream has delivered a speed up in initial repository indexing
and couple of other fixes. Bump karaf version to consume them.

Release notes:
https://github.com/apache/karaf/commit/a16c3b095a6f17fb3641c98cbe56b7e9f69418c5

Change-Id: I1a632c51e8af62802473afb3d314743f5ca31cfc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit b0e04a0c274d86ea3dbbd71f85ec148c383458f2)

maven-archetype-plugin pluginManagement

The new version property introduced here will be used in controller.

Change-Id: Idf0859ee1be990c130735ca93dabf2e7557703a7
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump Checkstyle core from 7.6.1 to 8.2

and Sevntu from 1.21.0 to 1.24.2 (note the required change in groupId)

also includes removal of LeftCurly.maxLineLength = 100, which is not
supported (anymore; or -more likely- never was, probably the validation
just became stricter)

and removal of a duplicate RightCurly, which was always wrong

and required fixes to odlparent Java code showing violations now

Change-Id: I3efc1d2e97c87a9c072b3fe097cf388f5a457cf5
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Eliminate scala.version and scala.micro.version

These properties are interfering with scala-maven-plugin, which is
using scala.version to control target versions.

Change-Id: I501cd941b35f2c0ca738209ca2db1c722743b2e8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump akka to 2.5.4

http://akka.io/blog/news/2017/08/10/akka-2.5.4-released

Change-Id: Ib22206bdaf1c0aa4a218d33ecf8335f718868bc7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump netty to 4.1.15

http://netty.io/news/2017/08/25/4-0-51-Final-4-1-15-Final.html

Change-Id: Icc6415af8d73ab22f75fceb9f7d3fd574d3ebd0a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add net.sf.jung dependency declaration

Downstreams are using an old revision backaged from controller,
which is completely out-dated. Add a dependency declaration and
a proper feature.

Change-Id: I77b1e42aa8a21d94f96a967c0c21af497a65f18e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Checkstyle AvoidHidingCauseExceptionCheck

http://sevntu-checkstyle.github.io/sevntu.checkstyle/apidocs/com/github/sevntu/checkstyle/checks/coding/AvoidHidingCauseExceptionCheck.html

Change-Id: I37d22c88869911f26daad023d66c5559a3cd1fa8
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

CS new FinalClass & HideUtilityClassConstructor

* http://checkstyle.sourceforge.net/config_design.html#FinalClass
* http://checkstyle.sourceforge.net/config_design.html#HideUtilityClassConstructor

Change-Id: I4ab4d4550c2bba4e25a19cae7a0c20aa1241757e
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Remove & forbid mockito-all + findbugs:jsr305

via the maven-enforcer-plugin

as all projects should only use findbugs:annotations, to avoid duplicate
classpath entries from FindBugs annotations which are present in both
:jsr305 as well as :annotations (which is more recent, bigger, and
maintained)

https://git.opendaylight.org/gerrit/#/q/topic:bug/7663, which replaces
all current existing usages of findbugs:jsr305 by :annotations in ODL
project, is the 1st pre-req. to this change.

https://git.opendaylight.org/gerrit/#/c/47337/, which changes the
dependencyManagement re. FindBugs, is the 2nd pre-req. to this change.

Related to Bug 7663 & Bug 7662.

Change-Id: Ifcd9c833af37fe52182dbc8604978fb82cdbcba7
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Add karaf.shell.core dependencyManagement

see also https://github.com/apache/karaf/pull/338

Change-Id: Ia1e732dfe5b83b5795bf022d8bdd89417f0c0d62
Signed-off-by: Michael Vorburger <vorburger@redhat.com>