Sam Hague [Wed, 14 Oct 2015 14:49:05 +0000 (10:49 -0400)]
add ovsdb-sfc feature to test feature
Change-Id: I55c2df5791983998f696054b7728b7d1be696e33
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Wed, 14 Oct 2015 04:23:59 +0000 (00:23 -0400)]
Workaround to fix net-virt-it
Change-Id: I10838b993f60b5e3859780d7d9f7b4c3630e312a
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Tue, 13 Oct 2015 00:50:25 +0000 (20:50 -0400)]
Temp workaround to debug southbound IT
It is a timing change from the clustering code not taking into account some crazy existing code.
This patch has a workaround that works in my local tests. I will merge it temporarily to see if the jenkins builds are good.
Will work with Anil and Flavio on a long term solution.
Old code:
write ovsdb node to config ->
-> dcl ->
-> connect -> connect -> connectedButCallbacksNotRegistered -> putConnectionInstance
-> updateData -> OvsdbNodeUpdateCommand - > ovsdb node - set Open_vSwitch external_ids
*** key here is that the putConnectionInstance happened earlier in connect so now the OvsdbNodeUpdateCommand gets a chance to run and write the externalIds to the Open_vSwitch table
...
OvsdbMonitorCallback -> OpenVSwitchUpdateCommand - > writes node to operational
*** key here is that the iid (nodePath) is found by looking for the externalIds. If found, since it was written earlier, then it is used, if not the backup of using the uuid of the node is used. The IT expects the externalIds value to be there and that is the one with the form ip:port.
In the new code:
- putConnectionInstance() does not happen until the handleOwnership completes - too late since the updateData is processed before that
- updateData doesn't do anything, complains about not finding client since the connectionInstance was not written earlier, therefore the externalIds are not written
- OpenVSwitchUpdateCommand ends up using the wrong iid of the form using the uuid since the externalIds were not written.
Change-Id: Iafbb8c4fa3dd5708f4c4bd3242e27ec72a4b4c6e
Signed-off-by: Sam Hague <shague@redhat.com>
Andre Fredette [Tue, 6 Oct 2015 21:33:15 +0000 (17:33 -0400)]
Bug 4144 - Periodic ARP resolver should use unicast MAC destination
address whenever possible; instead of broadcast
Modified ArpResolver and GatewayMacResolverService to use the unicast DA
when known. The code treats the DA as known for a new ARP request if
one of the last N=2 ARP request was answered.
Change-Id: I2bd7791b74d41e2838edf59d6edc510b63f3c40b
Signed-off-by: Andre Fredette <afredette@redhat.com>
Vishal Thapar [Mon, 12 Oct 2015 08:52:57 +0000 (14:22 +0530)]
hwvtep: version bump to 1.2.1
Update hwvtep poms as per this:
https://git.opendaylight.org/gerrit/#/c/25574/
Change-Id: I651a4e475e9bf243497ce07386e7418141f2fc3c
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Sam Hague [Fri, 9 Oct 2015 20:22:56 +0000 (16:22 -0400)]
Add setting controller for sfc it
This patch adds setting the controller so that flows can be pushed to the switches.
Use the following to initate the tests:
start an ovsdb node and set it to be in passive mode: sudo ovs-vsctl set-manager ptcp:6640
cd .../net-virt-sfc/it
mvn -Dit.test=NetvirtSfcIT#testDoIt verify -Pintegrationtest -Dovsdbserver.ipaddress=192.168.120.31
The above will connect to the node and set's it controller to ODL.
Change-Id: Ibf307b668535e47fe80ba0a8b7403e53d7a40ccb
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Fri, 9 Oct 2015 19:25:47 +0000 (15:25 -0400)]
Add southbound to sfc it
Change-Id: I1627b92af8a919063d9214d57117741809525134
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Fri, 9 Oct 2015 18:57:28 +0000 (14:57 -0400)]
Add southbound utils.
This commit is copying the duplicated integration test code
for manipulating the southbound into a utils bundle. This
code is duplicated in the netvirt-it, setvirtsfc-it and southbound-it.
We will slowly migrate them to use this new utils bundle.
Change-Id: If3197fe3bcf50c12faff70cd01426b695686dd83
Signed-off-by: Sam Hague <shague@redhat.com>
Flavio Fernandes [Fri, 9 Oct 2015 12:07:45 +0000 (12:07 +0000)]
Merge "UT for southbound/transactions/md - set 3"
Flavio Fernandes [Fri, 9 Oct 2015 12:06:41 +0000 (12:06 +0000)]
Merge "Remove unused code"
Sam Hague [Thu, 8 Oct 2015 20:34:14 +0000 (16:34 -0400)]
Add IT for netvirtsfc mdsal read/write/delete
To run the integration tests:
- cd ../ovsdb/openstack/net-virt-sfc
- mvn clean install -Pintegrationtest
Change-Id: I191ace9c510a63bca59d99009eca8e970566f3f9
Signed-off-by: Sam Hague <shague@redhat.com>
Rashmi Pujar [Thu, 8 Oct 2015 18:24:54 +0000 (14:24 -0400)]
UT for southbound/transactions/md - set 3
6. OvsdbControllerUpdateCommand.java
7. OvsdbManagersRemovedCommand.java
Change-Id: Idcb7ff1ad8f414cb243ae766e69d6437d0bee93f
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>
Anil Vishnoi [Thu, 8 Oct 2015 16:22:57 +0000 (21:52 +0530)]
Remove unused code
Conflicts:
openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/api/UuidUtils.java
Change-Id: I09b2e4eee6e88d68c63fdbea8e7e42da790576e9
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Sam Hague [Wed, 7 Oct 2015 22:42:02 +0000 (22:42 +0000)]
Merge "UT for southbound/transactions/md - set 2"
Flavio Fernandes [Wed, 7 Oct 2015 21:23:35 +0000 (21:23 +0000)]
Merge "If controller joins the cluster late, and the owner of the device is already decided, EntityOwnershipService won't notify new candidate that register for ownership. Adding a proactive check on the ownership state of the device, so if it's already owned, adding the connection instances in the connection cache."
rpujar [Wed, 7 Oct 2015 20:29:28 +0000 (16:29 -0400)]
UT for southbound/transactions/md - set 2
4. OvsdbBridgeUpdateCommand.java
5. OvsdbControllerRemovedCommand.java
Change-Id: Idc469c08351b1e98129dd9e798c07a660d782709
Signed-off-by: rpujar <rpujar@inocybe.com>
Sam Hague [Wed, 7 Oct 2015 17:22:54 +0000 (13:22 -0400)]
Cleanup netvirtsfc poms
Change-Id: I6c1a3aa44c75f98d226dcf23dd514a31f5df5d2a
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Wed, 7 Oct 2015 17:22:13 +0000 (13:22 -0400)]
Bump mdsal-utils version to match other bundles
Change-Id: I6c5166ae27fd2f055217be95630cbc482261bb61
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Wed, 7 Oct 2015 13:38:27 +0000 (13:38 +0000)]
Merge "UT for southbound/transactions/md"
Sam Hague [Wed, 7 Oct 2015 00:36:02 +0000 (00:36 +0000)]
Merge "Fix checkstyle issues in netvirtsfc"
Anil Vishnoi [Tue, 6 Oct 2015 20:41:25 +0000 (02:11 +0530)]
If controller joins the cluster late, and the owner of the device
is already decided, EntityOwnershipService won't notify new candidate that register
for ownership. Adding a proactive check on the ownership state of the device,
so if it's already owned, adding the connection instances in the connection cache.
Change-Id: I7e87b55599f0ebd408814d72789c86f231b7907c
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
rpujar [Tue, 6 Oct 2015 19:56:23 +0000 (15:56 -0400)]
UT for southbound/transactions/md
1. AbstractTransactionCommand.java
2. OpenVSwitchUpdateCommand.java
3. OvsdbBridgeRemovedCommand.java
Change-Id: I7655dec526bc06b770c533dd082eb403bc89a2c7
Signed-off-by: rpujar <rpujar@inocybe.com>
Sam Hague [Tue, 6 Oct 2015 19:48:18 +0000 (19:48 +0000)]
Merge "Send a canonical IPv4 prefix in table 60 routing rules"
Sam Hague [Tue, 6 Oct 2015 19:45:13 +0000 (15:45 -0400)]
Fix checkstyle issues in netvirtsfc
Change-Id: I7db518959449958849a74c49a83bde1135ee325f
Signed-off-by: Sam Hague <shague@redhat.com>
Eric Multanen [Fri, 2 Oct 2015 13:43:04 +0000 (06:43 -0700)]
Send a canonical IPv4 prefix in table 60 routing rules
Testing with userspace OVS with DPDK uncovered that the routing
rules that go into table 60 were getting rejected.
Messages from ovs-vswitchd.log:
... |nx_match|WARN|Rejecting NXM/OXM entry
0:32768:12:1:8 with 1-bits in value for bits wildcarded by the mask.
... |connmgr|INFO|br-int<->tcp:10.11.21.7:6653:
sending OFPBMC_BAD_WILDCARDS error reply to OFPT_FLOW_MOD message
Clearing the non-prefix bits resolved the problem and the flows were
successfully added.
v2 - split up long line into two more readable lines
Change-Id: I42a0c63e6e837197d29bb8333f12e822a5f15d91
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
sangeeta.maurya [Tue, 6 Oct 2015 17:11:55 +0000 (22:56 +0545)]
Custom ICMP SG Rule:
1)Modification in ICMP matcher
2)Unit Test Improvement (Check added to validate if some values are set
properly).
Change-Id: I31fad80f6dd278372abe2b1a6aac95935aef5f17
Signed-off-by: sangeeta.maurya <sangeeta.maurya@hp.com>
Sam Hague [Tue, 6 Oct 2015 18:43:20 +0000 (18:43 +0000)]
Merge "Southbound UT: Fix SouthboundMapper stackoverflow issue"
Sam Hague [Tue, 6 Oct 2015 18:15:31 +0000 (18:15 +0000)]
Merge "Mechanical cleanup to SouthboundIT"
adetalhouet [Sat, 3 Oct 2015 22:24:30 +0000 (18:24 -0400)]
Southbound UT: Fix SouthboundMapper stackoverflow issue
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>
Sam Hague [Tue, 6 Oct 2015 15:54:09 +0000 (15:54 +0000)]
Merge "Fix build issues for UT for updated SouthboundProvider.class"
Sam Hague [Tue, 6 Oct 2015 15:32:08 +0000 (15:32 +0000)]
Merge "Net-virt-sfc Data Change Listener code first pass."
arunsarat [Mon, 5 Oct 2015 20:32:20 +0000 (13:32 -0700)]
Net-virt-sfc Data Change Listener code first pass.
Change-Id: Ie1e8e4471b2bddf476b8a55a1d022d4ace517868
Signed-off-by: arunsarat <arunsarat@yahoo.com>
Signed-off-by: Sam Hague <shague@redhat.com>
rpujar [Tue, 6 Oct 2015 13:46:31 +0000 (09:46 -0400)]
Fix build issues for UT for updated SouthboundProvider.class
Change-Id: If806d385d9399e514ea977a33fd9ab8008a8850b
Signed-off-by: rpujar <rpujar@inocybe.com>
Flavio Fernandes [Mon, 5 Oct 2015 21:14:36 +0000 (21:14 +0000)]
Merge "Add UT for SouthboundMapper and SouthboundProvider"
rpujar [Thu, 1 Oct 2015 15:43:34 +0000 (11:43 -0400)]
Add UT for SouthboundMapper and SouthboundProvider
Change-Id: I38776516b120cc16d123d37dcafb8d19c6fd7e21
Signed-off-by: rpujar <rpujar@inocybe.com>
Sam Hague [Mon, 28 Sep 2015 21:21:34 +0000 (17:21 -0400)]
Use odlparent checkstyle
Patch set 2: Remove ovsdb_checks.xml from parent pom
Patch set 3: Remove ovsdb_checks.xml from directory
Patch set 4: Add hwvtepsouthbound
Change-Id: Iccc680728e19967f9977453bb75c9c64b1a53e0c
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Sat, 3 Oct 2015 23:09:00 +0000 (23:09 +0000)]
Merge "Fix sonar integration test reporting"
Sam Hague [Sat, 3 Oct 2015 01:20:10 +0000 (21:20 -0400)]
Fix sonar integration test reporting
Change-Id: Icb238c6442a8d15ae144d6e9abbaabf9fd011570
Signed-off-by: Sam Hague <shague@redhat.com>
Anil Vishnoi [Sat, 3 Oct 2015 01:33:33 +0000 (07:03 +0530)]
Added postman collection and postman environment
files for Southbound plugin to test in Single and 3 Node cluster environment
Change-Id: I144801f0200d607013b3fa839cabf1de7c3bf1d0
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Anil Vishnoi [Fri, 2 Oct 2015 17:08:10 +0000 (22:38 +0530)]
Merge topic/master/clustering to master branch
Squashed commit of the following:
commit
e9e3a762ee75844b930d8251f44d2718a3358445
Merge:
2adbc25 83cfd5b
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date: Fri Oct 2 19:54:23 2015 +0530
Merge branch 'master' into topic/master/clustering
Change-Id: I3c26c3f4095b78d869cae271b01fa1ab2609cf89
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit
2adbc25b474d46f394e8f956c818383425570600
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date: Fri Oct 2 07:22:44 2015 +0530
Addressed following issuses:
1) Fixed entity unregisteration
2) Implemented logic for southbound provider to participate
in entityOwnership service, Southbound plugin instance as an entity
This will avoid all the instances to do initiatize the operational
and config topology, only master instance (who got ownership) will do that.
3) Properly closing listener registration for OvsdbConnectionManager listerner.
Change-Id: I73693b4faa8a6409c81c33647836516002b4b2fd
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit
193f145796924c051b36c61974df4253e68efb7e
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date: Thu Oct 1 16:54:41 2015 +0530
Addressed following issues:
1) Handled ownership change notifications for the device that is not registered by the instance.
2) If there is no owner of the device hasOwner=false, then clean up the operational data store,
3) For switch initiated connections, generate iid by fetching the openvswtich table row from the device.
Change-Id: I03158a616e7c020ce8f851b8251e4162f38ba622
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit
c26d79561555c23f4aec894418537cf059a1f85a
Merge:
740d21a 7848a77
Author: Flavio Fernandes <ffernand@redhat.com>
Date: Thu Oct 1 14:42:00 2015 -0400
Merge branch 'master' into topic/master/clustering
Change-Id: I191e71030d6523a3d7a11765010cc1b81b9405f3
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
commit
740d21afacb5a652a3a1d78ceff2c0d998492add
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date: Wed Sep 30 02:15:26 2015 +0530
Fixed iid issue for switch initiated connections
and refactored the code a bit
Patch 2:Fixed unit tests.
Conflicts:
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/OvsdbConnectionInstance.java
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/OvsdbConnectionManager.java
Change-Id: I9f8adfba4a4f866d423503b24f400c40bd43131b
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit
9079eb260e123c00625dc13e63a6f55d9bc42aea
Merge:
b203967 0179232
Author: Flavio Fernandes <ffernand@redhat.com>
Date: Tue Sep 29 12:58:54 2015 -0400
Merge branch 'master' into topic/master/clustering
Change-Id: I02c771238cd7447dbaa326516467259516868aa6
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
commit
b203967504c1de8814c32e7c7c8015ebb749e154
Author: Sharad Mishra <sharad.d.mishra@intel.com>
Date: Mon Sep 28 06:19:38 2015 -0700
OVSDB cluster device ownership
Only allow device owner to update device.
Patch 2: Fixed unit test
Change-Id: Id942a2ba16a83b19807e135a9b67f8a7eb7da003
Signed-off-by: Sharad Mishra <sharad.d.mishra@intel.com>
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit
218785ea03b74287de86395d1e57471ce02fe5e4
Author: Flavio Fernandes <ffernand@redhat.com>
Date: Wed Sep 23 09:55:06 2015 -0400
Use EntityOwnershipService to get ownership on the device.
If ownership is granted then *this* instance of southbound
plugin can perform actions to configure the device, rest
two southbound plugin instanceses in the cluster will just
hole the connection with them and won't do any operation
of configuring the device or reading from the device.
For controller initiated connections, all the southbound
plugin instance will attempt to connect to the device and
contest for ownership of the device and selected owner of
the device will do CRUD operations. For switch initiated
connection, only instance of southbound plugin that received
connection from switch will contest for ownership.
Change-Id: I349699ae0630e12bdbe18b6bd2588a651edd1f81
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit
da209a4aad67400a3c938329fb393ec6f7e2439e
Merge:
ec7827c 11c0865
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date: Tue Sep 29 00:44:50 2015 +0530
Merge branch 'master' into topic/master/clustering
Change-Id: I44ac4d66f731c0c0f56d746c563c6210eeceb978
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit
ec7827c688340fa85c42942ba6559201da07286a
Author: Flavio Fernandes <ffernand@redhat.com>
Date: Mon Sep 21 17:57:02 2015 -0400
Add hasDeviceOwnership flag to OvsdbConnectionInstance
Patch set 4: fix ut
Change-Id: Id7da9071374938c16b086b0d67059aec0a7cc3a0
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
commit
3cc32fd3d007b4c91dfbadee3920b9ae61a9283c
Author: Flavio Fernandes <ffernand@redhat.com>
Date: Fri Sep 25 17:02:13 2015 -0400
Set bridge controller(s) based on ovsdb node manager(s)
Change-Id: I10bcc04aed78f874cbb8a7d9a82e59cf1b80ec82
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
commit
628749e43002c4aa9fc8bfdf7c827cba0532eb6b
Merge:
3d7ce06 360d519
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date: Sat Sep 26 01:27:28 2015 +0530
Merge branch 'master' into topic/master/clustering
Change-Id: I20e84a6971466357c6819c7dba5d51809f9b2878
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit
3d7ce0660d25080dd1a5e3927eda6d071e085d12
Merge:
8a90856 708c8c3
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date: Fri Sep 25 06:07:23 2015 +0530
Merge branch 'master' into topic/master/clustering
Change-Id: I35038c6d7b2150d2efc9692a02d5e94bd97a8dba
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit
8a908569f4e8e19e7f03f08f97d0704f9ca46cc9
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date: Tue Sep 22 01:52:42 2015 +0530
Enable remote notification for southbound plugin
(cherry picked from commit
01f0737be6abacaf56721731f6a19dcb13e291f0)
Change-Id: Ida036244f3861e4d07437b49179bbf2851a212a5
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit
7747c272e6ad5f52ebcae97fd14e05762bc8f790
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date: Tue Sep 22 00:05:49 2015 +0530
Wire entity ownership service to OVSDB southbound plugin
Change-Id: I8baa3b31f9762c4b5656b399a1a7f705c1aed9c1
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Change-Id: Iec7a1c3055dac748c81b470a3d2286b42e32397e
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Stephen Kitt [Fri, 2 Oct 2015 14:36:32 +0000 (16:36 +0200)]
Mechanical cleanup to SouthboundIT
* dataBroker can be turned into a local variable
* "frmo" -> "from"
* drop a couple of variables used only for return
* Javadoc corrections
* remove commented Assume calls which have corresponding Assert calls
* reduce the scope of variables where appropriate
* fix an impossible equals assert (dpTypeStr -> dpType compared to a
DatapathTypeBase class)
* Java 7 <> operator
* remove unnecessary casts and boxing
* correct a format string ("%s_%s_d" -> "%s_%s_%d")
Change-Id: I9a7da21a9252c3f256a0230521402ced3fffb774
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Sam Hague [Fri, 2 Oct 2015 13:10:04 +0000 (13:10 +0000)]
Merge "Use the memorized service reference"
Sam Hague [Fri, 2 Oct 2015 13:08:23 +0000 (13:08 +0000)]
Merge "UT for SouthboundUtil.java"
Sam Hague [Fri, 2 Oct 2015 13:07:05 +0000 (13:07 +0000)]
Merge "Bug 4277 - Deleted Network flow entries retained in br-int, if network associated and disassociated from virutalrouter interface"
Stephen Kitt [Fri, 2 Oct 2015 09:37:39 +0000 (11:37 +0200)]
Future-proof OvsdbTypesIdResolver
Instead of implementing TypeIdResolver directly, the recommended
approach is to extend TypeIdResolverBase; this ensures that upgrading
Jackson won't cause sudden build failures because of methods added to
TypeIdResolver (TypeIdResolverBase provides an appropriate default
implementation).
Change-Id: I6be57cc22a54e46e9e07ff835f7ccf9feec14c8f
Signed-off-by: Stephen Kitt <skitt@redhat.com>
ravi_sabapathy [Mon, 28 Sep 2015 07:31:48 +0000 (00:31 -0700)]
Bug 4277 - Deleted Network flow entries retained in br-int, if network associated and disassociated from virutalrouter interface
Remove the mac cache after deleting the DHCP neutron port l3 flows
Patch set 2: Move all other caches updated in delete into cleanupRouterCache()
Change-Id: I0c29ba4976ddfd484415d851ad5a2df97d61b19a
Signed-off-by: ravi_sabapathy <ravi_sabapathy@dell.com>
rpujar [Tue, 29 Sep 2015 20:40:56 +0000 (16:40 -0400)]
UT for SouthboundUtil.java
Change-Id: I87e3577ab2f262ec7f50b6c185a41f49b1e607ed
Signed-off-by: rpujar <rpujar@inocybe.com>
Sam Hague [Thu, 1 Oct 2015 12:20:42 +0000 (12:20 +0000)]
Merge "Speed up SouthboundIT through multi-threading test cases"
Sam Hague [Thu, 1 Oct 2015 12:15:35 +0000 (12:15 +0000)]
Merge "Add yang for hwvtep"
Stephen Kitt [Mon, 28 Sep 2015 16:06:54 +0000 (18:06 +0200)]
Use the memorized service reference
Currently when dispatching "event handler added" events we retrieve
the appropriate service reference from the bundle context, but this
seems to cause problems when multiple services are registered for the
same interfaces. Since we know the service reference we got when
registering the service involved, we can just pass that.
As a result, ConfigInterface::setDependencies() doesn't need a
BundleContext at all, and since we're no longer supposed to pass that
around, we can just remove it altogether.
Some more debugging information should help track down other issues of
this type.
Change-Id: Iac54595aed388165711a7c4a3d86577646c59d4f
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Flavio Fernandes [Tue, 29 Sep 2015 14:57:03 +0000 (10:57 -0400)]
Less restriction on shared networks: it can be allowed on externals
Change-Id: I0a66758731eb35a73623c6f663792b9dffbfec08
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
Sam Hague [Tue, 29 Sep 2015 10:56:19 +0000 (10:56 +0000)]
Merge "Added model for QoS and Queue."
Sam Hague [Fri, 25 Sep 2015 20:40:20 +0000 (16:40 -0400)]
Use common profiles among ovsdb it bundles
Change-Id: I2636a15eb821e1be7edbebcdeef9d94cb0d783be
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Mon, 28 Sep 2015 14:30:05 +0000 (14:30 +0000)]
Merge "Remove unused integrationtest"
Sam Hague [Fri, 25 Sep 2015 19:41:15 +0000 (15:41 -0400)]
Remove unused integrationtest
Also add missing dependencies in library
Change-Id: I120a20ffb76f8d18bb54b1b72a69e752922974e4
Signed-off-by: Sam Hague <shague@redhat.com>
Gabriel Robitaille-Montpetit [Mon, 3 Aug 2015 23:11:04 +0000 (19:11 -0400)]
Added model for QoS and Queue.
Change-Id: I0d254ea9648dee2298a62523d6a10b64dcc88297
Signed-off-by: Gabriel Robitaille-Montpetit <grmontpetit@inocybe.com>
Sam Hague [Mon, 28 Sep 2015 12:51:01 +0000 (12:51 +0000)]
Merge "Added Security Rule for Custom ICMP"
Flavio Fernandes [Fri, 25 Sep 2015 19:49:08 +0000 (19:49 +0000)]
Merge "Remove unused northbound"
Sam Hague [Fri, 25 Sep 2015 19:48:28 +0000 (19:48 +0000)]
Merge "Controller initiated connections always connect to one manager listening in ptcp: mode. In clustered mode, all the three controller will connect to the device, and in case any of the connection will flip that instance will remove OvsdbNode from operational data store because it will see only one manager in manager list. But because switch is listening in passive mode, there can be multiple connection to same manager. To handle this scenario, this patch adds number_of_connection attribute to OvsdbNodeAugmentation to maintain the number of active connection to specific manager. In case of switch initiated connection this value is going to be 1 for each manager, but in case switch listening in passive mode, this value will represent active connections (extraced from Manager tables status column n_connections attributes)."
Flavio Fernandes [Fri, 25 Sep 2015 19:45:20 +0000 (19:45 +0000)]
Merge "Bug 3989 -- Fix the original patch. Original patch can break the functioning if there are more then one data change and the first data change is OvsdbNodeAugmentation for which connection already exist. It will return out of OnDataChanged() when it see that connection already exist, without processing rest of the data"
Flavio Fernandes [Fri, 25 Sep 2015 19:31:30 +0000 (19:31 +0000)]
Merge "Move OvsdbClient it under library-it"
Anil Vishnoi [Fri, 25 Sep 2015 17:34:02 +0000 (23:04 +0530)]
Bug 3989 -- Fix the original patch. Original patch can break
the functioning if there are more then one data change and
the first data change is OvsdbNodeAugmentation for which connection
already exist. It will return out of OnDataChanged() when it see
that connection already exist, without processing rest of the
data
Change-Id: Icec9fdcc241fb9f1b823d73cbe2dfdd1f5c3def7
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Sam Hague [Fri, 25 Sep 2015 18:46:59 +0000 (14:46 -0400)]
Move OvsdbClient it under library-it
A following commit will remove the integrationtest dir. With this commit here there
are no longer any tests in integrationtest. They have all been moved into the respective
bundles.
Change-Id: I40e7dccd6e5ee7ea362d75a422610fbdfe5e55cc
Signed-off-by: Sam Hague <shague@redhat.com>
Anil Vishnoi [Fri, 25 Sep 2015 04:19:01 +0000 (09:49 +0530)]
Controller initiated connections always connect to one manager
listening in ptcp: mode. In clustered mode, all the three controller
will connect to the device, and in case any of the connection will flip
that instance will remove OvsdbNode from operational data store because
it will see only one manager in manager list. But because switch is
listening in passive mode, there can be multiple connection to same manager.
To handle this scenario, this patch adds number_of_connection attribute
to OvsdbNodeAugmentation to maintain the number of active connection to
specific manager. In case of switch initiated connection this value is
going to be 1 for each manager, but in case switch listening in passive
mode, this value will represent active connections (extraced from
Manager tables status column n_connections attributes).
Change-Id: I910104a5109b5bed6af7786a7692c617bd4305b7
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Sam Hague [Fri, 25 Sep 2015 15:27:44 +0000 (11:27 -0400)]
Remove unused northbound
Change-Id: I8ac5ae92315d2558a7563a35bdd67c0d816ccc68
Signed-off-by: Sam Hague <shague@redhat.com>
Anil Vishnoi [Wed, 23 Sep 2015 18:08:06 +0000 (23:38 +0530)]
Fix ovsdb node update in clustered environment
In cluster environment same switch can be connected to multiple
controller instance running southbound plugin. In the existing implementation
if device disconnect from any of the controller instances OVSDB-SB remove
OvsdbNode from operational data store. In cluster environment that will
break contract with customer, given that device is still connected to
atleast one of the two controller instances running. This patch modifying the
behavior where controller will see if its the only connected controller,
then it will delete the data from operational data store, else it will skip
any clean up from operational data store, because other instances will anyway
update about the disconnected controller manager entry in the managers list.
Change-Id: Iaa043f6632eb2de660b623604e8f8e0938dbc4d5
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
(cherry picked from commit
6051e15c6f929c08f152417b1f19373b10e93647)
Anil Vishnoi [Fri, 25 Sep 2015 15:06:17 +0000 (15:06 +0000)]
Merge "Remove unused mdsal-plugin-adapter code"
Ryan Goulding [Wed, 26 Aug 2015 18:25:37 +0000 (14:25 -0400)]
Speed up SouthboundIT through multi-threading test cases
This speeds up SouthboundIT without losing coverage through the use of parallel
test cases. On my VM,ExecutorSer this reduced test time from ~12 to ~4.5 minutes.
Aggregates the testing work for certain test cases into corresponding
Runnables. For each set of test input data, a Runnable is spawned and
submitted to a fixed thread pool. The thread pool size may be altered
through the NUM_THREADS constant. The default is 4 since raising this
number causes issues with MD-SAL.
These test cases can be multi-threaded because they each utilize a distinct
bridge. In other words, each thread is manipulating a different bridge in the
operating system.
Change-Id: Icd8ca69171e996fbf4000ef632c9446bb6c89ed6
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Sam Hague [Fri, 25 Sep 2015 14:08:18 +0000 (10:08 -0400)]
Remove unused mdsal-plugin-adapter code
Change-Id: I161b63c1c5b4cff39388d8342052920e245e3796
Signed-off-by: Sam Hague <shague@redhat.com>
Flavio Fernandes [Fri, 25 Sep 2015 00:36:38 +0000 (00:36 +0000)]
Merge "Mdsal utils bundle"
Anil Vishnoi [Thu, 24 Sep 2015 16:32:26 +0000 (16:32 +0000)]
Merge "Initial pass at netvirt model"
Sam Hague [Mon, 21 Sep 2015 01:45:11 +0000 (21:45 -0400)]
Mdsal utils bundle
Patch set 2: Renamed to MdsalUtils and matched the strucure of
the other bundles in the utils dir.
This commit adds a Mdsal utils bundle that has all the mdsal methods to read,
write, delete and merge to the datastore. This is so that other bundles can
reuse the same methods.
Change-Id: Ida83ed957f74155224b007b54e3e80bfb1e29a71
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Thu, 24 Sep 2015 14:32:05 +0000 (14:32 +0000)]
Merge "Added UT for OvsdbDataChangeListener.java"
rpujar [Wed, 23 Sep 2015 15:39:48 +0000 (11:39 -0400)]
Added UT for OvsdbDataChangeListener.java
Also added code to test new method in OvsdbConnectionManager.java
Change-Id: I75faec2f20305c9ac806087042136d09d1048d49
Signed-off-by: rpujar <rpujar@inocybe.com>
Sam Hague [Mon, 21 Sep 2015 01:43:59 +0000 (21:43 -0400)]
Initial pass at netvirt model
Patch set 2: Renamed netvirtmodel to net-virt-sfc.
Patch set 3: Add net-virt-sfc to the root pom so it is built
Change-Id: Ia8b21b538e38463e860148abb4bf055ae3020761
Signed-off-by: Sam Hague <shague@redhat.com>
Stephen Kitt [Wed, 23 Sep 2015 16:24:32 +0000 (18:24 +0200)]
Clean up dependencies and features
Remove more plugin-related code.
Correct a couple of netconf dependencies.
Remove obsolete dependencies on controller features which are no
longer provided upstream.
Change-Id: Ia8f68200e997c11375414cd3071fe605b9025cd4
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Anil Vishnoi [Wed, 23 Sep 2015 15:37:41 +0000 (21:07 +0530)]
Add YangInstanceIdentifer to InstanceIdentifier converter method
Change-Id: I540772d6461ccf9a281b738a3ba8d6601abffafb
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Anil Vishnoi [Wed, 23 Sep 2015 18:49:12 +0000 (00:19 +0530)]
Fixed unit test testDisconnect in OvsdbConnectionmanagerTest
Change-Id: I2b2eca244036dc7567c24e85a71bd968f04ac587
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Anil Vishnoi [Wed, 23 Sep 2015 14:02:48 +0000 (14:02 +0000)]
Merge "hwvtepsb: Fixed restconf migration build issues"
Vishal Thapar [Wed, 23 Sep 2015 12:34:51 +0000 (18:04 +0530)]
hwvtepsb: Fixed restconf migration build issues
restconf migration from controller to netconf was done while
hwvtep bundle creation was in progress, so those were not done
for hwvtepsouthbound which is causing build failure.
Change-Id: Ib32c591e0dd197730f1bc50d7e92b38018c0fd7f
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Flavio Fernandes [Wed, 23 Sep 2015 12:15:39 +0000 (12:15 +0000)]
Merge "Unit Test for ovsdb southbound OvsdbConnectionManager.java"
Flavio Fernandes [Wed, 23 Sep 2015 12:15:07 +0000 (12:15 +0000)]
Merge "Added manager list to Ovsdb Node. For application southbound plugin only give a device level view and not a connection level view. To make net-virt cluster aware, it needs to the managers of the ovsdb server, so that when it creates ovs bridges, it can connect them to the same controllers through OF plugin"
Anil Vishnoi [Tue, 22 Sep 2015 22:06:50 +0000 (03:36 +0530)]
Added manager list to Ovsdb Node.
For application southbound plugin only give a device level view and not a connection level view.
To make net-virt cluster aware, it needs to the managers of the ovsdb server, so that
when it creates ovs bridges, it can connect them to the same controllers through OF plugin
Tests:
ovs-vsctl set-manager tcp:ip:6640
ovs-vsctl set-manager tcp:ip:6640 tcp:ip2:6640
ovs-vsctl set-manager tcp:ip:6640
ovs-vsctl del-manager
Change-Id: I8b68fef9583f4fbcc330a0e9fc239015851b3f7c
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Anil Vishnoi [Wed, 19 Aug 2015 12:22:17 +0000 (17:52 +0530)]
Removing the old unused plugin and ovsdb-plugin-compatibility-layer
OVSDB stopped using these module in Lithium release. These modules were kept for VTN project, because they didn't had time to migrate
VTN component that relies on these module to MD-SAL.
We will merge this patch after one month on 19th Sep.
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Anil Vishnoi [Wed, 23 Sep 2015 01:40:21 +0000 (07:10 +0530)]
Fixed binding-parent groupId. It was causing build failure
Patch2: Fix library module to use odl-mdsal-models feature rather then deprecated odl-yangtools-models
Patch3: Fix hwvtep southbound module to use odl-mdsal-models feature as well. Also disable hwvtepsouthbound-karaf
and hwvtepsouthbound-it features. They are causing the build break.
Change-Id: Ia2261af7f21fb4dbff2958a5e3a01283c4c43f23
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Flavio Fernandes [Tue, 22 Sep 2015 17:09:02 +0000 (17:09 +0000)]
Merge "Revert "Use the library config bundle in southbound""
Stephen Kitt [Tue, 22 Sep 2015 15:07:25 +0000 (15:07 +0000)]
Revert "Use the library config bundle in southbound"
This reverts commit
c031f4be42abdbee58417a0c0af3ea14f74b2e95, which fails IT currently.
Change-Id: Ib1dd8daf9005fccc886ebaa6b831aa89cfa78597
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Sam Hague [Tue, 22 Sep 2015 11:36:53 +0000 (11:36 +0000)]
Merge "Use the library config bundle in southbound"
rpujar [Wed, 16 Sep 2015 13:07:53 +0000 (09:07 -0400)]
Unit Test for ovsdb southbound OvsdbConnectionManager.java
Change-Id: I272d716e3d8b3df9bdaea5fc0009c809c8e25933
Signed-off-by: rpujar <rpujar@inocybe.com>
Vishal Thapar [Tue, 14 Jul 2015 04:46:22 +0000 (10:16 +0530)]
Add yang for hwvtep
1. Addressed some review comments
2. Added some new fields
3. Moved file to hwvtepsouthbound-api
4. Fix for key mac-entry-key issue
Change-Id: I37945123170621dc8dacf187d2a47ff744fdceb5
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Sam Hague [Thu, 17 Sep 2015 11:51:13 +0000 (11:51 +0000)]
Merge "SecGroup: Handle cases when security group has empty rules"
Stephen Kitt [Thu, 17 Sep 2015 10:01:38 +0000 (12:01 +0200)]
Bug 3989: clear the connection info
When disconnecting, we need to clear the connection info to avoid
thinking we're still connected later.
Add assertions in the southbound IT tests to make sure we don't
connect twice.
Change-Id: I778a2cb9ab957db02146f5a2b3a6658129ba7219
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Flavio Fernandes [Thu, 17 Sep 2015 05:13:45 +0000 (01:13 -0400)]
SecGroup: Handle cases when security group has empty rules
Change-Id: I54ef43f6a4afd9fc571c8dcf9bf843007452c968
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
Anil Vishnoi [Wed, 16 Sep 2015 17:11:06 +0000 (17:11 +0000)]
Merge "Initial bundle creation for HWTEP SB"
Anil Vishnoi [Wed, 16 Sep 2015 12:57:31 +0000 (12:57 +0000)]
Merge "A few cleanups"
Stephen Kitt [Wed, 16 Sep 2015 09:14:03 +0000 (11:14 +0200)]
Document how to use Docker Compose
Fig has been obsoleted by Docker Compose. Some distributions have now
replaced Fig entirely (e.g. Fedora 22); this patch documents Docker
Compose as an alternative to Fig.
Change-Id: Ia33bb8633e7c2f039857b98ba96e9b8b343d0394
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Flavio Fernandes [Wed, 16 Sep 2015 06:19:35 +0000 (02:19 -0400)]
A few cleanups
* use plain String concatenation instead of StringBuilder where appropriate
* simplify single-use return variables
* <> operator
* avoid calling new String()
Change-Id: I56e99426daeda620a37059417588e5ee4fb99c76
Also-By: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
Flavio Fernandes [Wed, 16 Sep 2015 05:44:10 +0000 (05:44 +0000)]
Merge "Revert "Use single-argument form of firstKeyOf()""
Anil Vishnoi [Tue, 15 Sep 2015 22:58:34 +0000 (22:58 +0000)]
Revert "Use single-argument form of firstKeyOf()"
This reverts commit
e19e4e3f10f65054aba16a94c082180f24b9beb6.
This is breaking the net-virt code. Bridges are not getting created when OVSDB server connects to the controller. Probably happening because of single argument firstKeyOf() method.
Change-Id: I76ab5f86f7329f741e30fd21eaed436391f793b8
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Vishal Thapar [Tue, 1 Sep 2015 09:32:08 +0000 (15:02 +0530)]
Initial bundle creation for HWTEP SB
1. Creating initial bundles for hwvtep southbound using Startup Project
archetype.
2. Adds hwvtepsouthbound bundle and entry in ovsdb/pom.xml
PatchSet2:
1. Addressed review comments and added hwvtepsouthbound-it
PatchSet3:
1. Fixed IT failure.
PatchSet4:
Fixed minor issue in southbound/default-config.xml
Change-Id: Ib185c1a9a90b08dc84f64231b8fee414d1e209a0
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>