bgpcep.git
9 years agoBUG-608 : implemented SrPrefix parser/serializers 01/15401/4
Dana Kutenicsova [Tue, 17 Feb 2015 09:52:30 +0000 (10:52 +0100)]
BUG-608 : implemented SrPrefix parser/serializers

Change-Id: I55b6cc996d0fdeb8a77ecaa703f1ce8c9ec2770e
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoMoved serializing of forwarding address to conform tlv order 02/15402/3
Dana Kutenicsova [Tue, 17 Feb 2015 09:51:38 +0000 (10:51 +0100)]
Moved serializing of forwarding address to conform tlv order

- adjusting also the tests

Change-Id: Ib2857f0f3f0ec90252d21c19ed4a1b4075837321
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoUntagle packages 52/15352/8
Dana Kutenicsova [Mon, 16 Feb 2015 09:19:48 +0000 (10:19 +0100)]
Untagle packages
by moving TlvUtil to separate spi package.

Change-Id: I3a0619e65d392c5c38d4a97220245de397451e1f
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-608: parsers/serializers for SID Label Binding TLV and sub-tlvs 50/15350/6
Dana Kutenicsova [Sun, 15 Feb 2015 21:40:19 +0000 (22:40 +0100)]
BUG-608: parsers/serializers for SID Label Binding TLV and sub-tlvs

Change-Id: I49d0e7fe2effaef56eef690e23ed8a177a0f722b
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoMerge "Use readUnsignedByte instead of readByte and typecast."
Robert Varga [Wed, 18 Feb 2015 13:36:15 +0000 (13:36 +0000)]
Merge "Use readUnsignedByte instead of readByte and typecast."

9 years agoMerge "Remove check for empty lists, where not needed."
Robert Varga [Wed, 18 Feb 2015 13:32:56 +0000 (13:32 +0000)]
Merge "Remove check for empty lists, where not needed."

9 years agoBug-2208: pcc-mock support tunnel initiate and remove 57/15257/2
Milos Fabian [Wed, 11 Feb 2015 14:16:07 +0000 (15:16 +0100)]
Bug-2208: pcc-mock support tunnel initiate and remove

-pcc-mock can handle PCInitaiate message (create/remove tunnel)
and sends fake report message.
-extended EndPointIpv4ObjectParser to avoid checking "P" object header flag

Change-Id: I822d649940a1a8d0fb8ab5dedf886bb2a9f63a47
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBug-2208: pcc-mock configurable port numbers 12/15112/3
Milos Fabian [Tue, 10 Feb 2015 09:49:34 +0000 (10:49 +0100)]
Bug-2208: pcc-mock configurable port numbers

-input arguments "--local-address" and "--remote-address"
can now handle parameter in form "<IPAddress:PortNumber>"
The port number can be omitted - deafult values are used.
Default remote port number is 4189 and local is 0.

Change-Id: I18ef3c75c07743b919fb8fcca757746e44998287
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoMerge "Bug-2250: pcc-mock support TCP MD5"
Dana Kutenicsova [Tue, 17 Feb 2015 12:57:16 +0000 (12:57 +0000)]
Merge "Bug-2250: pcc-mock support TCP MD5"

9 years agoMerge "Bug-2208: pcc-mock code refactoring"
Dana Kutenicsova [Tue, 17 Feb 2015 12:56:20 +0000 (12:56 +0000)]
Merge "Bug-2208: pcc-mock code refactoring"

9 years agoUse readUnsignedByte instead of readByte and typecast. 71/15371/1
Dana Kutenicsova [Mon, 16 Feb 2015 16:56:39 +0000 (17:56 +0100)]
Use readUnsignedByte instead of readByte and typecast.

- gets rid of UnsignedBytes import in most cases
- will be followed up by cleaning up readByte()

Change-Id: I98846e2b71c4724ef978e5681d9b6e71405d1a1d
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoRemove check for empty lists, where not needed. 69/15369/1
Dana Kutenicsova [Mon, 16 Feb 2015 16:07:04 +0000 (17:07 +0100)]
Remove check for empty lists, where not needed.

- fixed communities tests

Change-Id: I232bb411f56b06fb2711b268587e3213039223a3
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoReplaced slice() with readSlice() where appropriate. 60/15360/3
Dana Kutenicsova [Mon, 16 Feb 2015 12:14:15 +0000 (13:14 +0100)]
Replaced slice() with readSlice() where appropriate.

- reduces the need to move readerIndex manually

Change-Id: I3cfe1f0d9e64a0efd7a71db02dacbe40d79eaaaa
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBug-2250: pcc-mock support TCP MD5 11/15111/5
Milos Fabian [Tue, 10 Feb 2015 08:37:05 +0000 (09:37 +0100)]
Bug-2250: pcc-mock support TCP MD5

-new input argument "--password <string>"
-when password is omitted, plain tcp is used

Change-Id: I973ac455be1fe093a129dc065bd1d6a28bc3dfe4
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoMerge "BUG-2571 : added parser/serializer for flowspec NLRI"
Robert Varga [Sun, 15 Feb 2015 16:06:22 +0000 (16:06 +0000)]
Merge "BUG-2571 : added parser/serializer for flowspec NLRI"

9 years agoBug-2208: pcc-mock code refactoring 70/15070/5
Milos Fabian [Mon, 9 Feb 2015 14:37:35 +0000 (15:37 +0100)]
Bug-2208: pcc-mock code refactoring

-removed unnecessary code
-switched to use immediate reconnecting strategy
-refactored client dispatcher and main class
-improved junit tests

Change-Id: I3d44ad88a5bf81212443bd0079ad82719e367b1c
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBUG-608 : implemented parsers/serializers for 40/15340/1
Dana Kutenicsova [Fri, 13 Feb 2015 15:13:28 +0000 (16:13 +0100)]
BUG-608 : implemented parsers/serializers for
- SrAlgorithm
- SrCapabilities

Change-Id: I9dd5bf14f12238a64981a2f78b7a41689ab73426
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-608 : additional rework of models 47/15247/2
Dana Kutenicsova [Fri, 13 Feb 2015 11:44:07 +0000 (12:44 +0100)]
BUG-608 : additional rework of models

Change-Id: I19b4e1fb605bcfc5dbc9c3956711a38ede2c53a3
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoMigrate Objects->MoreObjects 33/15333/1
Robert Varga [Sat, 14 Feb 2015 22:25:17 +0000 (23:25 +0100)]
Migrate Objects->MoreObjects

This future-proofs our codebase as Guava have moved the helper to
MoreObjects.

Change-Id: I02651171981c243c2cf95417d8dd2b2bc92e876c
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoUpdate to conform with guava 18 32/15332/2
Robert Varga [Sat, 14 Feb 2015 21:44:10 +0000 (22:44 +0100)]
Update to conform with guava 18

Stopwatch instantiation has changed, so adjust accordingly.

Change-Id: I97800f17c0af3dad038b07c6aa393c44fd9f80ee
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoDo not override plugins from odlparent 96/15296/2
Robert Varga [Fri, 13 Feb 2015 22:29:16 +0000 (23:29 +0100)]
Do not override plugins from odlparent

These plugins are already defined in odlparent.

Change-Id: I53eda9fe25b08d1045a38675f268a1889c8aa83b
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoRemove unused properties 95/15295/2
Robert Varga [Fri, 13 Feb 2015 22:24:08 +0000 (23:24 +0100)]
Remove unused properties

We do not use these properties anywhere -- just remove them.

Change-Id: I699e99ce8a1e4753b8fcbf6dc55f256391eac1d2
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoMigrate to using features-parent 91/15291/2
Robert Varga [Fri, 13 Feb 2015 21:51:43 +0000 (22:51 +0100)]
Migrate to using features-parent

odlparent gives us a convenience parent, so let's use it.

Change-Id: I57c20ce1d1ade81c7d6ae3b0c6fa82eff49ae44c
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoMove features 88/15288/2
Robert Varga [Fri, 13 Feb 2015 21:37:27 +0000 (22:37 +0100)]
Move features

this moves the features artifact to the standardized place.

Change-Id: I0b4e9d82c51c46f742f3de5f1de46ba0cfe475d5
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoRemove unneeded dependencyManagement sections 87/15287/2
Robert Varga [Fri, 13 Feb 2015 21:41:19 +0000 (22:41 +0100)]
Remove unneeded dependencyManagement sections

All these are inherited from the artifacts artifact, so should no longer
be needed.

Change-Id: I9154403b2d69df0e47f146738c8d3da1ae3f8ff1
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoRemove legacy eclipse project 86/15286/1
Robert Varga [Fri, 13 Feb 2015 21:43:14 +0000 (22:43 +0100)]
Remove legacy eclipse project

The project has been moved, so we do not need this file anymore.

Change-Id: I7be269a78dbe4775c02fd37bc9a838d41f2ab0a2
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoRework project structure 75/13475/9
Dana Kutenicsova [Tue, 9 Dec 2014 10:04:41 +0000 (11:04 +0100)]
Rework project structure

- create an artifacts artifact
- move parent to standard place, renaming it
- rename top-level aggregator

Change-Id: I77f0ffca4bd660d993471719ad16b26bbf3fe936
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoMerge "Added synchronized to close()."
Robert Varga [Fri, 13 Feb 2015 10:27:08 +0000 (10:27 +0000)]
Merge "Added synchronized to close()."

9 years agoMerge "BUG-608 : added prefix-sid tlv - added another revision of linkstate to includ...
Robert Varga [Fri, 13 Feb 2015 10:26:02 +0000 (10:26 +0000)]
Merge "BUG-608 : added prefix-sid tlv - added another revision of linkstate to include SR - changed imports of linkstate"

9 years agoMerge "BUG-2708 : fixed failing tests"
Robert Varga [Fri, 13 Feb 2015 09:59:12 +0000 (09:59 +0000)]
Merge "BUG-2708 : fixed failing tests"

9 years agoAdded synchronized to close(). 45/15245/1
Dana Kutenicsova [Fri, 13 Feb 2015 09:41:32 +0000 (10:41 +0100)]
Added synchronized to close().

Change-Id: Ie975458b918dd17dd7e2a0e4fb52edc0cc577904
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-2708 : fixed failing tests 43/15243/1
Dana Kutenicsova [Fri, 13 Feb 2015 09:15:03 +0000 (10:15 +0100)]
BUG-2708 : fixed failing tests

Change-Id: I7b3516d39d80dabf568e0d52122c2730f65163c6
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoPCEP add-lsp RPC: propagate TLVs from input to initiate message. 41/15241/2
Milos Fabian [Thu, 12 Feb 2015 09:07:32 +0000 (10:07 +0100)]
PCEP add-lsp RPC: propagate TLVs from input to initiate message.

Change-Id: Iaf9d010f178feec90f349e389c5b8f39bc2cba19
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit 6b884d7bdc4427036f37ce01721458ee87c0168c)

9 years agoMerge "Remove repositories declaration"
Dana Kutenicsova [Fri, 13 Feb 2015 08:21:17 +0000 (08:21 +0000)]
Merge "Remove repositories declaration"

9 years agoRemove repositories declaration 18/15218/1
Robert Varga [Thu, 12 Feb 2015 21:22:11 +0000 (22:22 +0100)]
Remove repositories declaration

This has moved to settings.xml, so let's remove it. Building without a
custom settings.xml will no longer work.

Change-Id: I7986ad598ceabb6475fd7e7a87a02cde1d39dcc0
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBug 2227 - RFC7311 Parser/Serializer 86/15186/3
Ladislav Borak [Thu, 12 Feb 2015 09:03:05 +0000 (10:03 +0100)]
Bug 2227 - RFC7311 Parser/Serializer

- added parser and serializer for Aigp attribute

- added transformation utility class, which transform bytebuffer to
  instance of Aigp and vice versa.

- added test for parsing and serializing aigp attribute

Change-Id: Idbf67c1baddf3abe8132f1bd0936fe0360a92c90
Signed-off-by: Ladislav Borak <lborak@cisco.com>
9 years agoBug 2227 - API for RFC7311 85/15185/9
Ladislav Borak [Thu, 12 Feb 2015 08:47:12 +0000 (09:47 +0100)]
Bug 2227 - API for RFC7311

- added new metric into network_concepts.yang

- added new path attribute represents AIGP into bgp_message.yang

Change-Id: Ie82066f1bc7f7cb241438a80ac21ecfd57b5763d
Signed-off-by: Ladislav Borak <lborak@cisco.com>
9 years agoBUG-2571 : added parser/serializer for flowspec NLRI 39/14639/7
Dana Kutenicsova [Fri, 30 Jan 2015 17:08:16 +0000 (18:08 +0100)]
BUG-2571 : added parser/serializer for flowspec NLRI

Change-Id: I42a59f81a3d9023768f6ae526b5e15463d4b40f1
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoFix integration tests after sal-dom-broker change 88/15188/1
Robert Varga [Thu, 12 Feb 2015 09:22:52 +0000 (10:22 +0100)]
Fix integration tests after sal-dom-broker change

Upstream has pulled in LMAX disruptor into dependencies, so we need to
add these, too.

Change-Id: I56c25ee0f8902e9e8aab78a0d22302e8b7b66107
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoDisable to create duplicate (with same IP Address) PCEP sessions. 64/14964/4
Milos Fabian [Wed, 10 Dec 2014 15:21:54 +0000 (16:21 +0100)]
Disable to create duplicate (with same IP Address) PCEP sessions.

Moved duplicate session handling into AbstractSessionNegtiatorFactory (PCEPPeerRegistry),
to be usable for all session negotiators created by. PCEPPeerRegistry also handle session-id caching.

Session ref. entries stored in bi-map were identifed by byte array (raw IP Address of client),
casuing that already existing session in bi-map were not look-up properly => allowing to create duplicate sessions.
Changed type of bi-map's key to wrapper of byte array.

Fixed also removing of session refs. from map on channel close. Turned bi-map to map, since inverse map is not used anymore.

pcc-mock is reusing this code - need to create session negotiator factory per pcc.

Change-Id: I85670b083b6ea832f8b9a4891c812845174f03ff
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBUG-608 : added prefix-sid tlv 08/15108/1
Dana Kutenicsova [Tue, 10 Feb 2015 14:09:48 +0000 (15:09 +0100)]
BUG-608 : added prefix-sid tlv
- added another revision of linkstate to include SR
- changed imports of linkstate

Change-Id: I9f8db2172cccf07aedaecc581eeacefd72ea208a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoMerge "Do not redefine dependencies from odlparent"
Dana Kutenicsova [Tue, 10 Feb 2015 08:24:19 +0000 (08:24 +0000)]
Merge "Do not redefine dependencies from odlparent"

9 years agoDo not redefine dependencies from odlparent 06/14906/2
Robert Varga [Thu, 5 Feb 2015 09:57:14 +0000 (10:57 +0100)]
Do not redefine dependencies from odlparent

These are already mentioned in odlparent, no need to repeat them here.

Change-Id: I1e78d3debbe74d2b5e6ca331d53a4dc3ff6113c3
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBug-2229: RFC6286 - AS-wide Unique BGP Identifier 85/14685/7
Milos Fabian [Tue, 3 Feb 2015 15:15:41 +0000 (16:15 +0100)]
Bug-2229: RFC6286 - AS-wide Unique BGP Identifier

-extended Connection Collision Resolution
https://tools.ietf.org/html/rfc6286#section-2.3
-if BGP identifiers are same, compare AS numbers

-modified Open Message Error Handling
https://tools.ietf.org/html/rfc6286#section-2.2
-if BGP Identifier of local and remote speaker is the same -
return error "Bad BGP Identifier"

Change-Id: Idcf18390129805c2b78cf6070ba47f3d4ab0e9d0
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoCreate client dispatcher for testing. 31/14831/5
Milos Fabian [Wed, 4 Feb 2015 15:10:35 +0000 (16:10 +0100)]
Create client dispatcher for testing.

-allows client to be binded to specified IP address

Change-Id: I1f665e30ed452ec672f16c7b3a39ca9a2e42706a
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBug-2631 - Fixed BGP connection collision detection 84/14684/4
Milos Fabian [Tue, 3 Feb 2015 14:30:20 +0000 (15:30 +0100)]
Bug-2631 - Fixed BGP connection collision detection

-have to examine all connections, in OpenConfirm state
-before, only fully established connections were examined
-connections are kept in map
-remove connection from map, when session goes down
-avoids https://bugs.opendaylight.org/show_bug.cgi?id=2109
-brings dependency of BGPSessionImpl on BGPPeerRegistry
-fixed bgp-identifier conversion to long

Change-Id: I700e8e5a0fb0874731ab2fe013cd7853e44428da
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoMerge "BUG-608 : initial segment routing model for BGP"
Robert Varga [Sun, 8 Feb 2015 21:06:14 +0000 (21:06 +0000)]
Merge "BUG-608 : initial segment routing model for BGP"

9 years agoBUG-608 : initial segment routing model for BGP 80/14980/1
Dana Kutenicsova [Fri, 6 Feb 2015 15:59:19 +0000 (16:59 +0100)]
BUG-608 : initial segment routing model for BGP

Change-Id: Id364a1e4255f6d0604b0ff66f51da0c1799167f0
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBug-2208: Added ability to configure keepalive and deadtimer 63/14963/1
Milos Fabian [Mon, 8 Dec 2014 13:51:47 +0000 (14:51 +0100)]
Bug-2208: Added ability to configure keepalive and deadtimer

-d, --deadtimer <0..255> (optional, default 120) - DeadTimer value in seconds
-ka, --keepalive <0.255> (optional, deafult 30) - KeepAlive timer value in seconds

Change-Id: I1fcc983f96793853d719ed8c5aaa241e848801b4
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBug-2208: Mocked PCC can connect to multiple PCEs. 82/12782/4
Milos Fabian [Wed, 12 Nov 2014 13:02:46 +0000 (14:02 +0100)]
Bug-2208: Mocked PCC can connect to multiple PCEs.

-input argument "--remote-address" can handle multiple
ip addresses (separated by comma).

Change-Id: I9e32781b9ced77d6351b4d681ed7677e357b039e
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBug-2208: On session-up reported LSPs have one hop path. 62/14962/1
Milos Fabian [Thu, 16 Oct 2014 15:30:56 +0000 (17:30 +0200)]
Bug-2208: On session-up reported LSPs have one hop path.

-all reported LSPs have common tunnel endpoint + one hop path (ERO with one ipv4-prefix subobject)

Change-Id: Ib358bccce79e4e41020dddecfcf5476c010fc8fe
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBUG-2571 : added flowspec to features 90/14890/2
Dana Kutenicsova [Thu, 5 Feb 2015 07:08:25 +0000 (08:08 +0100)]
BUG-2571 : added flowspec to features

Change-Id: I1f520e8592ac9ca955b8817637e0fd7f8fc275dd
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-2228 : modified best path selection algorithm according to RFC5004 77/14777/1
Dana Kutenicsova [Tue, 3 Feb 2015 12:50:57 +0000 (13:50 +0100)]
BUG-2228 : modified best path selection algorithm according to RFC5004

Change-Id: Iaf5a95487eef5060da253c2153086540216d016c
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoAdd prefixForByteBuf method to util. 38/14638/2
Dana Kutenicsova [Fri, 30 Jan 2015 17:07:48 +0000 (18:07 +0100)]
Add prefixForByteBuf method to util.

Change-Id: Iad68714b97074d71aa7051860e5d1f5af32da48a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-2571 - added parsers for new Extended Communities 12/14512/5
Dana Kutenicsova [Mon, 26 Jan 2015 16:50:50 +0000 (17:50 +0100)]
BUG-2571 - added parsers for new Extended Communities

Change-Id: I7bbf4f3d47164e8eaccd72f97e41703df51c4539
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoRework of extended communities. 11/14511/5
Dana Kutenicsova [Mon, 26 Jan 2015 16:34:51 +0000 (17:34 +0100)]
Rework of extended communities.

- moved parsing/serializing of the header to separate methods
- switch to use ByteBufWriteUtil
- rewritten tests to be more clear

Change-Id: Ibc7ba4d7d54c80b9f7c2f59b96172c29a3b318c4
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-2571 : initial model for BGP flow specification 84/14184/5
Dana Kutenicsova [Mon, 26 Jan 2015 12:43:59 +0000 (13:43 +0100)]
BUG-2571 : initial model for BGP flow specification

Change-Id: I33c73bda31dfe18101802ff0db6e0fa2e6e994fb
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-2225 : upgraded docs to new draft version. 18/14218/2
Dana Kutenicsova [Sun, 18 Jan 2015 21:21:22 +0000 (22:21 +0100)]
BUG-2225 : upgraded docs to new draft version.

Change-Id: I5d02da38279edf5ee2d26fa1d19660782a274b6f
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoMerge "Bug-2225 Update PCEP segment routing according draft version 00."
Robert Varga [Thu, 22 Jan 2015 18:42:11 +0000 (18:42 +0000)]
Merge "Bug-2225 Update PCEP segment routing according draft version 00."

9 years agoBUG-2475: Fix keepalives not being sent 80/14380/2
Robert Varga [Thu, 22 Jan 2015 14:17:38 +0000 (15:17 +0100)]
BUG-2475: Fix keepalives not being sent

As it turns out, we failed to update channel configuration when MD5 keys
were not specified.

Change-Id: I5c2a5983c0797d032bb058974aac82254b554041
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBug-2225 Update PCEP segment routing according draft version 00. 16/13716/8
Milos Fabian [Fri, 5 Dec 2014 09:27:28 +0000 (10:27 +0100)]
Bug-2225 Update PCEP segment routing according draft version 00.

reference: http://tools.ietf.org/html/draft-ietf-pce-segment-routing-00

-removed "02" suffix from package names, class names and yang filed
-added SR RRO Subobject model, parser/serializer and tests
-added new PCEP errors
-removed unnecessary PCEP messages extensions
-removed F and S flags from Subobject model - can be determined from context

Change-Id: Iac566fea7b3f74e0bd61341306ac5a5e46bbf15e
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoOptimize AsPath lists 38/14338/2
Robert Varga [Wed, 21 Jan 2015 14:45:11 +0000 (15:45 +0100)]
Optimize AsPath lists

Tracing on 500K routes has shown we waste about 35MB of memory in sparse
arrays. It turns out that we fail to size ArrayLists properly when
allocating AsPaths: in case of attribute, we can trimToSize(), in case
of individual segments we know the right size beforehand.

Change-Id: Ie25610b9f04e57c6659b69b65f20299c5cb10881
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoFix a potential deadlock in BGPSession 39/14339/1
Robert Varga [Wed, 21 Jan 2015 15:17:49 +0000 (16:17 +0100)]
Fix a potential deadlock in BGPSession

In a two-session scenario, it is possible to arrive at a ABBA deadlock,
where we acquire locks:

Thread 1      Thread 2
--------      --------
Session A     Session B

RIB
              RIB <-- blocks waiting for Thread 1

Session B <-- blocks waiting for Thread 2

The lock is being held only for scheduling a task on Thread 2, which a
thread-safe operation, so we can simply remove the need to take the lock
in Thread 1.

Change-Id: I4e55d3228a48790b2f19eef12ce1b54fd57955a0
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoFixed synchronization. 93/14293/2
Dana Kutenicsova [Tue, 20 Jan 2015 15:12:20 +0000 (16:12 +0100)]
Fixed synchronization.

Change-Id: I2ae6bcaddfac6fd7555a8b418542cb4f5417f7a1
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoMerge "Fix build breakage after controller API change"
Robert Varga [Tue, 20 Jan 2015 18:32:41 +0000 (18:32 +0000)]
Merge "Fix build breakage after controller API change"

9 years agoFix build breakage after controller API change 98/14298/1
Robert Varga [Tue, 20 Jan 2015 16:17:05 +0000 (17:17 +0100)]
Fix build breakage after controller API change

Just add a canReuse() method.

Change-Id: I142dbf8c304a63ad8f00ec0ea660724721598ca7
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoMerge "BUG-1025 : Moved log level of unrecognized attribute in BGP to WARN."
Robert Varga [Tue, 20 Jan 2015 13:55:54 +0000 (13:55 +0000)]
Merge "BUG-1025 : Moved log level of unrecognized attribute in BGP to WARN."

9 years agoFix unsynchronized access to TransactionChain 85/14285/1
Robert Varga [Tue, 20 Jan 2015 12:08:54 +0000 (13:08 +0100)]
Fix unsynchronized access to TransactionChain

The background resynchronization task instantiated transactions without
holding RIBImpl lock, leading to:

Exception in thread "Thread-29" java.lang.IllegalStateException: Previous transaction DOM-OPER-1298 is not ready yet
        at com.google.common.base.Preconditions.checkState(Preconditions.java:176)
        at org.opendaylight.controller.md.sal.dom.store.impl.DOMStoreTransactionChainImpl$Allocated.getSnapshot(DOMStoreTransactionChainImpl.java:68)
        at org.opendaylight.controller.md.sal.dom.store.impl.DOMStoreTransactionChainImpl.getSnapshot(DOMStoreTransactionChainImpl.java:111)
        at org.opendaylight.controller.md.sal.dom.store.impl.DOMStoreTransactionChainImpl.newReadWriteTransaction(DOMStoreTransactionChainImpl.java:131)
        at org.opendaylight.controller.md.sal.dom.broker.impl.AbstractDOMForwardedTransactionFactory.newReadWriteTransaction(AbstractDOMForwardedTransactionFactory.java:206)
        at org.opendaylight.controller.md.sal.dom.broker.impl.PingPongTransactionChain.slowAllocateTransaction(PingPongTransactionChain.java:127)
        at org.opendaylight.controller.md.sal.dom.broker.impl.PingPongTransactionChain.allocateTransaction(PingPongTransactionChain.java:144)
        at org.opendaylight.controller.md.sal.dom.broker.impl.PingPongTransactionChain.newReadWriteTransaction(PingPongTransactionChain.java:295)
        at org.opendaylight.controller.md.sal.dom.broker.impl.PingPongTransactionChain.newWriteOnlyTransaction(PingPongTransactionChain.java:326)
        at org.opendaylight.controller.md.sal.binding.impl.BindingTranslatedTransactionChain.newWriteOnlyTransaction(BindingTranslatedTransactionChain.java:77)
        at org.opendaylight.protocol.bgp.rib.impl.RIBImpl$1.run(RIBImpl.java:125)
        at java.lang.Thread.run(Thread.java:745)

Change-Id: I8b5b34f313dbd1b2584ea73aef37fb6e5c6b5120
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-1025 : Moved log level of unrecognized attribute in BGP to WARN. 79/14279/1
Dana Kutenicsova [Tue, 20 Jan 2015 09:12:32 +0000 (10:12 +0100)]
BUG-1025 : Moved log level of unrecognized attribute in BGP to WARN.

Change-Id: I84a9e252b78407fb9ec091af02805d996b13d374
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoMerge "Removed rib dependency on linkstate."
Robert Varga [Fri, 16 Jan 2015 14:08:02 +0000 (14:08 +0000)]
Merge "Removed rib dependency on linkstate."

9 years agoMerge "Bug-2226: RFC5886 - Messages parsers/serializers"
Robert Varga [Fri, 16 Jan 2015 14:07:39 +0000 (14:07 +0000)]
Merge "Bug-2226: RFC5886 - Messages parsers/serializers"

9 years agoMerge "Refactor linkstate."
Robert Varga [Fri, 16 Jan 2015 14:05:47 +0000 (14:05 +0000)]
Merge "Refactor linkstate."

9 years agoMerge "Bug 868: Replaced use of toInstance() for build()."
Dana Kutenicsova [Fri, 16 Jan 2015 13:54:41 +0000 (13:54 +0000)]
Merge "Bug 868: Replaced use of toInstance() for build()."

9 years agoRefactor linkstate. 99/13799/10
Dana Kutenicsova [Tue, 25 Nov 2014 15:34:44 +0000 (16:34 +0100)]
Refactor linkstate.

- split LinkstateAttributeParser to Node/Link/Prefix AttributeParser
- split LinkstateNlriParser to Node/Link/PrefixNlriParser
- moved constants from TlvCode to appropriate classes
- renamed TlvCode class to TlvUtil
- small improvements in the code

Change-Id: I9ce95ef9d704e9e2a183121c35ba5973d2ec308e
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoMerge "Set root pom.xml <name> for Sonar"
Dana Kutenicsova [Fri, 16 Jan 2015 09:45:49 +0000 (09:45 +0000)]
Merge "Set root pom.xml <name> for Sonar"

9 years agoBug-2226: RFC5886 - Messages parsers/serializers 17/12517/6
Milos Fabian [Tue, 28 Oct 2014 09:54:14 +0000 (10:54 +0100)]
Bug-2226: RFC5886 - Messages parsers/serializers

-new messages PCMonReq and PCMonRep parsers/serializers implementation
-extended PCReq and PCRep message parsers/serializer
-fixed and refactored PCReq message parser

Change-Id: I53081c1cdca7d8e0acedc24e25260f31f76032cd
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoBug 868: Replaced use of toInstance() for build(). 89/14189/1
Tony Tkacik [Fri, 16 Jan 2015 09:21:59 +0000 (10:21 +0100)]
Bug 868: Replaced use of toInstance() for build().

Change-Id: I55280880475f6011d5494dba30e4ac052c34b474
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoRemoved rib dependency on linkstate. 83/14183/2
Dana Kutenicsova [Fri, 16 Jan 2015 08:32:26 +0000 (09:32 +0100)]
Removed rib dependency on linkstate.

Change-Id: I179f13ceace2a65c299ca657ebfb63ded6e7040f
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoMerge "Bug-2225: Move Path Setup Type TLV to base PCEP"
Robert Varga [Wed, 14 Jan 2015 16:42:43 +0000 (16:42 +0000)]
Merge "Bug-2225: Move Path Setup Type TLV to base PCEP"

9 years agoRemove deprecated BindingAwareProvider methods 26/14126/3
Ed Warnicke [Tue, 13 Jan 2015 15:14:37 +0000 (09:14 -0600)]
Remove deprecated BindingAwareProvider methods

https://git.opendaylight.org/gerrit/#/c/13806/

will remove deprecated BindingAwareProvider methods.
This patch simply removes them from
implmementation of that interface so when 13806 is
merged we can merge this to fix.

Change-Id: I8606df504c491b1167224b6f4d61dd6c2efb3af4
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoBug-2225: Move Path Setup Type TLV to base PCEP 15/13715/4
Milos Fabian [Thu, 4 Dec 2014 10:14:04 +0000 (11:14 +0100)]
Bug-2225: Move Path Setup Type TLV to base PCEP

-moved PST TLV yang model to pcep-types.yang
-added to RP Object TLV container
-added to SRP Object TLV container in stateful07
-moved/updated parsers/serializers according to changes in model
-segment routnig extends PST TLV parser/serializer - can handle PST=1
-added PST TLV as input argument in addLsp and updateLsp
-addLsp - optional for RSVP-TE, resp. PST TLV is omitted in message when PST=0; must be present for SR
-updateLsp - if present, use PST TLV defined in input argument; otherwise use stored one.
-LSP can be migrated from RSVP-TE to SR-TE and vice-versa -> PST TLV must be explicitly included in input args.
-removeLsp - stored PST TLV is used
-PST TLV is exposed in pcep-topology - if present in report message

-motivation:
-get rid of ugly augmentations in segment-routing
-get rid of hacking (adding PST TLV) in PCEP SR messages serializer

-reference: https://tools.ietf.org/html/draft-sivabalan-pce-lsp-setup-type-02

Change-Id: Id6e099fe5bb55e7436c7e89df4821a547ed065b8
Signed-off-by: Milos Fabian <milfabia@cisco.com>
9 years agoSet root pom.xml <name> for Sonar 70/14070/1
Thanh Ha [Fri, 9 Jan 2015 21:53:41 +0000 (16:53 -0500)]
Set root pom.xml <name> for Sonar

As mentioned on the mailing list Sonar uses the <name> field of the
pom.xml that is passed to the mvn command as the name of the project in
Sonar. In most cases this is the root pom.xml file in a project. This
patch sets the name to the project shortname.

https://lists.opendaylight.org/pipermail/discuss/2014-November/004024.html

Change-Id: Ib41a4bf3539149b81023ad857d0d0136f885e55a
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
9 years agoMerge "BUG-2568 : fixed generated EORs"
Robert Varga [Fri, 9 Jan 2015 16:12:59 +0000 (16:12 +0000)]
Merge "BUG-2568 : fixed generated EORs"

9 years agoAvoid NPE when PCC node was cleaned up from the topology. 18/14018/1
Dana Kutenicsova [Fri, 9 Jan 2015 14:51:55 +0000 (15:51 +0100)]
Avoid NPE when PCC node was cleaned up from the topology.

Change-Id: I9a232dba0726517f09f2ae0945910e989e8ecaab
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-2568 : fixed generated EORs 90/13990/2
Dana Kutenicsova [Thu, 8 Jan 2015 12:50:11 +0000 (13:50 +0100)]
BUG-2568 : fixed generated EORs

Change-Id: I225b8aa7a1741f7c472715567e6157df42b6d69f
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoMerge "Added forgotten SLRG attribute to linkstate-topology output."
Robert Varga [Thu, 8 Jan 2015 13:44:30 +0000 (13:44 +0000)]
Merge "Added forgotten SLRG attribute to linkstate-topology output."

9 years agoUse mdsal-artifacts for dependencies 55/13755/3
Robert Varga [Mon, 1 Dec 2014 16:42:41 +0000 (17:42 +0100)]
Use mdsal-artifacts for dependencies

Instead of declaring them manually, use the exported artifacts.

Change-Id: Ia38931fbfc1aff14a4284078a796c9cb61f31177
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoAdded forgotten SLRG attribute to linkstate-topology output. 57/13957/3
Dana Kutenicsova [Wed, 7 Jan 2015 09:34:41 +0000 (10:34 +0100)]
Added forgotten SLRG attribute to linkstate-topology output.

Change-Id: I5c19cb5f60a4955f1e1f5ad16aec3067401a93d0
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoRemove references to xtend-lib-osgi 60/13960/2
Robert Varga [Wed, 7 Jan 2015 12:32:01 +0000 (13:32 +0100)]
Remove references to xtend-lib-osgi

This library is no longer needed (and no longer exported from
yangtools), so remove any and all references to it.

Change-Id: I80bff551e29cb66ed4d767d44f6f03efe5d2cf4e
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-196 : support graceful restart 81/13181/4
Dana Kutenicsova [Sat, 15 Nov 2014 15:20:54 +0000 (16:20 +0100)]
BUG-196 : support graceful restart

- rework parser/serializer for capability
- from now on, bgp peer is sending graceful restart
capability by default, to increase speed of synchronization

Change-Id: Ida62710ff505288bff48d6d78faf5142b7a43db5
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoMerge "Introducing method byteBufForAddress."
Robert Varga [Wed, 24 Dec 2014 12:49:51 +0000 (12:49 +0000)]
Merge "Introducing method byteBufForAddress."

9 years agoMerge "Fixed version warnings in pom files."
Robert Varga [Wed, 24 Dec 2014 12:49:13 +0000 (12:49 +0000)]
Merge "Fixed version warnings in pom files."

9 years agoMerge "Added key to list of advertized tables to be compliant with 6020."
Robert Varga [Wed, 24 Dec 2014 12:48:10 +0000 (12:48 +0000)]
Merge "Added key to list of advertized tables to be compliant with 6020."

9 years agoFixed version warnings in pom files. 37/13837/1
Dana Kutenicsova [Tue, 23 Dec 2014 21:41:01 +0000 (22:41 +0100)]
Fixed version warnings in pom files.

Change-Id: I7b13a07e74cf4f10f12021edc804a585e975c902
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoMerge "Split out RIBEntry"
Dana Kutenicsova [Tue, 23 Dec 2014 16:39:46 +0000 (16:39 +0000)]
Merge "Split out RIBEntry"

9 years agoIntroducing method byteBufForAddress. 98/13798/4
Dana Kutenicsova [Sat, 22 Nov 2014 15:51:43 +0000 (16:51 +0100)]
Introducing method byteBufForAddress.

Change-Id: I7494a20ea464a35553895076402298a63631abb7
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoAdded key to list of advertized tables to be compliant with 6020. 92/13592/2
Dana Kutenicsova [Fri, 12 Dec 2014 12:13:04 +0000 (13:13 +0100)]
Added key to list of advertized tables to be compliant with 6020.

Change-Id: I24f37cadad003de8f27c51eea0d0e5ec70a1bd74
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
(cherry picked from commit c3aadd1f5006b0c477396039a873dd2b03e66741)

9 years agoMerge changes Ia42de3cd,Iae8be8b9
Dana Kutenicsova [Tue, 23 Dec 2014 16:10:25 +0000 (16:10 +0000)]
Merge changes Ia42de3cd,Iae8be8b9

* changes:
  The set of local tables should always be a Set
  Improve documentation

9 years agoMerge changes I8c9c6038,I7d340c4d
Robert Varga [Tue, 23 Dec 2014 15:19:44 +0000 (15:19 +0000)]
Merge changes I8c9c6038,I7d340c4d

* changes:
  Bug-2226: RFC5886 - New objects parsers/seriazers
  Bug-2226: RFC5886 yang model

9 years agoSplit out RIBEntry 32/13832/2
Robert Varga [Tue, 23 Dec 2014 00:38:23 +0000 (01:38 +0100)]
Split out RIBEntry

Change-Id: Ifccb24128ebb32172ada1cc61d8e3bc2c593270c
Signed-off-by: Robert Varga <rovarga@cisco.com>