Arunprakash D [Thu, 16 Apr 2020 07:15:06 +0000 (07:15 +0000)]
Merge "OPNFLWPLUG-1087: ODL controller to provide view of openflow node reconciliation status"
Somashekhar Javalagi [Tue, 31 Mar 2020 07:21:34 +0000 (12:51 +0530)]
MDSAL API migration changes
Desc: List of MdSAL API migration changes.
Signed-off-by: Somashekhar Javalagi <somashekhar.manohara.javalagi@ericsson.com>
Change-Id: I857c25b6bfcfe80160f735bac91746d113c844f3
Signed-off-by: dheenadayalan b <dhinua@gmail.com>
dheenadayalan b [Mon, 24 Feb 2020 10:02:56 +0000 (15:32 +0530)]
OPNFLWPLUG-1087: ODL controller to provide view of openflow node reconciliation status
Signed-off-by: dheenadayalan b <dhinua@gmail.com>
Change-Id: Ibf3e02fe4352a2bd559b838f8788ca18bc2ab83d
Signed-off-by: dheenadayalan b <dhinua@gmail.com>
Arunprakash D [Thu, 2 Apr 2020 04:46:43 +0000 (04:46 +0000)]
Merge "Reduce use of deprecated constructors"
Robert Varga [Wed, 25 Mar 2020 21:49:31 +0000 (22:49 +0100)]
Use Magnesium controller
As part of controller transition to being MRI, downgrade the version
used to Magnesium release. This will be bumped to Aluminium proper
during the MRI window.
Change-Id: Idffaea187f9913b7107c26c03410ea6033c21578
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 25 Feb 2020 11:19:27 +0000 (12:19 +0100)]
Reduce use of deprecated constructors
Integer-based constructors are deprecated, this adds a dent to
remove their usage.
Change-Id: I3125796dd8b2f12d43a7c491ea34bdc799fdf649
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
VenkataSatya Jonnadula [Thu, 5 Mar 2020 07:30:58 +0000 (13:00 +0530)]
OPNFLWPLUG-1083: Stats frozen after applying 2 sec delay in OF channel
Signed-off-by: VenkataSatya Jonnadula <rsankar@luminanetworks.com>
Change-Id: Ie7fa92f2307ac5751f0c14133d582262f1c46f89
dheenadayalan b [Thu, 27 Feb 2020 08:43:44 +0000 (14:13 +0530)]
OPNFLWPLUG-1085: Switch-idle events weren't consumed by inbound handler during read time-out,
hence moved idle handler above inbound handler from end of channel pipeline
desc: Reverting the changes provided for OPNFLWPLUG-1039, by moving idle handler above the inbound handler
within channel pipeline, as the switchidle event message are fired after channel messages are consumed.
Signed-off-by: dheenadayalan b <dhinua@gmail.com>
Change-Id: I1c1a2306eb298ba72aad2480a8f34fa6affa9a28
Signed-off-by: dheenadayalan b <dhinua@gmail.com>
Arunprakash D [Fri, 28 Feb 2020 06:45:13 +0000 (06:45 +0000)]
Merge "OPNFLWPLUG-1086: Reconciliation framework failure when starting cbench tool for the first time"
Gobinath [Thu, 27 Feb 2020 05:54:41 +0000 (11:24 +0530)]
OPNFLWPLUG-1086: Reconciliation framework failure when starting cbench tool for the first time
Issue:
CSIT job using cbench had consistent failure with the error message
starting starting with a "closed connection ... exiting" message.
The karaf logs indicated the switches getting disconnected because of
"reconciliation framework" failure.
Observation and Fix:
On analyzing the logs it was found that the "flownodereconciliation"
service of the reconciliation framework was throwing an uncaught
exception (ConcurrentModificationException) which had resulted in
the reconciliation framework failure.
This has been fixed and logs have been enhanced to debug similar issues.
Change-Id: I3cbcea2da32c342c83846f2041d82e921d7acf08
Signed-off-by: Gobinath <gobinath@ericsson.com>
(cherry picked from commit
1fdc1a25f9703550c678b4cd83188de26ad9b19d)
Robert Varga [Thu, 21 Feb 2019 10:46:00 +0000 (11:46 +0100)]
Rework MatchEntrySerializer
MatchEntrySerializer has a filter, which is being applied before
main serialization, and that is the only way it is being used --
we check if the match is present and if it is we run serialize().
This leads to quite a bit of code duplication as well as inefficient
execution, MatchSerializer performs two invocations and each of them
performs at least one traversal of the match.
Change matchTypeCheck() to serializeIfPresent(), which means
MatchSerializer does not invoke two method. This also allows us to
optimize the serialization process in AbstractMatchEntrySerializer
and its subclasses by traversing the match only once. This rework
makes it obvious that MatchEntrySerializer should not be an
OFSerializer, at all, as the inherited methods just confuse the
workflow.
Resulting code structure removes quite a bit of duplicated code
from the individual EntrySerializer classes and lends itself to
sharing functionality through common subclasses -- reducing the
number of possible method implementations at various places, thus
allowing better devirtualization and inlining.
The second part deals with the logic of serializing the header,
as all specific serializers have a constant header, which we can
easily precompute and emit with a single ByteBuf.writeInt() call.
Since external serializers have had the option to dynamically emit
a different header, this capability is retained via HeaderWriter
helper which is attached to each serializer. Since the number of
serializers is limited, this additional object poses little memory
overhead and is partially offset by the reduction of bytecode coming
from the elimination of oxmField/oxmClass/valueLength getters.
Because all our serializers have a constant length, we only provide
one concrete implementation of HeaderWriter, which is
ConstantHeaderWriter. Unless an additional implementation is provided
externally, this means that all header serialization calls are
readily devirtualized via CHA, thus the cost of this indirection
is zero.
JIRA: OPNFLWPLUG-1068
Change-Id: I49b7a3c5770e939d082db8479f6d70a689d4c944
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
VenkataSatya Jonnadula [Mon, 10 Feb 2020 08:56:03 +0000 (14:26 +0530)]
OPNFLWPLUG-1083: Stats frozen after applying 2 sec delay in OF channel
Signed-off-by: VenkataSatya Jonnadula <rsankar@luminanetworks.com>
Change-Id: I3a34ed327237ec2f765291cc45305683f561ae88
jenkins-releng [Sat, 22 Feb 2020 04:30:16 +0000 (04:30 +0000)]
Bump versions by x.y.(z+1)
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: Idcbd5dc14cae5925e588837bafb1abf1839b88ed
Somashekhar Javalagi [Wed, 12 Feb 2020 16:31:06 +0000 (22:01 +0530)]
OPNFLWPLUG-1074: table stats not available after a switch flap
Problem: csit test cases failing due to empty table stats
Root Casue: First time when table stats are collected, they
are written into operational inventory. But consequently at
the time of writing flow stats to datastore, table stats
transaction was still not complete. So when fow stats are
written with empty table stats which are read from
operational inventory
Fix: Collecting flow stats first followed by table stats,
which prevents overwrite of table stats.
Signed-off-by: Somashekhar Javalagi <somashekhar.manohara.javalagi@ericsson.com>
Change-Id: I39bf7ffe9b12a4d3a03efbec95f75dd1a0ef70f6
Arunprakash D [Sun, 16 Feb 2020 16:18:18 +0000 (16:18 +0000)]
Merge "OPNFLWPLUG-1084 Device operational is not getting created if device reconciliation is not enabled"
D Arunprakash [Fri, 14 Feb 2020 06:38:46 +0000 (12:08 +0530)]
Revert "All-dpns are not getting listed in the"
This reverts commit
566c4ac8fcd1feaa501955791790a247f3e69b07.
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
Change-Id: I6433cdb02d7cf875e9aa9c56bfa0f39ec3bdcc02
D Arunprakash [Fri, 14 Feb 2020 05:56:30 +0000 (11:26 +0530)]
Revert "Fix for DPNs not connecting to controller"
This reverts commit
6b6281680872611d795261dbf232c0131235bd51.
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
Change-Id: Id5ed63c59aeb4a3303f5f176d8ad82d6767a43ca
D Arunprakash [Fri, 14 Feb 2020 05:54:42 +0000 (11:24 +0530)]
Revert "CSC to provide a view of DPN re-sync"
This reverts commit
674bb50091db4628a50c08606f8f8b9f3c8a5e55.
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
Change-Id: I5d03f6175bd2ae9faeb5cdf248c5d15242ee4653
Shweta Chaturvedi [Thu, 7 Feb 2019 09:38:45 +0000 (15:08 +0530)]
CSC to provide a view of DPN re-sync
status from CLI
Change-Id: I6153f394803e43abf77e871f993d9ca7a1bedd45
Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
Somashekhar Javalagi [Wed, 28 Nov 2018 11:12:14 +0000 (16:42 +0530)]
Fix for DPNs not connecting to controller
Change-Id: If708df53a0102bb85fe0040b260f821b4d35773c
Signed-off-by: Somashekhar Javalagi <somashekhar.manohara.javalagi@ericsson.com>
Shweta Chaturvedi [Fri, 18 Oct 2019 11:32:10 +0000 (17:02 +0530)]
All-dpns are not getting listed in the
output of display all-dpns in cics
Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
Change-Id: Id4198d385fd636c5cedefbbf16a99b852ba36265
Robert Varga [Thu, 3 Oct 2019 13:28:31 +0000 (15:28 +0200)]
Optimize ReconcileUtil.safe*()
Node exposes nonnullTables() etc., which we can take advantage of
to simplify code.
Change-Id: Ifc53b8d9bc7898f23896ab0ca159fb4f4d1d73ef
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Arunprakash D [Wed, 5 Feb 2020 06:29:47 +0000 (06:29 +0000)]
Merge "Code refractor and logging improvements"
Arunprakash D [Wed, 5 Feb 2020 06:28:35 +0000 (06:28 +0000)]
Merge "Code Refractor and logging improvements"
Arunprakash D [Tue, 4 Feb 2020 09:33:07 +0000 (09:33 +0000)]
Merge "NETVIRT-1638 Modify yang modules such that it can be validated using pyang"
Shweta Chaturvedi [Mon, 5 Aug 2019 10:07:09 +0000 (15:37 +0530)]
Code refractor and logging improvements
Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
Change-Id: I0b03ed4aae82f11c3d6dbe266120d00653b4ee1d
Shweta Chaturvedi [Mon, 5 Aug 2019 07:12:12 +0000 (12:42 +0530)]
Code Refractor and logging improvements
Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
Change-Id: I85091cb808a35981c128d3f2194c15b17d92d85b
Shweta Chaturvedi [Tue, 21 Jan 2020 08:38:35 +0000 (14:08 +0530)]
OPNFLWPLUG-1084 Device operational is not getting created if
device reconciliation is not enabled
Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
Change-Id: I7d72c004d71a9b7f47c2eedc8a399bfa8547dde9
Nishchya Gupta [Thu, 16 Jan 2020 11:39:17 +0000 (17:09 +0530)]
NETVIRT-1638 Modify yang modules such that it can be validated using pyang
Fixing pyang warning and errors.
Signed-off-by: Nishchya Gupta <nishchyag@altencalsoftlabs.com>
Change-Id: Ic66aa4a4394b5b6132b4027e044da5b165e2912e
Shweta Chaturvedi [Mon, 20 May 2019 11:15:29 +0000 (16:45 +0530)]
Moving threadPool to a common place.
It was creating one threadPool for each connection
and failed to close it, now using common thread pool
for all the incoming dpn connections on 6653.
Change-Id: I60372c32c9e32f65f83eb678d741a12202702d52
Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
Robert Varga [Thu, 16 Jan 2020 21:13:28 +0000 (22:13 +0100)]
Bump to odlparent-6.0.4/yangtools-4.0.6/mdsal-5.0.9
Pick up latest fixes and upgrades.
Change-Id: I04d1232d8bff69d15436257a2e56ff60a4e2ecf8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 12 Dec 2019 07:05:04 +0000 (08:05 +0100)]
Bump odlparent/yangtools/mdsal to 6.0.3/4.0.3/5.0.6
Pick up the latest upgrades and fixes.
Change-Id: I6633200cb4a9895889f8627b8fea4cd93f052974
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Arunprakash D [Fri, 6 Dec 2019 10:11:36 +0000 (10:11 +0000)]
Merge "Failed to cancel service reconciliation, When controller become slave."
Shweta Chaturvedi [Tue, 26 Mar 2019 11:08:57 +0000 (16:38 +0530)]
Error log correction
Change-Id: Ie00ff4c3008aaf3fba2af4245f09c021195829c3
Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
Shweta Chaturvedi [Tue, 11 Jun 2019 03:45:45 +0000 (09:15 +0530)]
Avoid holding netty threads during resync callbacks
Change-Id: Ic6b78c053a9971b3be83ee1aa98f3ad822394c1b
Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
Arunprakash D [Mon, 2 Dec 2019 06:32:54 +0000 (06:32 +0000)]
Merge "Grep not working for Karaf commands"
Ning Zhang [Wed, 30 Oct 2019 10:01:57 +0000 (18:01 +0800)]
Read action throwing NPE
Issue Description:
When process alien action throwing NullPointerException:
java.lang.NullPointerException: null
at org.opendaylight.openflowplugin.openflow.md.core.extension.ActionExtensionHelper.processAlienAction(ActionExtensionHelper.java:46)
at org.opendaylight.openflowplugin.impl.protocol.deserialization.util.ActionUtil.readAction(ActionUtil.java:66)
Signed-off-by: Ning Zhang <zhangninglc@inspur.com>
Change-Id: I4008eef616bb08de9333442a4f21c3f21b12c65e
Arunprakash D [Mon, 25 Nov 2019 12:25:12 +0000 (12:25 +0000)]
Merge "OPNFLWPLUG-1078: Notify device TLS authentication failure messages"
Arunprakash D [Mon, 25 Nov 2019 12:25:00 +0000 (12:25 +0000)]
Merge "OPNFLWPLUG-1075: Making Device Oper transactions atomic"
VenkataSatya Jonnadula [Mon, 18 Nov 2019 14:22:24 +0000 (19:52 +0530)]
OPNFLWPLUG-1075: Making Device Oper transactions atomic
Signed-off-by: VenkataSatya Jonnadula <rsankar@luminanetworks.com>
Change-Id: I7b2ed09633367e01229c7ea83063525c688821e8
VenkataSatya Jonnadula [Thu, 7 Nov 2019 12:39:45 +0000 (18:09 +0530)]
OPNFLWPLUG-1078: Notify device TLS authentication failure messages
Signed-off-by: VenkataSatya Jonnadula <rsankar@luminanetworks.com>
Change-Id: I2d6acae15e94676b23764c62f4094123014e0093
gobinath [Tue, 4 Sep 2018 06:45:45 +0000 (12:15 +0530)]
Grep not working for Karaf commands
SupressWarnings is used to suppress checkstyle warnings thrown upon
using System.out
This covers the changes for "southbound-cli" in openflowplugin
Change-Id: I3491068d5cb14cfac8afe42f648445fcd7f0cdc1
Signed-off-by: gobinath <gobinath@ericsson.com>
Shweta Chaturvedi [Mon, 6 May 2019 10:26:41 +0000 (15:56 +0530)]
Refactoring shownode cli
Grep was not working for shownode command
SupressWarnings is used to suppress checkstyle warnings thrown upon
using System.out
Change-Id: I6b70f44f84241e71edbd13b72696f65f744f941b
Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
Shweta Chaturvedi [Wed, 8 May 2019 08:01:20 +0000 (13:31 +0530)]
Refactoring shownode and getallnodes cli
Changing OFNODE to NodeId in shownode cli
and removing extra line from getallnodes cli
Change-Id: Ibe6a71047c99c41f327258d1478537c17ea8569e
Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
Robert Varga [Sat, 14 Sep 2019 19:04:49 +0000 (21:04 +0200)]
Migrate MockitoJUnitRunner
This migrates from org.mockito.runners.MockitoJUnitRunner to
org.mockito.junit.MockitoJUnitRunner.
Change-Id: If60b8b839393b87bd3ba4e44690a13d37dbd90d9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Arunprakash D [Thu, 14 Nov 2019 09:48:39 +0000 (09:48 +0000)]
Merge "OPNFLWPLUG-1049 : Device connection hold time to maintain delay between consecutive connections to the controller"
D Arunprakash [Wed, 17 Apr 2019 02:59:18 +0000 (08:29 +0530)]
Defaults flows missing due to mastership not available
Change-Id: Icb53d1a504ad7f9a9129bc589a7df7e51e33fcac
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
Gobinath [Thu, 4 Apr 2019 06:43:38 +0000 (12:13 +0530)]
Getallnodes should read from cache instead of DS
Problem
=======
Get All DPNs query takes long time to respond, as it reads from database.
Solution
========
Fix is to provide cache based response instead of Data store read.
Change-Id: Ida535c986713b25440b86c057d94c7b6bf060ede
Signed-off-by: Gobinath <gobinath@ericsson.com>
Shweta Chaturvedi [Mon, 23 Sep 2019 11:37:42 +0000 (17:07 +0530)]
OPNFLWPLUG-1036 OFP deleting topology-netconf operational data
Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
Change-Id: I9b4952c4cda7d391d3d8b874b441f0c58d764e29
Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
Somashekhar Javalagi [Wed, 20 Mar 2019 04:31:18 +0000 (10:01 +0530)]
OPNFLWPLUG-1049 : Device connection hold time to maintain delay between
consecutive connections to the controller
Device connection hold time is the least time delay a device has to
mantain between its consecutive connection attempts. If time delay
between the previous connection and the current connection is within
device connection hold time, the device will not be allowed to connect
to the controller. Default value of the device connection hold time is
0 second.
Change-Id: I15d3ca40c11d2ca20ad582bdddafb14dab449e4b
Signed-off-by: Somashekhar Javalagi <somashekhar.manohara.javalagi@ericsson.com>
Arunprakash D [Wed, 13 Nov 2019 05:34:32 +0000 (05:34 +0000)]
Merge "Use String(byte[], Charset)"
Arunprakash D [Wed, 13 Nov 2019 05:33:55 +0000 (05:33 +0000)]
Merge "Apply some Objects.requireNonNull() modernization"
Ning Zhang [Tue, 12 Nov 2019 09:46:27 +0000 (17:46 +0800)]
Failed to cancel service reconciliation, When controller become slave.
1.An exception may be thrown when the previous service reconciliation is cancelled,
causing the subsequent service to fail to cancel.
2.Do not use the toString() method when printing logs
Change-Id: I14f22a4b637890abb530140ba3666fda2181e24a
Signed-off-by: Ning Zhang <zhangninglc@inspur.com>
Robert Varga [Sun, 10 Nov 2019 11:16:21 +0000 (11:16 +0000)]
Merge changes from topic "odlparent-6.0.1"
* changes:
Bump to odlparent-6.0.1/yangtools-4.0.2/mdsal-5.0.4
Fix meter-id overlap
Arunprakash D [Fri, 8 Nov 2019 09:55:48 +0000 (09:55 +0000)]
Merge "Optimize ArbitratorReconciliationManagerImpl"
Robert Varga [Thu, 3 Oct 2019 10:33:53 +0000 (12:33 +0200)]
Optimize ArbitratorReconciliationManagerImpl
Use constant objects more rather than building them over and over
again. Also use ListeningExecutorService to dispatch tasks, leading
to simpler code.
Change-Id: I9f6186336c3f244a5bcc10647b9206d716501ff8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 28 Oct 2019 12:50:36 +0000 (13:50 +0100)]
Do not use toString() in logging arguments
Logging implementation will call toString() when it is needed,
doing it explicitly just wastes resources when logging is not
enabled -- which is typically the case for debugs.
Change-Id: I4298665ca7b8a5d65d23cfe184686cc38a4fbe55
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Fri, 6 Sep 2019 07:11:08 +0000 (09:11 +0200)]
Use String(byte[], Charset)
This is pointed out by modernizer and is more efficient.
Change-Id: I8f585247f3e117f955ebb39acff205d1679bd062
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 7 Nov 2019 08:02:59 +0000 (09:02 +0100)]
Bump to odlparent-6.0.1/yangtools-4.0.2/mdsal-5.0.4
This picks up latest upgrades and fixes.
Change-Id: I8db358b0af81394a561071d98bffea168dda47cc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sun, 20 Oct 2019 13:05:24 +0000 (15:05 +0200)]
Fix meter-id overlap
Adding meter-id leaf in two cases is not valid YANG, fix that up.
Change-Id: Icbdf91015d28061548bac3aa0f1f94e1668aaa91
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
d9f901335a6fd2ff660545d4e85497fd64f7d533)
Robert Varga [Wed, 30 Oct 2019 10:19:17 +0000 (11:19 +0100)]
Apply some Objects.requireNonNull() modernization
This cleans up moderinization warnings reported for
openflow-protocol-{api,impl} and simple-client.
Change-Id: Iec311574b090fd79242ce00ad690ff79333b940a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Arunprakash D [Thu, 7 Nov 2019 06:58:06 +0000 (06:58 +0000)]
Merge "OPNFLWPLUG-1077 : Bundle resync is not able to push groups to switch"
Arunprakash D [Thu, 7 Nov 2019 05:57:36 +0000 (05:57 +0000)]
Merge "Eliminate {infra,service}utils.version"
Somashekhar Javalagi [Fri, 25 Oct 2019 06:01:46 +0000 (11:31 +0530)]
OPNFLWPLUG-1077 : Bundle resync is not able to push groups to switch
As buckets are put into the SingletonImmutableList, sort on
SingletonImmutableList is not supported. yangtools is converting
yang list into SingletonImmutableList. Copying same into
ArrayList and sorting same.
Signed-off-by: Somashekhar Javalagi <somashekhar.manohara.javalagi@ericsson.com>
Change-Id: I5d7714c6b58421e14c535e5c3f42d81d0503bb2c
Arunprakash D [Thu, 7 Nov 2019 05:48:56 +0000 (05:48 +0000)]
Merge "Remove nagasena dependency declaration"
Arunprakash D [Thu, 7 Nov 2019 05:48:23 +0000 (05:48 +0000)]
Merge "Make applications/pom.xml an aggregator"
Arunprakash D [Thu, 7 Nov 2019 05:47:13 +0000 (05:47 +0000)]
Merge "Turn libraries/pom.xml into an aggregator"
Arunprakash D [Thu, 7 Nov 2019 05:46:52 +0000 (05:46 +0000)]
Merge "Turn samples/pom.xml into an aggregator"
Arunprakash D [Thu, 7 Nov 2019 05:45:49 +0000 (05:45 +0000)]
Merge "Turn extension/pom.xml into an aggregator"
Arunprakash D [Thu, 7 Nov 2019 05:45:32 +0000 (05:45 +0000)]
Merge "Make model/pom.xml inherit from odlparent-lite"
Robert Varga [Fri, 25 Oct 2019 12:31:59 +0000 (14:31 +0200)]
Eliminate {infra,service}utils.version
Rather than going through properties, use foo-artifacts to get
proper version declarations into dependencyManagement. This cleans
up version management a bit.
Change-Id: Ib2cf7bdd44235a9659c07bfd75ee29de29e3f863
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Fri, 25 Oct 2019 12:23:15 +0000 (14:23 +0200)]
Remove nagasena dependency declaration
This dependency was used by netconf a long time ago, we no longer
use it (and properly declare libraries). Remove the declaration.
Change-Id: If35e53803fdf085d1db2ed8182694314ed24b6b4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Fri, 25 Oct 2019 12:18:29 +0000 (14:18 +0200)]
Make applications/pom.xml an aggregator
This really is just an aggregator, make sure it inherits from
odlparent-lite and adjust its users to inherit from ofp-parent.
Shaves ~29 seconds from build time.
Change-Id: Id2cd32ed36a1bf40ff279cef1d9efced1649047b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Fri, 25 Oct 2019 11:44:24 +0000 (13:44 +0200)]
Turn libraries/pom.xml into an aggregator
This is a pure aggregator, not adding anything beneficial on top
of openflowplugin-parent. Turn it into an uninstalled aggregator,
shaving 3 seconds from the build.
Change-Id: I17a8ff7b4d753fb13bce0e3f03130a19e3beb899
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Fri, 25 Oct 2019 11:38:29 +0000 (13:38 +0200)]
Turn samples/pom.xml into an aggregator
This pom is not referenced anywhere and is a pure aggregator. Make
sure it inherits from odlparent-lite and is not installed. Speeds
up the build very negligibly.
Change-Id: I8d241525a229db794754e7212a0b63f4bd8b9c5c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Fri, 25 Oct 2019 09:10:36 +0000 (11:10 +0200)]
Turn extension/pom.xml into an aggregator
This 'parent' is not adding any value on top the usual OFP parent,
turn it into a proper aggregator, shaving another 3 seconds from
build time.
Also cleans up the extensions themselves by removing unnecessary
directives.
Change-Id: I0742cb5cf711dbbf7f70e6b3f95c768a94a9f596
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Fri, 25 Oct 2019 08:22:20 +0000 (10:22 +0200)]
Make model/pom.xml inherit from odlparent-lite
This 'parent' is really an aggregator, which is not adding anything
useful on top of OFP parent. Turn it into a pure aggregator and
adjust models to inherit from OFP parent instead.
The result is one fewer artifact to install as well as 3 seconds
shaved from build time.
Change-Id: I2a81635f43a5de1be87975bc0b193477b4fb0953
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Somashekhar Javalagi [Wed, 24 Apr 2019 04:16:57 +0000 (09:46 +0530)]
OPNFLWPLUG-1071 : Removal of javax.annotation.Nonnnull and replacement of javax.annotation.concurrent.GuardedBy
with org.checkerframework.checker.lock.qual.GuardedBy
Also please have close look at classes - AbstractStackedOutboundQueue, TransactionChainManager
and SimpleRatelimiter, @GuardedBy annotaion is removed as it is not supporting on void methods.
Change-Id: I34ec33525415b355065fee581a90054bdd501e6c
Signed-off-by: Somashekhar Javalagi <somashekhar.manohara.javalagi@ericsson.com>
Gobinath [Tue, 9 Apr 2019 06:23:10 +0000 (11:53 +0530)]
Synchronize Flow and Group Remove events
Description:
The flow and group remove events have to be synchronized too along with
the add/update events which are already synchronized.If the flow/group
remove events aren't synchronized, it could result in the stale flows
when there are multiple flow updates and deleted (like in case of
bulk evacuation)
Fix:
Used the existing nodeconfigurator framework to synchronize the remove
events too (with nodeId as key)
Change-Id: I9b386e5c8db2c35e721d539fa11558a292214ec0
Signed-off-by: Gobinath <gobinath@ericsson.com>
Gobinath [Tue, 2 Apr 2019 12:42:19 +0000 (18:12 +0530)]
Drop flows with actions to non-existing group id
Drop the flows which has action pointing to non-existing group
id in both apply actions and write actions.
Change-Id: I63e000871fe8fb80b7d12d0779232cdd6433f9f8
Signed-off-by: Gobinath <gobinath@ericsson.com>
Somashekhar Javalagi [Fri, 7 Jun 2019 06:45:08 +0000 (12:15 +0530)]
Creating Empty Tables in datastore only when statistics polling is
enabled.
Change-Id: Ia651042e35ceba5d2aea5f0579573cc68d81c90b
Signed-off-by: Somashekhar Javalagi <somashekhar.manohara.javalagi@ericsson.com>
Robert Varga [Wed, 23 Oct 2019 09:19:18 +0000 (11:19 +0200)]
Remove unused YANG imports
pyang is flagging these as unused, remove them.
Change-Id: Ib66f11a83e8c27be582fc299d7ec1cfde42d4356
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Arunprakash D [Mon, 21 Oct 2019 08:20:40 +0000 (08:20 +0000)]
Merge "OPNFLWPLUG-1076 Migrate lldp-speaker, forwardingrules-sync and arbitratorreconciliation to MD-SAL APIs"
Robert Varga [Fri, 11 Oct 2019 19:07:26 +0000 (21:07 +0200)]
Fix odlparent mis-bump
We have missed the upgrade of this feature, fix that up.
Change-Id: I55fa6052ea037dc5cebde12f9b086dd2bd7e1f28
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Fri, 11 Oct 2019 14:12:53 +0000 (16:12 +0200)]
Bump mdsal to 5.0.3
This bumps mdsal to 5.0.3 to workaround issues with Blueprint
injection.
Change-Id: I848c9220ce06ec7b4af304ab64948bdc30257dbd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Shweta Chaturvedi [Wed, 9 Oct 2019 10:12:20 +0000 (15:42 +0530)]
OPNFLWPLUG-1076 Migrate lldp-speaker, forwardingrules-sync and
arbitratorreconciliation to MD-SAL APIs
Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
Change-Id: I3309c2eef27224e3d3044c6b844f9eacab6fd03e
Robert Varga [Fri, 6 Sep 2019 07:04:45 +0000 (09:04 +0200)]
Bump mdsal to 5.0.2
This bumps mdsal to 5.0.2 as part of Magnesium MRI.
The change in uint{8,16,32,64} mapping necessitates quite a few
changes to protocol coding on both protocol-api and plugin-api
side, which are done in minimalistic fashion.
A follow-up patch will need to clean up unneeded conversions,
especially those from BigInteger.
Change-Id: Id9ab45edf28477dca8acf8f7538cfd26f237f6f4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Fri, 6 Sep 2019 07:04:14 +0000 (09:04 +0200)]
Bump odlparent to 6.0.0
This bumps odlparent to 6.0.0 as part of Magnesium MRI.
Change-Id: I19505dd80b832cd6ed8b68daf471d9e90d3dfdd2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Anil Vishnoi [Mon, 30 Sep 2019 23:38:08 +0000 (23:38 +0000)]
Merge "Update docs header to Magnesium in the master"
Robert Varga [Thu, 26 Sep 2019 13:41:38 +0000 (15:41 +0200)]
Fix odlparent reference
sodium code should use 5.0.x odlparent, fix that.
Change-Id: I73b8a0fae8eae267bba5b8c68911331c63a82369
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sat, 14 Sep 2019 02:17:29 +0000 (04:17 +0200)]
Bump mdsal to 4.0.6
This picks up the latest fixes.
Change-Id: I8ec178ca726c1df504efc4f19d2c9c80965d93be
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Fri, 6 Sep 2019 07:03:51 +0000 (09:03 +0200)]
Bump odlparent to 5.0.2
This bumps odlparent to pick up latest references.
Change-Id: Ica16c98bd6eeeb2530bdc9cee4bb7f198e4a6ab0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Fri, 6 Sep 2019 07:09:43 +0000 (09:09 +0200)]
Fix checkstyle
Upgraded checkstyle is reporting issues, fix them up.
Change-Id: I5ef8369369265ee31c151376694d8fceb37fb813
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Shweta Chaturvedi [Thu, 28 Mar 2019 11:27:06 +0000 (16:57 +0530)]
Enhance debug logs in ofj
Change-Id: I0529720235628687cf3ceeaa9af792fee0024c10
Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
gobinath [Thu, 21 Mar 2019 09:02:36 +0000 (14:32 +0530)]
Adding Logs to log commit bundle errors
Logging enhancement to log the commit bundle errors.
Change-Id: I587175acc52b184ff815452b1cd2dddc7e1b765d
Signed-off-by: gobinath <gobinath@ericsson.com>
Anil Vishnoi [Thu, 22 Aug 2019 21:19:13 +0000 (21:19 +0000)]
Merge "Use netconf-artifacts to get restconf version"
Robert Varga [Thu, 22 Aug 2019 14:52:37 +0000 (16:52 +0200)]
Use netconf-artifacts to get restconf version
restconf is not a separate ODL project, hence restconf-artifacts
is going away. Use netconf-artifacts to get (and use) the needed
declaration.
Change-Id: Iaf8274714b432a1dd6e3c2e981d14a32890f7a58
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Arunprakash D [Thu, 22 Aug 2019 11:55:43 +0000 (11:55 +0000)]
Merge "Use QueuedNotificationManager for port message processing"
Anushka Bhandari [Tue, 20 Aug 2019 16:53:10 +0000 (22:23 +0530)]
Update docs header to Magnesium in the master
Should be Magnesium on master and Sodium on stable/sodium.
Signed-off-by: Anushka Bhandari <anushka16134@iiitd.ac.in>
Change-Id: Ic3713a7cb4563b7ca212adec30f8024acd8a2812
Robert Varga [Thu, 15 Aug 2019 08:44:51 +0000 (10:44 +0200)]
Bump mdsal to 4.0.4
This brings in latest fixes.
Change-Id: I59f89ef4fe76ef16fcdc9b59f8d9b50aa0849847
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>