Claudio D. Gasparini [Fri, 20 Apr 2018 05:33:31 +0000 (07:33 +0200)]
MVPN RFC6514 Extendend communities
Update imports generate revision date
JIRA: BGPCEP-396
Change-Id: Id99f5ffac750a278b8f966b682c1f8659765afe5
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 19 Apr 2018 16:36:43 +0000 (18:36 +0200)]
MVPN RFC6514 Extendend communities
- Source AS
- VRF Route Import
JIRA: BGPCEP-396
Change-Id: Ib19270ad50c30d805008497e35b33fbcf7030aac
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 19 Apr 2018 21:08:56 +0000 (23:08 +0200)]
Remove no longer required karaf.shell imports
Change-Id: I8157504ba60b9fe8ccd9c49a39b7029b11d5a119
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 12 Apr 2018 18:44:08 +0000 (20:44 +0200)]
Remove duplicated Peer code
- improve tx synchronization
Change-Id: I6a87b0e90aa53f8f3a224535b988da08229d873b
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Wed, 18 Apr 2018 07:40:43 +0000 (09:40 +0200)]
Fix compilation issues related to IpAddress
Use IpAddress containing Ipv4/Ipv6, instead
of the IpAddress containing *nozone generated by
IetfInetUtil.
Change-Id: I4537b31e9561cb645881400358d54bfecd643bc1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 16 Apr 2018 08:26:13 +0000 (10:26 +0200)]
Initialize effective rib in for App Peer
Effective Rib in has splitted constructor and
initializer. Add missing initialization under
AppPeer
BGPCEP-789
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Change-Id: Iee2bde3ebf5f786b78ff5c4dd387da7decf20b0d
Claudio D. Gasparini [Mon, 16 Apr 2018 05:57:04 +0000 (07:57 +0200)]
Support Local AS only when configured as eBGP
Change-Id: Iac5d463fdf3849148e5845aa9265806e25c8ba76
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Stephen Kitt [Thu, 22 Mar 2018 17:24:33 +0000 (18:24 +0100)]
Bump to odlparent 3.1.0 and yangtools 2.0.3
Change-Id: I89ac7aec458dd9b567697bd2449bacb92e192369
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Claudio D. Gasparini [Sat, 14 Apr 2018 12:10:25 +0000 (14:10 +0200)]
Fix findbug complains
Change-Id: Ifeb808d6890c6150057ade9693b0730e9bf515fd
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 11 Apr 2018 10:57:42 +0000 (12:57 +0200)]
Migrate deprecated OsgiCommandSupport
Change-Id: I3fabc2af08746b2690a8e1ca8cb87e6ec84ad411
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 10 Apr 2018 18:35:42 +0000 (20:35 +0200)]
Rework Cluster-Id config
BGPCEP-564
Change-Id: I96557eca0c599e0934b7fada91bfc35162eae7bc
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 10 Apr 2018 15:47:25 +0000 (17:47 +0200)]
Delete routes under eff-rib-in
only if there are present.
Change-Id: I7c863999b54a16dec2bcaddd256c6ff7121b0cb5
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 10 Apr 2018 09:46:04 +0000 (11:46 +0200)]
Rework OffsetMap.remove() and share empty arrays
Empty arrays are immutable, hence we can share those instances,
reducing overheads. Also updates OffsetMap.remove() to take an
empty array argument, which will be used when the map would become
empty.
Change-Id: I58116eddce3d8b1a1f7d049c0c1f12fcd9f79966
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio D. Gasparini [Fri, 6 Apr 2018 13:25:50 +0000 (15:25 +0200)]
Provide Add Path support for all AFI/SAFI
Updade code according to models change.
Path Id and Route Key(string) leaf added
to route.
Route Key and Path Id are now the common
route-key for all routes list.
BGPCEP-781
Change-Id: I45bb53c939a2ecca57d2e11ec5e317e8164c7182
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 6 Apr 2018 08:41:03 +0000 (10:41 +0200)]
Provide Add Path support for all AFI/SAFI
Update route model, adding by default path-id
and route-key to be used as key for routes lists.
BGPCEP-781
Change-Id: Ie62c2f304976cb275ede8f52ad6d07812f46f15a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 10 Apr 2018 12:05:26 +0000 (14:05 +0200)]
Fix Peer Identifier used per Rib creation.
Use the provided by peer when session goes up.
BGPCEP-783
Change-Id: I7cd497df649be689a25dd67eed3903b42def8d28
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 9 Apr 2018 13:25:00 +0000 (15:25 +0200)]
Fix findbug NP_NONNULL_PARAM_VIOLATION complains
Change-Id: I359f4a8c626753e9d5eeb6eb4b2cbd906b28e984
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Sat, 7 Apr 2018 11:16:04 +0000 (13:16 +0200)]
Migrate ShellTable to non-deprecated class
org.apache.karaf.shell.support.table.ShellTable is the new location,
use that.
Change-Id: I85b6adc2ae01a47236217676f78cce9e0f81237e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sat, 7 Apr 2018 12:05:27 +0000 (14:05 +0200)]
Use byte[].clone()
BGPDocumentedException can be made more efficient by using
byte[].clone() instead of Arrays.copyOf(). Also pre-cache empty
data and return it when needed.
Change-Id: Ib4e36522f0d3a734621349c1b62865496d330009
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio D. Gasparini [Mon, 9 Apr 2018 12:59:30 +0000 (14:59 +0200)]
Use dedicated executor for BGPCEP Stats
BGPCEP-786
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Change-Id: I85d227f237509e3646805258ebeb1c22ebb3a54b
Robert Varga [Sat, 7 Apr 2018 11:22:26 +0000 (13:22 +0200)]
Migrate to karaf shell api
org.apache.felix.gogo.commands is deprecated, migrate to
org.apache.karaf.shell.api.action equivalents.
Change-Id: I22d1714f4bff6acfecb0fdd87c595e32af5d9a8c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Thanh Ha [Sat, 7 Apr 2018 02:39:57 +0000 (22:39 -0400)]
Add Karaf build profile
Project local Karaf distros are handy for devs to test their work
however is unneeded by autorelease builds and should not be released
as part of the Simultanious Release. Add a profile that is active by
default so that default behaviour is unchanged however allows the
autorelease project to disable building this module.
Issue: RELENG-86
Change-Id: I0b1d31b051223a8a1c22494da08bd72eb585198b
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Sat, 7 Apr 2018 02:38:31 +0000 (22:38 -0400)]
Remove obsolete Maven Site configuration
Change-Id: I31d7a0f8c709797cd927fd1eae266f2cbf6418f5
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Claudio D. Gasparini [Thu, 5 Apr 2018 09:01:02 +0000 (11:01 +0200)]
BGPCEP-578: Add additional path config
to afis/safis peer group
Change-Id: I2a4776d7566d79fd15c799c0c3d7613c01638e9e
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 5 Apr 2018 06:54:42 +0000 (08:54 +0200)]
Fix missing return under AbstractBestPathSelector
Change-Id: I0156a2be5a7772ecdbd55de5f5308092656b38eb
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 4 Apr 2018 15:35:19 +0000 (17:35 +0200)]
BGPCEP-740: Fix logic for MED comparison in BGP best path selection
New better path should be selected only if new MED is lower than
actual best path MED.
Change-Id: I8bd07dc8b42e575cebcc4e1ea4b55d9c2c842f42
Signed-off-by: Ajay Lele <ajayslele@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 3 Apr 2018 15:10:44 +0000 (17:10 +0200)]
BGPCEP-577: Neighbor’s local AS configurable
Change-Id: I4dab50d048c2c61900251959d06c909c55722df5
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 3 Apr 2018 07:53:26 +0000 (09:53 +0200)]
BGPCEP-576: Neighbor’s local address configurable
Change-Id: Ic4aaf8dbb408e37a0df40e320793dc1330879b06
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 3 Apr 2018 10:47:45 +0000 (12:47 +0200)]
BGPCEP-782: Fix peer-id
by using the one send by peer.
Change-Id: Ic18e7fac972b08dcd77a2dbaad7482295bdcd7ae
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sun, 1 Apr 2018 10:43:24 +0000 (12:43 +0200)]
Rework match role condition.
Make condition support from peer role and
to peer role evaluation at once.
Improving performance.
Change-Id: I2e3c69e82e17d651aca962f478901ec4aed63b88
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 29 Mar 2018 15:53:51 +0000 (17:53 +0200)]
BGPCEP-781: Provide Add Path support for all AFI/SAFI
Change-Id: I0fefe5c28a8b9d4f2f0be5cbe966233b73c7081a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sat, 31 Mar 2018 22:33:15 +0000 (00:33 +0200)]
BGPCEP-779: Fix Effective rib writer
empty table creation. Create table route
container only if its already not present.
Change-Id: Ia621e8aa8058eeb14b06bc99956efe1e7c6a9f5b
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Sat, 31 Mar 2018 17:41:24 +0000 (19:41 +0200)]
Fix test identity
Identities are mapped to interfaces, not classes.
Change-Id: I1fa4ce6dcf2825bb40b8c2b86fd4ed93e6d58a8d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Tom Pantelis [Sat, 31 Mar 2018 01:13:12 +0000 (21:13 -0400)]
Remove config system remnants
The config system is being removed in Flourine so remove
the unused config system dependencies.
Change-Id: I47175e831eced456d14f95cbcefd44dd404333dc
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Claudio D. Gasparini [Thu, 22 Mar 2018 11:41:02 +0000 (12:41 +0100)]
BGPCEP-564: Support multiple cluster IDs
Change-Id: I7e50b3ff7e9a4299b70bcfa6e1fa24ba970a795b
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 29 Mar 2018 10:43:01 +0000 (12:43 +0200)]
Fix Route removal
remove wrong check if from peer null.
Change-Id: Ica7a80db21ee7279d9aa6071287b0c499999ed04
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 29 Mar 2018 08:15:15 +0000 (10:15 +0200)]
Remove default Non add path implementation
under Ribsupport interface, and implement it under
new abstract class. Avoiding possible boilerplate.
Change-Id: I1e563659df3678aea5e491806adb42adea3dea9d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 28 Mar 2018 20:08:18 +0000 (22:08 +0200)]
BGPCEP-778: Fix peer-group reconfiguration
by use correct peer-group name.
Change-Id: Id68fbc1a9cd1a19aea26f0e810ec6b54560df359
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sun, 25 Mar 2018 19:59:15 +0000 (21:59 +0200)]
BGPCEP-712: Enforce checkstyle under binding-parent
Remove from dindiong modules, given inheritance.
Change-Id: I216d25eae5139f84663a9ae1ed43e94ab3d431ae
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 26 Mar 2018 07:10:46 +0000 (09:10 +0200)]
BGPCEP-712: Set Checkstyle with warn violationSeverity level
under specific modules. Until checkstyle issues
are fixed. Therefore we can enforce on top parent
the checkstyle for the rest.
Change-Id: I70cb6e540e4d6e9fa07aabe0f52527896ba228d1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 26 Mar 2018 10:38:13 +0000 (12:38 +0200)]
Fix checkstyle
for
- data change counter module
- parser mock module
Change-Id: If4bda129f1602effd7deb67a96eaeda4f3924962
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 27 Mar 2018 12:33:31 +0000 (14:33 +0200)]
Create Empty Route Container
under eff rib in tables, when
initializing the table.
Change-Id: Ia6138acb76b594a2bfac26b5a2099bd069d7a4be
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 27 Mar 2018 12:16:18 +0000 (14:16 +0200)]
BGPCEP-777: Ignore ParserToSalTest until fix
therefore autorelease-build will not be
blocked
Change-Id: I07df8e124c748a431735716926caf7c065a9d0ce
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 26 Mar 2018 18:23:10 +0000 (20:23 +0200)]
BGPCEP-775: Install missing feature
Openconfig rp Statement implementing(default
of policies)
Change-Id: Ic3d70dd960ce61c012a06f49d659582f9ca44444
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 26 Mar 2018 06:40:14 +0000 (08:40 +0200)]
Fix checkstyle under Concepts module
Change-Id: If5ed38841ea0013f3e5b721f59c48d7cb778fedf
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 22 Mar 2018 11:24:10 +0000 (12:24 +0100)]
BGPCEP-770: Lock file before processing
In this way we ensure is not still been modified
when event is raised.
Change-Id: I69047f244e78bdf4536d6f2a83d3b80c45191e90
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 23 Mar 2018 11:16:38 +0000 (12:16 +0100)]
BGPCEP-774: Improver error message when missing AFI/SAFI
on peer configuration
Change-Id: I79568d87a0e8401fa71376e9a9c0b3b5389a8baf
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 22 Mar 2018 09:27:56 +0000 (10:27 +0100)]
BGPCEP-768: Fix switch case
use break instead of wrong use of return.
Change-Id: I54b1e39c2b0017a628eff9a5a6eb09bb7a68f92c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 20 Mar 2018 08:54:25 +0000 (09:54 +0100)]
revert method name change
Change-Id: Id3f00b6d224e61b9de2dc5ab9d85a6273883aaef
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 21 Mar 2018 12:07:36 +0000 (13:07 +0100)]
BGPCEP-578: Extended peer-group support
- Add Peer Group to Operational state
- Augment peer group model for support peer remote port.
- Name augmentations missing naming.
- Clean up OpenConfigMappingUtil and
remove no longer required utility methods.
Change-Id: I840dad2d6f3c49fa1c12462e21f241f36cda03dc
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 19 Mar 2018 16:18:18 +0000 (17:18 +0100)]
BGPCEP-764: Use full Ipv6 form under StrictBGPPeerRegistry
Ipv6 equal is not capable of handle short or full form
of Ipv6, returning false when comparing different versions.
Therefore use full form under registry.
Change-Id: I2127f20e847860792d0f1c18b0ae243825a9d86a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sun, 18 Mar 2018 20:54:04 +0000 (21:54 +0100)]
Enforce findbug on binding-parent
fix findbug complains
Change-Id: Ib05cded6d40994269e06d70ac78a7e534b0d29b6
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sun, 18 Mar 2018 20:36:28 +0000 (21:36 +0100)]
Clean up
- remove unnecesary imports
- duplicated import
- Use string instead of StringBuilder
Change-Id: Ia4e7d83a582ae54a602fc213a55fff80d337beb5
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 15 Mar 2018 11:31:28 +0000 (12:31 +0100)]
BGPCEP-578: Introduce PeerGroup configuration
allowing to configure neighbors using a common
peer group config.
Change-Id: I2385f5927146324b540c9cd416942c5166e2d6e8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 20 Mar 2018 11:05:59 +0000 (12:05 +0100)]
BGPCEP-769: Dont use path id
under family(L3vpn) no supporting additional path.
Change-Id: I738cea4694411f7a63f077b243600f09aee61878
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 15 Mar 2018 11:31:03 +0000 (12:31 +0100)]
Fix config rib policy xml
Change-Id: Ie4af66dad1cfb797a010b4e2357c2b8b4d5989b3
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 16 Mar 2018 08:56:29 +0000 (09:56 +0100)]
BGPCEP-766: Reduce synchornization
under AbstractTopologySessionListener
Change-Id: I99efef02cef6f9af761c73d57bb4b37e50177830
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 16 Mar 2018 11:27:01 +0000 (12:27 +0100)]
Add logs to catch result of transaction submision
Change-Id: I4143786bc88c32c8ace8050e27c48c5a96aafb1f
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 15 Mar 2018 07:01:28 +0000 (08:01 +0100)]
Improve sync under EffectiveRibInWriter
Change-Id: I63e46860de46ea0a008400dfb64b1e8e97ea7e73
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 15 Mar 2018 08:06:48 +0000 (09:06 +0100)]
BGPCEP-589: BGP Neighbor match
match Peer-Id generated from neighbor address,
it can be used as replacement for generate similar
policy than removed simple-routing-policy.
Change-Id: I347a77cb40c72ff110b5088682f8edd375cecca1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 15 Mar 2018 10:47:28 +0000 (11:47 +0100)]
Fix BestPathState NPE
Check As Path segments are not null when
selecting best path.
Change-Id: Id4d76b9f83d957b505300aabde248978151f5b73
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 13 Mar 2018 06:25:45 +0000 (07:25 +0100)]
Fix RIB SPI checkstyle complains
Change-Id: Ia1862f8db58413ca284f4d76f1d24c0a2d818ac9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 9 Mar 2018 19:47:37 +0000 (20:47 +0100)]
BGPCEP-574: Apply Export Config policy
Change-Id: Ia117f0676edb02b2d92aba46aa99d2ba5fa52ce5
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 12 Mar 2018 09:01:08 +0000 (10:01 +0100)]
BGPCEP-574: Remove old Export Policy
Change-Id: I99c774cfb9c40469f2880307b2b9e2427f9b9dfa
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Thu, 8 Mar 2018 14:30:55 +0000 (15:30 +0100)]
Bump yangtools to 2.0.2
This patch bumps yangtools 2.0.2.
Change-Id: I21576a27323dff34e77db70f290e3a4e5b6beeb6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio D. Gasparini [Sun, 11 Mar 2018 20:35:48 +0000 (21:35 +0100)]
Use long instead of PathId wrapper
until the moment a PathId is required.
Change-Id: Idc2ce010fe4f2081f0d8131f2af226dfe88aec72
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 12 Mar 2018 09:21:55 +0000 (10:21 +0100)]
Fix Test values comparison
use { instead of [
Change-Id: I2750e4d00a389f6ca1051851749cb6f21f9f5538
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sun, 11 Mar 2018 19:07:04 +0000 (20:07 +0100)]
Clean up
Remove unused ribsupport method
Change-Id: I7d0867e51faf6f420c14e5df65ac8b4b43c794e8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sun, 11 Mar 2018 12:28:18 +0000 (13:28 +0100)]
BGPCEP-574: Remove unnesary methods
- remove extract key
- remove extract changed routes
Change-Id: I6bc6e83be77edcc8312dde8509ebd18051d888ee
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 9 Mar 2018 13:39:36 +0000 (14:39 +0100)]
Rename Base Route Entry classes
to keep consistency with
Add Path Route Entry classes.
Change-Id: I742540b51cfae5ee6935cf5340ff617858e9c31a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 9 Mar 2018 13:02:16 +0000 (14:02 +0100)]
BGPCEP-754: Fix NPE and rework
- Fix npe
- Simplify PeerTracker
- Fix test name
Change-Id: I239d634a98799c73220e55cbb9b295b84576f7ec
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 9 Mar 2018 10:33:24 +0000 (11:33 +0100)]
BGPCEP-574: Install RIB policy config file
by default.
Make config file loader depency between them
in order to avoid race condition when loading
configurations.
Change-Id: I35ab0886c64502c3ec9961d83dbae330667c0ea3
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 8 Mar 2018 11:54:00 +0000 (12:54 +0100)]
BGPCEP-754: Rework EffectiveRibInWriter
use ClusteredDataTreeChangeListener instead
of ClusteredDOMDataTreeChangeListener
Change-Id: I773ada0d2b593afad1c63dc8ed54c88e48fee500
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 7 Mar 2018 12:05:10 +0000 (13:05 +0100)]
BGPCEP-574: Fix features
by importing features intead of use the
blundles.
Change-Id: I645778f3e4e2338c74040f819ff1c56d3cdd822e
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sat, 3 Mar 2018 07:30:32 +0000 (08:30 +0100)]
BGPCEP-574: Rework rib config policies
by making possible to pass only wanted
attribute for condition match.
Change-Id: I876fafaba79ed2e4598a1de2db280ff280442d4a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 1 Mar 2018 10:26:09 +0000 (11:26 +0100)]
BGPCEP-763: Fix Pcep Deadlocked thread
improve synchronization
Change-Id: I9d0b97aefe58e742d10313d7ab18f69f3e8be69c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 1 Mar 2018 11:01:21 +0000 (12:01 +0100)]
BGPCEP-574: Remove old ImportPolicyPeerTracker
Change-Id: Ife1849081727a6ab06038f3f5dbab010797347a7
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 26 Feb 2018 11:01:55 +0000 (12:01 +0100)]
BGPCEP-754: Start using default import policy
configuration with configurable rib policies.
Change-Id: I6aeb4c4261aafb7faf1ff0a08edfefb443590830
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 14 Feb 2018 15:43:30 +0000 (16:43 +0100)]
BGPCEP-754: Remove simple-routing-policy
Can be replace by configuring a rib policy
Change-Id: I12ef5f2571b01020e23ee073c8745ca9fe972a1a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 18 Jan 2018 09:53:15 +0000 (10:53 +0100)]
BGPCEP-754: PeerTracker Impl
- recollected information for advertize
path, as supported families, peerID, etc..
will be provided by peers themselves.
Change-Id: I759bb14fa513ba5927f52ac4160cc2ffb4641d5d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 17 Jan 2018 16:05:58 +0000 (17:05 +0100)]
BGPCEP-754: Introduce BGPPeerTracker interfaces
as replacement for static Export group.
Each Peer will provide information required
per rib policies for update tables.
BGPPeerTracker will just keep track of
all registered peers.
Change-Id: I08c94afab183a49c7277e30792d8344b87064d8a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 31 Jan 2018 16:09:05 +0000 (17:09 +0100)]
BGPCEP-589: Openconfig Basic Routing Policy Statement
- match prefix set
- match originator set
- match cluster-id set
- match peer-role set
- community
- ext-community
- as-path set
- med eq
- next-hop-in
- as-path length
- local-pref-eq
Basic actions
- accept
- reject
- as-path prepend
- set community
- set excommunity
- set originator-id
- originator-id prepend
- cluster-id prepend
- set local-pref
- set next-hop
- set med
- transitive attributes filtering
Change-Id: I5052ad5a0e5319dfd143a79b2bf812cad8676236
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 28 Feb 2018 14:23:03 +0000 (15:23 +0100)]
BGPCEP-589: use odl communities / ext-communities
on openconfig-bgp-policy.
Odl supports more comm/ext-comm that the ones
defined by oepnconfig. Also this improve efficency
for match comparisons.
Change-Id: I6989c64cdd8bf102f3d44ac5b545a97990578459
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 31 Jan 2018 15:53:27 +0000 (16:53 +0100)]
BGPCEP-754: Openconfig Routing Policy Service
- Routing Policy Registry, listening DS and
keeping track of all defined policies
- RIB Policy Factory, provide a factory
for create rib policies per specific RIB.
Change-Id: Id5521811a23b65ad1ae5e4e20eb41a61d78beb95
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 11 Jan 2018 12:06:36 +0000 (13:06 +0100)]
BGPCEP-574: Openconfig Routing Policy SPI
- Actions API
- Conditions API
- Statement handlers registry
- Feature
Change-Id: Ie1784f18c5d27fb8750e1d0ae2417b6561434bcc
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 11 Jan 2018 10:47:56 +0000 (11:47 +0100)]
BGPCEP-574: Introduce RIB Policy interfaces
for Configurable RIB policies.
Change-Id: I20930255ede101204b2d7402831953539e6a4398
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 31 Jan 2018 13:02:51 +0000 (14:02 +0100)]
BGPCEP-589: Define default routing policies
create basic routing policies required
for default bgp default rib policy.
Change-Id: Ia9cdbdfa9f9ef6231a7bb774d6d66701dc777d26
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Wed, 28 Feb 2018 00:11:11 +0000 (01:11 +0100)]
Fix model compliance
Declared prefix should be unique within a module, as that is
the prefix that is used to refer to a module within itself.
Change-Id: I699c529831fd62854a50e46c105a3d7922d670f1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio D. Gasparini [Thu, 11 Jan 2018 21:23:24 +0000 (22:23 +0100)]
BUG-6966: Openconfig policy config file loader.
Loads from xml Openconfig rib policies and
sets.
Change-Id: I59153172cf5ab917420e3b1e182b84d5e0ef0abe
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 1 Feb 2018 22:57:44 +0000 (23:57 +0100)]
Remove deprecated methods
Change-Id: I7abb75ae3b151e3ff3171b78fee47cb6853c2478
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 17 Jan 2018 08:05:51 +0000 (09:05 +0100)]
Reduce number of parameters for RIBImpl
Change-Id: Ib9a9fff4e1d21673fec9251b32663106614fb8c1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sun, 7 Jan 2018 21:35:25 +0000 (22:35 +0100)]
Reduce number of parameters for path selection
-enforce findbug.
Change-Id: Idc9cb566e31b81c7d87cf544016525122487393b
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 26 Feb 2018 15:58:31 +0000 (16:58 +0100)]
Add missing copyrights
Change-Id: I992492a29d54cd0d70e0a1289fb891754775584b
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Anil Belur [Mon, 26 Feb 2018 07:41:40 +0000 (17:41 +1000)]
Bump versions by x.(y+1).z for next dev cycle
Change-Id: Ia32d405970372481dd25d9764f92c409a5e98c3e
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Claudio D. Gasparini [Fri, 23 Feb 2018 21:12:09 +0000 (22:12 +0100)]
BGPCEP-760: Fix Dead lock
when connecting multiple peers at
the same time multiple routes are announced.
Fix by improve sync under Peer export groups.
Change-Id: I588db1bfc3cfca80308837084ac5088b8fc89cea
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 23 Feb 2018 14:40:33 +0000 (15:40 +0100)]
Fix NPE
when calling containsEqualConfiguration on Peer
Change-Id: Idc674a8be808386c0a3050dca3a3895cf0491caf
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 15 Feb 2018 09:59:07 +0000 (10:59 +0100)]
Remove no longer required service-properties
for restart OSGI CSS service
Change-Id: I65c4810ca5da9bd357dbdabb3ed413649ba8fbb1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 14 Feb 2018 11:06:38 +0000 (12:06 +0100)]
BGPCEP-758: Use random ip for Pcc mock tests
-perform some clean up
Change-Id: I79ef9f8e5f01b1d461c5848d7966f9e3521f926d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 14 Feb 2018 10:16:19 +0000 (11:16 +0100)]
BGPCEP-757: Handle WRITE as SUBTREE_MODIFIED
on case of Topology rewrite, following
the same procedure as if it was an update.
Change-Id: Ida6bf596137054bb6a5d02d4345daee8cf5f3394
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 12 Feb 2018 13:24:46 +0000 (14:24 +0100)]
Remove unnecesary sync
Change-Id: I6cf0f20346719e311164bf96c3b87387878200d3
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Code Review / bgpcep.git / log