Bump versions by x.y.(z+1)

Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: Idcbd5dc14cae5925e588837bafb1abf1839b88ed

OPNFLWPLUG-1074: table stats not available after a switch flap

Problem: csit test cases failing due to empty table stats

Root Casue: First time when table stats are collected, they
are written into operational inventory. But consequently at
the time of writing flow stats to datastore, table stats
transaction was still not complete. So when fow stats are
written with empty table stats which are read from
operational inventory

Fix: Collecting flow stats first followed by table stats,
which prevents overwrite of table stats.

Signed-off-by: Somashekhar Javalagi <somashekhar.manohara.javalagi@ericsson.com>
Change-Id: I39bf7ffe9b12a4d3a03efbec95f75dd1a0ef70f6

Merge "OPNFLWPLUG-1084 Device operational is not getting created if device reconciliation is not enabled"

Revert "All-dpns are not getting listed in the"

This reverts commit 566c4ac8fcd1feaa501955791790a247f3e69b07.

Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
Change-Id: I6433cdb02d7cf875e9aa9c56bfa0f39ec3bdcc02

Revert "Fix for DPNs not connecting to controller"

This reverts commit 6b6281680872611d795261dbf232c0131235bd51.

Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
Change-Id: Id5ed63c59aeb4a3303f5f176d8ad82d6767a43ca

Revert "CSC  to provide a view of DPN re-sync"

This reverts commit 674bb50091db4628a50c08606f8f8b9f3c8a5e55.

Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
Change-Id: I5d03f6175bd2ae9faeb5cdf248c5d15242ee4653

CSC  to provide a view of DPN re-sync
status from CLI

Change-Id: I6153f394803e43abf77e871f993d9ca7a1bedd45
Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>

Fix for DPNs not connecting to controller

Change-Id: If708df53a0102bb85fe0040b260f821b4d35773c
Signed-off-by: Somashekhar Javalagi <somashekhar.manohara.javalagi@ericsson.com>

All-dpns are not getting listed in the
output of display all-dpns in cics

Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
Change-Id: Id4198d385fd636c5cedefbbf16a99b852ba36265

Optimize ReconcileUtil.safe*()

Node exposes nonnullTables() etc., which we can take advantage of
to simplify code.

Change-Id: Ifc53b8d9bc7898f23896ab0ca159fb4f4d1d73ef
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge "Code refractor and logging improvements"

Merge "Code Refractor and logging improvements"

Merge "NETVIRT-1638 Modify yang modules such that it can be validated using pyang"

Code refractor and logging improvements

Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
Change-Id: I0b03ed4aae82f11c3d6dbe266120d00653b4ee1d

Code Refractor and logging improvements

Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
Change-Id: I85091cb808a35981c128d3f2194c15b17d92d85b

OPNFLWPLUG-1084 Device operational is not getting created if
device reconciliation is not enabled

Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
Change-Id: I7d72c004d71a9b7f47c2eedc8a399bfa8547dde9

NETVIRT-1638 Modify yang modules such that it can be validated using pyang

Fixing pyang warning and errors.

Signed-off-by: Nishchya Gupta <nishchyag@altencalsoftlabs.com>
Change-Id: Ic66aa4a4394b5b6132b4027e044da5b165e2912e

Moving threadPool to a common place.

It was creating one threadPool for each connection
and failed to close it, now using common thread pool
for all the incoming dpn connections on 6653.

Change-Id: I60372c32c9e32f65f83eb678d741a12202702d52
Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>

Bump to odlparent-6.0.4/yangtools-4.0.6/mdsal-5.0.9

Pick up latest fixes and upgrades.

Change-Id: I04d1232d8bff69d15436257a2e56ff60a4e2ecf8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent/yangtools/mdsal to 6.0.3/4.0.3/5.0.6

Pick up the latest upgrades and fixes.

Change-Id: I6633200cb4a9895889f8627b8fea4cd93f052974
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge "Failed to cancel service reconciliation, When controller become slave."

Error log correction

Change-Id: Ie00ff4c3008aaf3fba2af4245f09c021195829c3
Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>

Avoid holding netty threads during resync callbacks

Change-Id: Ic6b78c053a9971b3be83ee1aa98f3ad822394c1b
Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>

Merge "Grep not working for Karaf commands"

Read action throwing NPE

Issue Description:
When process alien action throwing NullPointerException:
java.lang.NullPointerException: null
        at org.opendaylight.openflowplugin.openflow.md.core.extension.ActionExtensionHelper.processAlienAction(ActionExtensionHelper.java:46)
        at org.opendaylight.openflowplugin.impl.protocol.deserialization.util.ActionUtil.readAction(ActionUtil.java:66)

Signed-off-by: Ning Zhang <zhangninglc@inspur.com>
Change-Id: I4008eef616bb08de9333442a4f21c3f21b12c65e

Merge "OPNFLWPLUG-1078: Notify device TLS authentication failure messages"

Merge "OPNFLWPLUG-1075: Making Device Oper transactions atomic"

OPNFLWPLUG-1075: Making Device Oper transactions atomic

Signed-off-by: VenkataSatya Jonnadula <rsankar@luminanetworks.com>
Change-Id: I7b2ed09633367e01229c7ea83063525c688821e8

OPNFLWPLUG-1078: Notify device TLS authentication failure messages

Signed-off-by: VenkataSatya Jonnadula <rsankar@luminanetworks.com>
Change-Id: I2d6acae15e94676b23764c62f4094123014e0093

Grep not working for Karaf commands

SupressWarnings is used to suppress checkstyle warnings thrown upon
using System.out

This covers the changes for "southbound-cli" in openflowplugin

Change-Id: I3491068d5cb14cfac8afe42f648445fcd7f0cdc1
Signed-off-by: gobinath <gobinath@ericsson.com>

Refactoring shownode cli

Grep was not working for shownode command

SupressWarnings is used to suppress checkstyle warnings thrown upon
using System.out

Change-Id: I6b70f44f84241e71edbd13b72696f65f744f941b
Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>

Refactoring shownode and getallnodes cli

Changing OFNODE to NodeId in shownode cli
and removing extra line from getallnodes cli

Change-Id: Ibe6a71047c99c41f327258d1478537c17ea8569e
Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>

Migrate MockitoJUnitRunner

This migrates from org.mockito.runners.MockitoJUnitRunner to
org.mockito.junit.MockitoJUnitRunner.

Change-Id: If60b8b839393b87bd3ba4e44690a13d37dbd90d9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge "OPNFLWPLUG-1049 : Device connection hold time to maintain delay between consecutive connections to the controller"

Defaults flows missing due to mastership not available

Change-Id: Icb53d1a504ad7f9a9129bc589a7df7e51e33fcac
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>

Getallnodes should read from cache instead of DS

Problem
=======
 Get All DPNs query takes long time to respond, as it reads from database.

Solution
========
Fix is to provide cache based response instead of Data store read.

Change-Id: Ida535c986713b25440b86c057d94c7b6bf060ede
Signed-off-by: Gobinath <gobinath@ericsson.com>

OPNFLWPLUG-1036 OFP deleting topology-netconf operational data

Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
Change-Id: I9b4952c4cda7d391d3d8b874b441f0c58d764e29
Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>

OPNFLWPLUG-1049 : Device connection hold time to maintain delay between
consecutive connections to the controller

Device connection hold time is the least time delay a device has to
mantain between its consecutive connection attempts. If time delay
between the previous connection and the current connection is within
device connection hold time, the device will not be allowed to connect
to the controller. Default value of the device connection hold time is
0 second.

Change-Id: I15d3ca40c11d2ca20ad582bdddafb14dab449e4b
Signed-off-by: Somashekhar Javalagi <somashekhar.manohara.javalagi@ericsson.com>

Merge "Use String(byte[], Charset)"

Merge "Apply some Objects.requireNonNull() modernization"

Failed to cancel service reconciliation, When controller become slave.

1.An exception may be thrown when the previous service reconciliation is cancelled,
causing the subsequent service to fail to cancel.
2.Do not use the toString() method when printing logs

Change-Id: I14f22a4b637890abb530140ba3666fda2181e24a
Signed-off-by: Ning Zhang <zhangninglc@inspur.com>

Merge changes from topic "odlparent-6.0.1"

* changes:
  Bump to odlparent-6.0.1/yangtools-4.0.2/mdsal-5.0.4
  Fix meter-id overlap

Merge "Optimize ArbitratorReconciliationManagerImpl"

Optimize ArbitratorReconciliationManagerImpl

Use constant objects more rather than building them over and over
again. Also use ListeningExecutorService to dispatch tasks, leading
to simpler code.

Change-Id: I9f6186336c3f244a5bcc10647b9206d716501ff8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not use toString() in logging arguments

Logging implementation will call toString() when it is needed,
doing it explicitly just wastes resources when logging is not
enabled -- which is typically the case for debugs.

Change-Id: I4298665ca7b8a5d65d23cfe184686cc38a4fbe55
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use String(byte[], Charset)

This is pointed out by modernizer and is more efficient.

Change-Id: I8f585247f3e117f955ebb39acff205d1679bd062
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump to odlparent-6.0.1/yangtools-4.0.2/mdsal-5.0.4

This picks up latest upgrades and fixes.

Change-Id: I8db358b0af81394a561071d98bffea168dda47cc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix meter-id overlap

Adding meter-id leaf in two cases is not valid YANG, fix that up.

Change-Id: Icbdf91015d28061548bac3aa0f1f94e1668aaa91
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit d9f901335a6fd2ff660545d4e85497fd64f7d533)

Apply some Objects.requireNonNull() modernization

This cleans up moderinization warnings reported for
 openflow-protocol-{api,impl} and simple-client.

Change-Id: Iec311574b090fd79242ce00ad690ff79333b940a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge "OPNFLWPLUG-1077 : Bundle resync is not able to push groups to switch"

Merge "Eliminate {infra,service}utils.version"

OPNFLWPLUG-1077 : Bundle resync is not able to push groups to switch

As buckets are put into the SingletonImmutableList, sort on
SingletonImmutableList is not supported. yangtools is converting
yang list into SingletonImmutableList. Copying same into
ArrayList and sorting same.

Signed-off-by: Somashekhar Javalagi <somashekhar.manohara.javalagi@ericsson.com>
Change-Id: I5d7714c6b58421e14c535e5c3f42d81d0503bb2c

Merge "Remove nagasena dependency declaration"

Merge "Make applications/pom.xml an aggregator"

Merge "Turn libraries/pom.xml into an aggregator"

Merge "Turn samples/pom.xml into an aggregator"

Merge "Turn extension/pom.xml into an aggregator"

Merge "Make model/pom.xml inherit from odlparent-lite"

Eliminate {infra,service}utils.version

Rather than going through properties, use foo-artifacts to get
proper version declarations into dependencyManagement. This cleans
up version management a bit.

Change-Id: Ib2cf7bdd44235a9659c07bfd75ee29de29e3f863
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove nagasena dependency declaration

This dependency was used by netconf a long time ago, we no longer
use it (and properly declare libraries). Remove the declaration.

Change-Id: If35e53803fdf085d1db2ed8182694314ed24b6b4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Make applications/pom.xml an aggregator

This really is just an aggregator, make sure it inherits from
odlparent-lite and adjust its users to inherit from ofp-parent.
Shaves ~29 seconds from build time.

Change-Id: Id2cd32ed36a1bf40ff279cef1d9efced1649047b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Turn libraries/pom.xml into an aggregator

This is a pure aggregator, not adding anything beneficial on top
of openflowplugin-parent. Turn it into an uninstalled aggregator,
shaving 3 seconds from the build.

Change-Id: I17a8ff7b4d753fb13bce0e3f03130a19e3beb899
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Turn samples/pom.xml into an aggregator

This pom is not referenced anywhere and is a pure aggregator. Make
sure it inherits from odlparent-lite and is not installed. Speeds
up the build very negligibly.

Change-Id: I8d241525a229db794754e7212a0b63f4bd8b9c5c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Turn extension/pom.xml into an aggregator

This 'parent' is not adding any value on top the usual OFP parent,
turn it into a proper aggregator, shaving another 3 seconds from
build time.

Also cleans up the extensions themselves by removing unnecessary
directives.

Change-Id: I0742cb5cf711dbbf7f70e6b3f95c768a94a9f596
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Make model/pom.xml inherit from odlparent-lite

This 'parent' is really an aggregator, which is not adding anything
useful on top of OFP parent. Turn it into a pure aggregator and
adjust models to inherit from OFP parent instead.

The result is one fewer artifact to install as well as 3 seconds
shaved from build time.

Change-Id: I2a81635f43a5de1be87975bc0b193477b4fb0953
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

OPNFLWPLUG-1071 : Removal of javax.annotation.Nonnnull and replacement of javax.annotation.concurrent.GuardedBy
with org.checkerframework.checker.lock.qual.GuardedBy

Also please have close look at classes - AbstractStackedOutboundQueue, TransactionChainManager
and SimpleRatelimiter, @GuardedBy annotaion is removed  as it is not supporting on void methods.

Change-Id: I34ec33525415b355065fee581a90054bdd501e6c
Signed-off-by: Somashekhar Javalagi <somashekhar.manohara.javalagi@ericsson.com>

Synchronize Flow and Group Remove events

Description:
The flow and group remove events have to be synchronized too along with
the add/update events which are already synchronized.If the flow/group
remove events aren't synchronized, it could result in the stale flows
when there are multiple flow updates and deleted (like in case of
bulk evacuation)

Fix:
Used the existing nodeconfigurator framework to synchronize the remove
events too (with nodeId as key)

Change-Id: I9b386e5c8db2c35e721d539fa11558a292214ec0
Signed-off-by: Gobinath <gobinath@ericsson.com>

Drop flows with actions to non-existing group id

Drop the flows which has action pointing to non-existing group
id in both apply actions and write actions.

Change-Id: I63e000871fe8fb80b7d12d0779232cdd6433f9f8
Signed-off-by: Gobinath <gobinath@ericsson.com>

Creating Empty Tables in datastore only when statistics polling is
enabled.

Change-Id: Ia651042e35ceba5d2aea5f0579573cc68d81c90b
Signed-off-by: Somashekhar Javalagi <somashekhar.manohara.javalagi@ericsson.com>

Remove unused YANG imports

pyang is flagging these as unused, remove them.

Change-Id: Ib66f11a83e8c27be582fc299d7ec1cfde42d4356
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge "OPNFLWPLUG-1076 Migrate lldp-speaker, forwardingrules-sync and arbitratorreconciliation to MD-SAL APIs"

Fix odlparent mis-bump

We have missed the upgrade of this feature, fix that up.

Change-Id: I55fa6052ea037dc5cebde12f9b086dd2bd7e1f28
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump mdsal to 5.0.3

This bumps mdsal to 5.0.3 to workaround issues with Blueprint
injection.

Change-Id: I848c9220ce06ec7b4af304ab64948bdc30257dbd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

OPNFLWPLUG-1076 Migrate lldp-speaker, forwardingrules-sync and
arbitratorreconciliation to MD-SAL APIs

Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
Change-Id: I3309c2eef27224e3d3044c6b844f9eacab6fd03e

Bump mdsal to 5.0.2

This bumps mdsal to 5.0.2 as part of Magnesium MRI.

The change in uint{8,16,32,64} mapping necessitates quite a few
changes to protocol coding on both protocol-api and plugin-api
side, which are done in minimalistic fashion.

A follow-up patch will need to clean up unneeded conversions,
especially those from BigInteger.

Change-Id: Id9ab45edf28477dca8acf8f7538cfd26f237f6f4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent to 6.0.0

This bumps odlparent to 6.0.0 as part of Magnesium MRI.

Change-Id: I19505dd80b832cd6ed8b68daf471d9e90d3dfdd2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge "Update docs header to Magnesium in the master"

Fix odlparent reference

sodium code should use 5.0.x odlparent, fix that.

Change-Id: I73b8a0fae8eae267bba5b8c68911331c63a82369
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump mdsal to 4.0.6

This picks up the latest fixes.

Change-Id: I8ec178ca726c1df504efc4f19d2c9c80965d93be
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent to 5.0.2

This bumps odlparent to pick up latest references.

Change-Id: Ica16c98bd6eeeb2530bdc9cee4bb7f198e4a6ab0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix checkstyle

Upgraded checkstyle is reporting issues, fix them up.

Change-Id: I5ef8369369265ee31c151376694d8fceb37fb813
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Enhance debug logs in ofj

Change-Id: I0529720235628687cf3ceeaa9af792fee0024c10
Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>

Adding Logs to log commit bundle errors

Logging enhancement to log the commit bundle errors.

Change-Id: I587175acc52b184ff815452b1cd2dddc7e1b765d
Signed-off-by: gobinath <gobinath@ericsson.com>

Merge "Use netconf-artifacts to get restconf version"

Use netconf-artifacts to get restconf version

restconf is not a separate ODL project, hence restconf-artifacts
is going away. Use netconf-artifacts to get (and use) the needed
declaration.

Change-Id: Iaf8274714b432a1dd6e3c2e981d14a32890f7a58
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge "Use QueuedNotificationManager for port message processing"

Update docs header to Magnesium in the master

Should be Magnesium on master and Sodium on stable/sodium.

Signed-off-by: Anushka Bhandari <anushka16134@iiitd.ac.in>
Change-Id: Ic3713a7cb4563b7ca212adec30f8024acd8a2812

Bump mdsal to 4.0.4

This brings in latest fixes.

Change-Id: I59f89ef4fe76ef16fcdc9b59f8d9b50aa0849847
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions by x.y.(z+1)

Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: Ie185860b8b00e07fe66f48fda9496c77f3ab0860

Use QueuedNotificationManager for port message processing

Using queuedNotificationManager for port message processing to avoid datastore
operations in netty thread contex

Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
Change-Id: Ib3dc671b8dd5e6afcbe8d7b4751e8beec45651aa

Merge changes from topic "mdsal-4.0.3"

* changes:
  Bump mdsal to 4.0.3
  Bump odlparent to 5.0.1

Do not store empty node list

Empty node list does not have a semantic meaning and will be
turned into a non-existent list when it becomes empty again.

Do not store it in the datastore.

Change-Id: I8d85650ffe51ec96e243482230c91da9f9e8f402
JIRA: OPNFLWPLUG-1052
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge "Printing failed flow/group details for the bundle based resync"

Merge "Sending each flow/group in separate bundle add rpc instead of adding all messages and calling the bundle add rpc. This would allow for the echo message to be processed not waiting for all the bundle messages to be sent."

Bump mdsal to 4.0.3

This bumps mdsal to 4.0.3, bringing in latest fixes and improvements.

Change-Id: Ie8e03aab1f31edf80bc9f1d7896c334c9d83be8d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent to 5.0.1

This picks up the latest upgrades.

Change-Id: If6006a94197839a9718cd5eae16b0a025913af93
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

OPNFLWPLUG-1070

OVS Based NA Responder for IPv6 default Gateway

Added support IPv6 NA responder fields as part of
odl-openflowplugin-eric-extensions feature.
As per the changes, below eric experimenter fields will be supported with
vendor ID 0X1000.
nd_reserved - OXM name: ERICOXM_OF_ICMPV6_ND_RESERVED(1)
nd_options_type - OXM name: ERICOXM_OF_ICMPV6_ND_OPTION_TYPE(2)
Yes this feature is  present in the OVS master with below patch detail.
https://github.com/openvswitch/ovs/commit/9b2b84973db76e1138d9234ff1b84bb6bb156011

Change-Id: I7e53b54097c6678046f5b216537129157081913c
Signed-off-by: nithi thomas <nithi.t@altencalsoftlabs.com>

Printing failed flow/group details for the bundle based resync

Change-Id: I6dab8ef845e9cd2ef8fbadc02dc557cac5e2323c
Signed-off-by: Somashekhar Javalagi <somashekhar.manohara.javalagi@ericsson.com>

Sending each flow/group in separate bundle add rpc instead of adding all
messages and calling the bundle add rpc. This would allow for the echo
message to be processed not waiting for all the bundle messages to be
sent.

Change-Id: I9d0f4ca136b8d313a1b0804a009aa047555db9e3
Signed-off-by: gobinath <gobinath@ericsson.com>

Merge "OPNFLWPLUG-1073 : Using ofppool executor for role change service request callbacks"