Derive RpcRoutingStrategy from RpcEffectiveStatement

Use RpcEffectiveStatement instead of RpcDefinition to derive the
strategy. A knock-on effect is a clean up of entries and their tests,
as they can operate solely on QNames now.

Change-Id: Id2988458bb923d09b07a5a1819554b043b3840d8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Seal RpcRoutingStrategy

We do not allow subclassing of this class, make sure to codify that by
sealing it.

Change-Id: I6edea76dec0511bc16e94a06b4aee2be894732b7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add RpcProviderService documentation

We have largely-undocumented methods. Add documentation.

Change-Id: I7b12ba2d412d6de276e4c62277ff3c852e72a996
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Rename Enumeration to EnumTypeObject

Enumeration is a troublesome name, let's use a more regular
EnumTypeObject, which follows the TypeObject naming.

Change-Id: I2581d760db8597f7ccfe6f0d2c68e28423fbea5d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add UnionTypeObject

Introduce UnionTypeObject, which is a specialization of TypeObject to
unions. This allows us to seal TypeObject, making sure all it is always
properly specialized.

Also revert the change in SerialVersionUID introduced with
BitsTypeObject by properly ignoring it.

Change-Id: I72ef1d452e2a48c630e9c87bfb4ff0fac0fda32c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add BitsTypeObject

The new interface BitsTypeObject, besides grouping bits type objects,
helps clarify which bits are restricted.

Method validValues() returns constant containing valid bits.
The logic of the creation of this constant is contained in the
AbstractTypeObjectGenerator.java.
Method getValue() was included in this interface and its generation
was adjusted for restricted and standard bits types separately.

Related test classes were adjusted as well.

JIRA: MDSAL-743
Change-Id: I74820e7a041e137902c774655517ea8d1e4bccd9
Signed-off-by: Ivan Martiniak <ivan.martiniak@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump byte-buddy to 1.12.19

https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.12.14
https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.12.15
https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.12.16
https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.12.17
https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.12.18
https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.12.19

Change-Id: Iff0bf7fac38abb69cb8d1547e8fa188a11428b94
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve SerialVersionHelper a bit

sortedCollection() can use local variable type inference, which ends up
binding ArrayList.sort() directly -- providing a smidge better
performance by using INVOKEVIRTUAL instead of INVOKEINTERFACE.

Change-Id: I28470942dc37dd8171cc10eccf6c6a15d85ade9e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not use appendValue to append bits

Using false/true values is overly verbose and incurs a boxing penalty.
Update mapping to only mention bits which are set. Add a dedicated
CodeHelpers.appendBit(), which uses boolean value to decide whether to
append the bit's name or not.

JIRA: MDSAL-744
Change-Id: Ifefa258dc6850ea220ffebcc7dbb788979657704
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use Boolean.hashCode() for bits components

Rather than boxing to Boolean and then going through
Objects.hashCode(Object), employ some smarts and go directly to
Boolean.hashCode(boolean).

JIRA: MDSAL-744
Change-Id: Ida374207c67b776e1eeafb40e3a4f725fe2edf1f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use primitive comparison for bit properties

Rather than boxing to go through Objects.equals(), use plain '==' on
booleans.

JIRA: MDSAL-744
Change-Id: I005ba52d8c68fb9eaf7d93e40adcf13ca159436f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove BaseTemplate.hashCodeResult()

This method is not used anywhere, remove it.

Change-Id: I7c17303b08443c67eaf321ff5c316ebb991351ec
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve class template equals()

Rather than generating a slew of if/return statements, use instanceof
pattern and generate a single-expression return statement.

Change-Id: Id8c0fc65736399fed3454fdbcc16a16849f86064
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Import java.lang.Object in equals()

We have the machinery to have a proper reference, let's use it.

Change-Id: I92e08cac810c3c3f7a3a737746d6c85ba5f2c10e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Map bits type to primitive boolean

The main change is in the AbstractTypeObjectGenerator.java,
returned type for bits was set to primitive boolean.
Generation of the getDefaultInstance() method in the ClassTemplate.xtend
had to be adjusted as well, as the null value obviously
does not make sense in the case of primitive type.
Related test classes had to be changed as well

JIRA: MDSAL-744
Change-Id: Ic6423f67679475fced73ea68ed4f447b241230f7
Signed-off-by: ivan.martiniak <ivan.martiniak@pantheon.tech>

Make SerializedDOMDataBroker final

This is a utility implementation and it should not be subclassed.

Change-Id: Ie69f01bd232ae1a407f332235c800b655a186499
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not emit empty super() call

If we do not have any parent properties, we should not generate a
free-standing super() call -- javac will do that for us.

Change-Id: Ib45ec29e9914f0f3eeef7e2d86ebb94fbd33aab1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Keep property initialization order constant

Eventhough one property is checked for null, we should not be placing it
before the others.

Change-Id: I2be23b4ed278d693828a1758af9c47b0a6e0caf9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Require union field to be set

Do not allow an union type object to be costructed without supplying one
of its alternatives.

JIRA: MDSAL-792
Change-Id: I69a9dc3f0094cc9ff03d0846d5f9dcc746417628
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate mdsal-binding-test-model to JUnit 5

We have a few simple tests, let's migrate them.

Change-Id: Ifea435affc917070a20d3ca9368d6d3c7f499453
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not allow multi-datastore transactions

Cross-datastore transactions are something that does not fit into
interaction model of neither MD-SAL nor NETCONF WG. As we are evolving
our APIs to make them impossible, make sure we report attempts to use
transactions across multiple datastore.

JIRA: MDSAL-775
Change-Id: If9a3bb619f4fd5703f786d14f42485d2073968ec
Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use a VarHandle for closed flag

This eliminates type safety warnings and make it more explicit as to
what we mean.

Change-Id: Ib268de2c02c7ac04aec25a3a1f9df40d2b8c3238
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve AbstractDOMForwardedTransactionFactory

AutoCloseable.close() is recommended to be idempotent, follow that
guidance, producing a warning with a stack trace if that is not the
case.

Change-Id: I0ba827bae521b07c94ecf58e8881f72b1ec8fdc6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Specialize CommitCoordinationTask

Tracker is optional, so let's subclass the tracking into a wrapper
class.

Change-Id: I4271d2453181bbbf2310c4737ef90b87d154b046
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove OSGiQueryFactory

We have constructor injection, so let's do that. Also activate lazily
and therefore lower debug levels.

Change-Id: I0b37a2bab8109d47d13276b135b7f510272ee024
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use a record for RecordId

This is pure data holder, use a record instead.

Change-Id: I1161e0431592f15360c6cdd87e37604bb0fbc2e0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fixup AbstractForwardedTransaction.doExecute()

This should be a static method, also modernize it a bit.

Change-Id: Iecea13d78146c235dea389f1e72543751ed255fb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Rename ModuleInfoSnapshotResolver

We are masquerading as the binding-dom-codec, but that is not accurate.
Use our name instead.

Change-Id: I930976e96b22bbb070d1a02ccd28bfa86a59cf1e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize ModuleInfoSnapshotResolver a bit

Use local variable type inference and streams to transform things.
This reduces the verboseness a bit.

Change-Id: I9ec9bf70c7f90b4cd264e9f239b96ddff60bc0cc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Simplify YangModuleInfoScanner

We will be tracking YangFeatureProviders, so
List<ObjectRegistration<YangModuleInfo>> is not quite accurate. Track
only a simple Registration and make sure we wrap the return from
ModuleInfoSnapshotResolver.

Also improve the tracking logic a bit: do not track bundles which do not
contain YangModuleInfos, but make a special exception for the system
bundle.

JIRA: MDSAL-791
Change-Id: I245f25c72152f7e49817c316f63ace557b4c56c0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unneeded suppression

We are catching only checked exceptions, no need for the suppression.

Change-Id: Ib19174db68934d058d3ec9352653e2d19762a164
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix version mis-bump

We have failed to update model versions, fix that up.

Change-Id: Ie5894174fa2322cb663a14a10a98f50a2ff94897
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up LazySerializedContainerNodeTest

Use ImmutableNodes instead of relying on builder implementation.

Change-Id: I7e9ca92c8b1f71e06296427d19560fa6c62624e4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up NormalizedNodeSerializeDeserializeTest

Use static imports from Builders/ImmutableNodes to eliminate dependency
on builder implementations.

Change-Id: Ie34c8d92d721132d9b5881481997df358e1f53d8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up mdsal-dom-broker tests

Do not reference builder implementations directly.

Change-Id: I15111ea3b446e677d4c02a9cd0c7f46743e8f184
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up mdsal-dom-inmemory-datastore-benchmark

Clean up pom.xml, update JMH and use Builders instead of implementation
detail.

Change-Id: Ida822fa4e15f44d610ea080b3a68f217e8fecad4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate a SchemaContext reference

We should be operating on EffectiveModelContext.

Change-Id: I1a2978a3f912c4edb31923cc24e31c619df04a06
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up InMemoryDataStoreTest

Add proper assertions and use Builders instead of direct reference to
immutable container builder.

Change-Id: I07d725d9da13c75ad152e618a9bf1bc761167309
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add nonnullFoo() getters for non-semantic objects

Add non-null getters for containers without presence statement. They
return a lazy-initialized containers' empty instances in case the
container is null.

Non-null getters are implemented in Builder's inner implementation
of the container's parent.

Container's empty instance is located in container's builder class
and is hidden behind a static method.

In the binding codec part a nonnull method is generated using usual
lazy proxy backed by an empty ContainerNode.

JIRA: MDSAL-673
Change-Id: I3a5a346b32b89e7c28cad31536593824dee3c232
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Signed-off-by: Samuel Schneider <samuel.schneider@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up BindingNormalizedNodeCodec.deserialize() implementations

We should consistently throw NPE/IAE for inputs. Add some basic infra
and make sure every implementation behaves similarly. Most notably we do
not want to dump the entire argument, as that could lead to an OOM.

Change-Id: I6aad6c587028637e0089684ba2305d3e7c20675e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Qualify FIXME

Attach issue reference to the pre-existing FIXME.

JIRA: MDSAL-785
Change-Id: Ic09ae54a8b8219703ccefc038df5d295e27b22c5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove BindingReflections.findHierarchicalParent()

These methods are not used anywhere, remove them.

JIRA: MDSAL-787
Change-Id: If141bf222523671fb524c27f2322e4591410d900
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Deprecate BindingReflections.findHierarchicalParent()

These methods are not used, deprecate them for removal.

Change-Id: Idee358f004fb36fb01a3c5222430a808dd68bbfd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove BindingReflections.isAugmentationChild()

This method is not used anywhere, remove it.

JIRA: MDSAL-786
Change-Id: I6ed40aab7432f59e2e2a8bcb51e161cac2fcb33e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Deprecate BindingReflections.isAugmentationChild()

This method is used only in test, deprecate it for removal.

Change-Id: I894429041302163288036085a1af4718d5e28a83
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use Optional.orElseThrow()

This makes the intent clearer.

Change-Id: Ib7d733d7563e6a51b86dbf313da55abb18556d4d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

SimpleDOMQueryResult should be a record

This is a simple reference holder with some accessors, turn it into a
record.

Change-Id: I76f66684f805f1938b621229a35e2efe91ab502e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix documentation typoes

We have simple grammar errors here, fix that up.

Change-Id: I597db08441200065924b233289a3e5864370a928
Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstreams

Adopt:
- odlparent-12.0.0
- yangtools-10.0.0

Change-Id: Ic101cb87855ee69680746d783e1a40b6f944e3f9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Package iana-crypt-hash module

This is a useful registry, make sure we package it. Since this model
comes from RFC7317, which also defines ietf-system.yang, we break our
usual feature packaging for now. This will be revised once we have the
tools to correctly indicate ietf-system being implemented (or not).

JIRA: MDSAL-768
Change-Id: I5c0bb5f97290a91718c90b66ffea4872887443cf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up Datastore addressing

Rather than using Class files, use explicit well-known constants.

Change-Id: I999e3a7e32f7743320da5c3a0b42ec136653255e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add BindingReflections.getQName(Rpc)

Acquiring the QName of an RPC implementation is a well-known operation,
make sure we publish that capability.

JIRA: MDSAL-773
Change-Id: I2d3bd90d41b8da45f7b99a0ffebdfa4e18c0ffcc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve BindingReflections.getQName()

BaseIdentity operates on instance methods now, hence we should not
be passing a Class here. This allows us to evolve the contract in
the future.

Change-Id: I837dbfd9dffedf190c6885202d39cf730cd08de2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update BindingReflections.getQName()

Use orElseThrow() instead of checkState() and explicit check/get.

Change-Id: I9b16d31ad4dba8a1d911a3566d590b2d8d2f47fc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

DOM RPC invocation takes ContainerNode

RPC input statements are equivalent to a ContainerNode, make sure to
update RPC services.

JIRA: MDSAL-541
Change-Id: Iaa26e7051cfb45e043acf4ca6f39125678684ea8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Deprecate BindingMapping.NOTIFICATION_LISTENER_SUFFIX

This is part of the NotificationListener specification, it needs to be
deprecated just as the rest of it is.

Change-Id: I61996af51b9f8bc67b986cefdc8abf98bdc2ac7c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 8414434942b4548da0a3fd96013cd35391575493)

Generate Rpc services

Introduce an Rpc concept similar to Action, except without a path.
Generate its specializations, allowing RPCs to be implemented and/or
invoked without their ModuleService aggregate.

JIRA: MDSAL-773
Change-Id: I5fec1ac5c81b908714965e71c3471b954b58d1f9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Integrate Action with BindingContract

Having an integrated BindingContract allows us readily identify
the the implementation contract of an action. This allows us to ditch
the explicit class instance.

JIRA: MDSAL-776
Change-Id: I6fc297f331d5f0c545b80e84ca54025c44c67eb6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update DOMRpcResult a bit

Use ContainerNode for result value and replace getErrors()/getResult()
with errors()/result().

This cleans up parlance a bit and makes the object model actually match
YANG RPCs.

JIRA: MDSAL-541
Change-Id: I0b1c0456385fd64eba06aa90580a7b56a5be0a86
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Simplify ActionSpec.equals(Object)

We can use an instanceof pattern, squashing logic accordingly.

Change-Id: Ice925cc99d90b1c918ce17cfdc987275db932381
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve ModuleAugmentGenerator safety

Require parent to be a module, which makes the intent more explicit.

Change-Id: Ic9d83c879838d10a475b46feb43a6aeab0c3f66c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use instanceof patterns

We have quite a bit of checking and casting going on, simplify a bit
but using JDK17 constructs.

Change-Id: Iffd0537e9832f8372b696fba7025c49c0fbf597c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove use of SchemaPath

We are not referencing SchemaPath in any shape or form. Remove all
references.

Change-Id: I509ee338ed3e8d038200ca8d36686a5320b13884
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 11.0.0-SNAPSHOT

This starts the next major development iteration.

Change-Id: Ia278be03f42f2e9c17c6b59fb5330aa41e3faa99
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not tolerate empty action instances

The set of instances is specified to be non-empty, enforce this
requirement.

Change-Id: If3334c850eaf3ffb1be33626b332547268a2bd90
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 10.0.3-SNAPSHOT

This starts the next development iteration.

Change-Id: I2434badf754ee6f6845ee7f090f78e597f0d5af0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Generate javadoc for TypeObjects

Fix warnings about missing javadoc in TypeObject classes.

Add setting of YangSourceDefinition when building GeneratedType
for TypeObject so JavaFileTemplate.appendSnippet() generate javadoc
for this class.

Generation of javadoc was added for all TypeObjects not only
ScalarTypes as described in corresponding task.

JIRA: MDSAL-762
Change-Id: Iec3ab9e36bcea0807892bd024b7f04c451ff9000
Signed-off-by: Samuel Schneider <samuel.schneider@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up AbstractEnumerationBuilder

We can use Java 17, fluent StringBuilder and streams to make the code
denser.

Change-Id: Id0b8bc176076469120fddbb993e9a59215aa660a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Propagate status in feature classes

When we have a deprecated or obsolete identity, the resulting interface
should be marked as deprecated, perhaps for removal.

JIRA: MDSAL-770
Change-Id: I2b1204b2afcd4b2786c0c76695c1d58304349f57
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Propagate status in identity classes

When we have a deprecated or obsolete identity, the resulting interface
should be marked as deprecated, perhaps for removal.

JIRA: MDSAL-769
Change-Id: I5aefc70d5cde269217143e092ba208589b55d12f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump xtend to 2.28.0

https://www.eclipse.org/xtend/releasenotes.html#/releasenotes/2022/05/30/version-2-27-0
https://www.eclipse.org/xtend/releasenotes.html#/releasenotes/2022/08/29/version-2-28-0

Change-Id: I9ce1d9fddabff9df48de9fc69637492d30c39635
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Generate features with @NonNullByDefault

We get quite a few warnings around nulls, use @NonNullByDefault, as that
is what we need.

Change-Id: Ia6b7c572ece161cc4e9cac1e9530a91b621cd93e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 10.0.2-SNAPSHOT

This starts the next development iteration.

Change-Id: I353e51fd685690023e24fdad452d53ced4d44eee
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent/yangtools

Adopt:
- odlparent-11.0.1
- yangtools-9.0.1

Change-Id: I3b1ba2d5345bbf26d471296f850e3b9836ffb2a8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use @Serial tag

With Java 17 we can make serialization-related components explicitly
tagged so their shape is enforced. Sprinkle java.io.Serial around.

Change-Id: Ibf0ce6e19f8433b3274e05ad3f56d86616146e78
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use contructor injection in OSGiModelRuntime

Remove unneeded indirection through fields, so that the lifecycle is a
tad more crisp.

Change-Id: I55794015a41340e38f77c7cca7caf047116ae18c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use instanceof pattern in Identity's equals()

We can use an implicit cast here, let's just do that to make things a
tad simpler.

Change-Id: Ic2f48c2b8f3fc0e4b5aec0b699cad8edf4c434b0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fixup a nullness warning

Add an annotation to fix a potential problem.

Change-Id: I8676cb25ee5f7c8c132b894f47c4383825d9ff5d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix raw type warnings in OSGiBindingRuntime

Component/ComponentFactory take a type specification, make sure we
take advantage of that.

Change-Id: I11cd64811b683fdfa8dfd62980cf9e1979ed1c0d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add YangFeatureProvider

YangFeatureProvider is a counterpart to YangModuleInfoProvider,
providing the runtime with the ability to introspect what features
should be supported in an EffectiveModelContext.

JIRA: MDSAL-767
Change-Id: I6d08772c96eead79b4c88ae9ac27c57901dc70a8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Generate classes for 'feature' statements

We need to cross-reference 'feature' statements before we assemble an
EffectiveModelContext. In order to do that cleanly and in a type-safe
manner, we need to generate Binding representation of each feature.

JIRA: MDSAL-766
Change-Id: I67e2a1dd42bd1b364fbcbbf88a83d96c947621ef
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use instanceof pattern checks

We can clean up some code with instanceof patterns, use them.

Change-Id: I0c3022b44d824b4677b1286a9c3b99cf18a01193
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Narrow @SuppressModernizer

We are only suppressing the use of Guava's Objects in != operator, narrow
covered places.

Change-Id: I6b3ec8f78996227bae27558f9c04b22ed866595b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use an instanceof pattern

We can remove a cast here, saving a few characters.

Change-Id: Ie2c03a062cffce58ba15a253e81957b6cc5d1b6b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Ditch Collections.{singleton,empty}List()

Use List.of() instead.

Change-Id: I728826dba2b4790ef75606da918c5968b3c8ee48
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Share AbstractExplicitGenerator.runtimeJavaType()

Most implementations do the same thing, pull the implementation down
into the abstract class.

Change-Id: Iaf0b6cee34e62c89ea3d34b8c83fa4f02bce913e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Seal CollisionMember.Member

This is an implementation detail, seal the class hierarchy.

Change-Id: Ifb9497a172d16a2e2560b46df47631934351afe0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Dispatch statements with instanceof pattern

Remove a bit of casting by using an instanceof match.

Change-Id: I2d22f4a3bd6151c4193d3dec95efc7f69c09013d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use instanceof pattern

Remove a cast to make the expression simpler.

Change-Id: I7a0d1abf1e80cafb9352bfbb1f05ae56b9117bf1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump byte-buddy to 2.12.13

https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.12.11
https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.12.12
https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.12.13

Change-Id: I08268857938cf7f732662c0e41c4fb7e8a5ba996
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve javadoc for generated keys

Fix warnings about missing javadoc in Key classes
generated by ListKeyTemplate.xtend.

Add generation of javadoc for all values constructor,
getter methods and for the class.

JIRA: MDSAL-759
Change-Id: I1cef9d4b4415e0f786eca414937b1958d31acd38
Signed-off-by: Samuel Schneider <samuel.schneider@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Generate javadoc for augments

Fix warnings about missing javadoc in augment interfaces.

Add setting of YangSourceDefinition when building GeneratedType
corresponding to augments so JavaFileTemplate.appendSnippet()
generate javadoc for this class.

JIRA: MDSAL-761
Change-Id: I243ce2e5198dca2b9c6e6c009c6ddb2a248d44a5
Signed-off-by: Samuel Schneider <samuel.schneider@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Generate javadoc for unions

Fix warnings about missing javadoc in union classes.

Add setting of YangSourceDefinition when building GeneratedType
corresponding to union so JavaFileTemplate.appendSnippet()
generate javadoc for this class.

JIRA: MDSAL-760
Change-Id: I42ac82ab099785b1318a5e3615e37ebeee653b02
Signed-off-by: Samuel Schneider <samuel.schneider@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use FrameworkUtil.asDictionary()

We do not need a Hashtable, use FrameworkUtil to give us what we need.

Change-Id: If6a590a2651e92b89e349b41a6ab4e10b0f73db8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix raw type warnings

CompoentFactory should use a proper type, fix that.

Change-Id: Ibf0c072d49c1ce9047eb01101f94d9b589448452
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up YangSourceDefinition a bit

Capture the shared predicate in a method and use method references
to route to it. Also use instanceof pattern match.

Change-Id: I530274532db9a4942dcc54725c211785badd5d42
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use instanceof pattern match

We can be more expressive now that we have Java 17, let's do that.

Change-Id: I669fe4bd871c9cc269ead6b3b376af21295efc4e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add generation of javadoc for Builder.withKey()

Fix warnings about missing javadoc for method withKey() in Builder
classes generated by BuilderTemplate.xtend.

JIRA: MDSAL-758
Change-Id: Ia871623b608a9dcdfb4fec284622843a7365e839
Signed-off-by: Samuel Schneider <samuel.schneider@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use FrameworkUtil.asDictionary()

We do not need a dedicated Dictionary implementation as OSGi R8 provides
a conversion utility.

Change-Id: I308c3d5dc23e0c06f176cda089daf4597b5028d4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 10.0.1-SNAPSHOT

This starts the next development iteration.

Change-Id: Iee036e6c5815752768d86f701fc44b3ce1e6c808
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>