bgpcep.git
9 years agoBug 2803 - Update SR 29/16329/14
Ladislav Borak [Wed, 11 Mar 2015 15:02:13 +0000 (16:02 +0100)]
Bug 2803 - Update SR

- updated API to confirm with
  https://tools.ietf.org/html/draft-ietf-pce-segment-routing-01

- added new error type

- added abstract class with parsing and serializing SrSubobject

Change-Id: Ic3b9d5a4b0f6bd8332211bfc670c2ff2c2dc9c95
Signed-off-by: Ladislav Borak <lborak@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoRemoved some sonar warnings. 84/15884/4
Dana Kutenicsova [Mon, 2 Mar 2015 07:00:28 +0000 (08:00 +0100)]
Removed some sonar warnings.

Change-Id: I3b3966505e14ba6ff7445211ac8edd8a04884f17
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-2383 : wired codec tree factory to RIB 80/16980/3
Dana Kutenicsova [Mon, 23 Mar 2015 11:33:35 +0000 (12:33 +0100)]
BUG-2383 : wired codec tree factory to RIB

Change-Id: I4c928c15a9f0902453096bf8db2e1ff571209c36
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoFixed NPE in BGPPeer. 81/16981/1
Dana Kutenicsova [Mon, 23 Mar 2015 12:57:05 +0000 (13:57 +0100)]
Fixed NPE in BGPPeer.

Change-Id: Icf4f9ab08f95ff9a878634d9f00033efca0534b0
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoMerge "BUG-2571 : flowspec-routes model"
Robert Varga [Sun, 22 Mar 2015 10:56:38 +0000 (10:56 +0000)]
Merge "BUG-2571 : flowspec-routes model"

9 years agoBug 2824 - Fill in unrecognized attributes 27/16827/7
Ladislav Borak [Thu, 19 Mar 2015 11:35:10 +0000 (12:35 +0100)]
Bug 2824 - Fill in unrecognized attributes

- added support for parsing unrecognized path attributes
- added test for parsing unrecognized path attributes

Change-Id: Ibca8feb9c10a6f22ee6ebb4c6bf43e03af319849
Signed-off-by: Ladislav Borak <lborak@cisco.com>
9 years agoMerge "BUG-2383 : BGPPeer now sends routes to AdjRibWriter"
Robert Varga [Fri, 20 Mar 2015 08:30:13 +0000 (08:30 +0000)]
Merge "BUG-2383 : BGPPeer now sends routes to AdjRibWriter"

9 years agoMigrate AbstractConfigTest subclasses from CodecRegistry 65/16765/3
Maros Marsalek [Wed, 18 Mar 2015 13:40:58 +0000 (14:40 +0100)]
Migrate AbstractConfigTest subclasses from CodecRegistry

Codec registry is being replaced by BindingRuntimeContext

Change-Id: I548a256f1814d2f94d478035baa4a6ea6a74db83
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoBUG-2383 : BGPPeer now sends routes to AdjRibWriter 17/16817/1
Dana Kutenicsova [Thu, 19 Mar 2015 10:45:54 +0000 (11:45 +0100)]
BUG-2383 : BGPPeer now sends routes to AdjRibWriter

Change-Id: I633c70781242b5a128a6c9982af3146dc8c4581d
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-2383 : fixed creating peer list 11/16811/1
Dana Kutenicsova [Thu, 19 Mar 2015 09:57:25 +0000 (10:57 +0100)]
BUG-2383 : fixed creating peer list

- added some logs to AdjRibInWriter too

Change-Id: I7ebd1414d71da09a302bb5833b545c49524fc22b
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoImprove compatibility with Java 8 javadoc 20/16220/5
Ladislav Borak [Wed, 18 Mar 2015 17:37:12 +0000 (18:37 +0100)]
Improve compatibility with Java 8 javadoc

This fixes various javadoc inconsistencies reported by JDK8.

Change-Id: Ic41c2d16e8191885266b6b8f440fe17eb5ec159c
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Ladislav Borak <lborak@cisco.com>
9 years agoMerge "Moved tests out of config test directory."
Robert Varga [Wed, 18 Mar 2015 17:26:10 +0000 (17:26 +0000)]
Merge "Moved tests out of config test directory."

9 years agoMerge "BUG-2383 : added tests & documentation for AbstractRIBSupport"
Robert Varga [Wed, 18 Mar 2015 17:25:24 +0000 (17:25 +0000)]
Merge "BUG-2383 : added tests & documentation for AbstractRIBSupport"

9 years agoBUG-2383 : added tests & documentation for AbstractRIBSupport 77/16777/2
Dana Kutenicsova [Wed, 18 Mar 2015 15:41:25 +0000 (16:41 +0100)]
BUG-2383 : added tests & documentation for AbstractRIBSupport

Change-Id: I518d355370161ce07de3f4440e6a20d23d8a4de5
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoMerge "BUG-2867: Make IANA assigned Linkstate attribute type as default (29)."
Robert Varga [Wed, 18 Mar 2015 13:08:23 +0000 (13:08 +0000)]
Merge "BUG-2867: Make IANA assigned Linkstate attribute type as default (29)."

9 years agoBUG-2867: Make IANA assigned Linkstate attribute type as default (29). 58/16758/2
Dana Kutenicsova [Wed, 18 Mar 2015 11:21:40 +0000 (12:21 +0100)]
BUG-2867: Make IANA assigned Linkstate attribute type as default (29).

Change-Id: Ie1e3d4393298a51dda846df2ea1a8f6aef22d3b8
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoMoved tests out of config test directory. 62/16762/1
Dana Kutenicsova [Wed, 18 Mar 2015 12:13:11 +0000 (13:13 +0100)]
Moved tests out of config test directory.

Change-Id: I24556612c59bb8704f7607236b1e9a8b58a7af68
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-2383 : fixed missing configuration file 57/16757/1
Dana Kutenicsova [Wed, 18 Mar 2015 11:20:27 +0000 (12:20 +0100)]
BUG-2383 : fixed missing configuration file

Change-Id: I51c447b8b52deb790dc40bbab8f61127ed938698
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-2383: wire up AdjRibInWriter 96/16096/12
Robert Varga [Thu, 12 Mar 2015 19:13:43 +0000 (20:13 +0100)]
BUG-2383: wire up AdjRibInWriter

Modify AdjRibInWriter lifecycle to fit with BGPPeer actions. Also make
sure we pick up the transaction chain from RIB.

Change-Id: Ide7b7bf3073d5a106608d555577535a079ed2b37
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-2383: wire DOMDataBroker into RIBImpl 19/16419/4
Robert Varga [Thu, 12 Mar 2015 22:32:54 +0000 (23:32 +0100)]
BUG-2383: wire DOMDataBroker into RIBImpl

We will need DOMDataBroker, so let's be sure to wire it in.

Change-Id: I04dafd0e394291c9146c19a0bb88e9cf6410efdc
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoRenamed OffsetMap tests 13/16513/1
Dana Kutenicsova [Sat, 14 Mar 2015 08:14:38 +0000 (09:14 +0100)]
Renamed OffsetMap tests

Change-Id: I37d7b3a9bb6b95bd391148842c4a516e0dea315d
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoMerge "BUG-2383: RibReference should expose the key"
Dana Kutenicsova [Fri, 13 Mar 2015 12:57:39 +0000 (12:57 +0000)]
Merge "BUG-2383: RibReference should expose the key"

9 years agoMerge "BUG-2383: split out policies into separate files"
Dana Kutenicsova [Fri, 13 Mar 2015 12:53:02 +0000 (12:53 +0000)]
Merge "BUG-2383: split out policies into separate files"

9 years agoBUG-2383 : fixed Destination container 71/16471/1
Dana Kutenicsova [Fri, 13 Mar 2015 10:12:15 +0000 (11:12 +0100)]
BUG-2383 : fixed Destination container

Change-Id: I38ddd1834ba31de60221b08ad43be14a8ed457f1
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoMerge "BUG-2383 : split ipv4/6 to separate model"
Robert Varga [Fri, 13 Mar 2015 09:37:38 +0000 (09:37 +0000)]
Merge "BUG-2383 : split ipv4/6 to separate model"

9 years agoBUG-2383: RibReference should expose the key 18/16418/3
Robert Varga [Thu, 12 Mar 2015 22:27:44 +0000 (23:27 +0100)]
BUG-2383: RibReference should expose the key

RibKey will be needed to simply convert the reference into a
YangInstanceIdentifier.

Change-Id: Id5d2c79cad02b85648a359764d70e2c9eecb59ef
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-2383: split out policies into separate files 48/16348/12
Robert Varga [Wed, 11 Mar 2015 11:26:58 +0000 (12:26 +0100)]
BUG-2383: split out policies into separate files

Static policies kwill not work, as some of them require additional
arguments to perform their role. Split them out, so they can be evolved
independently.

Change-Id: I33decf294c53391d4d705014adfd62b6d5ffa34d
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoAdd odlparent relativepath relative to autorelease 27/16427/1
Thanh Ha [Fri, 13 Mar 2015 02:12:38 +0000 (22:12 -0400)]
Add odlparent relativepath relative to autorelease

Change-Id: Iafdafcb1afdd7e14443a827327c9993c9456837d
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
9 years agoBUG-2383 : split ipv4/6 to separate model 80/16080/15
Dana Kutenicsova [Fri, 6 Mar 2015 16:41:39 +0000 (17:41 +0100)]
BUG-2383 : split ipv4/6 to separate model

- changed models: bgp-rib and bgp-multiprotocol
- created new artefact bgp-inet, that holds this model
- code rewritten to use this new artefact

Change-Id: I069f2c42a7e22c624a5549b09da8d07bd0d1acaf
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoMerge "BUG-2383 : moved AbstractRIBSupport class"
Robert Varga [Thu, 12 Mar 2015 10:28:10 +0000 (10:28 +0000)]
Merge "BUG-2383 : moved AbstractRIBSupport class"

9 years agoBUG-2383 : moved AbstractRIBSupport class 24/16324/6
Dana Kutenicsova [Wed, 11 Mar 2015 14:01:56 +0000 (15:01 +0100)]
BUG-2383 : moved AbstractRIBSupport class

- this class is probably by mistake in config package,
move it to bgpcep

Change-Id: I0e6dd856b3fab5f7fe8aba0987f92b29b99195bf
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoTest for OffsetMap 97/16197/2
Ladislav Borak [Mon, 9 Mar 2015 14:32:40 +0000 (15:32 +0100)]
Test for OffsetMap

Change-Id: I2696bb79d5bd30f6697abd407c898f0872d3a163
Signed-off-by: Ladislav Borak <lborak@cisco.com>
9 years agoTest for BestPathSelector 96/16196/5
Ladislav Borak [Mon, 9 Mar 2015 12:58:48 +0000 (13:58 +0100)]
Test for BestPathSelector

Change-Id: I62dd07b1dd4062fe6c5d70fc3d9ee29506f6d609
Signed-off-by: Ladislav Borak <lborak@cisco.com>
9 years agoMerge "Remove bundle tests"
Dana Kutenicsova [Thu, 12 Mar 2015 08:05:01 +0000 (08:05 +0000)]
Merge "Remove bundle tests"

9 years agoRemove bundle tests 50/16350/1
Robert Varga [Wed, 11 Mar 2015 22:00:34 +0000 (23:00 +0100)]
Remove bundle tests

Bundles are already tested in features, so we do not need these
hard-to-maintain tests.

Change-Id: I9c03b841892aa8d8f28417c910de15d4cd407d2a
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoRemoved some sonar warnings in the new RIB code. 00/16200/4
Dana Kutenicsova [Mon, 9 Mar 2015 15:50:36 +0000 (16:50 +0100)]
Removed some sonar warnings in the new RIB code.

- mostly attribute ordering, annotations are first
- final in method declaration is rarely necessary
- added default case to switch statements

Change-Id: I44abf4512fe64eb59504e0081d3dc88f23381960
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoFixed MD-SAL configuration mock. 36/16336/4
Tony Tkacik [Wed, 11 Mar 2015 16:12:40 +0000 (17:12 +0100)]
Fixed MD-SAL configuration mock.

Change-Id: I6da602da465f6481c9e3a1ebadc6ef54aa7329e0
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoMerge "Bug 2795 - Internal PCEP features hierarchy does not reflect config files"
Dana Kutenicsova [Wed, 11 Mar 2015 07:28:20 +0000 (07:28 +0000)]
Merge "Bug 2795 - Internal PCEP features hierarchy does not reflect config files"

9 years agoPushed missing .project files. 60/16260/1
Dana Kutenicsova [Tue, 10 Mar 2015 13:05:48 +0000 (14:05 +0100)]
Pushed missing .project files.

Change-Id: I0ee592cbb52ce89ed186ac5edb08a15dc8e6514d
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBug 2795 - Internal PCEP features hierarchy does not reflect config files 55/16255/2
Ladislav Borak [Tue, 10 Mar 2015 11:13:15 +0000 (12:13 +0100)]
Bug 2795 - Internal PCEP features hierarchy does not reflect config files

- added odl-bgpcep-programming-impl feature as depedency of
  odl-bgpcep-pcep-topology-provider feature

Change-Id: I5b306d6caa9a05bd14924da9daaeb50a853a900e
Signed-off-by: Ladislav Borak <lborak@cisco.com>
9 years agoBUG-2383: document AbstractRIBSupport abstract methods 46/16246/2
Robert Varga [Tue, 10 Mar 2015 09:23:12 +0000 (10:23 +0100)]
BUG-2383: document AbstractRIBSupport abstract methods

Add javadoc and rename for consistency.

Change-Id: I153f7f0ecfccd45084b95779a514a23008d30296
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoMerge "BUG-2383: construct route entry properly"
Dana Kutenicsova [Tue, 10 Mar 2015 09:44:49 +0000 (09:44 +0000)]
Merge "BUG-2383: construct route entry properly"

9 years agoMerge "BUG-2383: implement EffectiveRibInWriter"
Dana Kutenicsova [Tue, 10 Mar 2015 09:44:04 +0000 (09:44 +0000)]
Merge "BUG-2383: implement EffectiveRibInWriter"

9 years agoMerge "BUG-2383 : synchronize message/route linkstate core in model"
Robert Varga [Tue, 10 Mar 2015 09:27:05 +0000 (09:27 +0000)]
Merge "BUG-2383 : synchronize message/route linkstate core in model"

9 years agoBUG-2383: construct route entry properly 21/16221/1
Robert Varga [Mon, 9 Mar 2015 22:33:33 +0000 (23:33 +0100)]
BUG-2383: construct route entry properly

This adds the code to add attributes onto the route object.

Change-Id: Ibeee10d21114ae2344fbacb3d92ab6aa03da9354
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-2383: implement EffectiveRibInWriter 17/16217/5
Robert Varga [Mon, 9 Mar 2015 18:25:17 +0000 (19:25 +0100)]
BUG-2383: implement EffectiveRibInWriter

This completes the basic structure of EffectiveRibInWriter, such that
its flows are stable API-wise.

Change-Id: Idebad5a1d05667cdd767d16dc9278574dba1d3f6
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-2383 : synchronize message/route linkstate core in model 34/16134/8
Dana Kutenicsova [Fri, 6 Mar 2015 12:52:51 +0000 (13:52 +0100)]
BUG-2383 : synchronize message/route linkstate core in model

- there is no need to have the data in linkstate described in
two ways (for parser and for RIB). This commit eliminates the
parser data representation and uses RIB data represenation.
- the code and tests needed to be adjusted
- NlriType is eliminated from the data

Change-Id: I364b7f2d26dc44e0d22d0f7358c3e0d6991322bf
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-2383: Make TableContext.clearTable() reusable 16/16216/2
Robert Varga [Mon, 9 Mar 2015 17:39:47 +0000 (18:39 +0100)]
BUG-2383: Make TableContext.clearTable() reusable

An input table context is bound to a table. Refactor clearTable() to be
usable from other contexts, too.

Change-Id: Ic91326bf9f931f8dc1298ba67439253dece50e4c
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-2383: introduce ExportPolicyPeerTracker 95/16095/5
Robert Varga [Thu, 5 Mar 2015 20:31:50 +0000 (21:31 +0100)]
BUG-2383: introduce ExportPolicyPeerTracker

This splits out the policy tracker and implemnts proper policy tracking.
We optimize for lookup speeds, expecting the peers not to change much.

Change-Id: I92b27d54abb77ce10864d9ec8709a57aab7b87c7
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-2383: split out AbstractPeerRoleTracker and IdentifierUtils 94/16094/4
Robert Varga [Thu, 5 Mar 2015 20:12:23 +0000 (21:12 +0100)]
BUG-2383: split out AbstractPeerRoleTracker and IdentifierUtils

Functionality of these two classes is shared between multiple listeners,
so move them out to be shared. Also make sure EffectiveRibInWriter
instantiates its policy tracker.

Change-Id: If885ea283ed223cdffe8c14f777192d02cabffde
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoMerge "Do not replicate Sonar config"
Dana Kutenicsova [Thu, 5 Mar 2015 12:57:29 +0000 (12:57 +0000)]
Merge "Do not replicate Sonar config"

9 years agoMerge "Support proper route redistribution"
Dana Kutenicsova [Thu, 5 Mar 2015 12:37:00 +0000 (12:37 +0000)]
Merge "Support proper route redistribution"

9 years agoMerge "BUG-2383: fix a warning"
Dana Kutenicsova [Thu, 5 Mar 2015 12:34:45 +0000 (12:34 +0000)]
Merge "BUG-2383: fix a warning"

9 years agoMerge "BUG-2383: refactor RIBSupportRegistry"
Dana Kutenicsova [Thu, 5 Mar 2015 12:34:33 +0000 (12:34 +0000)]
Merge "BUG-2383: refactor RIBSupportRegistry"

9 years agoMerge "BUG-2383: rename BGPSessionImpl.sendMessage()"
Dana Kutenicsova [Thu, 5 Mar 2015 12:30:17 +0000 (12:30 +0000)]
Merge "BUG-2383: rename BGPSessionImpl.sendMessage()"

9 years agoMerge "BUG-2383: add a non-flushing message write method"
Dana Kutenicsova [Thu, 5 Mar 2015 12:29:48 +0000 (12:29 +0000)]
Merge "BUG-2383: add a non-flushing message write method"

9 years agoMerge "BUG-2383: introduce AdjRibOutListener"
Dana Kutenicsova [Thu, 5 Mar 2015 12:20:44 +0000 (12:20 +0000)]
Merge "BUG-2383: introduce AdjRibOutListener"

9 years agoMerge "BUG-2283: introduce OutputLimiter"
Dana Kutenicsova [Thu, 5 Mar 2015 12:20:01 +0000 (12:20 +0000)]
Merge "BUG-2283: introduce OutputLimiter"

9 years agoMerge "BUG-2383: rework RIB inbound"
Dana Kutenicsova [Thu, 5 Mar 2015 12:18:03 +0000 (12:18 +0000)]
Merge "BUG-2383: rework RIB inbound"

9 years agoBUG-2383: fix a warning 70/16070/1
Robert Varga [Thu, 5 Mar 2015 10:49:48 +0000 (11:49 +0100)]
BUG-2383: fix a warning

The cast is valid, but let's use one which does not trigger a warning.

Change-Id: I577efc001f7b06fce0806fc1149f79116a03bdd5
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-2383: refactor RIBSupportRegistry 69/16069/1
Robert Varga [Thu, 5 Mar 2015 09:12:17 +0000 (10:12 +0100)]
BUG-2383: refactor RIBSupportRegistry

Migrate registration and lookup into RIBExtensionContexts.

Change-Id: Ia1cdfb1052abc923c79ecada0ca62c99d3ed731a
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-2383: rename BGPSessionImpl.sendMessage() 15/16015/4
Robert Varga [Wed, 4 Mar 2015 12:31:19 +0000 (13:31 +0100)]
BUG-2383: rename BGPSessionImpl.sendMessage()

The method performs a write-and-flush, so let's call it writeAndFlush().

Change-Id: I20bc4db103f2a671bed0f33919ae3978c892af11
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-2383: add a non-flushing message write method 14/16014/5
Robert Varga [Wed, 4 Mar 2015 12:27:38 +0000 (13:27 +0100)]
BUG-2383: add a non-flushing message write method

When performing route dissemination, we may need to enqueue multiple
messages before flushing. This patch adds and API to perform that and
add the corresponding capability to ChannelOutputLimiter.

Change-Id: I048c6f6a84ced775ce1890cc1369ee8fff97cd1f
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-2383: introduce AdjRibOutListener 13/16013/6
Robert Varga [Wed, 4 Mar 2015 11:09:58 +0000 (12:09 +0100)]
BUG-2383: introduce AdjRibOutListener

The listener forwards a specific table towards the session with a peer.

Change-Id: I9b1241df2f0d8e8e06d3af62f206232f20d27465
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-2283: introduce OutputLimiter 12/16012/7
Robert Varga [Wed, 4 Mar 2015 11:31:54 +0000 (12:31 +0100)]
BUG-2283: introduce OutputLimiter

This is a simple utility class to perform backpressure based on channel
writability.

Change-Id: I2b4018722eee9dfa88ff92d49d17b969134a7de3
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoDo not replicate Sonar config 68/16068/1
Robert Varga [Thu, 5 Mar 2015 11:03:02 +0000 (12:03 +0100)]
Do not replicate Sonar config

These declarations are already in odlparent, no need to repeat them.

Change-Id: I866a1fa991e251582b8baf78f119bc4282e9227e
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoFix an checkstyle not being recognized by eclipse 67/16067/1
Robert Varga [Thu, 5 Mar 2015 10:57:44 +0000 (11:57 +0100)]
Fix an checkstyle not being recognized by eclipse

Since we override mappings, we need to make sure we carry checkstyle
declaration, otherwise eclipse reports an error.

Change-Id: I6fe6ea161ea963883284f68ed6faffe06f7d8f58
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoMake sure we execute the maven plugin 66/16066/1
Robert Varga [Thu, 5 Mar 2015 10:54:14 +0000 (11:54 +0100)]
Make sure we execute the maven plugin

This will make it easier on the developers, as eclipse will
automatically generate bindings.

Change-Id: I55df6997361195b3da8c506a68527349edb6201a
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoDo not override maven-dependency-plugin version 65/16065/1
Robert Varga [Thu, 5 Mar 2015 10:58:51 +0000 (11:58 +0100)]
Do not override maven-dependency-plugin version

odlparent already defines it to 2.10, we were reverting it to 2.8.

Change-Id: I489264ffa8805f24cc9db355e224c35fcb8cab3d
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-2383: rework RIB inbound 80/15780/22
Robert Varga [Thu, 26 Feb 2015 14:18:39 +0000 (15:18 +0100)]
BUG-2383: rework RIB inbound

Each Peer (like BGPPeer) performs updates the adj-rib-in via a dedicated
AdjRibInWriter instance. That class, along with RIBSupport and TableContext,
is responsible for translating the Binding-Aware messages coming from
the message parser into Binding-Independent form within the datastore.

Changes are then propagated via DataChangeNotifications into
InboundPolicyEnforcer, which performs any munging of attributes required
and checks if the route is eligible for inclusion in the local RIB. If
it is, the route is output into the effective-rib-in hosted in the
datastore.

From there it is picked up by BestPathSelection, which compares the
effective routes from multiple peers and installs the best one into the
local RIB.

Change-Id: Ie23746b2fc44499f42d346595562b498c19fd112
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoMerge "BUG-2383: add BestPathSelector and related classes"
Dana Kutenicsova [Thu, 5 Mar 2015 10:37:56 +0000 (10:37 +0000)]
Merge "BUG-2383: add BestPathSelector and related classes"

9 years agoMerge "BUG-2383: introduce OffsetMap"
Dana Kutenicsova [Thu, 5 Mar 2015 10:30:31 +0000 (10:30 +0000)]
Merge "BUG-2383: introduce OffsetMap"

9 years agoMerge "BUG-2383: fix the RIB model"
Dana Kutenicsova [Thu, 5 Mar 2015 10:28:14 +0000 (10:28 +0000)]
Merge "BUG-2383: fix the RIB model"

9 years agoBUG-2383: add BestPathSelector and related classes 35/15935/8
Robert Varga [Mon, 2 Mar 2015 15:32:04 +0000 (16:32 +0100)]
BUG-2383: add BestPathSelector and related classes

Introduce a utility BestPath class along with a builder-style selector.
The selector can be run incrementally by initiating the state from
previous selection run, then feeding all candidates and finally
extracting the best-matching path.

Change-Id: I34aab7f0c2ab4b917597a77d54508f5d93e6a8c9
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-2383: introduce OffsetMap 36/15936/6
Robert Varga [Mon, 2 Mar 2015 16:02:33 +0000 (17:02 +0100)]
BUG-2383: introduce OffsetMap

For the sectionprocess we will need a compact way of tracing
peer/attribute mappings. Storing things in array is the most compact
form, but we need to manage a lookup table. This is the role of
OffsetMap, which maps an UnsignedInteger (e.g. a BGP Identifier) to an
offset. We then need to only allocate a single array for each entry to
hold the actual values.

Change-Id: I7c4c8b841cca0330f9646e5e629a824fd929f181
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-2383: fix the RIB model 79/15779/8
Robert Varga [Thu, 26 Feb 2015 10:33:20 +0000 (11:33 +0100)]
BUG-2383: fix the RIB model

The overall goal is to store adjacency ribs in the datastore. In order
to do that, we need to fix the (defunct) model, so each peer has a
unique subtree. This patch fixes the model and introduces a peer ID
type, which we will use throughout to identify peers.

Change-Id: I45a4493d0aabb29828e6e935017939a5b09e7b60
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-2749 : deprecate unused methods 85/15885/3
Dana Kutenicsova [Thu, 26 Feb 2015 19:29:49 +0000 (20:29 +0100)]
BUG-2749 : deprecate unused methods

- cannot be removed, they are used in stateful02

Change-Id: I08d149b7fc9dbf376942104d3eb4f35fa1a02a93
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoMerge "BUG-2794 : refactored code to use BitArray"
Robert Varga [Thu, 5 Mar 2015 08:13:34 +0000 (08:13 +0000)]
Merge "BUG-2794 : refactored code to use BitArray"

9 years agoFixed IT breakage after migration of NSF from controller. 31/16031/1
Tony Tkacik [Wed, 4 Mar 2015 16:42:29 +0000 (17:42 +0100)]
Fixed IT breakage after migration of NSF from controller.

PcepServices test declared uncessary dependencies on
model-inventory, which was transitive compile dependency.

Transitive dependency relationship via sal-binding-it
was removed during removal of NSF from controller,
which prevented pax-exam starting these pcep test.

Removed offending declaration, since is not needed
for test to be run.

Change-Id: Ib505bbd0f91407ec6c7f89995b19fe61b1437d94
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoBUG-2794 : refactored code to use BitArray 93/15793/8
Ladislav Borak [Mon, 2 Mar 2015 12:46:07 +0000 (13:46 +0100)]
BUG-2794 : refactored code to use BitArray

Change-Id: I8906ec2b9671cd71916f0e3c4225199cf5963bdc
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Signed-off-by: Ladislav Borak <lborak@cisco.com>
9 years agoMerge "BUG-2794 : created BitArray class"
Robert Varga [Fri, 27 Feb 2015 15:57:31 +0000 (15:57 +0000)]
Merge "BUG-2794 : created BitArray class"

9 years agoGetting rid of readerIndex handling. 96/15796/1
Dana Kutenicsova [Thu, 26 Feb 2015 19:53:42 +0000 (20:53 +0100)]
Getting rid of readerIndex handling.

- in most cases it can be replaced by skipBytes()

Change-Id: Ia2d7fb64f61879bb5404745c270ae5364f051077
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-2794 : created BitArray class 68/15668/9
Dana Kutenicsova [Tue, 24 Feb 2015 16:05:37 +0000 (17:05 +0100)]
BUG-2794 : created BitArray class

Change-Id: I6857fb22eea643d90fb61933fb170b620c6dbf63
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoSupport proper route redistribution 00/14200/4
Robert Varga [Fri, 16 Jan 2015 18:12:27 +0000 (19:12 +0100)]
Support proper route redistribution

For proper route redistribution, we need to properly process received
attributes even if we do not recognize them. The parser needs to output
them as received and on egress we need to munge the value with a new
header, which will force the partial bit to be set to true.

Change-Id: Icc5d3b6393dae7ba6d83df0f8beb596cccc9559a
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoFixup supporting-node requiring also a topology ID 32/15732/1
Robert Varga [Wed, 25 Feb 2015 16:04:57 +0000 (17:04 +0100)]
Fixup supporting-node requiring also a topology ID

The fixed base model requires also a topology reference.

Change-Id: I21e272e8b3a70e89fd9e424a523b40d06575ab75
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoCleaned up dependencies. 99/15499/2
Dana Kutenicsova [Thu, 19 Feb 2015 15:04:29 +0000 (16:04 +0100)]
Cleaned up dependencies.

Change-Id: Iaab661407fcee445199e0be1f1f59abbd22c41e9
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoMerge "Split feature file"
Robert Varga [Tue, 24 Feb 2015 15:15:01 +0000 (15:15 +0000)]
Merge "Split feature file"

9 years agoMerge "Removed linkstate dependency from bgp-parser-impl."
Robert Varga [Tue, 24 Feb 2015 15:03:30 +0000 (15:03 +0000)]
Merge "Removed linkstate dependency from bgp-parser-impl."

9 years agoMerge "BUG-608 : fixed typo"
Robert Varga [Tue, 24 Feb 2015 14:45:17 +0000 (14:45 +0000)]
Merge "BUG-608 : fixed typo"

9 years agoBUG-608 : fixed typo 53/15653/1
Dana Kutenicsova [Tue, 24 Feb 2015 10:32:17 +0000 (11:32 +0100)]
BUG-608 : fixed typo

- ip4 vs ipv4

Change-Id: Ib48cd1df3c6ad156f93a80639980e1f835dbc992
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoMerge "BUG-2712: do not hold lock while updating future"
Dana Kutenicsova [Tue, 24 Feb 2015 10:08:48 +0000 (10:08 +0000)]
Merge "BUG-2712: do not hold lock while updating future"

9 years agoRemoved linkstate dependency from bgp-parser-impl. 52/15652/1
Dana Kutenicsova [Tue, 24 Feb 2015 09:05:10 +0000 (10:05 +0100)]
Removed linkstate dependency from bgp-parser-impl.

Change-Id: Ibe2cf3b6d27514518d1cf015159ccc19a4ce9379
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoRemoved some sonar warnings. 06/15606/3
Dana Kutenicsova [Sun, 22 Feb 2015 21:42:07 +0000 (22:42 +0100)]
Removed some sonar warnings.

Change-Id: I5f152d314c5021134f54f4c1b9ca2fc77d685d0f
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoBUG-2571 : flowspec-routes model 34/15534/2
Dana Kutenicsova [Thu, 19 Feb 2015 10:23:16 +0000 (11:23 +0100)]
BUG-2571 : flowspec-routes model

Change-Id: I8b6ff4c508c82c01ba53268eb9096c98a51df6d5
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoRemove <repositories> and <pluginRepositories> section 45/15145/2
Thanh Ha [Wed, 11 Feb 2015 15:11:29 +0000 (10:11 -0500)]
Remove <repositories> and <pluginRepositories> section

It is recommended that developers and servers configure this locally via
settings.xml.

https://lists.opendaylight.org/pipermail/discuss/2015-January/004482.html

Conflicts:
parent/pom.xml

Change-Id: Ia457b7368d85cf021d434f0262d749c9d954d67c
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
9 years agoBUG-2712: do not hold lock while updating future 11/15411/2
Robert Varga [Tue, 17 Feb 2015 12:47:56 +0000 (13:47 +0100)]
BUG-2712: do not hold lock while updating future

SettableFuture will call any and all registrants, which could
potentially lead to AB/BA deadlocks. with ProgrammingServiceImpl. Issue
the call to set outside a synchronized block.

Change-Id: Iddb268d2157256466b597aaef78002b4f474a149
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoRemoved warnings from linkstate. 33/15533/3
Dana Kutenicsova [Fri, 20 Feb 2015 10:35:25 +0000 (11:35 +0100)]
Removed warnings from linkstate.

- refactored some big methods

Change-Id: Ibf230b2a430ef7b26c4bb80468534852a8d281af
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
9 years agoMerge "Bug 2231 - Parser/Serializer StartTLS"
Dana Kutenicsova [Sun, 22 Feb 2015 17:02:13 +0000 (17:02 +0000)]
Merge "Bug 2231 - Parser/Serializer StartTLS"

9 years agoBug 2231 - Parser/Serializer StartTLS 45/15545/1
Ladislav Borak [Fri, 20 Feb 2015 09:30:01 +0000 (10:30 +0100)]
Bug 2231 - Parser/Serializer StartTLS

- changed type of PCEPStartTLSParser to temporary unused value

- registered parser and serializer into activator

- added parser/serialized test

Change-Id: Ie7ce9a5ad93192e3fbe712a15288f0e3f73915e0
Signed-off-by: Ladislav Borak <lborak@cisco.com>
9 years agoAdded private constructors + tests to linkstate classes. 32/15532/1
Dana Kutenicsova [Fri, 20 Feb 2015 10:34:46 +0000 (11:34 +0100)]
Added private constructors + tests to linkstate classes.

Change-Id: I996eba6cfa0c088e07bfb6d261e732dcb07f0191
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>