lispflowmapping.git
5 years agoUse predictable-order sets 19/78219/1
Robert Varga [Tue, 27 Nov 2018 16:38:16 +0000 (17:38 +0100)]
Use predictable-order sets

MapServerTest requires MapServer to respond with specific order
of items. Use LinkedHashMap/ImmutableSet to achieve that
consistently.

Change-Id: Ia96ac31e434f8fee5095802de446f0b1dc1eeeb7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoMove back to RFC7223 ietf-interfaces 70/77470/1
Robert Varga [Sat, 3 Nov 2018 13:07:11 +0000 (14:07 +0100)]
Move back to RFC7223 ietf-interfaces

This patch moves back from RFC8343 to align with other projects.

Change-Id: I29096cf4539d7ac6058d215819b75630d59e78e2
JIRA: TSC-179
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoNeon MRI changes 55/76055/16
Lorand Jakab [Thu, 25 Oct 2018 16:40:46 +0000 (18:40 +0200)]
Neon MRI changes

This patch bumps:
- odlparent to 4.0.2
- mdsal to 3.0.1

It also deals with:
- adjust dependencies to account for ietf-{inet,yang}-types movement
- new checkstyle failures
- bump odlparent feature version range from [3.1.0,4) to [4,5)
- move to odl-guava instead of the version explicit odl-guava-23
- move blueprints from org/opendaylight to OSGI-INF directory

JIRA: LISPMAP-175
Change-Id: Ia065800c9b92362371550f8e9c93eb6f3da57d4e
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
5 years agoMigrate lispflowmapping docs to the lispflowmapping project 79/75879/2
Thanh Ha [Sun, 9 Sep 2018 00:59:49 +0000 (20:59 -0400)]
Migrate lispflowmapping docs to the lispflowmapping project

Issue: DOCS-69
Change-Id: Ib05130afdc3e7ee07290e4203540baa7ece7e5fd
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoBootstrap lispflowmapping documentation 78/75878/2
Thanh Ha [Sun, 9 Sep 2018 00:58:51 +0000 (20:58 -0400)]
Bootstrap lispflowmapping documentation

Issue: DOCS-69
Change-Id: I610b370026a2741745f5c76f000898ae45770861
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoRemove references to mdsal-model-artifacts 22/75122/1
Robert Varga [Sat, 11 Aug 2018 07:38:30 +0000 (09:38 +0200)]
Remove references to mdsal-model-artifacts

This artifact is going away, migrate to mdsal-artifacts.

Change-Id: Iec98569ca92554f667a58e5aaaf53758e2c574d9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoBump versions by x.(y+1).z for next dev cycle 93/74993/1
Anil Belur [Thu, 9 Aug 2018 12:40:15 +0000 (18:10 +0530)]
Bump versions by x.(y+1).z for next dev cycle

Change-Id: I000419083e6d485488baa86b3619d8399b8e4fab
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
5 years agoDon't use Futures.transform() removed in Guava 26 46/74846/1
Lorand Jakab [Mon, 6 Aug 2018 11:14:21 +0000 (13:14 +0200)]
Don't use Futures.transform() removed in Guava 26

See https://lists.opendaylight.org/pipermail/release/2018-August/015735.html

Change-Id: I9ba0b1445af2d40d9d907608ff6ea306f8996d34
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
5 years agoBump to odlparent 3.1.3 98/74198/3
Stephen Kitt [Wed, 18 Jul 2018 16:06:39 +0000 (18:06 +0200)]
Bump to odlparent 3.1.3

Change-Id: I31e36b73fe9769d562e8e5eb2e370fa2ce722a6d
Signed-off-by: Stephen Kitt <skitt@redhat.com>
5 years agoMigrate to use stringValue() 00/74300/2
Robert Varga [Sat, 21 Jul 2018 05:40:41 +0000 (07:40 +0200)]
Migrate to use stringValue()

This migrates away from char[]-based getValue() and constructors.

Change-Id: I6cf3c40361352629e5810969f7f01148f31d7ba0
JIRA: MDSAL-364
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoAdd rfc7223/7224/7277 models 27/74227/1
Robert Varga [Thu, 19 Jul 2018 10:20:51 +0000 (12:20 +0200)]
Add rfc7223/7224/7277 models

With sal-dom-broker no longer masking these, we need to specify
them as features.

Change-Id: Ia056266f6647513c406c1318e55100f0ae57f04a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoUse specific models 37/74137/3
Robert Varga [Tue, 17 Jul 2018 17:01:48 +0000 (19:01 +0200)]
Use specific models

Rather than pulling odl-mdsal-models, pull specific models we need.

JIRA: MDSAL-363
Change-Id: I581554a83cc373d5c75d1139a8c1162f5405619c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoUse version ranges for odlparent feature deps 87/73487/2
Stephen Kitt [Wed, 27 Jun 2018 16:29:01 +0000 (18:29 +0200)]
Use version ranges for odlparent feature deps

This helps with upgrades and bump merges.

This patch also adds a dependency on the Guava feature.

Change-Id: Ifc6c40534e143a9589998f138c0a4378a980aff8
Signed-off-by: Stephen Kitt <skitt@redhat.com>
5 years agoAdd missing list keys where necessary 14/73614/1
Lorand Jakab [Fri, 29 Jun 2018 18:13:29 +0000 (20:13 +0200)]
Add missing list keys where necessary

Change-Id: Ibbb006dcceb03a5cd7d47a8b09187bd8c766fbaf
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
5 years agoBump odlparent to 3.1.2 95/72495/2
Stephen Kitt [Wed, 30 May 2018 13:46:04 +0000 (15:46 +0200)]
Bump odlparent to 3.1.2

Change-Id: I6e8ff01471ff281610e9942ae2e7a41819f8f55a
Signed-off-by: Stephen Kitt <skitt@redhat.com>
5 years agoAdd ignore-lispflowmapping-integrationtest profile 93/73193/1
Lorand Jakab [Tue, 19 Jun 2018 12:57:06 +0000 (14:57 +0200)]
Add ignore-lispflowmapping-integrationtest profile

The purpose of this profile is allow ignoring the results of the
integration tests. This would allow autorelease builds to pass even if
lispflowmapping integration tests fail, while keeping the test logs
around for debugging.

Change-Id: I05163d1f86eb318a92d5f00dfc8887492254bd02
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
5 years agoAdd explicit org.osgi.core dependency 49/73049/1
Tom Pantelis [Sat, 16 Jun 2018 01:33:21 +0000 (21:33 -0400)]
Add explicit org.osgi.core dependency

This was picked up transitively from config-api but that
is going away.

Change-Id: If83618e677a3082048632076192293438fcb148c
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
5 years agoRemove uses of BindingAwareProvider 05/72805/1
Tom Pantelis [Fri, 8 Jun 2018 17:15:52 +0000 (13:15 -0400)]
Remove uses of BindingAwareProvider

This is legacy and will eventually be deprecated/removed.

Change-Id: I3e643a8b8f2778caa4c85749409e86effe498bf5
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
5 years agoFix integrationtest log levels 83/72783/2
Lorand Jakab [Fri, 8 Jun 2018 10:18:25 +0000 (12:18 +0200)]
Fix integrationtest log levels

The TRACE level Karaf logging configuration for lispflowmapping no
longer works. Use an alternative, more realiable and independent way of
configuring it.

Change-Id: Idf91b7abf4c295d52d63f117e28e7a30b6332e09
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
5 years agoKeep integrationtest runtime folder 08/72508/3
Lorand Jakab [Wed, 30 May 2018 17:19:20 +0000 (19:19 +0200)]
Keep integrationtest runtime folder

It is very helpful to have the full Karaf environment used for the
integrationtest stay available after the test finishes. It lives in the
integrationtest/target/exam/{guid} folder, and has the full (~350MB)
Karaf distribution.

The most useful piece is the data/log/karaf.log file, which can be
examined in case of a failure. Other useful pieces are the configuration
files in etc/ which are modified by the integrationtests.

The patch makes sure to delete any existing such runtime environment, to
avoid developers building up many such folders, which takes up a lot of
space, and makes it harder to determine which environment was the last
one.

When running builds in Jenkins, only the log files are saved to the log
server, so the impact is minimal, but it helps debugging integration
test failures which occur on the CI infrastructure.

Change-Id: I11e92efebf6d74c95e4ddf12d02c4ba98462d8ba
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoFixup Augmentable and Identifiable methods changing 28/72228/1
Lorand Jakab [Thu, 24 May 2018 10:03:15 +0000 (12:03 +0200)]
Fixup Augmentable and Identifiable methods changing

This is a fixup of the change in binding codegen, adjusting:
  - getKey() -> key()
  - setKey() -> withKey()
  - getAugmentation() -> augmentation()

JIRA: TSC-101
Change-Id: I2a5c5a0e1e9b36870717ef232c9f1940bd7d6c4a
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoAdjust to RPC method signature update 07/71807/2
Lorand Jakab [Fri, 4 May 2018 18:47:23 +0000 (20:47 +0200)]
Adjust to RPC method signature update

Input/Output structures are always present and we need to return
ListenableFuture.

JIRA: TSC-99
Change-Id: I985feb0261ba73192a656c3c8803e0a258b28b80
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoEnable and update integration tests to use Log4J2 93/68993/4
Lorand Jakab [Fri, 2 Mar 2018 08:50:45 +0000 (10:50 +0200)]
Enable and update integration tests to use Log4J2

Change-Id: Ie55ad30f225d8d94dc7091c96c7ebf97a1816a1a
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoRevert "Adapt to IetfInetUtil change" 93/71193/1
Faseela K [Sun, 22 Apr 2018 17:53:54 +0000 (23:23 +0530)]
Revert "Adapt to IetfInetUtil change"

This reverts commit 1025f0aa152c0d3ca1514dd21cf7af5d8312c9cd.

Change-Id: Ibed626270a9e2cf5121da57d30724383b38dc537
Signed-off-by: Faseela K <faseela.k@ericsson.com>
6 years agoRevert "Add Karaf build profile" 53/70753/3
Thanh Ha [Wed, 11 Apr 2018 02:06:31 +0000 (02:06 +0000)]
Revert "Add Karaf build profile"

This reverts commit 37c6bb104b8884ef35a836dec739e9451e3f757f.

Change-Id: I152631e086a9f98d2d0996f7b147341c23c77456
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
6 years agoAdapt to IetfInetUtil change 04/71104/1
Lorand Jakab [Thu, 19 Apr 2018 09:29:10 +0000 (11:29 +0200)]
Adapt to IetfInetUtil change

Change-Id: Ic8046f1dc07ea3441a138065399cd1a59376a818
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoMerge "Bump to odlparent 3.1.0 and yangtools 2.0.3"
Thanh Ha [Mon, 16 Apr 2018 18:52:37 +0000 (18:52 +0000)]
Merge "Bump to odlparent 3.1.0 and yangtools 2.0.3"

6 years agoUse ietf-ip.yang from mdsal instead of our own 81/70781/1
Lorand Jakab [Wed, 11 Apr 2018 12:57:58 +0000 (15:57 +0300)]
Use ietf-ip.yang from mdsal instead of our own

Change-Id: I368657319c6fa22a6dd93507af479dfb2edc64f0
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoBump to odlparent 3.1.0 and yangtools 2.0.3 69/69869/3
Stephen Kitt [Thu, 22 Mar 2018 17:24:26 +0000 (18:24 +0100)]
Bump to odlparent 3.1.0 and yangtools 2.0.3

Change-Id: I36aecf3c093a8a85da8b0fafddfa6df38435d825
Signed-off-by: Stephen Kitt <skitt@redhat.com>
6 years agoAdd Karaf build profile 27/70527/1
Thanh Ha [Sat, 7 Apr 2018 02:21:23 +0000 (22:21 -0400)]
Add Karaf build profile

Project local Karaf distros are handy for devs to test their work
however is unneeded by autorelease builds and should not be released
as part of the Simultanious Release. Add a profile that is active by
default so that default behaviour is unchanged however allows the
autorelease project to disable building this module.

Issue: RELENG-86
Change-Id: I0a2aa794fa5e17cf6148a1f709257047ee0da00a
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
6 years agoRemove obsolete Maven Site configuration 26/70526/1
Thanh Ha [Sat, 7 Apr 2018 02:20:50 +0000 (22:20 -0400)]
Remove obsolete Maven Site configuration

Change-Id: I485b5ebacf6830406900332af959dec299e163cc
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
6 years agoRemove dependency on Honeycomb/VBD 70/70170/2
Lorand Jakab [Wed, 28 Mar 2018 23:15:06 +0000 (02:15 +0300)]
Remove dependency on Honeycomb/VBD

Change-Id: I1f4213c18773934760fa6d9745f37fe69cfbeba6
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoRemove the user interface feature 68/70168/1
Lorand Jakab [Wed, 28 Mar 2018 21:00:12 +0000 (00:00 +0300)]
Remove the user interface feature

DLUX is no longer maintained and will be archived, so remove the user
interface feature to get rid of the dependency. This is required for
becoming a Managed Project, since lispflowmapping can only depend on
other Managed Projects, and DLUX didn't request to become managed.

See https://lists.opendaylight.org/pipermail/release/2018-March/014520.html

Change-Id: Ib89bdd3f8444515487ad1ac154a46ab7608e05d9
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoFix some POM file warnings 01/69501/2
Lorand Jakab [Wed, 14 Mar 2018 13:42:11 +0000 (15:42 +0200)]
Fix some POM file warnings

Change-Id: Ica83946a572544508e06358a35fabb2f2fe03a3d
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoBump versions by x.(y+1).z for next dev cycle 39/68739/1
Anil Belur [Mon, 26 Feb 2018 07:41:44 +0000 (17:41 +1000)]
Bump versions by x.(y+1).z for next dev cycle

Change-Id: Ied56b56d34e8730849ea4da559d183a67e2ed44a
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
6 years agoRemove unnecessary explicit yangtools dependencies 85/67285/2
Lorand Jakab [Thu, 18 Jan 2018 22:51:14 +0000 (00:51 +0200)]
Remove unnecessary explicit yangtools dependencies

Change-Id: Ib20d994c6eae59a045400bacb8985c9270c1ad96
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoDisable integration tests 17/67217/1
Lorand Jakab [Tue, 16 Jan 2018 18:14:17 +0000 (20:14 +0200)]
Disable integration tests

After the Jenkins infrastructure was moved to a different cloud,
integration tests started failing in different ways, even after VMs were
upgraded to 4 vCPUs. This patch disables them until we can figure out a
proper fix, to unblock version bumping.

Change-Id: I5302b80cceb25346f739ac3ab6ecd63d82ee1b55
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoBump to yangtools-2.0.0 and odlparent-3.0.2 82/66482/2
Tom Pantelis [Mon, 8 Jan 2018 22:18:37 +0000 (00:18 +0200)]
Bump to yangtools-2.0.0 and odlparent-3.0.2

Change-Id: I6a95552ea003b74e10530bd448fea6c6264c4697
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoFix odlparent 3 Checkstyle issues 81/66481/2
Tom Pantelis [Thu, 14 Dec 2017 23:00:24 +0000 (18:00 -0500)]
Fix odlparent 3 Checkstyle issues

Change-Id: Ida69b8e8c3a3e4964887230d645e8da0d153c4f7
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
6 years agoMerge "Add IT for mapping change events"
Vina Ermagan [Wed, 20 Dec 2017 18:36:47 +0000 (18:36 +0000)]
Merge "Add IT for mapping change events"

6 years agoMerge "Bug 9116: Fix negative mapping handling"
Vina Ermagan [Wed, 13 Dec 2017 05:58:18 +0000 (05:58 +0000)]
Merge "Bug 9116: Fix negative mapping handling"

6 years agoAdd IT for mapping change events 33/63333/28
Lorand Jakab [Tue, 12 Sep 2017 17:41:01 +0000 (20:41 +0300)]
Add IT for mapping change events

Change-Id: I5cf2c201a48f34dcbb07b81a3e3d60c56f58bbf5
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoBug 9116: Fix negative mapping handling 20/66320/1
Lorand Jakab [Fri, 8 Dec 2017 10:46:23 +0000 (12:46 +0200)]
Bug 9116: Fix negative mapping handling

Change-Id: I23022dc9481e52363cbb4768caf17a44894e74ee
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoBug 9171: Fix lookup when first result is expired 01/66001/3
Lorand Jakab [Tue, 28 Nov 2017 10:36:08 +0000 (12:36 +0200)]
Bug 9171: Fix lookup when first result is expired

When looking up southbound mappings, we check if they are expired, in
which case we remove them and return null. This patch keeps looking up
mappings after deletion, since a valid non-expired mapping matching the
lookup key may still exist.

JIRA: LISPMAP-168

Change-Id: I73550275cc27215296dd7b51c1708e6c7a5f8791
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoBug 9116: Move notification logic to MappingSystem 23/65723/6
Lorand Jakab [Wed, 15 Nov 2017 12:22:00 +0000 (14:22 +0200)]
Bug 9116: Move notification logic to MappingSystem

JIRA: LISPMAP-165

Change-Id: I78c66d7801118536729fdf3e8fe42d5312129cef
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoBug 9116: SMR children of a prefix too 54/63954/17
Lorand Jakab [Tue, 12 Sep 2017 17:41:01 +0000 (20:41 +0300)]
Bug 9116: SMR children of a prefix too

JIRA: LISPMAP-165

Change-Id: I99800a800cef37a5d9cd1b33fe2e13a6d1ca1f5d
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoFix NPE in MappingSystem#removeMapping() 08/66008/1
Lorand Jakab [Tue, 28 Nov 2017 14:34:25 +0000 (16:34 +0200)]
Fix NPE in MappingSystem#removeMapping()

JIRA: LISPMAP-173

Change-Id: I61540332110869c1bacc670695b378c268298a76
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoPrepare for odlparent 3.0.0 checkstyle rules 26/63326/10
Lorand Jakab [Wed, 20 Sep 2017 11:09:23 +0000 (14:09 +0300)]
Prepare for odlparent 3.0.0 checkstyle rules

Odlparent 3.0.0 will have updated checkstyle rules, see [0] for details.
This patch makes sure the code base will pass those new rules when we
upgrade.

[0] https://lists.opendaylight.org/pipermail/release/2017-September/012353.html

Change-Id: I5d8165f21a276468a2e2262fb106792b0e670885
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoBug 9311: Remove expired mappings before printing 41/64441/2
Lorand Jakab [Wed, 18 Oct 2017 11:41:49 +0000 (14:41 +0300)]
Bug 9311: Remove expired mappings before printing

Change-Id: I11aa5ab1b8313c7f1bca5968ab486afc7cd45ec7
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoBug 9116: Add getChildPrefixes() method to caches 56/63056/14
Lorand Jakab [Fri, 8 Sep 2017 12:26:24 +0000 (15:26 +0300)]
Bug 9116: Add getChildPrefixes() method to caches

As a first step to fixing the bug, we need a way to find child prefixes
of a given prefix.

Change-Id: Icaf45888766e79fb2800fb4e24f3aa4e67eb580e
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoMerge "Refactor integration tests"
Vina Ermagan [Mon, 9 Oct 2017 23:45:04 +0000 (23:45 +0000)]
Merge "Refactor integration tests"

6 years agoMerge "Bug 9127: Make IT more robust when receiving packets"
Vina Ermagan [Mon, 9 Oct 2017 23:43:25 +0000 (23:43 +0000)]
Merge "Bug 9127: Make IT more robust when receiving packets"

6 years agoReplace deprecated Futures.addCallback by the newer version 52/64052/1
David Suarez [Mon, 9 Oct 2017 09:28:09 +0000 (11:28 +0200)]
Replace deprecated Futures.addCallback by the newer version

The method addCallback(ListenableFuture<V> future,
FutureCallback<? super V> callback) is deprecated and will be replaced
by a new its new version addCallback(ListenableFuture<V> future,
FutureCallback<? super V> callback, Executor executor) in April 2018.

Change-Id: I99f92ba310b6c0ebf0709b4d8455e596c7a12c47
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
6 years agoMake some improvements 60/63960/2
David Suarez [Wed, 4 Oct 2017 20:21:05 +0000 (22:21 +0200)]
Make some improvements

- Declare some variable finals
- Final for utility classes
- Reduce access level to variables and methods
- Simplification of boolean expressions

Change-Id: I76892a88dd8f04c4909eb5e99bf9c35d65cecc39
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
6 years agoRefactor integration tests 25/62925/6
Lorand Jakab [Fri, 8 Sep 2017 17:02:04 +0000 (20:02 +0300)]
Refactor integration tests

Many methods in integration tests were created ad-hoc to solve a
problem, without checking that methods performing similar functions
already exist and can be reused.

This patch factors out some of those methods to a separate utility
class, and migrates existing users to those methods. They are also
sorted according to functionality within the new file, and documented
with JavaDoc, so it's easier to figure what they offer.

This refactoring is not exhaustive, and may be continued in follow-up
patches.

Change-Id: I14d2a0abaa9d1cb59ff241eecd7e184165701ea6
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoBug 9127: Make IT more robust when receiving packets 44/62544/8
Lorand Jakab [Fri, 1 Sep 2017 13:14:47 +0000 (16:14 +0300)]
Bug 9127: Make IT more robust when receiving packets

Methods of the type receiveMapNotify() pass the raw packet to a specific
deserializer without checking if the packet is actually of the correct
type. Deserializers expect checking to happen outside, and deserialize
anyway. In some cases, they even succeed without throwing an exception,
with erroneous results. This is obviously bad.

This patch fixes the serializers to throw an exception when the wrong
packet type is passed for deserialization. It also makes the
receiveXXX() methods in the IT to retry until they receive the expected
packet type.

In some cases, a Map-Register can cause an SMR to be sent. SMRs are sent
in a separate thread. This may lead to a race condition beween the
Map-Notify sent back to the xTR and the SMR sent to the subscriber. In
some cases, we expect a Map-Notify, but deserialize an SMR as a
Map-Notify, if it comes first. We had IT fail in the past with a message
of the type:

MappingServiceIntegrationTest.testLCAFs:357->registerAndQuery__SrcDestLCAF:1828->registerAddressAndQuery:1789 expected:<8> but was:<-859317697383733792>

This patch finally fixes that.

It needs to disable testRepeatedSmr() though, because the test is
broken, and it never actually worked as intended. It will be fixed in a
future commit.

Change-Id: Ife4396013df82cb6320978c3c02536df91fba646
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoBump lispflowmapping to use yangtools 1.2.0 19/63819/3
Anil Belur [Fri, 29 Sep 2017 02:16:31 +0000 (12:16 +1000)]
Bump lispflowmapping to use yangtools 1.2.0

Jira: releng-485

Change-Id: Ib613354574a745452986d1d4afb096b303d781c5
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
6 years agoBump odlparent 2.0.4 to 2.0.5 23/63623/1
Stephen Kitt [Wed, 27 Sep 2017 13:34:33 +0000 (15:34 +0200)]
Bump odlparent 2.0.4 to 2.0.5

Change-Id: I4c7e96da4721264323f31ad610ebfb57088dec62
Signed-off-by: Stephen Kitt <skitt@redhat.com>
6 years agoMove usage of StringBuffer -> StringBuilder 33/63233/2
Lorand Jakab [Mon, 18 Sep 2017 12:43:10 +0000 (15:43 +0300)]
Move usage of StringBuffer -> StringBuilder

Sonar is complaining about using the old StringBuffer class and
recommends using the newer StringBuilder.

Change-Id: Iea5b64e94e1a4e3f2b2c10f341e55b4f288baac8
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoBug 9172: Don't store subscribers with "No Address" source EID 78/63178/1
Lorand Jakab [Fri, 15 Sep 2017 19:44:50 +0000 (22:44 +0300)]
Bug 9172: Don't store subscribers with "No Address" source EID

Change-Id: Ifc9bc62c875c4a6bd42bf9b53286dd461cd2f7cc
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoMerge "Rename LispSouthboundServiceTest.java -> LispSouthboundHandlerTest.java"
Vina Ermagan [Mon, 11 Sep 2017 20:53:28 +0000 (20:53 +0000)]
Merge "Rename LispSouthboundServiceTest.java -> LispSouthboundHandlerTest.java"

6 years agoBug 9037: Fix positive overlapping negative 90/62690/3
Lorand Jakab [Tue, 5 Sep 2017 10:08:42 +0000 (13:08 +0300)]
Bug 9037: Fix positive overlapping negative

Change-Id: I026d94ed9604287a0dae1a3bba2dc0f201c38793
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoBug 7947: Move subscribers to a separate cache 91/62491/6
Lorand Jakab [Thu, 31 Aug 2017 10:26:28 +0000 (13:26 +0300)]
Bug 7947: Move subscribers to a separate cache

Change-Id: I2cfa03b2dcdcea21e5c4382747b7317f4eb5f30b
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoRename LispSouthboundServiceTest.java -> LispSouthboundHandlerTest.java 39/62539/2
Lorand Jakab [Fri, 1 Sep 2017 10:37:27 +0000 (13:37 +0300)]
Rename LispSouthboundServiceTest.java -> LispSouthboundHandlerTest.java

So that the name reflects the tested class

Change-Id: I5b92e1a8c7113136463547f57a58585516882345
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoRevert "Bug 7947: Store MappingOrigin in MappingData" 90/62490/2
Lorand Jakab [Wed, 30 Aug 2017 11:29:44 +0000 (14:29 +0300)]
Revert "Bug 7947: Store MappingOrigin in MappingData"

This reverts commit 8dcc9410db67deddd3fe3a35e53a28e5d64ddfc8.

Change-Id: I22fc039b21a4ac94aca0ef32aa27b64b9c557389
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoBug 9023: Fix merging of negative prefixes 74/62274/3
Lorand Jakab [Tue, 20 Jun 2017 11:54:10 +0000 (14:54 +0300)]
Bug 9023: Fix merging of negative prefixes

This happens after a positive mapping removal. Add integration test to
keep from regressing.

Change-Id: I32788e8af5b457bf895197ba11add34e8ae06c57
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoBug 8746: Multi-threading improvements 64/61164/7
Lorand Jakab [Fri, 4 Aug 2017 12:10:24 +0000 (15:10 +0300)]
Bug 8746: Multi-threading improvements

Remove all state from SB handlers

This needs a significant rework of the LispSouthboundServiceTest test
class, moving even more functionality to Mockito, so eventually we can
remove the dependency on the old unittest.tools.

Change-Id: I901c5633cb60563ac5bc38a521796dad2186886a
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoBug 7947: Store MappingOrigin in MappingData 22/61622/3
Lorand Jakab [Tue, 4 Apr 2017 16:20:14 +0000 (19:20 +0300)]
Bug 7947: Store MappingOrigin in MappingData

As a first step towards separate subscriber storage, based on origin,
this patch adds support for storing the origin of a mapping in the
MappingData object. The origin is defined as a Set, to support the use
case of returning a combined mapping with information from different
origins, such as the NB_AND_SB policy surrently.

This patch doesn't change behavior yet, it just stores the origin.

Change-Id: Id285e829fed794de9ecf40ee9a9cb5e775228e92
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoMerge "Bug 8746: Multi-threading improvements"
Vina Ermagan [Wed, 16 Aug 2017 04:28:02 +0000 (04:28 +0000)]
Merge "Bug 8746: Multi-threading improvements"

6 years agoMerge "Remove our NETCONF component"
Vina Ermagan [Wed, 16 Aug 2017 03:50:07 +0000 (03:50 +0000)]
Merge "Remove our NETCONF component"

6 years agoRemove our NETCONF component 75/61475/3
Lorand Jakab [Thu, 10 Aug 2017 08:41:26 +0000 (11:41 +0300)]
Remove our NETCONF component

Our NETCONF connector has not been updated since several releases, and
any attempt to make it work again would likely mean reimplementing from
scratch. It is using the config subsystem too.

Worst case, if we still need to code for whatever reason, we can
resurrect it from old Git revisions.

Change-Id: Ia3e9479a1e83fbdc1f69d946c197e8f39ca9e9a4
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoBug 8112: IT: send SMR-invoked Map-Request on SMR 86/54186/8
Lorand Jakab [Fri, 31 Mar 2017 11:40:45 +0000 (14:40 +0300)]
Bug 8112: IT: send SMR-invoked Map-Request on SMR

Change-Id: I3458ef941460ad5af91ef097c16f17894f5bbfa9
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoBug 8469: Account for losing prefix length in Source EID 56/61556/3
Lorand Jakab [Fri, 11 Aug 2017 17:11:20 +0000 (20:11 +0300)]
Bug 8469: Account for losing prefix length in Source EID

Change-Id: I188d3001d887ade55be3a90738f74d0bace48c81
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoBump versions by x.(y+1).z for next dev cycle 89/61689/1
Thanh Ha [Mon, 14 Aug 2017 17:29:07 +0000 (13:29 -0400)]
Bump versions by x.(y+1).z for next dev cycle

Change-Id: Ib445f2ab3278c9024ca36329a351eeaa8f3e062e
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
6 years agoBug 8746: Multi-threading improvements 20/61320/2
Lorand Jakab [Mon, 7 Aug 2017 17:34:20 +0000 (20:34 +0300)]
Bug 8746: Multi-threading improvements

Fix southbound Map-Register cache authentication update code

Change-Id: I616d199e1fc6f37357c35ac75a9c60c5884068f7
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoMerge "Bug 8746: Multi-threading improvements"
Vina Ermagan [Mon, 14 Aug 2017 00:13:54 +0000 (00:13 +0000)]
Merge "Bug 8746: Multi-threading improvements"

6 years agoMerge "Bump odlparent 2.0.2 to 2.0.4"
Lori Jakab [Thu, 10 Aug 2017 04:43:47 +0000 (04:43 +0000)]
Merge "Bump odlparent 2.0.2 to 2.0.4"

6 years agoBump odlparent 2.0.2 to 2.0.4 44/61344/2
Stephen Kitt [Tue, 8 Aug 2017 16:14:05 +0000 (18:14 +0200)]
Bump odlparent 2.0.2 to 2.0.4

Change-Id: Ie310e026eb3408b236be40dffdea58171a8e166a
Signed-off-by: Stephen Kitt <skitt@redhat.com>
6 years agoMerge "Switch to MD-SAL LISP address model"
Vina Ermagan [Tue, 8 Aug 2017 18:25:51 +0000 (18:25 +0000)]
Merge "Switch to MD-SAL LISP address model"

6 years agoBug 8746: Multi-threading improvements 09/59509/6
Lorand Jakab [Mon, 26 Jun 2017 07:52:35 +0000 (10:52 +0300)]
Bug 8746: Multi-threading improvements

- Remove non-concurrent statistics class
- Make some variables 'volatile'
- Make some methods 'synchronized'

Change-Id: I83471fe7a422e63c2ab90e4c5fbc97b69c187247
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoSwitch to MD-SAL LISP address model 40/60940/3
Lorand Jakab [Mon, 31 Jul 2017 15:08:55 +0000 (18:08 +0300)]
Switch to MD-SAL LISP address model

ietf-lisp-address-types.yang was added to MD-SAL in [0] with the
intention to be the canonical place for the model. This patch removes
this model from lispflowmapping and switches to using that model.

[0] https://git.opendaylight.org/gerrit/#/c/60528/

Change-Id: Ib731bf9f10efd7f4417d3ea8cb1b73018519062f
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoBug 8764: Fix handling of old negative 18/59618/6
Lorand Jakab [Wed, 28 Jun 2017 12:35:45 +0000 (15:35 +0300)]
Bug 8764: Fix handling of old negative

Change-Id: Ia3295c955ecf7b364865e445cb7f75a0ec80a6bf
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoRemove config subsystem remnants 09/61209/1
Tom Pantelis [Fri, 4 Aug 2017 20:02:16 +0000 (16:02 -0400)]
Remove config subsystem remnants

lispflowmapping no longer uses the config subsystem so remove
remnants from the pom.

Change-Id: Ia211b670d6c3277f0ebc164fe1676f203c7a79cc
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
6 years agoMerge "Return negative mapping with 0 TTL for deletion"
Vina Ermagan [Fri, 21 Jul 2017 05:03:42 +0000 (05:03 +0000)]
Merge "Return negative mapping with 0 TTL for deletion"

6 years agoReturn negative mapping with 0 TTL for deletion 84/60584/1
Lorand Jakab [Thu, 20 Jul 2017 09:22:09 +0000 (12:22 +0300)]
Return negative mapping with 0 TTL for deletion

When an SMR-invoked Map-Request is asking for a mapping that is
negative, it is most likely an attempt to delete that mapping.

Change-Id: Iec949c5ca9da90845c6634a7d26fabebd65afc81
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoMake 'keys' CLI output user friendly 33/60533/1
Lorand Jakab [Wed, 14 Jun 2017 13:04:09 +0000 (16:04 +0300)]
Make 'keys' CLI output user friendly

Before this patch, the 'keys' CLI command would print out the full
Java objects contained in a map-cache. That's great for in-depth
debugging, but for a quick look it very hard to read. This patch
implements a user friendly CLI output for keys, to improve
readability.

The old full output is still available in Karaf, by adding the '-d' or
'--debug' switch to the CLI command.

Example output:

---8<------------------------------------------------------------------------------
opendaylight-user@root>keys
Instance ID 0
  -> EID                                           HMAC Algorithm        Shared Key
     192.0.2.1/32                                  HmacSHA1              password
     192.0.2.1/32|192.0.2.2/32                     HmacSHA1              password
------------------------------------------------------------------------------>8---

Change-Id: Ibe95d0ee4318053df3bc9f30c09c0e01c1d00eba
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoFully remove Maven Sites 47/60247/1
Lorand Jakab [Wed, 12 Jul 2017 12:04:59 +0000 (15:04 +0300)]
Fully remove Maven Sites

Change-Id: I8c6ba1fe18e0fff43d0aa47b19c9f11df05ead20
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoRemove outdated src/site documentation 42/60242/1
Lorand Jakab [Wed, 12 Jul 2017 10:53:18 +0000 (13:53 +0300)]
Remove outdated src/site documentation

https://lists.opendaylight.org/pipermail/odlparent-dev/2017-July/001218.html

Content moved to the wiki:
https://wiki.opendaylight.org/view/Southbound_Performance_Cache

Change-Id: I9867417f6f0a9f30cb3166371f4cfe4c5f3cbe14
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoMerge "Make negative mapping TTL configurable"
Lori Jakab [Tue, 11 Jul 2017 11:09:46 +0000 (11:09 +0000)]
Merge "Make negative mapping TTL configurable"

6 years agoUpgrade to odlparent 2.0.2 45/60145/1
Lorand Jakab [Mon, 10 Jul 2017 13:07:36 +0000 (16:07 +0300)]
Upgrade to odlparent 2.0.2

Build is broken without this upgrade.

Change-Id: Ib9e24eb78d4af103ad8e30febd233ef2ec175963
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoMake negative mapping TTL configurable 60/59560/4
Lorand Jakab [Tue, 27 Jun 2017 11:34:24 +0000 (14:34 +0300)]
Make negative mapping TTL configurable

Change-Id: I08c6ad1517f4cc34747a4762dc604b0de87b2bea
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoFix build 49/59549/1
Lorand Jakab [Tue, 27 Jun 2017 08:21:47 +0000 (11:21 +0300)]
Fix build

Change-Id: I5bfc3c58fef1fcb1c20387d840f1307f09fd7990
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoBug 8679: Fix widest negative prefix calculation 06/59206/4
Lorand Jakab [Tue, 20 Jun 2017 08:53:15 +0000 (11:53 +0300)]
Bug 8679: Fix widest negative prefix calculation

And add integration tests to avoid regressions.

Change-Id: I6cadaca03d360f475c7c88fd3cb58dd39814d23f
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoUpgrade to odlparent 2.0.0 81/59281/1
Lorand Jakab [Wed, 7 Jun 2017 09:36:55 +0000 (12:36 +0300)]
Upgrade to odlparent 2.0.0

Change-Id: I10061eda3522ded1d55adc1ac365ab9d4b22763b
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoDo not build Karaf 3 features and distro 92/58392/8
Lorand Jakab [Wed, 7 Jun 2017 09:36:55 +0000 (12:36 +0300)]
Do not build Karaf 3 features and distro

Disable building the Karaf 3 features and local distribution, since
that's a prerequisite for getting back into autorelease in Nitrogen [0],
apart from the build breaking right now.

For now, just comment them out in the build, we fully remove source code
just before code freeze (in case we need to contrast behaviors between a
Karaf 3 and 4 container).

[0] https://lists.opendaylight.org/pipermail/odlparent-dev/2017-June/001036.html

Change-Id: Id7f9a82e4b9868ad57141d3ef7e5a0cc2ef74946
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoUpgrade V3PO model version 35/59135/1
Lorand Jakab [Mon, 19 Jun 2017 06:57:04 +0000 (09:57 +0300)]
Upgrade V3PO model version

Else build fails

Change-Id: I57439066304d70c633dd565873d9401870238b13
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoMerge "Bug 8503: Remove empty structures in DAO"
Vina Ermagan [Thu, 15 Jun 2017 01:08:27 +0000 (01:08 +0000)]
Merge "Bug 8503: Remove empty structures in DAO"

6 years agoMigrate to odlparent 1.9.0 65/58865/1
Thanh Ha [Tue, 13 Jun 2017 20:20:20 +0000 (16:20 -0400)]
Migrate to odlparent 1.9.0

Change-Id: I9de99604521440580045e6bedcff4606389561a2
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
6 years agoBug 8503: Remove empty structures in DAO 99/57799/6
Lorand Jakab [Thu, 25 May 2017 06:29:15 +0000 (09:29 +0300)]
Bug 8503: Remove empty structures in DAO

Change-Id: I52bb47edbb2e34c0b72d874b1ceab33125156f42
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoBUG-6709: migrate karaf-empty 75/58375/2
Robert Varga [Tue, 6 Jun 2017 20:41:58 +0000 (22:41 +0200)]
BUG-6709: migrate karaf-empty

No longer provided by controller.

Change-Id: I11fa1db7b9aaf2a15be3c8979c744d23d5c77d62
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>