Code clean up

- check style
- Qname generation
- functional style
- java language migration
- mvn duplication

Change-Id: I0c7757c8cadead5e988cde6d3fa0e607c4cad72c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Improve bmp synchronization

Change-Id: If5d90f32d6f72b0f1c07a7ff63db4afeb4391772
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Simplify some of the new Mvpn attributes models

Change-Id: Ie850e304705dff3bb19c7d7bec616d0c09698782
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Migrate deprecated submit() to commit() under PCEP

Change-Id: Id3136e3bcac708e0c04e35ee2bc673f8dd424d36
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Rework MVPN Routes Model as workaround for MDSAL-310

JIRA: BGPCEP-396
Change-Id: Ia56252bf08593b35bcda56580baef6293ceb3d84
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix Pmsi tunnel type model name typo

Change-Id: Ie374f97383095090280fd261d484986f879c85c5
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix Mvpn Model choice container

Choice case are not allowed to
share a common container as case;

JIRA: BGPCEP-396
Change-Id: Icb51b2c23d5cf5bc8dbe9ea316e200eb0ecd3596
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Migrate deprecated submit() to commit() for BGP/BMP

Change-Id: Id22bb9d50c40e94bb616272d018a376cecc1705a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Adjust to RPC method signature update

Input/Output structures are always present and we need to return
ListenableFuture.

Change-Id: Idf91f4321be2c339a7752c177bb000ffdd2e5021
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Partial submit() migration to commit()

Change-Id: I4610af88fe7cbce2259b90ca19842ee30d0952a7
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix MVPN

- Remove unnecesary prefix under mvpn route model
- register mvpn routes cases under CacheableNlriObjects
- correct registration of ribsupport with corresponding family

JIRA: BGPCEP-396
Change-Id: Ibf83e013b53dbda6120621990dc84781565ff70d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

MVPN Support

- Nlri Handlers
- RIB Supports
- Add supported family to default RIB/Peer config
- BGP/RIB Activator
- Increment test coverage

JIRA: BGPCEP-396
Change-Id: Ib020247ab87aa7baa303703c552cfecf1c7314d9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Provide codec Serializer via RibSupport

- provide access to BindingToNormalizedNodeCodec
under ribsupport
- clean up

Change-Id: Ibee3e1550211c9d88c24eb9ae2e741ee77f7d948
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

MVPN Routes PArser/Serializer

JIRA: BGPCEP-396
Change-Id: I02535dd90ae1cd3563a44980df016d10ce33ebed
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove IpAddress handler duplicated code

- create util for parse, serialize IpAddress

Change-Id: I4eec0ad9658c28b4ff238eb24266d9a2303fb9f0
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Improve chain transaction fail handling

under Data change counter.
- Migrate submit to commit.

Change-Id: If2149bdf87ca8a94e4d74f379424ff36f934a52f
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Register MVPN TableType

- minor fixups

JIRA: BGPCEP-396
Change-Id: Ibd87a1230817c3e09c352ec2a230944dd2d1f8d4
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove migrated PMSI Tunnel Attributes

JIRA: BGPCEP-396
Change-Id: Ie86e68fca156f0e50e76744ecb5e7b4d93f45278
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Augment Server connection timeout for BMP tests

Change-Id: I3947d797a54b8e152a86022e97a4d1ddb23964c4
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

MVPN Attributes Handlers

- PMSI Tunnel Attributes
- PE Distinguisher Labels

JIRA: BGPCEP-396
Change-Id: I243f325260a46c16f6f9412282b83b8f415b0ea2
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove duplicated code for Route Entry

Change-Id: Ia962719cbca89d7092e040506d125ead2106d8cb
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Improve TopologyStatsProvider transaction chain failure

Create new chain when onTransactionChainFailed
for TopologyStatsProvider.

Change-Id: Ib3ff3b7b1c9381efa8f35cbb5ed88195320f06c9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix IllegalStateException in StateProviderImpl

If a transaction fails, the StateProviderImpl can get stuck in
a perpetual cycle of subsequent transactions failing due to:

java.lang.IllegalStateException: Previous transaction odl2-1-datastore-operational-fe-3-chn-44-txn-1-0 is not ready yet
        at org.opendaylight.controller.cluster.datastore.TransactionChainProxy$Allocated.checkReady(TransactionChainProxy.java:85)[315:org.opendaylight.controller.sal-distributed-datastore:1.6.0.ODL_7_0_0_0]
        at org.opendaylight.controller.cluster.datastore.TransactionChainProxy.allocateWriteTransaction(TransactionChainProxy.java:187)[315:org.opendaylight.controller.sal-distributed-datastore:1.6.0.ODL_7_0_0_0]
        at org.opendaylight.controller.cluster.datastore.TransactionChainProxy.newReadWriteTransaction(TransactionChainProxy.java:166)[315:org.opendaylight.controller.sal-distributed-datastore:1.6.0.ODL_7_0_0_0]
        at org.opendaylight.controller.cluster.databroker.DOMBrokerReadWriteTransaction.createTransaction(DOMBrokerReadWriteTransaction.java:52)[315:org.opendaylight.controller.sal-distributed-datastore:1.6.0.ODL_7_0_0_0]
        at org.opendaylight.controller.cluster.databroker.DOMBrokerReadWriteTransaction.createTransaction(DOMBrokerReadWriteTransaction.java:22)[315:org.opendaylight.controller.sal-distributed-datastore:1.6.0.ODL_7_0_0_0]
        at org.opendaylight.controller.cluster.databroker.AbstractDOMBrokerTransaction.getSubtransaction(AbstractDOMBrokerTransaction.java:57)[315:org.opendaylight.controller.sal-distributed-datastore:1.6.0.ODL_7_0_0_0]
        at org.opendaylight.controller.cluster.databroker.AbstractDOMBrokerWriteTransaction.merge(AbstractDOMBrokerWriteTransaction.java:102)[315:org.opendaylight.controller.sal-distributed-datastore:1.6.0.ODL_7_0_0_0]
        at org.opendaylight.controller.md.sal.dom.spi.ForwardingDOMDataReadWriteTransaction.merge(ForwardingDOMDataReadWriteTransaction.java:54)[314:org.opendaylight.controller.sal-core-spi:1.6.0.ODL_7_0_0_0]
        at org.opendaylight.controller.md.sal.binding.impl.BindingDOMWriteTransactionAdapter.ensureParentsByMerge(BindingDOMWriteTransactionAdapter.java:67)[302:org.opendaylight.controller.sal-binding-broker-impl:1.6.0.ODL_7_0_0_0]
        at org.opendaylight.controller.md.sal.binding.impl.AbstractWriteTransaction.put(AbstractWriteTransaction.java:41)[302:org.opendaylight.controller.sal-binding-broker-impl:1.6.0.ODL_7_0_0_0]
        at org.opendaylight.protocol.bgp.state.StateProviderImpl.storeOperationalState(StateProviderImpl.java:151)[252:org.opendaylight.bgpcep.bgp-openconfig-state:0.8.0.ODL_7_0_0_0]
        at org.opendaylight.protocol.bgp.state.StateProviderImpl.lambda$updateBGPStats$1(StateProviderImpl.java:124)[252:org.opendaylight.bgpcep.bgp-openconfig-state:0.8.0.ODL_7_0_0_0]

The root cause is due to attempitng to continue to use a failed
transaction chain. It should close the failed chain and create a new
on as is required by the API contract.

For the UT, I used the RememberingLogger from infrautils to indirectly
verify the tx chain is rest on failure by checking logged errors. The
RememberingLogger is wired via static binding in infrautils which
supplants logback as the backing impl.

Change-Id: Ie26f047c2320ff812d796a25f2e3721b59b73ba0
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

MVPN Extended communities Handlers

- Source AS (2 Oct/4 Oct) Extended community
- Vrf Route Import Extended community

Change-Id: I853b17d0e10362c45aa80b7edfaa8e63a37f2dda
JIRA: BGPCEP-396
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

MVPN Models

JIRA: BGPCEP-396
Change-Id: Iea02ed31c11ab68e162cb7d83ca56fdae8b9299b
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Handle Path Id under Evpn nlri

Change-Id: Id28defea49d0d444ce2313a90652e4cd0074c255
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Handle path Id under L3vpn

Change-Id: Ibaf99870f2c2d775315471cb62a48a65deb2acf3
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove deprecated method

Change-Id: I076db42eb6737d9712fe400958b4c9f56476fb93
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Add path Id under l3vpn destination

Change-Id: I6e87bf8c24649382eaf596b497f0385cb4cb539d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix NPE

Remove wrong null assignment for effRibInWriter

BGPCEP-792
Change-Id: Ie3df9b0b98e2cd6578554c53b0e6c3a1979677bf
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove unnecesary tests

Change-Id: Ic4e22341bc7b65b2eb6d90f22793eec1e9548666
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove duplicated code

- extension ribsupports should use
  provided routeKeyQname and routeQname
  method provided by abstract rib support.
- fix email contact address

Change-Id: I74200558d7bf1d8300c83e7c48e047b674908ba8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Return ListenableFuture from RPCs

This future-proofs a couple of places, so we do not need to change
them when RPC methods change.

Change-Id: I8eba6f27377c683184d7b2ce539b37393b8d1b3a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove duplicated code

by implementing default behaviour under
interface.

Change-Id: Ida088bc8d78df7d5cc4bb04fe94fb7946b50073b
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix linkstate Route Distinguishers model

actual model do no correspond with
https://tools.ietf.org/html/rfc4364#section-4.2.
- Fix by use correct existent model.
- Remove duplicated grouping models

Change-Id: I870d100d3ce441aa2d7c197be3fb4243ab1846d8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

MVPN RFC6514 Extendend communities

Implement parser/serializer for new
extended communities

JIRA: BGPCEP-396
Change-Id: I3e5dd62e906d40ef4cd8239256539010acfb83d0
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Revert "Fix compilation issues related to IpAddress"

This reverts commit b673aa2e43295f2d4359f39982574c323c1f16e4.

Change-Id: Ib3749d1a852de67b5a22efff2623a6c84608bf2f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix BmpMockTest random failing

Change-Id: I13761faf48e210bbfb7310ce02a044a5c17bfb7a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

MVPN RFC6514 Extendend communities

Update imports generate revision date

JIRA: BGPCEP-396
Change-Id: Id99f5ffac750a278b8f966b682c1f8659765afe5
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

MVPN RFC6514 Extendend communities

- Source AS
- VRF Route Import

JIRA: BGPCEP-396
Change-Id: Ib19270ad50c30d805008497e35b33fbcf7030aac
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove no longer required karaf.shell imports

Change-Id: I8157504ba60b9fe8ccd9c49a39b7029b11d5a119
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove duplicated Peer code

- improve tx synchronization

Change-Id: I6a87b0e90aa53f8f3a224535b988da08229d873b
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix compilation issues related to IpAddress

Use IpAddress containing Ipv4/Ipv6, instead
of the IpAddress containing *nozone generated by
IetfInetUtil.

Change-Id: I4537b31e9561cb645881400358d54bfecd643bc1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Initialize effective rib in for App Peer

Effective Rib in has splitted constructor and
initializer. Add missing initialization under
AppPeer

BGPCEP-789
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Change-Id: Iee2bde3ebf5f786b78ff5c4dd387da7decf20b0d

Support Local AS only when configured as eBGP

Change-Id: Iac5d463fdf3849148e5845aa9265806e25c8ba76
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bump to odlparent 3.1.0 and yangtools 2.0.3

Change-Id: I89ac7aec458dd9b567697bd2449bacb92e192369
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Fix findbug complains

Change-Id: Ifeb808d6890c6150057ade9693b0730e9bf515fd
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Migrate deprecated OsgiCommandSupport

Change-Id: I3fabc2af08746b2690a8e1ca8cb87e6ec84ad411
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Rework Cluster-Id config

BGPCEP-564
Change-Id: I96557eca0c599e0934b7fada91bfc35162eae7bc
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Delete routes under eff-rib-in

only if there are present.

Change-Id: I7c863999b54a16dec2bcaddd256c6ff7121b0cb5
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Rework OffsetMap.remove() and share empty arrays

Empty arrays are immutable, hence we can share those instances,
reducing overheads. Also updates OffsetMap.remove() to take an
empty array argument, which will be used when the map would become
empty.

Change-Id: I58116eddce3d8b1a1f7d049c0c1f12fcd9f79966
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Provide Add Path support for all AFI/SAFI

Updade code according to models change.
Path Id and Route Key(string) leaf added
to route.
Route Key and Path Id are now the common
route-key for all routes list.

BGPCEP-781
Change-Id: I45bb53c939a2ecca57d2e11ec5e317e8164c7182
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Provide Add Path support for all AFI/SAFI

Update route model, adding by default path-id
and route-key to be used as key for routes lists.

BGPCEP-781
Change-Id: Ie62c2f304976cb275ede8f52ad6d07812f46f15a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix Peer Identifier used per Rib creation.

Use the provided by peer when session goes up.

BGPCEP-783
Change-Id: I7cd497df649be689a25dd67eed3903b42def8d28
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix findbug NP_NONNULL_PARAM_VIOLATION complains

Change-Id: I359f4a8c626753e9d5eeb6eb4b2cbd906b28e984
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Migrate ShellTable to non-deprecated class

org.apache.karaf.shell.support.table.ShellTable is the new location,
use that.

Change-Id: I85b6adc2ae01a47236217676f78cce9e0f81237e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use byte[].clone()

BGPDocumentedException can be made more efficient by using
byte[].clone() instead of Arrays.copyOf(). Also pre-cache empty
data and return it when needed.

Change-Id: Ib4e36522f0d3a734621349c1b62865496d330009
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use dedicated executor for BGPCEP Stats

BGPCEP-786
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Change-Id: I85d227f237509e3646805258ebeb1c22ebb3a54b

Migrate to karaf shell api

org.apache.felix.gogo.commands is deprecated, migrate to
org.apache.karaf.shell.api.action equivalents.

Change-Id: I22d1714f4bff6acfecb0fdd87c595e32af5d9a8c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add Karaf build profile

Project local Karaf distros are handy for devs to test their work
however is unneeded by autorelease builds and should not be released
as part of the Simultanious Release. Add a profile that is active by
default so that default behaviour is unchanged however allows the
autorelease project to disable building this module.

Issue: RELENG-86
Change-Id: I0b1d31b051223a8a1c22494da08bd72eb585198b
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Remove obsolete Maven Site configuration

Change-Id: I31d7a0f8c709797cd927fd1eae266f2cbf6418f5
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

BGPCEP-578: Add additional path config

to afis/safis peer group

Change-Id: I2a4776d7566d79fd15c799c0c3d7613c01638e9e
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix missing return under AbstractBestPathSelector

Change-Id: I0156a2be5a7772ecdbd55de5f5308092656b38eb
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-740: Fix logic for MED comparison in BGP best path selection

New better path should be selected only if new MED is lower than
actual best path MED.

Change-Id: I8bd07dc8b42e575cebcc4e1ea4b55d9c2c842f42
Signed-off-by: Ajay Lele <ajayslele@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-577: Neighbor’s local AS configurable

Change-Id: I4dab50d048c2c61900251959d06c909c55722df5
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-576: Neighbor’s local address configurable

Change-Id: Ic4aaf8dbb408e37a0df40e320793dc1330879b06
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-782: Fix peer-id

by using the one send by peer.

Change-Id: Ic18e7fac972b08dcd77a2dbaad7482295bdcd7ae
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Rework match role condition.

Make condition support from peer role and
to peer role evaluation at once.
Improving performance.

Change-Id: I2e3c69e82e17d651aca962f478901ec4aed63b88
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-781: Provide Add Path support for all AFI/SAFI

Change-Id: I0fefe5c28a8b9d4f2f0be5cbe966233b73c7081a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-779: Fix Effective rib writer

empty table creation. Create table route
container only if its already not present.

Change-Id: Ia621e8aa8058eeb14b06bc99956efe1e7c6a9f5b
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix test identity

Identities are mapped to interfaces, not classes.

Change-Id: I1fa4ce6dcf2825bb40b8c2b86fd4ed93e6d58a8d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove config system remnants

The config system is being removed in Flourine so remove
the unused config system dependencies.

Change-Id: I47175e831eced456d14f95cbcefd44dd404333dc
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

BGPCEP-564: Support multiple cluster IDs

Change-Id: I7e50b3ff7e9a4299b70bcfa6e1fa24ba970a795b
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix Route removal

remove wrong check if from peer null.

Change-Id: Ica7a80db21ee7279d9aa6071287b0c499999ed04
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove default Non add path implementation

under Ribsupport interface, and implement it under
new abstract class. Avoiding possible boilerplate.

Change-Id: I1e563659df3678aea5e491806adb42adea3dea9d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-778: Fix peer-group reconfiguration

by use correct peer-group name.

Change-Id: Id68fbc1a9cd1a19aea26f0e810ec6b54560df359
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-712: Enforce checkstyle under binding-parent

Remove from dindiong modules, given inheritance.

Change-Id: I216d25eae5139f84663a9ae1ed43e94ab3d431ae
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-712: Set Checkstyle with warn violationSeverity level

under specific modules. Until checkstyle issues
are fixed. Therefore we can enforce on top parent
the checkstyle for the rest.

Change-Id: I70cb6e540e4d6e9fa07aabe0f52527896ba228d1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix checkstyle

for

- data change counter module
- parser mock module

Change-Id: If4bda129f1602effd7deb67a96eaeda4f3924962
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Create Empty Route Container

under eff rib in tables, when
initializing the table.

Change-Id: Ia6138acb76b594a2bfac26b5a2099bd069d7a4be
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-777: Ignore ParserToSalTest until fix

therefore autorelease-build will not be
blocked

Change-Id: I07df8e124c748a431735716926caf7c065a9d0ce
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-775: Install missing feature

Openconfig rp Statement implementing(default
 of policies)

Change-Id: Ic3d70dd960ce61c012a06f49d659582f9ca44444
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix checkstyle under Concepts module

Change-Id: If5ed38841ea0013f3e5b721f59c48d7cb778fedf
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-770: Lock file before processing

In this way we ensure is not still been modified
when event is raised.

Change-Id: I69047f244e78bdf4536d6f2a83d3b80c45191e90
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-774: Improver error message when missing AFI/SAFI

on peer configuration

Change-Id: I79568d87a0e8401fa71376e9a9c0b3b5389a8baf
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-768: Fix switch case

use break instead of wrong use of return.

Change-Id: I54b1e39c2b0017a628eff9a5a6eb09bb7a68f92c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

revert method name change

Change-Id: Id3f00b6d224e61b9de2dc5ab9d85a6273883aaef
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-578: Extended peer-group support

- Add Peer Group to Operational state
- Augment peer group model for support peer remote port.
- Name augmentations missing naming.
- Clean up OpenConfigMappingUtil and
  remove no longer required utility methods.

Change-Id: I840dad2d6f3c49fa1c12462e21f241f36cda03dc
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-764: Use full Ipv6 form under StrictBGPPeerRegistry

Ipv6 equal is not capable of handle short or full form
of Ipv6, returning false when comparing different versions.
Therefore use full form under registry.

Change-Id: I2127f20e847860792d0f1c18b0ae243825a9d86a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Enforce findbug on binding-parent

fix findbug complains

Change-Id: Ib05cded6d40994269e06d70ac78a7e534b0d29b6
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Clean up

- remove unnecesary imports
- duplicated import
- Use string instead of StringBuilder

Change-Id: Ia4e7d83a582ae54a602fc213a55fff80d337beb5
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-578: Introduce PeerGroup configuration

allowing to configure neighbors using a common
peer group config.

Change-Id: I2385f5927146324b540c9cd416942c5166e2d6e8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-769: Dont use path id

under family(L3vpn) no supporting additional path.

Change-Id: I738cea4694411f7a63f077b243600f09aee61878
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix config rib policy xml

Change-Id: Ie4af66dad1cfb797a010b4e2357c2b8b4d5989b3
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-766: Reduce synchornization

under AbstractTopologySessionListener

Change-Id: I99efef02cef6f9af761c73d57bb4b37e50177830
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Add logs to catch result of transaction submision

Change-Id: I4143786bc88c32c8ace8050e27c48c5a96aafb1f
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Improve sync under EffectiveRibInWriter

Change-Id: I63e46860de46ea0a008400dfb64b1e8e97ea7e73
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-589: BGP Neighbor match

match Peer-Id generated from neighbor address,
it can be used as replacement for generate similar
policy than removed simple-routing-policy.

Change-Id: I347a77cb40c72ff110b5088682f8edd375cecca1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix BestPathState NPE

Check As Path segments are not null when
selecting best path.

Change-Id: Id4d76b9f83d957b505300aabde248978151f5b73
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix RIB SPI checkstyle complains

Change-Id: Ia1862f8db58413ca284f4d76f1d24c0a2d818ac9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>