Robert Varga [Mon, 18 Aug 2014 12:09:12 +0000 (12:09 +0000)]
Merge changes I0f764a60,I5f7eff95
* changes:
Fixed PCE's remote and local address
Bug-1516: Introduce PCC mock.
Milos Fabian [Fri, 15 Aug 2014 12:15:03 +0000 (14:15 +0200)]
Fixed PCE's remote and local address
-server's channel remote and local address are reversed
if channel has parent channel - return proper values,
since remote address is used to build pcc's node-id
-hit the issue while testing PCC Mock with ODL's PCE on localhost
Change-Id: I0f764a606fde2336c51e085184cf0feb08cb748a
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Fri, 15 Aug 2014 11:42:50 +0000 (13:42 +0200)]
Bug-1516: Introduce PCC mock.
-dummy PCC responder
-contains executable jar
-input parameters:
--address <inet address> (the first PCC's address, mandatory argument)
--pcc <count> (a number of PCC mocks to connect ODL's PCE, 1 by default)
--lsp <count> (a number of LSPs per PCC, 1 by default)
--pcerr (optional flag - PCC returns random PCError Msg as a response to PCUpd)
-PCC mock can establish connection with PCE, periodically (30s) sends keep-alive msg
-creates dummy LSPs and sync with PCE, responses to PCE requests (PCUpd Msg) - with PCRpt Msg
Change-Id: I5f7eff957375be53f48bc169cf85a22a19ff60b1
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Dana Kutenicsova [Thu, 14 Aug 2014 13:29:49 +0000 (15:29 +0200)]
BUG-730 : added missing tests for linkstate adjacency ribs in
Change-Id: I1b60a1497d880a8821b73e97685c2f13590a5ee3
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Thu, 14 Aug 2014 11:16:37 +0000 (13:16 +0200)]
BUG-730 : more unit tests to Util.
Change-Id: Iee0db68ef7883bd7db391241d09ac6e9615cd2fb
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 15 Aug 2014 18:45:47 +0000 (18:45 +0000)]
Merge "Fixed config tests"
Milos Fabian [Fri, 15 Aug 2014 17:42:22 +0000 (19:42 +0200)]
Fixed config tests
-according to RuntimeMappingModule implenation changes
Change-Id: I9fc05d0bfa88a4c41f0a2139a4a882d789ed238d
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Giovanni Meo [Tue, 5 Aug 2014 16:27:04 +0000 (18:27 +0200)]
Tell to IT the version of object-api in BGPCEP
Change-Id: Ia377178f883a2747f2663e728c8752cf9137a52f
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 13 Aug 2014 21:45:20 +0000 (23:45 +0200)]
Fix a sonar warning
Just be explicit about expected null-ness.
Change-Id: I3f9363878c0e985bc1fedafe3af05d3e685be400
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Tue, 12 Aug 2014 19:47:49 +0000 (21:47 +0200)]
BUG-730 : moved BGP path selection test to proper place.
- added test for vendor tlv in pcep
Change-Id: Ibca29e9dc440a24f2b160f325df4d381be4ce149
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Mon, 11 Aug 2014 15:14:02 +0000 (17:14 +0200)]
Fixed bgp-testool activator exception.
Change-Id: Ic515178061e745774e51e11fc00780e3049ccd22
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Tue, 12 Aug 2014 10:24:39 +0000 (10:24 +0000)]
Merge "Pre-populate links/nodes with empty lists"
Dana Kutenicsova [Tue, 12 Aug 2014 10:15:29 +0000 (10:15 +0000)]
Merge "Bug-731: Fixed few major Sonar warnings"
Robert Varga [Tue, 12 Aug 2014 10:09:26 +0000 (12:09 +0200)]
Pre-populate links/nodes with empty lists
This should for existence of the nodes in datastore.
Change-Id: Ie2ba183e927089971ce024ae0cc9d053f27f0029
Signed-off-by: Robert Varga <rovarga@cisco.com>
Milos Fabian [Thu, 7 Aug 2014 13:39:16 +0000 (15:39 +0200)]
Bug-731: Fixed few major Sonar warnings
Change-Id: Ic176a1f7e5478721571b8efdab470bd0dad760d6
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Robert Varga [Tue, 12 Aug 2014 05:41:39 +0000 (07:41 +0200)]
Properly create parent nodes in reachability builders
The abstract class quietly relied on parent nodes being created by the
datastore, which could have lead to them not being cleaned up. Fix the
code to do the right thing.
Change-Id: Ie5dd735b4a0791a4439d446cb2a7a5bb6fe87db5
Signed-off-by: Robert Varga <rovarga@cisco.com>
Milos Fabian [Mon, 11 Aug 2014 15:10:12 +0000 (17:10 +0200)]
Bug-1399: Fixed initial linkstate-attribute type configuration.
Change-Id: Ie318d01687ed570aa205eed82a07dfce6835decd
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Robert Varga [Wed, 6 Aug 2014 08:11:56 +0000 (10:11 +0200)]
Switch Sonar profile
This switches the sonar profile to the more strict findbugs-enabled one.
Merge when confident we can take the extra work.
Change-Id: Ia2e9224d69baf3dc74f25995bf3aeef4f5ada64d
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sun, 10 Aug 2014 05:50:01 +0000 (05:50 +0000)]
Merge "Revoke delegation sent as Pcinitiate message."
Dana Kutenicsova [Fri, 8 Aug 2014 13:15:27 +0000 (13:15 +0000)]
Merge "Bug-731 Fixed few minor Sonar warnings"
Robert Varga [Fri, 8 Aug 2014 13:03:43 +0000 (13:03 +0000)]
Merge "Fixed lookup of created routes in BGP Topology Exporter."
Tony Tkacik [Fri, 8 Aug 2014 12:52:35 +0000 (14:52 +0200)]
Fixed lookup of created routes in BGP Topology Exporter.
Change-Id: I6f44c0e0265cd4ddf475a43553ba835ec8964e4b
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Dana Kutenicsova [Fri, 8 Aug 2014 12:36:44 +0000 (14:36 +0200)]
Revoke delegation sent as Pcinitiate message.
Change-Id: Ife958b1a2ff98f4b2b03b0108704518ebf33b64b
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Milos Fabian [Thu, 7 Aug 2014 10:44:27 +0000 (12:44 +0200)]
Bug-731 Fixed few minor Sonar warnings
Change-Id: Id1ac7061e395f4feca8d29304785d03ef14007ad
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Thu, 7 Aug 2014 08:17:16 +0000 (10:17 +0200)]
Bug-731: PCEPErrors enum with error-type and error-value
-enum backed with inverse mapping - look-up enum for type and value
-deleted PCEPErrorMapping class - got rid of Sonar "Magic Number" warnings
-AbstractMessageParser - merge two createErrorMsg methods to one
Change-Id: I94a688427ae606eecdbafffa09d29e364f183526
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Robert Varga [Wed, 6 Aug 2014 04:57:59 +0000 (06:57 +0200)]
Fix UT coverage not being reported in Sonar
Makes sure jacoco is run and points sonar the right way.
Change-Id: Ica97f4635e83d66133ebcaae479d6987f7b7794d
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Tue, 5 Aug 2014 20:13:10 +0000 (20:13 +0000)]
Merge "BUG-1116: Finish up egress path API changes"
Milos Fabian [Tue, 5 Aug 2014 11:54:45 +0000 (13:54 +0200)]
BUG-1116: Finish up egress path API changes
This finishes the API-level changes required to support route
dissemination. The codepath should just work, but more testing is
needed.
Change-Id: I79ace174c78f0653b057b0bad1c685ecd5e9d0cb
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Mon, 4 Aug 2014 11:25:04 +0000 (13:25 +0200)]
Bug-479: Implementation of Vendor-Information Object
-reference: http://tools.ietf.org/html/draft-ietf-pce-rfc7150bis-00
-added yang model of new object
-added abstract skeleton of Vendor-Information object parser/serializer
-PCReq and PCRep Messages models and parsers enhanced with list of VI objects
-introduced new Vendor-Information object parsers/serializers registry
-added junit tests
Change-Id: Icbf1ff79542cc2f7e5219de208ec015e31323730
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Robert Varga [Tue, 5 Aug 2014 12:05:26 +0000 (14:05 +0200)]
Fix integration tests after object-cache-api addition
Change-Id: I81ac3d42374fc80f74801b646625e93a3b08a7eb
Signed-off-by: Robert Varga <rovarga@cisco.com>
Milos Fabian [Sun, 3 Aug 2014 14:02:34 +0000 (16:02 +0200)]
Bug-479: Implementation of Vendor-Information TLV
-reference: http://tools.ietf.org/html/draft-ietf-pce-rfc7150bis-00
-added yang model of new TLV
-added abstract skeleton of Vendor-Information TLV parser/serializer
-objects's tlvs container enhanced with list of Vendor-Information Tlvs
-added junit tests
-introduced new Vendor-Information TLV registry
Change-Id: Ib14c369afb39dffd58160596dbca4954f5641a7f
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
Milos Fabian [Mon, 4 Aug 2014 12:19:24 +0000 (14:19 +0200)]
Bug-1429: Get rid of overriding managed dependencies version
Change-Id: If9d821cf7143fe46956ea0ad7cdf6f5373a90fde
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Mon, 4 Aug 2014 15:45:22 +0000 (17:45 +0200)]
BUG-1116: Rework AbstractAdjRIBsIn interface
Rework the class such that we have support for encoding of individual
NLRI types, as well as adding proper insulation of the subclasses from
the actual place where a particular data node is being written to.
Change-Id: I82196d506004c30745820fd2769d63d34d5cf806
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Robert Varga [Tue, 15 Jul 2014 08:17:12 +0000 (10:17 +0200)]
BUG-1116: add BGP application peer skeleton
This adds the skeleton of the application peer, which routes data
written to MD-SAL through best path selection into the local rib.
Change-Id: Id9466d4206c30747cfa59eeabcd5d79dd9718c24
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 31 Jul 2014 15:55:38 +0000 (17:55 +0200)]
BUG-868: migrate SchemaServiceListener users
Follow-through for the changes introduced in yangtools/controller.
Change-Id: I9bbf1f5233a37b46219799fcfa2a81c47b236876
Signed-off-by: Robert Varga <rovarga@cisco.com>
Milos Fabian [Fri, 1 Aug 2014 08:09:28 +0000 (10:09 +0200)]
Bug-1463: Unknown attribute's bytes must be skipped.
Change-Id: Ibea17c4b83a7b054997bfeb5631054a2f666c1c6
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Mon, 21 Jul 2014 19:12:17 +0000 (21:12 +0200)]
Bug-1383: BGP listener should fail to configure if we do not have privileges
-verify if has root privileges, before BGP server is created.
-changed bgp's binding port initial configuration to 1790
Change-Id: Ic15c5c18ee773902b060fde733fe54f3a7a8526c
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Wed, 30 Jul 2014 13:29:12 +0000 (15:29 +0200)]
Bug-1447: Ensure candidate's parents exist.
-When electing Rib enty's new state, ensure it's parents are created.
Change-Id: Ia0791eee031dc2dba5c5b206dae693fa880df1ab
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Robert Varga [Wed, 30 Jul 2014 09:12:56 +0000 (11:12 +0200)]
BUG-1116: add AbstractAdjRIBsIn documentation
Adds proper documentation before we start movint things around.
Change-Id: I49cd2f41a7f3294e345c733c0803c9f03d0a6264
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 29 Jul 2014 14:28:52 +0000 (16:28 +0200)]
BUG-1116: Move BGPSession and friends to a more private place
The parser API is independent of BGPSession details. BGPSession will be
needed for the RIBsOut work.
Change-Id: I3b0774e5325d07465c00718c185e3f4a7925827c
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Wed, 30 Jul 2014 12:59:40 +0000 (12:59 +0000)]
Merge changes I21c05c40,Ib6e5362f
* changes:
BUG-1287: migrate Transaction.commit() to Transaction.submit()
BUG-1116: Rework comparator and encapsulate transactions
Robert Varga [Wed, 30 Jul 2014 12:48:03 +0000 (12:48 +0000)]
Merge "Bug-1399: Added Linkstate attribute type configuration"
Robert Varga [Tue, 29 Jul 2014 13:01:30 +0000 (15:01 +0200)]
BUG-1287: migrate Transaction.commit() to Transaction.submit()
Just minor cleanup, as the API has changed at the last minute.
Change-Id: I21c05c4070e8d7c888d7a9713b713acebdf0662d
Signed-off-by: Robert Varga <rovarga@cisco.com>
Milos Fabian [Tue, 29 Jul 2014 09:07:14 +0000 (11:07 +0200)]
BUG-1116: Rework comparator and encapsulate transactions
Having the route comparator in the peer was just a hack. It really is
part of the local rib, so this patch moves it to the appropriate place.
Since we are changing interfaces, change them some more by not passing
raw transaction around, but rather a proper transaction context. This
will allow us to transparently route it to other peers for dissemination
purposes.
Change-Id: Ib6e5362f32dcf9f2582bb76c364c8028a2c08c54
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Robert Varga [Sat, 26 Jul 2014 03:06:37 +0000 (05:06 +0200)]
Use an atomic long for SRP counter
Performance tests show that the listener monitor is heavily contended.
We start off by making the SRP counter atomic, so we can reference it
without the lock being held. Also add annotations to the base class, so
we know which fields are protected.
Change-Id: Ie5d0685f766de83fae0d1591a971727b610fc8ea
Signed-off-by: Robert Varga <rovarga@cisco.com>
Milos Fabian [Thu, 24 Jul 2014 11:50:18 +0000 (13:50 +0200)]
Bug-1399: Added Linkstate attribute type configuration
-IANA has issued an early allocation for the BGP Linkstate path attribute (=29)
-type is configurable to preserve backwards compatibility
Change-Id: I24adfea7abfa80bc897415317c8cd0f856d6b6f9
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Dana Kutenicsova [Sun, 27 Jul 2014 18:28:18 +0000 (20:28 +0200)]
Fixed various findbugs issues in PCEP.
Change-Id: I1d1e2d21009a2ce22b8f8e646e8ba3c62eecc545
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sun, 27 Jul 2014 18:08:53 +0000 (20:08 +0200)]
Fixed various findbugs issues in util.
Change-Id: I5e31d46ed509596284764cb7a1eba63399789dff
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sun, 27 Jul 2014 20:38:49 +0000 (22:38 +0200)]
Fixed findbug issues in BGP.
Change-Id: I3c2fb7433682d1ef3cafb77273849a3f397fb26a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Maros Marsalek [Fri, 25 Jul 2014 14:02:45 +0000 (16:02 +0200)]
Update config files in bgpcep, remove duplicate config nodes
Change-Id: I02e315f622585b4de51718bf700b52d178fa4990
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Dana Kutenicsova [Tue, 29 Jul 2014 08:40:13 +0000 (08:40 +0000)]
Merge "BUG-1116: Require Peer handle for creation of AdjRIBsIn entries"
Robert Varga [Tue, 22 Jul 2014 13:57:38 +0000 (15:57 +0200)]
BUG-1116: Require Peer handle for creation of AdjRIBsIn entries
This change is required in order to maintain knowledge of where we
learned a particular route. This knowledge will then be used by the
AdjRibsOut wiring to suppress announcement of routes.
Change-Id: I8e8f38f78ef9a971f4884577c7455a7262284f4a
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 24 Jul 2014 20:04:53 +0000 (22:04 +0200)]
BUG-1287: migrate to WriteTransaction.submit()
WriteTransaction.commit() has been superseded by
WriteTransaction.submit(), so migrate the user.
Change-Id: Ibbcbe28001581cb9db5e9588a3618d4f60bf92f8
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 17 Jul 2014 10:41:44 +0000 (12:41 +0200)]
Update LSPDB incrementally
Now that the datastore can properly handle augment removal and fast
merges, we can get rid of the full rebuild we were doing.
This patch restores the previous logic, such that we enqueue only LSP
updates into the datastore.
The flip of 'synced' boolean is handled as a merge of a single leaf, so
should propagate writhout incurring any other overhead.
Change-Id: I488e15ebef3abdeab6df791b7ed3b7fe2c266330
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 17 Jul 2014 10:59:52 +0000 (12:59 +0200)]
Use Collections.singletonList()
Removes the use of ArrayList and ImmutableList for carrying a single
element.
Change-Id: I8ce335d2e82b57e7696b105b46cb387cd3cd8c0c
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 17 Jul 2014 10:01:24 +0000 (12:01 +0200)]
BUG-1394: Do not notify RPC callers until the report hits the datastore
During bursts of activity, unblocking RPC callers early can lead into
datastore overload, as the callers will immediately issue a new request,
which in turn can succeed before the datastore has had a chance to catch
up.
As a side-effect, that also fixes a logical race condition, where the
caller sees the RPC succeed, but when looking into the topology, still
does not see the state recorded there.
Finally we take care to reorganize the tracking of outstanding requests,
because netty may give us the response from the router before it gives
us the notification that the request has in fact left. Now each request
has a state and the transitions are carefully managed.
Change-Id: I06b1a56777ffb2df6394f1cdcb74396160bb4e4b
Signed-off-by: Robert Varga <rovarga@cisco.com>
Milos Fabian [Mon, 21 Jul 2014 12:18:47 +0000 (14:18 +0200)]
BUG-1287: migrate bgp-topology-provider
Data store has a new set of APIs, which are more efficient. This is a
straightforward migration, without taking advantage of the full APIs
available.
Change-Id: I5d82dd8ed0cb95f2075593713f253bd9abc5b686
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Mon, 21 Jul 2014 09:16:38 +0000 (11:16 +0200)]
BUG-1287: migrate bgp-rib
-fixed config tests
Data store has a new set of APIs, which are more efficient. This is a
straightforward migration, without taking advantage of the full APIs
available.
Change-Id: I3c205fecc08d6ef7f8bedfd481a77a1aeafab7d6
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Mon, 21 Jul 2014 06:56:51 +0000 (08:56 +0200)]
BUG-1287: migrate pcep-tunnel-provider
Data store has a new set of APIs, which are more efficient. This is a
straightforward migration, without taking advantage of the full APIs
available.
Change-Id: I19e7d49f69ecc0bf24fbb511e7bb05df682d5c73
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Robert Varga [Mon, 28 Jul 2014 12:29:19 +0000 (14:29 +0200)]
BUG-432: fix API breakage
Change-Id: I3543a33374be57018d49c89e1ac99499b0bc2fa2
Signed-off-by: Robert Varga <rovarga@cisco.com>
Milos Fabian [Fri, 25 Jul 2014 11:07:36 +0000 (13:07 +0200)]
Bug-1409: Fix empty Update message (EOR) handling.
-Processing of EOR in BGPSynchronization#updReceived ends up with NPE
-fixed behaviour - synchronize Ipv4 Unicast
Change-Id: I6b85cbcfd8ff9ec00c99b9f11b4bb2dce75ef334
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Robert Varga [Sat, 26 Jul 2014 15:09:14 +0000 (15:09 +0000)]
Merge "Fixed various small bugs found by Findbugs plugin."
Dana Kutenicsova [Sat, 26 Jul 2014 08:36:49 +0000 (08:36 +0000)]
Merge "Add defensive checks when looking up attributes"
Dana Kutenicsova [Fri, 25 Jul 2014 21:27:46 +0000 (23:27 +0200)]
Fixed various small bugs found by Findbugs plugin.
Change-Id: I343625bdb9efd2c0ffdfc12f6c0c9119f377041c
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 25 Jul 2014 15:05:42 +0000 (15:05 +0000)]
Merge changes I6723f9e0,Iab4269dc
* changes:
BUG-731: registration no longer throw exceptions
Improve message writing performance
Dana Kutenicsova [Fri, 25 Jul 2014 13:07:38 +0000 (15:07 +0200)]
BUG-1287 : fixed pcep/programming configs.
Change-Id: Ia202bf4afdcc152e3862d007781123774abef4fd
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Fri, 25 Jul 2014 12:43:46 +0000 (14:43 +0200)]
BUG-731: registration no longer throw exceptions
Since the registrations do not throw them, we can simplify our code,
ridding us of a warning.
Change-Id: I6723f9e09d7419f768f80affea0708439f34c8df
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 23 Jul 2014 16:00:47 +0000 (18:00 +0200)]
Improve message writing performance
The advice is to use the context for writing, so let's do precisely
that.
Change-Id: Iab4269dc140f4bfe22753e421feccf8cbe7bce78
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 17 Jul 2014 09:16:43 +0000 (11:16 +0200)]
Report IllegalArgument instead of IllegalState
This is wrong input, not internal state.
Change-Id: I8a0d459a308f309229cf55955be3a77604d47a1d
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Thu, 24 Jul 2014 15:30:07 +0000 (15:30 +0000)]
Merge "BUG-1287: migrate pcep-topology-provider"
Robert Varga [Thu, 24 Jul 2014 03:25:17 +0000 (05:25 +0200)]
BUG-1394: do not read in tight loops
We want to make sure we give writes a chance to complete before reading
again. Lower the amount of processing we do per loop to a single
message.
Change-Id: Iecf029afd2c2ae0288c5c483569e9acff7545a64
Signed-off-by: Robert Varga <rovarga@cisco.com>
Milos Fabian [Mon, 21 Jul 2014 06:25:30 +0000 (08:25 +0200)]
BUG-1287: migrate pcep-topology-provider
-fixed config tests
-ParserToSalTest uses AbstractDataBrokerTest
Change-Id: I93f20d32cce9fbd6dead2a0b181d4852f41181db
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Sun, 20 Jul 2014 14:45:27 +0000 (16:45 +0200)]
BUG-1287: migrate programming-impl
-fixed config tests to use new md-sal configuration
-ProgrammingServiceImplTest uses AbstractDataBroker test instead of mocked DataBroker
Change-Id: I6b0b110c9a61253f8ab17b6ca9f7fb44bf218460
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Dana Kutenicsova [Wed, 23 Jul 2014 08:33:08 +0000 (08:33 +0000)]
Merge "BUG-1394: add traces"
Robert Varga [Mon, 21 Jul 2014 08:37:22 +0000 (10:37 +0200)]
Add defensive checks when looking up attributes
Lookup of attributes is made more hardened, so we do not lose prefixes,
but only attributes in things go south.
Also adds an explicit argument check for null objectType to track down a
NPE we have been hitting.
Change-Id: I2eacc5c66cac747e1ebeb9d88367dcd1e4ea9281
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 18 Jul 2014 15:24:18 +0000 (17:24 +0200)]
BUG-1394: add traces
It seems that when we are processing a PCRpt, the request should already
be in the queue, but we are failing to find it. This should not occur,
so let's add some traces to pinpoint it.
Change-Id: I5c8ee574ab1c95fc25d465374a26a944ecc0b2ce
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sun, 20 Jul 2014 22:22:22 +0000 (00:22 +0200)]
Migrate to use tcpmd5 code in its new place
The TCP-MD5 has been bigrate into its own project and thus lives in new
artifacts, new packages and under a different version. This patch
removes the code from BGPCEP repository and points all callsites to the
new place.
Change-Id: Ic061ba419dd350f32eb7e212fdb6a8cbff243673
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 22 Jul 2014 11:52:54 +0000 (13:52 +0200)]
Always set the list of uncleaned instructions
Change-Id: Idbcc7b2d1c69d406ab0d34493d75a48da35aa111
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Mon, 21 Jul 2014 18:24:11 +0000 (18:24 +0000)]
Merge "Rework BGP timers to work with channel"
Robert Varga [Fri, 18 Jul 2014 16:30:44 +0000 (18:30 +0200)]
Rework BGP timers to work with channel
Since netty channel gives us scheduling capabilities, there is simply no
need for an external timer. So let's get rid of it and simplify our
code.
Change-Id: If6b7f84dbb953fc1766a6ddceb8411abcf1dc442
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Mon, 21 Jul 2014 09:22:03 +0000 (11:22 +0200)]
BUG-1389 : fixed removing of LSP by checking remove flag in SRP-id
Change-Id: I3788157c04a10b6052bb379907fc7cb0d250887c
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Mon, 21 Jul 2014 14:58:16 +0000 (14:58 +0000)]
Merge "Rework PCEP timers to work on channel"
Dana Kutenicsova [Mon, 21 Jul 2014 12:56:04 +0000 (14:56 +0200)]
Fixed failing build after yangtools update (List fields are by default not null).
- added checks for empty
Change-Id: I1a6eb2481f85ce895e2c17a229b11cf8f0ba2fc4
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Fri, 18 Jul 2014 15:41:59 +0000 (17:41 +0200)]
Rework PCEP timers to work on channel
This has the nice property that netty will ensure thread safety, e.g. we
do not have to synchronize channel lifecycle events anymore.
Change-Id: I37ddd71b6cca8210573e767966032885a7678669
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Fri, 18 Jul 2014 16:32:56 +0000 (16:32 +0000)]
Merge "Bug-194: Deleted jni-cfg artifact."
Dana Kutenicsova [Fri, 18 Jul 2014 08:02:13 +0000 (08:02 +0000)]
Merge "Bug-1370: Support for four-octet AS number capability only."
Milos Fabian [Wed, 16 Jul 2014 12:24:46 +0000 (14:24 +0200)]
Bug-194: Deleted jni-cfg artifact.
Dependency removed from integration SP dist.:
https://git.opendaylight.org/gerrit/#/c/9125/
Change-Id: Icc9cde348df549795dd79f15b549ab9a6091f8cb
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Thu, 17 Jul 2014 08:43:32 +0000 (10:43 +0200)]
Bug-1370: Support for four-octet AS number capability only.
-Both BGP speaker and peer, must advertise "support for four-octet AS number capability", to establish connection.
Change-Id: I2998e20439c12aca4e1a31660260d52f5d4963b5
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Dana Kutenicsova [Thu, 17 Jul 2014 11:34:48 +0000 (13:34 +0200)]
BUG-731 : removed some sonar warnings
Change-Id: I4b1a5cdd7a12acca6b86eebd384066fc918ff2e4
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Milos Fabian [Thu, 17 Jul 2014 05:46:41 +0000 (07:46 +0200)]
Bug-194: Explicitly include yang file and services in bundle.
Change-Id: Id207403ecbd2ef0e2e77690a6272d21a5f5ef19f
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Dana Kutenicsova [Thu, 17 Jul 2014 07:02:31 +0000 (07:02 +0000)]
Merge "Revert "Bug 1205 - AS path segment value encoded by 2 bytes""
Robert Varga [Wed, 16 Jul 2014 17:16:43 +0000 (17:16 +0000)]
Merge "Bug-194: Moved tcpmd5/jni-cfg to tcpmd5/jni"
Milos Fabian [Wed, 16 Jul 2014 13:50:53 +0000 (15:50 +0200)]
Revert "Bug 1205 - AS path segment value encoded by 2 bytes"
This reverts commit
d4f23f2d138b7bf0f1e1d2b61b5720749daf207f.
Change-Id: Iaa6e1d467630ba4bc32d9b67db6f09150d46d914
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Robert Varga [Wed, 16 Jul 2014 10:57:39 +0000 (12:57 +0200)]
Add missing tcpmd5-controller-config .project file
Change-Id: I55e7ad85cf9c0e35b3b39dfe2121081301d9308e
Signed-off-by: Robert Varga <rovarga@cisco.com>
Milos Fabian [Wed, 16 Jul 2014 11:48:19 +0000 (13:48 +0200)]
Bug-194: Moved tcpmd5/jni-cfg to tcpmd5/jni
-moved cfg yang model and java files
-preserved minimalistic pom.xml in tcpmd5/jni-cfg
Change-Id: Ifee8463c33376a9da076dcc9297452d506e47897
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Robert Varga [Wed, 16 Jul 2014 10:59:50 +0000 (10:59 +0000)]
Merge "Fixed PCEP activator. Fixed ExcludeRouteObject type."
Dana Kutenicsova [Wed, 16 Jul 2014 08:26:33 +0000 (10:26 +0200)]
Fixed PCEP activator.
Fixed ExcludeRouteObject type.
Change-Id: I77229dab5b92457fd425a489178e6d8b60a3282f
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Milos Fabian [Wed, 16 Jul 2014 08:00:23 +0000 (10:00 +0200)]
Bug-194: Fixed BGPCEP initail configurations.
Change-Id: I030c2996fdd2f4d2371247ee166bda0e86b66cba
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Fri, 11 Jul 2014 08:35:36 +0000 (10:35 +0200)]
Bug-194: Deleted BGPCEP config artifacts.
Change-Id: Id3d921dd86951388212c1d732043ef6a445bc1f5
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Robert Varga [Wed, 16 Jul 2014 07:27:12 +0000 (07:27 +0000)]
Merge "Bug-1370: Reads message body bytes as well as exception is thrown during parsing."