Michal Rehak [Tue, 8 Sep 2015 19:19:32 +0000 (21:19 +0200)]
BUG-4118: Li:backward compatibility - rpcs - stats services
- added flow statistics services with notification emitting feature
- added group statistics services with notification emitting feature
- added meter statistics services with notification emitting feature
- added port statistics services with notification emitting feature
- added queue statistics services with notification emitting feature
- added tests
Change-Id: Iffc6637e6f1a81be11cb9ef9479557837195c678
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Michal Rehak [Tue, 8 Sep 2015 19:15:44 +0000 (21:15 +0200)]
BUG-4118: Li:backward compatibility - rpcs - transformers
- added general stats to notificatin transformers
- added abstract service providing transaction aware result
and async notification
Change-Id: If902096e1bd1041aa9ae1d5e23cd45fcc5eef5ea
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Michal Rehak [Tue, 8 Sep 2015 19:11:18 +0000 (21:11 +0200)]
BUG-4118: Li:backward compatibility - rpcs - initial proposal
- added config subsystem parameter for stats rpc control
- API changes for delegating of new parameter, service lookup
Change-Id: I5a639b30a83fd9b025da5c7e1faffdc63eb1315b
Signed-off-by: Michal Rehak <mirehak@cisco.com>
michal rehak [Fri, 27 Nov 2015 13:19:16 +0000 (13:19 +0000)]
Merge "Remove antlr4-runtime-osgi-nohead"
Thanh Ha [Fri, 27 Nov 2015 06:48:13 +0000 (01:48 -0500)]
Remove antlr4-runtime-osgi-nohead
This bundle was removed from yangtools so no longer exists. See:
https://git.opendaylight.org/gerrit/28272/
Change-Id: Iaea7f5022ac1e4706cddcface7726bbdf67ac8ed
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Signed-off-by: Stephen Kitt <skitt@redhat.com>
MonikaVerma [Thu, 26 Nov 2015 11:57:24 +0000 (17:27 +0530)]
Adding the unit tests for StatListenCommitFlow.java for Bug#3957
Change-Id: Iba725bc4bdd0063a72c5800673c5c58c8e31b5e5
Signed-off-by: MonikaVerma <monika.verma1@tcs.com>
Abhijit Kumbhare [Wed, 25 Nov 2015 23:24:52 +0000 (23:24 +0000)]
Merge "BUG-4565: queue stats error"
Michal Rehak [Fri, 23 Oct 2015 12:51:10 +0000 (14:51 +0200)]
BUG-4283 experimenter msg support - service expose part
- added sal-experimenter-service exposing experimenter message
sending and listening to experimenter notification
Change-Id: I24e0917f5e33f98dd1c11a32b37db47709483873
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Michal Rehak [Fri, 23 Oct 2015 12:49:40 +0000 (14:49 +0200)]
BUG-4283 experimenter msg support - exceptions part
- added conversion related exceptions for experimenter message converters
Change-Id: I593f8896d138619b93de68f07be9b86b2ae899b3
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Michal Rehak [Thu, 22 Oct 2015 18:40:12 +0000 (20:40 +0200)]
BUG-4283 experimenter msg support - provider part
- added provider infrastructure for experimenter message converters
Change-Id: I12e393ddbf1a4439763bc6922958005cec8a7bf4
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Anil Vishnoi [Fri, 13 Nov 2015 17:04:12 +0000 (17:04 +0000)]
Merge "BUG-4283 experimenter msg support - registration part"
Kamal Rameshan [Fri, 9 Oct 2015 00:12:26 +0000 (17:12 -0700)]
Bug-4433:OF Version 10 does not get ommitted for clustering
Change-Id: I928be12d3dd1b28f6cf110f6a6f99f14d993b35c
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
Kamal Rameshan [Mon, 5 Oct 2015 05:16:17 +0000 (22:16 -0700)]
Handle cancel txn exception for slaves and device disconnect exception
During the device initialization process, if its encountered that the role for this node is slave
we cancel the txn which is built during the process.
Now since ping-pong txn does not have a cancel, we drop the txn and recreate it. This throws an exception
Since this is an expected exception, it would be advisable to catch and log it in debug.
Also when a node gets disconected from device, the EntityOwnershipService does send a notification. Which trigers a role change.
A check is made to check if the device is connected before moving ahead with the role change.
Change-Id: I76572f27274f5c5f08117fcfd1590d1042049735
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
Kamal Rameshan [Sun, 4 Oct 2015 07:15:18 +0000 (00:15 -0700)]
Inventory Cleanup fails as txn could not be created
Cleanup of the inventory is done post closure of txn manager.
Hence if the status of the txn manager is shutting-down, get the WriteTx directly
to perform a datastore cleanup
Change-Id: If9dc9449f7e54e54ea4159376217297f6998e289
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
Kamal Rameshan [Sun, 4 Oct 2015 06:13:59 +0000 (23:13 -0700)]
RPC Registration changes for clustering
1. Unregisters rpcs for master/equal to slave scenario as well.
2. Made RpcManager as the device-context-closed-handler , instead of the RpcContext
3. If Role Change fails after several attempts on a switch, the device context is closed. This is to avoid rpcs getting registered in wrong nodes.
4. Removed debug exception for device close in RoleManagerImpl
5. Addition of Logs
Change-Id: Ie5af7466b1422698d3c3287195d237fe1407b023
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
Kamal Rameshan [Fri, 2 Oct 2015 07:51:16 +0000 (00:51 -0700)]
Getting latest state from Ownership RPC
Takes care of two scenarios
1. Switch connects to a second controller, after first controller is master.
In this case it wont get an Ownership Changed notification
2. Controller which is slave restarts and registers a candidate. Still it wont get a notification.
Notification is only sent when there is a change in the ownership in the OwnershipService
Change-Id: Ifdc5023a711bb66eb36f4d03e294456776810c50
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
Kamal Rameshan [Sun, 30 Aug 2015 00:03:50 +0000 (17:03 -0700)]
RoleManager,SalRoleService Impl and Test
1. Created a Role manager and RoleContext which would get invoked as part of the device init phase
2. Introduced dependency to EntityOwnership service , to get the ownership (implemented in controller)
4. RoleManager requests ownership from EntityOwnership and on notification makes a role change call SalRoleService
5. SalRoleService makes a role change to the device
6. Tests
Change-Id: Ie443d519be985b867d5c6f9ce8473fbd6cdf4dca
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
Signed-off-by: Moiz Raja <moraja@cisco.com>
Jamo Luhrsen [Mon, 26 Oct 2015 21:48:34 +0000 (14:48 -0700)]
moving "context not found" log message to INFO level
Change-Id: I1673074575edd013c3032b8a02268c944a39e141
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
Michal Rehak [Tue, 3 Nov 2015 14:54:21 +0000 (15:54 +0100)]
BUG-4565: queue stats error
- queues do not have any other inspect message but statistics query,
here 1 parent was missing when writing queue stats into DS/operational
- addapted data assembly in order to create queue node
- added TODO: we need to clean existing queues before writing fresh ones
- fixed test
Change-Id: Icfcb692100b2a0aa666c2e578b09cd903e59fd80
Signed-off-by: Michal Rehak <mirehak@cisco.com>
(cherry picked from commit
b706170bb88018010bde3d8bd84ef1bbf4662943)
Tony Tkacik [Fri, 30 Oct 2015 13:20:42 +0000 (14:20 +0100)]
Fixed mising ; in presence statements.
Change-Id: Ica105d65f3d49ca6f03c7b326d8338888a3ea937
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Michal Rehak [Thu, 22 Oct 2015 15:37:51 +0000 (17:37 +0200)]
BUG-4283 experimenter msg support - registration part
- added registration point for experimenter message converters
- depends on OFJava https://git.opendaylight.org/gerrit/#/c/28813/
- checkstyle fix
Change-Id: Ibb8294c522335a0f5df783fbf92b617e45f29930
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Michal Rehak [Thu, 29 Oct 2015 14:09:33 +0000 (15:09 +0100)]
BUG-4551: impact of YT BUG 2399 - action model fixing
- added presence element to empty action containers
- added sleep in order to follow port openings with some time reserve
Change-Id: Ia96c0f821455600a412df56c3d353b76184f26ef
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
michal rehak [Tue, 20 Oct 2015 15:22:34 +0000 (15:22 +0000)]
Merge "Add missing information from table features"
michal rehak [Tue, 20 Oct 2015 13:50:47 +0000 (13:50 +0000)]
Merge "Fix a few spelling mistakes in log output"
michal rehak [Tue, 20 Oct 2015 13:49:49 +0000 (13:49 +0000)]
Merge "Bug-4442 : PacketOut action headers are not implemented or ignored"
Renato Aguiar [Mon, 19 Oct 2015 15:34:05 +0000 (08:34 -0700)]
Add missing information from table features
Some information from table features were missing on MD-SAL Operational
DataStore:
1) Instructions on <instructions> and <instructions-miss>
2) Actions on <apply-actions>, <apply-actions-miss>, <write-actions>
and <write-actions-miss>
Change-Id: I31d6a84c821ae4671ae2ee079935ffc959c61ef0
Signed-off-by: Renato Aguiar <renato.aguiar@hp.com>
Michal Polkorab [Mon, 19 Oct 2015 11:09:45 +0000 (13:09 +0200)]
Openflowjava-util rename reflecting change
- openflowjava change: https://git.opendaylight.org/gerrit/#/c/28333/
Change-Id: I1a5fcae9e16c7d9bdd187ce588a509442816d6c1
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
michal rehak [Thu, 15 Oct 2015 18:15:47 +0000 (18:15 +0000)]
Merge "sal role service and role injection"
michal rehak [Thu, 15 Oct 2015 18:15:24 +0000 (18:15 +0000)]
Merge "Deleted unnecessary file."
Kamal Rameshan [Fri, 9 Oct 2015 05:44:26 +0000 (22:44 -0700)]
Bug-4442 : PacketOut action headers are not implemented or ignored
Change-Id: I5a31898035e857ef677fc163dc3670cb977e8b4e
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
Kamal Rameshan [Fri, 21 Aug 2015 20:45:56 +0000 (13:45 -0700)]
sal role service and role injection
role cannot be assigned to the whole of openflowplugin.
Since we are scaling switches across a cluster, the role would be assigned per device.
Added a new sal-role yang, rpc and service.
This would be the first of subsequent commits.
Made changes to merge to master - header and testchanges
Change-Id: I0a681485c5ccb8bc839b3b18f3efb648b88bd86b
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
(cherry picked from commit
f6d2398e08b0a9b2d7bb5c533e9ca17a5041a74f)
Kamal Rameshan [Sun, 27 Sep 2015 17:30:50 +0000 (10:30 -0700)]
Bug:4343-Ipaddress not set in FlowCapableNode
Change-Id: Ic48b2ba2494f1765a50b52309662d2bee228d741
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
(cherry picked from commit
c48b2ba2494f1765a50b52309662d2bee228d741)
Tony Tkacik [Thu, 15 Oct 2015 12:51:27 +0000 (14:51 +0200)]
Deleted unnecessary file.
Change-Id: I050014dd6cfe9022de8374a80a918d8efa54ee67
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Ryan Goulding [Mon, 12 Oct 2015 14:28:28 +0000 (10:28 -0400)]
Fix a few spelling mistakes in log output
Change-Id: I7743ad87943602aff1d2ddada9fc3ea26fecb676
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Shuva Jyoti Kar [Sun, 4 Oct 2015 07:29:18 +0000 (12:59 +0530)]
[Bug:4069]Ordering chained-groups during reconc
Change-Id: I4988d3b8b616a6bab60805cc00c9b04c8f1fea32
Signed-off-by: Shuva Jyoti Kar <shuva.jyoti.kar@ericsson.com>
dimgi [Mon, 28 Sep 2015 17:24:18 +0000 (20:24 +0300)]
BUG-2664 - Buckets in groups are not ordered
Change-Id: I4e199e859656a76842937c6734b821a89ec3bd7c
Signed-off-by: dimgi <dimgi@intracom-telecom.com>
Jozef Gloncak [Mon, 28 Sep 2015 06:25:06 +0000 (08:25 +0200)]
BUG-4340: raise test coverage to 80% - StatisticsManager related
- added mocked response from device
Change-Id: I942883377b94430a2ac073ae2488e63b62dd1bcc
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Mon, 28 Sep 2015 06:25:03 +0000 (08:25 +0200)]
BUG-4340: raise test coverage to 80% - DeviceManager related
- added close()
- added OF-1.0 codepath - phyPort
Change-Id: Ic9da1c69a78ab7700c3718abd2d49ca8dea005b5
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Mon, 28 Sep 2015 06:24:57 +0000 (08:24 +0200)]
BUG-4340: raise test coverage to 80% - multipart callback related
- covered on success - most code paths:
- MultipartRequestOnTheFlyCallback
- MultipartRequestCallback
Change-Id: Ia462410587a7650ff69a932a8454c26736104ca9
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
michal rehak [Wed, 23 Sep 2015 12:11:13 +0000 (12:11 +0000)]
Merge "BUG-4326: Eliminate dependency to org.apache.mina"
Jozef Gloncak [Wed, 23 Sep 2015 06:20:51 +0000 (08:20 +0200)]
BUG-4328: TransactionChainManager state
- txChainManager actually never goes back from SHUTTING_DOWN state
- added more unit tests in order to exersize the tear down mechanism
Change-Id: I6ef95d6b8e7d8211c81ce7f6e286756a040c535e
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Wed, 23 Sep 2015 06:17:10 +0000 (08:17 +0200)]
BUG-4326: Eliminate dependency to org.apache.mina
- replaced ConcurrentHashSet with Collections.newSetFromMap()
Change-Id: I88821f76d1e5a7e0a9e9a15ef3c9d36cb7b7aad3
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Tue, 22 Sep 2015 13:29:15 +0000 (15:29 +0200)]
BUG-4340: raise test coverage to 80% - statistics related
- statisticsGathering services related test
Change-Id: I631224e084cdb10541bbd75632984878a47af3d1
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Tue, 22 Sep 2015 13:29:12 +0000 (15:29 +0200)]
BUG-4340: raise test coverage to 80% - connection related
- ofpListenerInitialImpl related test
- connection context related tests
Change-Id: I8f93f9739dbcaabaa7ee87f065216d3278b3af30
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Tue, 22 Sep 2015 13:29:06 +0000 (15:29 +0200)]
BUG-4340: raise test coverage to 80% - services related
- salFlowService related tests
- flowCapableTransaction + packetProcessing related tests
- salTableService related test
Change-Id: I8215494765c78bb2f3197f3420a41ca76ed23cfc
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Tue, 22 Sep 2015 13:28:55 +0000 (15:28 +0200)]
BUG-4340: raise test coverage to 80% - transaction related
- transactionChainManager related tests
Change-Id: If3aa1910b88a11c4b8e0d82eece0aebfe6595e7c
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Tue, 22 Sep 2015 13:28:50 +0000 (15:28 +0200)]
BUG-4340: raise test coverage to 80% - device related
- packetInLimiter related tests
- deviceContextImpl related tests
- deviceManager related test
Change-Id: Ie306aa8a500598241eb16f285a845da18f4bd5fe
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Tue, 22 Sep 2015 13:28:33 +0000 (15:28 +0200)]
BUG-4340: raise test coverage to 80% - int.registry related
- internal flow/group/meter registry related tests
Change-Id: Id31a0fa1f3dac287cccc3151fa609ec2223e4b09
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Tue, 22 Sep 2015 13:28:26 +0000 (15:28 +0200)]
BUG-4340: raise test coverage to 80% - clean disabled tests
- removed ignored/disabled tests
Change-Id: I971639ec7a1ba195cfa5d6b635d39285c6c1a6db
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
michal rehak [Thu, 17 Sep 2015 10:56:29 +0000 (10:56 +0000)]
Merge "Use odlparent configuration for jacoco"
michal rehak [Thu, 17 Sep 2015 10:36:20 +0000 (10:36 +0000)]
Merge "Refactoring of 'extractIpv4Mask' method"
michal rehak [Thu, 17 Sep 2015 10:35:20 +0000 (10:35 +0000)]
Merge "Removed useless method"
michal rehak [Thu, 17 Sep 2015 10:34:53 +0000 (10:34 +0000)]
Merge "Removed useless variable"
michal rehak [Thu, 17 Sep 2015 10:34:39 +0000 (10:34 +0000)]
Merge "Refactoring: shortening of match methods"
Anil Vishnoi [Wed, 16 Sep 2015 16:55:21 +0000 (16:55 +0000)]
Merge "Convert features to features-parent"
Icaro Camelo [Fri, 14 Aug 2015 13:52:18 +0000 (09:52 -0400)]
Ignored .checkstyle files
Change-Id: Ifcfb778139d61f87cf505082672a74327be77001
Signed-off-by: Icaro Camelo <icamelo@inocybe.com>
Icaro Camelo [Thu, 13 Aug 2015 20:41:50 +0000 (16:41 -0400)]
Extracted constant
Change-Id: If26302b301ed581ae9e5f5df768ca9a37f3f2b35
Signed-off-by: Icaro Camelo <icamelo@inocybe.com>
michal rehak [Wed, 16 Sep 2015 16:10:30 +0000 (16:10 +0000)]
Merge "Removed unused fields"
Robert Varga [Wed, 17 Jun 2015 00:15:19 +0000 (02:15 +0200)]
Convert features to features-parent
Switches from hand-written features.xml, to a processed template,
lowering the need for magic properties.
Additional changes:
- migrated application and extensions features
- fixed legacy
- removed duplicate specified dependency version
- cleaned properties
- removed outdated version for xml-apis dependency
- included new extensions/feature-li (pom+features)
(based on commit
b4a79dbdfdc7dc00d3c1a477ad57d7c4192839fe)
Change-Id: I7089c1ee27eca228d05ec8942812a0466f71c153
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Jozef Gloncak [Thu, 10 Sep 2015 10:51:15 +0000 (12:51 +0200)]
BUG 4270 - Add missing versions, dependencies
Change-Id: I01a5fe9cec90c7009fd0dd8f7507513ab4a4acd4
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Anil Vishnoi [Thu, 10 Sep 2015 08:17:19 +0000 (08:17 +0000)]
Merge "BUG 4270 - adding reference to Li bundle to Li Nicira extension."
michal rehak [Thu, 10 Sep 2015 07:14:34 +0000 (07:14 +0000)]
Merge "Migration to use MD-SAL Project"
Jozef Gloncak [Wed, 9 Sep 2015 13:59:52 +0000 (15:59 +0200)]
BUG 4270 - adding reference to Li bundle to Li Nicira extension.
Change-Id: I14b1abf3b63c92e20bb65da2587f8e0260ad234b
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Tony Tkacik [Wed, 2 Sep 2015 14:13:30 +0000 (16:13 +0200)]
Migration to use MD-SAL Project
Change-Id: I8be5de8f8ea89d7e03f925d8a0da5a15e0a11adf
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Tue, 8 Sep 2015 08:58:07 +0000 (10:58 +0200)]
Removed legacy AD-SAL compatibility
AD-SAL is not part of beryllium, so dependencies
used by AD-SAL adapter are not available in
controller, autorelease and offline mode.
Since this code is not supported, lets remove it
to decrease technical debt.
Change-Id: Ifb4b9e7ec04b00566d421d0089e1dd629ee755d8
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tomas Cere [Fri, 4 Sep 2015 12:46:16 +0000 (14:46 +0200)]
Migrate restconf dependencies
Change-Id: I4ca3d812e80172c9398cbd6043fa6b710cae57cd
Signed-off-by: Tomas Cere <tcere@cisco.com>
Icaro Camelo [Thu, 13 Aug 2015 20:38:31 +0000 (16:38 -0400)]
Removed unused fields
Change-Id: Ia020ef62e922d047c5540f3f6a01d9b70167a21b
Signed-off-by: Icaro Camelo <icamelo@inocybe.com>
Thanh Ha [Wed, 2 Sep 2015 03:53:55 +0000 (23:53 -0400)]
Use odlparent configuration for jacoco
Change-Id: I9724253d6a7a51e844b7833f36124722358a338d
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Anil Vishnoi [Fri, 28 Aug 2015 12:22:31 +0000 (12:22 +0000)]
Merge "BUG-4123: Li:flow statistics are not passed into DS/operational"
Anil Vishnoi [Fri, 28 Aug 2015 12:21:31 +0000 (12:21 +0000)]
Merge "update nagasena dependencies for IT"
Anil Vishnoi [Fri, 28 Aug 2015 12:19:24 +0000 (12:19 +0000)]
Merge "BUG-4085: Li: support flowRemoved notifications when SM is off"
Anil Vishnoi [Fri, 28 Aug 2015 12:18:29 +0000 (12:18 +0000)]
Merge "BUG-4085: Li: provisioning translators"
michal rehak [Fri, 28 Aug 2015 11:48:38 +0000 (11:48 +0000)]
Merge "BUG-4084: Li:Save meters in operational DS based on barrier success"
michal rehak [Fri, 28 Aug 2015 11:41:17 +0000 (11:41 +0000)]
Merge "Fix pep8 violations in odl_meter_test"
michal rehak [Fri, 28 Aug 2015 11:41:12 +0000 (11:41 +0000)]
Merge "Fix pep8 violations in xml_validator"
Jozef Gloncak [Wed, 19 Aug 2015 12:19:28 +0000 (14:19 +0200)]
BUG-4084: Li:Save meters in operational DS based on barrier success
ItemLifeCycleListener also added to SalMeterServiceImpl class to be able
persist information about add/delete/update of meter to operational DS when
statistic collecting is switched off.
Change-Id: I9176353a498d76f735d9a089c4e3e088efd668cd
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
michal rehak [Fri, 28 Aug 2015 09:21:22 +0000 (09:21 +0000)]
Merge "BUG-4084: Li: Log unsuccessful submiting of write transactiion"
Michal Rehak [Tue, 25 Aug 2015 17:54:55 +0000 (19:54 +0200)]
BUG-4085: Li: support flowRemoved notifications when SM is off
- attach flowRemoved to itemLifecycleSource
Change-Id: Ide24af418963a46ab1d12997caab1aacfc9b87da
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Michal Rehak [Wed, 26 Aug 2015 10:44:18 +0000 (12:44 +0200)]
BUG-4085: Li: provisioning translators
- changed match conversion to returning builder
- added special flowRemoved message translators
Change-Id: I3d431ff1fea3fef26157f96a16d21cfc900b898f
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Jozef Gloncak [Fri, 21 Aug 2015 13:39:55 +0000 (15:39 +0200)]
BUG-4084: Li: Log unsuccessful submiting of write transactiion
If some exception occures during transaction submiting it is
logged (until now it was silently ignored).
Change-Id: I576572949259e9dd41be3efd6bd6a0a0a07955ee
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Wed, 19 Aug 2015 10:13:17 +0000 (12:13 +0200)]
BUG-4084: Li:Save groups in operational DS based on barrier success
ItemLifeCycleListener also added to SalGroupServiceImpl class to be able
persist information about add/delete/update of grouping to operational DS.
Change-Id: Ia2347af3133d7c68f54f206683d5dc981e81f9dd
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Jozef Gloncak [Tue, 18 Aug 2015 13:10:09 +0000 (15:10 +0200)]
BUG-4084: Li:Save flows in operational based on barrier success
- added ItemLifeCycleSource as the basic unit sourcing changes for
DS/operational
- this unit is provided by registered rpc services and if statistics
are disabled then those units are listened to in order to keep device
reflection in DS up to date
- TODO: this covers flows only, groups and meters are on the line
- from Jozef Gloncak: small fix of failing junit test
- from Jozef Gloncak: change in test TimeCounterTest:
Time marks are set in times 2 ms, 4 ms, 9 ms.
Waited average time are 2/1 = 2 ms, 4/2 = 2 ms, 9/3 = 3 ms
But this times are only theoretical if whole test is executed
without latency and atomically. Therefore awaited average times
can't be compared to exact values of awaited average time.
(therefore == was replaced with >=)
Change-Id: Ie52ad4421745b09db68dec5c9b1be1b64d04d697
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Anil Vishnoi [Fri, 28 Aug 2015 07:22:32 +0000 (07:22 +0000)]
Merge "BUG-4177: Li - flowMod result ignores errors from device"
michal rehak [Fri, 28 Aug 2015 07:20:12 +0000 (07:20 +0000)]
Merge "Add tox.ini to check for pep8 violations"
Thanh Ha [Thu, 27 Aug 2015 22:34:33 +0000 (18:34 -0400)]
Fix pep8 violations in odl_meter_test
Change-Id: I8289a7c77ececc1f4d58919ca8c48bea3664dff9
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Thu, 27 Aug 2015 21:52:45 +0000 (17:52 -0400)]
Fix pep8 violations in xml_validator
Change-Id: Ibe4afe4d4602549b0c00e4d222fbc59edb49d305
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Thu, 27 Aug 2015 21:54:02 +0000 (17:54 -0400)]
Add tox.ini to check for pep8 violations
Change-Id: I1d39fb8a2e5b96aafe8167fdde400641acb44f5d
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Thu, 27 Aug 2015 22:04:18 +0000 (18:04 -0400)]
Fix typos and reformat document
Change-Id: I6774f0ee2034c5f04c4fe3c21a1ddd1c8eac2704
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Michal Rehak [Wed, 26 Aug 2015 15:17:03 +0000 (17:17 +0200)]
update nagasena dependencies for IT
- based on commit
660539660393f1739de7956255f5d2abe54e259b (stable/lithium)
- on master there is no more dependency to netconf stuff
so we keep defining latest nagasena depdendecy locally
Change-Id: I8bedea3927dee66df9432b7df7f3bcf411f375be
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Michal Rehak [Mon, 24 Aug 2015 16:37:39 +0000 (18:37 +0200)]
BUG-4177: Li - flowMod result ignores errors from device
- added errors from original partial rpcResults to final rpcResul
- adapted unit tests
Change-Id: I43964c8f7afdfb4e3e748a33b68b7117fe95d710
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Jozef Gloncak [Mon, 24 Aug 2015 11:41:05 +0000 (13:41 +0200)]
BUG-4083: Li: knob to disable statistics collecting
- added rpc for get and change the work mode of statistics-manager
- minor changes regarding collection scheduling (adaptive timeCouter)
Change-Id: Ie4bdfb493951b28f027e85cb8beeb456bc730c18
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Mon, 24 Aug 2015 10:01:47 +0000 (12:01 +0200)]
BUG-4083: Li: Enabling polling of statistics via config subsystem.
New leaf >is-statistics-polling-off< was added to
openflow-plugin-impl.yang. Now it is possible to set statistic
gathering (ON|OFF) via configuration of 42-openflowplugin-new.xml -
add <is-statistics-polling-off>true|false</is-statistics-polling-off>
xml element to
configuration/data/modules/module/name=openflow-plugin-provider-impl
Change-Id: I3f8a8cee35f389a8804bb0234c61de686b5273a4
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Icaro Camelo [Tue, 18 Aug 2015 16:34:18 +0000 (12:34 -0400)]
Refactoring of 'extractIpv4Mask' method
Change-Id: Ifa574330303a44546e4612f3ceb0e8b5240c617e
Signed-off-by: Icaro Camelo <icamelo@inocybe.com>
Icaro Camelo [Tue, 18 Aug 2015 16:27:21 +0000 (12:27 -0400)]
Removed useless method
Change-Id: Ia1d267b81db82abe06e31af604e83bc56aa7a866
Signed-off-by: Icaro Camelo <icamelo@inocybe.com>
Icaro Camelo [Tue, 18 Aug 2015 16:25:32 +0000 (12:25 -0400)]
Removed useless variable
Change-Id: I23cfe98cd7de3db459506ea3bacea012568cf408
Signed-off-by: Icaro Camelo <icamelo@inocybe.com>
Icaro Camelo [Tue, 18 Aug 2015 16:20:43 +0000 (12:20 -0400)]
Refactoring: shortening of match methods
Change-Id: I2f83670e27c19cb819ab49370fa1c412326ddcd5
Signed-off-by: Icaro Camelo <icamelo@inocybe.com>
Icaro Camelo [Tue, 18 Aug 2015 16:05:48 +0000 (12:05 -0400)]
Fixed constant pattern name
Change-Id: Ib6dd1d74990250829b8e9b7a11c549d843af74d7
Signed-off-by: Icaro Camelo <icamelo@inocybe.com>
Icaro Camelo [Tue, 18 Aug 2015 15:47:52 +0000 (11:47 -0400)]
Removed useless boolean object instantiation
Change-Id: I6a89c599f8ab667d1ee0908097904c0c8061d7c7
Signed-off-by: Icaro Camelo <icamelo@inocybe.com>
Icaro Camelo [Tue, 18 Aug 2015 15:45:48 +0000 (11:45 -0400)]
Removed commented code
Change-Id: I750f42463060526f32c851c4c6095fe8bacc0898
Signed-off-by: Icaro Camelo <icamelo@inocybe.com>
Icaro Camelo [Mon, 17 Aug 2015 18:03:39 +0000 (14:03 -0400)]
Fixed magic numbers
Change-Id: I2076bcc6bfad08c48b64b015c64b93f5e5cc3ab9
Signed-off-by: Icaro Camelo <icamelo@inocybe.com>