Updated git submodules
Project: openflowplugin stable/carbon
d9d4102ab215b42ed4630e2d2ad9539cd114e860
Fix possible transaction leak in StatisticsGatheringUtils
see https://jira.opendaylight.org/projects/OPNFLWPLUG/issues/OPNFLWPLUG-961;
5x transactions opened here which were not closed
Change-Id: I1d9983a257881a7618943f76a6780a14c4e97e82
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
bug-7826: Data validation failed for group-id
OPNFLWPLUG-858
Identified the root cause for issue TransactionCommitFailed for group during statistic collection.
Change-Id: I8fe639e6102629fb903689114c617e76a61d68db
Signed-off-by: sunilkumarms <sunil.g.kumar@ericsson.com>
OPNFLWPLUG-930 Inconsistent flow IDs between flows
in config and operational data stores
Change-Id: I4ee8787e163a6ab64a4574f0dc906c7c91a7d0b2
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Bump versions by x.y.(z+1)
Change-Id: I765b74e91d07f2b32ef5eb679ea04943844ba4e0
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Merge "BUG-9223:Remove hardcoded value of lldp interval" into stable/carbon
Merge "This patch implements ct-mark support in nicira extensions." into stable/carbon
BUG-9223:Remove hardcoded value of lldp interval
Cherry-pick changes from stable/boron
Addressed comments
Change-Id: Id4fe81e27663cf89af8d95be577826988deeb7fe
Signed-off-by: Jalpa Modasiya <jmodasiy@luminanetworks.com>
Fix possible NPE on ContextChainHolderImpl
- deviceConnected method
Change-Id: I7cbd8c3bb2a4d92ecdaa5fc541e01e3d8ac738b6
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
This patch implements ct-mark support in nicira extensions.
Specifically:
- support for ct-mark MATCH, including mask.
- support for ct-mark ACTION (set-field), but not including mask
This patch supports implementing ACL spec:
https://git.opendaylight.org/gerrit/#/c/60580
Change-Id: Ib828da39b4470e7172fe7028e8d3123fb184c742
Signed-off-by: Bertrand <bertrand.low@hcl.com>
Merge "Sort bucket actions" into stable/carbon
Do not try to close context with null deviceInfo
Do not try to lookup contextChain with null deviceInfo to prevent
NullPointerException.
Resolves: bug 9217
Change-Id: I8f5d860317375e20a7df9bb8ab5031af62c43936
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Sort bucket actions
Sort bucket actions by order when serializing them in
GroupMessageSerializer.
Resolves: bug 9216
Change-Id: Icc5ad3f8b533a9f660e0248efed1b158c52336cf
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Use HashedWheelTimer instead of item scheduler
Use HashedWheelTimer instead of items scheduler for scheduling the SLAVE
role sending to device and move this logic to device context, where role
management is done.
See also: bug 9089
Change-Id: Ia180b3d7704bd2096bfa0bee88c2e87da333cfaa
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Merge "Solves issue with two connections from one device." into stable/carbon
Terminate SLAVE task before sending role change
- Terminate SLAVE task in device context when role change is requested and
not after role change is finished.
- Do not send notification about role failed to set to mastership
service in case future was cancelled
- Do not retry sending role to device 42 times
See also: bug 9089
Change-Id: Ia784d3b682b8991fe7a471bbfc7462aebfa6d4ef
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Fix transaction manager closing.
- the event onTransactionFailed we properly closing chain and creating
a new chain
- changed writeOnlyTransaction to readWriteTransaction
- moved transaction manager to the common module
- topology manager using transaction manager instead of creating a
transaction chain for itself
- added control of unfinished transaction on close
See also: Bug-9038
Change-Id: Idadbb4ed0f4c61e7f80da5e2dbedbd80dece118e
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Fix TransactionChainManager IllegalStateException
- Make txChainFactory volatile
- Close failed chain only if is current
See also: bug 9038
Change-Id: Ie897c5356addaef3f180a96296f5dd38950f2fb3
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
Solves issue with two connections from one device.
See also:Bug 8723
Change-Id: I1e07eb590f285f9d6c1326b94ef5b159242c0757
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Fix context state comparison
Fix comparison of context state and atomic reference of context state.
See also: bug 8668
Change-Id: Ie001d913982dc1331d1bb418e3fc8c7208e4c52d
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Bug 8882 - With conntrack SNAT communication with PNF fails
Added support for load metadata action.
Change-Id: Ia1b0454a4aeccd9a04cecb59b50f516264bddb3e
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Close CSS registration in separate thread
Instead of sending initialization of CSS in separate thread,
do closing of registration in separate thread and only in case
we are closing the registration during initialization, to prevent
CSS freezes. Also, when closing CSS service, add checks for connection
state to prevent closing context when connection is already RIP.
See also: bug 8805
Change-Id: I0759f7913937c897f41899a87b699989cdfe4abc
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Fix context chain initialization and SLAVE change
- Merge ContextChain and LifecycleService
- Let ClusterSingletonService handle stopping of mastership services in
closeServiceInstance method
- Store cluster singleton initialization future and process it
synchronously in case we are closing
- Cancel device initialization future if we got timeout
- Handle initialization chain order in ContextChain instead of storing
each next phase in contexts
- Remove SLAVE task from scheduler in case we acquired SLAVE role
already
- Prevent adding exactly same auxiliary connection twice to list of
auxiliary connections in ContextChain
- When SLAVE role is obtained from cluster singleton service, notify
MastershipChangeListener about it
- Log exceptions from handshake as warning instead of error (as only
problem is that device gets disconnected and reconnected, what is not
critical)
- In case context chain is still closing and we receive new connection,
drop the connection and let context chain finish closing
See also: bug 8805
Change-Id: If14da19899087018c5e6cc42d195af43c1e89bfd
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Merge "Fix match extensions deserialization" into stable/carbon
Merge "Improve flow collection" into stable/carbon
Fix match extensions deserialization
Fix transformation of match extensions for different match types during
deserialization so they will not be lost during this process.
Resolves: bug 8836
Change-Id: If089a72759a26b764479e58ea112b3a1a062c90e
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Bump versions by x.y.(z+1)
Change-Id: I0576e16aabc016896b51ec4538b453e66da709c9
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Improve flow collection
- Delete all known flows synchronously
- Add boolean isTransactionsEnabled to TxFacade to determine if it was
initialized and initial submit was called
- Improve deletion of flows during on the fly statistics gathering (now,
each gathering have 3 states, INITIALIZATION, WORKING and TERMINATION
and behaves according to that)
- Fix possibility of statistics collection freeze when error occurs
during OF Java to OF Plugin model translation while gathering
statistics on the fly
Resolves: bug 7501
Change-Id: I74843d4536215c192ac43964634502430da1aa9a
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Solves compilation error
- due openflow java changes plugin run in compilation errors
Resolves bug:8788
Change-Id: I41f964260c216fe3ee417c9d874cb58177f4596d
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Fix NPE in ConnectionContextImpl
- When we receive port status message, in some cases nodeId can be null,
so when logging, get nodeId safely and in case it is null, just log
"null"
- When we are closing outbound queue, log value of nodeId or null in
case nodeId is null
Resolves: bug 8762
Change-Id: Ifda277fd298f7d30fd5e94f07a94e67813971029
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Revert "Remove lifecycle service from tx chain manager"
This reverts commit
5bbffc61f90c85d6360a73c5eab35e203f6f20fd.
Change-Id: I793f7448803519e0dcdd8c5446e555fd8d6dfa15
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Remove lifecycle service from tx chain manager
Resolves: Bug8748
Change-Id: I6e9f1d7dbdfbdcca5cd52c368985ba7d37310a74
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Merge "Report (TCP) port number for switches" into stable/carbon
Fix context chain closing
- Close and create EOS registration correctly when closing context
chain holder and creating context chain holder.
- Cancel running scheduled task on context chain holder termination
- Always remove device from DS when we was not able to propagate roles,
not only when we have this device already in context chain map
- Add toleration for adding context chains to queue
- Wait for registration of RPC services before fully granting mastership
for context chain
- Close transaction chain manager on device context close
- Remove unnecessary auxiliary connection gathering in device context
(because this was moved to context chain)
- Fix closing of TxChain when DeviceContext is closed when activating tx
chain manager but not enabling submit transaction (do not try to submit
data)
- Unregister RPC registrations on RpcContext close
- Do not close ClusterSingletonServiceRegistration during
ClusterSingletonService initialization, to prevent freeze of
ClusterSingletonServiceGroup, send it to separate thread
- Prevent propagating of connection closed event twice (add checks for
RIP connection state)
- Fix ignored tests
- Remove getter for table statistics boolean from DeviceContext and just
send it to DeviceInitializer
- Close all RPC contexts when RPC manager is closed
- Do not reschedule statistics one more time when context chain is
closed
Resolves: bug 8668
Change-Id: Ifa8c492486c17a73eccd760fc610a435ef6a42ed
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Report (TCP) port number for switches
Write also port number to datastore for OpenFlow switches.
Resolves: bug 2188
Change-Id: I15054b55907b4f15b1567b21f5fa2d35ad416579
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Fix "stale" state after controller disconnected.
See also: Bug 8411
Change-Id: If5bf24f34a87ef0a7d5514b1c655a42508889724
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Ensure that statistics gathering is terminated
Store current statistics gathering future for cancellation instead of
settable future, so we can cancel it when we need to (there is no point
in cancelling settable future other than preventing more statistics
running, but current in-progress statistics gathering will still try
to finish).
Cancel statistics gathering also when become slave.
Resolves: bug 8635
Change-Id: If221a34901b08f8923ae5321a51abd00f4b047b1
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Merge "Fix connection when slave role request is unsupported" into stable/carbon
Fix connection when slave role request is unsupported
- Allow the switch connection when OFPRRFC_UNSUP is received
- Set feature exception for getGenerationIdFromDevice RPC error
- Add unit test
Resolves: bug 7664
Change-Id: If8d7d045fb516f55346333cc7e60d0ccb2135efd
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
Fix port update
- Update yang models. Add grouping common port with mask.
- Use config mask in the PortConvertor and PortMessageSerializer.
- Update unit tests.
Resolves: bug 4747
Change-Id: If558fea34f86c026ca45ba2853107c2cd82c7f50
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
(cherry picked from commit
8d18002e59e2b7e7fca95e52d2cb4a75d1023117)
Merge "Fix 'INPORT' keyword in port field" into stable/carbon
Merge "Fix onSwitchIdleEvent echo request-reply xid" into stable/carbon
Fix 'INPORT' keyword in port field
- also fix NPE in serialization by using wrong port number
Enumeration from opeflow java yang files is correct used keyword 'IN_PORT'.
Openflowplugin with the wrong translation (getString instead of getName) used the
keyword 'INPORT'. This fix use the correct name from enumeration but allow use
the legacy 'INPORT' keyword for next release.
Also prevent to throw NPE by using wrong keyword in port field.
Change-Id: If8b3d301d73169fd158a546a233928ab0c65d1c3
Fix: Bug 2095
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Merge "Bug 8253: Set-Field can not accept vendor extension fields." into stable/carbon
Fix onSwitchIdleEvent echo request-reply xid
Solves: Bug-4422
Change-Id: I879e9e6aaf560da486767a68a7e2f015db5a7d95
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Merge "Write port statistics when needed" into stable/carbon
BUG-8607: Replace logger and log by LOG
Replace logger and log by LOG to follow the
OpenDaylight recommendations [1].
[1]
https://wiki.opendaylight.org/view/BestPractices/Logging_Best_Practices
Change-Id: I77ef621927ba05417736d24c18c6659c7f504917
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>
Make create-parents in bulk-o-matic not required
To make bulk-o-matic input working like before, make create-parents
to default to true to use original functionality with same input
as it was before patch that introduced this new flag.
Change-Id: I89ee7d299f0ade62bd6859209c537528e5728aa7
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
(cherry picked from commit
d13de0fa783ab11e33a58417007be0d855be84ae)
Merge "Bug 8293: Add table writer to bulk-o-matic" into stable/carbon
Merge "Bug 8647: remove odl-dlux-core as artifact POM" into stable/carbon
Merge "HeaderDeserializer and HeaderSerializer for codecs" into stable/carbon
Merge "Close OpenFlowPluginProvider during shutdown" into stable/carbon
Bug 8647: remove odl-dlux-core as artifact POM
odl-dlux-core is used in dependency management as an artifact POM, but
it isn’t. Removing the declaration is fine since the actual dlux
dependencies specify the version to use.
Change-Id: I83598feb8175d674616a3a3f25c0d52ca1739664
Signed-off-by: Stephen Kitt <skitt@redhat.com>
BUG 7332: Cleanup queue after switch disconnect
In context of Helium Plugin, ingress queue in
ConnectionConductorImpl is not closed, which results in the memory
leak.
Change-Id: I3e69721114f887f8b71c22224a2a834d69a64a43
Signed-off-by: Vijay Daniel <vijay.daniel@ericsson.com>
Merge "Optimize port status and hello message handling" into stable/carbon
Close OpenFlowPluginProvider during shutdown
- Call close method on OpenFlowPluginProvider during shutdown
- Close all created managers, thread pool and timer during shutdown
- Remove unused notification service
- Remove warning when unknown property is loaded on start (because of
recent FRM changes)
Resolves: bug 8598
Change-Id: Ib5a4f84ea1fa0c957b90ef216346eb85aec81ad0
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Stop reschedule stat. after device disconnected
Resolves: Bug-7940
Change-Id: Ida42676ec5bf6f06fb47837c0532878976eed442
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
HeaderDeserializer and HeaderSerializer for codecs
Implement HeaderDeserializer and HeaderSerializer for nicira
match codecs.
Resolves: bug 4862
Change-Id: Ia3dbbf622460ecfa3b6a2c48e94e432294a08c0e
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Write port statistics when needed
When we receive port statistics reply, sometimes in OF 1.0 we do not
have parent node written to datastore, so now when OpenFlow version is
1.0 then write those port statistics with parents if needed.
Replace gathering missing port statuses with PORT_DESC with registry
that will collect missed port statuses when on MASTER.
Resolves: bug 8239, bug 6908
Change-Id: I47468cb37fa59a68cfa89efeb7e5c4191e07039d
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
(cherry picked from commit
acf2b5630ca4460bac2343bccc72f37da12f6e0d)
Add Nicira extension support for matching IPv6 Src/Dst
This patch implements the necessary support for programming a reg_move action
(i.e., move:NXM_NX_IPV6_SRC[]->NXM_NX_IPV6_DST[]) with IPv6 source/destination
headers. It will be used while constructing OVS flows that auto-respond to ping6
requests addressed to a router-interface.
Change-Id: I64757f55ed1d30a12217c4a5aadaa3f56572ab0e
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
(cherry picked from commit
7d00489cd0b6014b58b68fc84c533f6d33fc8dc1)
Fix auxiliary connections
See also: Bug-6755
Change-Id: If4964c1a0f07bfdd8104c7254f4b4484fd42d81e
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Optimize port status and hello message handling
- Reduce number of created threads and close used threads.
Change-Id: Ib37268be5e7982c64b95da9abffa6db78ef4edc1
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
Merge "Fix logging of exception in HandshakeListenerImpl" into stable/carbon
Merge "Fix no reserved xid" into stable/carbon
Merge "Bug 8497 - Provide config knob to disable the Forwarding Rule Manager reconciliation" into stable/carbon
Merge "Add missing convertors for OF1.0 actions" into stable/carbon
Bug 8497 - Provide config knob to disable the Forwarding Rule Manager reconciliation
Resolves: Bug 8497, Bug 7957
Change-Id: Ib798d9282f019e0c8dd520c15d8794678ee9af3d
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Merge "Remove unused method" into stable/carbon
Merge "Bug 8535: Fix IPv6 OXMHeader Mask issue" into stable/carbon
Merge "Though shall not use org.eclipse.tycho's osgi.. you don't even need it!" into stable/carbon
Merge "Adding Reason Attribute to FlowCapableNodeConnector" into stable/carbon
Add missing convertors for OF1.0 actions
- SetDlSrc
- SetDlDst
- SetNwSrc
- SetNwDst
- SetNwTos
- SetTpSrc
- SetTpDst
- SetVlanId
- SetVlanPcp
Resolves: bug 8527
Change-Id: I9c7c97804d077e1089fe92b3465c826a43da6a33
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Bug 8253: Set-Field can not accept vendor extension fields.
The various Set-Field actions are identified by their field type
which defined in OpenFlow Specification. It will be failed if we
pass a vendor extension field to Set-Field, that means Set-Field
can not accept those vendor extension fields. There are products
that hope Set-Field can accept those vendor extension fields, so
it will make sense to make Set-Field extensible.
Change-Id: Id25456d2b9008ec260ce81d3a459bdc471a69e49
Signed-off-by: Li guosheng <li.guosheng6@zte.com.cn>
(cherry picked from commit
4b3a659ef96aaca99c0fbd17ccdf9411c2e12da3)
Bug 8535: Fix IPv6 OXMHeader Mask issue
When programming an OVS flow to set an ipv6_src/dest as
an action field (i.e., set_field:2001::1->ipv6_src), the
current implementation is not checking the Mask and is
including the Mask (even for a full ipv6 address) in the
OXM header. Because of this, switch is rejecting the flow
with the following error.
"decode error: OFPBAC_BAD_SET_MASK. OXM header 0:32768:26:1:32
includes mask but masked OXMs are not allowed here"
This patch addresses this issue by checking the prefix and
including the prefix only if applicable.
Change-Id: Ieffdc7f0e74e9418156171d85a28c24dd336527c
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
(cherry picked from commit
85285353da4c397a9b4ad0e67ba137cddb0c4740)
Bump versions by x.y.(z+1)
Change-Id: Ifa2f0fe59824706e9bc78b3fab1b2830335b8bee
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Adding Reason Attribute to FlowCapableNodeConnector
-The reason attribute is added to the FlowCapableNodeConnector Yang
Modelling.
-The PortStatus contains reason when notification comes from Switch such
as ADD, UPDATE, DELETE.
-This reason flied will help in distinguishing between different
PortStatusMessages
-Also changed TestCase File to include Reason for test cases
Change-Id: If61fc1ba0afbe56cbf5382ab3997c67166989819
Signed-off-by: GauravBhagwani <gaurav.bhagwani@ericsson.com>
(cherry picked from commit
9af18614bfef2d765b61564096afe2c8a360bbb5)
Though shall not use org.eclipse.tycho's osgi.. you don't even need it!
see https://git.opendaylight.org/gerrit/#/c/51592/
see https://git.opendaylight.org/gerrit/#/c/51520/
There are 2 remaining use of org.eclipse.tycho in openflowplugin's
drop-test and test-provider, something related to console commands...
could we ask you if you would mind to change that to use
the Karaf Console API instead? Or delete those? ;)
I'll like to block use of dependency tycho in odlparent ASAP.
Change-Id: Ifccbd7f6ec463487e83aa546701cdffd1c7accb4
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Merge "Add timeout for device initialization" into stable/carbon
Fix logging of exception in HandshakeListenerImpl
Exception was not logged, so in case initial processing failed and
thrown exception, there was no exception actually shown in log. To
properly log exception, it needs to be either passed as second parameter
or inserted into message via logger string interpolation ({}).
Change-Id: Ic76f6d20588e34837994b50509603d994009b705
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Merge "Remove device without master from DS." into stable/carbon
Merge "Bug 8408 - Deserialization exception in logs when NAT flows are added." into stable/carbon
Add timeout for device initialization
Sometimes during device initialization, switch starts ignoring all
messages from plugin, and so we ended up with Future that waited
indefinitely for switch response until Karaf was restarted.
Add timeout that will prevent happening of above issue.
See also: bug 8401
Change-Id: I90c6c8b53f6a6e879b6d9f93c259a2cbf09f71d3
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Remove device without master from DS.
See also: Bug-6459
Change-Id: I6d27681b60a75df173a49742885c75c16d691b26
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Bug 8408 - Deserialization exception in logs when NAT flows are added.
The code is modified to fix the issues with multiple CT actions.
The logic skip padded bit is added during Deserialization
Change-Id: Ic5574f0a877228d966ca92eacfa22c751fa14b3c
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Fix queue and xid issue
Change-Id: Idef52a9243d9b2b9ac7028386422f0acc580c07d
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Fix no reserved xid
Change-Id: I153df3f1d3df895e2780a77dd6ed04e43bbc9599
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Remove unused method
Change-Id: I02e3d48f2ccca528995b18cb159700ab08449862
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Bug 8293: Add table writer to bulk-o-matic
* Table writer is introduced for Pre-Leader Role test in which
table is added first and flows next. We want the ability to
create tables separately and not to be created automatically
on addition of flows.
* Modify flow-test rpc to accomodate a boolean: create-parents.
This allows us to prevent addition of flows in case the tables
are missing.
* Fix import ordering
Change-Id: Ic3fe4764631d9cbc7550ad3d7d926debb3ca6977
Signed-off-by: Faiz Ilahi Kothari <faiz.ilahi.k.kothari@ericsson.com>
(cherry picked from commit
2f8d414a2b42bee7504c6fd78536bc6fd1049b83)
Handle missing converters for match extensions
Prevent throwing NullPointerException when converter for match
entry extension is missing, instead throw warning and allow process
to continue (like it was before single-layer-serialization).
See also: bug 8401
Change-Id: If006eef401da4b9bf61911c183e76876fac0dfcf
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Fix no match serialization
This patch ensures that even when match in flow is null, at least empty
match is sent to device.
Change-Id: If77c59b889e45698da4b96f098088cdbdf4698ee
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Prevent changing single-layer-serialization on fly
Prevent changing use-single-layer-serialization config
parameter on the fly, allow it only during initialization.
Resolves: bug 8278
Change-Id: Idfd2f7aa99fdf330bc32615431b4378209c83fda
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Improve property-based configuration
- Add OpenFlowPluginConfigurationService. This service can control
updating of OpenFlowPlugin configuration (skip-table-features etc.)
in initialization phase and also on the fly.
- Comment out default settings in org.opendaylight.openflowplugin.cfg
because with all default values set in that file, we are ignoring
values specified in openflow-provider-config.yang.
- Add support for missing configuration values from
openflow-provider-config.yang to OpenFlowPluginConfigurationService
- Remove changeable configuration values that was passed to some
OpenFlowPlugin class implementations to both constructors and setters
from constructors to prevent code duplicity and to simplify code a bit
Now, when feature is installed,
default values are taken from openflow-provider-config.yang, then we
check if we have org.opendaylight.openflowplugin.cfg file in karaf/etc/
(blueprint will do this for us) and try to read it as map. Then we will
pass this map to update method, that will iterate over this map and
parse it's keys and values and calls appropriate update methods in
OpenflowPluginProviderImpl based on key
(f.e skip-table-features will call
OpenflowPluginProviderImpl#updateSkipTableFeatures).
When org.opendaylight.openflowplugin.cfg file is changed, we receive
notification about it in form of
OpenFlowPluginConfigurationService#update method call, and we will
repeat same procedure as during initialization (parse map passed as
argument to this method and update configuration).
Resolves: bug 7218
Change-Id: Ida986f7dfffe55a90ddb6f354f0addf56c3c4b90
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
(cherry picked from commit
f1cc4de7dee9e22c231a90cf517b03bc5071ad35)
Ignore early port status msg and process it later
When port status message arrives before we got MASTER role,
ignore it. Then, after receiving mastership collect PORT_DESC statistics
again to make sure we do not missed any port status messages in process
Resolves: bug 6908
Change-Id: I01285ed4880533f48bf90fa7c6a4ca2c7d3a210f
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
(cherry picked from commit
426392ea39557e58c0cec51eae3bc91a0bebdf6f)
Merge "Bug 8223: Fixed incorrect enable-flow-removed-notification check." into stable/carbon
Bug 8223: Fixed incorrect enable-flow-removed-notification check.
flow-removed notification needs to be published if
DeviceManager.isFlowRemovedNotificationOn() returns true.
Change-Id: I10c025f11e14670303b70bf31d3a9cefa5a676ec
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
Bug 8217: Set error information into direct statistics RPC result.
Change-Id: I3fdf51b94bf95afefa47dddea37a82b8f139af95
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
Update .gitreview to stable/carbon
Change-Id: I7401c138c0ff82640a18f60e336ae62a3ca441de
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>