Release Nitrogen

Bump to odlparent 2.0.7

Change-Id: I1101b6ca1b013a9f7ecb1bf1fde0118b2c33ce70
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump to odlparent 2.0.6

Change-Id: I1ab320aa48c19dddbe7b4542b6805bd563ee54aa
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Use byte[].clone()

BGPDocumentedException can be made more efficient by using
byte[].clone() instead of Arrays.copyOf(). Also pre-cache empty
data and return it when needed.

Change-Id: Ib4e36522f0d3a734621349c1b62865496d330009
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use dedicated executor for BGPCEP Stats

BGPCEP-786
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Change-Id: I7c33b4938cf575350dee4e32aef02abca808bc05

Add Karaf build profile

Project local Karaf distros are handy for devs to test their work
however is unneeded by autorelease builds and should not be released
as part of the Simultanious Release. Add a profile that is active by
default so that default behaviour is unchanged however allows the
autorelease project to disable building this module.

Issue: RELENG-86
Change-Id: I6ad24975a9c54338e493438e5dfde211ec809697
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Remove obsolete Maven Site configuration

Change-Id: I0e2a856f537bd87c041e5346c55e1cdeb279939a
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

BGPCEP-740: Fix logic for MED comparison in BGP best path selection

New better path should be selected only if new MED is lower than
actual best path MED.

Change-Id: I8bd07dc8b42e575cebcc4e1ea4b55d9c2c842f42
Signed-off-by: Ajay Lele <ajayslele@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-732:  Pass IpAddress as BGP Peer identifier

a not give for true that it will be all the time Ipv4.

Change-Id: I5cb237f422fd4246d86e9e0c44e8dfda919a7af8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-770: Lock file before processing

In this way we ensure is not still been modified
when event is raised.

Change-Id: I69047f244e78bdf4536d6f2a83d3b80c45191e90
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit ac2ebcb16be3c1c17136cb479ba85f1c15dfa02f)

Fix model compliance

Declared prefix should be unique within a module, as that is
the prefix that is used to refer to a module within itself.

Change-Id: I699c529831fd62854a50e46c105a3d7922d670f1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

BGPCEP-774: Improver error message when missing AFI/SAFI

on peer configuration

Change-Id: I79568d87a0e8401fa71376e9a9c0b3b5389a8baf
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-764: Use full Ipv6 form under StrictBGPPeerRegistry

Ipv6 equal is not capable of handle short or full form
of Ipv6, returning false when comparing different versions.
Therefore use full form under registry.

Change-Id: I2127f20e847860792d0f1c18b0ae243825a9d86a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit 889700a070e725f44ee3d4fe215d93312ac8f0bf)

BGPCEP-763: Fix Pcep Deadlocked thread

improve synchronization

Change-Id: Ie10528d511b35911051a9aef149ae0c0c87116e0
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-760: Fix Dead lock

when connecting multiple peers at
the same time multiple routes are announced.
Fix by improve sync under Peer export groups.

Change-Id: I588db1bfc3cfca80308837084ac5088b8fc89cea
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bump versions by x.y.(z+1)

Change-Id: Ie31fe5f3e650f6bc628802d2d6c35d111ad084c3
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

BGPCEP-758: Use random ip for Pcc mock tests

-perform some clean up

Change-Id: I79ef9f8e5f01b1d461c5848d7966f9e3521f926d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-739: Fix  "raced with transaction PingPongTransaction"

under TopologyNodeState. Raced call to putTopologyNode
will cause an override node and therefore PathComputationClient
was being removed and ending on exception when trying to update
it after such change.

Change-Id: I1d5b44c383d7159669bec7475afff3713f1370a0
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Duplicate pax injection timeout

Change-Id: I927be80ac6db8ca1b76c4c0fc6ee1244ccdeb02a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-748: Fix AFI/SAFI

peer support registration when old-school BGP-4
is used.

Change-Id: I2137ea2647f01fb87bad04e682fe0bf5541768e8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-724 Make BGP Session recoverable

This patch make BGP Session recoverable when anything wrong
happens during netty session negotiation. When an exception
is captured, the BGP session will be terminated.

Change-Id: Id3fc7ec282a2151e3bd6bdbfa8930e141b3ceaff
Signed-off-by: Kevin Wang <kevixw@gmail.com>

Document path-id reserved value

Change-Id: I663ffac423e8a48c8528782165abc1406d70bb44
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-672: Fix key storage un adj-rib-out

list key must not be null, therefore
path-id should always be included.
Reserving PATH-ID 0 for non-supporting
add-path.

Change-Id: I9b0af92e91e7c0b1c7281230a804c7adeff2dbca
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-742 Fix BGP NPE filter null BGP State

from BGP State collector.

Change-Id: Ic23277b22466140c2e17c429eea7467fd9d33ce8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit b323c783131390fbc70f41db19271ddc1e16cbc5)

BGPCEP-737: Implement BMP client reconnection

after succesful connection goes down.
Remove duplicate code.

Change-Id: I8690de7d6a49c6c92e319c840a37a1fe043b9775
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-736: BMP Testtool retry connection

capability

Change-Id: I70169ff59c621e6a0c60b9b185bf9e2a2337b8b7
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Deprecate interfaces

to be removed under Oxigen

Change-Id: I313b837f90073f7cf8befb8fd3476c140c25aa6c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGP Migrate deprecated netty methods

Change-Id: I7bc2c5899f17fe974212da37dfea6c51461e502a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit eb45aa7c5df5e66665fef4ee324dbe863d39749e)

Move Pcep topology to Pcep Topology aggregator

Change-Id: I2c08acccfdb0f940ab7a1723223157d004762e6b
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Migrate deprecated netty methods

Change-Id: I8b4b28c2f7d9acdd2ebd436be48260d3505f04af
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-728: BMP Mock clustering

Fix clustering connection for bmp test tool
-enforce findbug

Change-Id: Icd0cb21467ab5c8fbea38a2561f0330cbdc5914d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit dd553db0255426051b8fd7f201a9895759c8bcba)

BUG-726: Move pcep topology tunnel to aggregator

- enforce findbug and checkstyle
- migrate checknotnull

Change-Id: Ib6b63744c2ac9d7c345c5d85cddc02a19ca3ea3f
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Improve CheckUtil testss

-enforce checkstyle
-enforce findbug

Change-Id: I9d3dd4dc6b6b6192d8015f0d9f11a4c7082e7297
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit 3fc26db07a4eadd2c6ed4d89b6beb42fce9cb568)

BGPCEP-711: BMP test tool clustering support

Make test tool able to connect to multiple nodes

Change-Id: Ic0011095140e7a31e598bc475f66713c85ed3038
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

move bmp to bmp aggregator

Change-Id: I78ac37a18987378ce066effbff0972ee9e04c8c9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix odlparent reference

The reference should point to 2.0.5, not 1.9.0.

Change-Id: I739d260b1509ce981b803a7a0b7e087a55f97159
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit c1b4aafd7b5fb5857452494e02fff85bb5a4b4e6)

BGPCEP-718: Hide InterruptedException

coming from closing thread, when closing module.
Avoiding confuse message.

Change-Id: Ifefc71a918dd9e1e6a4767e9b8077e521ab5d84a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-706: Fix BGP Flowspec NumbericOphrand

Right now when serializing a NumbericOphrand, the "end-of-list"
bit is not properly set. The last entry in the ophrand list
should have this bit set according to RFC [1]. Otherwise the packet
will be in malformed format.
This patch fix BGP flowspec NumbericOphrand to set the "end-of-list"
field properly. When the serialization happens, the end-of-list
field will be set in runtime.

[1] https://tools.ietf.org/html/rfc5575

Change-Id: Ib8841360b47137dc0ec0f54c3ef156a298ba3c81
Signed-off-by: Kevin Wang <kevixw@gmail.com>

Bump versions by x.y.(z+1)

Change-Id: I2c5a1d8356fa8148fcf56d2720cc849b39bfd4f6
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

BUG-9079 Make PCEP session recoverable from exception

This patch makes PCEP session recoverable from any netty exception.
Whenever an exception happens, PCEP session will be closed. So it
will be at a clean state when the next session retry comes.

Change-Id: I38a983c44519fd5c12cb9cd0da09fa14c4177ac7
Signed-off-by: Kevin Wang <kevixw@gmail.com>
(cherry picked from commit 004a235ef03cf72dd39e91a2085fa94fd5c1c80d)

BUG-9192 / BUG-9191

Enforce that each bundle under bgp is part of exactly one
feature by introducing new topology-api and concepts features.

Change-Id: Ifc6898b7154ba3451f1af7cfeba638c90c3c7a31
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit a41ee3138b4eaf27b2f806807ff50ed4258ed2e5)

BUG-9218: eliminate duplicate bundles

Packaging api bundles in multiple features causes inefficiency
in Karaf4. Introduce org-bgpcep-{bmp,rsvp,bgp-parser}-api
features to hold them.

Change-Id: I6351c945bbf3e272187dcd875854bff40c9b4f11
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit c0fcacdeb1a8049dd9493d64fb3d52bd39594b74)

Bug 9205: NPE received while receiving BGP peers

Change-Id: I05383a406b03e5dc460e5ae013da82280920981e
Signed-off-by: Ajay Lele <ajayslele@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8929: NPE during singleton startup

Avoid NPE when installing features 'odl-bgpcep-bgp-api' and
'odl-bgpcep-bgp-impl' individually

Change-Id: Id651dff7c813544bd07a03b435069de5e723721d
Signed-off-by: Yrineu Rodrigues <yrineu.rodrigues@serro.com>
(cherry picked from commit ab128ea6a1ee1fd19578326049bbfd8084a250c4)

Bug-8942: Fix DelegatedLspsCount

mbean value returns count of all LSPs and not just
the ones that are delegated

- Fixed code to return count of delegated LSPs only
- Added unit-test

Change-Id: I067b4cff8c7503fa878742ab6605fca2685a6c15
Signed-off-by: Ajay Lele <ajayl.bro@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8987: Print Exception when Css registration fails

Change-Id: I34236ac8546358fe3c00985fbbf40f69aa0bef19
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8156 : conflicting listener fix

In case another session listener is in conflict
with the existing one, close the new listener.

Change-Id: I1a594c3876eb1d28133dcc08b31f38deb5ceb27a
Signed-off-by: Dana Kutenicsova <dana.kutenics@gmail.com>
(cherry picked from commit e8c3219416917322b69c473b9498dfd60ccad352)

BUG-8156 : fixed start of session manager

Upon restart of session manager, its close flag was never
set to false, causing pcep sessions to be rejected as they
rely on this value.

Change-Id: I676ea5774cea4cbbee84222d2ad562bea70e83f3
Signed-off-by: Dana Kutenicsova <dana.kutenics@gmail.com>
(cherry picked from commit 32eccfc95a98c3cd75cbfabd64c4ab62a7b5d117)

Bump odlparent 2.0.4 to 2.0.5

Change-Id: I0764041e6638fb24bc73deba3d158c265669ed66
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit ca9b92125db7021992ce43116c9364d89c6d360a)

BUG-8156 : duplicate session up fixed

In case of session up twice, the second session gets
deleted from pcep and controller.

Change-Id: I192a13e29ccb69bb869a9ed344d6f504d80100af
Signed-off-by: Dana Kutenicsova <dana.kutenics@gmail.com>
Signed-off-by: Kevin Wang <kevixw@gmail.com>
(cherry picked from commit 7d9607f750a8037e4f1e57c0a6f545c27df68366)

Bump versions by x.y.(z+1)

Change-Id: I1419dfe685db8738b4fa4d95c43cb85426bb445f
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

BUG-9141: Fix Stateful07TopologySessionListener failing test

Some of the timers are rounding down, which is ending
on some statistics results in 0, when we have better
performance than expected.  Update the code to round up.

Use LongAdder instead of long for counters

Change-Id: I958f1c252ba94f8cd392979fe469555aee3f8d48
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8987: check for null keys

Keys can be passed down as null, hence we need to check for this
happening.

Change-Id: I67018107b0925244f32b0cde6d8b53605594d521
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bug 9046: Bring back data change counter feature

Tests which rely on data change counter do not work without this.

Change-Id: I0a82674c50887f7282cc6ed7a6a54573da73d637
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

Update .gitreview to stable/nitrogen

Change-Id: Ic2b3fe3765b9e57e5751fd77d6ca5f12176fdb44
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Bump odlparent 2.0.2 to 2.0.4

Change-Id: Ieee18f9e069a0d9eb6ca8cc9e12237654d958105
Signed-off-by: Stephen Kitt <skitt@redhat.com>

BUG-8335: Adjust instantiation

The hanging issue stems from the use of a blocking dispatch for DTCL,
which means we are calling into user code while holding listener
registration lock. This does not happen in production environment.

This patch adds an explicit test for this scenario and migrates
the hanging test to call properly initialize its base class.

Also cleans up warnings in the implementation, as it has not seen much
love lately.

Change-Id: I6c424acfad87244c7a23b013ea91da543ecf72a8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up

- Migrate Futures.addCallback
- Move test to shorter package

Change-Id: I7c5f8f9743cd7220414d68d043ca912261edec4d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Cleanup eclipse warnings

- static methods
- deprecated classes
- raw types
- unneded version declarations

Change-Id: Ibfe2f1f3203ebca416d8badd1f149d669ddc2415
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Enforce no split packages

This patch augments Export-Packages with a directive to fail build
if a split package is detected.

Change-Id: I52a2a157f992cb97fd8c6a88cf45c933ed0fd953
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

BUG-8722: fix regression introduced by BUG-5876

Change I707914f3ab0786c0ad8ba71a5476b3b7e322b0cd regressed
bgp-rib-impl packaging such that it massively over-included
classes, leading to split package.

This patch fixes that regression.

Change-Id: I6366972b88e3881675c3dd70517fc4e95c050261
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Re add features-bgpcep-extra to integration test

Change-Id: Ic61d66e420f5281dbde1a836b5adbc1ba78be777
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove deprecated CSS Topology provider configuration

replaced by openconfig configuration

Change-Id: I569f75217302e3867a2106065ca9936981a4a126
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6978: Integrate BMP collector with Cluster Singleton Service

Implement bmp HA by introducing CSS to BmpMonitoringStation

Change-Id: I657c367c33fc6b1946c3db19a71725a78917925a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bug 8675: Follow-up fix to new XML parser change in yangtools

Behaviour of the new XML parser in yangtools project needs
to be changed a bit so that RESTCONF/NETCONF projects can be
migrated to the new parser. However, these changes break some
parts of BGPCEP which have already been using it.

This patch provides a fix for the issue and should be merged
right after the following yangtools patch goes in:
https://git.opendaylight.org/gerrit/#/c/59036/

Change-Id: I23a5677e31b01fee7f67c8a5eb6b4081bd976f8b
Signed-off-by: Igor Foltin <igor.foltin@pantheon.tech>

Move tests to base package

Test FQCN is used by surefire to generate a report file, which has
limits on its length, causing problems with archival.

Move these tests to base model package to keep the file name short.

Change-Id: I90a49004c235590c87cb331e7cd31f693b3cd6d1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent to 2.0.2

Automated bump to latest release.

Change-Id: Ib8ecc4751f93c75f93262fa42d43566b0d6094d2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bug 8667 - PCEP: When peer closes got IO exception

When peer closes the pcep session, it results on IO
Exception.
it is due to this close is not recognized as local pcep
PCEP session termination.
It was first implemented as a local pcep session
termination.
https://git.opendaylight.org/gerrit/#/c/906/1/pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/PCEPSessionImpl.java
Solution: Use the reason encapsulated in the close message to close the session.

Change-Id: Ia423f5c10b117ef21af5a3bddc28652ebb659e26
Signed-off-by: matcauf <mcauffiez@inocybe.ca>

Remove missing dependency features-extras

This appears to have been removed via
I6db5b40c398fbe5e7cb4077d2c2a321a0286fab0

Change-Id: I161964a0ed1d7e52a8a5d6a7dd28f771de2b29b2
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

BUG-7027 : Remove Data change counter CSS configuration

since is not longer need it. New configuration is done via REST.

Change-Id: I32c3ffcfa66108d72dd8033e44b1cbd7596537eb
Signed-off-by: Dana Kutenicsova <dana.kutenics@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bump odlparent dependency to 2.0.1

Change-Id: Ic2c34fb71552aeb6365ce37374c73f0bb909e14a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bump odlparent dependency to 2.0.0

also rename karaf4 features

Change-Id: I4d9d9274d12e4bb098884d70827d7ed57e8d7b48
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove BGPCEP Karaf 3 features

Change-Id: I6db5b40c398fbe5e7cb4077d2c2a321a0286fab0
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove no longer required 31-bgp.xml for bgp feature

CSS configuration is not longer supported under nitrogen.
Therefore 31-bgp.xml is no longer required for bgp feature.

Change-Id: I43aa0a52d919a03e90133a2f908505941285773a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6976: Migrate BMP collector to use BP wiring

Migrate to BP wiring

Change-Id: I6d7d33029123039d27493b014ae459da1333a77c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

KeyMapping rework

Change-Id: I76a1a1c0353219d453963422b64cd7bcf86bb523
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6801: Remove deprecated bgpcep *-all features

Remove deprecated bgpcep *-all features

Change-Id: Ib87ea2d091e2eead955b8cf959a02f071365a7f9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove stale prerequisite sections

It is generally accepted that ODL requires maven 3.3.9+ in order to
compile correctly.  This cleans up a bunch of places that reference
older minimum versions to avoid confusion.  Instead, we should
recommend that all modules are compiled using the ODL global minimum
in order to promote a common toolset across the project.

Change-Id: I61591cfbd262e712bdd428e8b6697f7c0742dbde
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

Migrate bgpcep local karaf distribution to karaf4

This change migrates the local karaf distribution from karaf 3 to
karaf 4.

Change-Id: Iabf8a96ecec5e3473eae55e6a1ca8f70856bc60c
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

Reduce over-inclusion of base BGPCEP artifacts

We have some duplication across concepts/utils, use the extras
dependencies feature to bring those in for now.

Change-Id: I594a8a7d553ab17c992882eb117c7dc94a1a9ee3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

BUG-8292 Fix BGP flowspec NLRI length read

In BGP Flowspec, NLRI length is set per NLRI. The
current implementation only read NLRI once. So
BGP parser will throw exception when multiple
NLRIs are batched in one BGP UPDATE message.

Change-Id: I6630bca4c222e68f4609134192550d6c0a7ea3ba
Signed-off-by: Kevin Wang <kevixw@gmail.com>
(cherry picked from commit 51646d108fc36adef7cffd99657386fd6f5f96bd)

Remove dependency on blueprint

There is no need to declare this, as far as I can tell.

Change-Id: I58e8cb0cefff8d05ab00319eb3cb6c9db3a22fa6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate to odlparent 1.9.0

Change-Id: Ie210d3177329d2bd94f590f06ecbcb5ed9877863
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix sonar complains

- Remove unused imports
- Remove unused exception
- Extract try block
- dont use generic Exception
- Reduce the number of conditional operators

Change-Id: I0d51ef2aa6540d1d841f637308431ce768b1636b
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7027 : wired data-change-counter with Blueprint

Deprecate existing config modules,
add BP xml with custom config yang file.
No default configuration is set, to avoid
conflict modification when using on 3 node clustering.

Change-Id: I2b0408310605c9b96388585582d2e7a9f63007cb
Signed-off-by: Dana Kutenicsova <dana.kutenics@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Migrate to odlparent 1.8.0-Carbon

Per request of odlparent project we are downgrading all Nitrogen
projects to use the released odlparent 1.8.0-Carbon to allow for the
odlparent project to start performing semver style releases.

Jira: RELENG-159
RT: 41406
Change-Id: I3e41a57a11b63902be1bce25f3a6937609eb1f1f
Signed-off-by: matcauf <mcauffiez@inocybe.ca>
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Bug 8568 - Remove deprecated CSS module tests

Remove Test class that are using deprecated DataProviderService
for Classes
BGPApplicationPeerModule
BGPPeerModule
RIBImplModule
Ipv4ReachabilityTopologyBuilderModule
Ipv6ReachabilityTopologyBuilderModule are deprecated and
will be not tested

Classes AddPathImplModule and BGPTableTypeImplModule are not
deprecated and will be not tested.
Do they need to be deprecated ?

Change-Id: I9b9d3125b6f80ee70c86451f8a46cbd480bde6c2
Signed-off-by: matthieu <mcauffiez@inocybe.com>

Rework failing test testStateful07TopologySessionListener

Change-Id: Id48d30e15351217a9738de742dec2d2581480d29
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove deprecated methods

Change-Id: I8d38181081702c692a4d093761b95d5a2dddeca2
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Change deprecated SchemaService by DOMSchemaService

Change-Id: Iaa4adace5e15a1aeee2824cac81f8c72703a80fb
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Introduce dependecies version management

for handle version of ODL features in an
unique place.

Change-Id: Ifbf831a0fd387f548f58084c003ef6475f7b0a8d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8548: Pass missing parameter to

SimpleBGPExtensionProviderContext#registerNlriParser

Change-Id: I625f82d64efa0d2843b94de31c649572be9cacf9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Code Cleanup: unused var and imports

Remove unused logs, class member and
methods paramenters

Change-Id: I02640d49844d46726da8da9ae162507dc6c6e581
Signed-off-by: matcauf <mcauffiez@inocybe.ca>

Code cleanup: Duplicate Code

Remove duplicated code

Change-Id: I318e391e95bc892ebcf6af3081a455e84843c93a
Signed-off-by: matcauf <mcauffiez@inocybe.ca>

Remove unused LOG

Change-Id: I03d203e42e009ef737b07e05d56f2df5d650cded
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8156 Fix PCEP topology registration

It is possible that when a PCEP session is being dropped and being
unregistered from ServerSessionManager, the thread gets switched
thus the topology unregistering cannot finish.

If such situation happens, PCEP session from the same PCEP peer will
not be able to established until after DEADTIMER_EXPIRED, as the
topology instance was not removed correctly.

Change-Id: I647ecfbbb35ef6805d563753b7ebd87edfc350fe
Signed-off-by: Kevin Wang <kevixw@gmail.com>
(cherry picked from commit 2801f2b71ca49dcee50b643ef5ed4f53938609fc)

Fix RD pattern in RouteDistinguisherBuilder

Type 0 RD is 2+4 bytes.

Change-Id: I7ec0099cf5c1cdf8ab7d333dc26756c17228579b
Signed-off-by: Xiao Liang <shaw.leon@gmail.com>

migrate yangtools deprecated BindingNormalizedNodeSerializer

migrate yangtools deprecated BindingNormalizedNodeSerializer
to mdsal BindingNormalizedNodeSerializer

Change-Id: I32439a487a209a567b5436b204c11d979ac46cc8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8356: Rename features4-extras

Rename features4-extras which colides
with controller features4-extras, making
SingleFeatureTest for repos/index fail.

Change-Id: I04c693f853178e08a15eaa5435310659f66ee061
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8335: @Ignore InstructionDeployerImplTest

This test hangs fairly consistently in autorelease-carbon.

Change-Id: Idc6a207ff669f433096017494c24d99b8ec02c09
Signed-off-by: Colin Dixon <colin@colindixon.com>
(cherry picked from commit 5cca02bf6871cc9345baadcc282acfa76e0ff5de)