Michal Rehak [Fri, 23 Jan 2015 21:12:26 +0000 (22:12 +0100)]
BUG-2637: migrate features
- remove migrated features
- integration test fix:
- commented out dependencies to models affected by migration
- adapted sal-binding-it in order not to push those models
into pax-exam context
- adapted sal-binding-broker-impl to use those models only in
test scope
- cleaned commented code/config
Change-Id: I8e09a7cd9ff9ba0f041abe1bf739be755aed3e8d
Signed-off-by: Michal Rehak <[email protected]>
Tom Pantelis [Thu, 19 Feb 2015 20:57:45 +0000 (20:57 +0000)]
Merge "Bug 2538: Remove redundant Augmentation checks and tests"
Tony Tkacik [Thu, 19 Feb 2015 17:09:32 +0000 (17:09 +0000)]
Merge "Bug 2682 - Switch sal-binding-dom-it to sal-test-model"
Michal Rehak [Thu, 19 Feb 2015 12:39:06 +0000 (13:39 +0100)]
Bug 2682 - Switch sal-binding-dom-it to sal-test-model
* Migration to sal-test-model
Change-Id: If46014ec4cc8b3311a7766bcb2cb9a61b9e71592
Signed-off-by: Jan Hajnar <[email protected]>
Signed-off-by: Martin Bobak <[email protected]>
Signed-off-by: Michal Rehak <[email protected]>
Tony Tkacik [Thu, 19 Feb 2015 08:15:32 +0000 (08:15 +0000)]
Merge "Initial message bus implementation"
Robert Varga [Sat, 7 Feb 2015 21:55:46 +0000 (22:55 +0100)]
Initial message bus implementation
This patch follows up on the API definition and builds a simple
implementation.
Change-Id: Ic128538a02d71a40ea44efe53f3c4b4503c068ac
Signed-off-by: Robert Gallas <[email protected]>
Signed-off-by: Robert Varga <[email protected]>
Tony Tkacik [Wed, 18 Feb 2015 09:31:01 +0000 (09:31 +0000)]
Merge "BUG-2573: mark CompositeNode-based RPC APIs obsolete"
Robert Varga [Mon, 16 Feb 2015 08:46:53 +0000 (09:46 +0100)]
Migrate to MoreObjects.ToStringHelper
Objects.ToStringHelper has been deprecated and moved to MoreObjects.
Adjust to this change.
Change-Id: Ibcaaebfe8e2cbbd77e624a53fc153d857b373a81
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Mon, 2 Feb 2015 17:36:30 +0000 (18:36 +0100)]
BUG-2573: mark CompositeNode-based RPC APIs obsolete
With the advent of the NormalizedNode-based APIs, the users should be
moving towards implementation of those.
This is a placeholder, to be merged once a reference implementation is
available.
Change-Id: I7e321861d5100554dfde30c31ed47e585573be0a
Signed-off-by: Robert Varga <[email protected]>
Tony Tkacik [Fri, 13 Feb 2015 09:30:12 +0000 (09:30 +0000)]
Merge "BUG-2573: create DOMRpcRouter"
Tony Tkacik [Fri, 13 Feb 2015 09:16:37 +0000 (09:16 +0000)]
Merge "BUG-2573: add NormalizedNode-based RPC API"
Tony Tkacik [Thu, 12 Feb 2015 17:14:31 +0000 (17:14 +0000)]
Merge "BUG-2673: Introduced new more low-level DOM Data Change APIs"
Tony Tkacik [Thu, 12 Feb 2015 16:53:24 +0000 (16:53 +0000)]
Merge "BUG-1511 - Datastore: cleanup ListenerTreeAPI"
Robert Varga [Thu, 21 Aug 2014 12:54:37 +0000 (14:54 +0200)]
BUG-1511 - Datastore: cleanup ListenerTreeAPI
- split ListenerTree two static inner classes to ListenerWalker and ListenerNode
- fix refences [ResolvedDataChangeState]
- improve performance of ListenerWalker.close()
Change-Id: Ide82bc6caeaca1aa5c9080f134d570cf7a1571d6
Signed-off-by: Vaclav Demcak <[email protected]>
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Tue, 27 Jan 2015 14:05:38 +0000 (15:05 +0100)]
BUG-2673: Introduced new more low-level DOM Data Change APIs
As it turned out abstraction provided by Helium Data Change
API was CPU costly and calculated lot of unnecessary data,
and did not provide necessary navigation for some use-cases.
This new API contract defines more low-level data change
APIs, where application is more in control, how it will
process / consume / decompose Data Change by providing
DataTreeCandidate.
Change-Id: I468c9583c7999bc02101a18a8adf5dc1a084f1d9
Signed-off-by: Tony Tkacik <[email protected]>
Signed-off-by: Robert Varga <[email protected]>
Kiran Sreenivasa [Mon, 26 Jan 2015 22:08:36 +0000 (14:08 -0800)]
Bug 2538: Remove redundant Augmentation checks and tests
Change-Id: Ifa19661df9d3ba9cc8b93e0203bb760b792d8689
Signed-off-by: Kiran Sreenivasa <[email protected]>
Tony Tkacik [Tue, 10 Feb 2015 21:06:08 +0000 (21:06 +0000)]
Merge "Fix missing log argument"
Tony Tkacik [Tue, 10 Feb 2015 21:01:02 +0000 (21:01 +0000)]
Merge "BUG-2288: implement DOMNotificationRouter"
Robert Varga [Thu, 5 Feb 2015 19:11:09 +0000 (20:11 +0100)]
BUG-2573: create DOMRpcRouter
This patch provides a default implementation of DOMRpc(Provider)Service.
The implementation is geared heavily towards steady state, e.g. so that
invocations are fast.
Change-Id: Icb50ae097aebb5e798177625e04ed9befc7337d4
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Mon, 2 Feb 2015 13:46:16 +0000 (14:46 +0100)]
BUG-2573: add NormalizedNode-based RPC API
This API introduces a NormalizedNode-based API for invoking RPCs,
supplanting the CompositeNodes-based one.
Change-Id: I256f83e80fc4a7d169bbfb60c5738ca489d16aeb
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Tue, 9 Dec 2014 14:09:59 +0000 (15:09 +0100)]
BUG-2288: implement DOMNotificationRouter
Implements DOMNotification(Publish)Service using LMAX Disruptor. The
disruptor is used internallly to transfer requests from publishers to
two-stage notification dispatch, where the frist stage takes care of
delivering events to subscribers and the second stage notifies the
futures.
Change-Id: I654d9d044e80b2a2ff6fd5b05ddceed4e79a4ebc
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Sat, 7 Feb 2015 20:17:06 +0000 (21:17 +0100)]
Fix missing log argument
Logging format indicates an argument, but it is missing in the method
arguments.
Change-Id: I961088d5534370227e741ee0b1ff9651fbcd3335
Signed-off-by: Robert Varga <[email protected]>
Michal Rehak [Thu, 5 Feb 2015 11:31:15 +0000 (12:31 +0100)]
BUG-2681: switch sal-binding-it to sal test models
- switched to test models:
- DataServiceTest
- RoutedServiceTest (unregister path verification failing)
- Notification Test
Change-Id: I381fd9ad9682f9527bdf8276fae6eb508f0807f7
Signed-off-by: Michal Rehak <[email protected]>
Tony Tkacik [Thu, 5 Feb 2015 09:57:50 +0000 (09:57 +0000)]
Merge "BUG-2288: remove DOMNotificationListenerRegistration"
Tony Tkacik [Thu, 5 Feb 2015 09:54:45 +0000 (09:54 +0000)]
Merge "Make sure write transaction cancellation is propagated"
Robert Varga [Wed, 4 Feb 2015 14:18:37 +0000 (15:18 +0100)]
BUG-2288: remove DOMNotificationListenerRegistration
This type is just a capture, and it fails to forward the type of the
listener properly for users. Remove it and be more consistent with the
design of other classes.
Change-Id: Ib8c3db54fc599d6ca194d1667e1a48a98e455180
Signed-off-by: Robert Varga <[email protected]>
Ed Warnicke [Tue, 3 Feb 2015 22:18:21 +0000 (15:18 -0700)]
Add features-restconf to mdsal-artifacts
Change-Id: I1919153b372d2b7323fb1179ad04f9d3a491b29f
Signed-off-by: Ed Warnicke <[email protected]>
Robert Varga [Tue, 27 Jan 2015 17:15:20 +0000 (18:15 +0100)]
Make sure write transaction cancellation is propagated
DOMForwardedWriteTransaction needs to notify subtransactions about
cancellation, as otherwise they will remain logically open and
potentially lost.
Change-Id: I15d926979fe181c60de65f44102b75513fd22dfc
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Tue, 27 Jan 2015 11:00:37 +0000 (12:00 +0100)]
Migrate AbstractRuntimeCodeGenerator to new ClassLoaderUtils
Change the import so we use the non-deprecated version. Also fix
exception string formatting.
Change-Id: Ibf710c8b59d633609c5f557604882034b63f4505
Signed-off-by: Robert Varga <[email protected]>
Tony Tkacik [Mon, 26 Jan 2015 08:51:18 +0000 (08:51 +0000)]
Merge changes I880310f2,I9f437328,I552372db,I587fb203,I05f0bd94, ...
* changes:
Do not leak AtomicLong from FollowerLogInformation
Remove followers as an explicit field
Hide AbstractLeader maps
Hide internals of FollowerLogInformationImpl
Speedup AbstractLeader.printFollowerStates()
Improve RpcInvocationStrategy performance
Robert Varga [Fri, 23 Jan 2015 08:02:29 +0000 (09:02 +0100)]
Improve RpcInvocationStrategy performance
As it turns out, the transformation function can easily be shared,
reducing the amount of objects we create.
Change-Id: I76c86e2f0c63e87c87677ac739f980a5e7929d3f
Signed-off-by: Robert Varga <[email protected]>
Tony Tkacik [Thu, 15 Jan 2015 15:49:44 +0000 (15:49 +0000)]
Merge "Bug 2358: Removed unused Hydrogen Data Store leftovers"
Robert Varga [Sat, 8 Nov 2014 10:48:47 +0000 (11:48 +0100)]
BUG-2288: binding Notification API
This is the definition of the new interfaces required to expose the new
DOM notification API to the users. It uses only the typed actor pattern,
reducing overall confusion to end users.
Change-Id: I12f14c1fa931511aa7b73d3b0491f848d6c08ba7
Signed-off-by: Robert Varga <[email protected]>
Tony Tkacik [Thu, 15 Jan 2015 11:31:57 +0000 (12:31 +0100)]
Bug 2358: Removed unused Hydrogen Data Store leftovers
Removed unused legacy code, which just increases complexity of code,
is not used and will be not used, since better solution exists
and was in place in Helium.
Change-Id: Ie58033d34ef3fcc7419db9ed9bce548b32fa24fd
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Thu, 15 Jan 2015 10:12:10 +0000 (10:12 +0000)]
Merge "Fix a race PingPongTransactionChain"
Ed Warnicke [Mon, 12 Jan 2015 01:02:35 +0000 (19:02 -0600)]
Removed deprecated methods from BindingAwareProvider
Also deprecated
BindingAwareBroker.registerConsumer(BindingAwareConsumer,BundleContext)
in favor of the newly added:
BindingAwareBroker.registerConsumer(BindingAwareConsumer)
and
BindingAwareBroker.registerProvider(BindingAwareProvider,BundleContext)
in favor of the newly added:
BindingAwareBroker.registerProvider(BindingAwareProvider)
Change-Id: Id256c81a7210640b9a493a3f0fc71a9e0379e317
Signed-off-by: Ed Warnicke <[email protected]>
Robert Varga [Mon, 12 Jan 2015 15:52:00 +0000 (16:52 +0100)]
Fix a race PingPongTransactionChain
As it turns out, we have made an illegal shortcut while readying a transaction. This results in the following exception,
which occurs if we happen to want to allocate a transaction while it is being submitted to backed.
Exception in thread "Thread-18" java.lang.IllegalStateException: Previous transaction DOM-OPER-9 is not ready yet
at com.google.common.base.Preconditions.checkState(Preconditions.java:176)
at org.opendaylight.controller.md.sal.dom.store.impl.DOMStoreTransactionChainImpl$Allocated.getSnapshot(DOMStoreTransactionChainImpl.java:68)
at org.opendaylight.controller.md.sal.dom.store.impl.DOMStoreTransactionChainImpl.getSnapshot(DOMStoreTransactionChainImpl.java:111)
at org.opendaylight.controller.md.sal.dom.store.impl.DOMStoreTransactionChainImpl.newReadWriteTransaction(DOMStoreTransactionChainImpl.java:131)
at org.opendaylight.controller.md.sal.dom.broker.impl.AbstractDOMForwardedTransactionFactory.newReadWriteTransaction(AbstractDOMForwardedTransactionFactory.java:206)
at org.opendaylight.controller.md.sal.dom.broker.impl.PingPongTransactionChain.slowAllocateTransaction(PingPongTransactionChain.java:128)
at org.opendaylight.controller.md.sal.dom.broker.impl.PingPongTransactionChain.allocateTransaction(PingPongTransactionChain.java:145)
at org.opendaylight.controller.md.sal.dom.broker.impl.PingPongTransactionChain.newReadWriteTransaction(PingPongTransactionChain.java:279)
at org.opendaylight.controller.md.sal.dom.broker.impl.PingPongTransactionChain.newWriteOnlyTransaction(PingPongTransactionChain.java:310)
at org.opendaylight.controller.md.sal.binding.impl.BindingTranslatedTransactionChain.newWriteOnlyTransaction(BindingTranslatedTransactionChain.java:77)
at org.opendaylight.protocol.bgp.rib.impl.RIBImpl$1.run(RIBImpl.java:125)
at java.lang.Thread.run(Thread.java:745)
Change-Id: Ie21cf5f0ebba79fa25358da2ee1e6b22cfb0f906
Signed-off-by: Robert Varga <[email protected]>
Tony Tkacik [Thu, 8 Jan 2015 13:23:40 +0000 (13:23 +0000)]
Merge "Optimize inflight transitions"
Tony Tkacik [Thu, 8 Jan 2015 13:23:33 +0000 (13:23 +0000)]
Merge "Remove lock out of the congested/reuse case"
Robert Varga [Mon, 24 Nov 2014 23:49:51 +0000 (00:49 +0100)]
Optimize inflight transitions
Change-Id: Iaab4941ab777eaef1068523fc055391d31ca3072
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Mon, 24 Nov 2014 23:04:34 +0000 (00:04 +0100)]
Remove lock out of the congested/reuse case
Reusing a transaction is a simple state transition inside the chain,
which helps the system throughput, since more changes will be packed in
a single transaction.
This patch optimizes this reuse as a fast path which is performed
without taking the lock on the assumption that this will allow better
code movement.
Change-Id: Idd8ba65c0d45c7ceea42d50ea3a6a521e0123733
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Wed, 7 Jan 2015 10:40:40 +0000 (11:40 +0100)]
Do not pull in xtend-lib-osgi
There is no need for the xtend bundle, as yangtools does not rely on
xtend being on classpath anymore. Also eradicate references to xtend
annotation and utility classes.
Change-Id: Iba61200f1af88b4bfd4165d38284d7ddbcac70b5
Signed-off-by: Robert Varga <[email protected]>
Tony Tkacik [Wed, 7 Jan 2015 10:35:40 +0000 (10:35 +0000)]
Merge "Model dom-broker statistics"
Tony Tkacik [Wed, 7 Jan 2015 10:35:26 +0000 (10:35 +0000)]
Merge "Move ConcurrentDOMDataBroker to clustered-datastore"
Robert Varga [Tue, 25 Nov 2014 11:39:53 +0000 (12:39 +0100)]
Model dom-broker statistics
This adds a model of statistics, reusing proper types where possible.
Change-Id: Iae5004df1eee6b2989cab5894173a38ccc96f1bc
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Mon, 24 Nov 2014 16:15:11 +0000 (17:15 +0100)]
Move ConcurrentDOMDataBroker to clustered-datastore
The concurrent data broker is only useful for the distributed datastore,
so move it along with the configuration binding there. Fixes the
potential for users to misconfigure their datastore.
Change-Id: I145c42ac64427db43889872abe06dd84bf751484
Signed-off-by: Robert Varga <[email protected]>
Tony Tkacik [Fri, 19 Dec 2014 15:44:44 +0000 (15:44 +0000)]
Merge "BUG-1382: do not instantiate prefixed QNames"
Robert Varga [Tue, 16 Dec 2014 12:41:26 +0000 (13:41 +0100)]
BUG-1382: do not instantiate prefixed QNames
Prefix-aware QName constructor is going away, do not use it. Also fix
all references to QName.getPrefix().
Change-Id: Ife6567a269c2db16019ae97a6eace74a19ac3b23
Signed-off-by: Robert Varga <[email protected]>
Tony Tkacik [Thu, 18 Dec 2014 14:13:12 +0000 (14:13 +0000)]
Merge "BUG-2288: DOMNotification API"
Tony Tkacik [Mon, 15 Dec 2014 15:07:09 +0000 (15:07 +0000)]
Merge "Remove throws declaration of a runtime exception"
Tony Tkacik [Mon, 15 Dec 2014 11:42:32 +0000 (11:42 +0000)]
Merge "Shorten org.opendaylight.controller.sal.core.api.Broker.RoutedRpcRegistration"
Tony Tkacik [Mon, 15 Dec 2014 11:37:34 +0000 (11:37 +0000)]
Merge "Registry instance cannot be null in RpcProxyRegistration"
Tony Tkacik [Mon, 15 Dec 2014 11:37:25 +0000 (11:37 +0000)]
Merge "Do not instantiate FluentIterable"
Robert Varga [Sun, 14 Dec 2014 18:18:40 +0000 (19:18 +0100)]
Remove throws declaration of a runtime exception
IllegalStateException is a RuntimeException -- hence we do not need to
declare it.
Change-Id: I681eff319b299beecf7710c44f154c1bb1b5174a
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Sun, 14 Dec 2014 17:38:56 +0000 (18:38 +0100)]
Shorten org.opendaylight.controller.sal.core.api.Broker.RoutedRpcRegistration
We can safely import the class, shortening references to it.
Change-Id: I41d5ca29f1dd4daff726d3598c1bf14732318752
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Sun, 14 Dec 2014 17:21:25 +0000 (18:21 +0100)]
Registry instance cannot be null in RpcProxyRegistration
removeRegistration() is guaranteed to be invoked at most once, and
registry cannot be null. Make it final and remove the safety check.
Change-Id: Ie8f2da7430c076d0bec71eb8b58a4adc2af25adf
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Sun, 14 Dec 2014 17:16:50 +0000 (18:16 +0100)]
Do not instantiate FluentIterable
We are performing an immediate transformation of the iterrable.
Instead of that we can immediately use Collections2.transform(), saving
an object.
Change-Id: Ie943a0a79e04713427bf6470e06d921412ebb179
Signed-off-by: Robert Varga <[email protected]>
Tony Tkacik [Mon, 15 Dec 2014 07:57:53 +0000 (07:57 +0000)]
Merge topic 'stable/helium'
* changes:
Shorten YangInstanceIdentifier references
BUG-2510: handle RPC route removal
Tony Tkacik [Mon, 15 Dec 2014 07:56:57 +0000 (07:56 +0000)]
Merge "BUG-2510: Remove all registrations when a routed rpc is closed"
Tony Tkacik [Mon, 15 Dec 2014 07:51:25 +0000 (07:51 +0000)]
Merge "Mark DomBrokerImplModule.createLegacyDataService() as deprecated"
Tony Tkacik [Mon, 15 Dec 2014 07:51:15 +0000 (07:51 +0000)]
Merge "BUG-2500: add current tree state to traces"
Robert Varga [Sun, 14 Dec 2014 17:13:10 +0000 (18:13 +0100)]
Shorten YangInstanceIdentifier references
We no longer have InstanceIdentifier name clash, so we can safely import
YangInstanceIdentifier and use it that way.
Change-Id: I48d13f9e6ecd17c1de40b5a017962cfc792810ad
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Sun, 14 Dec 2014 18:32:13 +0000 (19:32 +0100)]
BUG-2510: handle RPC route removal
DOM to Binding forwarding ignored removals of RPC implementations. Add
that case back.
Change-Id: I7af1d8b43b9b229cc9a696cfdfc61146f960b374
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Sun, 14 Dec 2014 18:20:00 +0000 (19:20 +0100)]
BUG-2510: Remove all registrations when a routed rpc is closed
The API contract specifies that the effects of a Registration are
removed on close(). Unfortunately the routed RPC case is more funny, as
it has sub-registrations, for each added path -- and we have no mention
of the fact that the user should be removing them.
Hence we need to handle the user expecting us to remove any and all
paths which have been registered.
Change-Id: Iedf451c2a481d648173819f895cccb9e63c54d99
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Mon, 24 Nov 2014 16:40:49 +0000 (17:40 +0100)]
Mark DomBrokerImplModule.createLegacyDataService() as deprecated
This marks the method deprecated, as we want to get rid of it. Fixes a
few warnings.
Change-Id: If4e613c07e9cd2b9b737fd697cbcd5709499c4d6
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Thu, 11 Dec 2014 12:10:10 +0000 (13:10 +0100)]
BUG-2500: add current tree state to traces
When a data validation exception occurs, also add the current tree state
to trace output.
Change-Id: I637973458519d4ed25fa3203fa79b72faf9a9e8b
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Fri, 12 Dec 2014 11:07:45 +0000 (12:07 +0100)]
BUG-2506: split out maven binding
Maven integration needs to be split out of the runtime implementation,
simply because we do not want to pull the requisite runtime into our
containers. It would never be used there anyway.
Change-Id: Ided36e3b06316739a3829d758889ba523e7e19ad
Signed-off-by: Robert Varga <[email protected]>
Tony Tkacik [Wed, 10 Dec 2014 15:35:38 +0000 (15:35 +0000)]
Merge "BUG-2470: add trace of failed modification"
Tony Tkacik [Wed, 10 Dec 2014 09:11:31 +0000 (09:11 +0000)]
Merge topic 'checkstyle'
* changes:
Fix checkstyle if-statements must use braces liblldp
Fix checkstyle if-statements must use braces hosttracker
Fix checkstyle if-statements must use braces bundlescanner
Fix checkstyle if-statements must use braces ClusterManager
Fix checkstyle if-statements must use braces HostTrackerCallable
Fix checkstyle if-statements must use braces ConnectionManagerNorthbound
Fix checkstyle if-statements must use braces HostTrackerNorthbound
Fix checkstyle if-statements must use braces BridgeDomainNorthbound
Fix checkstyle if-statements must use braces adsal/northbound/staticrouting
Fix checkstyle if-statements must use braces adsal/northbound/statistics
Fix checkstyle if-statements must use braces adsal/protocol_plugins
Fix checkstyle if-statements must use braces adsal/sal/connection
Fix checkstyle if-statements must use braces adsal/samples/loadbalancer
Fix checkstyle if-statements must use braces adsal/usermanager
Fix checkstyle if-statements must use braces config-persister-file-xml-adapter
Fix checkstyle if-statements must use braces logback-config
Fix checkstyle if-statements must use braces yang-jmx-generator-plugin
Fix checkstyle if-statements must use braces yang-jmx-generator
Fix checkstyle if-statements must use braces sal-common-impl
Fix checkstyle if-statements must use braces sal-common-util
Fix checkstyle if-statements must use braces sal-dom-xsql
Fix checkstyle if-statements must use braces sal-netconf-connector
Fix checkstyle if-statements must use braces sal-rest-docgen
Fix checkstyle if-statements must use braces md/statistics
Fix checkstyle if-statements must use braces netconf
Thanh Ha [Tue, 9 Dec 2014 22:42:25 +0000 (17:42 -0500)]
Fix checkstyle if-statements must use braces sal-common-impl
Change-Id: Ib2d0a8bcf4cef4a589a8c23181433dd14ea84657
Signed-off-by: Thanh Ha <[email protected]>
Thanh Ha [Tue, 9 Dec 2014 22:41:24 +0000 (17:41 -0500)]
Fix checkstyle if-statements must use braces sal-common-util
Change-Id: I518b9fa156af55c080d7e6a55067deab2c789a42
Signed-off-by: Thanh Ha <[email protected]>
Robert Varga [Tue, 9 Dec 2014 17:01:10 +0000 (18:01 +0100)]
BUG-2470: add trace of failed modification
With this change, the InMemoryDOMDataStore trace logs should contain the
dump of failed modifications.
Change-Id: Iea3038169090a574030c5e03cf155089faa6e985
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Wed, 17 Sep 2014 19:17:43 +0000 (21:17 +0200)]
BUG-2288: DOMNotification API
This API definition tries to fix the missing pieces in the
CompositeNode-centered APIs, such as inability to drop a notification
rather than waiting for resources needed to publish it to become
available.
Also adds missing documentation to the DOMService concept, which is used
by the two services being defined.
Change-Id: I93d22cf6121a7cf231b2da424e94d14b59fb883f
Signed-off-by: Robert Varga <[email protected]>
Tony Tkacik [Wed, 3 Dec 2014 10:28:00 +0000 (10:28 +0000)]
Merge "Refactor DOMDataBrokerImpl"
Tony Tkacik [Wed, 3 Dec 2014 10:27:44 +0000 (10:27 +0000)]
Merge "Add MD-SAL artifacts"
Tony Tkacik [Wed, 3 Dec 2014 10:26:32 +0000 (10:26 +0000)]
Merge "Remove use of xtend"
Robert Varga [Mon, 24 Nov 2014 14:15:42 +0000 (15:15 +0100)]
Refactor DOMDataBrokerImpl
This patch shuffles the abstractions, eliminating two intermediate
interfaces and ensuring proper layring is maintained with
AbstractDataBroker serving as a base for the Concurrent and Serialized
versions.
Change-Id: If363aa796db0c2ebf22fdefe7659dd428745dc75
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Thu, 27 Nov 2014 23:49:18 +0000 (00:49 +0100)]
Remove use of xtend
This patch converts RuntimeCodeGenerator into pure Java, optimizing it
in the process a bit. Since this is the last piece of Xtend code in
controller, also remove any trace of xtend.
Change-Id: I462968202d0e26c852aa683905b97bab8c5f99cf
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Mon, 1 Dec 2014 14:49:03 +0000 (15:49 +0100)]
Add MD-SAL artifacts
This migrates the version declarations into mdsal-artifacts artifact,
such that they can be imported by downstream projects. This will be
shuffled again as we define the scope more.
Change-Id: Ie97584dd477b786e3fc4f6d79a174425c020fa0c
Signed-off-by: Robert Varga <[email protected]>
Tony Tkacik [Mon, 1 Dec 2014 08:28:37 +0000 (08:28 +0000)]
Merge "BUG-2259: mark AbstractBindingAware* as deprecated"
Robert Varga [Thu, 20 Nov 2014 11:15:03 +0000 (12:15 +0100)]
BUG-2259: mark AbstractBindingAware* as deprecated
These classes encapsulate OSGi-activated clients, which are deprecated
in favor of using config subsystem activation.
Change-Id: I9632c6608be67e5763117a9bbb6e9c2519eb27b0
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Thu, 6 Nov 2014 19:13:59 +0000 (20:13 +0100)]
BUG-2255: introduce PingPongDataBroker
This is a forwarding DOMDataBroker implementation, which ensures that
there is at most one transaction pending for a particular transaction
chain. This is not useful in all scenarios, but if the users can
restrain themselves to use the supported semantics, they can use it.
Change-Id: I4a9ca12254763829f99e270d6716cd034b4b5ea9
Signed-off-by: Robert Varga <[email protected]>
Signed-off-by: Dana Kutenicsova <[email protected]>
Tony Tkacik [Tue, 25 Nov 2014 08:53:14 +0000 (08:53 +0000)]
Merge changes If7159c39,I6c84b2fe
* changes:
Deprecate ForwardedBackwardsCompatibleDataBroker
Migrate from using the deprecated SchemaContextProvider
Tony Tkacik [Tue, 25 Nov 2014 08:51:54 +0000 (08:51 +0000)]
Merge "Migrate FRM/SM to use model API SchemaContextProvider"
Robert Varga [Fri, 21 Nov 2014 16:55:30 +0000 (17:55 +0100)]
Deprecate ForwardedBackwardsCompatibleDataBroker
It implements a deprecated API only, so rather than suppressing the
deprecation warnings, deprecate the entire class.
Change-Id: If7159c3960b3ca2707bb4b9c716e95ed38ddb394
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Fri, 21 Nov 2014 17:08:51 +0000 (18:08 +0100)]
Migrate from using the deprecated SchemaContextProvider
org.opendaylight.controller.sal.dom.broker.SchemaContextProvider has
been deprecated, the services away so it is no longer used.
Change-Id: I6c84b2fe6ce02dce71aed4e4c24f8bc84ba078d8
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Fri, 21 Nov 2014 16:53:07 +0000 (17:53 +0100)]
Migrate FRM/SM to use model API SchemaContextProvider
Simple migration, eliminates the need for deprecation suppression.
Change-Id: Ic6d14c15dd1909d89c9b76bef20c36cdbde23187
Signed-off-by: Robert Varga <[email protected]>
Tony Tkacik [Fri, 21 Nov 2014 15:45:34 +0000 (15:45 +0000)]
Merge "BUG-8: mark deprecated classes as such"
Tony Tkacik [Thu, 20 Nov 2014 16:49:47 +0000 (17:49 +0100)]
Bug 865: Changed Config subsystem module for ForwardedBindingDataBroker.
Implementation of new Bidning Data Broker was wired to deprecated APIs
and used broker to discover dependencies which did not allowed for
full-fledged customized wiring. Reworked configuration to explicitly
allow injection of each required depenency and to not use
deprecated APIs for dependency injection.
Change-Id: Iccbb20ee4bb1df380f5fc4a3a1bbc5748dcc5a38
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Fri, 21 Nov 2014 11:58:21 +0000 (11:58 +0000)]
Merge "BUG-650: Split out CommitCoordinationTask"
Robert Varga [Thu, 2 Oct 2014 00:07:35 +0000 (02:07 +0200)]
BUG-650: Split out CommitCoordinationTask
The coordination task takes most of the coordinator implementation. We
do not want to expose it, but at the same time we want to evolve task.
Split it out and eliminate the unneeded atomic state updates, as it is
only ever touched by a single thread.
Change-Id: I49b494d23a8b8f9cdf6cb3dc33e08d22c5bf325e
Signed-off-by: Robert Varga <[email protected]>
Tony Tkacik [Fri, 21 Nov 2014 08:43:40 +0000 (08:43 +0000)]
Merge "BUG-650: remove executor abstraction"
Robert Varga [Thu, 20 Nov 2014 10:37:09 +0000 (11:37 +0100)]
BUG-8: mark deprecated classes as such
These classes refer to various deprecated interfaces of MD-SAL,
triggering a lot of warnings about deprecated constructs. Since these
classes themselves have been superseded, mark them as Deprecated,
lowering the amount of warnings we get.
Change-Id: I19753166fa1fd617ad7085b71a1218f6bc4a3f53
Signed-off-by: Robert Varga <[email protected]>
Tony Tkacik [Thu, 20 Nov 2014 12:48:34 +0000 (12:48 +0000)]
Merge "BUG-868: do not use YangInstanceIdentifier.getPath()"
Robert Varga [Sat, 20 Sep 2014 10:07:05 +0000 (12:07 +0200)]
BUG-650: remove executor abstraction
This patch removes sameThreadExecutor from the commit path, eliminating
associated overhead. Relevant benchmarks show improvement pretty much
across the board:
BEFORE millis error
write100KSingleNodeWithOneInnerItemInCommitPerWriteBenchmark 2213.735 77.597
write100KSingleNodeWithOneInnerItemInOneCommitBenchmark 171.524 2.289
write10KSingleNodeWithTenInnerItemsInCommitPerWriteBenchmark 164.282 1.391
write10KSingleNodeWithTenInnerItemsInOneCommitBenchmark 14.161 0.196
write50KSingleNodeWithTwoInnerItemsInCommitPerWriteBenchmark 982.697 29.397
write50KSingleNodeWithTwoInnerItemsInOneCommitBenchmark 93.233 2.174
AFTER millis error delta
write100KSingleNodeWithOneInnerItemInCommitPerWriteBenchmark 2138.900 75.844 -3.4%
write100KSingleNodeWithOneInnerItemInOneCommitBenchmark 177.839 3.997 +3.5%
write10KSingleNodeWithTenInnerItemsInCommitPerWriteBenchmark 158.666 1.090 -3.5%
write10KSingleNodeWithTenInnerItemsInOneCommitBenchmark 13.022 0.105 -8.0%
write50KSingleNodeWithTwoInnerItemsInCommitPerWriteBenchmark 935.490 30.395 -4.8%
write50KSingleNodeWithTwoInnerItemsInOneCommitBenchmark 89.907 1.204 -3.6%
Furthermore it cleans up and marks FIXMEs for defunct statistics. These
will need to be replaced with implementation which does not assume
underlying implementation.
Change-Id: I01c51462a8529a2f874ecd2f9af05faba503bc58
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Thu, 20 Nov 2014 09:59:09 +0000 (10:59 +0100)]
BUG-868: do not use YangInstanceIdentifier.getPath()
This method has been deprecated, so stop using it.
Change-Id: Ibfaf7e40a3d119ed05ff5743c4869e345d18e298
Signed-off-by: Robert Varga <[email protected]>
Tony Tkacik [Thu, 20 Nov 2014 11:27:40 +0000 (11:27 +0000)]
Merge "Fix typos and missing space"
Robert Varga [Sat, 1 Nov 2014 15:18:13 +0000 (16:18 +0100)]
Fix typos and missing space
Change-Id: Iaf581baea36091724eebbc5de33dda34605e1912
Signed-off-by: Robert Varga <[email protected]>
Tony Tkacik [Thu, 20 Nov 2014 08:42:10 +0000 (08:42 +0000)]
Merge "Remove unneeded embedded dependency"
Robert Varga [Thu, 13 Nov 2014 22:12:38 +0000 (23:12 +0100)]
Remove unneeded embedded dependency
yangtools:util already embeds the dependency with a different version,
causing a potential clash. Since sal-dom-broker is not a direct user,
this will work just fine.
Change-Id: If92555d6feb15c6ee9495fb789244750a48e9129
Signed-off-by: Robert Varga <[email protected]>