openflowplugin.git
9 years agoAdding required capabilities for LLDP Speaker. 05/20005/2
Jozef Gloncak [Mon, 11 May 2015 09:33:06 +0000 (11:33 +0200)]
Adding required capabilities for LLDP Speaker.

Adding required capabilities tags to xml of LLDP Speaker
for config subsystem.

Change-Id: Ie5a713ab5845651fd16c0897adfecadab6e0d106
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agobinding thread pools in drop test to target node 43/20043/1
Martin Bobak [Mon, 11 May 2015 15:42:23 +0000 (17:42 +0200)]
binding thread pools in drop test to target node

Change-Id: I593fb2d9dee8d991522d7538a8144b6c74c4417a
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoflow hash should be written to device flow registry only if alien ID was generated 40/20040/1
Martin Bobak [Mon, 11 May 2015 16:50:46 +0000 (18:50 +0200)]
flow hash should be written to device flow registry only if alien ID was generated

Change-Id: I649171151ea2079e56ca200a353f2cff0658973c
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoperformance fix - nodeConnector II reuse 32/20032/1
Martin Bobak [Mon, 11 May 2015 10:57:31 +0000 (12:57 +0200)]
performance fix - nodeConnector II reuse

 - instead of full creating of instanceIdentifier of nodeConnector
   we now reuse instanceIdentifier of node and add just nodeConnector part

Change-Id: I7f55fc73d38f716d3d8b08d65ba5bdc68174dad7
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoFlowRegistryException is not used anymore 31/20031/1
Martin Bobak [Fri, 8 May 2015 12:41:36 +0000 (14:41 +0200)]
FlowRegistryException is not used anymore

Change-Id: I407c837aeb9e65ae79ed25c8f4e93ff6f8d43d3d
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoMerge "internal message statistics available trough JMX bean"
michal rehak [Mon, 11 May 2015 14:58:45 +0000 (14:58 +0000)]
Merge "internal message statistics available trough JMX bean"

9 years agointernal message statistics available trough JMX bean 99/19999/1
Martin Bobak [Mon, 11 May 2015 08:37:59 +0000 (10:37 +0200)]
internal message statistics available trough JMX bean

Change-Id: Id49ab7080ee396e16af2f06282f1cc6b5e268010
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agomore of internal flow mode stats 41/19941/1
Martin Bobak [Fri, 8 May 2015 17:44:15 +0000 (19:44 +0200)]
more of internal flow mode stats

Change-Id: Iaaafcd27e4fc81b3fa0e60f16f0f1907e5edbf99
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoadded internal stats for packetIn+addFlow 19/19919/1
Martin Bobak [Fri, 8 May 2015 15:17:45 +0000 (17:17 +0200)]
added internal stats for packetIn+addFlow

Change-Id: Ie179559c2ceffdb74412843cce5298b0bc57bf9d
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoconnection adapter is set to autoread = false when notofications are not handled 18/19918/1
Martin Bobak [Fri, 8 May 2015 16:51:16 +0000 (18:51 +0200)]
connection adapter is set to autoread = false when notofications are not handled

Change-Id: Ie97ed2237a862c64dbd7b7616dce37ef98f3673e
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoFix LOG: private static final 97/19897/1
Martin Bobak [Fri, 8 May 2015 11:04:14 +0000 (13:04 +0200)]
Fix LOG: private static final

Change-Id: Id153479e96cf97d17064e7f90b4661982dcf2da1
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoDeviceFlowRegistry doesn't use ConcurrentHashMap 95/19895/1
Martin Bobak [Fri, 8 May 2015 12:11:04 +0000 (14:11 +0200)]
DeviceFlowRegistry doesn't use ConcurrentHashMap

Change-Id: I3d670585272ec986c078fa2a2ca392e452c22bd3
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoAdded signum where missing 93/19893/1
Martin Bobak [Fri, 8 May 2015 10:24:08 +0000 (12:24 +0200)]
Added signum where missing

 - for BigInteger ctor based on byte[] it might get negative value
 - 1 is for positive value - replaced by constant

Change-Id: I478880925dabeae7296222e731800c55b92b8175
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoEliminating new BigInteger where possible 92/19892/1
Martin Bobak [Fri, 8 May 2015 09:57:06 +0000 (11:57 +0200)]
Eliminating new BigInteger where possible

Change-Id: I5c2b7d209f4c80e8cc4d0320f4e7f01f28963b54
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agofixed pool size 91/19891/1
Martin Bobak [Fri, 8 May 2015 11:40:46 +0000 (13:40 +0200)]
fixed pool size

Change-Id: I1097a0860a55bdeaabd399c7bd826fb4730c4875
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoDeviceContext changes approach to synchronization 90/19890/1
Martin Bobak [Fri, 8 May 2015 09:50:36 +0000 (11:50 +0200)]
DeviceContext changes approach to synchronization

Instead of creating synchronization locks on whole DeviceContext object,
we create locks on relevant fields.

Change-Id: I593d579a2d4c40eb8b5aef29f7c7c76f5e918e70
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoCommonService has its fields private 87/19887/1
Martin Bobak [Fri, 8 May 2015 09:17:01 +0000 (11:17 +0200)]
CommonService has its fields private

Change-Id: I24a3ecf9ab3b869cc0575f4b36b4a7effb6a468a
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoremoved worthless logging wrapping 86/19886/1
Martin Bobak [Fri, 8 May 2015 08:42:18 +0000 (10:42 +0200)]
removed worthless logging wrapping

Change-Id: If005d2a5e84a187e6798629015b133f41e436f5d
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agochanged approach to synchronization of DeviceContext 48/19848/4
Martin Bobak [Thu, 7 May 2015 15:14:31 +0000 (17:14 +0200)]
changed approach to synchronization of DeviceContext

Change-Id: I557bf7c894708a1612feb9d304bee70b68667109
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoMerge "deviceCtx should not be used where is not needed"
michal rehak [Fri, 8 May 2015 09:29:45 +0000 (09:29 +0000)]
Merge "deviceCtx should not be used where is not needed"

9 years agoMerge "Use ImmutableMap for TranslatorLibrary"
michal rehak [Fri, 8 May 2015 09:27:59 +0000 (09:27 +0000)]
Merge "Use ImmutableMap for TranslatorLibrary"

9 years agoMerge "Lower fast-path locking in RpcContext"
michal rehak [Fri, 8 May 2015 09:25:21 +0000 (09:25 +0000)]
Merge "Lower fast-path locking in RpcContext"

9 years agodeviceCtx should not be used where is not needed 85/19885/1
Martin Bobak [Fri, 8 May 2015 08:34:23 +0000 (10:34 +0200)]
deviceCtx should not be used where is not needed

Change-Id: Iec28b063342a13aafed81ee0cae49852561ab34c
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoUse ImmutableMap for TranslatorLibrary 38/19838/3
Robert Varga [Thu, 7 May 2015 19:05:16 +0000 (21:05 +0200)]
Use ImmutableMap for TranslatorLibrary

There is no need for this to be concurrent.

 - fixed typo

Change-Id: If189f01e931e066205aa12108775a8c28e9c404c
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoLower fast-path locking in RpcContext 37/19837/2
Robert Varga [Thu, 7 May 2015 17:19:11 +0000 (19:19 +0200)]
Lower fast-path locking in RpcContext

Instead of acquiring the lock three times, perform common operations
under the lock and then follow-up without it.

 - fixed typo

Change-Id: Ie5b3f5cdd388c54f170e2a742855a6e654094994
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoMerge "add flowHash to device registry only after flow is successfully written to DS"
michal rehak [Fri, 8 May 2015 07:45:31 +0000 (07:45 +0000)]
Merge "add flowHash to device registry only after flow is successfully written to DS"

9 years agoadd flowHash to device registry only after flow is successfully written to DS 46/19846/2
Martin Bobak [Thu, 7 May 2015 12:45:48 +0000 (14:45 +0200)]
add flowHash to device registry only after flow is successfully written to DS

Change-Id: Ib3b746140462bab3fa632f23c67fb6088266184e
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoCleanup BaseCallback 25/19825/1
Robert Varga [Thu, 7 May 2015 16:24:24 +0000 (18:24 +0200)]
Cleanup BaseCallback

The fields should be private and final, so clean them up, making the
lifecycle much easier to understand.

Change-Id: I54b029ded933f2f56da6559b0991e2fdd7d5a91d
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoFix null check 24/19824/1
Robert Varga [Thu, 7 May 2015 16:11:37 +0000 (18:11 +0200)]
Fix null check

Preconditions.checkNotNull() was not used correctly. Fix that up.

Change-Id: I31582fd72365e4ad7c457f4e7cba4286bf133782
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoLower the size of deviceContext synchronized block 22/19822/2
Robert Varga [Thu, 7 May 2015 15:54:53 +0000 (17:54 +0200)]
Lower the size of deviceContext synchronized block

The synchronized block is needlessly large, slowing things down with
unrelated transitions happening.

Change-Id: I700ba58f567c592a611fd50f94cf27594385f865
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoFixed Scariest level bugs from findbugs. 05/19805/2
Martin Bobak [Thu, 7 May 2015 14:07:55 +0000 (16:07 +0200)]
Fixed Scariest level bugs from findbugs.

Change-Id: I22b51dd31887c9c61a049b7c06835f082fd7fd4f
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agooptimized usage of registry 78/19778/1
Martin Bobak [Thu, 7 May 2015 07:22:45 +0000 (09:22 +0200)]
optimized usage of registry

Change-Id: I9f7a551e172cb932af0f7b13d4c47f0a30db59d5
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agooptimized removal request context from registry 77/19777/1
Martin Bobak [Thu, 7 May 2015 07:18:36 +0000 (09:18 +0200)]
optimized removal request context from registry

Change-Id: I0f73d5abe4dd15e525725a6f4ceec3f57f387b26
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoTranslatorLibrary holds translators in synchronized structure 76/19776/1
Martin Bobak [Thu, 7 May 2015 07:14:48 +0000 (09:14 +0200)]
TranslatorLibrary holds translators in synchronized structure

Change-Id: I2fbbba39bbfa67937af7306ea63ce85005aa1f9c
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agohash usage optimized 75/19775/1
Martin Bobak [Thu, 7 May 2015 07:14:17 +0000 (09:14 +0200)]
hash usage optimized

Change-Id: Ie84d00786e0e2f74a45c20dfdec52f7f1c11e3ea
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoall device registries holds its data in synchronized lists 74/19774/1
Martin Bobak [Thu, 7 May 2015 07:08:15 +0000 (09:08 +0200)]
all device registries holds its data in synchronized lists

Change-Id: I4e47ea5d7ec0f46595d97771d3a0b40ace5ae88c
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoAdded threadpool to droptest. 17/19717/1
Tony Tkacik [Wed, 6 May 2015 14:01:49 +0000 (16:01 +0200)]
Added threadpool to droptest.

Droptest was stealing MD-SAL threads to do its work,
which actually make it dependable on MD-SAL thread count.

Droptest nows own own threadpool - so it should not be affected
by number of threads in MD-SAL.

Change-Id: I6ecf05e6b6f02b5790044888cf03642d7587d413
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoMerge "code cleanup"
michal rehak [Wed, 6 May 2015 13:32:14 +0000 (13:32 +0000)]
Merge "code cleanup"

9 years agocode cleanup 94/19694/2
Martin Bobak [Wed, 6 May 2015 10:24:53 +0000 (12:24 +0200)]
code cleanup

- removed unused imports and commented lines

Change-Id: I4b47b032536a45bf93289e6f7a008dc43dd2027f
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agofixed logging output 03/19703/1
Martin Bobak [Wed, 6 May 2015 11:45:03 +0000 (13:45 +0200)]
fixed logging output

Change-Id: I6e54da6e6b5be0b187fba0539e7a2c777c82af37
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoMerge "BUG-3129 NPE in flowHash"
michal rehak [Wed, 6 May 2015 09:15:18 +0000 (09:15 +0000)]
Merge "BUG-3129 NPE in flowHash"

9 years agoBUG-3129 NPE in flowHash 85/19685/1
Martin Bobak [Wed, 6 May 2015 08:19:08 +0000 (10:19 +0200)]
BUG-3129 NPE in flowHash

 - tableId and priority are mandatory
 - flowCookie will fallback to default (0) value

Change-Id: I9bf082178847544f1672b294b5461ea192e6b16f
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoMerge "bug 3126 - shift to new notification service"
michal rehak [Wed, 6 May 2015 08:37:23 +0000 (08:37 +0000)]
Merge "bug 3126 - shift to new notification service"

9 years agosanitized transaction operations 41/19641/4
Martin Bobak [Tue, 5 May 2015 16:11:35 +0000 (18:11 +0200)]
sanitized transaction operations

 - put and delete are wrapped inside of try-catch
   this way data still will be lost but next operation
   can be scheduled
 - added some more logging

Change-Id: I91b161603db994ef9a2b4879ddae78d8f8bee919
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoMerge "added transaction commit time expenses"
michal rehak [Tue, 5 May 2015 17:40:53 +0000 (17:40 +0000)]
Merge "added transaction commit time expenses"

9 years agoadded transaction commit time expenses 40/19640/3
Martin Bobak [Tue, 5 May 2015 16:10:13 +0000 (18:10 +0200)]
added transaction commit time expenses

 - hooking callback on checked future reterned by tx.submit()

Change-Id: I09f8bad1284b0fa58464460a8a64d5e445ed3543
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoMerge "scheduled transaction submit skipped when tx empty"
michal rehak [Tue, 5 May 2015 17:08:21 +0000 (17:08 +0000)]
Merge "scheduled transaction submit skipped when tx empty"

9 years agoMerge "bug 3118 - statistics polling should react on datastore operation time"
michal rehak [Tue, 5 May 2015 17:01:08 +0000 (17:01 +0000)]
Merge "bug 3118 - statistics polling should react on datastore operation time"

9 years agoscheduled transaction submit skipped when tx empty 39/19639/2
Martin Bobak [Tue, 5 May 2015 12:13:55 +0000 (14:13 +0200)]
scheduled transaction submit skipped when tx empty

 - separated counter and tx-submit-switch
 - improved scheduling of submit
 - skipped useless submits

Change-Id: I49fd60e38e3351d3f2d9cb2a28e84db7c8a13a9d
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agobug 3126 - shift to new notification service 42/19642/1
Martin Bobak [Mon, 4 May 2015 15:43:04 +0000 (17:43 +0200)]
bug 3126 - shift to new notification service

Change-Id: Id25983e139b521075a21d579fe12afd9db2b9363
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agobug 3118 - statistics polling should react on datastore operation time 26/19626/3
Martin Bobak [Tue, 5 May 2015 14:00:25 +0000 (16:00 +0200)]
bug 3118 - statistics polling should react on datastore operation time

- also cleaned up unused dependencies in StatisticsContextImpl

Change-Id: I55c0ab6f5cd74bd0e5e64229b876d03ee63378d5
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agofixed flow hash equals 38/19638/1
Martin Bobak [Tue, 5 May 2015 15:53:22 +0000 (17:53 +0200)]
fixed flow hash equals

 - getters delivered default zero/null values
 - updated unit tests

Change-Id: I5806678ce0d047fd25356d9278cdd7f8f1d0351c
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoMerge "Write to operational DS response of update-table rpc."
michal rehak [Tue, 5 May 2015 15:54:07 +0000 (15:54 +0000)]
Merge "Write to operational DS response of update-table rpc."

9 years agoMerge "removed unused method"
michal rehak [Tue, 5 May 2015 14:29:54 +0000 (14:29 +0000)]
Merge "removed unused method"

9 years agoWrite to operational DS response of update-table rpc. 79/19579/4
Jozef Gloncak [Tue, 5 May 2015 05:33:32 +0000 (07:33 +0200)]
Write to operational DS response of update-table rpc.

Write table features which were received as RPC response to
operational datastore (replace all corresponding data in datastore)

Change-Id: I615a26775019f4c79f292e0a95f3c1ac0ca9f116
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agoBUG 3119 - Empty flow statistics for OFv10. 04/19604/1
Jozef Gloncak [Tue, 5 May 2015 11:33:19 +0000 (13:33 +0200)]
BUG 3119 - Empty flow statistics for OFv10.

During building body of multipart request for flow statistics wildcards were missing.

Change-Id: Ib2e3658a342b991f0c5550780bbea72cccc8d7d1
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agoremoved unused method 25/19625/1
Martin Bobak [Tue, 5 May 2015 11:10:58 +0000 (13:10 +0200)]
removed unused method

Change-Id: Iadfdb55f25e0760add08438a2e30b21569c48458
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoMerge "BUG 3114 - Fixed NPE in table features reconciliation."
michal rehak [Tue, 5 May 2015 08:25:58 +0000 (08:25 +0000)]
Merge "BUG 3114 - Fixed NPE in table features reconciliation."

9 years agoBUG 3114 - Fixed NPE in table features reconciliation. 69/19569/2
Jozef Gloncak [Mon, 4 May 2015 17:48:29 +0000 (19:48 +0200)]
BUG 3114 - Fixed NPE in table features reconciliation.

Change-Id: I6bf31f4ab08f9ccde0a1266f833626bce77444f4
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agofix removed tables for OF-1.0 31/19531/1
Martin Bobak [Mon, 4 May 2015 14:39:00 +0000 (16:39 +0200)]
fix removed tables for OF-1.0

 - empty tables must be written after device description message
   is processed (and written into flowCapableNode - above tables)

Change-Id: Ia052caa103f51e578406cfc8f8128c5a26b99f12
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoMerge "process flows statistics in one commit tx only when device is synchronized"
michal rehak [Mon, 4 May 2015 08:44:31 +0000 (08:44 +0000)]
Merge "process flows statistics in one commit tx only when device is synchronized"

9 years agoMerge "Adding test for updating table-features."
michal rehak [Mon, 4 May 2015 08:35:24 +0000 (08:35 +0000)]
Merge "Adding test for updating table-features."

9 years agoMerge "Speedup local karaf distro."
michal rehak [Mon, 4 May 2015 08:30:51 +0000 (08:30 +0000)]
Merge "Speedup local karaf distro."

9 years agoprocess flows statistics in one commit tx only when device is synchronized 04/19504/1
Martin Bobak [Mon, 4 May 2015 08:08:58 +0000 (10:08 +0200)]
process flows statistics in one commit tx only when device is synchronized

Change-Id: I1d3490686445836299e3058a3102889e5c67549c
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoAdding test for updating table-features. 03/19503/2
Jozef Gloncak [Mon, 4 May 2015 06:45:52 +0000 (08:45 +0200)]
Adding test for updating table-features.

Added test for testing writting table-features to operational datastore
via FRM.

Reverting test for FlowListenerTest (currently TableForwarder isn't listening
on changes on node Table (also flow changes were caught) but on TableFeatures.
Therefore original test which tested direct equality on transaction DOM-xxx ID
can by again applied.

Change-Id: Iabf27ab01d0f11095af65e45374dba581c1656f7
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agoSpeedup local karaf distro. 00/19500/1
Jozef Gloncak [Mon, 4 May 2015 07:34:02 +0000 (09:34 +0200)]
Speedup local karaf distro.

 - by removing odl-restconf boot feature

Change-Id: I716469f96208d84a5f6dbf7ed9dff668725d0e91
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agosal-table:update-table rpc (service) implementation 83/19383/3
Jozef Gloncak [Thu, 30 Apr 2015 06:00:28 +0000 (08:00 +0200)]
sal-table:update-table rpc (service) implementation

According to yang this rpc should return only xid. In SalTableServiceImpl
is obtained data as OFPT_MULTIPART_REPLY type OFPMP_TABLE_FEATURES
which can be used to return more meaningful output (instead just xid)

Change-Id: I8a448fadab2884f8e2bd8518c69e50dc83102573
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agoMerge "lower log severity to warn where appropriate"
michal rehak [Thu, 30 Apr 2015 13:44:10 +0000 (13:44 +0000)]
Merge "lower log severity to warn where appropriate"

9 years agoMerge "avoid flow number oscilation by deleting and writing flow stats in single...
michal rehak [Thu, 30 Apr 2015 13:43:49 +0000 (13:43 +0000)]
Merge "avoid flow number oscilation by deleting and writing flow stats in single commit tx"

9 years agoavoid flow number oscilation by deleting and writing flow stats in single commit tx 72/19372/3
Martin Bobak [Thu, 30 Apr 2015 10:10:23 +0000 (12:10 +0200)]
avoid flow number oscilation by deleting and writing flow stats in single commit tx

Change-Id: I863e6b2e86a43cb5bfcde23dc99a44288a670b19
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agolower log severity to warn where appropriate 80/19380/1
Martin Bobak [Thu, 30 Apr 2015 12:33:22 +0000 (14:33 +0200)]
lower log severity to warn where appropriate

 - decreade log contamination

Change-Id: I311ebdba69ab44af20bb8dd1261d4a0db94af7d2
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoMerge "Improving logging in DeviceContext and MultiMsgCollector."
michal rehak [Thu, 30 Apr 2015 12:37:54 +0000 (12:37 +0000)]
Merge "Improving logging in DeviceContext and MultiMsgCollector."

9 years agoImproving logging in DeviceContext and MultiMsgCollector. 94/19294/3
Jozef Gloncak [Wed, 29 Apr 2015 12:12:42 +0000 (14:12 +0200)]
Improving logging in DeviceContext and MultiMsgCollector.

Change-Id: I82a72d384e651798d29e8997a8dfd90449d819a0
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agoReplace Table with TableFeatures in FRM. 75/19375/1
Jozef Gloncak [Thu, 30 Apr 2015 10:55:38 +0000 (12:55 +0200)]
Replace Table with TableFeatures in FRM.

Changes in flows caused also calling TableForwader (and SalTableService)
because listener was registered on Table which contains Flow.

This change changed listener directly to TableFeatures node.

Change-Id: I8ab25d0cb7f671599622870b40d5182583d937f2
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agomoving message to LOG instead of print to karaf console 48/19348/1
Jamo Luhrsen [Wed, 29 Apr 2015 21:21:05 +0000 (14:21 -0700)]
moving message to LOG instead of print to karaf console

Change-Id: I5b275ee2a3090649cc6826cafa77cd116ad538f6
Signed-off-by: Jamo Luhrsen <james.luhrsen@hp.com>
9 years agoadded success logging to retry looper 41/19341/1
Martin Bobak [Wed, 29 Apr 2015 19:42:20 +0000 (21:42 +0200)]
added success logging to retry looper

Change-Id: I1cbc25b279da8484aaa0f04d7e4283c5443f221f
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoStatiststicsContext is removed from registry when corresponding device context is... 40/19340/1
Martin Bobak [Wed, 29 Apr 2015 19:44:00 +0000 (21:44 +0200)]
StatiststicsContext is removed from registry when corresponding device context is closed

Change-Id: I792beebe71919f11d3e2140197d7ab2439cfad0f
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoFlowHash computation enhanced 39/19339/2
Martin Bobak [Wed, 29 Apr 2015 18:41:18 +0000 (20:41 +0200)]
FlowHash computation enhanced

Change-Id: I6bd100e80579f022c53fbfe1e0906cd3d1333a75
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoDeviceContext is not closed by statistics manager when connection status is HANDSHAKI... 38/19338/2
Martin Bobak [Wed, 29 Apr 2015 16:12:09 +0000 (18:12 +0200)]
DeviceContext is not closed by statistics manager when connection status is HANDSHAKING||TIMEOUTING

- device context is added to list of candidates for gathering statistics and removed next time
  when connection is closed and statistics gathering is not successful

Change-Id: I48571e4e9d630352f13fde66e086fbe293bfd133
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agochatty log switched to trace level 37/19337/2
Martin Bobak [Wed, 29 Apr 2015 15:55:21 +0000 (17:55 +0200)]
chatty log switched to trace level

Change-Id: Iac1a995451d115cf719c952622b365a64d66876f
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoAdded device connection status information to throwable 36/19336/2
Martin Bobak [Wed, 29 Apr 2015 15:55:01 +0000 (17:55 +0200)]
Added device connection status information to throwable

Change-Id: I9af26e095e6f8a8550bd52bc44349591fd9774aa
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoStatisticsManager closes device context when connection not in STATE working 35/19335/2
Martin Bobak [Wed, 29 Apr 2015 15:54:17 +0000 (17:54 +0200)]
StatisticsManager closes device context when connection not in STATE working

Change-Id: I61c0fbb7c05dc3e723867e67710e88348f3bf567
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agofix npe in BarrierTaskBuider 34/19334/2
Martin Bobak [Wed, 29 Apr 2015 12:32:01 +0000 (14:32 +0200)]
fix npe in BarrierTaskBuider

Change-Id: I2b11ccb47619c29d81bcacc04c616df493b5ad99
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoMerge "BarrierTaskBuilder cleanup - moved method to right place"
michal rehak [Wed, 29 Apr 2015 19:32:41 +0000 (19:32 +0000)]
Merge "BarrierTaskBuilder cleanup - moved method to right place"

9 years agoMerge "changed approach to device context synchronization"
michal rehak [Wed, 29 Apr 2015 19:32:01 +0000 (19:32 +0000)]
Merge "changed approach to device context synchronization"

9 years agoMerge "RpcContext doesn't hold referrence to DeviceContext anymore"
michal rehak [Wed, 29 Apr 2015 19:27:47 +0000 (19:27 +0000)]
Merge "RpcContext doesn't hold referrence to DeviceContext anymore"

9 years agoMerge "RpcContext doesn't need to provide DeviceContext"
michal rehak [Wed, 29 Apr 2015 19:25:44 +0000 (19:25 +0000)]
Merge "RpcContext doesn't need to provide DeviceContext"

9 years agofixing of10 issue in MatchUtil 02/19302/1
Timotej Kubas [Wed, 29 Apr 2015 08:32:31 +0000 (10:32 +0200)]
fixing of10 issue in MatchUtil

Change-Id: I406cefad80f19be511b343c3e82c48d907a19aea
Signed-off-by: Timotej Kubas <tkubas@cisco.com>
9 years agoBarrierTaskBuilder cleanup - moved method to right place 33/19333/1
Martin Bobak [Wed, 29 Apr 2015 11:46:14 +0000 (13:46 +0200)]
BarrierTaskBuilder cleanup - moved method to right place

Change-Id: If52d29af2b89b88000476d02645e501f911ef523
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agochanged approach to device context synchronization 32/19332/1
Martin Bobak [Wed, 29 Apr 2015 11:25:23 +0000 (13:25 +0200)]
changed approach to device context synchronization

Change-Id: I3708d526e12a9646690db3bfa9e7d69dc52ba8f5
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoRpcContext doesn't hold referrence to DeviceContext anymore 31/19331/1
Martin Bobak [Wed, 29 Apr 2015 11:19:51 +0000 (13:19 +0200)]
RpcContext doesn't hold referrence to DeviceContext anymore

Change-Id: Ia8a576221dde95d149f0ea8c10024f3153284bde
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoRpcContext doesn't need to provide DeviceContext 30/19330/1
Martin Bobak [Wed, 29 Apr 2015 10:55:41 +0000 (12:55 +0200)]
RpcContext doesn't need to provide DeviceContext

Change-Id: I618e8c2485f33b70fc43a5afcb0abe0905f251c1
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoMerge "Support for Table Features"
michal rehak [Wed, 29 Apr 2015 12:03:00 +0000 (12:03 +0000)]
Merge "Support for Table Features"

9 years agoSupport for Table Features 34/18334/9
Jozef Gloncak [Tue, 28 Apr 2015 12:41:06 +0000 (14:41 +0200)]
Support for Table Features

FlowListenerTest.java - removed equals which checks concrete transaction ID.
If changes are done on flow also TableForwarder is notified because listener is
listening on subtree changes. Therefore can happend that sometimes changes in
table are processed before changes in flow and therefore is generated transaction
ID DOM-2 instead DOM-1.

Change-Id: I3570c03fda0b532833c85bae01ed4a10cc14a2d2
Signed-off-by: HemaTG <hema.gopalkrishnan@ericsson.com>
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agoMerge "Barrier implementation."
michal rehak [Wed, 29 Apr 2015 10:38:10 +0000 (10:38 +0000)]
Merge "Barrier implementation."

9 years agoFixed aggregated statistics 20/19220/2
Timotej Kubas [Mon, 27 Apr 2015 10:50:39 +0000 (12:50 +0200)]
Fixed aggregated statistics

- fixed service for requesting/receiving aggregated statistics
from device

Change-Id: I1a1d0537e3405b2cd1303b2581f5ca83b318544b
Signed-off-by: Timotej Kubas <tkubas@cisco.com>
9 years agoBarrier implementation. 80/18980/7
Jozef Gloncak [Fri, 24 Apr 2015 08:08:36 +0000 (10:08 +0200)]
Barrier implementation.

Implementation of service FlowCapableTransactionService. Concretely sendBarrier method.

Change-Id: I75a4a5f82d0943bcbaf7f888e035715d67fafcd9
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agoMerge "TxChaingManager logging changed to warning"
michal rehak [Wed, 29 Apr 2015 04:07:54 +0000 (04:07 +0000)]
Merge "TxChaingManager logging changed to warning"

9 years agoMerge "removed unwanted requests map initialization"
michal rehak [Wed, 29 Apr 2015 04:06:03 +0000 (04:06 +0000)]
Merge "removed unwanted requests map initialization"

9 years agoMerge "added initial waiting for mdsal in topologyManager"
michal rehak [Wed, 29 Apr 2015 04:05:13 +0000 (04:05 +0000)]
Merge "added initial waiting for mdsal in topologyManager"