vtn.git
10 years agoBug 1453: Fixed unstable unit tests. 75/9475/1
Shigeru Yasuda [Wed, 30 Jul 2014 10:06:52 +0000 (19:06 +0900)]
Bug 1453: Fixed unstable unit tests.

This patch fixes unit tests that expected severe accuracy of timer task
execution.

Change-Id: Id0c3b33e2518f3e37a4b4cb495c4c2bdb8c0e964
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoEnable to configure data flow without specifying MAC address. 74/9274/1
Shigeru Yasuda [Thu, 24 Jul 2014 02:11:41 +0000 (11:11 +0900)]
Enable to configure data flow without specifying MAC address.

A data flow without specifying MAC address will be used to drop all
packets from the specified VLAN.

Change-Id: I45134a4deb417f89450b80ebd58cd83df9c83d31
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoAdded new checkstyle rule that checks coding style strictly. 46/9146/1
Shigeru Yasuda [Fri, 18 Jul 2014 12:10:43 +0000 (21:10 +0900)]
Added new checkstyle rule that checks coding style strictly.

Strict coding style check is enabled only if "-Pstrictcheck" option is
specified to mvn.

Change-Id: I550c266b86280be34785b9ab543b2b48b6833cbb
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoMerge "Bug 1364: Preserve flow entries during container mode."
Hideyuki Tai [Thu, 17 Jul 2014 20:38:37 +0000 (20:38 +0000)]
Merge "Bug 1364: Preserve flow entries during container mode."

10 years agoMerge "Fixed some sonar warnings."
Hideyuki Tai [Wed, 16 Jul 2014 21:38:05 +0000 (21:38 +0000)]
Merge "Fixed some sonar warnings."

10 years agoBug 1364: Preserve flow entries during container mode. 03/9003/2
Shigeru Yasuda [Tue, 15 Jul 2014 04:31:31 +0000 (13:31 +0900)]
Bug 1364: Preserve flow entries during container mode.

Flow entries in the default container should be preserved when the contoller
enters the container mode.

  * Ignore FLOW_REMOVED in the default container during container mode.
  * Data flow APIs behave as if no data flow is installed in the default
    container during container mode.

Change-Id: Ia999160aa123ea062f8d36af1eb072c44bf77e4c
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoMerge "Fixed hashCode() method that returned inconsistent value."
Hideyuki Tai [Tue, 15 Jul 2014 02:07:21 +0000 (02:07 +0000)]
Merge "Fixed hashCode() method that returned inconsistent value."

10 years agoMerge "Backed out OVSDB support code temporarily."
Shigeru Yasuda [Mon, 14 Jul 2014 09:26:29 +0000 (09:26 +0000)]
Merge "Backed out OVSDB support code temporarily."

10 years agoBacked out OVSDB support code temporarily. 77/8977/1
Shigeru Yasuda [Mon, 14 Jul 2014 07:40:49 +0000 (16:40 +0900)]
Backed out OVSDB support code temporarily.

OVSDB support that uses new APIs will be enabled later.

Other changes:

  * integrationtest: Ensure that the VTN neutron bundle can be loaded.
  * northboundIT: Ditto.

Change-Id: Ic7ccffc292d6569b59fda144b8c7bb3753fcc6ff
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoAdd Unit tests for VTNManager 92/8892/2
Karthik.s [Thu, 10 Jul 2014 16:43:10 +0000 (22:13 +0530)]
Add Unit tests for VTNManager

* DataFlowList UT for northbound.
* MacMapping features UT for manager implementation.

Change-Id: Id5e9f22291b2cba4b72d7abc03940fb0f000f22a
Signed-off-by: Karthik.s <siva-karthik@hcl.com>
10 years agoFixed some sonar warnings. 43/8943/1
Shigeru Yasuda [Fri, 11 Jul 2014 12:55:17 +0000 (21:55 +0900)]
Fixed some sonar warnings.

Change-Id: I6eb8668cfa18e745d4db1d70ede65cb76ce34238
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoFixed hashCode() method that returned inconsistent value. 39/8939/1
Shigeru Yasuda [Fri, 11 Jul 2014 11:35:13 +0000 (20:35 +0900)]
Fixed hashCode() method that returned inconsistent value.

Other changes:

  * DataFlow: Added javadoc comment which describes the meaning of
    an empty action list.
  * Fixed typo in javadoc comment.

Change-Id: I7c0e31b463ce62bcdb3918266fdb1a8988c699d6
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoEliminate duplicate plugins in distribution.vtn-manager. 46/8846/1
Shigeru Yasuda [Wed, 9 Jul 2014 09:18:02 +0000 (18:18 +0900)]
Eliminate duplicate plugins in distribution.vtn-manager.

Change-Id: I43e6c7a42e8ad9e797cd983b0dde844a1df4ce6f
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoProvide run.bat for Windows, and add "-of10" switch. 37/8737/1
Shigeru Yasuda [Mon, 7 Jul 2014 13:52:46 +0000 (22:52 +0900)]
Provide run.bat for Windows, and add "-of10" switch.

Change-Id: I1ec4c8c075ea495f31d5254f8dd705a1efd5d0d8
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoEnable MD-SAL openflow plugin if requested. 24/8524/1
Shigeru Yasuda [Wed, 2 Jul 2014 06:30:21 +0000 (15:30 +0900)]
Enable MD-SAL openflow plugin if requested.

MD-SAL openflow plugin is enabled only if "-of13" switch is specified to
run.sh.

Change-Id: I02b2214c37dc55165bdf01271af6241b5e6a4233
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoAdd path map feature. 58/8458/1
Shigeru Yasuda [Mon, 30 Jun 2014 14:22:48 +0000 (23:22 +0900)]
Add path map feature.

Path map defines the packet routing policy in the physical network.
A path map keeps a pair of flow condition and path policy.

  * Flow condition specifies the condition to select packets.
  * Path policy implements cost-based packet routing.

Change-Id: I32692a90e636529e9c14c4223e87b0666efd079b
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoRemove support of "MD_SAL" node and node connector type. 46/8446/1
Shigeru Yasuda [Mon, 30 Jun 2014 02:23:30 +0000 (11:23 +0900)]
Remove support of "MD_SAL" node and node connector type.

MD-SAL got to use the same node and node connector type as AD-SAL for
OpenFlow switch and port.

Change-Id: I738f705908d8fa363195fa42e3ab1fa90585fe24
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoDo not use Class.hashCode() in hashCode() method. 63/8363/1
Shigeru Yasuda [Thu, 26 Jun 2014 08:00:54 +0000 (17:00 +0900)]
Do not use Class.hashCode() in hashCode() method.

Class.hashCode() is inherited from Object class, so it may return
diffent value on different JVM.

Change-Id: I9ac9e2847af73a4e172bfe3a8e17b285ee07ffd3
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoBug 996: Fixed UT bug due to incorrect VTN event synchronization. 24/8324/1
Shigeru Yasuda [Wed, 25 Jun 2014 10:57:16 +0000 (19:57 +0900)]
Bug 996: Fixed UT bug due to incorrect VTN event synchronization.

If the test code verifies the number of VTN events delivered to the
listener instance, it needs to ensure that no VTN event is pending
before adding the listener.

Additional changes:

  * VTNThreadDataTest: Fixed too short timeout.
  * Add some test cases for IVTNModeListener.

Change-Id: Ic6efdab85e9cdbda9f73d27bf1319263edba67ab
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoAdd flow condition APIs. 79/8279/1
Shigeru Yasuda [Tue, 24 Jun 2014 06:08:07 +0000 (15:08 +0900)]
Add flow condition APIs.

Flow condition is used to select packets by specifying condition for
protocol header field in packets.

Change-Id: Ic7321eac15d4fbc3865a30ff31f3f972e31c3da2
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoFixed incorrect name of VTN Coordinator test executables. 32/8232/1
Shigeru Yasuda [Mon, 23 Jun 2014 05:22:15 +0000 (14:22 +0900)]
Fixed incorrect name of VTN Coordinator test executables.

Change-Id: I4adbcf9c41722e3054e4dbabc2ac28ffd2a7e5f1
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoFixed unstable VTN Coordinator tests. 10/8210/1
Shigeru Yasuda [Sat, 21 Jun 2014 03:29:03 +0000 (12:29 +0900)]
Fixed unstable VTN Coordinator tests.

Some tests expect that other test initializes vtncacheutil module.
Those tests may fail according to order of test execution.

Change-Id: I7df81f75f2aca173753acd0b46a2b6997e7ab297
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoDon't run VTN Coordinator test that may fail under heavy load. 08/8208/1
Shigeru Yasuda [Sat, 21 Jun 2014 02:01:56 +0000 (11:01 +0900)]
Don't run VTN Coordinator test that may fail under heavy load.

Some VTN Coordinator tests may fail if the build host is under heavy load,
especially tests that require accuracy of system timer.
This patch eliminates those tests.

Change-Id: I9bc76e7256799a415003a00698e8d9c275d7f7d6
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoMerge "Added support for new features in common driver framework in ODC driver. ...
Sarath Babu Gurujala [Fri, 20 Jun 2014 14:00:37 +0000 (14:00 +0000)]
Merge "Added support for new features in common driver framework in ODC driver.  * Flow Filter  * vTerminal"

10 years agoAdded support for new features in common driver framework in ODC driver. 92/7992/5
senthil [Fri, 13 Jun 2014 19:43:43 +0000 (01:13 +0530)]
Added support for new features in common driver framework in ODC driver.
 * Flow Filter
 * vTerminal

Change-Id: I7fdc072119baeed78313f58cd93f629e03215ebf
Signed-off-by: senthil <senthil-b@hcl.com>
10 years agoRename VTN configuration file path. 74/8074/1
Shigeru Yasuda [Tue, 17 Jun 2014 14:31:37 +0000 (23:31 +0900)]
Rename VTN configuration file path.

VTN configurations will be saved under the container config directory.

Change-Id: I662e5827dbb9b0b40a298c8008f6afd5b6f88f77
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoDo not use enum's hashCode() value. 59/8059/1
Shigeru Yasuda [Tue, 17 Jun 2014 05:52:08 +0000 (14:52 +0900)]
Do not use enum's hashCode() value.

A use of enum's hashCode() may break InfiniSpan consistency because
its hash code in a JVM differs from value in another JVM.

Other changes:

  * checkstyle: Allow use of magic number in hashCode().

Change-Id: I54d7e6e2503f617a89379a3cc81cc3fc492af8cb
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoUpdated unit tests for VTN Manager Neutron module 33/8033/1
kamatchi [Mon, 26 May 2014 20:12:22 +0000 (01:42 +0530)]
Updated unit tests for VTN Manager Neutron module

Change-Id: I51267edafaf0bf99e0494190279a7bc372deb24e
Signed-off-by: kamatchi <kamatchi-l@hcl.com>
10 years agoAdd APIs to get information about data flows. 75/7975/3
Shigeru Yasuda [Fri, 13 Jun 2014 06:36:56 +0000 (15:36 +0900)]
Add APIs to get information about data flows.

"Data flow" means a sequence of flow entries which establishes
end-to-end packet flow. APIs added by this patch provide the way to
derive data flow information from the VTN Manager.

  * Condition to select packets.
  * Flow actions to be applied to packets.
  * Packet route in virtual and physical network.
  * Statistics information.

Change-Id: I9d68eadb68fa0865d76c4c772925672327316d91
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoMerge "Add an example of JSON marshalling into javadoc comment."
Hideyuki Tai [Fri, 13 Jun 2014 12:00:01 +0000 (12:00 +0000)]
Merge "Add an example of JSON marshalling into javadoc comment."

10 years agoMerge "Add MAC mapping feature."
Hideyuki Tai [Fri, 13 Jun 2014 11:50:37 +0000 (11:50 +0000)]
Merge "Add MAC mapping feature."

10 years agoMerge "Bug 1189: Suppress duplicated path fault log."
Hideyuki Tai [Fri, 13 Jun 2014 11:18:34 +0000 (11:18 +0000)]
Merge "Bug 1189: Suppress duplicated path fault log."

10 years agoMerge "Modified implementation for ignoring unnecessary events from OVSDB plugin."
Sarath Babu Gurujala [Fri, 13 Jun 2014 07:11:16 +0000 (07:11 +0000)]
Merge "Modified implementation for ignoring unnecessary events from OVSDB plugin."

10 years agoImprove VTN Coordinator code to avoid some redundant code sections 99/7899/3
sameera [Wed, 11 Jun 2014 18:19:20 +0000 (23:49 +0530)]
Improve VTN Coordinator code to avoid some redundant code sections

Change-Id: I02a6d51f9e021d788377499289df6490be2f4ab0
Signed-off-by: sameera <sameera.k@hcl.com>
10 years agoModified implementation for ignoring unnecessary events from OVSDB plugin. 96/7896/2
ananthip [Wed, 11 Jun 2014 10:18:32 +0000 (15:48 +0530)]
Modified implementation for ignoring unnecessary events from OVSDB plugin.

Change-Id: I511e32c2eba0e35879fcf503016585a5fdcdfc8e
Signed-off-by: ananthip <ananthip@hcl.com>
10 years agoAdd an example of JSON marshalling into javadoc comment. 45/7945/1
Shigeru Yasuda [Thu, 12 Jun 2014 13:45:49 +0000 (22:45 +0900)]
Add an example of JSON marshalling into javadoc comment.

Change-Id: Ic4a62f31f880c1875dcd81ebda001cf182a2c8c9
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoAdd MAC mapping feature. 42/7942/2
Shigeru Yasuda [Thu, 12 Jun 2014 12:12:21 +0000 (21:12 +0900)]
Add MAC mapping feature.

MAC mapping is virtual network mapping based on MAC address and VLAN ID.
It can associate one or more MAC addresses with a vBridge.

Note that VTN Coordinator does not support MAC mapping yet.

Other changes:

  * API version of VTN Manager is changed to 2.

Change-Id: I98d1522753897595dc15ae494852d5ed3e5399f8
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoBug 1189: Suppress duplicated path fault log. 21/7921/1
Shigeru Yasuda [Thu, 12 Jun 2014 01:03:43 +0000 (10:03 +0900)]
Bug 1189: Suppress duplicated path fault log.

An error log which indicates a path fault should not be recorded
if it is already detected.

Change-Id: Icdf81c0677742268b52146953ec69e34015c9c5f
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoChange VTN Manager version to 0.2.0 for Helium release. 90/7890/1
Shigeru Yasuda [Wed, 11 Jun 2014 06:11:43 +0000 (15:11 +0900)]
Change VTN Manager version to 0.2.0 for Helium release.

Succeeding patches will change VTN Manager API. So I decided to change
VTN Manager version in advance.

Change-Id: I0d580002ed1c773d01468d9eb6a4d0006d64539e
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoBug 1177: Change "unix_socket_directory" paramter for PostgreSQL 9.3. 47/7847/1
Shigeru Yasuda [Tue, 10 Jun 2014 02:33:25 +0000 (11:33 +0900)]
Bug 1177: Change "unix_socket_directory" paramter for PostgreSQL 9.3.

"unix_socket_directory" parameter in postgresql.conf was renamed to
"unix_socket_directories" in PostgreSQL 9.3. This patch makes db_setup
script define "unix_socket_directories" parameter to specify UNIX socket
directory when it detects PostgreSQL 9.3 or later.

Change-Id: I3dda6064eaadfc24baee87da12ab0ef8675c78f6
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoFixed typo in error message. 45/7845/1
Shigeru Yasuda [Tue, 10 Jun 2014 02:24:25 +0000 (11:24 +0900)]
Fixed typo in error message.

Change-Id: I7245641ab6274781347545fd9f0338de92ed3385
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoFix for VTN Coordinator UT failure. 56/7756/1
Shigeru Yasuda [Fri, 6 Jun 2014 00:25:16 +0000 (09:25 +0900)]
Fix for VTN Coordinator UT failure.

  * Enlarge buffer to store absolute file path.

Change-Id: I16cfa80de944618a9237d249a0506c63c4f42921
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoMerge "Implementation for OVSDB-VTN Neutron Integration"
Hideyuki Tai [Thu, 5 Jun 2014 13:20:51 +0000 (13:20 +0000)]
Merge "Implementation for OVSDB-VTN Neutron Integration"

10 years agoImplementation for OVSDB-VTN Neutron Integration 58/6158/11
gvrangan [Mon, 14 Apr 2014 16:12:33 +0000 (09:12 -0700)]
Implementation for OVSDB-VTN Neutron Integration

   * Will use the ovsdb services to create required
     configuration on the OVS switch of OpenStack.

   * Will Handle the Neutron Requests and create
     portmapping to establish connectivity between hosts.

Change-Id: I3bbf4e99ab9a4a694ec1a9915229749dfb9dfa1f
Signed-off-by: gvrangan <venkatrangang@hcl.com>
10 years agoUpdate VTN Coordinator sources to the latest version. 40/7640/1
Shigeru Yasuda [Tue, 3 Jun 2014 12:34:48 +0000 (21:34 +0900)]
Update VTN Coordinator sources to the latest version.

VTN Coordinator version is changed to 5.1.1.0-SNAPSHOT.

Change-Id: I198631ea162e562a50fd08245ca5ec4632fee0a5
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoMerge "Update VTN Coordinator README for Helium release."
Hideyuki Tai [Tue, 3 Jun 2014 10:26:17 +0000 (10:26 +0000)]
Merge "Update VTN Coordinator README for Helium release."

10 years agoUpdate VTN Coordinator README for Helium release. 81/7581/1
Shigeru Yasuda [Mon, 2 Jun 2014 08:21:28 +0000 (17:21 +0900)]
Update VTN Coordinator README for Helium release.

  * Tomcat server instance is installed by VTN Coordinator, and
    it is started by vtn_start.
  * Tomcat server port was changed to 8083/tcp.
  * Version number in README is controlled by pom.xml.
  * VTN Coordinator API version was changed to V1.1.

Change-Id: Id5e28158cfc164e337a0445632148014f6b8a649
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoSync third-party modules to the controller. 80/7580/1
Shigeru Yasuda [Mon, 2 Jun 2014 06:18:50 +0000 (15:18 +0900)]
Sync third-party modules to the controller.

  * Jackson 2.3.2
  * JaCoCo 0.6.2.201302030002

Other changes:

  * Fixed invalid JaCoCo configuration.

Change-Id: I86fbb90b9b875242198ad1c31588e999643598b2
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoMerge "Bug 1068: Fixed ODC driver controller issue during commit"
Hideyuki Tai [Thu, 29 May 2014 04:47:45 +0000 (04:47 +0000)]
Merge "Bug 1068: Fixed ODC driver controller issue during commit"

10 years agoBug 1068: Fixed ODC driver controller issue during commit 97/7397/6
susant [Mon, 26 May 2014 17:08:18 +0000 (22:38 +0530)]
Bug 1068: Fixed ODC driver controller issue during commit

* This patch fixes ODC driver controller issue during simultaneous
commit of physical and virtual configuration

Change-Id: I0a739e593aad046c48aaffa1bc2c78e9a5f8ba91
Signed-off-by: susant <susantchandra.s@hcl.com>
10 years agoDon't record trace log for LLDP packet. 60/7460/1
Shigeru Yasuda [Wed, 28 May 2014 10:44:33 +0000 (19:44 +0900)]
Don't record trace log for LLDP packet.

Change-Id: I6d7999cd56063ee86c855099e95866d6447a4f9c
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoUse snapshot version of controller artifacts. 57/7457/2
Shigeru Yasuda [Wed, 28 May 2014 07:13:31 +0000 (16:13 +0900)]
Use snapshot version of controller artifacts.

Other changes:

  * Upgrade maven plugins.
    * maven-enunciate-plugin 1.28
    * maven-bundle-plugin 2.4.0
    * maven-dependency-plugin 2.8
    * maven-clean-plugin 2.5
  * Ignore configuration directory created by integration tests.

Change-Id: I244805d1de0ffb932aeade518bc0a3fc8c935021
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoImprove integration tests which run with PaxExam. 88/7288/1
Shigeru Yasuda [Wed, 21 May 2014 06:59:17 +0000 (15:59 +0900)]
Improve integration tests which run with PaxExam.

  * Don't use @BeforeClass and @AfterClass.
  * Run all tests in one test container in order to shorten test time.

Change-Id: I09618b99c409261e6ccf17ecc8773576f90c851a
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoBug 1058: Eliminate query parameters from the Location header. 86/7286/1
Shigeru Yasuda [Wed, 21 May 2014 05:19:24 +0000 (14:19 +0900)]
Bug 1058: Eliminate query parameters from the Location header.

Some REST APIs of the VTN Manager copy the request URI into the Location
response-header. But query parameters in the request URI should not be
copied.

Change-Id: I0ed50c9e4089f896295443b1a73dde87ffdf0321
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoBug 1043: Create "integrationtests" build profile. 36/7236/1
Shigeru Yasuda [Tue, 20 May 2014 10:37:29 +0000 (19:37 +0900)]
Bug 1043: Create "integrationtests" build profile.

Tests which take long time will be skipped unless "integrationtests"
profile is active.

Change-Id: I353c8a695fcc8145ad9cbaaf6a5c4c9422759ce0
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoMerge "Bug 1000: Fixed unstable tests in manager.integrationtest."
Hideyuki Tai [Wed, 14 May 2014 05:01:05 +0000 (05:01 +0000)]
Merge "Bug 1000: Fixed unstable tests in manager.integrationtest."

10 years agoBug 1000: Fixed unstable tests in manager.integrationtest. 37/6937/1
Shigeru Yasuda [Tue, 13 May 2014 16:57:11 +0000 (01:57 +0900)]
Bug 1000: Fixed unstable tests in manager.integrationtest.

  * testIListenDataPacket()
    * Fixed invalid initial value of count down latch used to wait for
      completion of flow installation.
    * Need more time to wait for flow entries.
    * Ensure that required edge is established before test.
  * testIListenRoutingUpdates()
    * Check vBridge state using VTN manager listener.
  * FlowProgrammerService.mapNF needs to be synchronized.

Change-Id: I89fc5763924ed4216ec81a7b1676984c433c60de
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoBug 996: Fixed unstable unit test. 27/6927/1
Shigeru Yasuda [Tue, 13 May 2014 10:34:01 +0000 (19:34 +0900)]
Bug 996: Fixed unstable unit test.

This patch fixes failure of manager.implementation UT caused by
too short event timeout.

Change-Id: I857ba986b41aa682bdfbd21505a0d0898ec59ba2
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
10 years agoBug 975: Eliminate the use of obsolete JSON-C function. 01/6801/1
Shigeru Yasuda [Thu, 8 May 2014 06:28:44 +0000 (15:28 +0900)]
Bug 975: Eliminate the use of obsolete JSON-C function.

json_object_object_get() in JSON-C library is obsolete.
json_object_object_get_ex() should be used instead.

Change-Id: I902b80df6a68f3e92f4b2511e29dfc24e2e49f3f
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoFix bug 711 to solve the clearing cache issue in VTN coordinator during audit 06/6706/1
kamatchi [Thu, 24 Apr 2014 06:17:38 +0000 (11:47 +0530)]
Fix bug 711 to solve the clearing cache issue in VTN coordinator during audit

Change-Id: Ia06885e0bf6059ff7931641f76224de272189863
Signed-off-by: kamatchi <kamatchi-l@hcl.com>
11 years agoMerge "Add functional test for physical read audit scenario"
Sarath Babu Gurujala [Mon, 5 May 2014 06:54:01 +0000 (06:54 +0000)]
Merge "Add functional test for physical read audit scenario"

11 years agoBug 857: Add workaround for a bug of old Open vSwitch. 42/6442/2
Shigeru Yasuda [Mon, 28 Apr 2014 06:46:33 +0000 (15:46 +0900)]
Bug 857: Add workaround for a bug of old Open vSwitch.

Old version of OVS has a bug that it may clear OFPFW_DL_VLAN_PCP bit in
FLOW_REMOVED message incorrectly. This workaround tries to remove the SAL
Flow from the flow database after eliminating DL_VLAN_PR match field if
FLOW_REMOVED handler receives a SAL Flow that has DL_VLAN_PR match field.
This should not cause any problem because current VTN Manager never uses
DL_VLAN_PR match field.

Change-Id: I700c61a51459aa86609dde9d5b192a07bb0965d9
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoMerge "Fixed unstable test."
Hideyuki Tai [Tue, 22 Apr 2014 08:09:27 +0000 (08:09 +0000)]
Merge "Fixed unstable test."

11 years agoMerge "Refactor VTN Manager."
Hideyuki Tai [Sun, 20 Apr 2014 22:33:14 +0000 (22:33 +0000)]
Merge "Refactor VTN Manager."

11 years agoFix bug 712 for switch description null check in VTN coordinator 54/6254/1
sameera [Thu, 17 Apr 2014 16:18:16 +0000 (21:48 +0530)]
Fix bug 712 for switch description null check in VTN coordinator

Change-Id: Id0e2cc3e7b534afd62ff4de60414256de995995e
Signed-off-by: sameera <sameera.k@hcl.com>
11 years agoMerge "Fix bug 673 for read physical configuration failure in VTN coordinator during...
Sarath Babu Gurujala [Wed, 16 Apr 2014 14:02:04 +0000 (14:02 +0000)]
Merge "Fix bug 673 for read physical configuration failure in VTN coordinator during opendaylight reboot"

11 years agoMerge "Fix bug 438 to solve the failure in getting physical link information"
Sarath Babu Gurujala [Wed, 16 Apr 2014 13:58:39 +0000 (13:58 +0000)]
Merge "Fix bug 438 to solve the failure in getting physical link information"

11 years agoFixed unstable test. 59/6159/1
Shigeru Yasuda [Mon, 14 Apr 2014 15:27:59 +0000 (00:27 +0900)]
Fixed unstable test.

This patch fixes bug for unit test that the result was affected by
the order of test cases.

Change-Id: I2fa948882e7204e3cfd186c33490c13b8b49d9fc
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoRefactor VTN Manager. 40/6140/2
Shigeru Yasuda [Fri, 11 Apr 2014 12:10:28 +0000 (21:10 +0900)]
Refactor VTN Manager.

  * Associate MAC address with virtual mapping which maps the address
    in the MAC address table.
  * Associate ingress and egress flow entries with virtual mappings
    which map them in the flow database.
  * Enable to get source and destination hosts configured in flow entries
    for internal use.
  * Optimize the way to purge obsolete flow entries and MAC addresses.
  * Scan TopoEdgeUpdate list only one time when an edge update event
    is received.

Change-Id: Idecfe40d949616523f7036d72641afed3a7ecb8e
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoSuppress unwanted log messages while running tests. 39/6139/2
Shigeru Yasuda [Fri, 11 Apr 2014 11:59:27 +0000 (20:59 +0900)]
Suppress unwanted log messages while running tests.

Change-Id: Ia1e38f3b6d5e4880eb75c379f797cfbbcc697bba
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoAdd functional test for physical read audit scenario 32/6332/1
kamatchi [Sat, 12 Apr 2014 20:55:28 +0000 (02:25 +0530)]
Add functional test for physical read audit scenario

Change-Id: I7f0ad88f5968bd98d9e399ef1bbe408ce0aa0cc4
Signed-off-by: kamatchi <kamatchi-l@hcl.com>
11 years agoFixed incorrect log message which indicates failure of flow uninstallation. 29/6029/1
Shigeru Yasuda [Thu, 10 Apr 2014 16:07:58 +0000 (01:07 +0900)]
Fixed incorrect log message which indicates failure of flow uninstallation.

Change-Id: I728ac6ec77acd13f1becdf12f03e39b8af641e77
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoFixed incorrect javadoc comment. 27/6027/1
Shigeru Yasuda [Thu, 10 Apr 2014 15:19:48 +0000 (00:19 +0900)]
Fixed incorrect javadoc comment.

Change-Id: I89605ddaec328f26d7aeabb411931961b9ade471
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoFix bug 673 for read physical configuration failure in VTN coordinator during openday... 91/5791/2
kamatchi [Thu, 20 Mar 2014 06:07:35 +0000 (11:37 +0530)]
Fix bug 673 for read physical configuration failure in VTN coordinator during opendaylight reboot

Change-Id: I5221f23dae6e1c111dc388616340e225640d8356
Signed-off-by: kamatchi <kamatchi-l@hcl.com>
11 years agoMerge "ArpHandler emulator: Abolish IPv4 forwarding."
Hideyuki Tai [Thu, 10 Apr 2014 05:18:17 +0000 (05:18 +0000)]
Merge "ArpHandler emulator: Abolish IPv4 forwarding."

11 years agoFixed unstable tests. 48/5948/1
Shigeru Yasuda [Mon, 7 Apr 2014 16:00:28 +0000 (01:00 +0900)]
Fixed unstable tests.

  * VTNManagerImplDisableNodesTest.testDisabledNodeAfterTimeout():
    Need more time to start PACKET_IN service on a new node.
  * VTNManagerImplClusterTest:
    Test should not fail even if cluster event is removed by timer thread.

Additional changes:

  * VTNManagerImpl: Use putEvent() to catch unexpected exception.

Change-Id: I2343417d994920ddce911d7e460fb436d7914b2e
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoArpHandler emulator: Abolish IPv4 forwarding. 35/5935/1
Shigeru Yasuda [Mon, 7 Apr 2014 09:30:25 +0000 (18:30 +0900)]
ArpHandler emulator: Abolish IPv4 forwarding.

The base controller has moved IPv4 forwarding logic from arphandler to
simpleforwarding. So it also should be removed from ArpHandler emulator.

Change-Id: I8c58a3a0cfa4ee37d1060c8c1084bb1d73a08ae2
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoImproved logging. 02/5902/1
Shigeru Yasuda [Fri, 4 Apr 2014 08:32:47 +0000 (17:32 +0900)]
Improved logging.

  * Don't record FLOW_MOD failure if the target node does not exist.
  * Record inventory change as informational log.

Change-Id: Ic7dab1f2e1b9dcd800ab70c62c15880e5c55f7a2
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoImplement Comparable to MacVlan and MapReference classes. 97/5897/1
Shigeru Yasuda [Thu, 3 Apr 2014 18:51:08 +0000 (03:51 +0900)]
Implement Comparable to MacVlan and MapReference classes.

Change-Id: Ifcc3addbb3e3a42336805e75c08bbed4b18388f9
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoAdded VTenantPath.contains(VTenantPath). 92/5892/2
Shigeru Yasuda [Thu, 3 Apr 2014 14:24:19 +0000 (23:24 +0900)]
Added VTenantPath.contains(VTenantPath).

VTenantPath.contains(VTenantPath) determines whether the virtual node
associated with the VTenantPath instance contains the virtual node
specified by another VTenantPath instance.

Change-Id: Ic1dbb1e6935d20ddea8d32e270e3ebe59a09797d
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoAllow unprivileged user to run VTN Coordinator. 01/5801/1
Shigeru Yasuda [Fri, 28 Mar 2014 13:43:15 +0000 (22:43 +0900)]
Allow unprivileged user to run VTN Coordinator.

  * A user who runs VTN Coordinator needs to have write permission
    for /usr/local/vtn/var directory.
  * db_setup command installs ownership of VTN Coordinator.
    Only a user who executed db_setup command can execute VTN commands,
    vtn_start, vtn_stop, and db_setup.
  * "db_setup -c" reset VTN Coordinator environment to initial state.
    * All data and log files are erased.

Change-Id: I366c14559bafe6bd0284815824bac7871721040b
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoFix bug 438 to solve the failure in getting physical link information 89/5889/1
kamatchi [Thu, 27 Mar 2014 01:05:02 +0000 (06:35 +0530)]
Fix bug 438 to solve the failure in getting physical link information

Change-Id: I4aa740d19ccc43dde42dcb8abb5613f65d242771
Signed-off-by: kamatchi <kamatchi-l@hcl.com>
11 years agoTerminate Tomcat instance when uncd crashes. 73/5773/1
Shigeru Yasuda [Wed, 26 Mar 2014 12:43:39 +0000 (21:43 +0900)]
Terminate Tomcat instance when uncd crashes.

Change-Id: I464a39416b18aabb4079675ff245bcad5d0a253e
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoProvide Tomcat instance only for the VTN Coordinator. 59/5759/1
Shigeru Yasuda [Tue, 25 Mar 2014 16:24:09 +0000 (01:24 +0900)]
Provide Tomcat instance only for the VTN Coordinator.

  * vtn_start starts a Tomcat instance only for the VTN Coordinator,
    and vtn_stop stops.
  * VTN web application, including required Tomcat configuration, is
    pre-installed.
  * Note that TCP port number used by Tomcat is changed from 8080 to 8083.

Change-Id: I37176c83e60cf69c3fa5eeaece4fa7b3fe0bf9a1
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoUpdate VTN Coordinator sources to the latest version. 27/5727/1
Shigeru Yasuda [Mon, 24 Mar 2014 10:03:56 +0000 (19:03 +0900)]
Update VTN Coordinator sources to the latest version.

VTN Coordinator version is changed to 5.1.0.0-SNAPSHOT.

Change-Id: I6f76c22e5210ad5c7d97eb52ec23953aa1fe052d
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoTry to detect IP address for a host as possible. 90/5690/1
Shigeru Yasuda [Wed, 19 Mar 2014 17:46:54 +0000 (02:46 +0900)]
Try to detect IP address for a host as possible.

VTN Manager will send at most 10 ARP requests to a detected host.

Change-Id: I4356b8d42f91a5901315e75cc5dc69e6fffa322a
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoMap StatusCode.BADREQUEST to HTTP 400 response (Bad Request) in REST API. 44/5644/1
Shigeru Yasuda [Fri, 14 Mar 2014 13:03:44 +0000 (22:03 +0900)]
Map StatusCode.BADREQUEST to HTTP 400 response (Bad Request) in REST API.

Note that this patch affects error response code returned by REST API.

Change-Id: I0165cc40c03bfc31196527faf1df378b4477d0e8
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoNever learn zero MAC address in vBridge. 41/5641/1
Shigeru Yasuda [Fri, 14 Mar 2014 12:22:27 +0000 (21:22 +0900)]
Never learn zero MAC address in vBridge.

Change-Id: I78ede562fe4cbd689f18e6e58eb18437e6c1b28c
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoImplement Comparable to VTenantPath class. 39/5639/1
Shigeru Yasuda [Fri, 14 Mar 2014 11:58:34 +0000 (20:58 +0900)]
Implement Comparable to VTenantPath class.

Change-Id: I3054f4e6c7e57b279ba5f25b02648ee00a63932f
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoEliminate duplicate code in toString(). 36/5636/1
Shigeru Yasuda [Fri, 14 Mar 2014 11:13:29 +0000 (20:13 +0900)]
Eliminate duplicate code in toString().

Change-Id: Ieb1093941c502406ac65ae2e10756df9b122e2e8
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoFixed unstable unit test. 77/5577/1
Shigeru Yasuda [Mon, 10 Mar 2014 09:04:56 +0000 (18:04 +0900)]
Fixed unstable unit test.

A MacAddressEntry instance keeps a set of InetAddress instances using
an unorderd set. So string representation of a MacAddressEntry instance
is unstable because it is affected by the order of InetAddress instances.

Change-Id: Ic91af42fcfa851c67d0197d7ad34c2ae1e974413
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoRefactor VTN Manager. 64/5564/1
Shigeru Yasuda [Fri, 7 Mar 2014 12:44:32 +0000 (21:44 +0900)]
Refactor VTN Manager.

  * Determine virtual node where an incoming packet is mapped using
    global cluster cache instead of virtual node scan.
  * Ease VLAN mapping restriction.
    * The same VLAN ID can be mapped to different vBridges as long as
      different nodes are specified.
    * A VLAN mapping configured with a non-null node (which maps VLAN
      network on a specific switch) can coexist with another VLAN mapping
      configured with the same VLAN ID and a null node (which maps VLAN
      network on all switches).
      * VLAN mapping configured with a non-null node is always prior to
        VLAN mapping configured with a null node.

Change-Id: Ifc9a3170ceab65492df3b05f356a44991c515748
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoRemove unused dependency, jersey-json. 45/5545/1
Shigeru Yasuda [Wed, 5 Mar 2014 09:52:01 +0000 (18:52 +0900)]
Remove unused dependency, jersey-json.

Change-Id: Ia3846fc9bd20d77c835cff123223a82f074e5aeb
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoBug fix for equals(Object) in virtual node path classes. 20/5520/1
Shigeru Yasuda [Tue, 4 Mar 2014 11:07:04 +0000 (20:07 +0900)]
Bug fix for equals(Object) in virtual node path classes.

Virtual node paths of different types should be treated as different
objects even if they have the same path components.

Change-Id: If2e6ab3cfc1436b8a14210e63284190c284957f8
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoBug fix for port mapping. 38/5438/1
Shigeru Yasuda [Fri, 21 Feb 2014 11:29:35 +0000 (20:29 +0900)]
Bug fix for port mapping.

This patch fixes a bug that an unexpected port may be mapped if the switch
port to be mapped is specified by its name.

Change-Id: If1643560292e8d57df11b42e24adb1616f00407c
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoFixed typo in PortHandler.java. 22/5422/1
Hideyuki Tai [Thu, 20 Feb 2014 11:59:53 +0000 (06:59 -0500)]
Fixed typo in PortHandler.java.

Change-Id: I8f065278fb9ca52994678c49194ea9616aa99fc8
Signed-off-by: Hideyuki Tai <h-tai@cd.jp.nec.com>
11 years agoAdditional Functional tests for reading physical attributes from controllers 60/5260/2
senthil [Tue, 11 Feb 2014 20:51:00 +0000 (02:21 +0530)]
Additional Functional tests for reading physical attributes from controllers

Change-Id: I09ed9e28309698101b2fcad9a9fbb361306766f6
Signed-off-by: senthil <senthil-b@hcl.com>
11 years agoMerge "Add Delay to FT after mininet session termination"
Sarath Babu Gurujala [Tue, 11 Feb 2014 10:02:34 +0000 (10:02 +0000)]
Merge "Add Delay to FT after mininet session termination"

11 years agoAdd Delay to FT after mininet session termination 45/5145/1
balakrishnan [Fri, 7 Feb 2014 11:11:34 +0000 (16:41 +0530)]
Add Delay to FT after mininet session termination

Change-Id: I6304814847fa9e68ef6a855e45eab5c50eaca8da
Signed-off-by: balakrishnan <balakrishnan.ka@hcl.com>
11 years agoFix bug 385 to solve logical port computation in multiple controller scenarios 12/5012/2
kamatchi [Sun, 26 Jan 2014 18:38:58 +0000 (00:08 +0530)]
Fix bug 385 to solve logical port computation in multiple controller scenarios

Change-Id: Ic23b8e41d6972e46bf5f0d97d45f3788eb3d944c
Signed-off-by: kamatchi <kamatchi-l@hcl.com>