openflowplugin.git
6 years agoMerge "Remove deprecated"
Anil Vishnoi [Mon, 30 Oct 2017 05:56:01 +0000 (05:56 +0000)]
Merge "Remove deprecated"

6 years agoDo not use fix custom version in ofp feature 83/64783/1
Luis Gomez [Fri, 27 Oct 2017 00:59:54 +0000 (17:59 -0700)]
Do not use fix custom version in ofp feature

Change-Id: Ic0a7c69a3f92b2d874fa64b168ccda50c6696351
Signed-off-by: Luis Gomez <ecelgp@gmail.com>
6 years agoRemove deprecated 66/64566/1
David Suárez [Fri, 20 Oct 2017 11:45:18 +0000 (13:45 +0200)]
Remove deprecated

- CheckedFuture
- Futures.addCallback
- Some other changes regarding checkstyle, sonar and annotations

Change-Id: I6ab7b10a6170bee6e78895b21d40ee1a047d961a
Signed-off-by: David Suárez <david.suarez.fuentes@gmail.com>
6 years agoFix checkstyle issues in openflowplugin-impl module 95/64295/2
D Arunprakash [Mon, 16 Oct 2017 09:06:50 +0000 (14:36 +0530)]
Fix checkstyle issues in openflowplugin-impl module

Change-Id: I8d6aa0b35078350bf897c5bf2b9a6cc11d0a4bf2
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
6 years agoMerge "Cli to display all the connected DPNs"
Anil Vishnoi [Fri, 13 Oct 2017 06:21:20 +0000 (06:21 +0000)]
Merge "Cli to display all the connected DPNs"

6 years agoCli to display all the connected DPNs 21/63521/15
Gobinath [Tue, 26 Sep 2017 09:37:45 +0000 (15:07 +0530)]
Cli to display all the connected DPNs

Change-Id: I519450772b670750ccb38391a3c633ba572340d1
Signed-off-by: Gobinath <gobinath@ericsson.com>
Signed-off-by: gobinath <gobinath@ericsson.com>
6 years agoMerge "Fix log message"
Anil Vishnoi [Thu, 12 Oct 2017 06:06:23 +0000 (06:06 +0000)]
Merge "Fix log message"

6 years agoFix log message 53/64153/1
David Suarez [Wed, 11 Oct 2017 09:43:22 +0000 (11:43 +0200)]
Fix log message

Change-Id: If70c25133d0a430ebb7b2a2906ac95fdad4d7bde
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
6 years agoDisable the test that's causing merge failure 48/64148/1
Anil Vishnoi [Wed, 11 Oct 2017 07:40:34 +0000 (00:40 -0700)]
Disable the test that's causing merge failure

It's bit of a weird situation. Locally this unit test is passing consistently
but it's failing in merge job. Looks like merge job for the following patch
https://git.opendaylight.org/gerrit/#/c/62822/

failed and it didn't publish the artifacts and looks like that's causing
the merge job failure. This patch is an attempt to get a green merge job
and once all the latest artifacts are publish, this test will be re-enabled.

Change-Id: I99742b756040382b249072cd21782f42b4de3b21
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
6 years agoMerge "BUG-9218: use packaged inventory model"
Anil Vishnoi [Tue, 10 Oct 2017 23:51:18 +0000 (23:51 +0000)]
Merge "BUG-9218: use packaged inventory model"

6 years agoMaster: cherry-pick changes for BUG-9223 30/64030/2
Jalpa Modasiya [Fri, 6 Oct 2017 19:58:09 +0000 (12:58 -0700)]
Master: cherry-pick changes for BUG-9223

    Cherry-pick changes for BUG-9223 from stable/boron branch for remove hardcoded value of lldp interval
    Removed debug log from LLDPLinkAger.java

Change-Id: I95361679b6f12824f45e0ae31972d81485e23fc7
Signed-off-by: Jalpa Modasiya <jmodasiy@luminanetworks.com>
6 years agoBUG-9218: use packaged inventory model 87/64087/1
Robert Varga [Mon, 9 Oct 2017 18:51:04 +0000 (20:51 +0200)]
BUG-9218: use packaged inventory model

Rather than packing it here, use controller's dedicated feature
to pull it in.

Change-Id: I14f7acb4577d32eda954406f1cf55f5fff3cb0c7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 years agoThis patch implements ct-mark support in nicira extensions. 43/64043/1
Bertrand [Thu, 28 Sep 2017 05:33:04 +0000 (22:33 -0700)]
This patch implements ct-mark support in nicira extensions.

Specifically:
- support for ct-mark MATCH, including mask.
- support for ct-mark ACTION (set-field), but not including mask

This patch supports implementing ACL spec:
https://git.opendaylight.org/gerrit/#/c/60580

Change-Id: Ib828da39b4470e7172fe7028e8d3123fb184c742
Signed-off-by: Bertrand <bertrand.low@hcl.com>
6 years agoFix issues related to checkstyle enforcement 78/63778/2
David Suarez [Thu, 28 Sep 2017 15:09:17 +0000 (17:09 +0200)]
Fix issues related to checkstyle enforcement

This is the first of a series of two or three commits, since the module
is quite big. The latest commit will set the severity to "error".

Change-Id: I7a00bb3038c22ae352b2d5134cc0184ad29dc30f
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
6 years agoBump odlparent 2.0.4 to 2.0.5 51/63651/2
Stephen Kitt [Wed, 27 Sep 2017 13:36:03 +0000 (15:36 +0200)]
Bump odlparent 2.0.4 to 2.0.5

Change-Id: I2bafbcaa16edd56d1260ffb184d1568c14a4ef13
Signed-off-by: Stephen Kitt <skitt@redhat.com>
6 years agoMerge changes
Thanh Ha [Fri, 29 Sep 2017 15:07:01 +0000 (15:07 +0000)]
Merge changes

6 years agoMerge "Bump openflowplugin to use yangtools 1.2.0"
Thanh Ha [Fri, 29 Sep 2017 15:07:00 +0000 (15:07 +0000)]
Merge "Bump openflowplugin to use yangtools 1.2.0"

6 years agoBump openflowplugin to use yangtools 1.2.0 21/63821/2
Anil Belur [Fri, 29 Sep 2017 02:25:35 +0000 (12:25 +1000)]
Bump openflowplugin to use yangtools 1.2.0

Jira: releng-485

Change-Id: I3a6b2716050b611e1a668a877ff6723f555c6372
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
6 years agoMerge "Remove Itemlifecycle"
Tomas Slusny [Thu, 28 Sep 2017 14:39:19 +0000 (14:39 +0000)]
Merge "Remove Itemlifecycle"

6 years agoRemove Itemlifecycle 72/61772/5
Tomas Slusny [Thu, 28 Sep 2017 08:52:31 +0000 (10:52 +0200)]
Remove Itemlifecycle

ItemLifecycle was created for one time use case. Devices without
statistics possibility at all
and this workaround was made to store flows, groups, meters to the DS
as a reaction on services (flow, group, meters) when statistics
gathering could not be used.

Resolves: Bug 9010

Change-Id: Ic6eeb79d720284b7f139063ea238f40cef32a11a
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
6 years agoSort bucket actions 95/63595/1
Tomas Slusny [Wed, 27 Sep 2017 07:19:19 +0000 (09:19 +0200)]
Sort bucket actions

Sort bucket actions by order when serializing them in
GroupMessageSerializer.

Resolves: bug 9216

Change-Id: Icc5ad3f8b533a9f660e0248efed1b158c52336cf
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
6 years agoMerge "Fix issues related to checkstyle enforcement"
Tomas Slusny [Tue, 26 Sep 2017 17:01:22 +0000 (17:01 +0000)]
Merge "Fix issues related to checkstyle enforcement"

6 years agoFix issues related to checkstyle enforcement 46/63446/4
David Suarez [Fri, 22 Sep 2017 10:54:30 +0000 (12:54 +0200)]
Fix issues related to checkstyle enforcement

Change-Id: Ia70763a22732dadf6d2f835915f9391c8e101e36
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
6 years agoMerge "Gather statistics in separate thread"
Jozef Bacigal [Tue, 26 Sep 2017 07:58:55 +0000 (07:58 +0000)]
Merge "Gather statistics in separate thread"

6 years agoMerge "Async config message"
Jozef Bacigal [Tue, 26 Sep 2017 07:57:13 +0000 (07:57 +0000)]
Merge "Async config message"

6 years agoGather statistics in separate thread 25/63125/5
Tomas Slusny [Thu, 14 Sep 2017 08:04:43 +0000 (10:04 +0200)]
Gather statistics in separate thread

Gather statistics in separate thread to free netty thread from
processing statistics when they arrive.

See also: bug 8787

Change-Id: I2df7de1773db7f4c71a2f8ac33d75b123c12f0c3
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
6 years agoAsync config message 22/59522/17
miroslav.macko [Mon, 19 Jun 2017 14:29:27 +0000 (16:29 +0200)]
Async config message

- Add support for async config message
  (Supported from version 1.3)

Resolves: bug 4082

Change-Id: Iae32e8a7433610d689c3d6b7a1c440032c3f2cc6
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
6 years agoCheckstyle enforcement. 74/63474/1
David Suárez [Sat, 23 Sep 2017 20:08:04 +0000 (22:08 +0200)]
Checkstyle enforcement.

This commit [1] left enforcement on warning, this one rise to error.

[1] https://git.opendaylight.org/gerrit/#/c/63234/

Change-Id: I80c896444e065b9f2aea5640775195deceb3ca24
Signed-off-by: David Suárez <david.suarez.fuentes@gmail.com>
6 years agoMerge "Fix checkstyle warnings for impl/connection package and OpenFlowPluginProvider...
Tomas Slusny [Fri, 22 Sep 2017 07:42:25 +0000 (07:42 +0000)]
Merge "Fix checkstyle warnings for impl/connection package and OpenFlowPluginProviderImpl"

6 years agoMerge "Drop the odlparent.netty property"
Anil Vishnoi [Thu, 21 Sep 2017 21:59:42 +0000 (21:59 +0000)]
Merge "Drop the odlparent.netty property"

6 years agoMerge "Fix issues related to checkstyle enforcement"
Anil Vishnoi [Thu, 21 Sep 2017 21:47:57 +0000 (21:47 +0000)]
Merge "Fix issues related to checkstyle enforcement"

6 years agoMerge "Fix transaction manager closing."
Anil Vishnoi [Thu, 21 Sep 2017 17:08:14 +0000 (17:08 +0000)]
Merge "Fix transaction manager closing."

6 years agoMerge "Fix issues related to checkstyle enforcement"
Tomas Slusny [Thu, 21 Sep 2017 14:16:53 +0000 (14:16 +0000)]
Merge "Fix issues related to checkstyle enforcement"

6 years agoFix transaction manager closing. 02/63402/1
Jozef Bacigal [Tue, 5 Sep 2017 09:27:57 +0000 (11:27 +0200)]
Fix transaction manager closing.

- the event onTransactionFailed we properly closing chain and creating
  a new chain
- changed writeOnlyTransaction to readWriteTransaction
- moved transaction manager to the common module
- topology manager using transaction manager instead of creating a
  transaction chain for itself
- added control of unfinished transaction on close

See also: Bug-9038

Change-Id: Idadbb4ed0f4c61e7f80da5e2dbedbd80dece118e
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
6 years agoFix issues related to checkstyle enforcement 85/63185/2
David Suarez [Fri, 15 Sep 2017 21:39:14 +0000 (23:39 +0200)]
Fix issues related to checkstyle enforcement

Change-Id: I5d2103eadcb1a20586fb4b78babfb76447981149
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
6 years agoMerge "Terminate SLAVE task before sending role change"
Jozef Bacigal [Tue, 19 Sep 2017 07:40:13 +0000 (07:40 +0000)]
Merge "Terminate SLAVE task before sending role change"

6 years agoMerge "Fix NPE, version 1.0 returns null on auxiliary id."
Tomas Slusny [Tue, 19 Sep 2017 07:19:16 +0000 (07:19 +0000)]
Merge "Fix NPE, version 1.0 returns null on auxiliary id."

6 years agoFix issues related to checkstyle enforcement 34/63234/1
David Suarez [Mon, 18 Sep 2017 13:43:59 +0000 (15:43 +0200)]
Fix issues related to checkstyle enforcement

Change-Id: I234058f50c2b035ca5d86dbd3a3ddd643c9747fc
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
6 years agoFix issues related to checkstyle enforcement 22/63222/1
David Suarez [Mon, 18 Sep 2017 10:23:46 +0000 (12:23 +0200)]
Fix issues related to checkstyle enforcement

Change-Id: I1cbb8d46e74185dbabbfbe74e8a6039ef6573168
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
6 years agoFix NPE, version 1.0 returns null on auxiliary id. 08/63208/2
Jozef Bacigal [Mon, 18 Sep 2017 07:43:46 +0000 (09:43 +0200)]
Fix NPE, version 1.0 returns null on auxiliary id.

Change-Id: Id2bce3ec8c03e73d1fcb20a4bde099d5c2a0224d
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
6 years agoTerminate SLAVE task before sending role change 23/63123/2
Tomas Slusny [Thu, 14 Sep 2017 07:16:05 +0000 (09:16 +0200)]
Terminate SLAVE task before sending role change

- Terminate SLAVE task in role context when role change is requested and
not after role change is finished.
- Do not send notification about role failed to set to mastership
service in case future was cancelled

See also: bug 9089

Change-Id: Ia784d3b682b8991fe7a471bbfc7462aebfa6d4ef
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
6 years agoFix issues related to checkstyle enforcement 45/63145/1
David Suarez [Thu, 14 Sep 2017 15:44:20 +0000 (17:44 +0200)]
Fix issues related to checkstyle enforcement

Change-Id: I3d96af4e9d5f72921767e2aa06d9daffc20ef26d
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
6 years agoFix checkstyle warnings for impl/connection package and OpenFlowPluginProviderImpl 62/62362/3
miroslav.macko [Mon, 28 Aug 2017 12:47:12 +0000 (14:47 +0200)]
Fix checkstyle warnings for impl/connection package and OpenFlowPluginProviderImpl

See also: bug 8607

Change-Id: I6d9e1fcf02d3c282f7e640ab6e30858d79b02289
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
6 years agoMove used code from openflowplugin to impl 85/62885/2
Tomas Slusny [Fri, 8 Sep 2017 09:07:11 +0000 (11:07 +0200)]
Move used code from openflowplugin to impl

Move used code that was used only in openflowplugin-impl from
openflowplugin (old Helium design)

See also: bug 8653

Change-Id: I5a425db395601f49625f598057d835ca7a471ac9
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
6 years agoMerge "Fix codestyle"
Tomas Slusny [Fri, 8 Sep 2017 10:20:27 +0000 (10:20 +0000)]
Merge "Fix codestyle"

6 years agoMerge "Fix codestyle"
Tomas Slusny [Fri, 8 Sep 2017 10:19:57 +0000 (10:19 +0000)]
Merge "Fix codestyle"

6 years agoMerge "Fix codestyle"
Tomas Slusny [Fri, 8 Sep 2017 10:18:24 +0000 (10:18 +0000)]
Merge "Fix codestyle"

6 years agoFix codestyle 83/62883/2
Jozef Bacigal [Fri, 8 Sep 2017 08:35:39 +0000 (10:35 +0200)]
Fix codestyle

- Removed deprecated getLOGValue from deviceInfo

See also:Bug-8607

Change-Id: Ic9c11ea6e2ace4e802ddc8dd3e2445655e2a57fd
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
6 years agoFix codestyle 81/62881/2
Jozef Bacigal [Fri, 8 Sep 2017 07:23:23 +0000 (09:23 +0200)]
Fix codestyle

- Anonymous type replaced by lambda

See also:Bug-8607

Change-Id: I7134315329b860d698927c6eb2c7f94a9476afde
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
6 years agoFix codestyle 78/62878/2
Jozef Bacigal [Fri, 8 Sep 2017 06:42:56 +0000 (08:42 +0200)]
Fix codestyle

- Removed unused import

See also:Bug-8607

Change-Id: Ie5f9e2449bcb072ff0a1a65857e3b371a1722dcd
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
6 years agoMerge "Remove dependency of impl on onf-extensions"
Jozef Bacigal [Fri, 8 Sep 2017 08:43:03 +0000 (08:43 +0000)]
Merge "Remove dependency of impl on onf-extensions"

6 years agoMerge "Add missing bundle converters"
Jozef Bacigal [Fri, 8 Sep 2017 08:42:57 +0000 (08:42 +0000)]
Merge "Add missing bundle converters"

6 years agoMerge "Fix codestyle"
Tomas Slusny [Fri, 8 Sep 2017 08:39:30 +0000 (08:39 +0000)]
Merge "Fix codestyle"

6 years agoMerge "Fix codestyle"
Tomas Slusny [Fri, 8 Sep 2017 08:39:20 +0000 (08:39 +0000)]
Merge "Fix codestyle"

6 years agoMerge "Cleanup"
Tomas Slusny [Fri, 8 Sep 2017 08:22:35 +0000 (08:22 +0000)]
Merge "Cleanup"

6 years agoMerge "Move match converter to new converter system"
Jozef Bacigal [Fri, 8 Sep 2017 07:35:22 +0000 (07:35 +0000)]
Merge "Move match converter to new converter system"

6 years agoFix codestyle 77/62877/1
Jozef Bacigal [Fri, 8 Sep 2017 06:39:50 +0000 (08:39 +0200)]
Fix codestyle

- Optional.isPresent replacesd to functional expression

See also:Bug-8607

Change-Id: Ib9a81b66751db08f93b12232f83da549cf9f2c1b
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
6 years agoFix codestyle 76/62876/1
Jozef Bacigal [Fri, 8 Sep 2017 06:34:37 +0000 (08:34 +0200)]
Fix codestyle

- Arrays.asList() memory save

See also:Bug-8607

Change-Id: I697affb49632c279175488ad35a2fe2111ddc234
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
6 years agoCleanup 85/62585/4
David Suarez [Sun, 3 Sep 2017 09:22:52 +0000 (11:22 +0200)]
Cleanup

- Remove dead code
- Join if statements
- Private methods called from inner classes should be moved to those
classes

Change-Id: If66b8291e4b9cb237ebc88d1ce362e0aeb32d393
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
6 years agoFix codestyle 25/62825/1
Jozef Bacigal [Thu, 7 Sep 2017 11:13:30 +0000 (13:13 +0200)]
Fix codestyle

- explicit type

See also:Bug-8607

Change-Id: I5078f0b423942fdec385e9043d5a719cbffb9a6d
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
6 years agoFix codestyle 24/62824/1
Jozef Bacigal [Thu, 7 Sep 2017 11:11:40 +0000 (13:11 +0200)]
Fix codestyle

- unnecessary boxing removed

See also:Bug-8607

Change-Id: Ia37138f17e4831d38611571b37e74553f06e93af
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
6 years agoMove match converter to new converter system 22/62822/1
Tomas Slusny [Thu, 7 Sep 2017 11:00:12 +0000 (13:00 +0200)]
Move match converter to new converter system

In preparation of removal of Helium design, remove MatchReactor and move
MatchConvertor to new converter manager based system.

See also: bug 8653

Change-Id: I14db62975cd16d07f3fd7a39e36fc38bacb8abf8
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
6 years agoRemove dependency of impl on onf-extensions 74/62774/2
Tomas Slusny [Wed, 6 Sep 2017 15:04:56 +0000 (17:04 +0200)]
Remove dependency of impl on onf-extensions

As preparation for removal of helium design:

- Remove dependency of openflowplugin-impl on onf-extensions and move
SalBundleService to openflowplugin-impl, as it is registered and used
only there
- Move onf extension yang models to extension-api

See also: bug 8653

Change-Id: Ib5813b5e7a115f1918d27ea116d7d49b4605799d
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
6 years agoAdd missing bundle converters 76/62776/1
Tomas Slusny [Wed, 6 Sep 2017 15:03:47 +0000 (17:03 +0200)]
Add missing bundle converters

Add missing bundle converters about what was device context throwing
warnings.

Change-Id: Ic3d89c386c32f06d80afe1221f2d30fd919d087d
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
6 years agoFix possible NPE on ContextChainHolderImpl 71/62771/1
Jozef Bacigal [Wed, 6 Sep 2017 14:43:31 +0000 (16:43 +0200)]
Fix possible NPE on ContextChainHolderImpl

- deviceConnected method

Change-Id: I7cbd8c3bb2a4d92ecdaa5fc541e01e3d8ac738b6
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
6 years agoDo not mark device as connecting when closing it 66/62666/1
Tomas Slusny [Tue, 5 Sep 2017 08:04:56 +0000 (10:04 +0200)]
Do not mark device as connecting when closing it

Do not put incoming device connection to connectingDevices map when it
is still in closing state, to prevent having stale entry in
connectingDevices map.

Resolves: bug 9088

Change-Id: Ibee87152cd791f639999097c07a737c64afda990
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
6 years agoRedesign statistics context and manager 20/61020/39
Tomas Slusny [Wed, 2 Aug 2017 07:48:37 +0000 (09:48 +0200)]
Redesign statistics context and manager

- To simplify statistics context and statistics manager code,
have better control over statistics polling and to remove
referencing of statistics manager from statistics context,
remove current method of statistics scheduling and replace
it with Guava scheduled service that will handle starting,
periodic gathering and stopping of statistics.
- Simplify chain of steps that continues with statistics initialization
with reconciliation framework enabled

See also: bug 8913

Change-Id: I0f3dcdd5292c6c7180ea80afc6d4d3df16b05ff9
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
6 years agoMerge "BUG8607 Fix checkstyle issues"
Anil Vishnoi [Sun, 3 Sep 2017 08:11:07 +0000 (08:11 +0000)]
Merge "BUG8607 Fix checkstyle issues"

6 years agoBUG8607 Fix checkstyle issues 80/62580/2
David Suarez [Sat, 2 Sep 2017 17:04:02 +0000 (19:04 +0200)]
BUG8607 Fix checkstyle issues

- Formatting
- JavaDoc
- Line lengths
- Name of variables
- Exception catching
- Remove redundant modifiers
- Add default case to switch
- Move variables closer to their

- Enforcement in pom.xml

Change-Id: If17fcdc00e8d22818a5501027a6bb7db3f2dcba3
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
6 years agoEnforce checkstyle 34/62534/1
David Suarez [Fri, 1 Sep 2017 08:45:32 +0000 (10:45 +0200)]
Enforce checkstyle

Enforce checkstyle by changing severity to error.

Change-Id: I4a6ae191bfec6df72e17f1c8ca50e92a9fd68ba5
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
6 years agoMerge "Remove CSS artifact remnants"
Tomas Slusny [Wed, 30 Aug 2017 07:25:38 +0000 (07:25 +0000)]
Merge "Remove CSS artifact remnants"

6 years agoMerge "Fix checkstyle warnings for impl/protocol test package"
Anil Vishnoi [Fri, 25 Aug 2017 22:43:24 +0000 (22:43 +0000)]
Merge "Fix checkstyle warnings for impl/protocol test package"

6 years agoMerge "Fix checkstyle warnings for impl/karaf, lifecycle, common, mastership"
Anil Vishnoi [Fri, 25 Aug 2017 22:42:13 +0000 (22:42 +0000)]
Merge "Fix checkstyle warnings for impl/karaf, lifecycle, common, mastership"

6 years agoMerge "Fix checkstyle warnings for impl/device package"
Anil Vishnoi [Fri, 25 Aug 2017 22:30:55 +0000 (22:30 +0000)]
Merge "Fix checkstyle warnings for impl/device package"

6 years agoMerge "Fix checkstyle warnings for impl/datastore package"
Anil Vishnoi [Fri, 25 Aug 2017 22:30:20 +0000 (22:30 +0000)]
Merge "Fix checkstyle warnings for impl/datastore package"

6 years agoMerge "Fix checkstyle warnings for impl/protocol package"
Anil Vishnoi [Fri, 25 Aug 2017 22:24:14 +0000 (22:24 +0000)]
Merge "Fix checkstyle warnings for impl/protocol package"

6 years agoRemove CSS artifact remnants 30/62330/1
Tom Pantelis [Fri, 25 Aug 2017 18:46:27 +0000 (14:46 -0400)]
Remove CSS artifact remnants

The project has already been converted to blueprint (except for test-extension)
so removed he remaining CSS remnants (eg use of config-parent, JMXGenerator).

Change-Id: I38c3e16ece82e2f5deada17a3faafa180e11a210
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
6 years agoFix checkstyle warnings for impl/datastore package 17/62317/1
miroslav.macko [Fri, 25 Aug 2017 12:46:50 +0000 (14:46 +0200)]
Fix checkstyle warnings for impl/datastore package

See also: bug 8607

Change-Id: I7701b8b611648a3c7af90686847ecefd1970bf8a
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
6 years agoFix checkstyle warnings for impl/device package 10/62310/1
miroslav.macko [Fri, 25 Aug 2017 11:40:29 +0000 (13:40 +0200)]
Fix checkstyle warnings for impl/device package

See also: bug 8607

Change-Id: I3f29d2ea40989877995b34211ac3e2f3aee5f637
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
6 years agoFix checkstyle warnings for impl/karaf, lifecycle, common, mastership 84/62284/2
miroslav.macko [Thu, 24 Aug 2017 15:32:14 +0000 (17:32 +0200)]
Fix checkstyle warnings for impl/karaf, lifecycle, common, mastership

See also: bug 8607

Change-Id: I8fc6a4677ec53df886877c62c5a98d624c01022f
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
6 years agoFix checkstyle warnings for impl/protocol test package 73/62273/2
miroslav.macko [Thu, 24 Aug 2017 13:22:41 +0000 (15:22 +0200)]
Fix checkstyle warnings for impl/protocol test package

See also: bug 8607

Change-Id: Icd8914faf38d0d6493dbe633b93cd2442e0bdfd4
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
6 years agoMerge "Fix checkstyle warnings for impl/role package"
Tomas Slusny [Thu, 24 Aug 2017 15:40:19 +0000 (15:40 +0000)]
Merge "Fix checkstyle warnings for impl/role package"

6 years agoFix checkstyle warnings for impl/protocol package 10/62210/2
miroslav.macko [Wed, 23 Aug 2017 14:59:42 +0000 (16:59 +0200)]
Fix checkstyle warnings for impl/protocol package

See also: bug 8607

Change-Id: I2adea22e939e8cf9bc87505ca4e130c73fc93a0f
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
6 years agoRemove unsupported statistics warning 49/62249/1
miroslav.macko [Thu, 24 Aug 2017 07:33:03 +0000 (09:33 +0200)]
Remove unsupported statistics warning

Remove warning for unsupported statistics type when deleting all groups,
flows and meters since it is unwanted.

See also: bug 8607

Change-Id: Ib91383a66306bebba3da9dff88bcb38664ec5860
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
6 years agoFix checkstyle warnings for impl/role package 88/62188/1
miroslav.macko [Wed, 23 Aug 2017 08:59:20 +0000 (10:59 +0200)]
Fix checkstyle warnings for impl/role package

See also: bug 8607

Change-Id: Ia72af7d846cd1a6e900b36821ef62703db4ebc1d
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
6 years agoSolves issue with two connections from one device. 79/59179/16
Jozef Bacigal [Tue, 8 Aug 2017 08:22:07 +0000 (10:22 +0200)]
Solves issue with two connections from one device.

See also:Bug 8723

Change-Id: I1e07eb590f285f9d6c1326b94ef5b159242c0757
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
6 years agoFix checkstyle warnings for rpc package 95/62095/4
miroslav.macko [Mon, 21 Aug 2017 14:57:30 +0000 (16:57 +0200)]
Fix checkstyle warnings for rpc package

See also: bug 8607

Change-Id: I2ad3e70aac83509f8af49369004633befba73df7
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
6 years agoFix checkstyle warnings for services package 82/62082/6
miroslav.macko [Mon, 21 Aug 2017 12:01:07 +0000 (14:01 +0200)]
Fix checkstyle warnings for services package

See also: bug 8607

Change-Id: I1f97d8faed46209423f95170af2413e0fb4beb07
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
6 years agoFix checkstyle warnings for statistics package 46/61846/9
miroslav.macko [Wed, 16 Aug 2017 13:49:07 +0000 (15:49 +0200)]
Fix checkstyle warnings for statistics package

See also: bug 8607

Change-Id: I45875a328dbfb078701ff1c6684c7c28a97a7634
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
6 years agoFix checkstyle warnings for translator and registry package 36/61836/6
miroslav.macko [Wed, 16 Aug 2017 11:58:47 +0000 (13:58 +0200)]
Fix checkstyle warnings for translator and registry package

See also: bug 8607

Change-Id: I793e00ae546e745cb42c0917494c7896f3b95719
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
6 years agoFix checkstyle warnings for util package 73/61773/8
miroslav.macko [Tue, 15 Aug 2017 14:25:26 +0000 (16:25 +0200)]
Fix checkstyle warnings for util package

See also: bug 8607

Change-Id: I3bd3b473ebb673b6883def0503cf8d3b3a8a6d10
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
6 years agoMerge "Remove deprecated bootstrap channel options"
Tomas Slusny [Tue, 22 Aug 2017 07:27:02 +0000 (07:27 +0000)]
Merge "Remove deprecated bootstrap channel options"

6 years agoRemove deprecated bootstrap channel options 18/62118/1
Jozef Bacigal [Tue, 22 Aug 2017 05:09:11 +0000 (07:09 +0200)]
Remove deprecated bootstrap channel options

- LOW and HIGH WATERMARK are deprecated

Bug: 8607
Change-Id: I6735aed51882361bc69d665f99b008e1d11f9030
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
6 years agoAdd RoleManager and RoleContext 35/61035/22
Tomas Slusny [Wed, 2 Aug 2017 11:15:42 +0000 (13:15 +0200)]
Add RoleManager and RoleContext

- Move sending of MASTER and SLAVE role from DeviceContext
  and ContextChainHolder to new RoleContext and RoleManager
- Use hashed wheel timer for setting SLAVE role on device in
  case MASTER role was not propagated instead of ItemScheduler
- Remove retries from SalRoleService

See also: bug 8913

Change-Id: I808efef843ed936035fbf7759ae22d8976c80ca7
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
6 years agoGuard lifecycle of contexts 75/60875/33
Tomas Slusny [Fri, 28 Jul 2017 13:35:33 +0000 (15:35 +0200)]
Guard lifecycle of contexts

- Add GuardedContext wrapper for OFPContext that will guard each
phase of context lifecycle (new instance, instantiateServiceInstance,
closeServiceInstance, close)

Resolves: bug 8913

Change-Id: I6c054575c9f93f03e45dcc23feefa0e7dae6fa88
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
6 years agoMerge "Update ONF tests"
Tomas Slusny [Mon, 21 Aug 2017 11:14:46 +0000 (11:14 +0000)]
Merge "Update ONF tests"

6 years agoUpdate ONF tests 35/61435/4
Jozef Bacigal [Wed, 9 Aug 2017 16:15:18 +0000 (18:15 +0200)]
Update ONF tests

- previously ingored tests fix

Change-Id: I70c4d2264635d1282391a7151c43ad802e0acb2c
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
6 years agoFix checkstyle impl/common and impl/configuration 68/62068/1
Jozef Bacigal [Mon, 21 Aug 2017 08:57:46 +0000 (10:57 +0200)]
Fix checkstyle impl/common and impl/configuration

Change-Id: I88b6af868552053cbaa3e01cec19df09db472979
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
6 years agoFix chectyle warning. 63/62063/1
Jozef Bacigal [Mon, 21 Aug 2017 07:17:27 +0000 (09:17 +0200)]
Fix chectyle warning.

Change-Id: Ie3e95d406edb98a77e0656ffaa8540231509e4f1
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
6 years agoMerge "Fix checkstyle"
Tomas Slusny [Mon, 21 Aug 2017 06:47:47 +0000 (06:47 +0000)]
Merge "Fix checkstyle"