netconf.git
10 years agoBUG 624 - Make netconf TCP port optional.
Tomas Olvecky [Tue, 27 May 2014 10:41:16 +0000 (12:41 +0200)]
BUG 624 - Make netconf TCP port optional.

Previously netconf-impl opened a TCP port with no authentication on
localhost, and netconf-ssh used it as a bridge to forward trafic
after processing authentication and encryption.

This patch creates new project netconf-tcp and modifies netconf-impl
to open the netconf server on LocalAddress. Both tcp and ssh modules
now communicate with this local server.
Config ini is modified so that the TCP port (8383) is not enabled
by default.

Change-Id: I74bded660f10b20d09535d32308aff5b2ae611d9
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
10 years agoBUG-633: allow overriding of channelFactory
Robert Varga [Thu, 1 May 2014 15:55:00 +0000 (17:55 +0200)]
BUG-633: allow overriding of channelFactory

It turns out netty does not let us override an already-set
channelFactory. Reorder customization to detect when such an override is
necessary.

Change-Id: I99de69b98e4034d4701313942d9ed2a09923375d
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoResolve Bug:681 - Fix config module registration to Service Registry.
Tomas Olvecky [Tue, 8 Apr 2014 14:22:48 +0000 (16:22 +0200)]
Resolve Bug:681 - Fix config module registration to Service Registry.

Rework OSGi service registration during second phase commit: only service references
will be registered into SR, instead of old behaviour when each module's service
interfaces were used. Only one key-value entry is persisted in registration:
{name: name of service reference} .

Change-Id: I25249fe8f9e51570cd3ea963e91145b7e44da57d
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
10 years ago Remove version mismatch in config.version
Giovanni Meo [Fri, 18 Apr 2014 13:32:50 +0000 (15:32 +0200)]
 Remove version mismatch in config.version

 - End goal was to remove several config.version present in the pom, in
 the making i cleaned some of the repetition in config parent pom and
 aligned with the commons.opendaylight
- Removed some more warning on the pom files

Change-Id: I6717ceb915fe90fa7313472eb03884de9d09235d
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
10 years agoAdding auto-sorting plugin to all Controller via parent/pom.xml
jameshall03885 [Wed, 16 Apr 2014 18:18:57 +0000 (14:18 -0400)]
Adding auto-sorting plugin to all Controller via parent/pom.xml

leveraging google's sortpom plugin, all controller poms are sorted
at build time as per the opendaylight/commons/parent/pom.xml configuration.

Sorted lists of properties, dependencies, and plugins will increase pom readability
and help prevent duplicate entry errors.

This first submission is huge as I changed one pom.xml and all are then sorted.
Only if the sortpom plugin is reconfigured will all pom's again be changed.

Note that if any pom.xml is pushed without having been through a build ... folks are
going to see pom.xml files showup as modified unintentionally.

Change-Id: I8553f38b9f0e5f6d27177ad6b9b9c35a4b43d55a
Signed-off-by: jameshall03885 <ghall@brocade.com>
10 years agoBug 651 - Added back IDE profile and changed target for yang sources
jameshall03885 [Wed, 9 Apr 2014 14:30:03 +0000 (10:30 -0400)]
Bug 651 - Added back IDE profile and changed target for yang sources

- The IDE maven profile was added back based on feedback from Giovanni Meo

- To avoid devs from having to run the IDE profile so eclipse can see the yang
generated source files, the yang source files are now generated under src/main/yang-gen-sals
or src/main/yang-gen-config instead of target/target-ide.

- The maven-clean-plugin was moved to the commons base pom and removed from
all child poms where it was specified. Thus, it will be automatically run for all
projects. The plugin's execution will clean all xtend and yang generated source dirs.

- The build-helper-maven-plugin was also moved to the commons base pom and removed from
all child poms. It will automatically run for all projects and no longer needs to be
specified in child poms. The plugin's execution will created eclipse source folders
for all xtend and yang generated source.

Tom P and Devin A really did all this work, Greg just gets credit unfairly.

Conflicts:
        opendaylight/config/config-module-archetype/src/main/resources/archetype-resources/pom.xml

Change-Id: I8d9e403629cab2e48d03d5c7a417a02f1d878ca7
Signed-off-by: tpantelis <tpanteli@brocade.com>
Signed-off-by: jameshall03885 <ghall@brocade.com>
Signed-off-by: dbavery <devin.avery@brocade.com>
Signed-off-by: jameshall03885 <ghall@brocade.com>
10 years agoBUG-633: allow bootstrap customization
Robert Varga [Sun, 6 Apr 2014 16:20:58 +0000 (18:20 +0200)]
BUG-633: allow bootstrap customization

Downstream projects may need to customize Bootstrap/ServerBootstrap
instances before they are used. Create two protected methods which
can be overridden to gain access to the instances before they are used.

Change-Id: Ibb45c7b99847cbe2fe8b90e8d1bf125c66a18e0d
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoBUG-467: reconnect-strategy configuration moved into controller/commons/protocol...
Milos Fabian [Mon, 17 Mar 2014 06:40:14 +0000 (07:40 +0100)]
BUG-467: reconnect-strategy configuration moved into controller/commons/protocol-framework
-changed reconnect-strategy service and modules to reconnect-strategy-factory - configuration of ReconnectStrategyFactory.

Change-Id: I863cf4f7cf559504d05e14293af9d2c5e9373ca7
Signed-off-by: Milos Fabian <milfabia@cisco.com>
10 years agoSuppress unchecked cast warnings
Robert Varga [Tue, 18 Feb 2014 10:45:26 +0000 (11:45 +0100)]
Suppress unchecked cast warnings

These casts are either safe, or we need to throw an exception --
ClassCast is as good an exception as any.

Change-Id: I74026fee5004984bfc18d990a3b6fee68a1fb479
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoIntroduce checked sendMessage() method
Robert Varga [Tue, 18 Feb 2014 10:39:14 +0000 (11:39 +0100)]
Introduce checked sendMessage() method

This method send a message down the socket and makes sure that
negotiation fails if the message does not reach the peer for any reason.
Subclasses should use this method instead of talking directly to the
underlying channel.

Change-Id: I5b8201caef1c4ba655dad12fb139b054b9e75f06
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoCHange log level from warn to debug in ProtocolSessionPromise when connection attempt...
Maros Marsalek [Thu, 13 Feb 2014 08:32:24 +0000 (09:32 +0100)]
CHange log level from warn to debug in ProtocolSessionPromise when connection attempt fails

Change-Id: I933bb145fb8dfda19a98c60cda108da078eb93e5
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
10 years agoRemove deprecated API elements from protocol framework
Robert Varga [Fri, 7 Feb 2014 22:50:42 +0000 (23:50 +0100)]
Remove deprecated API elements from protocol framework

The use of these concepts has been deprecated in version 0.4.0, which
was released. The only in-tree user was netconf, which was refactored to
not to rely on these concepts, so bump the version to 0.5.0 and purge
the  code.

Change-Id: Ibf2195b51bf12ea99b8b21f3da322d666b103b5e
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoGet rid of NetconfMessageFactory
Robert Varga [Fri, 7 Feb 2014 22:15:56 +0000 (23:15 +0100)]
Get rid of NetconfMessageFactory

This removes the use of deprecated ProtocolMessageFactory and
ProtocolHandlerFactory. Just instantiate appropriate Netty handlers
instead.

Change-Id: I98b6424af0256483be21c92dfdbe4c0ddbac7a9d
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years ago[maven-release-plugin] prepare for next development iteration
jenkins-controller [Mon, 27 Jan 2014 20:51:03 +0000 (20:51 +0000)]
[maven-release-plugin] prepare for next development iteration

10 years ago[maven-release-plugin] prepare release master-tagforprepareonly-controller-bulk-relea...
jenkins-controller [Mon, 27 Jan 2014 20:50:53 +0000 (20:50 +0000)]
[maven-release-plugin] prepare release master-tagforprepareonly-controller-bulk-release-2-1

10 years agoMake AbstractSessionNegotiator react to exceptions
Robert Varga [Tue, 21 Jan 2014 20:14:58 +0000 (21:14 +0100)]
Make AbstractSessionNegotiator react to exceptions

While the SessionNegotiator is present on the pipeline it should react
to exceptions happening on the channel by failing negotiation.

Change-Id: I6571dc25f17c7afe8fa4e4eb58f70ad0bb3397a4
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoFixed inappropriate uses of log level INFO
Ed Warnicke [Sun, 19 Jan 2014 23:33:16 +0000 (17:33 -0600)]
Fixed inappropriate uses of log level INFO

This is done per the recommendation here:

https://wiki.opendaylight.org/view/Draft_Syslog_Level_Settings

Change-Id: I69bbe15d81ed49511f643fd4a8c0ad60f58a0c22
Signed-off-by: Ed Warnicke <eaw@cisco.com>
10 years agoMove protocol framework from BGPCEP project
Robert Varga [Thu, 16 Jan 2014 10:58:29 +0000 (11:58 +0100)]
Move protocol framework from BGPCEP project

This moves the current parts of BGPCEP protocol framework into the
controller project, eliminating the circular dependency forced by
netconf being resident in this project.

Change-Id: I7c8457ebaec5c261217587d60a95a7b35e473d1e
Signed-off-by: Robert Varga <rovarga@cisco.com>