Kency Kurian [Mon, 1 Aug 2016 09:41:58 +0000 (15:11 +0530)]
Added phyAddress field in InterfaceInfo
- Included phyAddress field in InterfaceInfo
- Set this field before returning InterfaceInfo
Change-Id: Id1011ced05801948071279b5aa0e125f8ffdfd46
Signed-off-by: Kency Kurian <kency.kurian@ericsson.com>
Tali [Sun, 31 Jul 2016 10:46:22 +0000 (13:46 +0300)]
Set split-horizon bit to ingress table for external ports
Change-Id: I9895f0657e1da6c798eb4d4842ce1a8a68d45a56
Signed-off-by: Tali <tali.ben-meir@hpe.com>
Sam Hague [Sat, 30 Jul 2016 10:33:41 +0000 (10:33 +0000)]
Merge "Fix and renable FlowBasedServicesConfigurationtTest tests"
Sam Hague [Sat, 30 Jul 2016 10:33:29 +0000 (10:33 +0000)]
Merge "Add support for physical network on flat/vlan provider networks"
Sam Hague [Fri, 29 Jul 2016 17:19:11 +0000 (13:19 -0400)]
Fix and renable FlowBasedServicesConfigurationtTest tests
Change-Id: I0170f91745fab8970cddcd82952495a39d843a3e
Signed-off-by: Sam Hague <shague@redhat.com>
Suraj Ranjan [Fri, 29 Jul 2016 11:46:22 +0000 (17:16 +0530)]
New Table ids in NwConstants.java
This review includes few new table ids in NwConstants.java file, so that
we can use these table ids globally across all module.
Change-Id: Iabf2389c22443560a3da21e17a498218723fe844
Signed-off-by: Suraj Ranjan <suraj.ranjan@ericsson.com>
Faseela K [Fri, 29 Jul 2016 11:14:38 +0000 (11:14 +0000)]
Merge "Addition of new table ids in NwConstants.java"
Suraj Ranjan [Fri, 29 Jul 2016 08:55:05 +0000 (14:25 +0530)]
Addition of new table ids in NwConstants.java
To keep all the table ids at the common place, adding few new constants
from CloudServiceChainConstants.java to NwConstants.java file.
Change-Id: Ie3091bfd263b4b7491972e83e900a701a9557a88
Signed-off-by: Suraj Ranjan <suraj.ranjan@ericsson.com>
Sridhar Gaddam [Fri, 29 Jul 2016 09:55:48 +0000 (15:25 +0530)]
Use short for the ServiceIndex constants
The ServiceIndex in the yang file is a short, whereas the serviceIndex
constants in the NWConstants file are defined as int. This patch updates
the constants accordingly.
Change-Id: I8ac56b551d19a806940c8e5c006c6b06b1c62b93
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Sridhar Gaddam [Fri, 29 Jul 2016 07:14:01 +0000 (12:44 +0530)]
Update NWConstants with IPv6 table-id and cookie
Change-Id: I334a433bfa8e6d40fad97d8f48f58399caf4b70b
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Faseela K [Fri, 29 Jul 2016 04:59:51 +0000 (04:59 +0000)]
Merge "Addition of new Table in NwConstants.java"
Sam Hague [Thu, 28 Jul 2016 22:38:49 +0000 (18:38 -0400)]
Fix and renable FlowBasedServicesConfigurationtTest tests
Test was failing because the cache was returning an interfaceState
object from a different test.
Change-Id: I675d731aaa45c80cd0fb0857ec892dead63fb0b5
Signed-off-by: Sam Hague <shague@redhat.com>
Sridhar Gaddam [Thu, 28 Jul 2016 10:40:44 +0000 (16:10 +0530)]
Add ICMPv6 nd_target match
Change-Id: I274079ed234beb2823e12c7fcaf19dc7418b33ad
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Tali [Sun, 17 Jul 2016 07:50:40 +0000 (10:50 +0300)]
Add support for physical network on flat/vlan provider networks
Change-Id: Ia7383eeb108ae295836f1ae9da091f4a88279beb
Signed-off-by: Tali <tali.ben-meir@hpe.com>
Suraj Ranjan [Wed, 27 Jul 2016 07:43:14 +0000 (13:13 +0530)]
Addition of new Table in NwConstants.java
This review includes addition of new Tables in NwConstants.java file so
that these constants can be used universally across all module.
Change-Id: Iecf3c7e3bca107f5d638c6ebf88ad5fbb2fb1f99
Signed-off-by: Suraj Ranjan <suraj.ranjan@ericsson.com>
Vishal Thapar [Thu, 28 Jul 2016 15:11:16 +0000 (20:41 +0530)]
Fixes build breakage caused by change 41849
Change-Id: I0072ffa3897d56682bc558bfb856cb11d4031c01
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
David Suarez [Wed, 27 Jul 2016 20:05:27 +0000 (20:05 +0000)]
Merge "Make ActionInfo immutable"
Sridhar Gaddam [Wed, 27 Jul 2016 14:10:38 +0000 (19:40 +0530)]
Increase max service-binding's to 7
With new services coming up and using the ServiceBinding framework,
the existing limit of 3 needs to be appropriately updated.
This patch increases the max-service binding value to the maximum
supported value.
Change-Id: I590d810b0f86a1d6be1acc3b7bd2537f3ddb996d
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
David Suarez [Tue, 26 Jul 2016 15:36:41 +0000 (17:36 +0200)]
Document method and format changes
Minor changes: Javadoc for a method and formatting changes. Remove an useless null assignment.
Change-Id: If6d3950e243284608af0537393b350557df50bd0
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>
Sam Hague [Tue, 26 Jul 2016 19:51:20 +0000 (19:51 +0000)]
Merge "Added Ipv6 source and destination match."
Sam Hague [Tue, 26 Jul 2016 16:33:14 +0000 (16:33 +0000)]
Merge "Modification in ResourceBatchingManager.java"
David Suarez [Fri, 15 Jul 2016 09:06:57 +0000 (11:06 +0200)]
Remove wildcard imports
Remove wildcard imports to comply with Open Daylight's coding
guidelines.
Change-Id: I124280cc006ffff63946dbf4963b76e22d30a659
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>
Suraj Ranjan [Tue, 26 Jul 2016 06:56:18 +0000 (12:26 +0530)]
Modification in ResourceBatchingManager.java
This change is done to support a change in netvirt that deals with
VPN Engine concurrency fixes.
Change-Id: I6e95549e17a500726fa1ce0c9d4812bcb58056fe
Signed-off-by: Suraj Ranjan <suraj.ranjan@ericsson.com>
Aswin Suryanarayanan [Tue, 26 Jul 2016 06:27:30 +0000 (11:57 +0530)]
Added Ipv6 source and destination match.
Change-Id: I7cd8d66e68a9ca32a3c9de5f90fa27b352dff8b3
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Michael Vorburger [Fri, 22 Jul 2016 23:44:45 +0000 (01:44 +0200)]
Remove static block from ResourceManagerUtils
These are usually not a good idea for anything but very trivial code -
just in case anything goes wrong within the static, it leads to hard to
find problems, because they'll occur during class loading instead of
when methods are called. See e.g.
https://git.opendaylight.org/gerrit/#/c/39715/ for an example.
On a separate note, it is also wrong to use e.getMessage() in a LOGGER.
Change-Id: Ic982aac97f0aa5c41da801ab0c35880cf5e7f2e2
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Sam Hague [Mon, 25 Jul 2016 13:18:39 +0000 (13:18 +0000)]
Merge "Fix icmpv6 matchbuilder"
David Suarez [Sat, 23 Jul 2016 07:19:42 +0000 (07:19 +0000)]
Merge "Checkstyle fix"
Sam Hague [Sat, 23 Jul 2016 00:16:05 +0000 (00:16 +0000)]
Merge "Checkstyle clean-up src/test/java "
Michael Vorburger [Fri, 22 Jul 2016 23:38:18 +0000 (01:38 +0200)]
Checkstyle fix
preparing for https://git.opendaylight.org/gerrit/#/c/41305/ with:
* Utility classes should have private constructor
Change-Id: Id38840d9d200a0fe98844aabcc95c8e75dd4274a
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Sridhar Gaddam [Fri, 22 Jul 2016 16:57:48 +0000 (22:27 +0530)]
Fix icmpv6 matchbuilder
This patch addresses a typo in matchbuilder and allows us to
program an icmpv6 flow specifying icmpv6-type/code value.
Change-Id: I693b2fdbe58acadff4ca1fa5403901b13dedf23e
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Suraj Ranjan [Fri, 22 Jul 2016 11:54:39 +0000 (17:24 +0530)]
MDSAL module sync-up
Providing a simple batching infrastructure
for modules that use MDSAL DataStores
Change-Id: Ifd8df37ef74b26d98da07d8a5c33c3ae93279e5c
Signed-off-by: Suraj Ranjan <suraj.ranjan@ericsson.com>
Sam Hague [Thu, 21 Jul 2016 18:28:14 +0000 (18:28 +0000)]
Merge "Modification in JUnit test case file"
Sam Hague [Thu, 21 Jul 2016 18:26:38 +0000 (18:26 +0000)]
Merge "Load config system files in etc/opendaylight/karaf"
Suraj Ranjan [Thu, 21 Jul 2016 15:30:08 +0000 (21:00 +0530)]
Modification in JUnit test case file
After few merges went in InterfaceManager module, JUnit test case for
vlanInterfaceConfigurationTest.java started failing. For Jenkins build to
pass commit https://git.opendaylight.org/gerrit/#/c/42216/ ignored those
test cases.
This review again considers those test cases and gives a fix to pass all
of them.
Change-Id: Id4d1e2d1dae99ff9d1ff5b3993117be12dc4ea38
Signed-off-by: Suraj Ranjan <suraj.ranjan@ericsson.com>
Sam Hague [Thu, 21 Jul 2016 14:37:02 +0000 (14:37 +0000)]
Merge "Increase max service-binding's"
Sam Hague [Thu, 21 Jul 2016 14:36:55 +0000 (14:36 +0000)]
Merge "ITM module sync-up"
Sam Hague [Thu, 21 Jul 2016 14:36:21 +0000 (14:36 +0000)]
Merge "Multilple fixes in InterfaceManager module"
Sam Hague [Thu, 21 Jul 2016 14:36:08 +0000 (14:36 +0000)]
Merge "Implementation files for resourcemanager bundle"
Sam Hague [Thu, 21 Jul 2016 14:33:39 +0000 (14:33 +0000)]
Merge "add MatchFieldType for tcp flags"
Sam Hague [Thu, 21 Jul 2016 14:33:16 +0000 (14:33 +0000)]
Merge "Multiple match support for nicira extension"
Sam Hague [Thu, 21 Jul 2016 13:26:11 +0000 (09:26 -0400)]
Increase max service-binding's
Change-Id: I7226117f066821860d3e5abcacb8be9bb299bb5d
Signed-off-by: Sam Hague <shague@redhat.com>
Michael Vorburger [Thu, 21 Jul 2016 02:27:07 +0000 (04:27 +0200)]
Checkstyle clean-up src/test/java
Required to be able to run (enforce) CS on src/test as well.
Change-Id: I0947ccdf24aee935c7899b47eb79215e868c9297
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Suraj Ranjan [Thu, 21 Jul 2016 10:31:23 +0000 (16:01 +0530)]
ITM module sync-up
Below review gives a fix for the following issue:
FIB and Routes are not re-written on TEP Changes
Change-Id: Ia628bac6e44bef4c3e44bd4cc136386143c126e9
Signed-off-by: Suraj Ranjan <suraj.ranjan@ericsson.com>
Suraj Ranjan [Thu, 21 Jul 2016 08:42:02 +0000 (14:12 +0530)]
Multilple fixes in InterfaceManager module
This review deals with following fixes:
1> VM Migration Flows are not installing.
2> Elan flows are not getting installed
3> Fix for live provisioning of neutron ports.
4> Ignored 3 test cases in VlanInterfaceConfigurationTest.java file.
Beacuse of one of the previous merges in InterfaceManager module, these
JUnit test cases started failing. Because of that all Jenkins build were
failing. Ignored for now and later will fix for the same.
Change-Id: Ibc8b3b7efb83a9b193ac3fd87b3061a02a84ab3d
Signed-off-by: Suraj Ranjan <suraj.ranjan@ericsson.com>
Vivek Srivastava [Thu, 21 Jul 2016 08:07:51 +0000 (08:07 +0000)]
Merge "Upstreaming MdSalUtil interal code changes to ODL"
echegow [Mon, 18 Jul 2016 13:52:03 +0000 (19:22 +0530)]
Support for same OF port Name across different DPN
Description: Dpnid is prefixed to the Parent Inte-
-rfaces(<dpnid>:<interfacename>) in the Interface
State Operational DS, that fixes issue of,if two
compute nodes are managed by a single ODL and both
define "eth1" as the interface for external
network, their entries will overlap and the
interface-state subtree will contain only one
entry.
Change-Id: I2bf4f4462d9b440e86523f15f3770aecd4059799
Signed-off-by: echegow <chetan.arakere.gowdru@ericsson.com>
karanrajsingh [Thu, 14 Jul 2016 11:26:55 +0000 (16:56 +0530)]
Implementation files for resourcemanager bundle
This change contains all the implementation files for resourcemanager.
Change-Id: I4278cc9cd121a9d32c48b8f83e1a3e7ff5965ec8
Signed-off-by: karanrajsingh <karan.raj.s.singh@ericsson.com>
HemaTG [Wed, 20 Jul 2016 06:32:58 +0000 (12:02 +0530)]
Upstreaming MdSalUtil interal code changes to ODL
Description :- Compared the MdSalUtil module between the internal code
base and ODL master and upstreaming the code that has not yet been pushed
to ODL master
Change-Id: I56fa1366f3154b2a870502d103a297995b9ba297
Signed-off-by: HemaTG <hema.gopalkrishnan@ericsson.com>
David Suarez [Wed, 20 Jul 2016 05:57:11 +0000 (05:57 +0000)]
Merge "Introducing Builders for FlowEntity & Co. beans"
Vivek Srivastava [Wed, 20 Jul 2016 05:15:01 +0000 (05:15 +0000)]
Merge "Changes in different modules"
Sam Hague [Tue, 19 Jul 2016 21:38:29 +0000 (21:38 +0000)]
Merge "Enabling interfacemanager-shell"
Michael Vorburger [Wed, 13 Jul 2016 17:39:21 +0000 (19:39 +0200)]
Introducing Builders for FlowEntity & Co. beans
I need this for tests I'm writing, and it seems like a good idea anyway,
for consistency with the YANG generated beans. (Doing all this recent
work on FlowEntity & Co. fixing equals() & hashCode() and toString()
etc. and now this, I'm starting to seriously wonder if all this stuff
shouldn't just simply also be YANG modeled... thoughts?)
Change-Id: Ie8b0e49f4c0e5dbdc6f7a59a58f09b32beda7ac1
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Sam Hague [Tue, 19 Jul 2016 18:20:35 +0000 (18:20 +0000)]
Merge "Monitor interval range change."
Faseela K [Tue, 19 Jul 2016 17:18:01 +0000 (17:18 +0000)]
Merge "Upstream : Performance Improvements"
Faseela K [Tue, 19 Jul 2016 15:16:24 +0000 (15:16 +0000)]
Merge "Avoid deletion for the interface while adding"
Faseela K [Tue, 19 Jul 2016 15:14:03 +0000 (15:14 +0000)]
Merge "Portname was dispalying somestring and now updating with actual port name from parentref"
shlomi [Sun, 17 Jul 2016 16:20:41 +0000 (19:20 +0300)]
add MatchFieldType for tcp flags
Change-Id: I76ba008dca37423f036987513d434245dea5307c
Signed-off-by: shlomi <shlomi.alfasi@hpe.com>
Suraj Ranjan [Tue, 19 Jul 2016 11:27:55 +0000 (16:57 +0530)]
Changes in different modules
This commit deals with upstream changes in ITM and Interfacemanager module
that was done for bug CSC cluster reboot failure for 100 VPN scenario
Change-Id: I59930870823d01661b9c9c00d3d2440e4d30909a
Signed-off-by: Suraj Ranjan <suraj.ranjan@ericsson.com>
Abhinav Gupta [Tue, 19 Jul 2016 07:36:10 +0000 (13:06 +0530)]
Enabling interfacemanager-shell
few dependencies, etc. were missing to enable the shell bundle at runtime,
fixed it.
Change-Id: Ib8266e7131c31300860b88c9c368e7dbf0e1baee
Signed-off-by: Abhinav Gupta <abhinav.gupta@ericsson.com>
Dimple Jain [Tue, 19 Jul 2016 10:12:01 +0000 (15:42 +0530)]
Monitor interval range change.
Min interval value changed from 100 to 1000.
Change-Id: I3865d0ffba58b48cd76a58e0d8cd9f20ae318ede
Signed-off-by: Dimple Jain <dimple.jain@ericsson.com>
Suraj Ranjan [Mon, 18 Jul 2016 08:02:36 +0000 (13:32 +0530)]
Addition of new constants in mdsal
Following commit includes few additional constants in following file:
1> MetaDataUtil.Java
Change-Id: I96c47f0cd92986ae57479c3a7269b2e22e3b9c05
Signed-off-by: Suraj Ranjan <suraj.ranjan@ericsson.com>
Sharath Kumar V [Thu, 14 Jul 2016 09:27:01 +0000 (14:57 +0530)]
Portname was dispalying somestring and now updating with actual port name from parentref
Change-Id: Ie7b5043116a1ed1c16c3897de689c7dc220f8da5
Signed-off-by: Sharath Kumar V <sharath.kumar.v@ericsson.com>
Kency Kurian [Thu, 14 Jul 2016 09:26:34 +0000 (14:56 +0530)]
Upstream : Performance Improvements
IDMANAGER
- Allocating Id block to child pool when the pool is created
- The childPool entry updated for that particular instance for which lock
manager is not required.
- Added a check before debug log messages
- The id entry in parent pool is updated directly so lock manager is not
required
- Batching transactions where ever posssible
DATASTOREJOBCOORDINATOR
- The JobQueueHandler waits until a new job is enqueued. Earlier it used
to sleep for 1 second and again check for new jobs.
Change-Id: I5edfb2b6782bf3a752dc09702d11c1d80f7ff474
Signed-off-by: Kency Kurian <kency.kurian@ericsson.com>
Sam Hague [Mon, 18 Jul 2016 18:48:45 +0000 (18:48 +0000)]
Merge "Supporting DHCP as a service"
David Suarez [Mon, 18 Jul 2016 17:49:13 +0000 (17:49 +0000)]
Merge "Implement missing equals() & hashCode() for FlowEntity & Co."
Aswin Suryanarayanan [Mon, 11 Jul 2016 13:11:42 +0000 (18:41 +0530)]
Multiple match support for nicira extension
Modfied nicira match types to support multiple nicira extension matches
in the same flow.
Change-Id: Iae98334e977811c6dd0da09c0d8086e392e94966
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Michael Vorburger [Fri, 8 Jul 2016 22:13:06 +0000 (00:13 +0200)]
Implement missing equals() & hashCode() for FlowEntity & Co.
PLEASE CAREFULLY CODE REVIEW BY SEVERAL PEOPLE.
This is required to compare FlowEntity instances e.g. in tests. It's
also a Good Idea in general to have all "value" objects always properly
implement equals() & hashCode() ..
The MoreObjects2 is just a novel pattern I came up with for how to keep
equals() implementations short and concise.
Change-Id: I269bec061b1f8baf1caf36bcb0a46aef7100569f
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
D Arunprakash [Thu, 14 Jul 2016 09:34:14 +0000 (15:04 +0530)]
Avoid deletion for the interface while adding
Avoid deletion for the interface when add comes
from the same dpn.
Change-Id: I0fc66ba7943e0e83c8bfee57baa6ec1dacea63f8
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
Dimple Jain [Sun, 17 Jul 2016 11:05:25 +0000 (16:35 +0530)]
update even when original schema has no DPNs
Change-Id: Iee9692ce18445e7b9a7af08b75e581c892bd6f43
Signed-off-by: Dimple Jain <dimple.jain@ericsson.com>
epgoraj [Tue, 12 Jul 2016 11:12:08 +0000 (16:42 +0530)]
Supporting DHCP as a service
Change-Id: Ie282296c6e79abe7c49a1976100ec4f23cef4a7c
Signed-off-by: epgoraj <p.govinda.rajulu@ericsson.com>
Faseela K [Fri, 15 Jul 2016 05:36:17 +0000 (05:36 +0000)]
Merge "ArpUtil module sync up"
David Suarez [Thu, 14 Jul 2016 19:36:24 +0000 (19:36 +0000)]
Merge "Add convenience syntactic constructors and setter"
Abhinav Gupta [Thu, 14 Jul 2016 11:12:55 +0000 (16:42 +0530)]
ArpUtil module sync up
Change-Id: I0a948a75193f896426b403fc2dc50a866ebff7f8
Signed-off-by: Abhinav Gupta <abhinav.gupta@ericsson.com>
Faseela K [Thu, 14 Jul 2016 18:58:52 +0000 (18:58 +0000)]
Merge "IFM: InterfaceStatecache not updated correctly"
Michael Vorburger [Thu, 14 Jul 2016 17:08:44 +0000 (19:08 +0200)]
Make ActionInfo immutable
This subtly changes the behaviour of ActionInfo's actionKey. Please
carefully code review to make sure that no code anywhere assumes that
ActionInfo's actionKey gets automagically updated when FlowEntity's
getFlowBuilder() is used. From a pure Java development point of view
this seems logical, because you created the ActionInfo with a certain
actionKey given to the ActionInfo (or the default 0), and would not
expect it to just change by itself! (Or is it perhaps simply wrong to
have actionKey in ActionInfo all together, and this numeric index should
only be present in Action?)
Immutable objects are a Good Thing(TM). They are clear and thread safe
by default. All YANG gen. objects are immutable, and created by
*Builder, for a very good reason. We should make all hand-crafted beans
the same (or, ideally, better, just code generate them all as well, use
YANG, or using Google AutoValue; if YANG for simple Beans is somehow not
good; see
https://github.com/google/auto/blob/master/value/userguide/index.md).
This solves a specific problem I ran into when writing tests, where I
found it very un-intutive that what looked like a "getter", the
getFlowBuilder(), would change objects. The new
ActionInfoImmutableTest illustrates the specific problem I ran into, and
which originally motived me to do this - but immutable beans is a good
idea generally anyway.
This also makes the intention of the code in these classes much clearer
to read (the idea of the API as-is seems to be that always only either
String actionValues or BI bigActionValues is set; never both). Removal
of setActionKey is only consistent then.
Similar to what was already done in
https://git.opendaylight.org/gerrit/#/c/41524/ for InstructionInfo and
(Nx)MatchInfo.
Change-Id: Id0619b1ab6013bee53f392603acb85f9c4f18f7c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Thu, 14 Jul 2016 10:49:31 +0000 (10:49 +0000)]
Merge "ITM: Fix for tunnel ports not getting deleted."
Vishal Thapar [Thu, 14 Jul 2016 07:00:47 +0000 (12:30 +0530)]
IFM: InterfaceStatecache not updated correctly
1. CacheInterfaceStateListener is listening on CONFIGURATION DS changes
but it should be Operational as state changes are only made on operational
DS.
2.cache.remove() methods in InterfaceManagerCommonUtils use remove(key,
oject) to delete from cache. This is not an accurate representation of
deletes on DS where we only use key and leads to inconsistent behavior.
This fix changes those methods to only use key [interface name] to remove
from cache.
Change-Id: I322a3c5df9631cda2f5bdc4b46adf886a18bf88b
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Faseela K [Thu, 14 Jul 2016 06:31:52 +0000 (06:31 +0000)]
Merge "Utility method to get port termination point is added in HwvtepUtils.java"
Lorand Jakab [Wed, 13 Jul 2016 17:48:00 +0000 (12:48 -0500)]
Upgrade ietf-{inet,yang}-types to 2013-07-15
Change-Id: Ia762d7514d2426b3062a4e8d79ca7c9c5d35226f
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
Colin Dixon [Wed, 13 Jul 2016 17:23:15 +0000 (17:23 +0000)]
Merge "Upgrade ietf-{inet,yang}-types to 2013-07-15"
unknown [Wed, 13 Jul 2016 09:28:35 +0000 (14:58 +0530)]
Utility method to get port termination point is added in HwvtepUtils.java
This utility method is used in netvirt project
Change-Id: Iff23f3011d9c06a4f854ad22d653a8c822149899
Signed-off-by: Shashidhar R <shashidhar.raja@ericsson.com>
Vishal Thapar [Wed, 13 Jul 2016 07:57:11 +0000 (13:27 +0530)]
IFM: Add caching to optimize DS reads
This adds caching for Interface and InterfaceState to avoid reads on
Config and OperationalDS. For now it deprecates use of API that needs
InterfaceKey/InstanceIdentifier, a later cleanup activity should remove
all references to them.
This also adds a minor change to retry when submitting to DSJobCoordinator
Change-Id: Id46b191a8b73a95eecc8bf4c7996101986e13b17
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Faseela K [Wed, 13 Jul 2016 07:20:46 +0000 (07:20 +0000)]
Merge "Remove genius_checkstyle.xml fork"
Faseela K [Wed, 13 Jul 2016 07:02:11 +0000 (07:02 +0000)]
Merge "ITM: Dont use IdManager to generate tunnel name"
Sam Hague [Tue, 12 Jul 2016 18:51:32 +0000 (18:51 +0000)]
Merge "Added new matches and constants."
Michael Vorburger [Tue, 12 Jul 2016 14:19:19 +0000 (16:19 +0200)]
Remove genius_checkstyle.xml fork
Let's just use the shared one from odl-parent by inheritance. As almost
no
projects in Genius currently "enforce" Checkstyle anyway, this change
will just cause people to see probably slightly different Checkstyle
messages, but nothing on the build should fail.
Only resourcemanager-impl already enforced Checkstyle compliance to fail
the build. This change thus includes two CS related fixups to it.
Subsequently people, incl. perhaps me, may then start fixing more
projects, and turn on enforcement of Checkstyle in (more) Genius
projects, gradually.
Change-Id: I2c463d0dbe1572e58480a05562eabd502882bb1c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Vishal Thapar [Tue, 12 Jul 2016 12:46:48 +0000 (18:16 +0530)]
ITM: Dont use IdManager to generate tunnel name
This replaces call to IdManage to get Id part of Tunnel name with
generated uuid. IdKey becomes the seed for generated uuid. Tunnel
interface name is 'tun' followed by first 11 alphanumeric characters of
uuid generated.
Change-Id: I72b4663121df20839c6ac478a4f9bfd181285345
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Michael Vorburger [Fri, 8 Jul 2016 01:59:13 +0000 (03:59 +0200)]
Initializing bean List fields with empty lists make them easier to use
Change-Id: I9db3d3b49837ad5954b4df0ceedf2d4d8d9a0e34
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Somashekar Byrappa [Mon, 11 Jul 2016 14:19:17 +0000 (19:49 +0530)]
ITM: Fix for tunnel ports not getting deleted.
During deletion of transport zone, tunnel ports (on ovs) connecting to
l2gw devices were not getting deleted.
Root cause: During deletion of transport zone, there was a logic fetching
transport zone from config DS which actually doesn't exist.
Fix: Changed the logic to pass transport zone object from
TransportZoneListener to the worker.
Change-Id: I27dc944c43b83f1b6c17cf9ccbacc76201243ed4
Signed-off-by: Somashekar Byrappa <somashekar.byrappa@ericsson.com>
Faseela K [Tue, 12 Jul 2016 06:21:27 +0000 (06:21 +0000)]
Merge "JUnit test case for ITM"
Suraj Ranjan [Tue, 12 Jul 2016 04:29:06 +0000 (09:59 +0530)]
JUnit test case for ITM
JUnit test cases for TepCommandHelper.java
Change-Id: I8b37ec109781af4040336cce09f80879317434bd
Signed-off-by: Suraj Ranjan <suraj.ranjan@ericsson.com>
Faseela K [Mon, 11 Jul 2016 19:13:36 +0000 (19:13 +0000)]
Merge "Monitor Interval range changed. Min value 1 sec."
Dimple Jain [Thu, 7 Jul 2016 06:55:25 +0000 (12:25 +0530)]
Monitor Interval range changed. Min value 1 sec.
Change-Id: I44a52c36fbf4c7df13f4ff8c94cdab648e3ed0cb
Signed-off-by: Dimple Jain <dimple.jain@ericsson.com>
Vyshakh Krishnan CH [Mon, 11 Jul 2016 11:45:21 +0000 (17:15 +0530)]
Issue : BFD Session with 100ms interval is not getting established
Analysis:
As per ovs code & bfd rfc :
/* RFC 5880 Section 6.8.3
* When bfd.SessionState is not Up, the system MUST set
* bfd.DesiredMinTxInterval to a value of not less than one
* second
* (1,000,000 microseconds). This is intended to ensure
* that the
* bandwidth consumed by BFD sessions that are not Up
* is negligible,
* particularly in the case where a neighbor may
* not be running BFD. */
whatever Tx interval we configure less than a second, ovs is taking 1
sec.
So this is an expected behavior
Fix:
Since its an expected behavior no need of fix.
But we don’t provide options to configure Rx interval and decay min
rx in ODL, making changes just to pass enable and min_tx instead of
passing all the unconfigured parameters as well. And let the ovs
take the default min_rx and decay_interval.
Change-Id: I3dbcd466da98e00f716103678d1607e53ae8235b
Signed-off-by: Vyshakh Krishnan CH <vyshakh.krishnan.c.h@ericsson.com>
Lorand Jakab [Fri, 24 Jun 2016 18:23:51 +0000 (13:23 -0500)]
Upgrade ietf-{inet,yang}-types to 2013-07-15
Change-Id: Ifb05f4be62744715a6f2726416827d2db9e04670
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
David Suarez [Mon, 11 Jul 2016 08:44:35 +0000 (08:44 +0000)]
Merge "Making all these fields final and explicitly initialize to null"
David Suarez [Sat, 9 Jul 2016 09:54:09 +0000 (09:54 +0000)]
Merge "Getters of List<T> in Beans should not return List<? extends T>"
Michael Vorburger [Fri, 8 Jul 2016 02:07:50 +0000 (04:07 +0200)]
Making all these fields final and explicitly initialize to null
This makes the intention of the code in these classes much clearer to
read (the idea of the API as-is seems to be that always only either of
the 3 is set).
Removal of setInstructionValues in InstructionInfo is only consistent
then.
Change-Id: I4a0c540df0a4526f6ff326b5386260e291085275
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Fri, 8 Jul 2016 11:10:40 +0000 (11:10 +0000)]
Merge "Implement VxLAN-GPE tunnels in Genius"
Faseela K [Fri, 8 Jul 2016 08:57:35 +0000 (08:57 +0000)]
Merge "lport-tag interface map information lost during cluster reboot"