Claudio D. Gasparini [Mon, 16 Nov 2015 11:30:36 +0000 (12:30 +0100)]
BUG-4634: Prefix in withdrawn list is not ignored when announced in same msgUpd.
An UPDATE message SHOULD NOT include the same address prefix in the
WITHDRAWN ROUTES and Network Layer Reachability Information fields.
However, a BGP speaker MUST be able to process UPDATE messages in
this form. A BGP speaker SHOULD treat an UPDATE message of this form
as though the WITHDRAWN ROUTES do not contain the address prefix.
Fix by ingore common NLRI on withdrawn router
Change-Id: Ic9ebd3ce13f042f0dfcd2b28815442f8484add16
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Wed, 11 Nov 2015 12:23:46 +0000 (13:23 +0100)]
BUG-4622: Sending Empty Optional Attributes
Some of the parsers of Optional Attributes
only take in account the possibility of null
attribute and not of an empty one.
Fix by check it and dont parse them in case of
empty or null.
Change-Id: I34d801a001ed167e18646e228b9b9dfc03f7c882
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Robert Varga [Fri, 13 Nov 2015 09:41:16 +0000 (10:41 +0100)]
Remove unused dependency on yang-ext
Since the augmentation order is predictable now, do not depend on unused
yang-ext bundle.
Change-Id: I7e511a2f43f3f4e430ac6746a46ecefb13f10174
Signed-off-by: Robert Varga <rovarga@cisco.com>
Iveta Halanova [Wed, 4 Nov 2015 13:46:50 +0000 (14:46 +0100)]
Sonar warnings fix
Complexity issue - extracted switch into private method.
Renaming attributes and variables.
Removed unused attributes.
And other minor refactoring.
Change-Id: I335cb6ccce85b55e30c9537fe39f3dfb7754cc39
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Robert Varga [Wed, 11 Nov 2015 10:13:08 +0000 (11:13 +0100)]
BUG-4598: upgrade openconfig models
bgp.yang conflicts with another model in ODL. As it turns out,
this has already been fixed in OpenConfig 1.1.0 release. Update the
models to resolve the conflict.
Change-Id: Iede4e57116b81f5f8d835b60958ae3d87b59d897
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Iveta Halanova [Thu, 12 Nov 2015 12:15:54 +0000 (13:15 +0100)]
BUG-4593: BGP peer registry lookup false negative result
Added method into Ipv6Utill for creating Ipv6Address with uncompressed value.
Used when registring and deleting peer address.
Change-Id: Ifa96a3ec2f9f7cc3ee60329e888590647af40f64
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
(cherry picked from commit
0e5baad314c8374cc1d0dd4bcce9b2845d32da24)
Iveta Halanova [Wed, 11 Nov 2015 10:44:53 +0000 (11:44 +0100)]
BUG-4618: FS Redirect-IPv6 Extended Community
updated FS model for redirect-ipv6 ext.com and added to augmentations.
ref.: https://tools.ietf.org/html/draft-ietf-idr-flow-spec-v6-06#section-4
Change-Id: I65acbc4d47f9f0fe2375a8bcb920e1af83f08010
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Claudio D. Gasparini [Wed, 11 Nov 2015 09:46:12 +0000 (10:46 +0100)]
BUG-3771: Use sync on FutureChannels intead of await
"Await" waits until future has finished and throw execution
if thread was interrupted."Sync"" instead waits for this
future until it is done, and re throws the cause of
the failure if this future failed.
When closing the module, first we ensure that channel
has been closed and if it didn't fail we proceed
with next closures.
Change-Id: I1240d6fdb6986b8c30251206d8027db7b1a987fa
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Wed, 11 Nov 2015 02:03:52 +0000 (03:03 +0100)]
BUG-4617: BGP-FS redirect to next-hop IP action
-added yang data model for "redirect to IP extended communities"
ref.: https://tools.ietf.org/html/draft-ietf-idr-flowspec-redirect-ip-02#section-3
Change-Id: I80e74b884e87e2fdbcc0a9feb0ed5f873f8abbb7
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Wed, 11 Nov 2015 01:51:19 +0000 (02:51 +0100)]
BUG-4616: Update BGP-FS Redirect extended Communities
-added yang data model for redirect AS-4Byte
-added yang data model for redirect IPv4
ref.: https://tools.ietf.org/html/rfc7674
Change-Id: I4456f8bd7789f82418e852be74c010b1ee7038ee
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Thu, 5 Nov 2015 09:16:58 +0000 (10:16 +0100)]
BUG-4568: Introduce BGP Extended Community registry
-new Extended Community registry
-parsers registration is based on type/subtype
-serializers registration is based on "extened community case"
-added new "transitive" field for extened communities
-other "transitive" fileds are deprecated in yang data model
-deprecated type/sub-type value from yang data model:
-values are not filled in during a parsing
-values are ignored during a serialization
-make the extended commnity attribute parser non-extensible:
-BGP path attribute serializers are registred in
a specific order, an extending of the extended community
handler breaks the contract
-added missing IPv4 Transitive/non-transitive Route Target/Route Origin
extened communities
-updated Flowspec extended communities
Change-Id: I2818b20c069da362f60a716862421bb185bc8571
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Mon, 9 Nov 2015 11:07:28 +0000 (12:07 +0100)]
BUG-4594: ISIS PseudoNode NPE
NPE caused beacuse of wrong container.
Fix by: add missing is-is-router Container
which contains ISO System ID. Affecting
isis-node-case and isis-pseudonode-case.
Change-Id: I256c36ea980326bd39db4e8189ef092e20491c54
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Thu, 5 Nov 2015 15:20:10 +0000 (16:20 +0100)]
Remove gracefullyShutdown of EventLoopGroops
When instance is closed, boosgroud and workergroop
shouldnt be shutdown since they are required in case
of new instance created. If new instance is created
it will cause
RejectedExecutionException: event executor terminated
Change-Id: I58f9328140bc209aeafc7bfad14f883887447a59
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Thu, 5 Nov 2015 15:03:17 +0000 (16:03 +0100)]
Keep consistency under Optional parssword
Change-Id: Ib0f5901237ff370f7f9a6f143f1d9e8ec59405e9
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Vratko Polak [Fri, 6 Nov 2015 15:05:11 +0000 (16:05 +0100)]
Add openconfig-config to BGP feature dependencies
SingleFeatureTests in distribution jobs are failing.
Change-Id: Id6b6a55eb87519c27f63f6149f8dc505033c102f
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Milos Fabian [Wed, 23 Sep 2015 10:09:21 +0000 (12:09 +0200)]
BUG-4197: BGP OpenConfig Implementation
-BGP OpenConfig for ODL BGP RIB and peer/app-peer configuration (config-subsystem) and vice-versa
*RIBImpl <-> Global
*BGPPeer <-> Neighbor
*BGPApplicationPeer <-> Neighbor (belonging to special neighbors grupup "application-peers")
-support BGP configuration module to BGP OpenConfig mapping:
*once configuration of a particular BGP config module is created, the attributes
are mapped to OpenConfig API, configuration is stored and written do configuration DS
*once configuration of a particular BGP Configuration module is closed, a stored OpenConfig DTO
is removed and deleted from configuration DS
-support BGP OpenConfig API to BGP configuration module mapping
-application is listening to the changes in BGP OpenConfig DS subtree:
*when a new data are created or modified, the new BGP OpenConfig DTO is mapped to
BGP config module, the DTO is stored and config module is written to
controller-config's Modules subtree.
*when data is removed, the DTO is removed from inner store and BGP config module is removed
from controller-config's Modules subtree.
Motivation: Simplify configuration of the main ODL BGP components (mainly in programatic way) in a most used use-cases.
Limitations: BGP OpenConfig Yang data model is composed for configuration of one BGP speaker, ODL may have multiple instances of BGP Speaker
The change brings a dependecy on netconf's sal-nectonf-connector ot BGP project.
Change-Id: If245bd54d844bd9965637c83f382e82c6a5b9a53
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Tue, 3 Nov 2015 06:36:45 +0000 (07:36 +0100)]
Remove duplicate class
Remove duplicate and unnecesaries classes
Change-Id: I5835cb41ef3dfd881478b5ed93930c9cc87cf066
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Iveta Halanova [Mon, 2 Nov 2015 11:26:19 +0000 (12:26 +0100)]
BUG-4552: Enhance LS-SR - discern protocols
Updated yang model and decoding methods.
Corrected and extended unit tests.
Change-Id: I4cb8e7ba18ebce2962d4a5155e910f1292d57174
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Iveta Halanova [Thu, 29 Oct 2015 10:59:13 +0000 (11:59 +0100)]
Utilizing MplsLabel
Applied in BGP-LU and BGP-LS SR
Change-Id: I0736a96a71a2aca06bf9645df4fdf9b3afa967b9
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Iveta Halanova [Mon, 2 Nov 2015 14:48:48 +0000 (15:48 +0100)]
Sonar minor issues fix: modifiers
Change-Id: Idc6504dc7e95f64452a9c3e11f60690bbec36168
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Claudio D. Gasparini [Fri, 30 Oct 2015 14:01:01 +0000 (15:01 +0100)]
BGPCEP MD5 Password Fix
Password were checked in case if null
but not in case of empty.
Fix by creating an Optional from password where in
case of null or empty will be absent.
Change-Id: I67033deeccd5f634a73d941d0c3da23e8dfb644d
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Iveta Halanova [Fri, 30 Oct 2015 14:47:14 +0000 (15:47 +0100)]
Sonar issues fix: LS, FS
added final modifiers, solved complexity by extracting switches
to private methods, removed not used attributes.
Change-Id: Iab11adafac0b2519a5d07b26d638e8265ac6d0ff
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Milos Fabian [Fri, 30 Oct 2015 10:43:07 +0000 (11:43 +0100)]
BUG-4557: Fix BMP initial config files
-reconnecting strategy belongs to dispacther configuration
-add expected protocol framework capability in bmp's "features.xml"
Change-Id: Icde460db308d6882e742456df3829d9fb7cac683
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Fri, 30 Oct 2015 08:43:40 +0000 (09:43 +0100)]
Bug-4534: Fix yang model
remove an unexpected comma causing "line 124:13 extraneous input ',' expecting {'}', SEP, IDENTIFIER}"
Change-Id: Ia3dc19bdf95e3450b89bdcc00f33ad6898a55b67
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Wed, 28 Oct 2015 14:57:49 +0000 (15:57 +0100)]
BUG-4545: PCEP SR- ERO/RRO codepoint configurable
Since we dont have IANA stablished code point for
SR- ERO/RRO subobjects, and there are new one
proposed by draft (ref) we made the code point
configurable, setting by default previouly used.
ref:https://tools.ietf.org/html/draft-ietf-pce-segment-routing-06
Change-Id: I2055f1cd6644ad1506cb6d2ceb05bcaf9f794dd4
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Iveta Halanova [Thu, 29 Oct 2015 15:04:16 +0000 (16:04 +0100)]
BUG-4447: BGP-LS SR extention
applied in LS YANG model
updated attributes parsers of types: link, node, prefix
unit tests correction
Change-Id: Ie6624360ce0947ac4f5523386c1700bb41f11565
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Milos Fabian [Wed, 28 Oct 2015 10:42:18 +0000 (11:42 +0100)]
BUG-4197: use yang-ext's augment-identifier
-make sure that generated java APIs for augmentation have
always the same name.
Change-Id: I859460ca6265a5e52148af22d45d638b4d54030f
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Jeff Liu [Mon, 3 Aug 2015 23:54:06 +0000 (16:54 -0700)]
make bmp session with reconnect strategy
Change-Id: Ia4a0bc455b0d920c13eb9d4e1804ff7d98e79b7e
Signed-off-by: Jeff Liu <bigdataops@gmail.com>
Milos Fabian [Sat, 3 Oct 2015 00:18:28 +0000 (02:18 +0200)]
BUG-4197: BGP OpenConfig SPI
Defines the APIs to track a BGP configuration modules status changes and
BGP OpenConfig data writers consumed as a service injected by config subsystem into
BGP configuration module.
The goal is to react on changes in the BGP configuration module instances - the configuration
modules are mapped to the OpenConfig BGP data model instances and kept in a datastore.
Change-Id: Ic38d5049d4d7e2f51f05a0e44e28626fc48e7ab7
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Iveta Halanova [Tue, 29 Sep 2015 12:40:23 +0000 (14:40 +0200)]
BUG-4173: flowspec fixes
Fixed extraction of nodes in FSNlriParser.
Fixed model for extended communities and augmentation of bgp-rib route.
Corrected and simplified RIB support destination processing.
Unit test correction.
Change-Id: I3ddd1424703eb1e7f4a3506eeb4c02f641753452
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Iveta Halanova [Thu, 29 Oct 2015 10:50:14 +0000 (11:50 +0100)]
BGP-LU mpls-label replacement
Change-Id: Ifca9ba8f21dde71808360a4c5504ba4ef8739de7
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Iveta Halanova [Thu, 29 Oct 2015 13:21:24 +0000 (14:21 +0100)]
FS configuration
Change-Id: Ic52e2927572ce129775e81fce06e7a60338b86c1
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Claudio D. Gasparini [Mon, 26 Oct 2015 18:20:51 +0000 (19:20 +0100)]
BUG-4531: Error channelFactory set already
When we change the MD5 password we see
IllegalStateException: channelFactory set already.
Fix by setting only once the channelFactory, according
the case, MD5ServerChannelFactory when MD5 instead of
NioServerSocketChannel.
Change-Id: I5d02b1a3e325f1cd47099ee13397d141105969a3
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Iveta Halanova [Wed, 28 Oct 2015 10:10:29 +0000 (11:10 +0100)]
BUG-4447: BGP-LS SR extention: new YANG module
Change-Id: Icdf09f2303fc93b48c558efb9359698bec3f0d00
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Claudio D. Gasparini [Wed, 28 Oct 2015 09:48:09 +0000 (10:48 +0100)]
Update Node Flag TLV
Update Node Flag TLV based on last RFC
ref:https://tools.ietf.org/html/draft-ietf-idr-ls-distribution-12
Change-Id: Ia371c77780355709d65ebb9943a5b8a3fc488543
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Mon, 26 Oct 2015 09:26:35 +0000 (10:26 +0100)]
BGP Logs improvement
Logs in LocRibWriter and EffectiveRibInWriter were not
providing useful information, therefore they are mnodified.
Change-Id: I3ee623d287debf33a12c704b031c11d5fe0f5bad
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Fri, 23 Oct 2015 13:49:21 +0000 (15:49 +0200)]
BUG-4063: Deprecate vs-tlv
Deprecate vs-tlv, Vendor Information TLV should be used instead.
Change-Id: Ie14a44647dcd83d09460061acce56143917eb54f
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Tue, 13 Oct 2015 14:34:04 +0000 (16:34 +0200)]
BUG-3778: Next Hop needs to be specified in each extension
Since each NextHop need to be specified for each extension,
we need to enforce users to register his corresponding handlers.
Thus a new registerNlriParser method is created with NexHop
handler and NextHop classes which are handled, as a new parameters.
Previous registerNlriParser method is deprecated.
Change-Id: I7aca6dbc679bf146e9333e7f2d2c9affb75808e8
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Wed, 21 Oct 2015 15:11:42 +0000 (17:11 +0200)]
BUG-4490: onTransactionChainFailed return null transaction when closing
Karaf, causing NPE.
Check if null transaction is received from onTransactionChainFailed
Change-Id: Iece7abee96d7e4eb94960b173341ff2d56c8e170
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Tue, 20 Oct 2015 09:09:35 +0000 (11:09 +0200)]
BUG-4197: Use "revision-date" along imported modules
-avoid yang data modules version mismatch
Change-Id: Ifff049a580e0a536e78c935e1d40db8b598d50cb
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Thu, 22 Oct 2015 08:04:57 +0000 (10:04 +0200)]
BUG-4438: When delete a route from the app RIB transaction chain brokes
When deleting routes from app RIB, transaction get broken, therefore
some routes keep stored in DS.
Fix by indentify type of modification applied under
routes in ApplicatioPeer and apply correct write transaction
instead of use 'put' with any of them.
Change-Id: Ia7ad615d5290ec4deed0cdadfcd0d0f64c99cc52
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Iveta Halanova [Thu, 15 Oct 2015 09:05:54 +0000 (11:05 +0200)]
Refactor BGP session
refactored attribute, parameter, method names
Change-Id: I9840f65d7d52637cdf4e063642281c26edb22e50
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Iveta Halanova [Thu, 15 Oct 2015 09:44:01 +0000 (11:44 +0200)]
Sonar warning, refactor: AbstractNumericOperandParser
Change-Id: If19f82f959997f75c676bf8935117965f61ec4ae
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Jeff Liu [Fri, 11 Sep 2015 20:47:59 +0000 (13:47 -0700)]
BUG-4328: Update BMP implementation according the draft version 15
1. Implemented route mirroring bmp message parser/serialize and wired up to Bmp monitor module thru bmp activator
2. Extended stats report bmp message to include type 9 - 13
3. Extended peer down bmp message to include reason 5
4. Added JUnit tests for route mirroring bmp message including both parser and serializer
5. Added Junit tests for bmp monitor handling bmp route mirroring message
Change-Id: I4dd8442b4cb1f08576ae0f51c10480e9f6ff2797
Signed-off-by: Jeff Liu <bigdataops@gmail.com>
Milos Fabian [Wed, 23 Sep 2015 09:53:42 +0000 (11:53 +0200)]
BUG-4197: BGP OpenConfig API
BGP OpenConfig yang models as defined in https://tools.ietf.org/html/draft-ietf-idr-bgp-model-00
Defines yang data model for configuration and managing BGP.
Added "odl-openconfig-extensions" Yang data model to support missing AFI/SAFI
Change-Id: I1a59a1c36f6f81b94058cc201115174e41fdfc8b
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Iveta Halanova [Fri, 9 Oct 2015 13:34:30 +0000 (15:34 +0200)]
BUG-4364: data change counter transaction chain
to avoid logging spam
Change-Id: Ia59091f71edfb69d0fd3860086634112c4de0226
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
(cherry picked from commit
e6cdc776146d60ff8c33c12eedda930d8bf03e4d)
Claudio D. Gasparini [Mon, 14 Sep 2015 14:10:55 +0000 (16:10 +0200)]
BUG-139: PCE-triggered State Re-synchronization Procedure
Trigger resync
- RPC Trigger resyng
- Send Upd Message with SYNC Flag for LSP set to 1
- RPC Trigger resync Lsp
- Send Upd Message with an LSP object containing a PLSP-ID
of 0 and with the SYNC flag set to 1
Change-Id: I5642eb57426df739858359c0c1fe004ca339ef98
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Mon, 14 Sep 2015 09:02:58 +0000 (11:02 +0200)]
BUG-139: PCE-triggered Initial State Synchronization Procedure
- Support of PCE-triggered state synchronization
- create Rpc to trigger Initial Sync
- Test PCE Trigger initial Sync w/o Incremental sync
- PcepRpcServicesRoutingTest updated
Change-Id: I2c9bae691b695c49ec7866bf888364703345a5eb
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Fri, 11 Sep 2015 12:43:38 +0000 (14:43 +0200)]
BUG-139: Incremental Synchronization Procedure
- In case incremental syncronization is available, PCC will only
synchronize the delta ( Changes on LSP Database that occured
since session went down and during session reestablishment).
Therefore is not required PCE Purge LSP.
-ref: https://tools.ietf.org/html/draft-ietf-pce-stateful-sync-optimizations-02#section-4.2
Change-Id: I085906ea9c9a5cd0d8850834fea060342be4213e
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Tue, 6 Oct 2015 07:36:50 +0000 (09:36 +0200)]
BUG-4415: ISIS Area ID might have variable length
-fixed encoder to fit ISO NET Address ID pattern
Change-Id: I7f8a9311c3437c27e49751a1cd872d4efd687e78
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Tue, 11 Aug 2015 06:30:03 +0000 (08:30 +0200)]
BUG-139: State Synchronization Avoidance Procedure
-PCC node persistance:
-keep node in topology when session goes down and
syn. avoidance was enabled (PCE is aware of LSP DB version)
-PCC node retrieval:
-load node when session goes up again and if PCE or PCC
propagate LSP DB version number in Open msg.
-set LSP DB version number
-if PCEP session is sync-avoidance-enabled, PCC send LSP DB version in every
report message, DB version number is kept in PCC node by PCE
-get LSP DB version number
-PCE (sync avoidance enabled) tries to get stored LSP DB version from topology's node and use it Open message
-skip synchronization
-if PCE and PCC LSP DB version match, synchronization is skipped, otherwise perform synchronization
-perform synchronization
-mark all LSPs as stale, PCC perform synchronization (unmark reported LSPs), remove LSPs that remained marked as stale
-ref.: https://tools.ietf.org/html/draft-ietf-pce-stateful-sync-optimizations-02#section-3.2
Change-Id: Idf7b3f29fac1c470d5fcae18b329a5b78f7ebbee
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Mon, 21 Sep 2015 14:59:18 +0000 (16:59 +0200)]
Bug-3904: BGP-LU extension integration
*integration with config subsystem:
-wired with service providers (parser, RIB support)
-initial xml config files
*karaf integration
-added labaled unicast bundle to BGP feature
Change-Id: I5793cea801989b0aa9b3e778bb812e9890400914
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Iveta Halanova [Tue, 6 Oct 2015 05:58:42 +0000 (07:58 +0200)]
Sonar minor issues fix
removed redundant final modifiers, magic numbers
Change-Id: Ied2cc7e567ab624cb6c0f0950442e6fb5b3fdf3d
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Iveta Halanova [Mon, 5 Oct 2015 13:21:14 +0000 (15:21 +0200)]
Sonar isses fix
final Util classes.
private constructor
log exception
Change-Id: Ie4fd89dc31974187d473d29e17122bffc41e5e51
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Iveta Halanova [Thu, 8 Oct 2015 13:15:40 +0000 (15:15 +0200)]
BUG-4370: BGP reconnecting client: channel initiation
initializing channel with new decoders and encoders instances.
Change-Id: Ia193ad558bc3f03a4c50f8868233f22dcbe31373
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Claudio D. Gasparini [Tue, 6 Oct 2015 09:19:43 +0000 (11:19 +0200)]
BUG 4409: Routes to be withdrawn ignored.
Routes to be withdrawn ignored when UPDATE contains both
WITHDRAWN ROUTES and NLRI fields. RFC4271 specify that
an UPDATE message MAY simultaneously advertise a feasible route and
withdraw multiple unfeasible routes from service.
Change-Id: I77c810ed7ddb1eda55021ddd05414198f66ec7ec
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Iveta Halanova [Wed, 30 Sep 2015 11:40:17 +0000 (13:40 +0200)]
BUG-4381: flowspec next_hop length
zero-length next_hop in mp_reach made acceptable.
Change-Id: I6287228a058631685da34e0bf6bddb92f88f1e1d
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Milos Fabian [Mon, 5 Oct 2015 19:00:43 +0000 (21:00 +0200)]
BUG-4415: fix ISIS area Identifer encoding
-area identifier might have a length == 1,
this case was not treated properly
Change-Id: I0831871876121f75adc7f5860ba9e2e688f537ed
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit
a3941f9235f7bd5ebb8fee40064a9a9d86688e25)
Claudio D. Gasparini [Mon, 5 Oct 2015 14:02:00 +0000 (16:02 +0200)]
BUG 4413: Unit test "BGPDispatcherImplTest.testCreateClient" fails
Test testCreateClient/reconnectClient sometimes fails
because port still not free from previous tests.
Since NeverReconnectStrategy connections strategy is used,
when first attempt to stablish connection fails,
it throws throwable. As a solution we set the Socket on test
to be able to be reused.
Change-Id: I55d56ae2fbbf402924ba86a447ff518c329f5410
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Tony Tkacik [Sat, 3 Oct 2015 10:51:39 +0000 (12:51 +0200)]
Fixed incorrect prefix in uses augment.
Change-Id: I027adb3fffdd1aa938971ee8810e4b2c00de63bd
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Milos Fabian [Wed, 30 Sep 2015 11:31:34 +0000 (13:31 +0200)]
Fix yang models to be valid against new Yang parser
Change-Id: I4d8d0dcdcfc7695b3a2770ae9af416a54d9015c5
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Mon, 21 Sep 2015 14:55:23 +0000 (16:55 +0200)]
Bug-3904: BGP-LU RIB support
-implemented RIB support for BGP-LU routes
-support ipv4/ipv6 afi routes
-activator registers new rib support
Change-Id: I30762465979f2dbc82e778bf74a1906b3fdcab82
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Tue, 29 Sep 2015 06:43:33 +0000 (08:43 +0200)]
BUG 4070: Add missing policy database
Add missing policy database for new Internal Role defined.
Change-Id: Ifc7b29f7aa8417978db845d8544774e3b71ac8eb
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Mon, 28 Sep 2015 11:01:26 +0000 (13:01 +0200)]
BUG-4182: The "net" IS-IS node attribute is not filled by BGP-LS topo provider
In a case of link-state IS-IS node attribute, the area-id attribute is not
exported in IS-IS topology. Fix BGP-LS topology provider to fill in this attribute
as a "net" (iso-net-id).
Change-Id: I29dfc43590630a80eabad6433ef4a2f4371008b4
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Thu, 17 Sep 2015 12:06:58 +0000 (14:06 +0200)]
BUG-4070: Define new specific Peer role for App Peer.
Currently App Peer is defined a iBGP, therefore it doesnt
advertise to iBGP peers. Setting it as an RR, means that
it will advertise ORIGINATOR_ID and CLUSTER_ID, which
is undesirable.
Instead we create a new role for App Peer, INTERNAL.
Which will act as an RR-client but without advertise
undesirable fields ORIGINATOR_ID and CLUSTER_ID.
Change-Id: I1385158806838623824773c3031556fefa2a0262
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Mon, 21 Sep 2015 14:50:35 +0000 (16:50 +0200)]
Bug-3904: BGP-LU NLRI encoder/decoder
-implementation of new NLRI parser/serializers (Ipv4 and Ipv6 prefix support)
-junit tests
-bgp activator register handlers
Change-Id: Icf1fef1477d031bebc9a1247f9f4396c3cbb1a4b
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Mon, 7 Sep 2015 08:34:40 +0000 (10:34 +0200)]
BUG 4181: Fix PCEP Parsers/Serializers
Objects with more than one Ctype are not serialized
correctly.
This required update pcep-types.yang model, and register correctly
parser/serializers for:
-Bandwidth Object
-PathKEy Object /subobject
-EndPoint Object
Change-Id: I898c0521914eb4cb7f1a4a1349fdaf853101e3cf
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Fri, 28 Aug 2015 12:44:52 +0000 (14:44 +0200)]
BUG-4344: Expose PCEP local session characteristics
-Enhance PCEPSession API with method that returns local session characteristics in form of Open object TLVs
-might be useful for applications working on top of the session (specific behavior based on local session settings)
Change-Id: I7b7b864b4e9cdcdaaeeebca0341cfabc44e8df57
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Fri, 28 Aug 2015 12:53:20 +0000 (14:53 +0200)]
BUG-139: include LSP DB version number in PCC node
-PCC can send LSP DB version number in report (as a LSP TLV)
-augmented topology model to be able to keep LSP DB version as
a "global" variable in PCC node.
Change-Id: I7b1f76708ccfe7fafc798cd28180f279e00021b3
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Mon, 21 Sep 2015 14:28:36 +0000 (16:28 +0200)]
Bug-3904: BGP-LU yang model
-model prepresents BGP-LU NLRI as described in
https://tools.ietf.org/html/rfc3107#section-3
-labeled-unicast safi added
-BGP RIBs and Update message augmented to support BGP-LU
Change-Id: I0f33cd8c4e76fe7fcfdcaf8de322dea8dfa26acb
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Mon, 21 Sep 2015 14:24:00 +0000 (16:24 +0200)]
Expose IPv4Util method
-users might find this function useful, make it visible
Change-Id: I8b8d2316ff5861b83856567c995552f7fd41472c
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Wed, 23 Sep 2015 10:04:53 +0000 (12:04 +0200)]
Migrated yangtools.model to mdsal.model on RSVP
Change-Id: Ia12519f90225b662441e42932b3f9e933289ecbd
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Tony Tkacik [Tue, 22 Sep 2015 07:44:47 +0000 (09:44 +0200)]
Migrated yangtools.model to mdsal.model.
Change-Id: Ifec43bf573e9f859b352a22448a3099b2c14787d
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Claudio D. Gasparini [Thu, 20 Aug 2015 09:31:22 +0000 (11:31 +0200)]
BUG 2230: LSP TE
Extented BGP Linkstate to support LSP State TLV,
which is carried in the optional non-transitive
BGP Attribute "LINK_STATE Attribute"
-ref.: http://tools.ietf.org/html/draft-ietf-idr-te-lsp-distribution-03
Change-Id: Ifad8364c9c230ba75ae57a0d0442e7599d6244c3
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Thu, 27 Aug 2015 12:07:03 +0000 (14:07 +0200)]
BUG-2230: RSVP Initial Configuration, Features
-Initial configuration xml files
-RSVP features
-Include RSVP controller config to Artifacts
-Include features RSVP to Artifacts
Change-Id: I0be2b709f9727f963967959f628bcba3e2a94e73
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Iveta Halanova [Tue, 22 Sep 2015 08:02:48 +0000 (10:02 +0200)]
Sonar fix: final class
Change-Id: I3b7956d1f9631a1477cd8a51fb69ff99839aad53
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Dana Kutenicsova [Fri, 21 Aug 2015 13:36:05 +0000 (15:36 +0200)]
Refactoring: flowspec operands
Created a hierarchy of operand classes and removed
all operand-related code from FSNlriParser.
Change-Id: Ia41d22b16ab7e75fe9959df6a24b558721b0ff2f
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Claudio D. Gasparini [Tue, 22 Sep 2015 08:10:51 +0000 (10:10 +0200)]
Migrate Path-Key
Move Path-key from pcep-types to new RSVP Model,
path-key subobject can be carried on any RRO or ERO,
not only on reported route subobjects.
Change-Id: I59602173191bfc9cc8c7f9ead57099c72ccc5c8a
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Sun, 30 Aug 2015 12:05:12 +0000 (14:05 +0200)]
BUG 2230: RSVP Impl Extension Service
Change-Id: I5c7cbf0f205494dd6c0f05353d01a634431db8ed
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Sun, 30 Aug 2015 12:19:19 +0000 (14:19 +0200)]
BUG 2230: RSVP Activator
-Implementation of RSVP Activarot
-Test RSVP objects parsers/serializers
-Test RSVP ERO, RRO Subobject parsers/serializers Tests
Change-Id: I119ccd342c2871db540a6a59a57e77841857e907
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Sun, 30 Aug 2015 12:28:45 +0000 (14:28 +0200)]
BUG 2230: RSVP ERO Subobjects
-RSVP ERO Subobjects parsers/serializers
Change-Id: I921d6d165667a6290846ca8994aead0b0e6cee4c
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Sun, 30 Aug 2015 12:48:47 +0000 (14:48 +0200)]
BUG 2230: RSVP RRO Subobjects
-Implementation of RRO subobjects parsers/serializers
Change-Id: I06284a94601f0e022c59f323d6d38d47dcd4af3a
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Sun, 30 Aug 2015 12:43:19 +0000 (14:43 +0200)]
BUG 2230: RSVP XRO Subjobjects
-Implementation of XRO Subobjects parsers/serializers
-Implementation of XRO Subobjects parsers/serializers tests
Change-Id: Ib5e0eba605c0b9d5b433c59a51052cddf92baee0
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Sun, 30 Aug 2015 12:57:09 +0000 (14:57 +0200)]
BUG 2230: RSVP Subobjets
-Implentation of Label Subobjects parsers/serializers
-Implentation of ASNumber parser/serializer
-Implentation of Label Subobjects parsers/serializers tests
Change-Id: I348f241c73fa5928f20762356e45b7f55486a8a0
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Tue, 18 Aug 2015 17:13:36 +0000 (19:13 +0200)]
BUG 2230: RSPV Impl
-Implementation of RSPV parsers/serializers
Change-Id: I3619afc6ce40ee7644d54788b3ecedc183db2b8b
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Sun, 30 Aug 2015 13:11:31 +0000 (15:11 +0200)]
BUG 2230: RSVP SPI provider
-Implementation of RSVP Extension Provider
-Implementation of RSVP Extension Provider Tests
Change-Id: I10008c7f0ab798670f8c63e2866ab3f841de0cfe
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Wed, 2 Sep 2015 09:24:12 +0000 (11:24 +0200)]
BUG 2230: RSVP SPI POJO Tests
- Implement ServiceLoaderRSVPExtensionProviderContextTest Test
- Implement SimpleERORegistry Test
- Implement SimpleXRORegistry Test
- Implement SimpleRRORegistry Test
- Implement SimpleLabelRegistry Test
- SimpleRSVPObjectRegistryTest Test
Change-Id: Ib1268c0b1bce393c982491c3a321becd714fabb3
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Tue, 18 Aug 2015 17:16:56 +0000 (19:16 +0200)]
BUG 2230: RSVP SPI
-implemented common functionality for RSVP parsers/serializers
-implemented POJO
Change-Id: I3f3ae65776fd9c7487c7d684a6ce7bf728d036ed
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Wed, 16 Sep 2015 09:06:44 +0000 (11:06 +0200)]
BUG 2230: RSPV Model Update
Protection subobject can be only set on SRRO, SERO.
Change-Id: I963eb24abaec4d738b65beb90d0b25c5f51628c4
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Robert Varga [Thu, 17 Sep 2015 02:41:28 +0000 (04:41 +0200)]
BUG-2399: handle new ModificationTypes
The set of possible modification types has expanded with automatic
structural container lifecycle. Account for the new types in our
switch statements.
Change-Id: I7e6a78acfb87c9f5916ec83e7f10b9e271c24093
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Wed, 2 Sep 2015 14:13:30 +0000 (16:13 +0200)]
Migration to use MD-SAL Project
Change-Id: Ib5e2ef6e7e80ac749bea4dcd0e1b92ad518e9c13
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Milos Fabian [Thu, 27 Aug 2015 10:31:11 +0000 (12:31 +0200)]
Bug-139 Added new PCEP error values
new error values as defined in
https://tools.ietf.org/html/draft-ietf-pce-stateful-sync-optimizations-02#section-8.1
Change-Id: I251dde1407d43366f18903571820a87ecfe6b686
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Fri, 3 Jul 2015 14:30:56 +0000 (16:30 +0200)]
Bug-2230: Revision of module RSVP
Augment module with new definition of types related to
Resource Reservation Protocol as
-lsp-required-attributes-object
-lsp-attributes-object
-rsvp-te-objec
-bandwidth-object
-session-attribute-object
-rsvp-te-objec
-detour-object
-primary-path-route-object
-exclude-route-object
-metric-object
Change-Id: Ifb993bc9c9b38029b4be22bef04668ce9faae929
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Wed, 2 Sep 2015 08:24:42 +0000 (10:24 +0200)]
Bug-4230: Fix NPE in LSP TLV serializer
Change-Id: I6e1ede656d6db23f0e130d3ddc7cb37e1bc716e4
Signed-off-by: Milos Fabian <milfabia@cisco.com>
JMorvay [Wed, 2 Sep 2015 08:00:02 +0000 (10:00 +0200)]
Migrate netconf dependencies
Migrate integration tests netconf dependencies to new netconf groupId/version
Change-Id: I01a39601fb2d118e4eeb83f2ec2646ead4d682f7
Signed-off-by: JMorvay <jmorvay@cisco.com>
Robert Varga [Mon, 29 Jun 2015 12:12:31 +0000 (14:12 +0200)]
Use {{VERSION}} for feature repositories
With BUG-3671 addressed, we do not have to pass down properties to pick
up the versions. Also fix broken artifacts and bmp features.
Change-Id: Ic3abe22ab98b0c2d7e72833db65959f500521d2d
Signed-off-by: Robert Varga <rovarga@cisco.com>
Milos Fabian [Thu, 20 Aug 2015 10:54:15 +0000 (12:54 +0200)]
BUG-2208: set "sync" and "create" flags
-when reporting on update to PCE set "sync" flag always true
-when reporting on update to PCE set "create" flag true
if tunnel is pce-initiated, otherwise set false
Change-Id: Ie7e3ba0ec107e6a2f816435f3df298176db1bb03
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Iveta Halanova [Fri, 7 Aug 2015 13:09:17 +0000 (15:09 +0200)]
BUG-2663: Support v6 in BGP flowspec
Yang model:
- separated ipv4 and ipv6 distinct component types
- removed component type
Created abstract parser with common functionality and two
parsers with specific functionality
Updated RIB support for ipv4, created new for ipv6 and moved
common functionality into abstract RIB support class
Registred parsers and support for afi-s
Updated, expanded and created tests for parsers.
Change-Id: I3e95f419b5685e29faf1ac95ad4b55e5c3e5ced7
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Milos Fabian [Wed, 19 Aug 2015 13:31:26 +0000 (15:31 +0200)]
Fix DOM MD-SAL dependencies
Change-Id: Id4b46f1a1f591918cba5c2cc58cf1cb727752aee
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Mon, 17 Aug 2015 14:37:33 +0000 (16:37 +0200)]
BUG 4138: Fix RROLabelSubobjectParser
Change-Id: I647c5b980d16a03ca010b5d632b5bea8414ff0e5
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>