Merge "Enforce checkstyle validations"

interfacemanager Organize Imports for Checkstyle compliance

Change-Id: I0b44d9f431065629b46987fc2f28caf8e89883bd
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Merge "TestableDataTreeChangeListenerModule with logging"

Enforce checkstyle validations

Checkstyle enforcement.

Change-Id: I061bb99afeabeefa887029aa67a72cf0bb1dcc64
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>

TestableDataTreeChangeListenerModule with logging

Change-Id: I700186eb135dfd641a6804838e9611547c679345
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Enforce checkstyle validations

Checkstyle enforcement.

Change-Id: I8ceb5e261a0e925c75237900c6cbf2c583cf173c
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>

Merge "BUG 7494 : Idmanager returns the same Id from the same pool for different threads with different id keys"

BUG 7494 : Idmanager returns the same Id from the same pool for different
threads with different id keys

Problem with concurrency in IdManager, such that two threads requesting Id
at the same time with different keys might end up getting the same key.
This is because of unsafe read of an in-memory  cached local Id Pool.

Also, added IdManager test cases for multiple threads requesting
allocated/ released Ids concurrently.

Change-Id: I3d8c0e921461c4ecc5d3ca4ed41b9d18fee9a725
Signed-off-by: Kiran N Upadhyaya <kiran.n.upadhyaya@ericsson.com>

Merge "interfacemanager Checkstyle compliance: variable names & line length"

Action redesign: implement equals() and hashCode()

Change-Id: Ie6e86ebac788492220419ed6e6beae6b04c59b1e
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Action redesign: migrate NICIRA ARP extensions

Change-Id: I64583a3f57028af371ff1f0c7a8cb2359c384501
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Action redesign: migrate nx_load_in_port

Change-Id: Ia3975bf642439cc33166613a5c2bfa8e2c58cf52
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Action redesign: migrate set_icmp_type

Change-Id: Id9c36b7967c33013b4e43c5f161f654d2ddd1a8a
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Action redesign: migrate set_{destination,source}_ip

Change-Id: I557ad1d1b79a224c5d4adc9b71c2b0aa00652165
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Action redesign: migrate move_src_dst_{eth,ip}

Change-Id: Idda8f0ee6b0ebb91514bb2562e483e47362fb973
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Action redesign: migrate set_{tcp,udp}_{dest,src}_port

Change-Id: I45da9e1d0c847b0f9b40cf06636ae6a8db6596a6
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Action redesign: migrate set_udp_protocol

Change-Id: Id5d73de28e83f48840e591cea7a3240ddffb9147
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Merge "Action redesign: migrate punt_to_controller"

Merge "Action redesign: migrate set_field_eth_{dest,src}"

Merge "Action redesign: convert drop_action and nx_resubmit"

Merge "Action redesign: convert set_tunnel_{src,dest}_ip"

Merge "Action redesign: add typed getters in NxmOfFieldType"

Merge "Action redesign: always provide actionKey constructors"

Merge "Fix some minor problems."

Action redesign: migrate punt_to_controller

Change-Id: I62a64db77432c3ed7174181f12404a4d5f8db214
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Action redesign: migrate set_field_eth_{dest,src}

Change-Id: I77b1ed6a9e76d7b66b7cd43941ead50ee01482fb
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Action redesign: convert drop_action and nx_resubmit

Change-Id: Ie70eae9c06f36b57dcfc92933b7d816d033d15d3
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Action redesign: convert set_tunnel_{src,dest}_ip

Change-Id: I286d333ef38fb3b59b2a41af9e52c755c96776b8
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Action redesign: add typed getters in NxmOfFieldType

This is slightly inelegant since we can't replace getHexType() and
getFlowModHeaderLen() wholesale; we need to deprecate them in Carbon,
then replace them in Argon and deprecate the new functions, and
finally replace the now-useless new functions in Oxygen.

Change-Id: If63f9f732832e946ca43390cc6157840601d6da2
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Action redesign: always provide actionKey constructors

netvirt needs these...

Change-Id: I03da2ddfe18c4a2bdec3fba9fef33957743f7780
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Action redesign: ActionType.set_field_...

This patch switches MPLS labels, PBB ISID, VLAN and tunnel id handling
to the new model.

Change-Id: I18b621016f490bf84b4f68d1bfb78e14addc6030
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Action redesign: refactor ActionType.learn

Change-Id: I5ffe1d46dd1a88d25a466a976ab4cd03c532ea69
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Fix some minor problems.

* Logger name
* Fix exception log
* Name of attributes

Change-Id: I11e3d829fa735c8a804ce9df71fa91da312eb072
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>

Merge "Blueprint for LockManager"

interfacemanager Checkstyle compliance: variable names & line length

and also white space issues, and also remove some redunant "public" on
constructor of private classes.

this is incomplete, but it's a start. Let's get this merged, and I'll
continue on more like this another day

Change-Id: Ie4b73fc2f6ef8c6cf14dbd933a70619222972093
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Fix ActionRegLoadTest & ActionRegMoveTest failures

this happened following the upgrade of the xtendbeans test utility in
https://git.opendaylight.org/gerrit/#/c/50137/, because of
https://github.com/vorburger/xtendbeans/commit/b554dcf088646122bbcc6dbed83025023f32f7dc

Change-Id: I44fbda1ff45fa5f3d390f7b8af49dafd43398f8c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Blueprint for LockManager

Change-Id: I3e1a1a396520cfd01d725407024b19fff09cb26e
Signed-off-by: Edwin Anthony <n.edwin.anthony@ericsson.com>

Merge "Spec for ITM Tunnel Auto-config feature."

Merge "ITM POM minor clean up"

ITM POM minor clean up

moved all Testing Dependencies together

removed not needed <version> of org.apache.karaf.shell

Change-Id: I2f363becf04bc2903fb249af7070c94018349ce8
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Refactor NWUtil.toStringIpAddress

 + Replaces the current StringBuilder approach with the
   InetAddress.getByAddress() method that is 1) faster and
   2) IpV6 compatible.

 + This method is not used anywhere (yet), but it will.

Change-Id: Ife5fa781542a8465626d8a6bc2feb6d66cfa62b6
Signed-off-by: Miguel Perez <francisco.miguel.perez@ericsson.com>

Merge "Replace dlux with dluxapps features"

Merge "Use batching in interface Delete path"

Spec for ITM Tunnel Auto-config feature.

1. Added specification document for ITM Tunnel Auto-config feature.
2. Linked spec to specs/index

Change-Id: I1f7afb9ea91cb00ad118bd11aa3d4f7c61a21798
Signed-off-by: Tarun Thakur <tarun.t@altencalsoftlabs.com>

Replace dlux with dluxapps features

Renaming is due to DLUX project split.
Also, replacing yangui feature with yangman, new, redesigned and restyled
application.

https://wiki.opendaylight.org/view/Weather#Rename_some_odl-dlux-.2A_features_to_odl-dluxapps-.2A

Change-Id: I4cfeef30c7e83820ef628831c9a2ff6fb2622421
Signed-off-by: Daniel Malachovsky <dmalacho@cisco.com>

Action redesign: add regression test for ActionType.learn

Change-Id: I1403cad670c2f0f8c60efbf69da38e2006d211d0
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Use batching in interface Delete path

Interface delete path is still not using batching which has performance
issues in a scale setup.

Change-Id: Ifb8f54786405c93bdee3357d625881cf1671255e
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>

Merge "Allow Nicira Extension Actions in BoundServices"

Merge "handling idmanager csit intermittent failures"

Allow Nicira Extension Actions in BoundServices

Change-Id: I91531d00dad320efba3737c3dff661dc57601604
Signed-off-by: deepthivv88 <deepthi.v.v@ericsson.com>

Bug 7450 : suppressing unnecessary warning logs

* check to remove unncessary alivenessmonitor warn logs while packet
in handling

Change-Id: Ie592618dbf2b1db6d1891b111b14db04c01272eb
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@ericsson.com>

Merge "Moving interface-manager CLI utils to use cached entries"

Merge "Bug 7419 : Ids from id pool exhausted"

handling idmanager csit intermittent failures

* Due to faster allocation/deallocation of ids, release id is not able to
find the idKey in parent pool ds which is being fixed by a latch.
* Fix NPE by throwing IdManagerExcepion if requested id range is not
available

Change-Id: I37312000019b6eb7826f10f19b9fa7b2695101a3
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@ericsson.com>

Tunnel States should not be added for non-northbound configured tunnels

Change-Id: Iec4a8f4af7ffb360618c074445607d5762ff93d6
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>

Bug 7419 : Ids from id pool exhausted

Observed that there were many threads waiting to allocate block of ids
from parent pool. Once a thread acquired lock it just used to update its
availableIdHolder with that block without checking if some other thread
has already updated the localPoolCache.

After acquiring lock, a check has been added to know if some other thread
has already updated the availableIdHolder/releaseIdHolder.

Change-Id: Id5550bb2a483d14572803f0e346f2209b9cb9bcc
Signed-off-by: Kency Kurian <kency.kurian@ericsson.com>

Moving interface-manager CLI utils to use cached entries

Description : vlan:show and vxlan:show commands in interface-manager were
doing a read from datastore, when the entries are available in cache
actually. Changing the utils to make use of the same, so that the reads
can be faster in scaled scenarios

Change-Id: Ia5f7cd262b892fafd3b74551e8e82a0b3a1b5720
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Merge "Handle duplicate tunnel on multiple dpns"

Merge "Update spec template"

Handle duplicate tunnel on multiple dpns

If same tunnel port name shows up on multiple dpns, it is wrongly assumed
to be a case of VM Migration, which only applies to VM ports. In case we
get any such ports, first check on which DPN user configured it. Retain
interface-state entry for the port that is create on the DPN as configured
by user.

Change-Id: I95dab0a36fd1d033747fd887a4fea4a648da04aa
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>

DataStoreJobCoordinator super minor LOG related performance fix

LOG statements, especially trace(), should not do object creation, and
in this particular case, it seems not necessary to transform the Set to
an Array to a String... Set has a suitable toString, so not sure why
this was thought to be necessary; it should be just fine like this.

PS: Found while staring at DataStoreJobCoordinator for async test
infra.. I still can't complete make sense of what this class really
does! (Thus nor how to sanely make it testable.)

Change-Id: I27593b5ca0a5afe1784be23bc49b3fc231aaee51
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Update spec template

Refer: https://git.opendaylight.org/gerrit/#/c/49459/

This also adds ToC to existing specs.

Change-Id: I26322d3b288fd8e422b9ee504d72ccdc6ced24c4
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>

InterfaceManagerConfigurationTest reformatting etc. so no warnings

Change-Id: Ifa17867b095f600f0e14b354d17d5f3d3f5ac36f
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Merge "ResourceBatchingManager code clean up and fixed bad LOG"

interfacemanager POM fixed - no *-impl bundles

Not sure what historically happened here, but obviously the
implementation bundles of other modules should never be direct runtime
dependencies.. only their *-api.  And for component tests, some impl may
be <scope>test dependencies.

Change-Id: I44afb68fa4db3d795cdb045b05f8c16d4a369d0d
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

ResourceBatchingManager code clean up and fixed bad LOG

PS: Found while staring at ResourceBatchingManager for async test
infra.. I still can't complete make sense of what this class really is
supposed to be good for, or what problem it really solves! (Thus nor how
to sanely make it testable.)

Change-Id: Ica12a5695647d7d228cbd4e885ee38943f91e642
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Merge "Cleanup for constants and other stuff."

DataStoreJobCoordinator fixed broken LOG.warn of root cause exception

unless there is a very particular reason why this is done in an unusual
weird style, which does not properly show the Exception root cause in
logs (noticed while investigating a failure of the
InterfaceManagerConfigurationTest), it's wrong.

Change-Id: Ic42b4c79b9e7afe69eb4e4e6c633bb899ed3b74c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Cleanup for constants and other stuff.

- Declare constants properly.
- Log exceptions.
- Local variables.
- Basic formatting.
- Replace Guava's Preconditions by Objects'
- Remove catching of NPE
- Adding more constants to improve readability

There is still a NPE catching that will be removed in a later patch in
which I'll simplify the way in which we call the RPCs (see line
204-206).

Change-Id: I5a2173a39245e7d65469d84cb2a71ef9e21fe1be
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>

Merge "Genius: Neutron Qos DSCP Rule support"

Merge "Add CacheBridgeRefEntryListener to provider"

Add CacheBridgeRefEntryListener to provider

Change-Id: I9aae46b46ed7da3a820ca97521d95af56bf25385
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>

flow entries for multiple subports not getting created

Description :Update of vlanmember interfaces is causing unnecessary churn
of deleting and adding back all the interfaces unnecessarily, even if
there is no attribute which is modified.

Change-Id: Ib2d3be95ce48e2d971b27a8ff6e11d113be532ef
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Merge "InterfaceManagerConfigurationTest remove BridgeInterfaceEntryBuilder"

Genius: Neutron Qos DSCP Rule support

Adds QoS as a new service and a new table is created for QOS DSCP marking.
DSCP set action to tos field of the IP header is defined newly.

Testing procedure:
1. When a port is associated with QOS policy having DSCP rule. OF is
polpoluated for table 90.

Spec Review Link:
https://git.opendaylight.org/gerrit/#/c/48949/

Result:
- traffic flows with the DSCP value configured in the port.

Change-Id: I52057973bae295ec2e5ea4aec392b4ddf906f1bb
Signed-off-by: P.Poovizhi <poovizhi.p@ericsson.com>

Merge "InterfaceManagerTestModule LOG InterfacemgrProvider close() Exceptions"

InterfaceManagerTestModule LOG InterfacemgrProvider close() Exceptions

Change-Id: I1099c834024d8deb5e230e7a656bce5ed7c5a6e3
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Use platform-specific line separators

This should allow the XtendBeanGenerator-based tests to run on Windows
too.

Change-Id: I5c9e5d79405f8fb9a1f5035ad5a259eb9342614e
Signed-off-by: Stephen Kitt <skitt@redhat.com>

InterfaceManagerConfigurationTest remove BridgeInterfaceEntryBuilder

apparently it's un-used - or is this a mistake, and it should be used?

Change-Id: Id241bec009aadc5f7f20c65396c06b1540ea3054
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Add isIpInSubnet utility API to NwUtil

 + That method is extracted from VpnUtil (netvirt). NwUtil.java is
   a more suitable place

Change-Id: Ie999d09aec188fb861254fc985a53a9bd925ac68
Signed-off-by: Miguel Perez <francisco.miguel.perez@ericsson.com>

Merge "Fix the JMXAlarmAgent"

Merge "Bug 7270 Duplicate remote Mcast mac entry in TOR ."

Fix the JMXAlarmAgent

- Declare logger properly.
- More generic interface.
- Fix lifecycle: registration and de-registration.
- Fix logging of exceptions.
- The ItmTunnelEventListener can still work even if the system couldn't
  initialize the JMX agent properly.
- Cleanup and formatting.

Change-Id: Iecea96b426c1e7b30868eebe124c34427bc06f9b
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>

Enhancing DataStoreJobCoordinaor logs

In scale testing I had encountered jobs that took a long time to compelete,
between 1 and 10+ seconds.

Adding a warm log line for every job that takes more then 1sec to complete,
in order to help us in the future to detect possible bottlenecks
or just plain bugs.

Change-Id: Id65e00f925267bf1a30112804322d9b359e308eb
Signed-off-by: Tomer Pearl <tomer.pearl@hpe.com>

Merge "Bug 7315: switch ActionOutput to Uri"

Blueprint migration for ITM

change-Id: If4a0a852893e2b6d88ec59e0ac88d0af7c2bb3ce
Signed-off-by: Edwin Anthony <n.edwin.anthony@ericsson.com>

Merge "Introduce DataStoreJobCoordinator counters"

Bug 7315: switch ActionOutput to Uri

It turns out the output action port really is a string, interpreted by
Uri; so the appropriate type is probably Uri instead of long (or
perhaps String if we want to avoid Uri in the external API).

Change-Id: Ia55734bb4c7656b18c76de123717ea148e8d882f
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Introduce DataStoreJobCoordinator counters

The changes related to Bug 7236: System unable to handle high
rate of src mac learning packet-ins

Change-Id: Ie051e7d3bc5aca15a06e3e2aa42a75dc786f252c
Signed-off-by: Olga Schukin <olga.schukin@hpe.com>

Cleanup unwanted exceptions in interfacemanager

Description : Fixing NumberFormatExceptions thrown by interfacemanager
when nodeConnectorId comes with reserved port keywords, for eg :
openflow:1:LOCAL instead of Integer port numbers

Change-Id: Ifa5b6d4924fe400345c8ac6ed71c1a7460191e29
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Merge "Bug 7220 :port updates are not getting reflected in Table 220"

Bug 7220 :port updates are not getting reflected in Table 220

Description : services-info DS was not getting cleared for interface-state removals
for default egress service, this will have impact when there is a change in the underlying port
number for the interface being bound

Change-Id: I63a105c673dba9f1e1d8e2a6e8b1c6d7e02cf650
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Merge "New match Reg4 type and temporary SMAC table definitions"

Merge "Refactor ActionType.nx_conntrack"

Merge "Deprecate ActionType.goto_table"

Merge "Refactor push/pop MPLS/PBB/VLAN actions"

Merge "Migrate ActionType.output to ActionOutput"

Merge "Migrate ActionType.group to ActionGroup"

New match Reg4 type and temporary SMAC table definitions

Changes required for Bug 7236:
- Implement the match type nxm_reg_4.
- Define new source mac tables ELAN_BASE_TABLE and ELAN_SMAC_LEARNED_TABLE

Change-Id: Ib1854b86b5fd95097adcf9b90f338fff5a91659b
Signed-off-by: Olga Schukin <olga.schukin@hpe.com>

Refactor ActionType.nx_conntrack

Change-Id: I187cbc444b996ce3574040745051e6aa7fcf89e6
Signed-off-by: Stephen Kitt <skitt@redhat.com>