Move config-parent to aggregator POM

More then one project in the mappingservice/ directory is hanging off
config-parent.  This commit defines it as a parent in the aggregator POM
mappingservice/pom.xml, so that common configration for all projects,
like checkstyle and coverage can live in a single place.

Change-Id: I9e04b707ca0dbdac756bdd212ebc55bc869ee802
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Bug 3661: Avoid storing mappings in config datastore when authentication
fails

Change-Id: Ia1a30e75514ecdcb96ee123a22fa22cbd1ef61e0
Signed-off-by: Florin Coras <fcoras@cisco.com>

Bug 3757: Temporarily remove IT from the build

Change-Id: I16d48fe514b90ca594040a96726807cefc647699
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Remove old Hydrogen CLI

Change-Id: I99c2abf7468f9c4aaf67ce03b42dde9cdd5fd686
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Expand RPC API example Postman collection

Change-Id: I87f0575f9fc11e15ba0e14f0bcbca0c67afa1cbf
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Remove mappingservice.implementation activator

Change-Id: I6f5087f62fb129786092639d663a6c41fc2f98f3
Signed-off-by: Florin Coras <fcoras@cisco.com>

Bug 3380: Fix MD-SAL prefix overwriting

The root cause of this bug was that the string representation for
maskable EID was just the base address, without the network mask.  This
commit adds the mask to the maskable addresses, and improves string
representation of LISP addresses in general.

Change-Id: I83d43ce41b5b88989c80bb3ac7a7e7fd5e1f225f
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Bug 3385: Update Application Data LCAF to latest draft

Change-Id: Ifa7c1fcd98058a3ca43927833034d43a0bdcfca7
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Bug 3150: Fix some serializers to add name

Current YANG models include a key for most list elements, but the
serializers were not updated to fill that in.  This commit fixes that.

Change-Id: I728f40b8621b0d9eb4db08ce131d4997017c713b
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Bug 3355: Type 10 LCAF hops stored in user provided order

Change-Id: I8cad90e632fee6b4ad6b07ac3cec211ee63b0fb7
Signed-off-by: Florin Coras <fcoras@cisco.com>

Bug 3112: Add SB registrations to MD-SAL datastore

Change-Id: I0dc44dd96a43fe5a104908192d7c7022d8889ffd
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Removing AD-SAL dependencies

Change-Id: I8df9f0076d9ed2882f05669c53e6b0ec72b98894
Signed-off-by: Florin Coras <fcoras@cisco.com>

Modifying yangtools versions to use 0.8.0

- This change is needed for the downstream SFC project,
  since this is causing SFC's version bump to fail

Change-Id: Ia7e392abd9d3053126b1bb5e3f8bfd15b031189f
Signed-off-by: Brady Johnson <brady.allen.johnson@ericsson.com>

Switching SB to config subsystem

Change-Id: I976057f23d2f032546b9153b4df2160e00c503e0
Signed-off-by: Florin Coras <fcoras@cisco.com>

Remove AD-SAL based northbound interface

The AD-SAL based Northbound interface was deprecated in Lithium,
removing it with this patch for Beryllium.  There is still some AD-SAL
cruft left, but we'll eventually be able to remove it.

Change-Id: I6d783919f0ed81e43373f268a34b3903caa7eba3
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Bug 3223: Fix adding DistinguishedName from RPC

The bug was caused by no string representation existing for
DistringuishedName, which is necessary for URI construction.  This patch
adds string representation to other all other LCAF types that were
missing it.

Change-Id: I72d49fa3b37e741c4f90baac5aa3bc5969679968
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Remove dependency on clusterdao

This is part of an effort to remove adsal dependencies. Instead of
clusterdao we use HashMapDb, as an in memory map-server datastore.

Change-Id: Iccf7eccefe83e36fbf98e819b88a6036f7a7d4cf
Signed-off-by: Florin Coras <fcoras@cisco.com>

Do not instantiate Shorts

Speed up comparison by not instantiating an explicit Short instace, but
use autoboxing, which should result in better performance.

Change-Id: I260bf69935c2712162cb42404806e664f41a0cff
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix a maven warning

We had a duplicate config-api declaration. The effects were bounded,
but removing one of them fixes a maven warning.

Change-Id: I13f04d24ce7c7a735875e9abd5d47a1baf4c8c80
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Fix southbound start/stop sequence"

Switch mappingservice implementation to config subsystem

As a first step, the RPCs provided by the mappingservice implementation
are registered through the config subsystem. However, for the time being
we keep the Activator, not to break consumers (e.g., southbound or
northbound) that depend on it. As next steps, we'll switch the
consumers, one by one, to the config subsystem and once the process is
complete, we'll remove the Activator altogether.

Change-Id: Id8ff8549acf9769e22752dafd1aba326578bd0f5
Signed-off-by: Florin Coras <fcoras@cisco.com>

Fix southbound start/stop sequence

Change-Id: I865b818fa188f174fef9eff6d00b4ea62b4aa4ed
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit b2dfb13a01f7a494c3844b8399fd07848d4051db)

Beryllium version bump

Change-Id: Ic13e9bbee5f14dc50770e4818c7c1f5511d4cbe1
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Fix openjdk8 build

Change-Id: I2a2e6852d6ecd2e3e0f8bd78f450999e6bae3c11
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit 2c75db6f2476d9a71d5bb9021050fb84add221e4)

Merge "Support for Neutron Ports"

Support for Neutron Ports

Signed-off-by: Vina Ermagan <vermagan@cisco.com>

Process RPCs to config data store

Change-Id: I156d1c71ae0a5afd670c9ba0a0b4e5bc50fc180b
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Activate enunciate only on JDK 7

Change-Id: Ie5ba98893e806591c07cf878e2ac725019b3e32a
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Support adding RESTCONF data to DAO

Change-Id: Ia31994d6d25891dfa7adedb62e785650ee733db8
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

RPC implementation for RESTCONF

This commit introduces support for RESTCONF RPCs, using the existing
ClusterDAO storage backend with the existing MapServer/MapResolver API.

Change-Id: Ia9cca576e9bf06e90b05a7400aa807a1d6b970d3
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Proper checkstyle excludes

Changing the source directory just to match on class names is the wrong
approach and makes the build take more time.  Use part of the class
that's fixed instead.

Change-Id: I0085dcbca48f9fac0b07fa104e593166358883df
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Merge "Add support for SourceDest LCAF"

Add support for SourceDest LCAF

Change-Id: I19a984ef199cf0aa29e32784e32de9693616386e
Signed-off-by: Florin Coras <fcoras@cisco.com>

Merge "Enforce basic checkstyle on mappingservice.*"

Enforce basic checkstyle on mappingservice.*

Odlparent checkstyle rules are too restrictive for us at this time, so
we're ignoring them.  Instead of doing that, this patch overrides the
odlparent checkstyle rules for the mappingservice.* bundles so that we
enforce at least some basic rules.

The commit also fixes some checkstyle issues that were discovered.

Change-Id: Ife358094b206fe1f7b70fef25dfb43c9cea403ca
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Bug 3021: Fix notification handling

This fixes the return types of LispSouthboundPlugin methods used for
sending LISP messages to avoid NullPointerExceptions in mdsal.

Change-Id: I0d5596da016917eee74bf9776914081464a4c4c3
Signed-off-by: Florin Coras <fcoras@cisco.com>

Fix SingleFeatureTest issues

Change-Id: Ieee2da67fd8e70443bb8206d531f7399b758e81b
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Fix typo in lfm-control-plane.yang

Change-Id: I6ec57501e9b8da574832a5a1f8b90a368d9411e9
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Switch from junit.framework to org.junit

junit.framework.Assert is depracated in favor of org.junit.Assert, so
stop importing the deprecated classes.

Change-Id: I8719bbfd11d52fa208ac5cf85e4f5f122c985048
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Fix/reenable last failing integration tests

Change-Id: Idbfd1cf4171509fd6920fa4ff0ba71856831049e
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Bug 2946: Make LcafSegmentAddr maskable

This also enables longest prefix matches with segment addresses.

Change-Id: Iaf2c626786e79482aa1983c5226c012529591542
Signed-off-by: Florin Coras <fcoras@cisco.com>

BUG-2944: Parse iid mask length in northbound key registration

Change-Id: I793fd37786c4c837f767f9c2352e33d43aecfeaa
Signed-off-by: Florin Coras <fcoras@cisco.com>

Prepare the YANG models for RESTCONF

This commit is in preparation of an MD-SAL based mapping database.  The
existing YANG model had to be modified in order to be useble for that
goal, and a new model was added to describe the new API.  The models
have been checked to pass pyang.  The implementation of the MD-SAL based
mapping database will be provided by another commit.

Change-Id: Idb1a31a00fa110f2a1c493672cb508f23cf5fad7
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Add support for Karaf shell lisp:addkey command

The plan is to extend the command in the future to accept arguments, but
for now it installs the key "password" for the IPv4 prefix 0.0.0.0/0
(all IPv4 EIDs).

Change-Id: I7f3657b2a9254ddc1ef638b0d9a65293ed191d05
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Remove subscribers when removing mapping.

Change-Id: I3c20903cef359bcb2128fe9c39836553f4412ceb
Signed-off-by: Florin Coras <fcoras@ac.upc.edu>

Merge "Add support for Karaf shell lisp:* commands"

Merge "BUG-2931: Avoid removing mapping key when deleting mapping"

Add support for Karaf shell lisp:* commands

This commit adds the necessary infrastructure to add Karaf shell
commands for the lispflowmapping project and adds the first command:
"lisp:mappings", based on the previos OSGi shell command "dumpAll".
The list of implemented commands and a short help can be consulted at
any time with "help lisp".

Change-Id: Iee6f430053c52dc4933ce920859ce03523dd05e2
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Merge "Bug 2871: Add support for IID mask-len"

Bug 2871: Add support for IID mask-len

draft-farinacci-lisp-lcaf-07 introduced a change for LCAF type 2
(segmentation) where the 2nd reserved field in the LCAF header becomes
IID mask-len.  Some LISP implementations set this field to a non-zero
value when registering mappings.  LISPflowmapping needs to be able to
serialize-deserialize this field in order to authenticate such
registrations.

This commit adds support for the above mentioned ser/des, however, it
does not implement support for IID masking.  It doesn't fully fix bug
2871 either.

Change-Id: I777e5bb5bcabc4dc7b558ee6eac89d88e0820d8e
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

BUG-2931: Avoid removing mapping key when deleting mapping

Change-Id: Ifb8b9f24143d10478bbc27474d3a8b777a54cd68
Signed-off-by: Florin Coras <fcoras@ac.upc.edu>

Add <relativePath/> to ensure Maven pulls artifact from Nexus

Needed by autorelease to be able to find and replace this value
prebuild.

Change-Id: I1381fbc9f0888649e154fc04a705ac50ebff55b5
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

BUG-2915: Add support to remove mapping through northbound API

This supports removing a mapping from DAO by means of a northbound REST
call. If the mapping had any subscribers SMRs will be sent.

Change-Id: I54a627adb1c9dc19ce4944134761979a308ded2a
Signed-off-by: Florin Coras <fcoras@ac.upc.edu>

Revert "Add odlparent relativepath relative to autorelease"

Per discussion on mailing list thread we have decided to revert this
change and achieve relative path updating via scripting in autorelease.

https://lists.opendaylight.org/pipermail/release/2015-March/001754.html

This reverts commit 2adbccd94292df19094abd1a026b8ea02f9fadfc.

Change-Id: I81bde8f79f24098ad4125f76cd2488182ba4c13e
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix merge failure to out of order patches

Change-Id: I2ec031ef19c3da4cefb1413075e049368be5d78c
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Merge "Rename static final variable 'logger' to 'LOG'"

Avoid Map-Register inconsistencies due to SMR handling exceptions

Catch exceptions raised by handling/sending of SMRs such that they don't
affect the processing of Map-Register messages.

Change-Id: I2614948a0416d16e47d2ab557a65dba78e98aa10
Signed-off-by: Florin Coras <fcoras@ac.upc.edu>

Rename static final variable 'logger' to 'LOG'

This commit makes Sonar happier.

Change-Id: I9be49fca7eaabe0f6ca876d0bb25773e7daedb20
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Remove old checkstyle configuration

Our parent pom had a checkstyle configuration, using the rules from the
controller project.  ODLparent now has centrally managed checkstyle
rules, so remove the definition from out parent pom, which makes it
smaller.

Change-Id: I0e841f219713dc8661f14770b26a3656ff397684
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Merge "Map-Reply returns longest prefix match instead of eid-prefix being requested"

Map-Reply returns longest prefix match instead of eid-prefix being
requested

As per RFC6830 a map-reply should return an eid-prefix with a mask
length less than or equal to that of the eid being requested.
This should be extended to return multiple eid records when overlapping
prefixes exist.

Change-Id: I27b0fb9fadee526ff053a3043d051426045035da
Signed-off-by: Florin Coras <fcoras@ac.upc.edu>

Bug 2888: Make lisp.smr config option default true

Change-Id: Ib46369b9cb65684f2a930396e1108f57fffd2185
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Do not instantiate Integers

Speed up comparison by not instantiating an explicit Integer instace.
Get hold of it once and use it as a constant. It has the further
advantage of using a JVM-wide-shared object (as it happens to fall into
the range of changed integers).

Change-Id: I57fb875a7ffb151e5782b3af844f20fc4e193fc7
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 2871: Added xtrsiteid flag to map-register header built by MapRegisterSerializer

Change-Id: I47edbba65d9fbb921c8281b2142254badc5d8177
Reported-by: Saurabh Chopra <saurchop@cisco.com>
Signed-off-by: Florin Coras <fcoras@ac.upc.edu>

Add odlparent relativepath relative to autorelease

Change-Id: I92ab6c0eef27db2cfedd6ec4c75bb655f0db5e03
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge "Add enhanced ELP RLOC processing in Map-Replies"

Merge "Remove OSGi distribution build"

Fix build

Change-Id: I9e7bc61abfddd45623f60a7208712cdf90d89136
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Remove OSGi distribution build

The OSGi distribution was deprecated in Helium (we only shipped Karaf
features officially) and is being removed in Lithium.  The distribution
that is being built right now is based on
org.opendaylight.controller:distribution.opendaylight:0.2.0-SNAPSHOT,
which is Helium based, so we're building a Helium distribution with
lispflowmapping artifacts from Lithium.

Change-Id: I2ccf40e0626f3bdcf1d818fadca70c1bdfd5158d
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Add enhanced ELP RLOC processing in Map-Replies

Not all LISP data plane forwarding elements undestand the ELP LCAF used
for service chaining.  One solution to this problem is to check the list
of ITR-RLOCs in the Map-Requests against the ELP hop list and return the
next hop in a separate, lower priority simple (IPv4 or IPv6 AFI) locator
record.  This commit introduces this functionality in the mapping
service.

The more complex cases of several ELP locator records with different
priorities in combination with this patch have not been given a lot of
thought, and may lead to unexpected results.

The feature can be controlled using the 'lisp.elpPolicy' configuration
file property, which should be edited in the etc/custom.properties file
of the karaf distribution.  The three possible values are: 'default',
'both' and 'replace'.  'Default' keeps the ELP unmodified, 'both' adds
the next hop as a simple IPv4/IPv6 entry, and lowers ELP priority, while
'replace' removes the ELP, and keeps the next hop only.

Change-Id: I8166ca53a33413c212fd1e91d2d111611589b416
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Switch to the standalone Neutron project

Change-Id: I7edeecaaee44cc31d9a7cfb53889d736e1db5447
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Remove unnecessary declarations from the parent

Some of it is declared in odlparent, other declarations are no longer
necessary.

Change-Id: Ib416a6ac7ee3d6b56e9832db6b8f2833d4ff7473
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Make feature tests work again

Change-Id: I281ccebc6686f82243c4086afe19a6f83dd2f9c3
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Remove unnecesary declaration of <prerequisites>

Using the <prerequisites> configuration in POM files is deprecated and
odlparent enforces Maven version using the maven-enforcer-plugin.

See:
http://jira.codehaus.org/browse/MNG-5297
http://jira.codehaus.org/browse/MNG-4840

Change-Id: I138df3c2b03fb8f0f88e7c559098c665b111ba7a
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Merge "Remove <repositories> and <pluginRepositories> sections"

Merge "Revert "Basic AD-SAL inventory service""

Revert "Basic AD-SAL inventory service"

This reverts commit 7e9fbe75c13692537c2b8151435c1e45223d79a9.

Since we want to remove all AD-SAL dependencies in Lithium timeframe,
remove the AD-SAL based inventory service that was committed for Helium.

Change-Id: Ibbe644b02c07ddc14ff5f4d4bebd08eeb8365af4
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Update upstream Neutron groupId

Change-Id: I73c46df916715187a6cc53e798b1b8fa87d8b100
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Merge "Remove AD-SAL dependencies from Neutron service"

Remove reference to xtend-lib-osgi

The xtend library is embedded in yangtools, so there is no need to pull
it anywhere. Remove the dependency declaration to reduce clutter.

Change-Id: I099da77a1278bc5d55424ce2dbef64f02a55d7cd
Signed-off-by: Robert Varga <rovarga@cisco.com>

Move Karaf distribution POM file to "best practices"

We introduce a new pom file with a <dependencyManagement> section
inclusing all lispflowmapping artifacts.  Since the "best practices" now
use different parent POMs for different parts of the build, this is to
avoid repeating the project artifacts in many files.

With this commit, our Karaf distribution has a very simplified POM file,
with the parent being managed in the controller project.  We only have
to specify our own dependencies.

Change-Id: Ibbe9e6baa4ce59c160cd704ccb2c3497bac89425
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Remove AD-SAL dependencies from Neutron service

Change-Id: Iebc5b3ccb3e83f4936df530a3fc58218c68fdf3d
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Remove <repositories> and <pluginRepositories> sections

It is recommended that developers and servers configure this locally via
settings.xml.

https://lists.opendaylight.org/pipermail/discuss/2015-January/004482.html

Change-Id: I82a92386d9edea078deb34e5e87941e23e65028b
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix 'critical' severity issues in Sonar

Change-Id: Iac42897d1aec5d9da09e975d829bdd6fcae88c50
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Move YANG model POM file to "best practices"

Turns out, this also solves our issues with the integration tests
(w00t!), so turn them back on.

It pays to follow best practices! ;)

Change-Id: I521ba89c396804895fc87a060a4920d05510ee90
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

BUG-1173: do not hard-code guava version

odlparent defines the version upstream, no need to repeat it here.

Change-Id: Ie0d4934f774a70cf97d6304e37e86b879905d51d
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix unit test coverage settings

Change-Id: Iea1cb56557c0f3401fb735088a1092223c375311
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Bandaid: fix build by sweeping issues under the carpet

Integration tests have been broken since upstream yangtools project
commit a50515f "Add marker interface Builder<T> to generated Builders".
Since no fix was found so far, this commit removes intergration tests
from the build to please Jenkins so that we can go on with development.

Integration tests are using commons.integrationtest from the controller
project, which has been deprecated recently.  It is likely we have to
rework our IT a bit.

Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Do not override Sonar options configured in Jenkins

These settings are controlled by the Jenkins job.

Change-Id: I916e97f6eae22f4ed4b3c28d810e26a304a965d3
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix .gitreview for master branch

Change-Id: I32846d6556827e5219233414bfe16c222bea2245
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix 'blocker' severity issues in Sonar

Change-Id: I63e393027535d1fec078f3f52382b84dbd9dbd16
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

POM cleanup

Change-Id: I912a2bdebffb0801619e854feb744f6cba96025d
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Set root pom.xml <name> for Sonar

As mentioned on the mailing list Sonar uses the <name> field of the
pom.xml that is passed to the mvn command as the name of the project in
Sonar. In most cases this is the root pom.xml file in a project. This
patch sets the name to the project shortname.

https://lists.opendaylight.org/pipermail/discuss/2014-November/004024.html

Change-Id: I29fb850f46d615e4f468cf76f61b01397485a6db
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Add version for xtend-lib-osgi in IT POM

lispflowmapping-develop-nightbuild-and-integration - Build # 403 failed,
because of an upstream change.  This commit specifies an explicit
version for xtend-lib-osgi in the integration tests pom file, using the
xtend.version property from odlparent, fixing the build.

Change-Id: Ie58ae291b9e5b0c1ce64b74efeafe1fef4bf0218
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Remove unnecessary version definitions

Change-Id: Ife58a877f51d62758baf2001699ee26d7703b666
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Remove unnecessary imports

Change-Id: I6a66881e5dba6dbb9b066d0e83a6c04a5f02fc7f
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Remove unnecessary version overrides in IT

Change-Id: I2e13f47f450738bfc074b714f4acf85140f5d24c
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Bug 2440: Fix mappingservice.implementation unit tests

Change-Id: I2271f8fb0c49d794ee1cd4a4472cc1b43adea3e5
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Add coding style checks

Run the maven-checkstyle-plugin during the build, using rules from the
controller project, which include:

  - No TAB characters
  - No trailing spaces
  - No redundant, unused or star imports
  - Long constants defined with upper ell: 'L'
  - No empty statements (standalone ';' semicolon)
  - If a class overrides equals() it must override hashCode()

These rules are applied to .java, .xml, and .yang files.  Rule
violations are reported on the console, but they don't cause the build
to fail.  This behavior should be changed in the future, when the
existing code base is cleaned up, so that no new violations are
introduced after that.

Change-Id: I552eb72e1ac4b96a4cf80a216a1638bb36d77821
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Mass remove trailing spaces

Change-Id: I50f41f7d6f42f813fbe2a01d4e056bbc2480b83c
Signed-off-by: Lorand Jakab <lojakab@cisco.com>