Thanh Ha [Sun, 3 Dec 2017 04:30:17 +0000 (04:30 +0000)]
Updated git submodules
Project: releng/builder master
ad3143474a1fff2f70d4a4068451488dd9cc0357
Merge "Use eval command to append mail options"
Use eval command to append mail options
Use eval to append mail options with the notify script. When the eval
command is used without escaping the variables causes wordsplitting.
Ref: http://mywiki.wooledge.org/BashFAQ/050
JIRA: RELENG-213
Change-Id: Ib36836a957e88c919eff954c9acc21f94e9f13bc
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Sam Hague [Sat, 2 Dec 2017 01:40:48 +0000 (01:40 +0000)]
Updated git submodules
Project: releng/builder master
545a57351081c06b1d6cc576a9ed64cbde3c96d0
Merge "Make robot report logs better"
Make robot report logs better
- use more specific name for each pybot iteration which
will help when looking at results via jenkins robot
plugin
- start creating the full single log file again. We
stopped doing this because our small 2G VMs could not
handle the large log files. But, we are now using 4G
VMs and it should be fine
Change-Id: I8bc6628544c9684a2527fc7c12f8a27d7df31983
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
Jamo Luhrsen [Thu, 30 Nov 2017 00:07:25 +0000 (16:07 -0800)]
Updated git submodules
Project: integration/test master
5b9e37523c30ae627f697d54cf66359c56376352
Change return code checker to be more clear
Should Be True '${rc}' == '0'
is more clear (to me at least) than
Should Not Be True ${rc}
Change-Id: Ie6196c269de0d22457b02a5590f9de6141df23f9
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
Victor Pickard [Thu, 30 Nov 2017 18:58:49 +0000 (13:58 -0500)]
Updated git submodules
Project: integration/test master
31d2963f8fe13f2dcfb0410e6e78ee82c9245845
Do not restart/cleanup OVS in init code
Do not restart/cleanup OVS on compute node during
L2GW CSIT init.
Change-Id: Iab6c2dd93331d4b048e0e732f58a0ea8d66f613c
Signed-off-by: Victor Pickard <vpickard@redhat.com>
Philippe Guibert [Fri, 1 Dec 2017 09:09:30 +0000 (09:09 +0000)]
Updated git submodules
Project: integration/test master
e9237072333be7e4c11eca415f363e468eba7e97
vpnservice-ipv6: fix calls in neutron port
When calling neutron port creation, the calls are internal and do not
refer to external libraries.
Change-Id: Ib8322a065cad3bd6682326d2a1e542b15a13b183
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Jamo Luhrsen [Fri, 1 Dec 2017 16:34:21 +0000 (16:34 +0000)]
Updated git submodules
Project: releng/builder master
d2728da8c27b3fa350c24308ff364f2a469596c7
Merge "Configure tep-ip for genius auto tunnels"
Configure tep-ip for genius auto tunnels
Config tep-ip for control and compute nodes
as needed for genius auto tunnels to work.
Change-Id: I6146bc0bfffeb35603c89a49a02dd2f5263df0f2
Signed-off-by: Victor Pickard <vpickard@redhat.com>
Thanh Ha [Fri, 1 Dec 2017 15:12:14 +0000 (10:12 -0500)]
Updated git submodules
Project: releng/builder master
832dc2bdf5c7012d8be8758b57ceb458ec8c9855
Revert "Use eval command to append mail options"
The original commit introduces a regression in our ability to send
emails to the correct mailing lists.
This reverts commit
ea26afb7d635a615547490e05a7aef2d9bcda265.
Issue: RELENG-70
Change-Id: If493d40462d12edba2913971ba145a3d2b4a75e9
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Michael Vorburger [Thu, 30 Nov 2017 23:52:55 +0000 (00:52 +0100)]
Updated git submodules
Project: openflowplugin stable/carbon
d9d4102ab215b42ed4630e2d2ad9539cd114e860
Fix possible transaction leak in StatisticsGatheringUtils
see https://jira.opendaylight.org/projects/OPNFLWPLUG/issues/OPNFLWPLUG-961;
5x transactions opened here which were not closed
Change-Id: I1d9983a257881a7618943f76a6780a14c4e97e82
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
bug-7826: Data validation failed for group-id
OPNFLWPLUG-858
Identified the root cause for issue TransactionCommitFailed for group during statistic collection.
Change-Id: I8fe639e6102629fb903689114c617e76a61d68db
Signed-off-by: sunilkumarms <sunil.g.kumar@ericsson.com>
OPNFLWPLUG-930 Inconsistent flow IDs between flows
in config and operational data stores
Change-Id: I4ee8787e163a6ab64a4574f0dc906c7c91a7d0b2
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Bump versions by x.y.(z+1)
Change-Id: I765b74e91d07f2b32ef5eb679ea04943844ba4e0
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Merge "BUG-9223:Remove hardcoded value of lldp interval" into stable/carbon
Merge "This patch implements ct-mark support in nicira extensions." into stable/carbon
BUG-9223:Remove hardcoded value of lldp interval
Cherry-pick changes from stable/boron
Addressed comments
Change-Id: Id4fe81e27663cf89af8d95be577826988deeb7fe
Signed-off-by: Jalpa Modasiya <jmodasiy@luminanetworks.com>
Fix possible NPE on ContextChainHolderImpl
- deviceConnected method
Change-Id: I7cbd8c3bb2a4d92ecdaa5fc541e01e3d8ac738b6
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
This patch implements ct-mark support in nicira extensions.
Specifically:
- support for ct-mark MATCH, including mask.
- support for ct-mark ACTION (set-field), but not including mask
This patch supports implementing ACL spec:
https://git.opendaylight.org/gerrit/#/c/60580
Change-Id: Ib828da39b4470e7172fe7028e8d3123fb184c742
Signed-off-by: Bertrand <bertrand.low@hcl.com>
Merge "Sort bucket actions" into stable/carbon
Do not try to close context with null deviceInfo
Do not try to lookup contextChain with null deviceInfo to prevent
NullPointerException.
Resolves: bug 9217
Change-Id: I8f5d860317375e20a7df9bb8ab5031af62c43936
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Sort bucket actions
Sort bucket actions by order when serializing them in
GroupMessageSerializer.
Resolves: bug 9216
Change-Id: Icc5ad3f8b533a9f660e0248efed1b158c52336cf
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Use HashedWheelTimer instead of item scheduler
Use HashedWheelTimer instead of items scheduler for scheduling the SLAVE
role sending to device and move this logic to device context, where role
management is done.
See also: bug 9089
Change-Id: Ia180b3d7704bd2096bfa0bee88c2e87da333cfaa
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Merge "Solves issue with two connections from one device." into stable/carbon
Terminate SLAVE task before sending role change
- Terminate SLAVE task in device context when role change is requested and
not after role change is finished.
- Do not send notification about role failed to set to mastership
service in case future was cancelled
- Do not retry sending role to device 42 times
See also: bug 9089
Change-Id: Ia784d3b682b8991fe7a471bbfc7462aebfa6d4ef
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Fix transaction manager closing.
- the event onTransactionFailed we properly closing chain and creating
a new chain
- changed writeOnlyTransaction to readWriteTransaction
- moved transaction manager to the common module
- topology manager using transaction manager instead of creating a
transaction chain for itself
- added control of unfinished transaction on close
See also: Bug-9038
Change-Id: Idadbb4ed0f4c61e7f80da5e2dbedbd80dece118e
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Fix TransactionChainManager IllegalStateException
- Make txChainFactory volatile
- Close failed chain only if is current
See also: bug 9038
Change-Id: Ie897c5356addaef3f180a96296f5dd38950f2fb3
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
Solves issue with two connections from one device.
See also:Bug 8723
Change-Id: I1e07eb590f285f9d6c1326b94ef5b159242c0757
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Fix context state comparison
Fix comparison of context state and atomic reference of context state.
See also: bug 8668
Change-Id: Ie001d913982dc1331d1bb418e3fc8c7208e4c52d
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Bug 8882 - With conntrack SNAT communication with PNF fails
Added support for load metadata action.
Change-Id: Ia1b0454a4aeccd9a04cecb59b50f516264bddb3e
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Close CSS registration in separate thread
Instead of sending initialization of CSS in separate thread,
do closing of registration in separate thread and only in case
we are closing the registration during initialization, to prevent
CSS freezes. Also, when closing CSS service, add checks for connection
state to prevent closing context when connection is already RIP.
See also: bug 8805
Change-Id: I0759f7913937c897f41899a87b699989cdfe4abc
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Fix context chain initialization and SLAVE change
- Merge ContextChain and LifecycleService
- Let ClusterSingletonService handle stopping of mastership services in
closeServiceInstance method
- Store cluster singleton initialization future and process it
synchronously in case we are closing
- Cancel device initialization future if we got timeout
- Handle initialization chain order in ContextChain instead of storing
each next phase in contexts
- Remove SLAVE task from scheduler in case we acquired SLAVE role
already
- Prevent adding exactly same auxiliary connection twice to list of
auxiliary connections in ContextChain
- When SLAVE role is obtained from cluster singleton service, notify
MastershipChangeListener about it
- Log exceptions from handshake as warning instead of error (as only
problem is that device gets disconnected and reconnected, what is not
critical)
- In case context chain is still closing and we receive new connection,
drop the connection and let context chain finish closing
See also: bug 8805
Change-Id: If14da19899087018c5e6cc42d195af43c1e89bfd
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Merge "Fix match extensions deserialization" into stable/carbon
Merge "Improve flow collection" into stable/carbon
Fix match extensions deserialization
Fix transformation of match extensions for different match types during
deserialization so they will not be lost during this process.
Resolves: bug 8836
Change-Id: If089a72759a26b764479e58ea112b3a1a062c90e
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Bump versions by x.y.(z+1)
Change-Id: I0576e16aabc016896b51ec4538b453e66da709c9
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Improve flow collection
- Delete all known flows synchronously
- Add boolean isTransactionsEnabled to TxFacade to determine if it was
initialized and initial submit was called
- Improve deletion of flows during on the fly statistics gathering (now,
each gathering have 3 states, INITIALIZATION, WORKING and TERMINATION
and behaves according to that)
- Fix possibility of statistics collection freeze when error occurs
during OF Java to OF Plugin model translation while gathering
statistics on the fly
Resolves: bug 7501
Change-Id: I74843d4536215c192ac43964634502430da1aa9a
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Solves compilation error
- due openflow java changes plugin run in compilation errors
Resolves bug:8788
Change-Id: I41f964260c216fe3ee417c9d874cb58177f4596d
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Fix NPE in ConnectionContextImpl
- When we receive port status message, in some cases nodeId can be null,
so when logging, get nodeId safely and in case it is null, just log
"null"
- When we are closing outbound queue, log value of nodeId or null in
case nodeId is null
Resolves: bug 8762
Change-Id: Ifda277fd298f7d30fd5e94f07a94e67813971029
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Revert "Remove lifecycle service from tx chain manager"
This reverts commit
5bbffc61f90c85d6360a73c5eab35e203f6f20fd.
Change-Id: I793f7448803519e0dcdd8c5446e555fd8d6dfa15
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Remove lifecycle service from tx chain manager
Resolves: Bug8748
Change-Id: I6e9f1d7dbdfbdcca5cd52c368985ba7d37310a74
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Merge "Report (TCP) port number for switches" into stable/carbon
Fix context chain closing
- Close and create EOS registration correctly when closing context
chain holder and creating context chain holder.
- Cancel running scheduled task on context chain holder termination
- Always remove device from DS when we was not able to propagate roles,
not only when we have this device already in context chain map
- Add toleration for adding context chains to queue
- Wait for registration of RPC services before fully granting mastership
for context chain
- Close transaction chain manager on device context close
- Remove unnecessary auxiliary connection gathering in device context
(because this was moved to context chain)
- Fix closing of TxChain when DeviceContext is closed when activating tx
chain manager but not enabling submit transaction (do not try to submit
data)
- Unregister RPC registrations on RpcContext close
- Do not close ClusterSingletonServiceRegistration during
ClusterSingletonService initialization, to prevent freeze of
ClusterSingletonServiceGroup, send it to separate thread
- Prevent propagating of connection closed event twice (add checks for
RIP connection state)
- Fix ignored tests
- Remove getter for table statistics boolean from DeviceContext and just
send it to DeviceInitializer
- Close all RPC contexts when RPC manager is closed
- Do not reschedule statistics one more time when context chain is
closed
Resolves: bug 8668
Change-Id: Ifa8c492486c17a73eccd760fc610a435ef6a42ed
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Report (TCP) port number for switches
Write also port number to datastore for OpenFlow switches.
Resolves: bug 2188
Change-Id: I15054b55907b4f15b1567b21f5fa2d35ad416579
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Fix "stale" state after controller disconnected.
See also: Bug 8411
Change-Id: If5bf24f34a87ef0a7d5514b1c655a42508889724
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Ensure that statistics gathering is terminated
Store current statistics gathering future for cancellation instead of
settable future, so we can cancel it when we need to (there is no point
in cancelling settable future other than preventing more statistics
running, but current in-progress statistics gathering will still try
to finish).
Cancel statistics gathering also when become slave.
Resolves: bug 8635
Change-Id: If221a34901b08f8923ae5321a51abd00f4b047b1
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Merge "Fix connection when slave role request is unsupported" into stable/carbon
Fix connection when slave role request is unsupported
- Allow the switch connection when OFPRRFC_UNSUP is received
- Set feature exception for getGenerationIdFromDevice RPC error
- Add unit test
Resolves: bug 7664
Change-Id: If8d7d045fb516f55346333cc7e60d0ccb2135efd
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
Fix port update
- Update yang models. Add grouping common port with mask.
- Use config mask in the PortConvertor and PortMessageSerializer.
- Update unit tests.
Resolves: bug 4747
Change-Id: If558fea34f86c026ca45ba2853107c2cd82c7f50
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
(cherry picked from commit
8d18002e59e2b7e7fca95e52d2cb4a75d1023117)
Merge "Fix 'INPORT' keyword in port field" into stable/carbon
Merge "Fix onSwitchIdleEvent echo request-reply xid" into stable/carbon
Fix 'INPORT' keyword in port field
- also fix NPE in serialization by using wrong port number
Enumeration from opeflow java yang files is correct used keyword 'IN_PORT'.
Openflowplugin with the wrong translation (getString instead of getName) used the
keyword 'INPORT'. This fix use the correct name from enumeration but allow use
the legacy 'INPORT' keyword for next release.
Also prevent to throw NPE by using wrong keyword in port field.
Change-Id: If8b3d301d73169fd158a546a233928ab0c65d1c3
Fix: Bug 2095
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Merge "Bug 8253: Set-Field can not accept vendor extension fields." into stable/carbon
Fix onSwitchIdleEvent echo request-reply xid
Solves: Bug-4422
Change-Id: I879e9e6aaf560da486767a68a7e2f015db5a7d95
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Merge "Write port statistics when needed" into stable/carbon
BUG-8607: Replace logger and log by LOG
Replace logger and log by LOG to follow the
OpenDaylight recommendations [1].
[1]
https://wiki.opendaylight.org/view/BestPractices/Logging_Best_Practices
Change-Id: I77ef621927ba05417736d24c18c6659c7f504917
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>
Make create-parents in bulk-o-matic not required
To make bulk-o-matic input working like before, make create-parents
to default to true to use original functionality with same input
as it was before patch that introduced this new flag.
Change-Id: I89ee7d299f0ade62bd6859209c537528e5728aa7
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
(cherry picked from commit
d13de0fa783ab11e33a58417007be0d855be84ae)
Merge "Bug 8293: Add table writer to bulk-o-matic" into stable/carbon
Merge "Bug 8647: remove odl-dlux-core as artifact POM" into stable/carbon
Merge "HeaderDeserializer and HeaderSerializer for codecs" into stable/carbon
Merge "Close OpenFlowPluginProvider during shutdown" into stable/carbon
Bug 8647: remove odl-dlux-core as artifact POM
odl-dlux-core is used in dependency management as an artifact POM, but
it isn’t. Removing the declaration is fine since the actual dlux
dependencies specify the version to use.
Change-Id: I83598feb8175d674616a3a3f25c0d52ca1739664
Signed-off-by: Stephen Kitt <skitt@redhat.com>
BUG 7332: Cleanup queue after switch disconnect
In context of Helium Plugin, ingress queue in
ConnectionConductorImpl is not closed, which results in the memory
leak.
Change-Id: I3e69721114f887f8b71c22224a2a834d69a64a43
Signed-off-by: Vijay Daniel <vijay.daniel@ericsson.com>
Merge "Optimize port status and hello message handling" into stable/carbon
Close OpenFlowPluginProvider during shutdown
- Call close method on OpenFlowPluginProvider during shutdown
- Close all created managers, thread pool and timer during shutdown
- Remove unused notification service
- Remove warning when unknown property is loaded on start (because of
recent FRM changes)
Resolves: bug 8598
Change-Id: Ib5a4f84ea1fa0c957b90ef216346eb85aec81ad0
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Stop reschedule stat. after device disconnected
Resolves: Bug-7940
Change-Id: Ida42676ec5bf6f06fb47837c0532878976eed442
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
HeaderDeserializer and HeaderSerializer for codecs
Implement HeaderDeserializer and HeaderSerializer for nicira
match codecs.
Resolves: bug 4862
Change-Id: Ia3dbbf622460ecfa3b6a2c48e94e432294a08c0e
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Write port statistics when needed
When we receive port statistics reply, sometimes in OF 1.0 we do not
have parent node written to datastore, so now when OpenFlow version is
1.0 then write those port statistics with parents if needed.
Replace gathering missing port statuses with PORT_DESC with registry
that will collect missed port statuses when on MASTER.
Resolves: bug 8239, bug 6908
Change-Id: I47468cb37fa59a68cfa89efeb7e5c4191e07039d
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
(cherry picked from commit
acf2b5630ca4460bac2343bccc72f37da12f6e0d)
Add Nicira extension support for matching IPv6 Src/Dst
This patch implements the necessary support for programming a reg_move action
(i.e., move:NXM_NX_IPV6_SRC[]->NXM_NX_IPV6_DST[]) with IPv6 source/destination
headers. It will be used while constructing OVS flows that auto-respond to ping6
requests addressed to a router-interface.
Change-Id: I64757f55ed1d30a12217c4a5aadaa3f56572ab0e
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
(cherry picked from commit
7d00489cd0b6014b58b68fc84c533f6d33fc8dc1)
Fix auxiliary connections
See also: Bug-6755
Change-Id: If4964c1a0f07bfdd8104c7254f4b4484fd42d81e
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Optimize port status and hello message handling
- Reduce number of created threads and close used threads.
Change-Id: Ib37268be5e7982c64b95da9abffa6db78ef4edc1
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
Merge "Fix logging of exception in HandshakeListenerImpl" into stable/carbon
Merge "Fix no reserved xid" into stable/carbon
Merge "Bug 8497 - Provide config knob to disable the Forwarding Rule Manager reconciliation" into stable/carbon
Merge "Add missing convertors for OF1.0 actions" into stable/carbon
Bug 8497 - Provide config knob to disable the Forwarding Rule Manager reconciliation
Resolves: Bug 8497, Bug 7957
Change-Id: Ib798d9282f019e0c8dd520c15d8794678ee9af3d
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Merge "Remove unused method" into stable/carbon
Merge "Bug 8535: Fix IPv6 OXMHeader Mask issue" into stable/carbon
Merge "Though shall not use org.eclipse.tycho's osgi.. you don't even need it!" into stable/carbon
Merge "Adding Reason Attribute to FlowCapableNodeConnector" into stable/carbon
Add missing convertors for OF1.0 actions
- SetDlSrc
- SetDlDst
- SetNwSrc
- SetNwDst
- SetNwTos
- SetTpSrc
- SetTpDst
- SetVlanId
- SetVlanPcp
Resolves: bug 8527
Change-Id: I9c7c97804d077e1089fe92b3465c826a43da6a33
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Bug 8253: Set-Field can not accept vendor extension fields.
The various Set-Field actions are identified by their field type
which defined in OpenFlow Specification. It will be failed if we
pass a vendor extension field to Set-Field, that means Set-Field
can not accept those vendor extension fields. There are products
that hope Set-Field can accept those vendor extension fields, so
it will make sense to make Set-Field extensible.
Change-Id: Id25456d2b9008ec260ce81d3a459bdc471a69e49
Signed-off-by: Li guosheng <li.guosheng6@zte.com.cn>
(cherry picked from commit
4b3a659ef96aaca99c0fbd17ccdf9411c2e12da3)
Bug 8535: Fix IPv6 OXMHeader Mask issue
When programming an OVS flow to set an ipv6_src/dest as
an action field (i.e., set_field:2001::1->ipv6_src), the
current implementation is not checking the Mask and is
including the Mask (even for a full ipv6 address) in the
OXM header. Because of this, switch is rejecting the flow
with the following error.
"decode error: OFPBAC_BAD_SET_MASK. OXM header 0:32768:26:1:32
includes mask but masked OXMs are not allowed here"
This patch addresses this issue by checking the prefix and
including the prefix only if applicable.
Change-Id: Ieffdc7f0e74e9418156171d85a28c24dd336527c
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
(cherry picked from commit
85285353da4c397a9b4ad0e67ba137cddb0c4740)
Bump versions by x.y.(z+1)
Change-Id: Ifa2f0fe59824706e9bc78b3fab1b2830335b8bee
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Adding Reason Attribute to FlowCapableNodeConnector
-The reason attribute is added to the FlowCapableNodeConnector Yang
Modelling.
-The PortStatus contains reason when notification comes from Switch such
as ADD, UPDATE, DELETE.
-This reason flied will help in distinguishing between different
PortStatusMessages
-Also changed TestCase File to include Reason for test cases
Change-Id: If61fc1ba0afbe56cbf5382ab3997c67166989819
Signed-off-by: GauravBhagwani <gaurav.bhagwani@ericsson.com>
(cherry picked from commit
9af18614bfef2d765b61564096afe2c8a360bbb5)
Though shall not use org.eclipse.tycho's osgi.. you don't even need it!
see https://git.opendaylight.org/gerrit/#/c/51592/
see https://git.opendaylight.org/gerrit/#/c/51520/
There are 2 remaining use of org.eclipse.tycho in openflowplugin's
drop-test and test-provider, something related to console commands...
could we ask you if you would mind to change that to use
the Karaf Console API instead? Or delete those? ;)
I'll like to block use of dependency tycho in odlparent ASAP.
Change-Id: Ifccbd7f6ec463487e83aa546701cdffd1c7accb4
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Merge "Add timeout for device initialization" into stable/carbon
Fix logging of exception in HandshakeListenerImpl
Exception was not logged, so in case initial processing failed and
thrown exception, there was no exception actually shown in log. To
properly log exception, it needs to be either passed as second parameter
or inserted into message via logger string interpolation ({}).
Change-Id: Ic76f6d20588e34837994b50509603d994009b705
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Merge "Remove device without master from DS." into stable/carbon
Merge "Bug 8408 - Deserialization exception in logs when NAT flows are added." into stable/carbon
Add timeout for device initialization
Sometimes during device initialization, switch starts ignoring all
messages from plugin, and so we ended up with Future that waited
indefinitely for switch response until Karaf was restarted.
Add timeout that will prevent happening of above issue.
See also: bug 8401
Change-Id: I90c6c8b53f6a6e879b6d9f93c259a2cbf09f71d3
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Remove device without master from DS.
See also: Bug-6459
Change-Id: I6d27681b60a75df173a49742885c75c16d691b26
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Bug 8408 - Deserialization exception in logs when NAT flows are added.
The code is modified to fix the issues with multiple CT actions.
The logic skip padded bit is added during Deserialization
Change-Id: Ic5574f0a877228d966ca92eacfa22c751fa14b3c
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Fix queue and xid issue
Change-Id: Idef52a9243d9b2b9ac7028386422f0acc580c07d
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Fix no reserved xid
Change-Id: I153df3f1d3df895e2780a77dd6ed04e43bbc9599
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Remove unused method
Change-Id: I02e3d48f2ccca528995b18cb159700ab08449862
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Bug 8293: Add table writer to bulk-o-matic
* Table writer is introduced for Pre-Leader Role test in which
table is added first and flows next. We want the ability to
create tables separately and not to be created automatically
on addition of flows.
* Modify flow-test rpc to accomodate a boolean: create-parents.
This allows us to prevent addition of flows in case the tables
are missing.
* Fix import ordering
Change-Id: Ic3fe4764631d9cbc7550ad3d7d926debb3ca6977
Signed-off-by: Faiz Ilahi Kothari <faiz.ilahi.k.kothari@ericsson.com>
(cherry picked from commit
2f8d414a2b42bee7504c6fd78536bc6fd1049b83)
Handle missing converters for match extensions
Prevent throwing NullPointerException when converter for match
entry extension is missing, instead throw warning and allow process
to continue (like it was before single-layer-serialization).
See also: bug 8401
Change-Id: If006eef401da4b9bf61911c183e76876fac0dfcf
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Fix no match serialization
This patch ensures that even when match in flow is null, at least empty
match is sent to device.
Change-Id: If77c59b889e45698da4b96f098088cdbdf4698ee
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Prevent changing single-layer-serialization on fly
Prevent changing use-single-layer-serialization config
parameter on the fly, allow it only during initialization.
Resolves: bug 8278
Change-Id: Idfd2f7aa99fdf330bc32615431b4378209c83fda
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Improve property-based configuration
- Add OpenFlowPluginConfigurationService. This service can control
updating of OpenFlowPlugin configuration (skip-table-features etc.)
in initialization phase and also on the fly.
- Comment out default settings in org.opendaylight.openflowplugin.cfg
because with all default values set in that file, we are ignoring
values specified in openflow-provider-config.yang.
- Add support for missing configuration values from
openflow-provider-config.yang to OpenFlowPluginConfigurationService
- Remove changeable configuration values that was passed to some
OpenFlowPlugin class implementations to both constructors and setters
from constructors to prevent code duplicity and to simplify code a bit
Now, when feature is installed,
default values are taken from openflow-provider-config.yang, then we
check if we have org.opendaylight.openflowplugin.cfg file in karaf/etc/
(blueprint will do this for us) and try to read it as map. Then we will
pass this map to update method, that will iterate over this map and
parse it's keys and values and calls appropriate update methods in
OpenflowPluginProviderImpl based on key
(f.e skip-table-features will call
OpenflowPluginProviderImpl#updateSkipTableFeatures).
When org.opendaylight.openflowplugin.cfg file is changed, we receive
notification about it in form of
OpenFlowPluginConfigurationService#update method call, and we will
repeat same procedure as during initialization (parse map passed as
argument to this method and update configuration).
Resolves: bug 7218
Change-Id: Ida986f7dfffe55a90ddb6f354f0addf56c3c4b90
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
(cherry picked from commit
f1cc4de7dee9e22c231a90cf517b03bc5071ad35)
Ignore early port status msg and process it later
When port status message arrives before we got MASTER role,
ignore it. Then, after receiving mastership collect PORT_DESC statistics
again to make sure we do not missed any port status messages in process
Resolves: bug 6908
Change-Id: I01285ed4880533f48bf90fa7c6a4ca2c7d3a210f
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
(cherry picked from commit
426392ea39557e58c0cec51eae3bc91a0bebdf6f)
Merge "Bug 8223: Fixed incorrect enable-flow-removed-notification check." into stable/carbon
Bug 8223: Fixed incorrect enable-flow-removed-notification check.
flow-removed notification needs to be published if
DeviceManager.isFlowRemovedNotificationOn() returns true.
Change-Id: I10c025f11e14670303b70bf31d3a9cefa5a676ec
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
Bug 8217: Set error information into direct statistics RPC result.
Change-Id: I3fdf51b94bf95afefa47dddea37a82b8f139af95
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
Update .gitreview to stable/carbon
Change-Id: I7401c138c0ff82640a18f60e336ae62a3ca441de
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Daniel Farrell [Thu, 30 Nov 2017 16:39:31 +0000 (11:39 -0500)]
Updated git submodules
Project: integration/packaging master
b7f1c4bfb374415e693c6cd315a49b6b0b4f9e7e
Add Packer definitions for recent ODL releases
Change-Id: I7dcda75288595315c7bc3600d9e1a88b08ed0987
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Michael Vorburger [Thu, 16 Nov 2017 20:25:41 +0000 (21:25 +0100)]
Updated git submodules
Project: genius stable/carbon
468144cc3db40d4a50dc8f4061098b51506addd5
Fix possible transaction leak in ItmInternalTunnelDeleteWorker
discovered during https://jira.opendaylight.org/browse/NETVIRT-985,
but initially fixed only on master and not back-ported because only
leak x1 TX; seen again during trace:transactions analysis of
https://jira.opendaylight.org/browse/GENIUS-102 and now ported.
Change-Id: I0e079346c12002a55eb043b72c2f2e2c3b81f7c4
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Balaji Varadaraju [Thu, 16 Nov 2017 18:49:21 +0000 (12:49 -0600)]
Updated git submodules
Project: netconf stable/carbon
7d25cfdca9415fe92d4ad9de81d24bdab818e063
Support for patch command
The internal JSON libary did not have support for HTTP patch command. This patch provides the support
for the PATCH command.
Change-Id: Ibb76452d1a703a219aa7e369a0db21982ab2d08a
Signed-off-by: Balaji Varadaraju <bvaradar@brocade.com>
Sam Hague [Thu, 30 Nov 2017 20:40:29 +0000 (15:40 -0500)]
Updated git submodules
Project: releng/builder master
7228dcb89d6680951bbfbe560662c58ac09f91da
Trim the Exception grepper
Change-Id: I251acf243a7957e18073d0315196c7a2d6ad513a
Signed-off-by: Sam Hague <shague@redhat.com>
Stephen Kitt [Thu, 30 Nov 2017 13:14:44 +0000 (14:14 +0100)]
Updated git submodules
Project: ovsdb stable/carbon
d212bdd53a5445c1316512c080f6136eb4613fd8
OVSDB-435: fix transaction leak in BridgeOperationState
Change-Id: I82708edcf710f72c1356914e9da11a5769b489c9
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Thu, 30 Nov 2017 13:40:06 +0000 (14:40 +0100)]
Updated git submodules
Project: genius stable/carbon
eaa4fe376747f17aa25c3d14ad901d24f8b871d7
Fix bad transaction leak in SouthboundUtils
see https://jira.opendaylight.org/browse/GENIUS-102
This clearly left over was only in carbon, not in nitrogen and master.
(Have not checked earlier branches.)
Change-Id: I727652ac0b505b3ccd2794ec74370d00cf5c0f04
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Thanh Ha [Thu, 30 Nov 2017 01:14:15 +0000 (01:14 +0000)]
Merge "Add openflowplugin to ignore list" into stable/carbon
Jamo Luhrsen [Tue, 28 Nov 2017 17:45:16 +0000 (09:45 -0800)]
Updated git submodules
Project: integration/test master
3393c4247ea1c4a92409370e41691f8c19e0c249
Add keyword for iptables cmd on remote system
this should make it easier to run any arbitrary iptables
command on a remote system
Change-Id: I3748689a70181d9b71f7adfa3b2f9148c361bcc2
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
Daniel Farrell [Wed, 29 Nov 2017 00:49:52 +0000 (19:49 -0500)]
Updated git submodules
Project: integration/packaging master
dc8597cf02327f0ab73a6d3a4e245f5eec23ace1
Add example repo configs for recent RPMs
Change-Id: I807ccab2f5ea7a0d96574f25b270ac13206839dd
Fixes: INTPAK-105
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Tue, 28 Nov 2017 19:03:53 +0000 (14:03 -0500)]
Updated git submodules
Project: integration/packaging master
ebf825ba4665d2797f92203a0d1f473281bc6e28
Update RPM test, Dockerfile ODL versions 7->7.1
Change-Id: I6e259208702d2f817b8819ed3d1bc26bbd3c39cd
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Daniel Farrell [Tue, 28 Nov 2017 23:41:12 +0000 (18:41 -0500)]
Updated git submodules
Project: integration/packaging master
779143fc061e634f7c18719ef9d91846cad06e83
Update build URLs use in pkg tests, fixes
The periodic verify jobs were failing because two of the URLs here had
expired. Go ahead and update all of them.
Change-Id: I7f7dad9b1e4438bc8b8ee1d9936e10918e211c35
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Luis Gomez [Tue, 28 Nov 2017 19:16:13 +0000 (11:16 -0800)]
Updated git submodules
Project: integration/test master
7f466da2fe777820845213a821fde15bf2734bd6
Add 'bug' tag so this TC can be easily excluded
Single 'bug' tag is easy to exclude in case the suite is used
for any sanity or smoke test.
Change-Id: I3c3bba80779a9cd5064ae3a9304a23d32787a57b
Signed-off-by: Luis Gomez <ecelgp@gmail.com>
Kit Lou [Wed, 29 Nov 2017 16:23:43 +0000 (10:23 -0600)]
Add openflowplugin to ignore list
This prevents changes in openflowplugin submodule to affect
other docs from being merged.
Change-Id: If9ea4e9fc1809c2a2e60a2f60ff510ce1a230236
Signed-off-by: Kit Lou <klou.external@gmail.com>
(cherry picked from commit
6ed9d4632bcf5111cf9e8dce90eb4fc6e58b8c7c)
Thanh Ha [Wed, 29 Nov 2017 16:18:41 +0000 (16:18 +0000)]
Merge "Link to Openflowplugin main docs page" into stable/carbon
Thanh Ha [Wed, 29 Nov 2017 16:09:51 +0000 (16:09 +0000)]
Updated git submodules
Project: releng/builder master
2e838d8f80489e6c8804f2e0184c7630c13f32df
Merge "Use eval command to append mail options"
Use eval command to append mail options
Use eval to append mail options with the notify script. When the eval
command is used without escaping the variables causes wordsplitting.
Ref: http://mywiki.wooledge.org/BashFAQ/050
JIRA: RELENG-213
Change-Id: I736f3eaa98d58c4514a936c137d2a2df77053167
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
D Arunprakash [Mon, 13 Nov 2017 12:24:01 +0000 (17:54 +0530)]
Link to Openflowplugin main docs page
Change-Id: Icd494e9e6303d2023f8fea77d0b59a73ff59d830
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
Thanh Ha [Wed, 29 Nov 2017 16:05:52 +0000 (16:05 +0000)]
Merge "Pull in openflowplugin submodule" into stable/carbon
Thanh Ha [Wed, 29 Nov 2017 15:54:51 +0000 (15:54 +0000)]
Updated git submodules
Project: releng/builder master
155f252eebb90b02ddaafcbabedeb3abcde44931
Merge "Branch off oxygen branch for JSONRPC"
Branch off oxygen branch for JSONRPC
Change-Id: I699a0ffd86f527bacebf8b2df277774abb3517c0
Signed-off-by: Anton Ivanov <anton.ivanov@cambridgegreys.com>
Thanh Ha [Wed, 29 Nov 2017 14:41:33 +0000 (14:41 +0000)]
Merge "Update release notes" into stable/carbon
Thanh Ha [Wed, 29 Nov 2017 14:27:21 +0000 (14:27 +0000)]
Updated git submodules
Project: releng/builder master
4815d5cd765f9c01306b47a6870cd2d8c6745091
Merge "Update default repo in RPM verify job"
Update default repo in RPM verify job
Change-Id: I455d3391cc254d1d4d3460aaaa9b5243096f8088
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Thanh Ha [Wed, 29 Nov 2017 14:24:51 +0000 (14:24 +0000)]
Updated git submodules
Project: releng/builder master
f37dc0575b1987531dab82e0f44ff360d5fcfe1d
Merge "Use grep -E to grab relevant exception logs"
Use grep -E to grab relevant exception logs
There is some quirk/bug/problem with sed that it's not working like
we expect to collect the Exception logs. Sometimes it would not
return the expected output. There is probably the right way to do
it but I did not find it. I was trying to match on Exception$ which
would match our "java.lang.NullPointerException" which always
ends with a newline. We were not collecting it before.
Change-Id: I5c8f5bbae2ec44198d53cfc84ead779b3e280cf2
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
Daniel Farrell [Tue, 28 Nov 2017 23:55:36 +0000 (18:55 -0500)]
Updated git submodules
Project: releng/builder master
ead48d7ca8afcc305bfa86b7f2c2f2a997a74476
Update builds tested in RPM jobs
Change-Id: Ib74c407b0ace17df49cf97ac29c49204f7189a38
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
vinothb [Mon, 25 Sep 2017 22:37:28 +0000 (18:37 -0400)]
Updated git submodules
Project: genius stable/carbon
f8e155ada8ff01f04df85b631e6fefb503669514
Bug 8400 - ACL changes doesn't affect the existing connections
Problem:
Change in SG rules not affecting the existing communications
Fix provided:
When we delete the SG rule, added a flow to reset the
communication.
Change-Id: I40bb9c93b11b785e153e5751f083b628cec4b000
Signed-off-by: vinothb <vinothb@hcl.com>
Jamo Luhrsen [Tue, 28 Nov 2017 17:58:05 +0000 (17:58 +0000)]
Updated git submodules
Project: releng/builder master
5a1559f253c173a7c0a02fb3c8adc695b4e8de98
Merge "wait for rabbitmq before stacking computes"
wait for rabbitmq before stacking computes
Change-Id: If485ad4f294db94d0c454903d4236365342eda63
Signed-off-by: Sam Hague <shague@redhat.com>
Jamo Luhrsen [Tue, 28 Nov 2017 17:57:55 +0000 (17:57 +0000)]
Updated git submodules
Project: releng/builder master
4cf2cbabf56c3cf3d43325584a53be480bb9bb0a
Merge "allow shorter suite paths"
allow shorter suite paths
Change-Id: I3e621fd3e294de251f0b2db6c5d39405f6798e36
Signed-off-by: Sam Hague <shague@redhat.com>
Lenny Verkhovsky [Tue, 28 Nov 2017 13:17:27 +0000 (15:17 +0200)]
Updated git submodules
Project: releng/builder master
55fc955c0738ec6a1ae7e928301bb12697eae01b
Fix Trigger with multiproject multipatch build
Fixing support for multiproject multipatch trigger
such as genius=32/53632/9,netvirt=59/50259/47
Change-Id: I904064b5f612196ef80c78e1b2672b59d15d02f1
Signed-off-by: Lenny Verkhovsky <lennyb@mellanox.com>
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Josh [Mon, 30 Oct 2017 08:02:17 +0000 (10:02 +0200)]
Updated git submodules
Project: netvirt stable/carbon
e15d9d2e60eb2845e7910600b6514f7d5d53711d
Net-odl full-sync. Set router ext gw MAC
During full-sync networking-odl syncs routers before ports. As such,
the MAC of the router's gw port is not available to be set when the
internal netvirt router is written to md-sal. This commit adds logic
to update the router when the port is written.
Change-Id: Ic6b78f77a8352416d3260678dcd6624e2fcf8d68
Signed-off-by: Josh <jhershbe@redhat.com>
Jamo Luhrsen [Mon, 27 Nov 2017 21:19:45 +0000 (21:19 +0000)]
Updated git submodules
Project: releng/builder master
34efb6edd06fb16d07c6a1cee190a0c3a83c6c31
Merge "Add external repos during CSIT test"
Add external repos during CSIT test
This will fix decanter installation in nitrogen and later.
Change-Id: Ifb4942e935df0d7f4a85e631077e48bf996f28e9
Signed-off-by: Luis Gomez <ecelgp@gmail.com>
Luis Gomez [Mon, 27 Nov 2017 02:43:14 +0000 (18:43 -0800)]
Updated git submodules
Project: releng/builder master
8377f8d9f3d8439031e700e0a1ef29c381f64bc6
Add missing feature to OF sanity test
This is required after adding nicira extension test.
Change-Id: I88c42f4ebaa5d9a8add89759c90b064b714d828b
Signed-off-by: Luis Gomez <ecelgp@gmail.com>
Sam Hague [Mon, 27 Nov 2017 13:44:43 +0000 (08:44 -0500)]
Updated git submodules
Project: integration/test master
7cc59f4fa1b6750cb1e122efa5fd1cbcb2da54fd
Use consistent names for variables
Change-Id: I9d764f92cd49d20fbb963c8528f5fd54e3a2cf28
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Tue, 21 Nov 2017 02:06:28 +0000 (21:06 -0500)]
Updated git submodules
Project: integration/test master
b3964a98f3452abd2bfacb26c3c0e078dee15209
Use consistent naming in ha l3 suite
Change-Id: I4adbd1f585b853cb88866eb10fdcab187afa1693
Signed-off-by: Sam Hague <shague@redhat.com>
D Arunprakash [Mon, 13 Nov 2017 11:06:24 +0000 (16:36 +0530)]
Pull in openflowplugin submodule
Pull in Openflowplugin submodule so that Openflowplugin can
initialize their project docs.
(cherry picked from commit
d00d7a59fa8793b62ef8ebebaaf1da50f40bd29d)
Change-Id: I5340b9a464359c83ba6aebdaab2ba78ee3fca4cc
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
Sam Hague [Mon, 27 Nov 2017 02:18:31 +0000 (21:18 -0500)]
Updated git submodules
Project: integration/test master
3d5a3142de560754cca14276e5c7c66f37603ec5
Remove redundant Get OvsDebugInfo
Change-Id: I91dfe75be27e31d3a562c5b6a28816ca78b5dcb3
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Mon, 27 Nov 2017 00:15:33 +0000 (19:15 -0500)]
Updated git submodules
Project: integration/test master
6d89e3d4ca256b120733ae2918d2ba5c3e2776f6
Add back the ipv6 choice
Change-Id: I272b549d99b57828d0e8125df62dc2ee0651bfe3
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Sun, 26 Nov 2017 23:26:51 +0000 (18:26 -0500)]
Updated git submodules
Project: integration/test master
a7b78ab5cb8e300d315ccd43aca4bc709a276364
Add missing neutron cleanup
Change-Id: I1213b046b0f4029eb85b1c84663c4df9b29b148f
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Tue, 21 Nov 2017 01:45:28 +0000 (20:45 -0500)]
Updated git submodules
Project: integration/test master
66485bca9d653279b62de137787d5f3823d0257d
Use consistent naming in ha l2 suite
Change-Id: Iba3a6282d4cc8b274d2a40845365a0332cf53d87
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Sun, 26 Nov 2017 02:48:22 +0000 (21:48 -0500)]
Updated git submodules
Project: integration/test master
3172e521393a1b80e6206fdbb8f3378a2312fe89
Add missing create sg in ha l3
Change-Id: I94771f2d2ee97dd97ee2e12069430b7886f94501
Signed-off-by: Sam Hague <shague@redhat.com>
Use right name of suite for sg.robot
Change-Id: Ibd712a654ee1bb3d7d6abda058298b6bc41890bd
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Wed, 22 Nov 2017 01:43:42 +0000 (20:43 -0500)]
Updated git submodules
Project: integration/test master
80f2ba4681302f033fbea41dc5bf0eede6cd5029
Use consistent naming in sfc suite
Change-Id: I66ad1a5e630c1d28e3598531e823d6723807f1b7
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Wed, 22 Nov 2017 01:41:10 +0000 (20:41 -0500)]
Updated git submodules
Project: integration/test master
d908ea4b72d1c3d5bd94b3490e78d39b6a50b6aa
Use consistent naming in vpn bgp suite
Change-Id: Id37e1c6a36ed01e1bca37129b478f9934212091c
Signed-off-by: Sam Hague <shague@redhat.com>
Use consistent naming in vpn v6 suite
Change-Id: I8c7c52ce01dabd4b5f6271fe6706d8b4ebb7ee10
Signed-off-by: Sam Hague <shague@redhat.com>
Use consistent naming in vpn suite
Change-Id: I59c80658bd75d5f50eba4d6ff5411b18e9008b31
Signed-off-by: Sam Hague <shague@redhat.com>
Use consistent naming in arp suite
Change-Id: I1c989fca5377c8e4046a06591fb71c8959fd404f
Signed-off-by: Sam Hague <shague@redhat.com>
Use consistent naming in elan suite
Change-Id: Ia0e404471f50525c57fad0b743623f66c048bfe4
Signed-off-by: Sam Hague <shague@redhat.com>
Use consistent naming in tempest suite
Change-Id: I49f22fb96e18412a5dfb9b6acc0912544a861368
Signed-off-by: Sam Hague <shague@redhat.com>
Use consistent naming in sgs suite
Change-Id: I80af4940e7f98bd5c44b2196983134e86d739c3d
Signed-off-by: Sam Hague <shague@redhat.com>
Use consistent naming in sg suite
Change-Id: I502acda323cab483ccf155855f5eff126a8aa1b1
Signed-off-by: Sam Hague <shague@redhat.com>
Use consistent naming in external suite
Change-Id: I9ff856d16eae5ec4e43425f27bc8a268ab96ecf5
Signed-off-by: Sam Hague <shague@redhat.com>
Use consistent naming in l3 suite
Change-Id: Iabf7b246ee3ee65310456ff9ee5438d17f93850f
Signed-off-by: Sam Hague <shague@redhat.com>
Use consistent naming in l2 suite
Change-Id: I5e19f53d2137469df2826a0d026f1fe6dcf7232c
Signed-off-by: Sam Hague <shague@redhat.com>
jenkins-releng [Sat, 25 Nov 2017 06:35:30 +0000 (06:35 +0000)]
Update release notes
Change-Id: I56adc2344f9ea7f49b783629927542d6ffe6dbd5
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Luis Gomez [Wed, 22 Nov 2017 23:09:45 +0000 (15:09 -0800)]
Updated git submodules
Project: integration/test master
40d28a8c8a4e314a4eed48ae2483f9ee5908a414
Add more time in version test
Change-Id: Ia4f98a1bf28fd21a29b8f3afc843ab0fd141910e
Signed-off-by: Luis Gomez <ecelgp@gmail.com>
Sam Hague [Thu, 23 Nov 2017 17:21:11 +0000 (12:21 -0500)]
Updated git submodules
Project: integration/test master
511fc6398168f7d65fe44d71776b3954a04529b3
Make the ha suite names unique
Change-Id: I68c659f346f642042b612b08b8167f108ce50902
Signed-off-by: Sam Hague <shague@redhat.com>
Michael Vorburger [Fri, 17 Nov 2017 12:10:41 +0000 (13:10 +0100)]
Updated git submodules
Project: genius stable/carbon
2a6c5096ce56df099c485a81c4762e8bd3607e83
@Ignore IdManagerTest testMultithreadedIdAllocationFromReleasedIds
because this test is clearly "flaky", it faile the build on a totally
unrelated change (I613ab7720e226c09d46c90329f0bc767f4642530).
on master this entire test seems to be have been re-written (?) anyway.
Change-Id: Ic29ff8b9c2a692cb40a80b413cc8796865a6abeb
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Jaime Caamaño Ruiz [Tue, 21 Nov 2017 16:39:03 +0000 (17:39 +0100)]
Updated git submodules
Project: integration/test master
668367619017d89769c5d5cfd119cf4acddf4f39
Make sure ip forward is enabled on SFC full deploy
So that OVS instances running in docker containers can talk to ODL
controller.
Change-Id: I24fa65c2956b0474328658132277f251b746d8d3
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@suse.com>
Tom Pantelis [Tue, 21 Nov 2017 22:50:27 +0000 (17:50 -0500)]
Updated git submodules
Project: netvirt stable/carbon
a66d5ee06c599fd77076eff784dcdfb649afd01b
NETVIRT-937: Fix NPE in ElanInstanceManager
2017-11-21 16:21:43,179 | ERROR | nPool-1-worker-2 | JobCoordinatorImpl | 261 - org.opendaylight.infrautils.jobcoordinator-impl - 1.3.0.SNAPSHOT | Runnnable likely about to terminate thread due to uncaught exception; but here is useful debugging context: JobEntry{key='elaninterface-
963a4d35-297e-4757-be14-
6c3dec354221', mainWorker=org.opendaylight.netvirt.elan.internal.ElanInstanceManagerElanInstanceManager$$Lambda$774/
1098386956@
516cbba2, rollbackWorker=null, retryCount=6, futures=[null, com.google.common.util.concurrent.ImmediateFuture$ImmediateSuccessfulCheckedFuture@
39325841]}
java.lang.NullPointerException: at index 0
at com.google.common.collect.ObjectArrays.checkElementNotNull(ObjectArrays.java:235)[27:com.google.guava:22.0.0]
at com.google.common.collect.ObjectArrays.checkElementsNotNull(ObjectArrays.java:225)[27:com.google.guava:22.0.0]
at com.google.common.collect.ObjectArrays.checkElementsNotNull(ObjectArrays.java:219)[27:com.google.guava:22.0.0]
at com.google.common.collect.ImmutableList.construct(ImmutableList.java:342)[27:com.google.guava:22.0.0]
at com.google.common.collect.ImmutableList.copyOf(ImmutableList.java:257)[27:com.google.guava:22.0.0]
at com.google.common.collect.ImmutableList.copyOf(ImmutableList.java:228)[27:com.google.guava:22.0.0]
at com.google.common.util.concurrent.Futures.allAsList(Futures.java:835)[27:com.google.guava:22.0.0]
at org.opendaylight.infrautils.jobcoordinator.internal.JobCoordinatorImpl$MainTask.runWithUncheckedExceptionLogging(JobCoordinatorImpl.java:369)[261:org.opendaylight.infrautils.jobcoordinator-impl:1.3.0.SNAPSHOT]
The futures List in remove is reused across the submitted jobs in the forEach loop
which is unsafe as the List is accessed by multiple threads. Each job now returns its
own local futures List.
The futures returned from elanInterfaceManager.removeElanInterface
were also added to the List but I don't see the purpose of this. removeElanInterface
waits for those tx's to complete. Maybe it was so the JC would retry them? If so, this
entire code path has a mix of sync and async transactions which is a bit confusing -
some are submitted to the JC, ohers aren't; some may be retried, others aren't.
Change-Id: I82193fc36a339db42b83df5bfa3d17ff0a88dfa0
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Fix NPE in VpnSubnetRouteHandler
CSIT log shows several of these:
2017-11-21 16:51:37,973 | ERROR | nPool-1-worker-0 | VpnSubnetRouteHandler | 349 - org.opendaylight.netvirt.vpnmanager-impl - 0.6.0.SNAPSHOT | SUBNETROUTE: onInterfaceDown: SubnetOpDataEntry update on interface
174fcd9a-f2fc-4f70-bc1e-
9a42755175ea down event for subnet
9189b34e-b7be-40ff-9bd4-
8c0d0a4f96f3 falied {}
java.lang.NullPointerException
at org.opendaylight.netvirt.vpnmanager.VpnSubnetRouteHandler.electNewDpnForSubnetRoute(VpnSubnetRouteHandler.java:988)
at org.opendaylight.netvirt.vpnmanager.VpnSubnetRouteHandler.onInterfaceDown(VpnSubnetRouteHandler.java:649)
at org.opendaylight.netvirt.vpnmanager.SubnetRouteInterfaceStateChangeListener.lambda$remove$1(SubnetRouteInterfaceStateChangeListener.java:154)
networkId is purposely passed as null in several call sites. It is only used to extract
the String value to pass to addSubnetRouteToFib which passes to L3vpnInput#setNetworkName.
From there is looks like null network name is handled.
Change-Id: Ie86c2ead79d4431a06e04526dc415f58c893d461
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Fix NPE in SubnetmapChangeListener
CSIT log shows a ton of these:
java.lang.NullPointerException
at org.opendaylight.netvirt.vpnmanager.SubnetmapChangeListener.update(SubnetmapChangeListener.java:119)[349:org.opendaylight.netvirt.vpnmanager-impl:0.6.0.SNAPSHOT]
at org.opendaylight.netvirt.vpnmanager.SubnetmapChangeListener.update(SubnetmapChangeListener.java:31)[349:org.opendaylight.netvirt.vpnmanager-impl:0.6.0.SNAPSHOT]
at org.opendaylight.genius.datastoreutils.AsyncDataTreeChangeListenerBase$DataTreeChangeHandler.run(AsyncDataTreeChangeListenerBase.java:152)[247:org.opendaylight.genius.mdsalutil-api:0.4.0.SNAPSHOT]
Either vpnIdOld or subnetId was null when calling getValue(). We could check for
null in all places they're being logged but I just changed it to pass the
reference as Uuid's toString will print the internal value.
Change-Id: I6c88177a476f38c38189bddfb55a62cfba61d9a9
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Ryan Goulding [Tue, 21 Nov 2017 18:46:34 +0000 (13:46 -0500)]
Updated git submodules
Project: aaa stable/carbon
f8af7c245fa40c142c8ae2bc859a66989d7acb35
AAA-151: Invalidate claim cache for CLI initiated changes
The AAA IDM REST handlers already invoke the clearing of the
IdmLightProxy claimCache upon user update, but the CLI Handler did
not handle this properly. This change manually invokes the claim
invalidation.
Access to AAA CLI commands requires access to the karaf console via
client or SSH. Thus, system level access is needed to some degree
to invoke such commands. The major threat involves the action of
an administrator changing a user password via CLI, and then still
being able to invoke the old password because the claimCache is not
purged. This is why a reboot of karaf solves this issue; the
claimCache is flushed. We should not expect our users/administrators
to assume this in the future; this change explicitly invokes
the claimCache flush.
AAA-151 affects Carbon, Nitrogen, and master.
Change-Id: Ie3101d4dc2bbb6d0db91ddad4d567a41d041150d
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Michael Vorburger [Wed, 22 Nov 2017 10:04:32 +0000 (11:04 +0100)]
Updated git submodules
Project: netvirt stable/carbon
515f4392340cb10702d52ba98c21ec6fe5ed837f
Fix the fix for the bad transaction leak in VpnInterfaceManager
In I0f62fcc17c037365c9384e56c9f6f5a430693c20 there was a left-over
tx.submit() that should have also been removed as part of it (because
callWithNewWriteOnlyTransactionAndSubmit already does that, as its name
says). This fixes the follow new error which started appearing in CSIT
logs since that was merged:
2017-11-21 18:05:05,592 | ERROR | ChangeHandler-77 | L3vpnPopulator
| 349 - org.opendaylight.netvirt.vpnmanager-impl - 0.6.0.SNAPSHOT |
Future (eventually) failed: addToLabelMapper
java.lang.UnsupportedOperationException: submit() cannot be used inside
a Managed[New]TransactionRunner
see https://jira.opendaylight.org/browse/NETVIRT-985
Change-Id: Ic2c8b02670242f3a3f190860c205d7d70c2939b3
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Victor Pickard [Fri, 17 Nov 2017 14:31:06 +0000 (09:31 -0500)]
Updated git submodules
Project: netvirt stable/carbon
0e3235d0545898efd1f1d1e20dc5f15782ba041b
NETVIRT-999 - Interface leak when subnet deleted
https://jira.opendaylight.org/browse/NETVIRT-999
Cleanup/remove Interface when subnet is deleted to
fix resource leak.
Change-Id: Iac96a91de9dbdeeb19f8df3d35cd3e7e514e9471
Signed-off-by: Victor Pickard <vpickard@redhat.com>
(cherry picked from commit
114903ecead870e25e085e0fd527d2e8c6a6687d)
Victor Pickard [Mon, 13 Nov 2017 15:04:25 +0000 (10:04 -0500)]
Updated git submodules
Project: netvirt stable/carbon
b719fc671e88b41dfe4a01e544509be79242f2e8
BugId: NETVIRT-989 TEP not deleted when subnet is deleted
https://jira.opendaylight.org/browse/NETVIRT-989
Remove TEP from ds when subnet is deleted.
Change-Id: I5db9902c53a4021609718330406ad65985e0dffb
Signed-off-by: Victor Pickard <vpickard@redhat.com>
(cherry picked from commit
b25dd7ff4cb70a6852bb49d4884afaa93cd48a53)
Michael Vorburger [Thu, 16 Nov 2017 20:08:05 +0000 (21:08 +0100)]
Updated git submodules
Project: genius stable/carbon
00af9776b1afc4b3985f6ba171b411cd107b8e1c
Fix bad transaction leak in ItmInternalTunnelAddWorker
see https://jira.opendaylight.org/browse/NETVIRT-985
523x transactions opened here, which are not closed:
org.opendaylight.genius.itm.confighelpers.ItmInternalTunnelAddWorker.buildAllTunnels
Change-Id: I9c32010b64688b9cb441a2ea637e9519ba803c80
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Stephen Kitt [Mon, 20 Nov 2017 16:53:11 +0000 (17:53 +0100)]
Updated git submodules
Project: netvirt stable/carbon
2756f4d63319e71d6557ced7203ae341143edf11
NETVIRT-1000: protect VpnInterfaceManager::remove
This patch ensures that the write transactions in
VpnInterfaceManager::remove are always closed.
Change-Id: Iaca016e08fed88f8cb34afbef702465ba152bbe0
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit
0a5b512a8b81b08597129def6126909d426da6c8)
(cherry picked from commit
a94d7f296c29269d1a5ed250cec2a83b66374ee3)
NETVIRT-1000: protect VrfEntryListener (partially)
This patch ensures that the write transactions in
VrfEntryListener.CleanupVpnInterfaceWorker::call and
::deleteFibEntries are always closed.
Change-Id: I57a6912fa162d3e37792d479ad76ae0879c3ae35
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit
de26ae59fdd4ee4c51364a3eadead2dd2077118b)
(cherry picked from commit
d0a42553adeee94922bb552a841f577854600b8f)
NETVIRT-1000: protect TunnelEndPointChangeListener
This patch ensures that the write transactions in
TunnelEndPointChangeListener::add are always closed.
Change-Id: I79af37a9c046a405113c1fd408098b06fb59d028
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit
e87ef10577dfbca52c9d260f855282ab16774afd)
(cherry picked from commit
74f2577204e3fe604731b2753289d4d4a7b81cda)
NETVIRT-1000: protect manageRemoteRouteOnDPN
This patch ensures that the write transaction in
VrfEntryListener::manageRemoteRouteOnDPN is always closed.
Change-Id: I4add610addb470bea3ceda9736f9cbc457adcb44
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit
1ae660f95db00d71e3d1937d98dd618580ddf04c)
(cherry picked from commit
14c29b7847b9e30ab71cd340906af2ebafab08c2)
Stephen Kitt [Mon, 20 Nov 2017 10:15:33 +0000 (11:15 +0100)]
Updated git submodules
Project: netvirt stable/carbon
c3be18bbe87b01bf7b7744429a92d24e66c4f026
NETVIRT-1000: protect handleNeutronPortUpdated
This patch ensures that the write transaction in
NeutronPortChangeListener::handleNeutronPortUpdated is always closed.
Change-Id: I56557db7fc4852100599379b0b32267a94ed9807
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Sam Hague [Tue, 21 Nov 2017 13:54:32 +0000 (08:54 -0500)]
Updated git submodules
Project: integration/test master
e0007d9e0a86d3d4a34582f1645a2a6b8cd77753
Use full path to netvirt tests 2
Change-Id: I93969f5799f6c389eb4eec13de0b11b67aa2c600
Signed-off-by: Sam Hague <shague@redhat.com>
Jamo Luhrsen [Mon, 20 Nov 2017 17:59:40 +0000 (09:59 -0800)]
Updated git submodules
Project: integration/test master
4f179b6b1dfda0ebc3fb353a448d3a77fb58e8e6
Remove legacy script and test plans
netvirt legacy is no longer consumed by any projects. Boron
was the last release this was the case and Boron jobs no
longer exist
Change-Id: Ib58ba44cb74d402829fd152fe75743d5b4416bc3
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Tue, 21 Nov 2017 02:38:01 +0000 (21:38 -0500)]
Updated git submodules
Project: integration/test master
fc4066a7346ebe74cce54e9a0e7c02916591a73d
Use full path to netvirt tests
Change-Id: Iee93f187f6cc568aa18a21ec6fc7fc1d1834d734
Signed-off-by: Sam Hague <shague@redhat.com>
Tomas Jamrisko [Mon, 20 Nov 2017 14:10:45 +0000 (15:10 +0100)]
Updated git submodules
Project: integration/test master
72439d5260cfbdd3cdafff256c18c060aaeb643c
Workarounds for containers
Adding NODE_KARAF_COUNT_COMMAND as all the other operations on
nodes can be overwritten on command line and this is useful when
running from a container.
Also changing the start function to check for "docker" as we don't
want to add those options when using docker.
This is just a temporary fix that makes it usable, but it could be
limiting and require more work later
Change-Id: I5e90cefcb52dec9b9666813824a6a42721db173d
Signed-off-by: Tomas Jamrisko <tjamrisk@redhat.com>
Sam Hague [Fri, 17 Nov 2017 14:30:09 +0000 (09:30 -0500)]
Updated git submodules
Project: integration/test master
d7b7c20493d2f213c5934d8fe9e7c8b55183d91c
name netvirt suites consistently
Change-Id: Iadfd417aead7bd8fae53f468931ba181e3f5832c
Signed-off-by: Sam Hague <shague@redhat.com>
Stephen Kitt [Mon, 20 Nov 2017 09:55:38 +0000 (10:55 +0100)]
Updated git submodules
Project: netvirt stable/carbon
58e1d7decd1f148ac76d40e49e8d32baee32ed1e
NETVIRT-1000: protect handleNeutronPortCreated
This patch ensures that the write transaction in
NeutronPortChangeListener::handleNeutronPortCreated is always closed.
Change-Id: I97fed4d99d0c81bf4f8c2704233238884dbb2a0d
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit
a5905ebb236ac66d322b7e9bbf12a3ff8a49ec32)
(cherry picked from commit
abbf9cfce1858207a8195b5adb732fd27182db85)
Jamo Luhrsen [Mon, 20 Nov 2017 21:57:32 +0000 (13:57 -0800)]
Updated git submodules
Project: integration/test master
4bc6d322cadd82c7e9ca56824b3d2c267c128cb4
Fix sfc variable VP_IPS -> NET1_VM_IPS
this was overlooked in the refactor here:
https://git.opendaylight.org/gerrit/#/c/65589/4/csit/suites/openstack/extensions/sfc.robot
Change-Id: Ife8823eef4be6846ce8a783e71cfdb4c961012b7
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
Faseela K [Mon, 20 Nov 2017 16:35:07 +0000 (22:05 +0530)]
Updated git submodules
Project: genius stable/carbon
e8e0d0b7750dc186cce67f34f6ac3c40e7bc9733
Fix too long service binding INFO logs
Change-Id: I93860de36c332a1a8fcca0d06e5073fb2baac439
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Michael Vorburger [Thu, 16 Nov 2017 14:13:48 +0000 (15:13 +0100)]
Updated git submodules
Project: netvirt stable/carbon
a54964c510629d7faea73851083fb2b1667951a9
Fix bad transaction leak in VpnInterfaceManager
see https://jira.opendaylight.org/browse/NETVIRT-985
292x transactions opened here, which are not closed:
org.opendaylight.controller.md.sal.binding.impl.BindingDOMDataBrokerAdapter.newWriteOnlyTransaction(BindingDOMDataBrokerAdapter.java:69)
(...)
org.opendaylight.netvirt.vpnmanager.VpnInterfaceManager.addToLabelMapper(VpnInterfaceManager.java:1594)
org.opendaylight.netvirt.vpnmanager.populator.impl.L3vpnPopulator.addSubnetRouteFibEntry(L3vpnPopulator.java:104)
org.opendaylight.netvirt.vpnmanager.populator.impl.L3vpnOverMplsGrePopulator.populateFib(L3vpnOverMplsGrePopulator.java:57)
org.opendaylight.netvirt.vpnmanager.VpnSubnetRouteHandler.addSubnetRouteToFib(VpnSubnetRouteHandler.java:827)
org.opendaylight.netvirt.vpnmanager.VpnSubnetRouteHandler.electNewDpnForSubnetRoute(VpnSubnetRouteHandler.java:906)
org.opendaylight.netvirt.vpnmanager.VpnSubnetRouteHandler.onSubnetAddedToVpn(VpnSubnetRouteHandler.java:241)
org.opendaylight.netvirt.vpnmanager.SubnetmapChangeListener.add(SubnetmapChangeListener.java:89)
org.opendaylight.netvirt.vpnmanager.SubnetmapChangeListener.add(SubnetmapChangeListener.java:29)
org.opendaylight.genius.datastoreutils.AsyncDataTreeChangeListenerBase$DataTreeChangeHandler.run(AsyncDataTreeChangeListenerBase.java:158)
Change-Id: I0f62fcc17c037365c9384e56c9f6f5a430693c20
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Tue, 11 Jul 2017 15:54:37 +0000 (21:24 +0530)]
Updated git submodules
Project: infrautils stable/carbon
39550b6b5f3bec7e46db3382d2ec6e1021b5496c
ListenableFutures util to simplify adding error logging callbacks
Intended for usage in existing code prevalent in e.g. genius and netvirt
which simply ignores Future returned by DataBroker Tx submit; using
this, at least we'll get to see logs. (Ideal solution would be real
error recovery callbacks.)
NB: This is solution for today's world. In tomorrow's world where e.g.
DataBroker (and other ODL APIs) switch from Guava's ListenableFuture to
Java 8's CompletionStage, this helper won't be required anymore, as code
then will be able to just use the easier:
completionStage.exceptionally(t -> LOG.error("...", t));
instead of using this utility for today's APIs like this:
import static
org.opendaylight.infrautils.utils.concurrent.MoreFutures.addErrorLogging;
addErrorLogging(listenableFuture, LOG, "...");
Until that (major...) API switch happens though, this is a very
convenient utility to short-cut what otherwise is several lines of
boiler plate code.
TODO: It would be cool if this could, later, preserve the call stack...
Change-Id: I1d3e4afbc0940faa0c8f83e9d713c2e081e18a28
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Sam Hague [Sat, 18 Nov 2017 20:29:11 +0000 (15:29 -0500)]
Updated git submodules
Project: integration/test master
dc784f488a64deb07b7342fd6b0428cdde9a3179
Use iproute instead of nameserver to get gw
The nameserver line is only included when a vm fails
to ping the gw and you see the below messages in the
console log:
=== pinging gateway failed, debugging connection ===
The iproute line is always included:
ip-route:169.254.169.254 via 10.20.20.2 dev eth0
The old code worked because at least one of the vms
in the list would hit the gateway failed block and
get the gw from the nameserver line. The old code
also would only copy the gw address once for all
the vms because it kept a list with size 1 for
the address. The new Get VM IPs tries to get the
gw for each vm and not just one for the whole list
of vms. Timing differences might end up not getting
the nameserver line, so instead use the metadata
line which is always present.
Change-Id: I72637575b5171d3eaad6110ed2e8bc2cefed25ed
Signed-off-by: Sam Hague <shague@redhat.com>
Sridhar Gaddam [Wed, 11 Oct 2017 07:23:16 +0000 (12:53 +0530)]
Updated git submodules
Project: netvirt stable/carbon
40e95fd130e7cd8dc740c89067ce862c76f909c9
Shell Commands to Display Ipv6Service Cache
IPv6Service in netvirt maintains a cache of various Neutron resources to
honor the Router Solicitation/Neighbor Solicitation requests (which are
time sensitive) coming from the VMs spawned on the IPv6 Network.
This patch implements the necessary shell commands to dump the ipv6Cache.
Change-Id: Ie1aed6d47da540e3fd94c6a8cc3eedf7b4954989
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Daniel Farrell [Fri, 17 Nov 2017 18:32:32 +0000 (13:32 -0500)]
Updated git submodules
Project: releng/builder master
549eec835a8c2adfc4645a17efb4e000a4985688
Pass stream to snap jobs vs extracting
Now that Thanh has shown me how to inject vars into builder scripts like
this, just pass stream vs hack to extract it from job name.
Change-Id: I689258c9379a15d50c5f4f7b10629cc5bbb42f2a
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Michael Vorburger [Thu, 16 Nov 2017 10:59:32 +0000 (11:59 +0100)]
Updated git submodules
Project: netvirt stable/carbon
6faaf63551bab4383f84456418beb74bd9f32fff
Fix bad transaction leak in NeutronvpnManager
2256x transactions opened here, which are not closed.
see https://jira.opendaylight.org/browse/NETVIRT-886
Change-Id: I4b0d73203c46087d35cbfccc8aaf5d29d39d89b0
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 16 Nov 2017 17:05:16 +0000 (18:05 +0100)]
Updated git submodules
Project: netvirt stable/carbon
4b57bdc250dcaef13aff375e0fc3619765997a36
Fix bad transaction leak in InterfaceStateChangeListener
see https://jira.opendaylight.org/browse/NETVIRT-985
555x transactions opened here, which are not closed:
org.opendaylight.netvirt.vpnmanager.InterfaceStateChangeListener.lambda$remove$1
31x transactions opened here, which are not closed:
org.opendaylight.netvirt.vpnmanager.InterfaceStateChangeListener.lambda$add$0
15x transactions opened here, which are not closed:
org.opendaylight.netvirt.vpnmanager.InterfaceStateChangeListener.lambda$update$2
Change-Id: Id29be0fb48b3d97f84049d0e0d698d13757eb6a8
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit
a9b5d6ad16593465bc37a67b8f06e9d0f0c32b3d)
(cherry picked from commit
1a28405c7e179318d1918c87f9e8412667af78a4)
Stephen Kitt [Thu, 21 Sep 2017 16:22:31 +0000 (18:22 +0200)]
Updated git submodules
Project: genius stable/carbon
8409df3574c3a0496cb9b5e17859cd28ec162ac4
Add ReadWriteTransaction support
Backport from master (WITHOUT ItmTunnelAggregationHelper),
FOR https://jira.opendaylight.org/browse/NETVIRT-985.
Change-Id: Ia8c946dfc46f3218c15c7ce87215a434ba10ad85
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Jamo Luhrsen [Wed, 15 Nov 2017 19:51:42 +0000 (11:51 -0800)]
Updated git submodules
Project: integration/test master
d278dff10a574607d77a7570b89df07e6411bf31
Add router and sg listings to Show Debugs keyword
- also refactored List Router to List Routers because it makes
more sense to be plural
Change-Id: I83df8a7d7fdfd238dacda138f069bb0b74e2e176
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
Sam Hague [Wed, 15 Nov 2017 23:34:31 +0000 (18:34 -0500)]
Updated git submodules
Project: integration/test master
bfd68bfbb7801e923c05273146c2331610091cbb
Move arp learning to use Get VM IPs
Change-Id: I48ac351469f66875335763119081c503a12d2841
Signed-off-by: Sam Hague <shague@redhat.com>
Michael Vorburger [Wed, 20 Sep 2017 18:05:09 +0000 (20:05 +0200)]
Updated git submodules
Project: genius stable/carbon
59caf785376497197e8cccd214b2243f27dde5f9
ManagedTransactionRunner utility to help close transactions
BACKPORT from master WITHOUT ItmTunnelAggregationHelper,
and ManagedNewTransactionRunnerImplTest w.o. LogCaptureRule,
and adjusting for DataBrokerTestModule changed in master;
FOR https://jira.opendaylight.org/browse/NETVIRT-985.
REQUIRES https://git.opendaylight.org/gerrit/#/c/65602/
_______________________________________________________________________
Commit Message from original change on master:
inspired by
https://git.opendaylight.org/gerrit/#/q/topic:transaction-helper, but:
(1) instead of the cancel-if-lambda-didn't-submit design, forbid
lambda from doing submit() or cancel(), and instead let new transaction
utility do that. This is better because it already opens the door for
non-single transactions in the future (see upcoming next chained change)
(2) allow lambda to throw checked exceptions (see CheckedConsumer),
which will, obviously, lead to the Transaction to be canceled. This is
important as it helps avoid errors where using code forget this.
TODO: Make all places which topic:transaction-helper converted to using
TransactionHelper use this change's ManagedNewTransactionRunner instead.
Change-Id: I613ab7720e226c09d46c90329f0bc767f4642530
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Tomas Jamrisko [Mon, 13 Nov 2017 13:04:33 +0000 (14:04 +0100)]
Updated git submodules
Project: integration/test master
868f7131a40a557517903fc3775ca77655b21a07
Create and delete security groups
The connectivity test suites are creating and deleting most resources
as they require, except for allowing SSH, which gets created during
l2 tests and is reused by l3, which creates a dependency. It would be
great, if l3 test suite worked independently
Change-Id: Icdf47ceaaf3b1fb0353cca454eb039795137e7c1
Signed-off-by: Tomas Jamrisko <tjamrisk@redhat.com>
jenkins-releng [Fri, 17 Nov 2017 01:41:29 +0000 (01:41 +0000)]
Updated git submodules
Project: releng/builder master
ec7d552375394af9c77869ee330bf9d235019896
Update validate autorelease projects for oxygen
Change-Id: I364baf48dd67e7d15341bccdc734d7cf9e396141
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Jamo Luhrsen [Fri, 17 Nov 2017 00:50:21 +0000 (00:50 +0000)]
Updated git submodules
Project: releng/builder master
f1f135a94f604a243c7daa6418cea8b90b63603c
Merge "Add globstar to log surefire reports for odlparent"
Add globstar to log surefire reports for odlparent
Change-Id: I5a032fd993996f5120e0d0eb887ac8d563124b90
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Jamo Luhrsen [Fri, 17 Nov 2017 00:50:17 +0000 (00:50 +0000)]
Updated git submodules
Project: releng/builder master
1fc500b2ae0403431242b4d735698461cabe67a3
Merge "Add globstar to log surefire reports for yangtools"
Add globstar to log surefire reports for yangtools
Change-Id: I3462f88b541f71635a1f9a241366d868b716ebf5
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
ebrjohn [Thu, 12 Oct 2017 21:05:59 +0000 (16:05 -0500)]
Updated git submodules
Project: integration/test master
8038cf9dc0c10b11bca7a2c14983b6cc8f21a087
Fix SFC OVS NSH installation regression
- It was still tring to install OVS 2.5.90 from Yi Yang's
branch, but that no longer works and OVS 2.6.1 should now
be installed.
Change-Id: Ide9697e821c9136e053ef6a4b3bc3a866a135840
Signed-off-by: Brady Johnson <bjohnson@inocybe.com>
Aswin Suryanarayanan [Thu, 16 Nov 2017 15:58:20 +0000 (21:28 +0530)]
Updated git submodules
Project: netvirt stable/carbon
81b32336dbf5952c0ac60b05a622d1de5d42fdb1
NETVIRT-981 CSIT Sporadic failures - snat conntrack job failing many
tempest scenario tests Changes are made to avoid stale entries when an
external network is deleted.
https://jira.opendaylight.org/browse/NETVIRT-981
Change-Id: I28b86a4233d397686c9e074ece5697eb0629ff3e
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Philippe Guibert [Tue, 14 Nov 2017 14:18:33 +0000 (14:18 +0000)]
Updated git submodules
Project: integration/test master
8292f1a8e751ba5ff273a985f159f234891abf02
INTTEST-33: ipv6 neighboring displayed from VM
The fix is fixing the syntax of the ip command to use when being a
busybox instance.
Change-Id: I1eb3cf4e0e162437671f1f0fa7e7cdf117d9ebd2
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Sam Hague [Wed, 15 Nov 2017 23:41:57 +0000 (18:41 -0500)]
Updated git submodules
Project: integration/test master
6da09fecbb6f03a0c19859ca47ca233cf460ee23
Move sfc to use Get VM IPs
Change-Id: I0bcbfbea01c94f7cd9ca23a9b0e56e500fecd8e5
Signed-off-by: Sam Hague <shague@redhat.com>
Move l2gw to use Get VM IPs
Change-Id: Ic182f770e5a499b5dcaedacdd03448464e9fc0da
Signed-off-by: Sam Hague <shague@redhat.com>
Move l3 clustering to use Get VM IPs
Change-Id: I870b455a916ac951580cb89b4ba37e0379b5e00f
Signed-off-by: Sam Hague <shague@redhat.com>
Move l2 clustering to use Get VM IPs
Change-Id: If40be3121e7fd6b4a55237f702a95d989ec45c98
Signed-off-by: Sam Hague <shague@redhat.com>
Move bgp vpn to use Get VM IPs
Change-Id: I2db9208037690f274923b9a2c5839f3b4e671e3a
Signed-off-by: Sam Hague <shague@redhat.com>
Move basic vpn suite to use Get VM IPs
Change-Id: Ic2bf29fa8c54c7362dbdb26fa12730fb69a9aec9
Signed-off-by: Sam Hague <shague@redhat.com>
Jamo Luhrsen [Thu, 16 Nov 2017 20:15:21 +0000 (12:15 -0800)]
Updated git submodules
Project: integration/test master
df3c5d2933bf8fc1efdab37f3e3eb4091ab3d1be
Change Get VM IPs [Documentation] for accuracy
Change-Id: I26a677fe93b806ced9bc13611a658f5a6d479402
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
Sam Hague [Tue, 14 Nov 2017 22:26:03 +0000 (17:26 -0500)]
Updated git submodules
Project: integration/test master
dd6a44f6ba72dee9ac721ef484feb375619d86dc
Move elan suite to use Get VM IPs
Change-Id: Idc1d35e7fba07ee44daf3114bc3b98b22dcde64a
Signed-off-by: Sam Hague <shague@redhat.com>
Jamo Luhrsen [Thu, 16 Nov 2017 00:02:06 +0000 (16:02 -0800)]
Updated git submodules
Project: integration/test master
3fdf78082fc06cfbba8a3a46af20372ad2aee6bc
Use Run Keywords for multiple keywords in teardown
this was broken recently, when wanting to split out
the amount of data models we collect in our non-sfc
suite.
Change-Id: I5d4bf4751a27b00c01a7bd375c49013d66a6aebd
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
Jamo Luhrsen [Thu, 16 Nov 2017 16:21:23 +0000 (08:21 -0800)]
Updated git submodules
Project: integration/test master
61974191879f86d264fce78f00cd3293ddd3765d
Add parens around "${status}" - fix invalid syntax
Change-Id: I7a34148a7a2ba8f6b308fa3226dceca3b80b7d92
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
Jamo Luhrsen [Wed, 15 Nov 2017 05:24:46 +0000 (21:24 -0800)]
Updated git submodules
Project: integration/test master
77f953b1521fe9547348943f7e1aae5191704bee
Handle case when Get VM IP is status FAIL
When a keyword is supposed to return some values (a list in
this case) but hits a failure before the [Return] statement,
we actually only get a status of FAIL and some error message.
Need to handle that.
Change-Id: Ic8e7f9bccfc81bb18f34ede28f4b50277d1c802e
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
Jamo Luhrsen [Wed, 15 Nov 2017 22:57:12 +0000 (14:57 -0800)]
Updated git submodules
Project: releng/builder master
8b5d2536b5f1298f67beb3eb1c981e5722940036
Update template comment block for easy reference
- some templates have been added over time without
this reference section being updated
Change-Id: I3864556c7be51addb733b6f290763cf4a38e4b95
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
Michael Vorburger [Wed, 15 Nov 2017 17:32:02 +0000 (18:32 +0100)]
Updated git submodules
Project: netvirt stable/carbon
e34d572513dfe4e3e1eb7dcbe2ae1f1c6fcda3b6
Fix bad transaction leak in StatisticsImpl
see https://jira.opendaylight.org/browse/NETVIRT-886
Change-Id: Ia72726f9eeae0bcb6273da5b50eb60a65dcd7358
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Wed, 15 Nov 2017 16:59:01 +0000 (17:59 +0100)]
Updated git submodules
Project: ovsdb stable/carbon
d1723dd4ab8121da328137525a57fdd6c439406c
Fix transaction leak in BridgeConfigReconciliationTask
see https://jira.opendaylight.org/browse/OVSDB-425
Change-Id: I9d89cb72768cff137b91773ac8ab0e1d5fce7a04
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Wed, 15 Nov 2017 18:26:56 +0000 (19:26 +0100)]
Updated git submodules
Project: ovsdb stable/carbon
b4d2a15c4a4014446429d52d0ed3d635a15f8e96
Fix transaction leak in OvsdbConnectionManager
see https://jira.opendaylight.org/browse/NETVIRT-985
Change-Id: I50d5e5856d813be8b40bd552c734630856257294
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Wed, 15 Nov 2017 18:19:16 +0000 (19:19 +0100)]
Updated git submodules
Project: ovsdb stable/carbon
8bad9e3debeedab2313d75ba0ff3be08a621c1ab
Fix possible transaction leak in BridgeOperationalState
see https://jira.opendaylight.org/browse/NETVIRT-985
Change-Id: Ie8bd1d81cb4df55d9c75ca275756013262c12a00
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Jamo Luhrsen [Wed, 15 Nov 2017 01:16:17 +0000 (01:16 +0000)]
Updated git submodules
Project: releng/builder master
74cec2b6faea1ef272d8befcebe0a2adae007adb
Merge "Add more Xmx to bgpcep project build"
Add more Xmx to bgpcep project build
Change-Id: I95080c5583deeb2364f845d4f63122b180088990
Signed-off-by: Luis Gomez <ecelgp@gmail.com>
Jamo Luhrsen [Thu, 9 Nov 2017 20:29:07 +0000 (12:29 -0800)]
Updated git submodules
Project: integration/test master
627f8d2fc6b7126dfb2038588c08968bf9b0d099
Remove Lithium keyword from packetcable csit
There is no more lithium to worry about, so no need to keep that
keyword
Change-Id: Ib6f811f13a94efd52a818bc1ec0a6c62edc560e2
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
Anil Belur [Wed, 15 Nov 2017 00:37:19 +0000 (00:37 +0000)]
Updated git submodules
Project: releng/builder master
3c58e6f3d790405107a895a5bca46b191b4385be
Merge "Update to global-jjb v0.12.1"
Update to global-jjb v0.12.1
Pull in fix to enable maven jobs archive custom logs
https://gerrit.linuxfoundation.org/infra/#/c/7492/
Change-Id: Iddc7d9856ea1d21bfd3629e7240991b8e90cc5dc
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>