Robert Varga [Tue, 10 Jul 2018 18:46:09 +0000 (20:46 +0200)]
Remove use of JdkFutureAdapters
RPCs are now exposing ListenableFuture, there is no need to adapt
them.
Change-Id: Iee32036c0a2a1c044dc4c14c19f6d6eb408588af
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Faseela K [Fri, 6 Jul 2018 19:53:02 +0000 (01:23 +0530)]
getInterfaceFromIfIndex() should not log ERROR
With itm-direct-tunnels, there are several cases
where ifindex-interface map in interface-manager
will not have the mapping populated. The RPC should
not be logging ERROR in case of the same.
Change-Id: If14a4738f436b1519ac429a1c06d0383f74af1e0
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Faseela K [Tue, 10 Jul 2018 19:22:51 +0000 (00:52 +0530)]
servicerecovery handler cleanup
Change-Id: I489cc38bc7f7e34eec969aa15c9816884bfe63ab
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Nidhi [Thu, 5 Jul 2018 06:53:41 +0000 (12:23 +0530)]
Handling external tunnel Deletion
WHen a tep is deleted the internal tunnels are cleaned up but not
external tunnels towards DC gateway. The issue was when internal
tunnels were deleted the teps were also cleaned up and so resulted
in NPE when handling external tunnel deletion. Using the same object
reference was the problem. Fix was to return a copy.
Change-Id: Ic65f596d4eb2a89b7468b7ea6af12f3cac4d415a
Signed-off-by: Nidhi <nidhi.adhvaryu@ericsson.com>
Robert Varga [Mon, 9 Jul 2018 20:47:56 +0000 (22:47 +0200)]
Fix invalid models
These models do not contain correct import stanzas and were resolved
accidentally via prefixes declared in modules thy are importing.
JIRA: YANGTOOLS-889
Change-Id: Ia77d1e5199b51ad805e304dcb21c1edee04dfcd3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Stephen Kitt [Fri, 29 Jun 2018 16:07:51 +0000 (18:07 +0200)]
mdsalutil datastore-constrained migration, ifc 1
This migrates interfacemanager to the new IMdsalApiManager methods.
Change-Id: Ia9a2beb9de5f814bcbab50522584987062f21d4d
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 29 Jun 2018 14:02:49 +0000 (16:02 +0200)]
mdsalutil datastore-constrained migration, itm 1
This migrates itm to the new IMdsalApiManager methods.
Change-Id: I3a4c39bd2f53ab8fdbbc3593aaac29af99551bca
JIRA: GENIUS-168
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Edw7n [Mon, 2 Jul 2018 08:20:08 +0000 (13:50 +0530)]
Omitting group-id from DS:dpn-teps-state
Change-Id: Idbee55d52f7d247ba0fc42ec3e1ad3d8d45bd5bc
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
eswanit [Fri, 22 Jun 2018 09:28:02 +0000 (14:58 +0530)]
Updating service recovery spec to point to
existing service recovery test-plans
Change-Id: Iaa0e2108f5f21524286cab78b7e4327ab4a31073
Signed-off-by: eswanit <swati.udhavrao.niture@ericsson.com>
Faseela K [Thu, 14 Jun 2018 00:25:08 +0000 (05:55 +0530)]
Add IfIndex-Interface Cache
In an incident of heavy packet-in messages(30K events per minute),
each packet-in was making an RPC call to getinterfaceNameForIfIndex(),
which was internally doing a datastore read. In a particular case, all these
READS ended up being remote in a 3 node cluster, which was causing trouble
for the cluster.
Change-Id: I4f7f3adb2ed2c076a954cde25bd7186cb581d63c
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Michael Vorburger [Mon, 2 Jul 2018 15:22:14 +0000 (17:22 +0200)]
move AlivenessProtocolHandlerRegistryImpl from internal to impl package
because there is already an internal package in the impl-protocols
This fixes this "split package" issue:
[INFO] --- maven-bundle-plugin:3.3.0:bundle (default-bundle) @alivenessmonitor-impl-protocols ---
[WARNING] Bundle org.opendaylight.genius:alivenessmonitor-impl-protocols:bundle:0.5.0-SNAPSHOT:
Split package, multiple jars provide the same package:org/opendaylight/genius/alivenessmonitor/protocols/internal
Use Import/Export Package directive -split-package:=(merge-first|merge-last|error|first) to get rid of this
JIRA: GENIUS-170
Change-Id: Ifd4d17769e3c96f344de8c383dec75591358d1ef
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Tue, 19 Jun 2018 20:48:30 +0000 (02:18 +0530)]
Remove genius/tools and genius/srm
As these modules are moved to a new repo serviceutils,
let us migrate all the usages to the same.
Change-Id: Ib3f6b77f711d775c4ea615b986ab215dcdc26e88
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Stephen Kitt [Tue, 26 Jun 2018 07:19:00 +0000 (09:19 +0200)]
Port idmanager to datastore-constrained txs
Change-Id: I1f3a50453cd7519e78b104eb8a8a1c4e8bbaed62
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Thu, 28 Jun 2018 13:23:21 +0000 (15:23 +0200)]
mdsalutil datastore-constrained migration, part 1
This adds constrained methods to IMdsalApiManager and HwvtepUtils, in
particular to allow their use in NetVirt.
Change-Id: Ifeb6a43dd263583e2158ddf4b0b82f9e9a0597fd
JIRA: GENIUS-168
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Robert Varga [Thu, 28 Jun 2018 06:58:32 +0000 (08:58 +0200)]
Bump yangtools to 2.0.7
This patch brings in the latest yangtools version.
Change-Id: I2ee4591f8203967d127d1ad74559073174fe4634
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
David Suarez [Thu, 7 Jun 2018 22:36:59 +0000 (00:36 +0200)]
Improve declarations of static queues
Change-Id: Ia6db4b34738ca52d66b74b910e56bea2064a6470
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Robert Varga [Thu, 28 Jun 2018 17:35:09 +0000 (19:35 +0200)]
Bump to odlparent-3.1.2
This place was missed in the bump and was left at 3.1.0, fix that.
Change-Id: I3fec393504a910ae66197f0c26da77b86902cc5d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Stephen Kitt [Thu, 28 Jun 2018 17:53:08 +0000 (19:53 +0200)]
Add Equinox Common to the Xtend Maven plugin
As pointed out by Robert Varga in
I556c934db07148f05f701d1c541fd1f1bfc34219,
org.eclipse.platform:org.eclipse.equinox.common:3.10.0 appears to be
required by the Xtend Maven plugin now.
Change-Id: I8d4e47bab44672b5d6bda5d458f1472985be9469
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Valentina [Tue, 10 Apr 2018 16:38:48 +0000 (18:38 +0200)]
genius: NwConstants change L3_VPNV6_SERVICE_INDEX
Change L3_VPNV6_SERVICE_INDEX value to 9.
Change-Id: I3428d9daab6daf3dc0e685e27104bfc300418217
Signed-off-by: Valentina <valentina.krasnobaeva@6wind.com>
Stephen Kitt [Wed, 30 May 2018 13:46:55 +0000 (15:46 +0200)]
Bump odlparent to 3.1.2
Change-Id: I63a0ecec2f2fa558e4f228a514bc5af2444df291
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Wed, 20 Jun 2018 17:42:35 +0000 (19:42 +0200)]
make new Datastore type a class instead of an interface
with a private constructor, just to prevent any users
from doing new Datastore() { } by accident or confusion.
also include a simple unit test for its conversion methods.
Change-Id: Ifa0b8d8ba81a9599d4e68cf519a5ccdaa88852d4
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Stephen Kitt [Fri, 8 Jun 2018 16:02:18 +0000 (18:02 +0200)]
Drop deprecated odl-infrautils-counters
This is no longer used.
Change-Id: I4d99ec7d6df20133f036d2eae18d2fb759b989bb
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Wed, 20 Jun 2018 15:11:02 +0000 (17:11 +0200)]
Add datastore-constrained transactions
This introduces new transactions which constrain the datastore being
used, and thus no longer require it to be specified with each
operation.
Since this involves adding new methods to ManagedNewTransactionRunner,
this patch also switches to FluentFuture (for the new methods only).
JIRA: NETVIRT-1321
Change-Id: I4f5f46f3a3eb144827f131d31cf4b8f776b6be57
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Edw7n [Sat, 23 Jun 2018 10:41:28 +0000 (16:11 +0530)]
To prevent implicit type casting
- can lead to RPC failure in case of tunnelId not being set
Change-Id: I81c70110e97405e7caa8cea536041189983eba23
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Karthikeyan Krishnan [Thu, 14 Jun 2018 08:44:15 +0000 (14:14 +0530)]
Set Proper EtherType for MPLS Pop Action based on the IP Prefix address family
Problem Description:
======================
When IPv6 L3VPN traffic is coming from DC-GW to OVS switch via MPLSoGRE tunnel
at table L3_LFIB_TABLE(20) is doing removal of MPLS label and it is setting with
ethertype is 0x800(IPv4) always which is wrong for IPv6 traffic.
Solution:
=========
As part of this review, have done the required code modifications to accept both
IPv4(0x800) and IPv6(0x86dd) ethertype for MPLS Pop Action. Also added new utilty for
getting etherType based on the IP Prefix address family (Either IPv4 or
IPv6)
Issue: NETVIRT-1307
Change-Id: Ia84d25d6ba2ba8a2c53e7e9b99d4f65c3381d1a2
Signed-off-by: Karthikeyan Krishnan <karthikeyangceb007@gmail.com>
Nidhi [Tue, 12 Jun 2018 09:55:43 +0000 (15:25 +0530)]
GENIUS-162: Minor changes to karaf log levels and messages
Change-Id: I5ddb8d83bdc53f79938ef7e80404565a22d193b6
Signed-off-by: Nidhi <nidhi.adhvaryu@ericsson.com>
Stephen Kitt [Fri, 15 Jun 2018 13:12:18 +0000 (15:12 +0200)]
Add a returning variant of managed transactions
This patch adds a returnFromSubmittedNewReadWriteTransaction() method
to ManagedNewTransactionRunner, to allow building transaction runners
which return a value to the caller (via a Future).
It also adds unit tests for the callWithNewReadWrite... variant, which
didn’t have any.
Change-Id: I74f155fc487853d1eb1f9e9f7d06a760a638331f
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Somashekar Byrappa [Fri, 8 Jun 2018 12:32:40 +0000 (18:02 +0530)]
New module - ipv6util
+ This is refactoring of ipv6service module in Netvirt.
+ Moved all the IPv6 generic/common functionality from ipv6service module to
ipv6util module in Genius.
+ This is required to support ND based Aliveness monitor which will be used in
subnet routing for hidden IPv6 addresses.
+ ND based Aliveness monitor will be using ipv6util's RPC to send NS packet.
+ This also includes addition of new RPC to send NS packet to an OF group
which is raised as part of [1].
Note: Removing the corresponding code in ipv6service of Netvirt, will be
handled in a separate patch.
[1] https://git.opendaylight.org/gerrit/#/c/71567/
JIRA: NETVIRT-1213
Change-Id: I9263e27ed0533414de0401a87c9595764b23139f
Signed-off-by: Somashekar Byrappa <somashekar.b@altencalsoftlabs.com>
David Suarez [Wed, 20 Jun 2018 19:02:43 +0000 (21:02 +0200)]
Use the new Executors's shutdown method to stop listeners
Use the new Executor's shutdown method to stop listener using default
paramenters.
Change-Id: I1db913aa2575b2e0be0245cf4d8a683e01aac619
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Karthikeyan Krishnan [Fri, 15 Jun 2018 06:19:36 +0000 (11:49 +0530)]
Subnet Route Table Miss Cookie Constant
To support the feature rate limiting for subnet route punt
packets for IPv6 and IPv4 traffic, in this code changes is
defining the new cookie constant value for subnet route table
miss flow from NETVIRT VPN module.
Issue: NETVIRT-1213
Change-Id: I1145f6e1a7d6f4c1a442780fbfb358754a921d98
Signed-off-by: Karthikeyan Krishnan <karthikeyangceb007@gmail.com>
Michael Vorburger [Mon, 18 Jun 2018 14:29:14 +0000 (16:29 +0200)]
fix broken DataTreeEventCallbackRegistrar onAddOrUpdate()
actually fixes two technically completely unrelated bugs:
firstly the use of onUpdate instead of onAddOrUpdate in
two API default methods; and secondly a hard-coded
Duration.ZERO instead of timeoutDuration impl arg.
Change-Id: I6c2092d1b48fafe1a6b90821f0907cb2e064bac1
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 14 Jun 2018 09:38:41 +0000 (11:38 +0200)]
remove useless diagstatus ServiceDescriptor descriptions
following Change-Id: I22109f46e4505ec4336f5d8fdc1794bbb8d05562
Change-Id: Ie5d2a0e572328e7260fd97ad1a35714222e3c317
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Fri, 8 Jun 2018 13:47:10 +0000 (15:47 +0200)]
extend DatastoreServiceStatusProvider with Shard Leader/Follower status
This first requires I563105e8af79c0687cbb99444b34b540e80cbaa5 in
controller to fix CONTROLLER-1835; otherwise it will build, but fail at
runtime.
This also removes the "Data store is fully operational" status
description
in case of a ServiceState.OPERATIONAL; see
I22109f46e4505ec4336f5d8fdc1794bbb8d05562
(and this should not break anything, because until
I65529fc617bb2968ecccefcdd32ff66f7b808952
that was not displayed on the diagstatus CLI anyway).
JIRA: GENIUS-138
Change-Id: Ibbf1ad281880df8da862c9b28b8ca5d360d43bcd
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Edw7n [Wed, 13 Jun 2018 04:46:56 +0000 (10:16 +0530)]
Fixing ItmRpcService to return tunnelName
- requires TestModule, as IITMProvider will be injected in elanItmUtils
dependent changes: https://git.opendaylight.org/gerrit/#/c/72867/
Change-Id: I5d4c22682200ed63d3edb88d0769d7622328813b
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Faseela K [Mon, 11 Jun 2018 08:54:51 +0000 (14:24 +0530)]
Add new openflowutils to batchedAddFlow()/batchedRemoveFlow()
Change-Id: I271162acf229d20be816c9220728cccbcdbc45f3
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Faseela K [Mon, 11 Jun 2018 08:48:35 +0000 (14:18 +0530)]
Add New Table for ITM Egress Tunnel Table
JIRA: GENIUS-143
Change-Id: I9371d597508f7f7e317026b147f4cff0c000a8d4
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Michael Vorburger [Fri, 8 Jun 2018 12:46:13 +0000 (14:46 +0200)]
look up MBean in DatastoreServiceStatusProvider constructor
instead of every time in getServiceDescriptor()
JIRA: GENIUS-138
Change-Id: I8590242f1e9c20a690a544803265be96b9c82369
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Fri, 8 Jun 2018 11:41:01 +0000 (13:41 +0200)]
use strong instead "stringly" typing in DatastoreServiceStatusProvider
getSyncStatus() is better than getMBeanAttribute("SyncStatus")
This requires I3020a86b5221d36eace4359031558fb2bd6b979d in infrautils
and Ie0cb62db5ee2dd98fa1a0e55791c9551089e6aac in controller.
JIRA: GENIUS-138
Change-Id: Ic8df4299b46a4dd21310619e295552404266fb80
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Fri, 8 Jun 2018 09:54:02 +0000 (11:54 +0200)]
report exceptions from datastore service with cause (INFRAUTILS-31)
JIRA: GENIUS-138
Change-Id: Ie0a9f6edeb69e2d4164c51d8340bd4f4a89aefab
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Fri, 8 Jun 2018 09:51:53 +0000 (11:51 +0200)]
make initial datastore service report query for real
JIRA: GENIUS-138
Change-Id: If54dc9b18edac67188dd53678b1d871ec7815c5a
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Stephen Kitt [Thu, 7 Jun 2018 11:38:05 +0000 (13:38 +0200)]
Remove Genius version properties
This avoids the temptation of using them for parents.
Change-Id: I1753fa760a46fd14da5c907a7aa0bfbb2f08d19a
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Faseela K [Wed, 6 Jun 2018 12:23:03 +0000 (17:53 +0530)]
itm-direct-tunnels : key=flow should be set for internal vxlan tunnels
Change-Id: I750727997740e7e3f3a6fac10b8ab7e663fe3a04
Signed-off-by: Faseela K <faseela.k@ericsson.com>
David Suarez [Tue, 5 Jun 2018 21:04:21 +0000 (23:04 +0200)]
Fix the listener to async listener to stop properly
The executor has to be shutdown properly.
Change-Id: Icf0154c322bb8cf386d962fa5bdd1e8c7dcce645
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Dimple Jain [Fri, 27 Apr 2018 05:30:36 +0000 (11:00 +0530)]
Turning on BFD selectively
Change-Id: Ibe15156bd9eafd50ed17ca4230a2e5babb035645
Signed-off-by: Dimple Jain <dimple.jain@ericsson.com>
Robert Varga [Fri, 1 Jun 2018 14:46:41 +0000 (16:46 +0200)]
Bump yangtools to 2.0.5
This bumps the artifacts to latest release.
Change-Id: I0f872362eb81d77a42feb29bba00e6f8e980ea0f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Stephen Kitt [Thu, 31 May 2018 13:59:16 +0000 (15:59 +0200)]
Fixup Augmentable and Identifiable methods changing
This is a fixup of the change in binding codegen, adjusting:
- getKey() -> key()
- setKey() -> withKey()
- getAugmentation() -> augmentation()
Change-Id: I8e384b6d0f6c6bd81e96d71d3cbb81c89e4954a1
JIRA: TSC-101
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
David Suarez [Thu, 3 May 2018 22:06:42 +0000 (00:06 +0200)]
Migrate the only listener in the lockmanager-impl module
- Migrate the only listener in the lockmanager-impl module to use the
new framework.
Change-Id: I65483b6a46de258f46d39b8ec77a333208e6c8a9
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
David Suarez [Thu, 3 May 2018 21:49:22 +0000 (23:49 +0200)]
Migrate the last listener of itm-impl module to use the new framework
- This must be the very last listener in the itm-impl module after [1].
[1] https://git.opendaylight.org/gerrit/#/c/70256/
Change-Id: I2ee2b95c31db0668992f42dd273f48b042ba779e
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Ravindra Thakur [Tue, 15 May 2018 06:44:03 +0000 (12:14 +0530)]
controller-punt-protection: modify learn actions
This change modifies the learn actions to work with field offsets
specified as match/load in learn action eg
field[start..end]=src[start..end]
field[start..end]
spec link:
http://docs.opendaylight.org/projects/netvirt/en/latest/specs/fluorine/controller-punt-protection.html
Issue: NETVIRT-1218
Change-Id: I19af3ffe8aceac426dadb6ad77a4e3adbb72620a
Signed-off-by: Ravindra Thakur <ravindra.nath.thakur@ericsson.com>
Ravindra Thakur [Tue, 15 May 2018 06:33:32 +0000 (12:03 +0530)]
controller-punt-protection: add table ids for ARP rate limiting
The change adds table ids for rate limiting of ARP packets
and defines constants for use in netvirt.
link: https://git.opendaylight.org/gerrit/#/c/71994/
Issue: NETVIRT-1218
Change-Id: Id1b7108a22748190f5013aae9fbad5f6988f66c1
Signed-off-by: Ravindra Thakur <ravindra.nath.thakur@ericsson.com>
Nidhi Adhvaryu [Wed, 16 May 2018 10:17:43 +0000 (15:47 +0530)]
Add timeout support for Genius service recovery
Change-Id: I0e5d1642a81739e80fd2e99f5cd498c279a62c68
Signed-off-by: Nidhi Adhvaryu <nidhi.adhvaryu@ericsson.com>
Faseela K [Thu, 31 May 2018 11:11:00 +0000 (16:41 +0530)]
OF Tunnels - Yang Changes
JIRA: GENIUS-130
Change-Id: Ib26b5007acda1b80f0e1a945f9d21e853edc88c2
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Somashekar Byrappa [Wed, 16 May 2018 10:08:46 +0000 (15:38 +0530)]
Utility method to check IP address is within CIDR range
JIRA: NETVIRT-1213
Change-Id: I0714c5a8cfceee397baf4056689bee3c48d14154
Signed-off-by: Somashekar Byrappa <somashekar.b@altencalsoftlabs.com>
Faseela K [Wed, 2 May 2018 09:50:27 +0000 (15:20 +0530)]
JIRA: GENIUS-130 Spec - OF Tunnels Support For ITM Direct Tunnels
Change-Id: I63920177eaeb57f702568e7c7a93662a8bffa40c
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Michael Vorburger [Wed, 23 May 2018 18:19:54 +0000 (20:19 +0200)]
migrate TepShowState from deprecated OsgiCommandSupport to Action
nota bene https://issues.apache.org/jira/browse/KARAF-5767
Change-Id: I99133078466bd400d912e6d20de11b1dcf633e69
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Tue, 29 May 2018 23:56:32 +0000 (05:26 +0530)]
JIRA: GENIUS-141 DataTreeEventCallbackRegistrar should use ClusteredListener
If DataTreeEventCallbackRegistrar does not use ClusteredListener, there can be cases
in a 3 node cluster where the event call back will be not executed, as the
shard leader for the DS on which the listener is registered can be on a different
node where the callback is not available.
Making DataTreeEventCallbackRegistrar directly use ClusteredDataTreeChangeListener
does not seem to be a problem, as the callback will be available only on one node.
Change-Id: Idcb4b6a3ee709aea14c5fe09bc416100ddaa5519
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Faseela K [Tue, 29 May 2018 09:21:25 +0000 (14:51 +0530)]
Format ITM yang models
No changes to the model is done, only indentation is fixed :)
Change-Id: I06fc2a7285525686186dd396d0cbaf331c821d78
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Karthikeyan Krishnan [Wed, 23 May 2018 12:23:07 +0000 (17:53 +0530)]
NxmOfFieldType support for IPv6 Protocol
The following NXM_NX Fields are needs to be supported as part of IPv6 Punt
Path Protection implementation. This changes is dependent on IPv6
Controller Punt Path Protection support in NETVIRT.
* NXM_NX_IPV6_SRC(19)
* NXM_NX_IPV6_DST(20)
Ref: http://www.openvswitch.org/support/dist-docs/ovs-fields.7.pdf
Change-Id: Ie2bfc988cdfe161988cc51c7fd88b1c69ee4a032
Signed-off-by: Karthikeyan Krishnan <karthikeyangceb007@gmail.com>
Michael Vorburger [Fri, 25 May 2018 13:15:35 +0000 (15:15 +0200)]
fix bug in AlivenessMonitor
introduced in change I508ef8a4c54fbc2af4ae3af56755af73bf192dae
JIRA: GENIUS-140
Change-Id: I7cdc27b5c3db0f26403d1047ac2ccdc6a59ef2b2
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Robert Varga [Fri, 25 May 2018 15:09:58 +0000 (17:09 +0200)]
Eliminate InstanceIdentifier.toInstance() reference
This method has been long-deprecated, do not use it.
Change-Id: Iedd854b3a988767d1188d944ff032d41398c0995
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Faseela K [Wed, 16 May 2018 11:11:23 +0000 (16:41 +0530)]
ITM Tunnels State Container should be operational
Change-Id: Ifd0b84f2c0913564e0dbc3d6c9a095d7aff8c943
Signed-off-by: Faseela K <faseela.k@ericsson.com>
David Suarez [Thu, 3 May 2018 22:50:34 +0000 (00:50 +0200)]
Migrate InterfaceConfigListener to use the new listeners
- Code simplification by using lambdas
- Remove unused services injected
- Other minor changes
Change-Id: Ie60556f42b553618c13205191e1ac3e77ddf860d
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Michael Vorburger [Thu, 24 May 2018 12:31:19 +0000 (14:31 +0200)]
remove non-needed Maven plugin from fcapsapplication-impl
The maven-bundle-plugin and yang-maven-plugin are configured
in genius:binding-parent already, the build-helper-maven-plugin
is not needed. (The blueprint-maven-plugin IS required.)
This avoids this ugly message we see at the top of each build:
[WARNING] Some problems were encountered while building the effective model for org.opendaylight.genius:fcapsapplication-impl:bundle:0.5.0-SNAPSHOT
[WARNING] 'build.plugins.plugin.version' for org.opendaylight.yangtools:yang-maven-plugin is missing. @ org.opendaylight.genius:fcapsapplication-impl:[unknown-version], /home/vorburger/dev/ODL/git/genius/fcapsapplication/fcapsapplication-impl/pom.xml, line 75, column 15
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
Change-Id: I60fc6fd71dbde66dbac4c922eb47246aa5a5fd66
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 24 May 2018 12:26:52 +0000 (14:26 +0200)]
remove <version>${genius.version} from GAV
because this is inherited from <parent> and avoid this:
[WARNING] Some problems were encountered while building the effective model for org.opendaylight.genius:interfacemanager-shell:bundle:0.4.2-SNAPSHOT
[WARNING] 'version' contains an expression but should be a constant. @ org.opendaylight.genius:interfacemanager-shell:${genius.version}, /w/workspace/integration-multipatch-test-fluorine/patch_tester/genius/interfacemanager/interfacemanager-shell/pom.xml, line 22, column 14
Change-Id: Ibb8b91b06ef63fb8292e02503b4c711069650e1b
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Mon, 30 Apr 2018 07:27:41 +0000 (12:57 +0530)]
TSC-99 Adjust to RPC method signature update
Change-Id: I1307120c6400e225a3e5e3e2344648ea5c7c5396
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Dimple Jain [Fri, 18 May 2018 20:12:32 +0000 (01:42 +0530)]
Fixing bug while updating port status to UNKNOWN.
For ITM direct tunnels, state tunnel list was not getting updated to
UNKNOWN only if monitoring was disabled. Fix is removal of the
monitoring check.
Change-Id: I6fa26fab874de22b247adca3ddfc178a460a1a29
Signed-off-by: Dimple Jain <dimple.jain@ericsson.com>
Michael Vorburger [Mon, 30 Apr 2018 11:35:39 +0000 (13:35 +0200)]
introduce TestableDataBroker (with TestableDataBrokerTest)
JIRA: GENIUS-122
Change-Id: Ibebecdd2b387cc33079f2c669199b6f590866e8a
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
David Suarez [Thu, 3 May 2018 21:05:57 +0000 (23:05 +0200)]
Migrate HwVTEPTunnelStateListener to use the new listeners
- Code simplification by using lambdas
- Other minor changes
Note: HwvtepAbstractDataTreeChangeListener might be removed, once
verified that is not used elsewhere, in a separate commit.
Change-Id: I686f00272fe4888cc1b00db0710248ade7313220
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Josh [Sun, 22 Apr 2018 06:36:55 +0000 (09:36 +0300)]
Add default genius-mdsaulutil-config.xml
Change-Id: I87cb6fd5da8b02fafa07823ce161ab1e2b156a15
Signed-off-by: Josh <jhershbe@redhat.com>
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Hema Gopalakrishnan [Fri, 4 May 2018 05:04:57 +0000 (10:34 +0530)]
Pipeline changes incorporated for TaaS
Included the pipeline changes for Tap as a Service(TaaS) feature.
Here is a link to the Spec for TaaS - https://git.opendaylight.org/gerrit/#/c/71691/
Updated with Table no 180,181
Updated the pipeline RST file
Change-Id: I42ef02a4e6ceeff065e253d2f1d66ee4b80439d3
Signed-off-by: Hema Gopalakrishnan <hema.gopalkrishnan@ericsson.com>
Dimple Jain [Wed, 16 May 2018 08:18:06 +0000 (13:48 +0530)]
ITM Direct Tunnels: Handling of UNKNOWN port status.
Updating the tunnel interface state to UNKNOWN on receiving
FlowCapableNodeConnector remove notification with reason
other than DELETE.
Change-Id: I06a52f803c635065f1e70811b6213b869178c920
Signed-off-by: Dimple Jain <dimple.jain@ericsson.com>
Tom Pantelis [Mon, 30 Apr 2018 14:12:35 +0000 (10:12 -0400)]
Remove AsyncWriteTransaction.submit() impls
The submit() method is now defaulted in the interface
so implementations don't need to implement it.
Change-Id: I15916f53797552d165c61b9f5b637017f863011c
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Tue, 1 May 2018 21:22:07 +0000 (17:22 -0400)]
Fix concurrency edge cases in DataTreeEventCallbackRegistrar
Also added UT's for various edge cases.
Change-Id: Ieecb1ba9a509d606952165dad52a4c870c4b8b5e
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Michael Vorburger [Mon, 16 Apr 2018 14:00:19 +0000 (16:00 +0200)]
add timeout support to DataTreeEventCallbackRegistrar
JIRA: GENIUS-122
Change-Id: I628d7e85f47662c82b42b55c43227b70df354680
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Edw7n [Fri, 11 May 2018 10:39:48 +0000 (16:09 +0530)]
To fix bfd status related issue
seen on ovs restart in tdd-wip
Change-Id: Iaaf997db33109941409b7da3ac405be3cdf98a8f
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
(cherry picked from commit
43154768adf28898381c675ba1713cd0a9639a43)
Faseela K [Thu, 10 May 2018 17:21:27 +0000 (22:51 +0530)]
Minor log clean-up and method name change to align to OVS
Change-Id: I1a410e1cfda92ad2499709cde4bc3ddf1133fe9e
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Jamo Luhrsen [Wed, 9 May 2018 03:44:39 +0000 (20:44 -0700)]
Stop git from thinking logo.png has changed
something in our build systems thinks there is something
different about line endings now that the logo.png
file has been put in the genius repo. Removing eol=lf
should prevent that. I'm not totally understanding
what is happening, as this is not a problem on a local
linux system, and our build systems are centos7 so I
would expect the problem to be in both places.
some extra reading here:
https://help.github.com/articles/dealing-with-line-endings/
Change-Id: I4809c34cb04e63563f314bdc7086f0a76955c470
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
Michael Vorburger [Mon, 7 May 2018 10:56:22 +0000 (12:56 +0200)]
remove un-used arguments in InterfaceInventoryStateListener
JIRA: GENIUS-133
Change-Id: I5111839d87648c458c07c597229f9a78823dcde9
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Fri, 4 May 2018 08:51:50 +0000 (14:21 +0530)]
OVS Port Delete not going through
JIRA: GENIUS-133
Deletion of OVS port is resulting in the below error:
mainWorker=InterfaceStateRemoveWorker{nodeConnectorIdNew=Uri{_value=openflow:
68797520762178:2},
nodeConnectorIdOld=Uri{_value=openflow:
68797520762178:2}, fcNodeConnectorOld=FlowCapableNodeConnector{
getAdvertisedFeatures=PortFeatures{_tenMbHd=false, _tenMbFd=false, _hundredMbHd=false, _hundredMbFd=false,
_oneGbHd=false, _oneGbFd=false, _tenGbFd=false, _fortyGbFd=false, _hundredGbFd=false, _oneTbFd=false, _other=false,
_copper=false, _fiber=false, _autoeng=false, _pause=false, _pauseAsym=false}, getConfiguration=PortConfig{_pORTDOWN=false,
_nORECV=false, _nOFWD=false, _nOPACKETIN=false}, getCurrentFeature=PortFeatures{_tenMbHd=false, _tenMbFd=false,
_hundredMbHd=false, _hundredMbFd=false, _oneGbHd=false, _oneGbFd=false, _tenGbFd=false, _fortyGbFd=false,
_hundredGbFd=false, _oneTbFd=false, _other=false, _copper=false, _fiber=false, _autoeng=false, _pause=false,
_pauseAsym=false}, getCurrentSpeed=0, getHardwareAddress=MacAddress{_value=9a:be:c5:8b:90:d2}, getMaximumSpeed=0,
getName=tun704bde687e8, getPeerFeatures=PortFeatures{_tenMbHd=false, _tenMbFd=false, _hundredMbHd=false,
_hundredMbFd=false, _oneGbHd=false, _oneGbFd=false, _tenGbFd=false, _fortyGbFd=false, _hundredGbFd=false, _oneTbFd=false,
_other=false, _copper=false, _fiber=false, _autoeng=false, _pause=false, _pauseAsym=false}, getPortNumber=
PortNumberUni{_uint32=2}, getQueue=[], getReason=Delete, getState=State{isBlocked=false, isLinkDown=false,
isLive=false, augmentations={}}, getSupported=PortFeatures{_tenMbHd=false, _tenMbFd=false, _hundredMbHd=false,
_hundredMbFd=false,_oneGbHd=false, _oneGbFd=false, _tenGbFd=false, _fortyGbFd=false, _hundredGbFd=false,
_oneTbFd=false, _other=false, _copper=false, _fiber=false, _autoeng=false, _pause=false, _pauseAsym=false}},
interfaceName='tun704bde687e8'}, rollbackWorker=null, retryCount=6/6, futures=[com.google.common.util.concurrent.
ImmediateFuture$ImmediateFailedFuture@
6a75e6cd[status=FAILURE, cause=[java.lang.UnsupportedOperationException: submit()
cannot be used inside a Managed[New]TransactionRunner]]]}
java.lang.UnsupportedOperationException: submit() cannot be used inside a Managed[New]TransactionRunner
at org.opendaylight.genius.infra.NonSubmitCancelableReadWriteTransaction.submit(NonSubmitCancelableReadWriteTransaction.java:36) ~[332:org.opendaylight.genius.mdsalutil-api:0.5.0.SNAPSHOT]
at org.opendaylight.genius.interfacemanager.listeners.InterfaceInventoryStateListener$InterfaceStateRemoveWorker.handleTunnelMonitoringRemoval(InterfaceInventoryStateListener.java:424) ~[?:?]
at org.opendaylight.genius.interfacemanager.listeners.InterfaceInventoryStateListener$InterfaceStateRemoveWorker.lambda$removeInterfaceStateConfiguration$0(InterfaceInventoryStateListener.java:398) ~[?:?]
at org.opendaylight.genius.infra.ManagedNewTransactionRunnerImpl.callWithNewReadWriteTransactionAndSubmit(ManagedNewTransactionRunnerImpl.java:63) [332:org.opendaylight.genius.mdsalutil-api:0.5.0.SNAPSHOT]
at org.opendaylight.genius.interfacemanager.listeners.InterfaceInventoryStateListener$InterfaceStateRemoveWorker.removeInterfaceStateConfiguration(InterfaceInventoryStateListener.java:378) [326:org.opendaylight.genius.interfacemanager-impl:0.5.0.SNAPSHOT]
at org.opendaylight.genius.interfacemanager.listeners.InterfaceInventoryStateListener$InterfaceStateRemoveWorker.call(InterfaceInventoryStateListener.java:355) [326:org.opendaylight.genius.interfacemanager-impl:0.5.0.SNAPSHOT]
at org.opendaylight.genius.interfacemanager.listeners.InterfaceInventoryStateListener$InterfaceStateRemoveWorker.call(InterfaceInventoryStateListener.java:318) [326:org.opendaylight.genius.interfacemanager-impl:0.5.0.SNAPSHOT]
at org.opendaylight.infrautils.jobcoordinator.internal.JobCoordinatorImpl$MainTask.runWithUncheckedExceptionLogging(JobCoordinatorImpl.java:401) [352:org.opendaylight.infrautils.jobcoordinator-impl:1.4.0.SNAPSHOT]
at org.opendaylight.infrautils.utils.concurrent.LoggingUncaughtThreadDeathContextRunnable.run(LoggingUncaughtThreadDeathContextRunnable.java:60) [357:org.opendaylight.infrautils.util:1.4.0.SNAPSHOT]
at java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1402) [?:?]
at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289) [?:?]
at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056) [?:?]
at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692) [?:?]
at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157) [?:?]
Change-Id: I5d0e634bdf24f159f018ed8ff8bdf9cacd98a78a
Signed-off-by: Faseela K <faseela.k@ericsson.com>
David Suarez [Thu, 3 May 2018 21:31:37 +0000 (23:31 +0200)]
Fix a typo
Change-Id: I1c8b7b67148c0de3d4fc4624c3ec169b7511d5dc
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Tom Pantelis [Fri, 27 Apr 2018 17:22:04 +0000 (13:22 -0400)]
Implement AsyncWriteTransaction.commit()
Implement the new commit() method which uses FluentFuture
instead of the deprecated CheckedFuture. The commit() method
is defaukted in the interface but, as soon as all implementations
implement commit(), the deprecated submit() method will be defaulted
instead.
Change-Id: Icbd987b95c6fc8f0a7cce61870e93365daf47967
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Michael Vorburger [Thu, 12 Apr 2018 17:05:39 +0000 (19:05 +0200)]
remove un-used pax-cdi-api from tools-api
Change-Id: I72799ecfbf8cfca2e394abf4030df1f6fdbeec10
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Thanh Ha [Tue, 1 May 2018 18:52:22 +0000 (14:52 -0400)]
Switch to using lfdocs-conf to pull in theme
lfdocs-conf is a new project that allows us to centrally manage
project theme configuration without having to duplicate it
everywhere or have the "docs" project become a large submodule
project.
We will push to ReadTheDocs separately and then create a new path
for this doc under docs.opendaylight.org/projects/integration-packaging
For further details refer to:
http://docs.releng.linuxfoundation.org/en/latest/project-documentation.html
Issue: DOCS-69
Change-Id: I2259eea16a3cc6a52d1b72ee67a84ca6439dca6c
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Vishal Thapar [Fri, 27 Apr 2018 06:29:41 +0000 (11:59 +0530)]
GENIUS-117 Create MPLSGRE only for OVS2.8.0+
1. Added logic to get OVS version
2. If OVS Version is 2.8.0+ create MplsOverGre tunnel
3. Else, return without creating tunnel port
Change-Id: If8178dcc2f5f49b4293bbb5ba62b37319a12daa1
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Signed-off-by: Vishal Thapar <vthapar@redhat.com>
David Suarez [Mon, 2 Apr 2018 22:07:05 +0000 (00:07 +0200)]
Migrate FlowBasedServicesInterfaceStateListener to use new listeners fw
Other minor changes
Change-Id: I480573521a755827dfc2bf6d4608975bd888397f
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Michael Vorburger [Fri, 20 Apr 2018 16:31:18 +0000 (18:31 +0200)]
use MBeanUtils getMBeanAttribute instead deprecated readMBeanAttribute
and handle the possibly thrown exception here in the caller, instead of
burying that in the utility, and (erroneously) returning null to the
caller.
also fix up an unrelated logical error in this
DatastoreServiceStatusProvider which had me scratching my head for a
moment: The volatile ServiceDescriptor field really makes no sense, and
is actually not really needed; it wasn't even used in
getServiceDescriptor() anyway.
Change-Id: I1813d1a7e709b2fb3d4e564de14c0080afa4c000
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Edw7n [Sat, 28 Apr 2018 11:24:37 +0000 (16:54 +0530)]
To fix Elan Junits because of
https://git.opendaylight.org/gerrit/#/c/68397/
Change-Id: I9e2d285e18cea4ec44cfe5794ee5772843708633
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Edw7n [Thu, 19 Apr 2018 04:18:25 +0000 (09:48 +0530)]
Rpc changes for performance enhacements
corresponding netvirt changes:
https://git.opendaylight.org/gerrit/#/c/68187/
Change-Id: I142de600b189ba1e803779a7ba47be714efb4764
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Michael Vorburger [Thu, 19 Apr 2018 12:59:20 +0000 (14:59 +0200)]
replace findbugs' @SuppressWarnings by @SuppressFBWarnings
Change-Id: Iebe8b04c1409a769e91ea545abcbc97e987b7794
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Fri, 20 Apr 2018 08:46:51 +0000 (10:46 +0200)]
fix catch ReadFailedException LOG.debug in TunnelTopologyStateListener
the point of callWithNewWriteOnlyTransactionAndSubmit is that it deals
with and correctly propagates (into the Future, here to the
JobCoordinator) any failures; you're abusing that with the catch.
Change-Id: Icd0d16a6bcbd01b83f1a2200843934160751b76d
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
David Suarez [Sat, 21 Apr 2018 08:17:44 +0000 (10:17 +0200)]
Make new Genius' listeners testable
Make new Genius' listeners testable old ones by implementing the
ChainableDataTreeChangeListener interface.
Change-Id: Ia321ad95956eba717afb3de56c4ef4afb14e771a
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Edw7n [Wed, 25 Apr 2018 03:34:21 +0000 (09:04 +0530)]
Adding API support for ELAN
Support for fetching Interface information from tunnelName
Change-Id: Ibc067c3c05b02fc30cc6bd0e20040457744c3cd4
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
David Suarez [Thu, 19 Apr 2018 19:17:02 +0000 (21:17 +0200)]
Move ChainableDataTreeListener to tools-api
Change-Id: I9401d9a623a0ac141d0f6d03bbf9ce2810da1462
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Robert Varga [Thu, 26 Apr 2018 09:47:14 +0000 (11:47 +0200)]
Add mdsalutil-api and tools-api to artifacts
Downstreams are using properties to declare these versions in
a consistent manner. Add them to artifacts, so that a consistent
set of artifacts can be imported into dependencyManagement.
Change-Id: I020e409c80fc6fff85adb94e6f84381050e6d124
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Tarun Thakur [Fri, 13 Apr 2018 09:31:36 +0000 (15:01 +0530)]
GENIUS-121: TEP with same local & remote IP
TEP is created with same local & remote IP when br-int is removed and added.
Change-Id: Idde1dabad34113ee41cf79a4cab973ba5d10813b
Signed-off-by: Tarun Thakur <tarun.t@altencalsoftlabs.com>
Michael Vorburger [Fri, 6 Apr 2018 19:28:51 +0000 (21:28 +0200)]
increase code quality in tools api/testutils by using infrautils' parent
Change-Id: I7485ce352b452cec2db19c5e726c9bb51438846c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Nobin Mathew [Mon, 16 Apr 2018 09:37:41 +0000 (15:07 +0530)]
AlivenessMonitor pause/stop should work in a cluster
JIRA: GENIUS-126
Change-Id: I464c3d6bdd67ebda2c47cdbb22d69e9b254b28c6
Signed-off-by: Nobin Mathew <nobin.mathew@ericsson.com>
Edw7n [Tue, 24 Apr 2018 06:35:01 +0000 (12:05 +0530)]
Support for ITM direct tunnels in ITM workers
Modified the ItmInternalTunnel Add and Delete workers
to support creation/deletion of tunnels directly by ITM
Fixed issues while testing
Fix for bfd CSIT failure
Change-Id: I1bd9c0edf1f549168d95bc2e7c1e7c3caf6b5967
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Edw7n [Thu, 5 Apr 2018 04:21:29 +0000 (09:51 +0530)]
Updating tunnel status based on tp status update
Update the ITM tunnel status by listening to the termination point status
Fixed issues while testing
Change-Id: I5b9b5389b4a2073d6648b164f2a5975484874ab1
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Edw7n [Wed, 4 Apr 2018 14:59:13 +0000 (20:29 +0530)]
Implemented tunnel state updation
Listening to the inventory DS and create tunnel state information and also
program the ingress flows related to the tunnel
Fixed issues while testing
Change-Id: I83b0b6e95156ad7013cd8b3ff9902dcfed0a35ee
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Code Review / genius.git / log